SalesforceAuth - Code Metrics - Inspection of "Update namespace" - Surge-Financial/laravel-salesforce - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 449a48...6f6236 )

by Ashleigh

created 2017-07-12 08:58 UTC

SalesforceAuth A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	0
dl	0
loc	68
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	isAuthenticated()	0	4	1
A	__construct()	0	6	1

<?php

namespace Surge\LaravelSalesforce;

class SalesforceAuth
{
    /**
     * @var string
     */
    public $id;

    /**
     * @var string
     */
    public $accessToken;

    /**
     * @var string
     */
    public $instanceUrl;

    /**
     * @var string
     */
    public $url;

    /**
     * @var bool
     */
    private $authenticated = false;

    public function isAuthenticated(): bool
    {
        return $this->authenticated;
    }

    public function __construct($client)
    {
        $this->client = $client;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->login();
    }

    /**
     * Login.
     */
    private function login()
    {
        $body = [
            'grant_type'    => 'password',
            'client_id'     => config('sf.client_id'),
            'client_secret' => config('sf.client_secret'),
            'username'      => config('sf.username'),
            'password'      => config('sf.password'),
        ];

        $response = $this->client->post('https://login.salesforce.com/services/oauth2/token', [
            'form_params' => $body,
        ])->getBody()->getContents();

        $responseObject = \GuzzleHttp\json_decode($response);

        $this->id = $responseObject->id;
        $this->accessToken = $responseObject->access_token;
        $this->instanceUrl = $responseObject->instance_url;
        $this->url = $responseObject->instance_url.$this->version['url'];
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if ($this->accessToken !== null) {
            $this->authenticated = true;
        }
    }
}


1			<?php
2
3			namespace Surge\LaravelSalesforce;
4
5			class SalesforceAuth
6			{
7			/**
8			* @var string
9			*/
10			public $id;
11
12			/**
13			* @var string
14			*/
15			public $accessToken;
16
17			/**
18			* @var string
19			*/
20			public $instanceUrl;
21
22			/**
23			* @var string
24			*/
25			public $url;
26
27			/**
28			* @var bool
29			*/
30			private $authenticated = false;
31
32			public function isAuthenticated(): bool
33			{
34			return $this->authenticated;
35			}
36
37			public function __construct($client)
38			{
39			$this->client = $client;
			0 ignored issues – show Bug introduced 2017-07-11 08:29 UTC by Report Bug Copy Issue Report The property `client` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40
41			$this->login();
42			}
43
44			/**
45			* Login.
46			*/
47			private function login()
48			{
49			$body = [
50			'grant_type' => 'password',
51			'client_id' => config('sf.client_id'),
52			'client_secret' => config('sf.client_secret'),
53			'username' => config('sf.username'),
54			'password' => config('sf.password'),
55			];
56
57			$response = $this->client->post('https://login.salesforce.com/services/oauth2/token', [
58			'form_params' => $body,
59			])->getBody()->getContents();
60
61			$responseObject = \GuzzleHttp\json_decode($response);
62
63			$this->id = $responseObject->id;
64			$this->accessToken = $responseObject->access_token;
65			$this->instanceUrl = $responseObject->instance_url;
66			$this->url = $responseObject->instance_url.$this->version['url'];
			0 ignored issues – show Bug introduced 2017-07-11 08:29 UTC by Report Bug Copy Issue Report The property `version` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
67
68			if ($this->accessToken !== null) {
69			$this->authenticated = true;
70			}
71			}
72			}
73

Surge-Financial / laravel-salesforce

Push — master ( 449a48...6f6236 )

SalesforceAuth A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like