PlayStoreInfo::lookup() - Code Metrics - SurajAdsul/appmarket - Measure and Improve Code Quality continuously with Scrutinizer

PlayStoreInfo::lookup() B
last analyzed 2018-05-27 05:24 UTC

↳ Parent: PlayStoreInfo

Complexity

Conditions	3
Paths	1

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	27
rs	8.8571
c	0
b	0
f	0
cc	3
eloc	16
nc	1
nop	0

<?php

namespace SurajAdsul\AppMarket;

class PlayStoreInfo extends AbstractStoreInfo
{
    private static $lookupUrl = 'https://play.google.com/store/apps/details?id=%s';

    /**
     * @return array
     */
    protected function lookup()
    {
        $url = sprintf(self::$lookupUrl, $this->storeId);

        $client = new CrawlerClient();
        $crawler = $client->request('GET', $url);

        $this->name = $crawler->filter('[itemprop="name"]')->text();

        $crawler->filter('div.score-container meta')->each(function ($node) {
            switch ($node->attr('itemprop')) {
                case 'ratingValue':
                    $this->ratingStars = round($node->attr('content'));
$answer = 42;

$correct = false;

$correct = (bool) $answer;
                    break;
                case 'ratingCount':
                    $this->ratingCount = $node->attr('content');
            }
        });

//        $this->contentRating = $crawler->filter('[itemprop="contentRating"]')->text();

        $iconUrl = $crawler->filter('[itemprop="image"]')->attr('src');
        $this->icon = $this->addScheme($iconUrl);

        $crawler->filter('[alt="Screenshot Image"]')->each(function ($node) {
            $this->screenshots[] = $this->addScheme($node->attr('src'));
        });
    }
}


1			<?php
2
3			namespace SurajAdsul\AppMarket;
4
5			class PlayStoreInfo extends AbstractStoreInfo
6			{
7			private static $lookupUrl = 'https://play.google.com/store/apps/details?id=%s';
8
9			/**
10			* @return array
11			*/
12			protected function lookup()
13			{
14			$url = sprintf(self::$lookupUrl, $this->storeId);
15
16			$client = new CrawlerClient();
17			$crawler = $client->request('GET', $url);
18
19			$this->name = $crawler->filter('[itemprop="name"]')->text();
20
21			$crawler->filter('div.score-container meta')->each(function ($node) {
22			switch ($node->attr('itemprop')) {
23			case 'ratingValue':
24			$this->ratingStars = round($node->attr('content'));
			0 ignored issues – show Documentation Bug introduced 2018-05-27 04:51 UTC by Report Bug Copy Issue Report The property `$ratingStars` was declared of type `integer`, but `round($node->attr('content'))` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
25			break;
26			case 'ratingCount':
27			$this->ratingCount = $node->attr('content');
28			}
29			});
30
31			// $this->contentRating = $crawler->filter('[itemprop="contentRating"]')->text();
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-05-27 04:51 UTC by Report Bug Copy Issue Report `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
32			$iconUrl = $crawler->filter('[itemprop="image"]')->attr('src');
33			$this->icon = $this->addScheme($iconUrl);
34
35			$crawler->filter('[alt="Screenshot Image"]')->each(function ($node) {
36			$this->screenshots[] = $this->addScheme($node->attr('src'));
37			});
38			}
39			}
40

SurajAdsul / appmarket

PlayStoreInfo::lookup() B last analyzed 2018-05-27 05:24 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PlayStoreInfo::lookup() B
last analyzed 2018-05-27 05:24 UTC