AppMarket::fetchAppDetails() - Code Metrics - SurajAdsul/appmarket - Measure and Improve Code Quality continuously with Scrutinizer

AppMarket::fetchAppDetails() A
last analyzed 2018-05-27 05:24 UTC

↳ Parent: AppMarket

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	12
nc	3
nop	1

<?php

namespace SurajAdsul\AppMarket;

class AppMarket
{
    const ANDROID_SUBSTRING = '://play.google.com';
    const IOS_REGEX = '/https?:\/\/itunes\.apple\.com\/((?<country>[a-zA-Z]{2})\/)?.+\/id(?<id>\d+)/';
    const PLATFORM_ANDROID = 1;
    const PLATFORM_IOS = 2;

    public function fetchAppDetails($previewUrl)
    {
        $details = $this->mobileAppStore($previewUrl);

        switch ($details['platform']) {
            case self::PLATFORM_IOS:
                $appDetails = new AppStoreInfo($details);
                break;
            case self::PLATFORM_ANDROID:
                $appDetails = new PlayStoreInfo($details);
                break;
            default:
                throw new \Exception();
        }

        return $appDetails;
    }

    private function mobileAppStore($previewUrl, $withCountry = false)

    {
        $storeId = null;
        $platform = null;
        $country = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $matches = [];

        if (strpos($previewUrl, self::ANDROID_SUBSTRING) !== false) {
            $request = new \GuzzleHttp\Psr7\Request('GET', $previewUrl);
            parse_str($request->getUri()->getQuery(), $output);
            $storeId = $output['id'] ?: null;
            $platform = self::PLATFORM_ANDROID;
        } elseif (preg_match(self::IOS_REGEX, $previewUrl, $matches)) {
            $storeId = ! empty($matches['id']) ? $matches['id'] : null;
            $platform = self::PLATFORM_IOS;
        }

        $data = [
            'storeId' => $storeId,
            'platform' => $platform,
        ];

        return $data;
    }
}


1			<?php
2
3			namespace SurajAdsul\AppMarket;
4
5			class AppMarket
6			{
7			const ANDROID_SUBSTRING = '://play.google.com';
8			const IOS_REGEX = '/https?:\/\/itunes\.apple\.com\/((?<country>[a-zA-Z]{2})\/)?.+\/id(?<id>\d+)/';
9			const PLATFORM_ANDROID = 1;
10			const PLATFORM_IOS = 2;
11
12			public function fetchAppDetails($previewUrl)
13			{
14			$details = $this->mobileAppStore($previewUrl);
15
16			switch ($details['platform']) {
17			case self::PLATFORM_IOS:
18			$appDetails = new AppStoreInfo($details);
19			break;
20			case self::PLATFORM_ANDROID:
21			$appDetails = new PlayStoreInfo($details);
22			break;
23			default:
24			throw new \Exception();
25			}
26
27			return $appDetails;
28			}
29
30			private function mobileAppStore($previewUrl, $withCountry = false)
			0 ignored issues – show Unused Code introduced 2018-05-27 04:51 UTC by Report Bug Copy Issue Report The parameter `$withCountry` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
31			{
32			$storeId = null;
33			$platform = null;
34			$country = null;
			0 ignored issues – show Unused Code introduced 2018-05-27 04:51 UTC by Report Bug Copy Issue Report `$country` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35			$matches = [];
36
37			if (strpos($previewUrl, self::ANDROID_SUBSTRING) !== false) {
38			$request = new \GuzzleHttp\Psr7\Request('GET', $previewUrl);
39			parse_str($request->getUri()->getQuery(), $output);
40			$storeId = $output['id'] ?: null;
41			$platform = self::PLATFORM_ANDROID;
42			} elseif (preg_match(self::IOS_REGEX, $previewUrl, $matches)) {
43			$storeId = ! empty($matches['id']) ? $matches['id'] : null;
44			$platform = self::PLATFORM_IOS;
45			}
46
47			$data = [
48			'storeId' => $storeId,
49			'platform' => $platform,
50			];
51
52			return $data;
53			}
54			}
55

SurajAdsul / appmarket

AppMarket::fetchAppDetails() A last analyzed 2018-05-27 05:24 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

AppMarket::fetchAppDetails() A
last analyzed 2018-05-27 05:24 UTC