TenantRepository - Code Metrics - Inspection of "Resolve tenant from domain and subdomain+domain." - SuperdeskWebPublisher/SWPMultiTenancyBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6718d9...b5055a )

by Rafał

created 2017-03-06 11:13 UTC

TenantRepository A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	34.78 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	4
c	2
b	0
f	0
lcom	1
cbo	5
dl	16
loc	46
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	findOneBySubdomainAndDomain()	8	8	1
A	findOneByDomain()	8	8	1
A	findOneByCode()	0	6	1
A	findAvailableTenants()	0	6	1

How to fix Duplicated Code

<?php

/*
 * This file is part of the Superdesk Web Publisher MultiTenancy Bundle.
 *
 * Copyright 2016 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2016 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\MultiTenancyBundle\Doctrine\PHPCR;

use SWP\Bundle\StorageBundle\Doctrine\ODM\PHPCR\DocumentRepository;
use SWP\Component\MultiTenancy\Repository\TenantRepositoryInterface;

class TenantRepository extends DocumentRepository implements TenantRepositoryInterface

{
    /**
     * {@inheritdoc}
     */
    public function findOneBySubdomainAndDomain($subdomain, $domain)

    {
        $qb = $this->createQueryBuilder('t');
        $qb->where()->eq()->field('t.subdomain')->literal($subdomain);
        $qb->andWhere()->eq()->field('t.domainName')->literal($domain);

        return $qb->getQuery()->getOneOrNullResult();

    }

    /**
     * {@inheritdoc}
     */
    public function findOneByDomain($domain)

    {
        $qb = $this->createQueryBuilder('t');
        $qb->where()->eq()->field('t.domainName')->literal($domain);
        $qb->andWhere()->eq()->field('t.subdomain')->literal(null);

        return $qb->getQuery()->getOneOrNullResult();

    }

    /**
     * {@inheritdoc}
     */
    public function findOneByCode($code)
    {
        return $this->findOneBy([
            'code' => $code,
        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function findAvailableTenants()
    {
        return $this
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            ->createQueryBuilder('t')
            ->getQuery();
    }
}


1		<?php
2
3		/*
4		* This file is part of the Superdesk Web Publisher MultiTenancy Bundle.
5		*
6		* Copyright 2016 Sourcefabric z.ú. and contributors.
7		*
8		* For the full copyright and license information, please see the
9		* AUTHORS and LICENSE files distributed with this source code.
10		*
11		* @copyright 2016 Sourcefabric z.ú
12		* @license http://www.superdesk.org/license
13		*/
14
15		namespace SWP\Bundle\MultiTenancyBundle\Doctrine\PHPCR;
16
17		use SWP\Bundle\StorageBundle\Doctrine\ODM\PHPCR\DocumentRepository;
18		use SWP\Component\MultiTenancy\Repository\TenantRepositoryInterface;
19
20		class TenantRepository extends DocumentRepository implements TenantRepositoryInterface
		0 ignored issues – show Bug introduced 2017-03-06 11:28 UTC by Report Bug Copy Issue Report There is one abstract method `findOneBySubdomain` in this class; you could implement it, or declare this class as abstract. Loading history...
21		{
22		/**
23		* {@inheritdoc}
24		*/
25	View Code Duplication	public function findOneBySubdomainAndDomain($subdomain, $domain)
		0 ignored issues – show Duplication introduced 2017-03-06 11:28 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		{
27		$qb = $this->createQueryBuilder('t');
28		$qb->where()->eq()->field('t.subdomain')->literal($subdomain);
29		$qb->andWhere()->eq()->field('t.domainName')->literal($domain);
30
31		return $qb->getQuery()->getOneOrNullResult();
		0 ignored issues – show Bug introduced 2016-09-26 08:37 UTC by Report Bug Copy Issue Report The method `getOneOrNullResult()` does not seem to exist on `object<PHPCR\Query\QueryInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
32		}
33
34		/**
35		* {@inheritdoc}
36		*/
37	View Code Duplication	public function findOneByDomain($domain)
		0 ignored issues – show Duplication introduced 2017-03-06 11:28 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		$qb = $this->createQueryBuilder('t');
40		$qb->where()->eq()->field('t.domainName')->literal($domain);
41		$qb->andWhere()->eq()->field('t.subdomain')->literal(null);
42
43		return $qb->getQuery()->getOneOrNullResult();
		0 ignored issues – show Bug introduced 2017-03-06 11:28 UTC by Report Bug Copy Issue Report The method `getOneOrNullResult()` does not seem to exist on `object<PHPCR\Query\QueryInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
44		}
45
46		/**
47		* {@inheritdoc}
48		*/
49		public function findOneByCode($code)
50		{
51		return $this->findOneBy([
52		'code' => $code,
53		]);
54		}
55
56		/**
57		* {@inheritdoc}
58		*/
59		public function findAvailableTenants()
60		{
61		return $this
		0 ignored issues – show Bug Best Practice introduced 2016-08-18 10:11 UTC by Report Bug Copy Issue Report The return type of `return $this->createQuer...ilder('t')->getQuery();` (`PHPCR\Query\QueryInterface`) is incompatible with the return type declared by the interface `SWP\Component\MultiTenan...e::findAvailableTenants` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
62		->createQueryBuilder('t')
63		->getQuery();
64		}
65		}
66

SuperdeskWebPublisher / SWPMultiTenancyBundle

Push — master ( 6718d9...b5055a )

TenantRepository A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like