SimpleXmlReader\ExceptionThrowingXMLReader

Complexity

Total Complexity

11

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	7
Bugs	2	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	open()	0	4	1
A	ensureSuccess()	0	7	2
A	expand()	0	8	2
A	read()	0	4	1
A	tryRead()	0	5	1
A	next()	0	8	2
A	tryNext()	0	9	2

<?php

namespace SimpleXmlReader;

use DOMNode;
use XMLReader;

class ExceptionThrowingXMLReader extends XMLReader
{
    public function open($URI, $encoding = null, $options = 0)
    {
        return static::ensureSuccess(@parent::open($URI, $encoding, $options), 'open');
    }

    static protected function ensureSuccess($returnValue, $operation)
    {
        if (! $returnValue) {
            throw new XmlException("Error while performing XMLReader::$operation");
        }
        return $returnValue;
    }

    public function expand(DOMNode $baseNode = null)
    {
        if (null === $baseNode) {
            return static::ensureSuccess(@parent::expand(), 'expend');
        } else {
            return static::ensureSuccess(@parent::expand($baseNode), 'expend');
        }
    }

    public function read()
    {
        return static::ensureSuccess(@parent::read(), 'read');
    }

    public function tryRead()
    {
        // We're ignoring any PHP errors, as we are trying to read
        return @parent::read();

It seems like you call parent on a different method (read() instead of tryRead()). Are you sure this is correct? If so, you might want to change this to $this->read().

    }

    public function next($localName = null)
    {
        if (null === $localName) {
            return static::ensureSuccess(@parent::next(), 'next');
        }

        return static::ensureSuccess(@parent::next($localName), 'next');
    }

    public function tryNext($localName = null)
    {
        // We're ignoring any PHP errors, as we are trying to fetch the next element
        if (null === $localName) {
            return @parent::next();

It seems like you call parent on a different method (next() instead of tryNext()). Are you sure this is correct? If so, you might want to change this to $this->next().

        }

        return @parent::next($localName);

It seems like you call parent on a different method (next() instead of tryNext()). Are you sure this is correct? If so, you might want to change this to $this->next().

    }
}