UniqueIterator::accept() - Code Metrics - SuRaMoN/itertools - Measure and Improve Code Quality continuously with Scrutinizer

UniqueIterator::accept() A
last analyzed 2020-05-28 15:38 UTC

↳ Parent: UniqueIterator

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	3
nc	3
nop	0

<?php

namespace itertools;

use InvalidArgumentException;
use FilterIterator;


class UniqueIterator extends FilterIterator
{
	const COMPARE_STRICT = 'COMPARE_STRICT';
	const COMPARE_NONSTRICT = 'COMPARE_NONSTRICT';

	protected $options;

	public function __construct($iterator, $options = array())
	{
		parent::__construct(new HistoryIterator($iterator));

		$defaultOptions = array(
			'compareType' => self::COMPARE_STRICT,
		);

		$unknownOptions = array_diff(array_keys($options), array_keys($defaultOptions));
		if(count($unknownOptions) != 0) {
			throw new InvalidArgumentException('Unknown options specified: ' . implode(', ', $unknownOptions));
		}

		$this->options = array_merge($defaultOptions, $options);
	}

	public function accept()
	{
		if(!$this->getInnerIterator()->hasPrev()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			return true;
		}
		if($this->options['compareType'] == self::COMPARE_STRICT) {
			return $this->current() !== $this->getInnerIterator()->prev();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		} else {
			return $this->current() != $this->getInnerIterator()->prev();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		}
	}
}
 


1			<?php
2
3			namespace itertools;
4
5			use InvalidArgumentException;
6			use FilterIterator;
7
8
9			class UniqueIterator extends FilterIterator
10			{
11			const COMPARE_STRICT = 'COMPARE_STRICT';
12			const COMPARE_NONSTRICT = 'COMPARE_NONSTRICT';
13
14			protected $options;
15
16			public function __construct($iterator, $options = array())
17			{
18			parent::__construct(new HistoryIterator($iterator));
19
20			$defaultOptions = array(
21			'compareType' => self::COMPARE_STRICT,
22			);
23
24			$unknownOptions = array_diff(array_keys($options), array_keys($defaultOptions));
25			if(count($unknownOptions) != 0) {
26			throw new InvalidArgumentException('Unknown options specified: ' . implode(', ', $unknownOptions));
27			}
28
29			$this->options = array_merge($defaultOptions, $options);
30			}
31
32			public function accept()
33			{
34			if(!$this->getInnerIterator()->hasPrev()) {
			0 ignored issues – show Bug introduced 2015-11-27 15:17 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Iterator` as the method `hasPrev()` does only exist in the following implementations of said interface: `SQLiteResult`, `itertools\HistoryIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
35			return true;
36			}
37			if($this->options['compareType'] == self::COMPARE_STRICT) {
38			return $this->current() !== $this->getInnerIterator()->prev();
			0 ignored issues – show Bug introduced 2015-11-27 15:17 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Iterator` as the method `prev()` does only exist in the following implementations of said interface: `SQLiteResult`, `SplDoublyLinkedList`, `SplQueue`, `SplStack`, `itertools\HistoryIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
39			} else {
40			return $this->current() != $this->getInnerIterator()->prev();
			0 ignored issues – show Bug introduced 2015-11-27 15:17 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Iterator` as the method `prev()` does only exist in the following implementations of said interface: `SQLiteResult`, `SplDoublyLinkedList`, `SplQueue`, `SplStack`, `itertools\HistoryIterator`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
41			}
42			}
43			}
44
45

SuRaMoN / itertools

UniqueIterator::accept() A last analyzed 2020-05-28 15:38 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

UniqueIterator::accept() A
last analyzed 2020-05-28 15:38 UTC