CurrentCachedIterator::__construct() - Code Metrics - SuRaMoN/itertools - Measure and Improve Code Quality continuously with Scrutinizer

CurrentCachedIterator::__construct() A
last analyzed 2020-05-28 15:38 UTC

↳ Parent: CurrentCachedIterator

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace itertools;

use IteratorIterator;


class CurrentCachedIterator extends IteratorIterator
{
	protected $cachedCurrent;
	protected $currentUpToDate;
	protected $cachedValid;
	protected $validUpToDate;

	public function __construct($innerIterator)
	{
		parent::__construct(IterUtil::asIterator($innerIterator));
		$this->currentUpToDate = false;
		$this->validUpToDate = false;
	}

	public function invalidateCache()
	{
		$this->currentUpToDate = false;
		$this->validUpToDate = false;
	}

    public function rewind()
	{
		$this->invalidateCache();
		return parent::rewind();
    }

	public function uncachedCurrent()
	{
		return parent::current();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
	}

    public function current()
	{
		if(!$this->currentUpToDate) {
			$this->cachedCurrent = $this->uncachedCurrent();
			$this->currentUpToDate = true;
		}
        return $this->cachedCurrent;
    }

    public function next()
	{
		$this->invalidateCache();
		return parent::next();
    }

	public function uncachedValid()
	{
		return parent::valid();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
	}

    public function valid()
	{
		if($this->validUpToDate) {
			return $this->cachedValid;
		}
		$this->validUpToDate = true;
        return $this->cachedValid = $this->uncachedValid();
    }
}



1			<?php
2
3			namespace itertools;
4
5			use IteratorIterator;
6
7
8			class CurrentCachedIterator extends IteratorIterator
9			{
10			protected $cachedCurrent;
11			protected $currentUpToDate;
12			protected $cachedValid;
13			protected $validUpToDate;
14
15			public function __construct($innerIterator)
16			{
17			parent::__construct(IterUtil::asIterator($innerIterator));
18			$this->currentUpToDate = false;
19			$this->validUpToDate = false;
20			}
21
22			public function invalidateCache()
23			{
24			$this->currentUpToDate = false;
25			$this->validUpToDate = false;
26			}
27
28			public function rewind()
29			{
30			$this->invalidateCache();
31			return parent::rewind();
32			}
33
34			public function uncachedCurrent()
35			{
36			return parent::current();
			0 ignored issues – show Comprehensibility Bug introduced 2015-11-27 15:17 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`current()` instead of `uncachedCurrent()`). Are you sure this is correct? If so, you might want to change this to `$this->current()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
37			}
38
39			public function current()
40			{
41			if(!$this->currentUpToDate) {
42			$this->cachedCurrent = $this->uncachedCurrent();
43			$this->currentUpToDate = true;
44			}
45			return $this->cachedCurrent;
46			}
47
48			public function next()
49			{
50			$this->invalidateCache();
51			return parent::next();
52			}
53
54			public function uncachedValid()
55			{
56			return parent::valid();
			0 ignored issues – show Comprehensibility Bug introduced 2015-11-27 15:17 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`valid()` instead of `uncachedValid()`). Are you sure this is correct? If so, you might want to change this to `$this->valid()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
57			}
58
59			public function valid()
60			{
61			if($this->validUpToDate) {
62			return $this->cachedValid;
63			}
64			$this->validUpToDate = true;
65			return $this->cachedValid = $this->uncachedValid();
66			}
67			}
68
69

SuRaMoN / itertools

CurrentCachedIterator::__construct() A last analyzed 2020-05-28 15:38 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CurrentCachedIterator::__construct() A
last analyzed 2020-05-28 15:38 UTC