Studioforty9_Recaptcha_Helper_Request

Complexity

Total Complexity

7

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setHttpClient()	0	6	1
A	getHttpClient()	0	10	2
B	verify()	0	26	3
A	_getHelper()	0	4	1

<?php
/**
 * Studioforty9_Recaptcha
 *
 * @category  Studioforty9
 * @package   Studioforty9_Recaptcha
 * @author    StudioForty9 <info@studioforty9.com>
 * @copyright 2015 StudioForty9 (http://www.studioforty9.com)
 * @license   https://github.com/studioforty9/recaptcha/blob/master/LICENCE BSD
 * @version   1.5.7
 * @link      https://github.com/studioforty9/recaptcha
 */

/**
 * Studioforty9_Recaptcha_Helper_Request
 *
 * @category   Studioforty9
 * @package    Studioforty9_Recaptcha
 * @subpackage Helper
 * @author     StudioForty9 <info@studioforty9.com>
 */
class Studioforty9_Recaptcha_Helper_Request extends Mage_Core_Helper_Abstract
{
    const REQUEST_URL = 'https://www.google.com/recaptcha/api/siteverify';
    const REQUEST_RESPONSE = 'g-recaptcha-response';

    /**
     * @var Varien_Http_Client $_client
     */
    protected $_client;

    /**
     * Set the client to make the request to recaptca.
     *
     * @param Varien_Http_Client $client The http client to use
     *
     * @return $this
     */
    public function setHttpClient(Varien_Http_Client $client)
    {
        $this->_client = $client;
        
        return $this;
    }

    /**
     * Get the Http Client to use for the request to reCAPTCHA
     *
     * @return Zend_Http_Client
     */
    public function getHttpClient()
    {
        if (is_null($this->_client)) {
            $this->_client = new Zend_Http_Client();

It seems like new \Zend_Http_Client() of type object<Zend_Http_Client> is incompatible with the declared type object<Varien_Http_Client> of property $_client.

        }
        
        $this->_client->setUri(self::REQUEST_URL);

        return $this->_client;

The expression $this->_client; of type Zend_Http_Client|Varien_Http_Client adds the type Varien_Http_Client to the return on line 59 which is incompatible with the return type documented by Studioforty9_Recaptcha_Helper_Request::getHttpClient of type Zend_Http_Client.

    }

    /**
     * Verify the details of the recaptcha request.
     *
     * @return Studioforty9_Recaptcha_Helper_Response
     */
    public function verify()
    {
        $params = array(
            'secret'   => $this->_getHelper()->getSecretKey(),
            'response' => $this->_getRequest()->getPost(self::REQUEST_RESPONSE),
            'remoteip' => $this->_getRequest()->getClientIp(true),
        );
        
        $client = $this->getHttpClient();
        $client->setParameterPost($params);
        $errors = array();

        try {
            $response = $client->request('POST');
            $body = $response->getBody();
            $data = Mage::helper('core')->jsonDecode($body);
            if (array_key_exists('error-codes', $data)) {
                $errors = $data['error-codes'];
            }
        } catch (Exception $e) {
            Mage::logException($e);
            $data = array('success' => false);
        }

        return new Studioforty9_Recaptcha_Helper_Response($data['success'], $errors);
    }

    /**
     * Get the module data helper.
     *
     * @codeCoverageIgnore
     * @return Studioforty9_Recaptcha_Helper_Data
     */
    protected function _getHelper()
    {
        return Mage::helper('studioforty9_recaptcha');
    }
}