KernelResponseListener::__construct() - Code Metrics - Strontium-90/StrontiumPjaxBundle - Measure and Improve Code Quality continuously with Scrutinizer

KernelResponseListener::__construct() A
last analyzed 2016-07-28 11:18 UTC

↳ Parent: KernelResponseListener

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php
namespace Strontium\PjaxBundle\EventListener;

use Strontium\PjaxBundle\Helper\PjaxHelperInterface;
use Symfony\Component\HttpFoundation\Cookie;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;

class KernelResponseListener
{
    /**
     * @var PjaxHelperInterface
     */
    protected $pjax;

    /**
     * @param PjaxHelperInterface $pjax
     */
    public function __construct(PjaxHelperInterface $pjax)
    {
        $this->pjax = $pjax;
    }

    /**
     * @param FilterResponseEvent $event
     */
    public function addPjaxVersion(FilterResponseEvent $event)
    {
        $request = $event->getRequest();

        if ($this->pjax->isPjaxRequest($request) && $this->pjax->haveGenerator()) {
            $response = $event->getResponse();
            $response->headers->set('X-PJAX-Version', $this->pjax->generateVersion($request));
        }
    }

    /**
     * @param FilterResponseEvent $event
     *
     * @return Response
     */
    public function pjaxRedirect(FilterResponseEvent $event)
    {
        $request = $event->getRequest();
        $response = $event->getResponse();

        if ($this->pjax->isPjaxRequest($request) && $response->isRedirect()) {
            $redirectCookieName = sprintf('pjax_redirect_%s', $request->headers->get('X-PJAX-Target'));
            $redirectTo = $response->headers->get('Location');
            $response->headers->setCookie(
                new Cookie(rawurlencode($redirectCookieName), $redirectTo, 0, '/', null, false, false)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            );
        }

        return $response;
    }
}


1			<?php
2			namespace Strontium\PjaxBundle\EventListener;
3
4			use Strontium\PjaxBundle\Helper\PjaxHelperInterface;
5			use Symfony\Component\HttpFoundation\Cookie;
6			use Symfony\Component\HttpFoundation\Response;
7			use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
8
9			class KernelResponseListener
10			{
11			/**
12			* @var PjaxHelperInterface
13			*/
14			protected $pjax;
15
16			/**
17			* @param PjaxHelperInterface $pjax
18			*/
19			public function __construct(PjaxHelperInterface $pjax)
20			{
21			$this->pjax = $pjax;
22			}
23
24			/**
25			* @param FilterResponseEvent $event
26			*/
27			public function addPjaxVersion(FilterResponseEvent $event)
28			{
29			$request = $event->getRequest();
30
31			if ($this->pjax->isPjaxRequest($request) && $this->pjax->haveGenerator()) {
32			$response = $event->getResponse();
33			$response->headers->set('X-PJAX-Version', $this->pjax->generateVersion($request));
34			}
35			}
36
37			/**
38			* @param FilterResponseEvent $event
39			*
40			* @return Response
41			*/
42			public function pjaxRedirect(FilterResponseEvent $event)
43			{
44			$request = $event->getRequest();
45			$response = $event->getResponse();
46
47			if ($this->pjax->isPjaxRequest($request) && $response->isRedirect()) {
48			$redirectCookieName = sprintf('pjax_redirect_%s', $request->headers->get('X-PJAX-Target'));
49			$redirectTo = $response->headers->get('Location');
50			$response->headers->setCookie(
51			new Cookie(rawurlencode($redirectCookieName), $redirectTo, 0, '/', null, false, false)
			0 ignored issues – show Bug introduced 2016-07-08 10:43 UTC by Report Bug Copy Issue Report It seems like `$redirectTo` defined by `$response->headers->get('Location')` on line `49` can also be of type `array`; however, `Symfony\Component\HttpFo...n\Cookie::__construct()` does only seem to accept `string\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
52			);
53			}
54
55			return $response;
56			}
57			}
58

Strontium-90 / StrontiumPjaxBundle

GitHub Access Token became invalid

KernelResponseListener::__construct() A last analyzed 2016-07-28 11:18 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

KernelResponseListener::__construct() A
last analyzed 2016-07-28 11:18 UTC