Strikewood / omnipay-first-atlantic-commerce

src/CreditCard.php

<?php

namespace Omnipay\FirstAtlanticCommerce;

use Omnipay\Common\CreditCard as BaseCreditCard;
use Omnipay\Common\Exception\InvalidCreditCardException;

class CreditCard extends BaseCreditCard
{
    /**
     * Validate this credit card. If the card is invalid, InvalidCreditCardException is thrown.
     *
     * This method is called internally by gateways to avoid wasting time with an API call
     * when the credit card is clearly invalid.
     *
     * Falls back to validating number, cvv, expiryMonth, expiryYear if no parameters are present.
     *
     * @param string ... Optional variable length list of required parameters
     * @throws InvalidCreditCardException
     */
    public function validate()
    {
        $parameters = func_get_args();

        if ( count($parameters) == 0 )

Found "== 0". Use Yoda Condition checks, you must

Opening brace should be on the same line as the declaration

        {
            $parameters = ['number', 'cvv', 'expiryMonth', 'expiryYear'];
        }

        foreach ($parameters as $key)

No space after opening parenthesis is prohibited

Opening brace should be on the same line as the declaration

No space before closing parenthesis is prohibited

        {
            $value = $this->parameters->get($key);

            if ( empty($value) )

Opening brace should be on the same line as the declaration

            {
                throw new InvalidCreditCardException("The $key parameter is required");
            }
        }

        if ( isset($parameters['expiryMonth']) && isset($parameters['expiryYear']) )

Opening brace should be on the same line as the declaration

        {
            if ( $this->getExpiryDate('Ym') < gmdate('Ym') )

Opening brace should be on the same line as the declaration

            {
                throw new InvalidCreditCardException('Card has expired');
            }
        }

        if ( isset($parameters['number']) )

Opening brace should be on the same line as the declaration

        {
            if ( !Helper::validateLuhn( $this->getNumber() ) )

Opening brace should be on the same line as the declaration

Expected 1 space after "!"; 0 found

            {
                throw new InvalidCreditCardException('Card number is invalid');
            }

            if ( !is_null( $this->getNumber() ) && !preg_match( '/^\d{12,19}$/i', $this->getNumber() ) )

Opening brace should be on the same line as the declaration

Expected 1 space after "!"; 0 found

            {
                throw new InvalidCreditCardException('Card number should have 12 to 19 digits');
            }
        }

        if ( isset($parameters['cvv']) )

Opening brace should be on the same line as the declaration

        {
            if ( !is_null( $this->getCvv() ) && !preg_match( '/^\d{3,4}$/i', $this->getCvv() ) )

Opening brace should be on the same line as the declaration

Expected 1 space after "!"; 0 found

            {
                throw new InvalidCreditCardException('Card CVV should have 3 to 4 digits');
            }
        }
    }
}