Strikewood / omnipay-first-atlantic-commerce

src/Message/UpdateCardResponse.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
      * @param RequestInterface $request
      * @param string $data
      */
-    public function __construct(RequestInterface $request, $data)
+    public function __construct( RequestInterface $request, $data )
     {
         if ( empty($data) )
         {
@@ -25,7 +25,7 @@ 
         }
 
         $this->request = $request;
-        $this->data    = $this->xmlDeserialize($data);
+        $this->data    = $this->xmlDeserialize( $data );
     }
 
     /**

Braces +6 added lines, -12 removed lines

@@ -9,18 +9,15 @@ 
 /**
  * FACPG2 XML Update Token Response
  */
-class UpdateCardResponse extends AbstractResponse
-{
+class UpdateCardResponse extends AbstractResponse {
     /**
      * Constructor
      *
      * @param RequestInterface $request
      * @param string $data
      */
-    public function __construct(RequestInterface $request, $data)
-    {
-        if ( empty($data) )
-        {
+    public function __construct(RequestInterface $request, $data) {
+        if ( empty($data) ) {
             throw new InvalidResponseException();
         }
 
@@ -33,8 +30,7 @@ 
      *
      * @return boolean
      */
-    public function isSuccessful()
-    {
+    public function isSuccessful() {
         return isset($this->data['Success']) && 'true' === $this->data['Success'];
     }
 
@@ -43,8 +39,7 @@ 
      *
      * @return string
      */
-    public function getMessage()
-    {
+    public function getMessage() {
         return isset($this->data['ErrorMsg']) && !empty($this->data['ErrorMsg']) ? $this->data['ErrorMsg'] : null;
     }
 
@@ -53,8 +48,7 @@ 
      *
      * @return string
      */
-    public function getCardReference()
-    {
+    public function getCardReference() {
         return isset($this->data['TokenPAN']) ? $this->data['TokenPAN'] : null;
     }
 

src/Message/AuthorizeResponse.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
      * @param RequestInterface $request
      * @param string $data
      */
-    public function __construct(RequestInterface $request, $data)
+    public function __construct( RequestInterface $request, $data )
     {
         if ( empty($data) )
         {
@@ -25,7 +25,7 @@ 
         }
 
         $this->request = $request;
-        $this->data    = $this->xmlDeserialize($data);
+        $this->data    = $this->xmlDeserialize( $data );
 
         $this->verifySignature();
     }
@@ -48,10 +48,10 @@ 
             $signature .= $this->request->getAcquirerId();
             $signature .= $this->request->getTransactionId();
 
-            $signature  = base64_encode( sha1($signature, true) );
+            $signature  = base64_encode( sha1( $signature, true ) );
 
             if ( $signature !== $this->data['Signature'] ) {
-                throw new InvalidResponseException('Signature verification failed');
+                throw new InvalidResponseException( 'Signature verification failed' );
             }
         }
     }

Braces +9 added lines, -18 removed lines

@@ -9,18 +9,15 @@ 
 /**
  * FACPG2 XML Authorize Response
  */
-class AuthorizeResponse extends AbstractResponse
-{
+class AuthorizeResponse extends AbstractResponse {
     /**
      * Constructor
      *
      * @param RequestInterface $request
      * @param string $data
      */
-    public function __construct(RequestInterface $request, $data)
-    {
-        if ( empty($data) )
-        {
+    public function __construct(RequestInterface $request, $data) {
+        if ( empty($data) ) {
             throw new InvalidResponseException();
         }
 
@@ -37,12 +34,10 @@ 
      *
      * @return void
      */
-    public function verifySignature()
-    {
+    public function verifySignature() {
         if ( isset($this->data['CreditCardTransactionResults']['ResponseCode']) && (
             '1' == $this->data['CreditCardTransactionResults']['ResponseCode'] ||
-            '2' == $this->data['CreditCardTransactionResults']['ResponseCode']) )
-        {
+            '2' == $this->data['CreditCardTransactionResults']['ResponseCode']) ) {
             $signature  = $this->request->getMerchantPassword();
             $signature .= $this->request->getMerchantId();
             $signature .= $this->request->getAcquirerId();
@@ -61,8 +56,7 @@ 
      *
      * @return boolean
      */
-    public function isSuccessful()
-    {
+    public function isSuccessful() {
         return isset($this->data['CreditCardTransactionResults']['ResponseCode']) && '1' === $this->data['CreditCardTransactionResults']['ResponseCode'];
     }
 
@@ -71,8 +65,7 @@ 
      *
      * @return string
      */
-    public function getCode()
-    {
+    public function getCode() {
         return isset($this->data['CreditCardTransactionResults']['ReasonCode']) ? $this->data['CreditCardTransactionResults']['ReasonCode'] : null;
     }
 
@@ -81,8 +74,7 @@ 
      *
      * @return string
      */
-    public function getMessage()
-    {
+    public function getMessage() {
         return isset($this->data['CreditCardTransactionResults']['ReasonCodeDescription']) ? $this->data['CreditCardTransactionResults']['ReasonCodeDescription'] : null;
     }
 
@@ -91,8 +83,7 @@ 
      *
      * @return string
      */
-    public function getTransactionReference()
-    {
+    public function getTransactionReference() {
         return isset($this->data['CreditCardTransactionResults']['ReferenceNumber']) ? $this->data['CreditCardTransactionResults']['ReferenceNumber'] : null;
     }
 }

src/Message/StatusResponse.php

Spacing +2 added lines, -2 removed lines

@@ -17,14 +17,14 @@
      * @param RequestInterface $request
      * @param string $data
      */
-    public function __construct(RequestInterface $request, $data)
+    public function __construct( RequestInterface $request, $data )
     {
         if ( empty($data) ) {
             throw new InvalidResponseException();
         }
 
         $this->request = $request;
-        $this->data    = $this->xmlDeserialize($data);
+        $this->data    = $this->xmlDeserialize( $data );
     }
 
     /**

Braces +5 added lines, -10 removed lines

@@ -9,16 +9,14 @@ 
 /**
  * FACPG2 Transaction Status Response
  */
-class StatusResponse extends AbstractResponse
-{
+class StatusResponse extends AbstractResponse {
     /**
      * Constructor
      *
      * @param RequestInterface $request
      * @param string $data
      */
-    public function __construct(RequestInterface $request, $data)
-    {
+    public function __construct(RequestInterface $request, $data) {
         if ( empty($data) ) {
             throw new InvalidResponseException();
         }
@@ -32,8 +30,7 @@ 
      *
      * @return boolean
      */
-    public function isSuccessful()
-    {
+    public function isSuccessful() {
         return isset($this->data['ResponseCode']) && '1' === $this->data['ResponseCode'];
     }
 
@@ -42,8 +39,7 @@ 
      *
      * @return string
      */
-    public function getMessage()
-    {
+    public function getMessage() {
         return isset($this->data['ReasonCodeDescription']) ? $this->data['ReasonCodeDescription'] : null;
     }
 
@@ -52,8 +48,7 @@ 
      *
      * @return string
      */
-    public function getTransactionReference()
-    {
+    public function getTransactionReference() {
         return isset($this->data['ReferenceNumber']) ? $this->data['ReferenceNumber'] : null;
     }
 }

src/Message/UpdateCardRequest.php

Spacing +9 added lines, -9 removed lines

@@ -26,7 +26,7 @@ 
         $signature .= $this->getMerchantId();
         $signature .= $this->getAcquirerId();
 
-        return base64_encode( sha1($signature, true) );
+        return base64_encode( sha1( $signature, true ) );
     }
 
     /**
@@ -36,12 +36,12 @@ 
      */
     public function getData()
     {
-        $this->validate('merchantId', 'merchantPassword', 'acquirerId', 'customerReference', 'cardReference', 'card');
+        $this->validate( 'merchantId', 'merchantPassword', 'acquirerId', 'customerReference', 'cardReference', 'card' );
         $this->getCard()->validate();
 
         $data = [
             'CustomerReference' => $this->getCustomerReference(),
-            'ExpiryDate'        => $this->getCard()->getExpiryDate('my'),
+            'ExpiryDate'        => $this->getCard()->getExpiryDate( 'my' ),
             'MerchantNumber'    => $this->getMerchantId(),
             'Signature'         => $this->generateSignature(),
             'TokenPAN'          => $this->getCardReference()
@@ -57,7 +57,7 @@ 
      */
     public function getCustomerReference()
     {
-        return $this->getParameter('customerReference');
+        return $this->getParameter( 'customerReference' );
     }
 
     /**
@@ -65,9 +65,9 @@ 
      *
      * @param string $value
      */
-    public function setCustomerReference($value)
+    public function setCustomerReference( $value )
     {
-        return $this->setParameter('customerReference', $value);
+        return $this->setParameter( 'customerReference', $value );
     }
 
     /**
@@ -77,7 +77,7 @@ 
      */
     protected function getEndpoint()
     {
-        return parent::getEndpoint() . 'UpdateToken';
+        return parent::getEndpoint().'UpdateToken';
     }
 
     /**
@@ -87,9 +87,9 @@ 
      *
      * @return UpdateCardResponse
      */
-    protected function newResponse($xml)
+    protected function newResponse( $xml )
     {
-        return new UpdateCardResponse($this, $xml);
+        return new UpdateCardResponse( $this, $xml );
     }
 
 }

Braces +7 added lines, -14 removed lines

@@ -7,8 +7,7 @@ 
 /**
  * FACPG2 Update Token Request
  */
-class UpdateCardRequest extends AbstractRequest
-{
+class UpdateCardRequest extends AbstractRequest {
     /**
      * @var string;
      */
@@ -20,8 +19,7 @@ 
      * @return string base64 encoded sha1 hash of the merchantPassword, merchantId,
      *    and acquirerId.
      */
-    protected function generateSignature()
-    {
+    protected function generateSignature() {
         $signature  = $this->getMerchantPassword();
         $signature .= $this->getMerchantId();
         $signature .= $this->getAcquirerId();
@@ -34,8 +32,7 @@ 
      *
      * @return array
      */
-    public function getData()
-    {
+    public function getData() {
         $this->validate('merchantId', 'merchantPassword', 'acquirerId', 'customerReference', 'cardReference', 'card');
         $this->getCard()->validate();
 
@@ -55,8 +52,7 @@ 
      *
      * @return string
      */
-    public function getCustomerReference()
-    {
+    public function getCustomerReference() {
         return $this->getParameter('customerReference');
     }
 
@@ -65,8 +61,7 @@ 
      *
      * @param string $value
      */
-    public function setCustomerReference($value)
-    {
+    public function setCustomerReference($value) {
         return $this->setParameter('customerReference', $value);
     }
 
@@ -75,8 +70,7 @@ 
      *
      * @return string Endpoint URL
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return parent::getEndpoint() . 'UpdateToken';
     }
 
@@ -87,8 +81,7 @@ 
      *
      * @return UpdateCardResponse
      */
-    protected function newResponse($xml)
-    {
+    protected function newResponse($xml) {
         return new UpdateCardResponse($this, $xml);
     }
 

src/Message/CreateCardResponse.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
      * @param RequestInterface $request
      * @param string $data
      */
-    public function __construct(RequestInterface $request, $data)
+    public function __construct( RequestInterface $request, $data )
     {
         if ( empty($data) )
         {
@@ -25,7 +25,7 @@ 
         }
 
         $this->request = $request;
-        $this->data    = $this->xmlDeserialize($data);
+        $this->data    = $this->xmlDeserialize( $data );
     }
 
     /**

Braces +6 added lines, -12 removed lines

@@ -9,18 +9,15 @@ 
 /**
  * FACPG2 XML Tokenize Response
  */
-class CreateCardResponse extends AbstractResponse
-{
+class CreateCardResponse extends AbstractResponse {
     /**
      * Constructor
      *
      * @param RequestInterface $request
      * @param string $data
      */
-    public function __construct(RequestInterface $request, $data)
-    {
-        if ( empty($data) )
-        {
+    public function __construct(RequestInterface $request, $data) {
+        if ( empty($data) ) {
             throw new InvalidResponseException();
         }
 
@@ -33,8 +30,7 @@ 
      *
      * @return boolean
      */
-    public function isSuccessful()
-    {
+    public function isSuccessful() {
         return isset($this->data['Success']) && 'true' === $this->data['Success'];
     }
 
@@ -43,8 +39,7 @@ 
      *
      * @return string
      */
-    public function getMessage()
-    {
+    public function getMessage() {
         return isset($this->data['ErrorMsg']) && !empty($this->data['ErrorMsg']) ? $this->data['ErrorMsg'] : null;
     }
 
@@ -53,8 +48,7 @@ 
      *
      * @return string
      */
-    public function getCardReference()
-    {
+    public function getCardReference() {
         return isset($this->data['Token']) ? $this->data['Token'] : null;
     }
 

src/Message/RefundRequest.php

Braces +1 added lines, -2 removed lines

@@ -7,8 +7,7 @@
 /**
  * FACPG2 Refund Request
  */
-class RefundRequest extends TransactionModificationRequest
-{
+class RefundRequest extends TransactionModificationRequest {
     /**
      * Flag as a refund
      *

src/Message/CaptureRequest.php

Braces +1 added lines, -2 removed lines

@@ -7,8 +7,7 @@
 /**
  * FACPG2 Capture Request
  */
-class CaptureRequest extends TransactionModificationRequest
-{
+class CaptureRequest extends TransactionModificationRequest {
     /**
      * Flag as a capture
      *

src/Message/StatusRequest.php

Spacing +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
      */
     public function getData()
     {
-        $this->validate('merchantId', 'merchantPassword', 'acquirerId', 'transactionId');
+        $this->validate( 'merchantId', 'merchantPassword', 'acquirerId', 'transactionId' );
 
         $data = [
             'AcquirerId'  => $this->getAcquirerId(),
@@ -40,7 +40,7 @@ 
      */
     protected function getEndpoint()
     {
-        return parent::getEndpoint() . 'TransactionStatus';
+        return parent::getEndpoint().'TransactionStatus';
     }
 
     /**
@@ -50,8 +50,8 @@ 
      *
      * @return StatusResponse
      */
-    protected function newResponse($xml)
+    protected function newResponse( $xml )
     {
-        return new StatusResponse($this, $xml);
+        return new StatusResponse( $this, $xml );
     }
 }

Braces +4 added lines, -8 removed lines

@@ -7,8 +7,7 @@ 
 /**
  * FACPG2 Transaction Status Request
  */
-class StatusRequest extends AbstractRequest
-{
+class StatusRequest extends AbstractRequest {
     /**
      * @var string;
      */
@@ -19,8 +18,7 @@ 
      *
      * @return array
      */
-    public function getData()
-    {
+    public function getData() {
         $this->validate('merchantId', 'merchantPassword', 'acquirerId', 'transactionId');
 
         $data = [
@@ -38,8 +36,7 @@ 
      *
      * @return string Endpoint URL
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return parent::getEndpoint() . 'TransactionStatus';
     }
 
@@ -50,8 +47,7 @@ 
      *
      * @return StatusResponse
      */
-    protected function newResponse($xml)
-    {
+    protected function newResponse($xml) {
         return new StatusResponse($this, $xml);
     }
 }

src/ParameterTrait.php

Spacing +12 added lines, -12 removed lines

@@ -9,9 +9,9 @@ 
      *
      * @return string $value Merchant ID.
      */
-    public function setMerchantId($value)
+    public function setMerchantId( $value )
     {
-        return $this->setParameter('merchantId', $value);
+        return $this->setParameter( 'merchantId', $value );
     }
 
     /**
@@ -19,7 +19,7 @@ 
      */
     public function getMerchantId()
     {
-        return $this->getParameter('merchantId');
+        return $this->getParameter( 'merchantId' );
     }
 
     /**
@@ -27,9 +27,9 @@ 
      *
      * @return string $value Merchant Password.
      */
-    public function setMerchantPassword($value)
+    public function setMerchantPassword( $value )
     {
-        return $this->setParameter('merchantPassword', $value);
+        return $this->setParameter( 'merchantPassword', $value );
     }
 
     /**
@@ -37,7 +37,7 @@ 
      */
     public function getMerchantPassword()
     {
-        return $this->getParameter('merchantPassword');
+        return $this->getParameter( 'merchantPassword' );
     }
 
     /**
@@ -45,9 +45,9 @@ 
      *
      * @return string $value Acquirer ID.
      */
-    public function setAcquirerId($value)
+    public function setAcquirerId( $value )
     {
-        return $this->setParameter('acquirerId', $value);
+        return $this->setParameter( 'acquirerId', $value );
     }
 
     /**
@@ -55,7 +55,7 @@ 
      */
     public function getAcquirerId()
     {
-        return $this->getParameter('acquirerId');
+        return $this->getParameter( 'acquirerId' );
     }
 
     /**
@@ -63,9 +63,9 @@ 
      *
      * @return boolean $value Require AVS Check.
      */
-    public function setRequireAvsCheck($value)
+    public function setRequireAvsCheck( $value )
     {
-        return $this->setParameter('requireAvsCheck', $value);
+        return $this->setParameter( 'requireAvsCheck', $value );
     }
 
     /**
@@ -73,6 +73,6 @@ 
      */
     public function getRequireAvsCheck()
     {
-        return $this->getParameter('requireAvsCheck');
+        return $this->getParameter( 'requireAvsCheck' );
     }
 }

Braces +9 added lines, -18 removed lines

@@ -2,23 +2,20 @@ 
 
 namespace Omnipay\FirstAtlanticCommerce;
 
-trait ParameterTrait
-{
+trait ParameterTrait {
     /**
      * @param string $value Merchant ID.
      *
      * @return string $value Merchant ID.
      */
-    public function setMerchantId($value)
-    {
+    public function setMerchantId($value) {
         return $this->setParameter('merchantId', $value);
     }
 
     /**
      * @return string $value Merchant ID.
      */
-    public function getMerchantId()
-    {
+    public function getMerchantId() {
         return $this->getParameter('merchantId');
     }
 
@@ -27,16 +24,14 @@ 
      *
      * @return string $value Merchant Password.
      */
-    public function setMerchantPassword($value)
-    {
+    public function setMerchantPassword($value) {
         return $this->setParameter('merchantPassword', $value);
     }
 
     /**
      * @return string $value Merchant Password.
      */
-    public function getMerchantPassword()
-    {
+    public function getMerchantPassword() {
         return $this->getParameter('merchantPassword');
     }
 
@@ -45,16 +40,14 @@ 
      *
      * @return string $value Acquirer ID.
      */
-    public function setAcquirerId($value)
-    {
+    public function setAcquirerId($value) {
         return $this->setParameter('acquirerId', $value);
     }
 
     /**
      * @return string $value Acquirer ID.
      */
-    public function getAcquirerId()
-    {
+    public function getAcquirerId() {
         return $this->getParameter('acquirerId');
     }
 
@@ -63,16 +56,14 @@ 
      *
      * @return boolean $value Require AVS Check.
      */
-    public function setRequireAvsCheck($value)
-    {
+    public function setRequireAvsCheck($value) {
         return $this->setParameter('requireAvsCheck', $value);
     }
 
     /**
      * @return boolean $value Require AVS Check.
      */
-    public function getRequireAvsCheck()
-    {
+    public function getRequireAvsCheck() {
         return $this->getParameter('requireAvsCheck');
     }
 }