Conditions | 1 |
Paths | 1 |
Total Lines | 4 |
Code Lines | 2 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Metric | Value |
---|---|
c | 1 |
b | 0 |
f | 0 |
dl | 0 |
loc | 4 |
rs | 10 |
cc | 1 |
eloc | 2 |
nc | 1 |
nop | 0 |
1 | <?php |
||
2 | |||
3 | namespace Omnipay\FirstAtlanticCommerce; |
||
4 | |||
5 | trait ParameterTrait |
||
6 | { |
||
7 | /** |
||
0 ignored issues
–
show
Coding Style
introduced
by
![]() |
|||
8 | * @param string $value Merchant ID. |
||
0 ignored issues
–
show
|
|||
9 | * |
||
0 ignored issues
–
show
|
|||
10 | * @return string $value Merchant ID. |
||
0 ignored issues
–
show
|
|||
11 | */ |
||
0 ignored issues
–
show
|
|||
12 | public function setMerchantId($value) |
||
0 ignored issues
–
show
|
|||
13 | { |
||
0 ignored issues
–
show
|
|||
14 | return $this->setParameter('merchantId', $value); |
||
0 ignored issues
–
show
It seems like
setParameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?
This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable {
public function equalIds(Idable $other) {
return $this->getId() === $other->getId();
}
}
The trait Adding the ![]() |
|||
15 | } |
||
0 ignored issues
–
show
|
|||
16 | |||
17 | /** |
||
0 ignored issues
–
show
|
|||
18 | * @return string $value Merchant ID. |
||
0 ignored issues
–
show
|
|||
19 | */ |
||
0 ignored issues
–
show
|
|||
20 | public function getMerchantId() |
||
0 ignored issues
–
show
|
|||
21 | { |
||
0 ignored issues
–
show
|
|||
22 | return $this->getParameter('merchantId'); |
||
0 ignored issues
–
show
It seems like
getParameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?
This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable {
public function equalIds(Idable $other) {
return $this->getId() === $other->getId();
}
}
The trait Adding the ![]() |
|||
23 | } |
||
0 ignored issues
–
show
|
|||
24 | |||
25 | /** |
||
0 ignored issues
–
show
|
|||
26 | * @param string $value Merchant Password. |
||
0 ignored issues
–
show
|
|||
27 | * |
||
0 ignored issues
–
show
|
|||
28 | * @return string $value Merchant Password. |
||
0 ignored issues
–
show
|
|||
29 | */ |
||
0 ignored issues
–
show
|
|||
30 | public function setMerchantPassword($value) |
||
0 ignored issues
–
show
|
|||
31 | { |
||
0 ignored issues
–
show
|
|||
32 | return $this->setParameter('merchantPassword', $value); |
||
0 ignored issues
–
show
It seems like
setParameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?
This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable {
public function equalIds(Idable $other) {
return $this->getId() === $other->getId();
}
}
The trait Adding the ![]() |
|||
33 | } |
||
0 ignored issues
–
show
|
|||
34 | |||
35 | /** |
||
0 ignored issues
–
show
|
|||
36 | * @return string $value Merchant Password. |
||
0 ignored issues
–
show
|
|||
37 | */ |
||
0 ignored issues
–
show
|
|||
38 | public function getMerchantPassword() |
||
0 ignored issues
–
show
|
|||
39 | { |
||
0 ignored issues
–
show
|
|||
40 | return $this->getParameter('merchantPassword'); |
||
0 ignored issues
–
show
It seems like
getParameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?
This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable {
public function equalIds(Idable $other) {
return $this->getId() === $other->getId();
}
}
The trait Adding the ![]() |
|||
41 | } |
||
0 ignored issues
–
show
|
|||
42 | |||
43 | /** |
||
0 ignored issues
–
show
|
|||
44 | * @param string $value Acquirer ID. |
||
0 ignored issues
–
show
|
|||
45 | * |
||
0 ignored issues
–
show
|
|||
46 | * @return string $value Acquirer ID. |
||
0 ignored issues
–
show
|
|||
47 | */ |
||
0 ignored issues
–
show
|
|||
48 | public function setAcquirerId($value) |
||
0 ignored issues
–
show
|
|||
49 | { |
||
0 ignored issues
–
show
|
|||
50 | return $this->setParameter('acquirerId', $value); |
||
0 ignored issues
–
show
It seems like
setParameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?
This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable {
public function equalIds(Idable $other) {
return $this->getId() === $other->getId();
}
}
The trait Adding the ![]() |
|||
51 | } |
||
0 ignored issues
–
show
|
|||
52 | |||
53 | /** |
||
0 ignored issues
–
show
|
|||
54 | * @return string $value Acquirer ID. |
||
0 ignored issues
–
show
|
|||
55 | */ |
||
0 ignored issues
–
show
|
|||
56 | public function getAcquirerId() |
||
0 ignored issues
–
show
|
|||
57 | { |
||
0 ignored issues
–
show
|
|||
58 | return $this->getParameter('acquirerId'); |
||
0 ignored issues
–
show
It seems like
getParameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?
This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable {
public function equalIds(Idable $other) {
return $this->getId() === $other->getId();
}
}
The trait Adding the ![]() |
|||
59 | } |
||
0 ignored issues
–
show
|
|||
60 | |||
61 | /** |
||
0 ignored issues
–
show
|
|||
62 | * @param boolean $value Require AVS Check. |
||
0 ignored issues
–
show
|
|||
63 | * |
||
0 ignored issues
–
show
|
|||
64 | * @return boolean $value Require AVS Check. |
||
0 ignored issues
–
show
|
|||
65 | */ |
||
0 ignored issues
–
show
|
|||
66 | public function setRequireAvsCheck($value) |
||
0 ignored issues
–
show
|
|||
67 | { |
||
0 ignored issues
–
show
|
|||
68 | return $this->setParameter('requireAvsCheck', $value); |
||
0 ignored issues
–
show
It seems like
setParameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?
This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable {
public function equalIds(Idable $other) {
return $this->getId() === $other->getId();
}
}
The trait Adding the ![]() |
|||
69 | } |
||
0 ignored issues
–
show
|
|||
70 | |||
71 | /** |
||
0 ignored issues
–
show
|
|||
72 | * @return boolean $value Require AVS Check. |
||
0 ignored issues
–
show
|
|||
73 | */ |
||
0 ignored issues
–
show
|
|||
74 | public function getRequireAvsCheck() |
||
0 ignored issues
–
show
|
|||
75 | { |
||
0 ignored issues
–
show
|
|||
76 | return $this->getParameter('requireAvsCheck'); |
||
0 ignored issues
–
show
It seems like
getParameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?
This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable {
public function equalIds(Idable $other) {
return $this->getId() === $other->getId();
}
}
The trait Adding the ![]() |
|||
77 | } |
||
0 ignored issues
–
show
|
|||
78 | } |
||
79 |