StatusRequest::getData() - Code Metrics - Strikewood/omnipay-first-atlantic-commerce - Measure and Improve Code Quality continuously with Scrutinizer

StatusRequest::getData() A
last analyzed 2016-05-27 20:55 UTC

↳ Parent: StatusRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
rs	9.4285
cc	1
eloc	8
nc	1
nop	0

1			<?php
2
3			namespace Omnipay\FirstAtlanticCommerce\Message;
4
5			use Omnipay\FirstAtlanticCommerce\Message\AbstractRequest;
6
7			/**
8			* FACPG2 Transaction Status Request
9			*/
10			class StatusRequest extends AbstractRequest
11			{
12			/**
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
13			* @var string;
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
14			*/
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
15			protected $requestName = 'TransactionStatusRequest';
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
16
17			/**
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
18			* Validate and construct the data for the request
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
19			*
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
20			* @return array
			0 ignored issues – show Documentation introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `array<string,string>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
21			*/
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
22			public function getData()
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report The function name `getData` is in camel caps, but expected `get_data` instead as per the coding standard. Loading history...
23			{
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
24			$this->validate('merchantId', 'merchantPassword', 'acquirerId', 'transactionId');
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
25
26			$data = [
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
27			'AcquirerId' => $this->getAcquirerId(),
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
28			'MerchantId' => $this->getMerchantId(),
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
29			'Password' => $this->getMerchantPassword(),
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
30			'OrderNumber' => $this->getTransactionId()
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
31			];
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
32
33			return $data;
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
34			}
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
35
36			/**
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
37			* Returns endpoint for authorize requests
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
38			*
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
39			* @return string Endpoint URL
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
40			*/
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
41			protected function getEndpoint()
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report The function name `getEndpoint` is in camel caps, but expected `get_endpoint` instead as per the coding standard. Loading history...
42			{
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
43			return parent::getEndpoint() . 'TransactionStatus';
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
44			}
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
45
46			/**
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
47			* Return the transaction modification response object
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
48			*
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
49			* @param \SimpleXMLElement $xml Response xml object
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
50			*
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
51			* @return StatusResponse
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
52			*/
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
53			protected function newResponse($xml)
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report The function name `newResponse` is in camel caps, but expected `new_response` instead as per the coding standard. Loading history...
54			{
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
55			return new StatusResponse($this, $xml);
			0 ignored issues – show Bug Best Practice introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report The return type of `return new \Omnipay\Firs...sResponse($this, $xml);` (`Omnipay\FirstAtlanticCom...\Message\StatusResponse`) is incompatible with the return type declared by the abstract method `Omnipay\FirstAtlanticCom...actRequest::newResponse` of type `Omnipay\FirstAtlanticCom...ssage\ResponseInterface`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
56			}
			0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
57			}
58

Strikewood / omnipay-first-atlantic-commerce

GitHub Access Token became invalid

StatusRequest::getData() A last analyzed 2016-05-27 20:55 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

StatusRequest::getData() A
last analyzed 2016-05-27 20:55 UTC