CreateCardResponse::isSuccessful() - Code Metrics - Strikewood/omnipay-first-atlantic-commerce - Measure and Improve Code Quality continuously with Scrutinizer

CreateCardResponse::isSuccessful() A
last analyzed 2016-05-27 20:55 UTC

↳ Parent: CreateCardResponse

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	4
loc	4
rs	10
cc	2
eloc	2
nc	2
nop	0

1		<?php
2
3		namespace Omnipay\FirstAtlanticCommerce\Message;
4
5		use Omnipay\Common\Exception\InvalidResponseException;
6		use Omnipay\Common\Message\RequestInterface;
7		use Omnipay\FirstAtlanticCommerce\Message\AbstractResponse;
8
9		/**
10		* FACPG2 XML Tokenize Response
11		*/
12	View Code Duplication	class CreateCardResponse extends AbstractResponse
		0 ignored issues – show Duplication introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/**
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
15		* Constructor
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
16		*
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
17		* @param RequestInterface $request
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
18		* @param string $data
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
19		*/
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
20		public function __construct(RequestInterface $request, $data)
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
21		{
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
22		if ( empty($data) )
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Opening brace should be on the same line as the declaration Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
23		{
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
24		throw new InvalidResponseException();
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
25		}
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
26
27		$this->request = $request;
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
28		$this->data = $this->xmlDeserialize($data);
		0 ignored issues – show Documentation introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report `$data` is of type `string`, but the function expects a `object<SimpleXMLElement>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
29		}
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
30
31		/**
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
32		* Return whether or not the response was successful
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
33		*
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
34		* @return boolean
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
35		*/
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
36		public function isSuccessful()
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report The function name `isSuccessful` is in camel caps, but expected `is_successful` instead as per the coding standard. Loading history...
37		{
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
38		return isset($this->data['Success']) && 'true' === $this->data['Success'];
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
39		}
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
40
41		/**
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
42		* Return the response's reason message
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
43		*
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
44		* @return string
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
45		*/
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
46		public function getMessage()
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report The function name `getMessage` is in camel caps, but expected `get_message` instead as per the coding standard. Loading history...
47		{
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
48		return isset($this->data['ErrorMsg']) && !empty($this->data['ErrorMsg']) ? $this->data['ErrorMsg'] : null;
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history... introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 space after "!"; 0 found Loading history...
49		}
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
50
51		/**
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
52		* Return card reference
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
53		*
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
54		* @return string
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
55		*/
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
56		public function getCardReference()
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report The function name `getCardReference` is in camel caps, but expected `get_card_reference` instead as per the coding standard. Loading history...
57		{
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
58		return isset($this->data['Token']) ? $this->data['Token'] : null;
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
59		}
		0 ignored issues – show Coding Style introduced 2016-05-27 20:55 UTC by Report Bug Copy Issue Report Tabs must be used to indent lines; spaces are not allowed Loading history...
60
61		}
62

Strikewood / omnipay-first-atlantic-commerce

GitHub Access Token became invalid

CreateCardResponse::isSuccessful() A last analyzed 2016-05-27 20:55 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CreateCardResponse::isSuccessful() A
last analyzed 2016-05-27 20:55 UTC