Omnipay\FirstAtlanticCommerce\Message\TransactionModificationRequest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getData()	0	16	1
A	getEndpoint()	0	4	1
A	getModificationType()	0	4	1
A	newResponse()	0	4	1

<?php

namespace Omnipay\FirstAtlanticCommerce\Message;

use Omnipay\FirstAtlanticCommerce\Message\AbstractRequest;

/**
 * FACPG2 Transaction Modification Request
 */
class TransactionModificationRequest extends AbstractRequest
{
    /**

Tabs must be used to indent lines; spaces are not allowed

     * @var string;

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected $requestName = 'TransactionModificationRequest';

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Modification Type

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @var int;

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected $modificationType;

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Validate and construct the data for the request

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return array

Consider making the return type a bit more specific; maybe use array<string,string|integer>.

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function getData()

Tabs must be used to indent lines; spaces are not allowed

The function name getData is in camel caps, but expected get_data instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        $this->validate('merchantId', 'merchantPassword', 'acquirerId', 'transactionId', 'amount');

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

        $data = [

Tabs must be used to indent lines; spaces are not allowed

            'AcquirerId'       => $this->getAcquirerId(),

Tabs must be used to indent lines; spaces are not allowed

            'Amount'           => $this->formatAmount(),

Tabs must be used to indent lines; spaces are not allowed

            'CurrencyExponent' => $this->getCurrencyDecimalPlaces(),

Tabs must be used to indent lines; spaces are not allowed

            'MerchantId'       => $this->getMerchantId(),

Tabs must be used to indent lines; spaces are not allowed

            'ModificationType' => $this->getModificationType(),

Tabs must be used to indent lines; spaces are not allowed

            'OrderNumber'      => $this->getTransactionId(),

Tabs must be used to indent lines; spaces are not allowed

            'Password'         => $this->getMerchantPassword()

Tabs must be used to indent lines; spaces are not allowed

        ];

Tabs must be used to indent lines; spaces are not allowed

        return $data;

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Returns endpoint for authorize requests

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return string Endpoint URL

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected function getEndpoint()

Tabs must be used to indent lines; spaces are not allowed

The function name getEndpoint is in camel caps, but expected get_endpoint instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        return parent::getEndpoint() . 'TransactionModification';

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Returns the modification type

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return int Modification Type

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected function getModificationType()

Tabs must be used to indent lines; spaces are not allowed

The function name getModificationType is in camel caps, but expected get_modification_type instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        return $this->modificationType;

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Return the transaction modification response object

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @param \SimpleXMLElement $xml Response xml object

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return ResponseInterface

Should the return type not be TransactionModificationResponse?

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected function newResponse($xml)

Tabs must be used to indent lines; spaces are not allowed

The function name newResponse is in camel caps, but expected new_response instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        return new TransactionModificationResponse($this, $xml);

The return type of return new \Omnipay\FirstAtlanticCommerce\Message\TransactionModificationResponse($this, $xml); (Omnipay\FirstAtlanticCommerce\Message\TransactionModificationResponse) is incompatible with the return type declared by the abstract method Omnipay\FirstAtlanticCommerce\Message\AbstractRequest::newResponse of type Omnipay\FirstAtlanticCommerce\Message\ResponseInterface.

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

    }

Tabs must be used to indent lines; spaces are not allowed

}