Omnipay\FirstAtlanticCommerce\Message\AuthorizeResponse

Complexity

Total Complexity

15

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	4
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	2
B	verifySignature()	0	18	5
A	isSuccessful()	0	4	2
A	getCode()	0	4	2
A	getMessage()	0	4	2
A	getTransactionReference()	0	4	2

<?php

namespace Omnipay\FirstAtlanticCommerce\Message;

use Omnipay\Common\Exception\InvalidResponseException;
use Omnipay\Common\Message\RequestInterface;
use Omnipay\FirstAtlanticCommerce\Message\AbstractResponse;

/**
 * FACPG2 XML Authorize Response
 */
class AuthorizeResponse extends AbstractResponse
{
    /**

Tabs must be used to indent lines; spaces are not allowed

     * Constructor

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @param RequestInterface $request

Tabs must be used to indent lines; spaces are not allowed

     * @param string $data

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function __construct(RequestInterface $request, $data)

Tabs must be used to indent lines; spaces are not allowed

    {

Tabs must be used to indent lines; spaces are not allowed

        if ( empty($data) )

Tabs must be used to indent lines; spaces are not allowed

Opening brace should be on the same line as the declaration

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

        {

Tabs must be used to indent lines; spaces are not allowed

            throw new InvalidResponseException();

Tabs must be used to indent lines; spaces are not allowed

        }

Tabs must be used to indent lines; spaces are not allowed

        $this->request = $request;

Tabs must be used to indent lines; spaces are not allowed

        $this->data    = $this->xmlDeserialize($data);

$data is of type string, but the function expects a object<SimpleXMLElement>.

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

        $this->verifySignature();

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Verifies the signature for the response.

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @throws InvalidResponseException if the signature doesn't match

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return void

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function verifySignature()

Tabs must be used to indent lines; spaces are not allowed

The function name verifySignature is in camel caps, but expected verify_signature instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        if ( isset($this->data['CreditCardTransactionResults']['ResponseCode']) && (

Tabs must be used to indent lines; spaces are not allowed

Opening brace should be on the same line as the declaration

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

            '1' == $this->data['CreditCardTransactionResults']['ResponseCode'] ||

Tabs must be used to indent lines; spaces are not allowed

            '2' == $this->data['CreditCardTransactionResults']['ResponseCode']) )

Tabs must be used to indent lines; spaces are not allowed

        {

Tabs must be used to indent lines; spaces are not allowed

            $signature  = $this->request->getMerchantPassword();

It seems like you code against a concrete implementation and not the interface Omnipay\Common\Message\RequestInterface as the method getMerchantPassword() does only exist in the following implementations of said interface: Omnipay\FirstAtlanticCommerce\Message\AbstractRequest, Omnipay\FirstAtlanticCommerce\Message\AuthorizeRequest, Omnipay\FirstAtlanticCommerce\Message\CaptureRequest, Omnipay\FirstAtlanticCommerce\Message\CreateCardRequest, Omnipay\FirstAtlanticCommerce\Message\PurchaseRequest, Omnipay\FirstAtlanticCommerce\Message\RefundRequest, Omnipay\FirstAtlanticCommerce\Message\StatusRequest, Omnipay\FirstAtlanticCommerce\Message\TransactionModificationRequest, Omnipay\FirstAtlanticCommerce\Message\UpdateCardRequest, Omnipay\FirstAtlanticCommerce\Message\VoidRequest.

Tabs must be used to indent lines; spaces are not allowed

            $signature .= $this->request->getMerchantId();

It seems like you code against a concrete implementation and not the interface Omnipay\Common\Message\RequestInterface as the method getMerchantId() does only exist in the following implementations of said interface: Omnipay\FirstAtlanticCommerce\Message\AbstractRequest, Omnipay\FirstAtlanticCommerce\Message\AuthorizeRequest, Omnipay\FirstAtlanticCommerce\Message\CaptureRequest, Omnipay\FirstAtlanticCommerce\Message\CreateCardRequest, Omnipay\FirstAtlanticCommerce\Message\PurchaseRequest, Omnipay\FirstAtlanticCommerce\Message\RefundRequest, Omnipay\FirstAtlanticCommerce\Message\StatusRequest, Omnipay\FirstAtlanticCommerce\Message\TransactionModificationRequest, Omnipay\FirstAtlanticCommerce\Message\UpdateCardRequest, Omnipay\FirstAtlanticCommerce\Message\VoidRequest.

Tabs must be used to indent lines; spaces are not allowed

            $signature .= $this->request->getAcquirerId();

It seems like you code against a concrete implementation and not the interface Omnipay\Common\Message\RequestInterface as the method getAcquirerId() does only exist in the following implementations of said interface: Omnipay\FirstAtlanticCommerce\Message\AbstractRequest, Omnipay\FirstAtlanticCommerce\Message\AuthorizeRequest, Omnipay\FirstAtlanticCommerce\Message\CaptureRequest, Omnipay\FirstAtlanticCommerce\Message\CreateCardRequest, Omnipay\FirstAtlanticCommerce\Message\PurchaseRequest, Omnipay\FirstAtlanticCommerce\Message\RefundRequest, Omnipay\FirstAtlanticCommerce\Message\StatusRequest, Omnipay\FirstAtlanticCommerce\Message\TransactionModificationRequest, Omnipay\FirstAtlanticCommerce\Message\UpdateCardRequest, Omnipay\FirstAtlanticCommerce\Message\VoidRequest.

Tabs must be used to indent lines; spaces are not allowed

            $signature .= $this->request->getTransactionId();

Tabs must be used to indent lines; spaces are not allowed

            $signature  = base64_encode( sha1($signature, true) );

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

            if ( $signature !== $this->data['Signature'] ) {

Tabs must be used to indent lines; spaces are not allowed

                throw new InvalidResponseException('Signature verification failed');

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

            }

Tabs must be used to indent lines; spaces are not allowed

        }

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Return whether or not the response was successful

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return boolean

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function isSuccessful()

Tabs must be used to indent lines; spaces are not allowed

The function name isSuccessful is in camel caps, but expected is_successful instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        return isset($this->data['CreditCardTransactionResults']['ResponseCode']) && '1' === $this->data['CreditCardTransactionResults']['ResponseCode'];

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Return the response's reason code

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return string

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function getCode()

Tabs must be used to indent lines; spaces are not allowed

The function name getCode is in camel caps, but expected get_code instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        return isset($this->data['CreditCardTransactionResults']['ReasonCode']) ? $this->data['CreditCardTransactionResults']['ReasonCode'] : null;

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Return the response's reason message

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return string

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function getMessage()

Tabs must be used to indent lines; spaces are not allowed

The function name getMessage is in camel caps, but expected get_message instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        return isset($this->data['CreditCardTransactionResults']['ReasonCodeDescription']) ? $this->data['CreditCardTransactionResults']['ReasonCodeDescription'] : null;

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Return transaction reference

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return string

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function getTransactionReference()

Tabs must be used to indent lines; spaces are not allowed

The function name getTransactionReference is in camel caps, but expected get_transaction_reference instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        return isset($this->data['CreditCardTransactionResults']['ReferenceNumber']) ? $this->data['CreditCardTransactionResults']['ReferenceNumber'] : null;

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

    }

Tabs must be used to indent lines; spaces are not allowed

}