Omnipay\FirstAtlanticCommerce\Message\AbstractRequest

Complexity

Total Complexity

12

Size/Duplication

Total Lines	137
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	4
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	formatAmount()	0	9	1
A	getEndpoint()	0	4	2
	newResponse()	0	1	?
A	sendData()	0	10	1
B	xmlSerialize()	0	27	5
A	setCard()	0	9	3

<?php

namespace Omnipay\FirstAtlanticCommerce\Message;

use Omnipay\Common\Message\AbstractRequest as BaseAbstractRequest;
use Omnipay\FirstAtlanticCommerce\CreditCard;
use Omnipay\FirstAtlanticCommerce\ParameterTrait;
use SimpleXMLElement;

abstract class AbstractRequest extends BaseAbstractRequest
{
    use ParameterTrait;

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * FACPG2 live endpoint URL

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @var string

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected $liveEndpoint = 'https://marlin.firstatlanticcommerce.com/PGServiceXML/';

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * FACPG2 test endpoint URL

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @var string

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected $testEndpoint = 'https://ecm.firstatlanticcommerce.com/PGServiceXML/';

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * FACPG2 XML namespace

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @var string

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected $namespace = 'http://schemas.firstatlanticcommerce.com/gateway/data';

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * FACPG2 XML root

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @var string

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected $requestName;

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Returns the amount formatted to match FAC's expectations.

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return string The amount padded with zeros on the left to 12 digits and no decimal place.

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected function formatAmount()

Tabs must be used to indent lines; spaces are not allowed

The function name formatAmount is in camel caps, but expected format_amount instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        $amount = $this->getAmount();

Tabs must be used to indent lines; spaces are not allowed

        $amount = str_replace('.', '', $amount);

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

        $amount = str_pad($amount, 12, '0', STR_PAD_LEFT);

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

        return $amount;

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Returns the live or test endpoint depending on TestMode.

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return string Endpoint URL

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected function getEndpoint()

Tabs must be used to indent lines; spaces are not allowed

The function name getEndpoint is in camel caps, but expected get_endpoint instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        return $this->getTestMode() ? $this->testEndpoint : $this->liveEndpoint;

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Return the response object

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @param \SimpleXMLElement $xml Response xml object

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return ResponseInterface

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    abstract protected function newResponse($xml);

Tabs must be used to indent lines; spaces are not allowed

The function name newResponse is in camel caps, but expected new_response instead as per the coding standard.

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Send the request payload

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @param array $data Request payload

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return ResponseInterface

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function sendData($data)

Tabs must be used to indent lines; spaces are not allowed

The function name sendData is in camel caps, but expected send_data instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        $httpResponse = $this->httpClient->post(

Tabs must be used to indent lines; spaces are not allowed

            $this->getEndpoint(),

Tabs must be used to indent lines; spaces are not allowed

            ['Content-Type' => 'text/xml; charset=utf-8'],

Tabs must be used to indent lines; spaces are not allowed

            $this->xmlSerialize($data)

It seems like $this->xmlSerialize($data) targeting Omnipay\FirstAtlanticCommerce\Message\AbstractRequest::xmlSerialize() can also be of type false; however, Guzzle\Http\ClientInterface::post() does only seem to accept array|object<Guzzle\Common\Collection>|string|object<Guzzle\Http\EntityBodyInterface>|null, did you maybe forget to handle an error condition?

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

        )->send();

Tabs must be used to indent lines; spaces are not allowed

        return $this->response = $this->newResponse( $httpResponse->xml() );

It seems like $this->newResponse($httpResponse->xml()) of type object<Omnipay\FirstAtlanticCommerce\Message\ResponseInterface> is incompatible with the declared type object<Omnipay\Common\Message\ResponseInterface> of property $response.

The return type of return $this->response = $this->newResponse($httpResponse->xml()); (Omnipay\FirstAtlanticCommerce\Message\ResponseInterface) is incompatible with the return type declared by the interface Omnipay\Common\Message\RequestInterface::sendData of type Omnipay\Common\Message\ResponseInterface.

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Serializes an array into XML

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @param array $data Array to serialize into XML.

Tabs must be used to indent lines; spaces are not allowed

     * @param \SimpleXMLElement $xml SimpleXMLElement object.

Should the type for parameter $xml not be SimpleXMLElement|null?

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return string XML

Should the return type not be string|false?

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    protected function xmlSerialize($data, $xml = null)

Tabs must be used to indent lines; spaces are not allowed

The function name xmlSerialize is in camel caps, but expected xml_serialize instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        if ( !$xml instanceof SimpleXMLElement )

Tabs must be used to indent lines; spaces are not allowed

Opening brace should be on the same line as the declaration

Expected 1 space after "!"; 0 found

        {

Tabs must be used to indent lines; spaces are not allowed

            $xml = new SimpleXMLElement('<'. $this->requestName .' xmlns="'. $this->namespace .'" />');

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

        }

Tabs must be used to indent lines; spaces are not allowed

        foreach ($data as $key => $value)

Tabs must be used to indent lines; spaces are not allowed

No space after opening parenthesis is prohibited

Opening brace should be on the same line as the declaration

No space before closing parenthesis is prohibited

        {

Tabs must be used to indent lines; spaces are not allowed

            if ( !isset($value) )

Tabs must be used to indent lines; spaces are not allowed

Opening brace should be on the same line as the declaration

Expected 1 space after "!"; 0 found

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

            {

Tabs must be used to indent lines; spaces are not allowed

                continue;

Tabs must be used to indent lines; spaces are not allowed

            }

Tabs must be used to indent lines; spaces are not allowed

            if ( is_array($value) )

Tabs must be used to indent lines; spaces are not allowed

Opening brace should be on the same line as the declaration

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

            {

Tabs must be used to indent lines; spaces are not allowed

                $node = $xml->addChild($key);

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

                $this->xmlSerialize($value, $node);

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

            }

Tabs must be used to indent lines; spaces are not allowed

            else

Tabs must be used to indent lines; spaces are not allowed

            {

Tabs must be used to indent lines; spaces are not allowed

                $xml->addChild($key, $value);

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

            }

Tabs must be used to indent lines; spaces are not allowed

        }

Tabs must be used to indent lines; spaces are not allowed

        return $xml->asXML();

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

    /**

Tabs must be used to indent lines; spaces are not allowed

     * Sets the card.

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @param CreditCard $value

Tabs must be used to indent lines; spaces are not allowed

     *

Tabs must be used to indent lines; spaces are not allowed

     * @return AbstractRequest Provides a fluent interface

Tabs must be used to indent lines; spaces are not allowed

     */

Tabs must be used to indent lines; spaces are not allowed

    public function setCard($value)

Tabs must be used to indent lines; spaces are not allowed

The function name setCard is in camel caps, but expected set_card instead as per the coding standard.

    {

Tabs must be used to indent lines; spaces are not allowed

        if ($value && !$value instanceof CreditCard)

Tabs must be used to indent lines; spaces are not allowed

No space after opening parenthesis is prohibited

Opening brace should be on the same line as the declaration

Expected 1 space after "!"; 0 found

No space before closing parenthesis is prohibited

        {

Tabs must be used to indent lines; spaces are not allowed

            $value = new CreditCard($value);

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

        }

Tabs must be used to indent lines; spaces are not allowed

        return $this->setParameter('card', $value);

Tabs must be used to indent lines; spaces are not allowed

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

    }

Tabs must be used to indent lines; spaces are not allowed

}