Completed
Pull Request — master (#1580)
by Stephanie
48s
created
classes/models/fields/FrmFieldCaptcha.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -255,8 +255,8 @@  discard block
 block discarded – undo
255 255
 
256 256
 		if ( is_wp_error( $resp ) ) {
257 257
 			$error_string                     = $resp->get_error_message();
258
-			$errors[ 'field' . $args['id'] ]  = __( 'There was a problem verifying your captcha', 'formidable' );
259
-			$errors[ 'field' . $args['id'] ] .= ' ' . $error_string;
258
+			$errors['field' . $args['id']]  = __( 'There was a problem verifying your captcha', 'formidable' );
259
+			$errors['field' . $args['id']] .= ' ' . $error_string;
260 260
 			return $errors;
261 261
 		}
262 262
 
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
 			if ( $invalid_message === __( 'The reCAPTCHA was not entered correctly', 'formidable' ) ) {
284 284
 				$invalid_message = '';
285 285
 			}
286
-			$errors[ 'field' . $args['id'] ] = ( $invalid_message === '' ? $frm_settings->re_msg : $invalid_message );
286
+			$errors['field' . $args['id']] = ( $invalid_message === '' ? $frm_settings->re_msg : $invalid_message );
287 287
 		}
288 288
 
289 289
 		return $errors;
@@ -299,8 +299,8 @@  discard block
 block discarded – undo
299 299
 			$frm_vars['captcha_scores'] = array();
300 300
 		}
301 301
 		$form_id = is_object( $this->field ) ? $this->field->form_id : $this->field['form_id'];
302
-		if ( ! isset( $frm_vars['captcha_scores'][ $form_id ] ) ) {
303
-			$frm_vars['captcha_scores'][ $form_id ] = $score;
302
+		if ( ! isset( $frm_vars['captcha_scores'][$form_id] ) ) {
303
+			$frm_vars['captcha_scores'][$form_id] = $score;
304 304
 		}
305 305
 	}
306 306
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 	protected static function post_data_includes_token() {
330 330
 		$settings = FrmCaptchaFactory::get_settings_object();
331 331
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
332
-		return ! empty( $_POST[ $settings->token_field ] );
332
+		return ! empty( $_POST[$settings->token_field] );
333 333
 	}
334 334
 
335 335
 	/**
Please login to merge, or discard this patch.
classes/controllers/FrmDashboardController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -478,7 +478,7 @@  discard block
 block discarded – undo
478 478
 		foreach ( $data as $key => $messages ) {
479 479
 			if ( in_array( $key, array( 'unread', 'dismissed' ), true ) ) {
480 480
 				foreach ( $messages as $key_msg => $message ) {
481
-					$data[ $key ][ $key_msg ]['cta'] = self::inbox_clean_messages_cta( $message['cta'] );
481
+					$data[$key][$key_msg]['cta'] = self::inbox_clean_messages_cta( $message['cta'] );
482 482
 				}
483 483
 			}
484 484
 		}
@@ -557,11 +557,11 @@  discard block
 block discarded – undo
557 557
 	 */
558 558
 	private static function get_dashboard_options( $option_name = null ) {
559 559
 		$options = get_option( self::OPTION_META_NAME, array() );
560
-		if ( null !== $option_name && ! isset( $options[ $option_name ] ) ) {
560
+		if ( null !== $option_name && ! isset( $options[$option_name] ) ) {
561 561
 			return array();
562 562
 		}
563 563
 		if ( null !== $option_name ) {
564
-			return $options[ $option_name ];
564
+			return $options[$option_name];
565 565
 		}
566 566
 		return $options;
567 567
 	}
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
576 576
 	 */
577 577
 	private static function update_dashboard_options( $data, $option_name ) {
578 578
 		$options                 = self::get_dashboard_options();
579
-		$options[ $option_name ] = $data;
579
+		$options[$option_name] = $data;
580 580
 		update_option( self::OPTION_META_NAME, $options, 'no' );
581 581
 	}
582 582
 
Please login to merge, or discard this patch.
classes/factories/FrmFieldFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@
 block discarded – undo
111 111
 			FrmSubmitHelper::FIELD_TYPE => 'FrmFieldSubmit',
112 112
 		);
113 113
 
114
-		$class = isset( $type_classes[ $field_type ] ) ? $type_classes[ $field_type ] : '';
114
+		$class = isset( $type_classes[$field_type] ) ? $type_classes[$field_type] : '';
115 115
 
116 116
 		return apply_filters( 'frm_get_field_type_class', $class, $field_type );
117 117
 	}
Please login to merge, or discard this patch.
classes/helpers/FrmSubmitHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,8 +71,8 @@  discard block
 block discarded – undo
71 71
 	public static function get_current_action_from_global_var( $form_id ) {
72 72
 		global $frm_vars;
73 73
 
74
-		if ( isset( $frm_vars['form_params'][ $form_id ]['action'] ) ) {
75
-			return $frm_vars['form_params'][ $form_id ]['action'];
74
+		if ( isset( $frm_vars['form_params'][$form_id]['action'] ) ) {
75
+			return $frm_vars['form_params'][$form_id]['action'];
76 76
 		}
77 77
 
78 78
 		return 'create';
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	public static function remove_submit_field_from_list( &$fields ) {
168 168
 		foreach ( $fields as $key => $field ) {
169 169
 			if ( self::FIELD_TYPE === FrmField::get_field_type( $field ) ) {
170
-				unset( $fields[ $key ] );
170
+				unset( $fields[$key] );
171 171
 				return;
172 172
 			}
173 173
 		}
Please login to merge, or discard this patch.
classes/controllers/FrmOnboardingWizardController.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,8 @@
 block discarded – undo
138 138
 		}
139 139
 
140 140
 		// Only do this for single site installs.
141
-		if ( is_network_admin() ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
141
+		if ( is_network_admin() ) {
142
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
142 143
 			self::mark_onboarding_as_skipped();
143 144
 			return;
144 145
 		}
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -317,8 +317,8 @@  discard block
 block discarded – undo
317 317
 		);
318 318
 
319 319
 		foreach ( $fields_to_update as $field => $sanitize_callback ) {
320
-			if ( isset( $_POST[ $field ] ) ) {
321
-				$usage_data[ $field ] = FrmAppHelper::get_post_param( $field, '', $sanitize_callback );
320
+			if ( isset( $_POST[$field] ) ) {
321
+				$usage_data[$field] = FrmAppHelper::get_post_param( $field, '', $sanitize_callback );
322 322
 			}
323 323
 		}
324 324
 
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
 				'is-disabled' => true,
546 546
 				'help-text'   => esc_html__( 'Customize form appearance with an intuitive styling interface.', 'formidable' ),
547 547
 			);
548
-			self::$available_addons['save-entries']  = array(
548
+			self::$available_addons['save-entries'] = array(
549 549
 				'title'       => esc_html__( 'Save Entries', 'formidable' ),
550 550
 				'is-checked'  => true,
551 551
 				'is-disabled' => true,
Please login to merge, or discard this patch.
classes/controllers/FrmFormActionsController.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -108,19 +108,19 @@  discard block
 block discarded – undo
108 108
 		}
109 109
 
110 110
 		foreach ( $action_controls as $action ) {
111
-			if ( isset( $groups[ $action->id_base ] ) || in_array( $action->id_base, $grouped ) ) {
111
+			if ( isset( $groups[$action->id_base] ) || in_array( $action->id_base, $grouped ) ) {
112 112
 				continue;
113 113
 			}
114 114
 
115 115
 			$this_group = $action->action_options['group'];
116
-			if ( ! isset( $groups[ $this_group ] ) ) {
116
+			if ( ! isset( $groups[$this_group] ) ) {
117 117
 				$this_group = 'misc';
118 118
 			}
119 119
 
120
-			if ( ! isset( $groups[ $this_group ]['actions'] ) ) {
121
-				$groups[ $this_group ]['actions'] = array();
120
+			if ( ! isset( $groups[$this_group]['actions'] ) ) {
121
+				$groups[$this_group]['actions'] = array();
122 122
 			}
123
-			$groups[ $this_group ]['actions'][] = $action->id_base;
123
+			$groups[$this_group]['actions'][] = $action->id_base;
124 124
 
125 125
 			unset( $action );
126 126
 		}
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 				return $a;
271 271
 			}
272 272
 
273
-			$actions[ $a->id_base ] = $a;
273
+			$actions[$a->id_base] = $a;
274 274
 		}
275 275
 
276 276
 		return $actions;
@@ -301,16 +301,16 @@  discard block
 block discarded – undo
301 301
 		$action_map = array();
302 302
 
303 303
 		foreach ( $action_controls as $key => $control ) {
304
-			$action_map[ $control->id_base ] = $key;
304
+			$action_map[$control->id_base] = $key;
305 305
 		}
306 306
 
307 307
 		foreach ( $form_actions as $action ) {
308
-			if ( ! isset( $action_map[ $action->post_excerpt ] ) ) {
308
+			if ( ! isset( $action_map[$action->post_excerpt] ) ) {
309 309
 				// don't try and show settings if action no longer exists
310 310
 				continue;
311 311
 			}
312 312
 
313
-			self::action_control( $action, $form, $action->ID, $action_controls[ $action_map[ $action->post_excerpt ] ], $values );
313
+			self::action_control( $action, $form, $action->ID, $action_controls[$action_map[$action->post_excerpt]], $values );
314 314
 		}
315 315
 	}
316 316
 
@@ -539,8 +539,8 @@  discard block
 block discarded – undo
539 539
 			}
540 540
 
541 541
 			// Store actions so they can be triggered with the correct priority.
542
-			$stored_actions[ $action->ID ]  = $action;
543
-			$action_priority[ $action->ID ] = $link_settings[ $action->post_excerpt ]->action_options['priority'];
542
+			$stored_actions[$action->ID]  = $action;
543
+			$action_priority[$action->ID] = $link_settings[$action->post_excerpt]->action_options['priority'];
544 544
 
545 545
 			unset( $action );
546 546
 		}//end foreach
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
 			new FrmNotification();
553 553
 
554 554
 			foreach ( $action_priority as $action_id => $priority ) {
555
-				$action = $stored_actions[ $action_id ];
555
+				$action = $stored_actions[$action_id];
556 556
 
557 557
 				/**
558 558
 				 * Allows custom form action trigger.
@@ -613,12 +613,12 @@  discard block
 block discarded – undo
613 613
 	}
614 614
 
615 615
 	public function register( $action_class ) {
616
-		$this->actions[ $action_class ] = new $action_class();
616
+		$this->actions[$action_class] = new $action_class();
617 617
 	}
618 618
 
619 619
 	public function unregister( $action_class ) {
620
-		if ( isset( $this->actions[ $action_class ] ) ) {
621
-			unset( $this->actions[ $action_class ] );
620
+		if ( isset( $this->actions[$action_class] ) ) {
621
+			unset( $this->actions[$action_class] );
622 622
 		}
623 623
 	}
624 624
 
@@ -627,8 +627,8 @@  discard block
 block discarded – undo
627 627
 
628 628
 		foreach ( $keys as $key ) {
629 629
 			// don't register new action if old action with the same id is already registered
630
-			if ( ! isset( $this->actions[ $key ] ) ) {
631
-				$this->actions[ $key ]->_register();
630
+			if ( ! isset( $this->actions[$key] ) ) {
631
+				$this->actions[$key]->_register();
632 632
 			}
633 633
 		}
634 634
 	}
Please login to merge, or discard this patch.
classes/controllers/FrmEntriesAJAXSubmitController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 			foreach ( $errors as $field => $error ) {
89 89
 				$field_id         = str_replace( 'field', '', $field );
90 90
 				$error            = self::maybe_modify_ajax_error( $error, $field_id, $form, $errors );
91
-				$obj[ $field_id ] = $error;
91
+				$obj[$field_id] = $error;
92 92
 			}
93 93
 
94 94
 			$response['errors']        = $obj;
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 	private static function fix_woocommerce_conflict() {
120 120
 		add_action(
121 121
 			'wp_print_footer_scripts',
122
-			function () {
122
+			function() {
123 123
 				if ( ! function_exists( 'get_current_screen' ) ) {
124 124
 					require_once ABSPATH . 'wp-admin/includes/screen.php';
125 125
 				}
Please login to merge, or discard this patch.
classes/controllers/FrmElementorController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 		if ( is_admin() ) {
19 19
 			add_action(
20 20
 				'elementor/editor/after_enqueue_styles',
21
-				function () {
21
+				function() {
22 22
 					wp_enqueue_style( 'font_icons', FrmAppHelper::plugin_url() . '/css/font_icons.css', array(), FrmAppHelper::plugin_version() );
23 23
 				}
24 24
 			);
Please login to merge, or discard this patch.
classes/controllers/FrmApplicationsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@
 block discarded – undo
154 154
 	private static function sort_templates( $applications ) {
155 155
 		usort(
156 156
 			$applications,
157
-			function ( $a, $b ) {
157
+			function( $a, $b ) {
158 158
 				return strcmp( $a['name'], $b['name'] );
159 159
 			}
160 160
 		);
Please login to merge, or discard this patch.