Completed
Pull Request — master (#1580)
by Stephanie
48s
created
classes/controllers/FrmSettingsController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 				$section['function'] = $original;
159 159
 			}
160 160
 
161
-			$sections[ $key ] = $section;
161
+			$sections[$key] = $section;
162 162
 		}//end foreach
163 163
 
164 164
 		return $sections;
@@ -170,11 +170,11 @@  discard block
 block discarded – undo
170 170
 
171 171
 		$section  = FrmAppHelper::get_post_param( 'tab', '', 'sanitize_text_field' );
172 172
 		$sections = self::get_settings_tabs();
173
-		if ( ! isset( $sections[ $section ] ) ) {
173
+		if ( ! isset( $sections[$section] ) ) {
174 174
 			wp_die();
175 175
 		}
176 176
 
177
-		$section = $sections[ $section ];
177
+		$section = $sections[$section];
178 178
 
179 179
 		if ( isset( $section['class'] ) ) {
180 180
 			call_user_func( array( $section['class'], $section['function'] ) );
Please login to merge, or discard this patch.
classes/controllers/FrmFormsController.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1616,7 +1616,8 @@  discard block
 block discarded – undo
1616 1616
 		$vars   = array();
1617 1617
 		FrmAppHelper::include_svg();
1618 1618
 
1619
-		if ( isset( $_POST['frm_compact_fields'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1619
+		if ( isset( $_POST['frm_compact_fields'] ) ) {
1620
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1620 1621
 			FrmAppHelper::permission_check( 'frm_edit_forms' );
1621 1622
 
1622 1623
 			// Javascript needs to be allowed in some field settings.
@@ -2046,7 +2047,8 @@  discard block
 block discarded – undo
2046 2047
 	private static function get_saved_errors( $form, $params ) {
2047 2048
 		global $frm_vars;
2048 2049
 
2049
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2050
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
2051
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
2050 2052
 			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2051 2053
 		} else {
2052 2054
 			$errors = array();
Please login to merge, or discard this patch.
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -637,7 +637,7 @@  discard block
 block discarded – undo
637 637
 			 * @param string|null $src
638 638
 			 * @return string
639 639
 			 */
640
-			function ( $src ) {
640
+			function( $src ) {
641 641
 				if ( is_null( $src ) ) {
642 642
 					$src = '';
643 643
 				}
@@ -702,11 +702,11 @@  discard block
 block discarded – undo
702 702
 			),
703 703
 		);
704 704
 
705
-		if ( ! isset( $available_status[ $status ] ) ) {
705
+		if ( ! isset( $available_status[$status] ) ) {
706 706
 			return;
707 707
 		}
708 708
 
709
-		FrmAppHelper::permission_check( $available_status[ $status ]['permission'] );
709
+		FrmAppHelper::permission_check( $available_status[$status]['permission'] );
710 710
 
711 711
 		$params = FrmForm::list_page_params();
712 712
 
@@ -714,8 +714,8 @@  discard block
 block discarded – undo
714 714
 		check_admin_referer( $status . '_form_' . $params['id'] );
715 715
 
716 716
 		$count = 0;
717
-		if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
718
-			++$count;
717
+		if ( FrmForm::set_status( $params['id'], $available_status[$status]['new_status'] ) ) {
718
+			++ $count;
719 719
 		}
720 720
 
721 721
 		$form_type = FrmAppHelper::get_simple_request(
@@ -731,7 +731,7 @@  discard block
 block discarded – undo
731 731
 		/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
732 732
 		$available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
733 733
 
734
-		$message = $available_status[ $status ]['message'];
734
+		$message = $available_status[$status]['message'];
735 735
 
736 736
 		self::display_forms_list( $params, $message );
737 737
 	}
@@ -746,7 +746,7 @@  discard block
 block discarded – undo
746 746
 		$count = 0;
747 747
 		foreach ( $ids as $id ) {
748 748
 			if ( FrmForm::trash( $id ) ) {
749
-				++$count;
749
+				++ $count;
750 750
 			}
751 751
 		}
752 752
 
@@ -756,7 +756,7 @@  discard block
 block discarded – undo
756 756
 				'type'  => 'request',
757 757
 			)
758 758
 		);
759
-		$message      = sprintf(
759
+		$message = sprintf(
760 760
 			/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
761 761
 			_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
762 762
 			$count,
@@ -777,7 +777,7 @@  discard block
 block discarded – undo
777 777
 
778 778
 		$count = 0;
779 779
 		if ( FrmForm::destroy( $params['id'] ) ) {
780
-			++$count;
780
+			++ $count;
781 781
 		}
782 782
 
783 783
 		/* translators: %1$s: Number of forms */
@@ -797,7 +797,7 @@  discard block
 block discarded – undo
797 797
 		foreach ( $ids as $id ) {
798 798
 			$d = FrmForm::destroy( $id );
799 799
 			if ( $d ) {
800
-				++$count;
800
+				++ $count;
801 801
 			}
802 802
 		}
803 803
 
@@ -1286,7 +1286,7 @@  discard block
 block discarded – undo
1286 1286
 
1287 1287
 		add_action(
1288 1288
 			'wp_enqueue_editor',
1289
-			function () {
1289
+			function() {
1290 1290
 				wp_print_media_templates();
1291 1291
 			}
1292 1292
 		);
@@ -1391,7 +1391,7 @@  discard block
 block discarded – undo
1391 1391
 
1392 1392
 		foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
1393 1393
 			if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
1394
-				unset( $sections[ $feature ] );
1394
+				unset( $sections[$feature] );
1395 1395
 			}
1396 1396
 		}
1397 1397
 
@@ -1419,7 +1419,7 @@  discard block
 block discarded – undo
1419 1419
 				$section['id'] = $section['anchor'];
1420 1420
 			}
1421 1421
 
1422
-			$sections[ $key ] = $section;
1422
+			$sections[$key] = $section;
1423 1423
 		}//end foreach
1424 1424
 
1425 1425
 		return $sections;
@@ -1542,7 +1542,7 @@  discard block
 block discarded – undo
1542 1542
 		if ( $user_fields ) {
1543 1543
 			$user_helpers = array();
1544 1544
 			foreach ( $user_fields as $uk => $uf ) {
1545
-				$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
1545
+				$user_helpers['|user_id| show="' . $uk . '"'] = $uf;
1546 1546
 				unset( $uk, $uf );
1547 1547
 			}
1548 1548
 
@@ -1681,7 +1681,7 @@  discard block
 block discarded – undo
1681 1681
 		if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
1682 1682
 			$frm_vars['js_validate_forms'] = array();
1683 1683
 		}
1684
-		$frm_vars['js_validate_forms'][ $form->id ] = $form;
1684
+		$frm_vars['js_validate_forms'][$form->id] = $form;
1685 1685
 	}
1686 1686
 
1687 1687
 	public static function get_email_html() {
@@ -1844,7 +1844,7 @@  discard block
 block discarded – undo
1844 1844
 				add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
1845 1845
 			} else {
1846 1846
 				$vars   = FrmAppHelper::json_to_array( $json_vars );
1847
-				$action = $vars[ $action ];
1847
+				$action = $vars[$action];
1848 1848
 				unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1849 1849
 				$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1850 1850
 				$_POST    = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -2010,7 +2010,7 @@  discard block
 block discarded – undo
2010 2010
 		$actions = array();
2011 2011
 		foreach ( $frm_vars['forms_loaded'] as $form ) {
2012 2012
 			if ( is_object( $form ) ) {
2013
-				$actions[ $form->id ] = $form->name;
2013
+				$actions[$form->id] = $form->name;
2014 2014
 			}
2015 2015
 			unset( $form );
2016 2016
 		}
@@ -2255,8 +2255,8 @@  discard block
 block discarded – undo
2255 2255
 	private static function get_saved_errors( $form, $params ) {
2256 2256
 		global $frm_vars;
2257 2257
 
2258
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2259
-			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2258
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2259
+			$errors = $frm_vars['created_entries'][$form->id]['errors'];
2260 2260
 		} else {
2261 2261
 			$errors = array();
2262 2262
 		}
@@ -2278,7 +2278,7 @@  discard block
 block discarded – undo
2278 2278
 	public static function just_created_entry( $form_id ) {
2279 2279
 		global $frm_vars;
2280 2280
 
2281
-		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
2281
+		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][$form_id] ) && isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ? $frm_vars['created_entries'][$form_id]['entry_id'] : 0;
2282 2282
 	}
2283 2283
 
2284 2284
 	/**
@@ -2298,7 +2298,7 @@  discard block
 block discarded – undo
2298 2298
 	private static function get_confirmation_method( $atts ) {
2299 2299
 		$action = FrmOnSubmitHelper::current_event( $atts );
2300 2300
 		$opt    = 'update' === $action ? 'edit_action' : 'success_action';
2301
-		$method = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
2301
+		$method = ! empty( $atts['form']->options[$opt] ) ? $atts['form']->options[$opt] : 'message';
2302 2302
 
2303 2303
 		if ( ! empty( $atts['entry_id'] ) ) {
2304 2304
 			$met_actions = self::get_met_on_submit_actions( $atts, $action );
@@ -2319,7 +2319,7 @@  discard block
 block discarded – undo
2319 2319
 	public static function maybe_trigger_redirect( $form, $params, $args ) {
2320 2320
 		if ( ! isset( $params['id'] ) ) {
2321 2321
 			global $frm_vars;
2322
-			$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
2322
+			$params['id'] = $frm_vars['created_entries'][$form->id]['entry_id'];
2323 2323
 		}
2324 2324
 
2325 2325
 		$conf_method = self::get_confirmation_method(
@@ -2401,7 +2401,7 @@  discard block
 block discarded – undo
2401 2401
 		$args['success_opt'] = $opt;
2402 2402
 		$args['ajax']        = ! empty( $frm_vars['ajax'] );
2403 2403
 
2404
-		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[ $opt . '_page_id' ] ) ) {
2404
+		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[$opt . '_page_id'] ) ) {
2405 2405
 			self::load_page_after_submit( $args );
2406 2406
 		} elseif ( $args['conf_method'] === 'redirect' ) {
2407 2407
 			self::redirect_after_submit( $args );
@@ -2425,7 +2425,7 @@  discard block
 block discarded – undo
2425 2425
 		}
2426 2426
 
2427 2427
 		// If a redirect action has already opened the URL in a new tab, we show the default message in the currect tab.
2428
-		if ( ! empty( self::$redirected_in_new_tab[ $args['form']->id ] ) ) {
2428
+		if ( ! empty( self::$redirected_in_new_tab[$args['form']->id] ) ) {
2429 2429
 			return array( FrmOnSubmitHelper::get_fallback_action_after_open_in_new_tab( $event ) );
2430 2430
 		}
2431 2431
 
@@ -2613,7 +2613,7 @@  discard block
 block discarded – undo
2613 2613
 
2614 2614
 		$opt = 'update' === $args['action'] ? 'edit_' : 'success_';
2615 2615
 
2616
-		$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
2616
+		$new_args['conf_method'] = $new_args['form']->options[$opt . 'action'];
2617 2617
 
2618 2618
 		/**
2619 2619
 		 * Filters the run success action args.
@@ -2633,8 +2633,8 @@  discard block
 block discarded – undo
2633 2633
 	private static function load_page_after_submit( $args ) {
2634 2634
 		global $post;
2635 2635
 		$opt = $args['success_opt'];
2636
-		if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
2637
-			$page     = get_post( $args['form']->options[ $opt . '_page_id' ] );
2636
+		if ( ! $post || $args['form']->options[$opt . '_page_id'] != $post->ID ) {
2637
+			$page     = get_post( $args['form']->options[$opt . '_page_id'] );
2638 2638
 			$old_post = $post;
2639 2639
 			$post     = $page;
2640 2640
 			$content  = apply_filters( 'frm_content', $page->post_content, $args['form'], $args['entry_id'] );
@@ -2664,7 +2664,7 @@  discard block
 block discarded – undo
2664 2664
 		add_filter( 'frm_use_wpautop', '__return_false' );
2665 2665
 
2666 2666
 		$opt         = $args['success_opt'];
2667
-		$success_url = trim( $args['form']->options[ $opt . '_url' ] );
2667
+		$success_url = trim( $args['form']->options[$opt . '_url'] );
2668 2668
 		$success_url = apply_filters( 'frm_content', $success_url, $args['form'], $args['entry_id'] );
2669 2669
 		$success_url = do_shortcode( $success_url );
2670 2670
 
@@ -2686,7 +2686,7 @@  discard block
 block discarded – undo
2686 2686
 			// Not AJAX submit, no headers sent, and there is just one Redirect action runs.
2687 2687
 			if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
2688 2688
 				self::print_open_in_new_tab_js_with_fallback_handler( $success_url, $args );
2689
-				self::$redirected_in_new_tab[ $args['form']->id ] = 1;
2689
+				self::$redirected_in_new_tab[$args['form']->id] = 1;
2690 2690
 				return;
2691 2691
 			}
2692 2692
 
@@ -2946,7 +2946,7 @@  discard block
 block discarded – undo
2946 2946
 			'description' => false,
2947 2947
 			'reset'       => false,
2948 2948
 		);
2949
-		$args     = wp_parse_args( $args, $defaults );
2949
+		$args = wp_parse_args( $args, $defaults );
2950 2950
 	}
2951 2951
 
2952 2952
 	/**
@@ -2984,7 +2984,7 @@  discard block
 block discarded – undo
2984 2984
 		$opt          = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
2985 2985
 
2986 2986
 		if ( $entry_id && is_numeric( $entry_id ) ) {
2987
-			$message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
2987
+			$message = isset( $form->options[$opt . '_msg'] ) ? $form->options[$opt . '_msg'] : $frm_settings->success_msg;
2988 2988
 			$class   = 'frm_message';
2989 2989
 		} else {
2990 2990
 			$message = $frm_settings->failed_msg;
@@ -3207,8 +3207,8 @@  discard block
 block discarded – undo
3207 3207
 
3208 3208
 		check_ajax_referer( 'frm_ajax', 'nonce' );
3209 3209
 
3210
-		$html             = FrmAppHelper::clip(
3211
-			function () {
3210
+		$html = FrmAppHelper::clip(
3211
+			function() {
3212 3212
 				FrmAppHelper::maybe_autocomplete_pages_options(
3213 3213
 					array(
3214 3214
 						'field_name'  => 'frm_page_dropdown',
Please login to merge, or discard this patch.
classes/models/FrmEntryValidate.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,8 @@
 block discarded – undo
145 145
 
146 146
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
147 147
 			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
148
-		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
148
+		} elseif ( ! isset( $_POST['item_name'] ) ) {
149
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
149 150
 			self::maybe_add_item_name( $value, $posted_field );
150 151
 		}
151 152
 
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 			return $errors;
21 21
 		}
22 22
 
23
-		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) {
23
+		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values['frm_submit_entry_' . $values['form_id']] ) || ! wp_verify_nonce( $values['frm_submit_entry_' . $values['form_id']], 'frm_submit_entry_nonce' ) ) ) {
24 24
 			$frm_settings   = FrmAppHelper::get_settings();
25 25
 			$errors['form'] = $frm_settings->admin_permission;
26 26
 		}
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 		$args = wp_parse_args( $args, $defaults );
124 124
 
125 125
 		if ( empty( $args['parent_field_id'] ) ) {
126
-			$value = isset( $values['item_meta'][ $args['id'] ] ) ? $values['item_meta'][ $args['id'] ] : '';
126
+			$value = isset( $values['item_meta'][$args['id']] ) ? $values['item_meta'][$args['id']] : '';
127 127
 		} else {
128 128
 			// value is from a nested form
129 129
 			$value = $values;
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 		}
145 145
 
146 146
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
147
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
147
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
148 148
 		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
149 149
 			self::maybe_add_item_name( $value, $posted_field );
150 150
 		}
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 			$pattern = self::phone_format( $field );
227 227
 
228 228
 			if ( ! preg_match( $pattern, $value ) ) {
229
-				$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
229
+				$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
230 230
 			}
231 231
 		}
232 232
 	}
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
 	 */
337 337
 	private static function form_is_in_progress( $values ) {
338 338
 		return FrmAppHelper::pro_is_installed() &&
339
-			( isset( $values[ 'frm_page_order_' . $values['form_id'] ] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
339
+			( isset( $values['frm_page_order_' . $values['form_id']] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
340 340
 			FrmField::get_all_types_in_form( $values['form_id'], 'break' );
341 341
 	}
342 342
 
@@ -581,9 +581,9 @@  discard block
 block discarded – undo
581 581
 			foreach ( $datas['missing_keys'] as $key_index => $key ) {
582 582
 				$found = self::is_akismet_guest_info_value( $key, $value, $field_id, $datas['name_field_ids'] );
583 583
 				if ( $found ) {
584
-					$datas[ $key ]             = $value;
584
+					$datas[$key]             = $value;
585 585
 					$datas['frm_duplicated'][] = $field_id;
586
-					unset( $datas['missing_keys'][ $key_index ] );
586
+					unset( $datas['missing_keys'][$key_index] );
587 587
 				}
588 588
 			}
589 589
 		}//end foreach
@@ -629,7 +629,7 @@  discard block
 block discarded – undo
629 629
 
630 630
 			// Send any potentially useful $_SERVER vars, but avoid sending junk we don't need.
631 631
 			if ( $include_value ) {
632
-				$datas[ $key ] = $value;
632
+				$datas[$key] = $value;
633 633
 			}
634 634
 			unset( $key, $value );
635 635
 		}
@@ -646,10 +646,10 @@  discard block
 block discarded – undo
646 646
 	private static function add_comment_content_to_akismet( &$datas, $values ) {
647 647
 		if ( isset( $datas['frm_duplicated'] ) ) {
648 648
 			foreach ( $datas['frm_duplicated'] as $index ) {
649
-				if ( isset( $values['item_meta'][ $index ] ) ) {
650
-					unset( $values['item_meta'][ $index ] );
649
+				if ( isset( $values['item_meta'][$index] ) ) {
650
+					unset( $values['item_meta'][$index] );
651 651
 				} else {
652
-					unset( $values[ $index ] );
652
+					unset( $values[$index] );
653 653
 				}
654 654
 			}
655 655
 			unset( $datas['frm_duplicated'] );
@@ -670,14 +670,14 @@  discard block
 block discarded – undo
670 670
 	private static function skip_adding_values_to_akismet( &$values ) {
671 671
 		$skipped_fields = self::get_akismet_skipped_field_ids( $values );
672 672
 		foreach ( $skipped_fields as $skipped_field ) {
673
-			if ( ! isset( $values['item_meta'][ $skipped_field->id ] ) ) {
673
+			if ( ! isset( $values['item_meta'][$skipped_field->id] ) ) {
674 674
 				continue;
675 675
 			}
676 676
 
677 677
 			if ( self::should_really_skip_field( $skipped_field, $values ) ) {
678
-				unset( $values['item_meta'][ $skipped_field->id ] );
679
-				if ( isset( $values['item_meta']['other'][ $skipped_field->id ] ) ) {
680
-					unset( $values['item_meta']['other'][ $skipped_field->id ] );
678
+				unset( $values['item_meta'][$skipped_field->id] );
679
+				if ( isset( $values['item_meta']['other'][$skipped_field->id] ) ) {
680
+					unset( $values['item_meta']['other'][$skipped_field->id] );
681 681
 				}
682 682
 			}
683 683
 		}
@@ -713,14 +713,14 @@  discard block
 block discarded – undo
713 713
 		}
714 714
 
715 715
 		// If a choice field has Other option, but Other is not selected.
716
-		if ( empty( $values['item_meta']['other'][ $field_data->id ] ) ) {
716
+		if ( empty( $values['item_meta']['other'][$field_data->id] ) ) {
717 717
 			return true;
718 718
 		}
719 719
 
720 720
 		// Check if submitted value is same as one of field option.
721 721
 		foreach ( $field_data->options as $option ) {
722 722
 			$option_value = ! is_array( $option ) ? $option : ( isset( $option['value'] ) ? $option['value'] : '' );
723
-			if ( $values['item_meta']['other'][ $field_data->id ] === $option_value ) {
723
+			if ( $values['item_meta']['other'][$field_data->id] === $option_value ) {
724 724
 				return true;
725 725
 			}
726 726
 		}
@@ -791,7 +791,7 @@  discard block
 block discarded – undo
791 791
 
792 792
 			// Convert name array to string.
793 793
 			if ( isset( $value['first'] ) && isset( $value['last'] ) ) {
794
-				$values['item_meta'][ $field_id ] = trim( implode( ' ', $value ) );
794
+				$values['item_meta'][$field_id] = trim( implode( ' ', $value ) );
795 795
 				$values['name_field_ids'][]       = $field_id;
796 796
 				continue;
797 797
 			}
@@ -812,8 +812,8 @@  discard block
 block discarded – undo
812 812
 						continue;
813 813
 					}
814 814
 
815
-					if ( ! isset( $values['item_meta'][ $subsubindex ] ) ) {
816
-						$values['item_meta'][ $subsubindex ] = array();
815
+					if ( ! isset( $values['item_meta'][$subsubindex] ) ) {
816
+						$values['item_meta'][$subsubindex] = array();
817 817
 					}
818 818
 
819 819
 					// Convert name array to string.
@@ -823,11 +823,11 @@  discard block
 block discarded – undo
823 823
 						$values['name_field_ids'][] = $subsubindex;
824 824
 					}
825 825
 
826
-					$values['item_meta'][ $subsubindex ][] = $subsubvalue;
826
+					$values['item_meta'][$subsubindex][] = $subsubvalue;
827 827
 				}
828 828
 			}//end foreach
829 829
 
830
-			unset( $values['item_meta'][ $field_id ] );
830
+			unset( $values['item_meta'][$field_id] );
831 831
 		}//end foreach
832 832
 
833 833
 		return $form_ids;
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldNumber.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
 		// Validate the number format.
72 72
 		if ( ! is_numeric( $args['value'] ) && '' !== $args['value'] ) {
73
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
73
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
74 74
 		}
75 75
 
76 76
 		// validate number settings
@@ -82,9 +82,9 @@  discard block
 block discarded – undo
82 82
 			if ( $frm_settings->use_html && $maxnum !== '' && $minnum !== '' ) {
83 83
 				$value = (float) $args['value'];
84 84
 				if ( $value < $minnum ) {
85
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a higher number', 'formidable' );
85
+					$errors['field' . $args['id']] = __( 'Please select a higher number', 'formidable' );
86 86
 				} elseif ( $value > $maxnum ) {
87
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a lower number', 'formidable' );
87
+					$errors['field' . $args['id']] = __( 'Please select a lower number', 'formidable' );
88 88
 				}
89 89
 			}
90 90
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 	 * @return void
106 106
 	 */
107 107
 	private function validate_step( &$errors, $args ) {
108
-		if ( isset( $errors[ 'field' . $args['id'] ] ) ) {
108
+		if ( isset( $errors['field' . $args['id']] ) ) {
109 109
 			// Don't need to check if value is invalid before.
110 110
 			return;
111 111
 		}
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 			return;
121 121
 		}
122 122
 
123
-		$errors[ 'field' . $args['id'] ] = sprintf(
123
+		$errors['field' . $args['id']] = sprintf(
124 124
 			// Translators: %1$s: the first nearest value; %2$s: the second nearest value.
125 125
 			__( 'Please enter a valid value. Two nearest valid values are %1$s and %2$s', 'formidable' ),
126 126
 			floatval( $result[0] ),
Please login to merge, or discard this patch.
classes/models/FrmAddon.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -465,7 +465,8 @@
 block discarded – undo
465 465
 	}
466 466
 
467 467
 	private function is_license_revoked() {
468
-		if ( empty( $this->license ) || empty( $this->plugin_slug ) || isset( $_POST['license'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
468
+		if ( empty( $this->license ) || empty( $this->plugin_slug ) || isset( $_POST['license'] ) ) {
469
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
469 470
 			return;
470 471
 		}
471 472
 
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	}
71 71
 
72 72
 	public function insert_installed_addon( $plugins ) {
73
-		$plugins[ $this->plugin_slug ] = $this;
73
+		$plugins[$this->plugin_slug] = $this;
74 74
 
75 75
 		return $plugins;
76 76
 	}
@@ -78,8 +78,8 @@  discard block
 block discarded – undo
78 78
 	public static function get_addon( $plugin_slug ) {
79 79
 		$plugins = apply_filters( 'frm_installed_addons', array() );
80 80
 		$plugin  = false;
81
-		if ( isset( $plugins[ $plugin_slug ] ) ) {
82
-			$plugin = $plugins[ $plugin_slug ];
81
+		if ( isset( $plugins[$plugin_slug] ) ) {
82
+			$plugin = $plugins[$plugin_slug];
83 83
 		}
84 84
 
85 85
 		return $plugin;
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 		} else {
140 140
 			$api     = new FrmFormApi( $this->license );
141 141
 			$plugins = $api->get_api_info();
142
-			$_data   = $plugins[ $item_id ];
142
+			$_data   = $plugins[$item_id];
143 143
 		}
144 144
 
145 145
 		$_data['sections'] = array(
@@ -380,19 +380,19 @@  discard block
 block discarded – undo
380 380
 
381 381
 		if ( $this->is_current_version( $transient ) ) {
382 382
 			// Make sure it doesn't show there is an update if plugin is up-to-date.
383
-			if ( isset( $transient->response[ $this->plugin_folder ] ) ) {
384
-				unset( $transient->response[ $this->plugin_folder ] );
383
+			if ( isset( $transient->response[$this->plugin_folder] ) ) {
384
+				unset( $transient->response[$this->plugin_folder] );
385 385
 			}
386
-		} elseif ( isset( $transient->response ) && isset( $transient->response[ $this->plugin_folder ] ) ) {
387
-			$this->prepare_update_details( $transient->response[ $this->plugin_folder ] );
386
+		} elseif ( isset( $transient->response ) && isset( $transient->response[$this->plugin_folder] ) ) {
387
+			$this->prepare_update_details( $transient->response[$this->plugin_folder] );
388 388
 
389 389
 			// if the transient has expired, clear the update and trigger it again
390
-			if ( $transient->response[ $this->plugin_folder ] === false ) {
390
+			if ( $transient->response[$this->plugin_folder] === false ) {
391 391
 				if ( ! $this->has_been_cleared() ) {
392 392
 					$this->cleared_plugins();
393 393
 					$this->manually_queue_update();
394 394
 				}
395
-				unset( $transient->response[ $this->plugin_folder ] );
395
+				unset( $transient->response[$this->plugin_folder] );
396 396
 			}
397 397
 		}
398 398
 
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
 	}
483 483
 
484 484
 	private function is_current_version( $transient ) {
485
-		if ( empty( $transient->checked ) || ! isset( $transient->checked[ $this->plugin_folder ] ) ) {
485
+		if ( empty( $transient->checked ) || ! isset( $transient->checked[$this->plugin_folder] ) ) {
486 486
 			return false;
487 487
 		}
488 488
 
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
 			return true;
492 492
 		}
493 493
 
494
-		return isset( $transient->response ) && isset( $transient->response[ $this->plugin_folder ] ) && $transient->checked[ $this->plugin_folder ] === $transient->response[ $this->plugin_folder ]->new_version;
494
+		return isset( $transient->response ) && isset( $transient->response[$this->plugin_folder] ) && $transient->checked[$this->plugin_folder] === $transient->response[$this->plugin_folder]->new_version;
495 495
 	}
496 496
 
497 497
 	/**
@@ -633,8 +633,8 @@  discard block
 block discarded – undo
633 633
 			$response['message'] = $response['status'];
634 634
 		} else {
635 635
 			$messages = $this->get_messages();
636
-			if ( is_string( $response['status'] ) && isset( $messages[ $response['status'] ] ) ) {
637
-				$response['message'] = $messages[ $response['status'] ];
636
+			if ( is_string( $response['status'] ) && isset( $messages[$response['status']] ) ) {
637
+				$response['message'] = $messages[$response['status']];
638 638
 			} else {
639 639
 				$response['message'] = FrmAppHelper::kses( $response['status'], array( 'a' ) );
640 640
 			}
@@ -796,7 +796,7 @@  discard block
 block discarded – undo
796 796
 			'user-agent' => $this->plugin_slug . '/' . $this->version . '; ' . get_bloginfo( 'url' ),
797 797
 		);
798 798
 
799
-		$resp              = wp_remote_post(
799
+		$resp = wp_remote_post(
800 800
 			$this->store_url . '?l=' . urlencode( base64_encode( $this->license ) ),
801 801
 			$arg_array
802 802
 		);
Please login to merge, or discard this patch.
stripe/controllers/FrmStrpLiteActionsController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 			$gateway   = $payment_action->post_content['gateway'];
48 48
 			$is_stripe = $gateway === 'stripe' || ( is_array( $gateway ) && in_array( 'stripe', $gateway, true ) );
49 49
 			if ( ! $is_stripe || empty( $payment_action->post_content['amount'] ) ) {
50
-				unset( $payment_actions[ $k ] );
50
+				unset( $payment_actions[$k] );
51 51
 			}
52 52
 		}
53 53
 		return $payment_actions;
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 			'run_triggers' => false,
85 85
 			'show_errors'  => true,
86 86
 		);
87
-		$atts     = compact( 'action', 'entry', 'form' );
87
+		$atts = compact( 'action', 'entry', 'form' );
88 88
 
89 89
 		$amount = self::prepare_amount( $action->post_content['amount'], $atts );
90 90
 		if ( empty( $amount ) || $amount == 000 ) {
@@ -502,7 +502,7 @@  discard block
 block discarded – undo
502 502
 		$disallowed = array( ';', ':', '!important' );
503 503
 		foreach ( $settings as $k => $s ) {
504 504
 			if ( is_string( $s ) ) {
505
-				$settings[ $k ] = str_replace( $disallowed, '', $s );
505
+				$settings[$k] = str_replace( $disallowed, '', $s );
506 506
 			}
507 507
 		}
508 508
 
@@ -574,18 +574,18 @@  discard block
 block discarded – undo
574 574
 	 * @return array
575 575
 	 */
576 576
 	public static function remove_cc_validation( $errors, $field, $values ) {
577
-		$has_processed = isset( $_POST[ 'frmintent' . $field->form_id ] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
577
+		$has_processed = isset( $_POST['frmintent' . $field->form_id] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
578 578
 		if ( ! $has_processed ) {
579 579
 			return $errors;
580 580
 		}
581 581
 
582 582
 		$field_id = isset( $field->temp_id ) ? $field->temp_id : $field->id;
583 583
 
584
-		if ( isset( $errors[ 'field' . $field_id . '-cc' ] ) ) {
585
-			unset( $errors[ 'field' . $field_id . '-cc' ] );
584
+		if ( isset( $errors['field' . $field_id . '-cc'] ) ) {
585
+			unset( $errors['field' . $field_id . '-cc'] );
586 586
 		}
587
-		if ( isset( $errors[ 'field' . $field_id ] ) ) {
588
-			unset( $errors[ 'field' . $field_id ] );
587
+		if ( isset( $errors['field' . $field_id] ) ) {
588
+			unset( $errors['field' . $field_id] );
589 589
 		}
590 590
 
591 591
 		return $errors;
Please login to merge, or discard this patch.
classes/models/FrmEntryFormatter.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -164,8 +164,8 @@  discard block
 block discarded – undo
164 164
 
165 165
 		$conditionally_add = array( 'include_fields', 'fields', 'exclude_fields', 'entry' );
166 166
 		foreach ( $conditionally_add as $index ) {
167
-			if ( isset( $atts[ $index ] ) ) {
168
-				$entry_atts[ $index ] = $atts[ $index ];
167
+			if ( isset( $atts[$index] ) ) {
168
+				$entry_atts[$index] = $atts[$index];
169 169
 			}
170 170
 		}
171 171
 
@@ -351,8 +351,8 @@  discard block
 block discarded – undo
351 351
 
352 352
 		$unset = array( 'id', 'form_id', 'format' );
353 353
 		foreach ( $unset as $param ) {
354
-			if ( isset( $atts[ $param ] ) ) {
355
-				unset( $atts[ $param ] );
354
+			if ( isset( $atts[$param] ) ) {
355
+				unset( $atts[$param] );
356 356
 			}
357 357
 		}
358 358
 
@@ -523,11 +523,11 @@  discard block
 block discarded – undo
523 523
 
524 524
 			$displayed_value = $this->prepare_display_value_for_array( $field_value->get_displayed_value() );
525 525
 
526
-			$output[ $this->get_key_or_id( $field_value ) ] = $displayed_value;
526
+			$output[$this->get_key_or_id( $field_value )] = $displayed_value;
527 527
 
528 528
 			$has_separate_value = (bool) $field_value->get_field_option( 'separate_value' );
529 529
 			if ( $has_separate_value || $displayed_value !== $field_value->get_saved_value() ) {
530
-				$output[ $this->get_key_or_id( $field_value ) . '-value' ] = $field_value->get_saved_value();
530
+				$output[$this->get_key_or_id( $field_value ) . '-value'] = $field_value->get_saved_value();
531 531
 			}
532 532
 		}
533 533
 	}
@@ -917,7 +917,7 @@  discard block
 block discarded – undo
917 917
 
918 918
 			if ( is_array( $value ) ) {
919 919
 				foreach ( $value as $key => $single_value ) {
920
-					$value[ $key ] = $this->strip_html( $single_value );
920
+					$value[$key] = $this->strip_html( $single_value );
921 921
 				}
922 922
 			} elseif ( $this->is_plain_text && ! is_array( $value ) ) {
923 923
 				if ( strpos( $value, '<img' ) !== false ) {
Please login to merge, or discard this patch.
classes/views/frm-fields/back-end/html-content.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
 		<?php esc_html_e( 'Content', 'formidable' ); ?>
10 10
 	</label>
11 11
 	<?php
12
-	$e_args  = array(
12
+	$e_args = array(
13 13
 		'textarea_name' => 'field_options[description_' . absint( $field['id'] ) . ']',
14 14
 		'textarea_rows' => 8,
15 15
 	);
Please login to merge, or discard this patch.
classes/models/FrmYoutubeFeedApi.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,8 +40,8 @@
 block discarded – undo
40 40
 	 */
41 41
 	public function get_video( $type = 'welcome' ) {
42 42
 		$videos = $this->get_api_info();
43
-		if ( isset( $videos[ $type ] ) ) {
44
-			return $videos[ $type ];
43
+		if ( isset( $videos[$type] ) ) {
44
+			return $videos[$type];
45 45
 		}
46 46
 		return array();
47 47
 	}
Please login to merge, or discard this patch.