Strategy11 / formidable-forms

classes/models/FrmPluginSearch.php

Spacing +8 added lines, -8 removed lines

@@ -80,20 +80,20 @@ 
 			'name'              => sprintf(
 				/* translators: Formidable addon name */
 				esc_html_x( 'Formidable %s', 'Formidable Addon Name', 'formidable' ),
-				$addon_list[ $matching_addon ]['name']
+				$addon_list[$matching_addon]['name']
 			),
-			'addon'             => $addon_list[ $matching_addon ]['slug'],
-			'short_description' => $addon_list[ $matching_addon ]['excerpt'],
+			'addon'             => $addon_list[$matching_addon]['slug'],
+			'short_description' => $addon_list[$matching_addon]['excerpt'],
 			'slug'              => self::$slug,
-			'version'           => $addon_list[ $matching_addon ]['version'],
+			'version'           => $addon_list[$matching_addon]['version'],
 		);
 
-		if ( ! empty( $addon_list[ $matching_addon ]['external'] ) ) {
+		if ( ! empty( $addon_list[$matching_addon]['external'] ) ) {
 			unset( $overrides['name'] );
 		}
 
 		// Splice in the base addon data.
-		$inject = array_merge( $inject, $addon_list[ $matching_addon ], $overrides );
+		$inject = array_merge( $inject, $addon_list[$matching_addon], $overrides );
 
 		// Add it to the top of the list.
 		array_unshift( $result->plugins, $inject );
@@ -308,7 +308,7 @@ 
 		// Plugin installed, active, feature not enabled; prompt to enable.
 		if ( ! $is_active && $is_installed ) {
 			if ( current_user_can( 'activate_plugins' ) ) {
-				$activate_url             = add_query_arg(
+				$activate_url = add_query_arg(
 					array(
 						'action'   => 'activate',
 						'_wpnonce' => wp_create_nonce( 'activate-plugin_' . $plugin['plugin'] ),
@@ -352,7 +352,7 @@ 
 	 */
 	protected function is_installed( $plugin ) {
 		$all_plugins = FrmAppHelper::get_plugins();
-		return isset( $all_plugins[ $plugin ] );
+		return isset( $all_plugins[$plugin] );
 	}
 
 	/**

classes/controllers/FrmOverlayController.php

Spacing +3 added lines, -3 removed lines

@@ -85,7 +85,7 @@ 
 	private function update_next_execution_time() {
 		$config_option_name = $this->config['config-option-name'];
 
-		$this->options_data[ $config_option_name ] = $this->get_next_execution();
+		$this->options_data[$config_option_name] = $this->get_next_execution();
 		$this->update_options_data();
 	}
 
@@ -104,11 +104,11 @@ 
 	 * @return bool
 	 */
 	private function is_time_to_execute() {
-		if ( ! isset( $this->options_data[ $this->config['config-option-name'] ] ) ) {
+		if ( ! isset( $this->options_data[$this->config['config-option-name']] ) ) {
 			return true;
 		}
 
-		$options = $this->options_data[ $this->config['config-option-name'] ];
+		$options = $this->options_data[$this->config['config-option-name']];
 
 		return ! ( isset( $options['timestamp'] ) && (int) $options['timestamp'] > $this->get_time() );
 	}

classes/models/FrmEmail.php

Spacing +5 added lines, -5 removed lines

@@ -162,7 +162,7 @@ 
 		$to = $this->prepare_email_setting( $this->settings['email_to'], $user_id_args );
 		$to = $this->explode_emails( $to );
 
-		$where  = array(
+		$where = array(
 			'it.field_id !' => 0,
 			'it.item_id'    => $this->entry->id,
 		);
@@ -172,7 +172,7 @@ 
 			'entry'     => $this->entry,
 			'form'      => $this->form,
 		);
-		$to     = apply_filters( 'frm_to_email', $to, $values, $this->form->id, $args );
+		$to = apply_filters( 'frm_to_email', $to, $values, $this->form->id, $args );
 
 		$this->to = array_unique( (array) $to );
 
@@ -702,11 +702,11 @@ 
 				$name = trim( str_replace( $email, '', $val ) );
 			} else {
 				// If user enters a name without an email
-				unset( $recipients[ $key ] );
+				unset( $recipients[$key] );
 				continue;
 			}
 
-			$recipients[ $key ] = $this->format_from_email( $name, $email );
+			$recipients[$key] = $this->format_from_email( $name, $email );
 		}//end foreach
 
 		return $recipients;
@@ -856,7 +856,7 @@ 
 				);
 
 				// Remove phone number from to addresses
-				unset( $this->to[ $key ] );
+				unset( $this->to[$key] );
 			}//end if
 		}//end foreach
 	}

classes/views/xml/posts_xml.php

Spacing +2 added lines, -2 removed lines

@@ -113,8 +113,8 @@
 	$label         = 'category' === $term->taxonomy || 'tag' === $term->taxonomy ? $term->taxonomy : 'term';
 	?>
 	<term><term_id><?php echo esc_html( $term->term_id ); ?></term_id><term_taxonomy><?php echo esc_html( $term->taxonomy ); ?></term_taxonomy><?php
-	if ( ! empty( $parent_slugs[ $term->parent ] ) ) {
-		echo '<term_parent>' . esc_html( $parent_slugs[ $term->parent ] ) . '</term_parent>';
+	if ( ! empty( $parent_slugs[$term->parent] ) ) {
+		echo '<term_parent>' . esc_html( $parent_slugs[$term->parent] ) . '</term_parent>';
 	}
 	if ( ! empty( $term->name ) ) {
 		echo '<term_name>' . FrmXMLHelper::cdata( $term->name ) . '</term_name>'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped

classes/helpers/FrmStylesCardHelper.php

Spacing +10 added lines, -10 removed lines

@@ -138,11 +138,11 @@ 
 	private static function has_dark_background( $style ) {
 		$key = 'fieldset_bg_color';
 
-		if ( empty( $style->post_content[ $key ] ) ) {
+		if ( empty( $style->post_content[$key] ) ) {
 			return false;
 		}
 
-		$color = $style->post_content[ $key ];
+		$color = $style->post_content[$key];
 
 		if ( 0 === strpos( $color, 'rgba' ) ) {
 			preg_match_all( '/([\\d.]+)/', $color, $matches );
@@ -201,7 +201,7 @@ 
 			 * @param stdClass $style_object
 			 * @param array    $style
 			 */
-			$param_filter = function ( $params, $args ) use ( $style_object, $style ) {
+			$param_filter = function( $params, $args ) use ( $style_object, $style ) {
 				if ( $args['style'] !== $style_object ) {
 					return $params;
 				}
@@ -214,7 +214,7 @@ 
 					),
 					'/style-templates/' . $style['slug']
 				);
-				$params['data-requires']    = FrmFormsHelper::get_plan_required( $style );
+				$params['data-requires'] = FrmFormsHelper::get_plan_required( $style );
 				return $params;
 			};
 		} else {
@@ -225,7 +225,7 @@ 
 			 * @param array $style
 			 * @return array
 			 */
-			$param_filter = function ( $params ) use ( $style ) {
+			$param_filter = function( $params ) use ( $style ) {
 				$params['data-template-key'] = $style['slug'];
 				return $params;
 			};
@@ -277,7 +277,7 @@ 
 				continue;
 			}
 
-			$value = $style->post_content[ $key ];
+			$value = $style->post_content[$key];
 
 			$is_hex = in_array( $key, $color_settings, true ) && $value && '#' !== $value[0] && false === strpos( $value, 'rgb' ) && $value !== 'transparent';
 			if ( $is_hex ) {
@@ -396,7 +396,7 @@ 
 			 * @param int          $count Used for pagination.
 			 * @return void
 			 */
-			function ( $style, $key ) {
+			function( $style, $key ) {
 				if ( ! is_numeric( $key ) ) {
 					// Skip active_sub/expires keys.
 					return;
@@ -423,10 +423,10 @@ 
 			 * @param int     $count Used for pagination.
 			 * @return void
 			 */
-			function ( $style ) use ( &$count ) {
+			function( $style ) use ( &$count ) {
 				$hidden = $count > self::PAGE_SIZE - 1;
 				$this->echo_style_card( $style, $hidden );
-				++$count;
+				++ $count;
 			}
 		);
 
@@ -484,7 +484,7 @@ 
 			 * @param WP_Post $style
 			 * @return bool
 			 */
-			function ( $style ) {
+			function( $style ) {
 				return $this->default_style->ID !== $style->ID;
 			}
 		);

classes/helpers/FrmStylesPreviewHelper.php

Spacing +6 added lines, -6 removed lines

@@ -74,7 +74,7 @@ 
 			 * @param array|object $field
 			 * @return string
 			 */
-			function ( $position, $field ) {
+			function( $position, $field ) {
 				if ( is_array( $field ) ) {
 					$this->default_label_position_field_ids[] = (int) $field['id'];
 				}
@@ -91,7 +91,7 @@ 
 			 * @param array|object $field
 			 * @return string
 			 */
-			function ( $classes, $field ) {
+			function( $classes, $field ) {
 				if ( is_array( $field ) && in_array( (int) $field['id'], $this->default_label_position_field_ids, true ) ) {
 					$classes .= ' frm-default-label-position';
 				}
@@ -118,7 +118,7 @@ 
 			 * @param string $target_field_type
 			 * @return bool
 			 */
-			function ( $show, $field_type ) {
+			function( $show, $field_type ) {
 				if ( 'captcha' === $field_type ) {
 					$show = false;
 				}
@@ -146,7 +146,7 @@ 
 			 * @param int           $form_id
 			 * @return stdClass|null
 			 */
-			function ( $form ) {
+			function( $form ) {
 				if ( is_object( $form ) && is_array( $form->options ) ) {
 					$form->options['js_validate'] = false;
 				}
@@ -196,7 +196,7 @@ 
 
 		$frm_settings = FrmAppHelper::get_settings();
 		if ( 'none' === $frm_settings->load_style ) {
-			$notes[] = function () {
+			$notes[] = function() {
 				printf(
 					// translators: %1$s: Anchor tag open, %2$s: Anchor tag close.
 					esc_html__( 'Formidable styles are disabled. This needs to be enabled in %1$sGlobal Settings%2$s.', 'formidable' ),
@@ -354,7 +354,7 @@ 
 			return;
 		}
 
-		unset( $dependencies[ $index ] );
+		unset( $dependencies[$index] );
 		$dependencies = array_values( $dependencies );
 
 		$styles->registered['wp-admin']->deps = $dependencies;

classes/helpers/FrmListHelper.php

Spacing +15 added lines, -15 removed lines

@@ -223,8 +223,8 @@ 
 			return $this->get_pagenum();
 		}
 
-		if ( isset( $this->_pagination_args[ $key ] ) ) {
-			return $this->_pagination_args[ $key ];
+		if ( isset( $this->_pagination_args[$key] ) ) {
+			return $this->_pagination_args[$key];
 		}
 	}
 
@@ -269,8 +269,8 @@ 
 	}
 
 	private function hidden_search_inputs( $param_name ) {
-		if ( ! empty( $_REQUEST[ $param_name ] ) ) {
-			$value = sanitize_text_field( wp_unslash( $_REQUEST[ $param_name ] ) );
+		if ( ! empty( $_REQUEST[$param_name] ) ) {
+			$value = sanitize_text_field( wp_unslash( $_REQUEST[$param_name] ) );
 			echo '<input type="hidden" name="' . esc_attr( $param_name ) . '" value="' . esc_attr( $value ) . '" />';
 		}
 	}
@@ -312,7 +312,7 @@ 
 
 		echo "<ul class='subsubsub'>\n";
 		foreach ( $views as $class => $view ) {
-			$views[ $class ] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
+			$views[$class] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
 		}
 		echo implode( " |</li>\n", $views ) . "</li>\n"; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 		echo '</ul>';
@@ -461,7 +461,7 @@ 
 
 		$out = '<div class="' . ( $always_visible ? 'row-actions visible' : 'row-actions' ) . '">';
 		foreach ( $actions as $action => $link ) {
-			++$i;
+			++ $i;
 			$sep  = $i == $action_count ? '' : ' | ';
 			$out .= "<span class='$action'>$link$sep</span>";
 		}
@@ -684,7 +684,7 @@ 
 			'next'  => __( 'Next page', 'formidable' ),
 		);
 
-		return $labels[ $link ];
+		return $labels[$link];
 	}
 
 	private function current_url() {
@@ -774,7 +774,7 @@ 
 
 		// If the primary column doesn't exist fall back to the
 		// first non-checkbox column.
-		if ( ! isset( $columns[ $default ] ) ) {
+		if ( ! isset( $columns[$default] ) ) {
 			$default = self::get_default_primary_column_name();
 		}
 
@@ -788,7 +788,7 @@ 
 		 */
 		$column = apply_filters( 'list_table_primary_column', $default, $this->screen->id );
 
-		if ( empty( $column ) || ! isset( $columns[ $column ] ) ) {
+		if ( empty( $column ) || ! isset( $columns[$column] ) ) {
 			$column = $default;
 		}
 
@@ -809,7 +809,7 @@ 
 			// In 4.3, we added a fourth argument for primary column.
 			$column_headers = array( array(), array(), array(), $this->get_primary_column_name() );
 			foreach ( $this->_column_headers as $key => $value ) {
-				$column_headers[ $key ] = $value;
+				$column_headers[$key] = $value;
 			}
 
 			return $column_headers;
@@ -842,7 +842,7 @@ 
 				$data[1] = false;
 			}
 
-			$sortable[ $id ] = $data;
+			$sortable[$id] = $data;
 		}
 
 		$primary = $this->get_primary_column_name();
@@ -898,7 +898,7 @@ 
 			static $cb_counter = 1;
 			$columns['cb']     = '<label class="screen-reader-text" for="cb-select-all-' . $cb_counter . '">' . __( 'Select All', 'formidable' ) . '</label>';
 			$columns['cb']    .= '<input id="cb-select-all-' . esc_attr( $cb_counter ) . '" type="checkbox" />';
-			++$cb_counter;
+			++ $cb_counter;
 		}
 
 		foreach ( $columns as $column_key => $column_display_name ) {
@@ -920,8 +920,8 @@ 
 				$class[] = 'column-primary';
 			}
 
-			if ( isset( $sortable[ $column_key ] ) ) {
-				list( $orderby, $desc_first ) = $sortable[ $column_key ];
+			if ( isset( $sortable[$column_key] ) ) {
+				list( $orderby, $desc_first ) = $sortable[$column_key];
 
 				if ( $current_orderby == $orderby ) {
 					// The sorted column. The `aria-sort` attribute must be set only on the sorted column.
@@ -1034,7 +1034,7 @@ 
 	 * @return bool Returns true if the setting is not set or if it is not false; otherwise, returns false.
 	 */
 	protected function should_display( $args, $settings ) {
-		return ! isset( $args[ $settings ] ) || false !== $args[ $settings ];
+		return ! isset( $args[$settings] ) || false !== $args[$settings];
 	}
 
 	/**

classes/views/dashboard/templates/counters.php

Braces +10 added lines, -4 removed lines

@@ -14,20 +14,26 @@
 				<h4><?php echo esc_html( $counter['heading'] ); ?></h4>
 				<?php if ( isset( $counter['cta'] ) && isset( $counter['cta']['display'] ) && true === $counter['cta']['display'] ) : ?>
 					<a href="<?php echo esc_url( $counter['cta']['link'] ); ?>"><?php echo esc_html( $counter['cta']['title'] ); ?></a>
-				<?php else : ?>
+				<?php else {
+	: ?>
 					<?php if ( 'currency' === $counter['type'] ) : ?>
 						<div class="frm-flex-box frm-gap-md">
 							<?php foreach ( $counter['items'] as $item ) : ?>
 								<b>
-									<?php echo esc_attr( $item['counter_label']['symbol_left'] ); ?>
+									<?php echo esc_attr( $item['counter_label']['symbol_left'] );
+}
+?>
 									<span class="frm-counter" data-type="<?php echo esc_attr( $counter['type'] ); ?>" data-locale="<?php echo esc_attr( get_locale() ); ?>" data-counter="<?php echo (int) $item['counter']; ?>"><?php echo (int) $item['counter']; ?></span>
 									<?php echo esc_attr( $item['counter_label']['symbol_right'] ); ?>
 								</b>
 							<?php endforeach; ?>
 						</div>
-					<?php else : ?>
+					<?php else {
+	: ?>
 						<b>
-							<span class="frm-counter" data-type="<?php echo esc_attr( $counter['type'] ); ?>" data-locale="<?php echo esc_attr( get_locale() ); ?>" data-counter="<?php echo (int) $counter['counter']; ?>"><?php echo (int) $counter['counter']; ?></span>
+							<span class="frm-counter" data-type="<?php echo esc_attr( $counter['type'] );
+}
+?>" data-locale="<?php echo esc_attr( get_locale() ); ?>" data-counter="<?php echo (int) $counter['counter']; ?>"><?php echo (int) $counter['counter']; ?></span>
 						</b>
 					<?php endif; ?>
 				<?php endif; ?>

classes/controllers/FrmXMLController.php

Spacing +11 added lines, -11 removed lines

@@ -163,7 +163,7 @@ 
 			return;
 		}
 
-		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][ $selected_form ] ) ? $form['xml'][ $selected_form ] : '';
+		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][$selected_form] ) ? $form['xml'][$selected_form] : '';
 		if ( empty( $selected_xml ) || strpos( $selected_xml, 'http' ) !== 0 ) {
 			return;
 		}
@@ -178,8 +178,8 @@ 
 	 * @param string $value
 	 */
 	private static function get_selected_in_form( $form, $value = 'form' ) {
-		if ( ! empty( $form ) && ! empty( $form[ $value ] ) ) {
-			return $form[ $value ];
+		if ( ! empty( $form ) && ! empty( $form[$value] ) ) {
+			return $form[$value];
 		}
 
 		return '';
@@ -208,7 +208,7 @@ 
 			}
 
 			if ( $for === 'view' ) {
-				$item_key  = is_array( $view_keys ) ? $view_keys[ $form_key ] : $view_keys;
+				$item_key  = is_array( $view_keys ) ? $view_keys[$form_key] : $view_keys;
 				$shortcode = '[display-frm-data id=%1$s filter=limited]';
 			} elseif ( $for === 'form' ) {
 				$item_key  = $form_key;
@@ -223,7 +223,7 @@ 
 				continue;
 			}
 
-			$page_ids[ $for ] = wp_insert_post(
+			$page_ids[$for] = wp_insert_post(
 				array(
 					'post_title'   => $name,
 					'post_type'    => 'page',
@@ -376,7 +376,7 @@ 
 		// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
 		$file_type = sanitize_option( 'upload_path', $_FILES['frm_import_file']['name'] );
 		$file_type = strtolower( pathinfo( $file_type, PATHINFO_EXTENSION ) );
-		if ( 'xml' !== $file_type && isset( $export_format[ $file_type ] ) ) {
+		if ( 'xml' !== $file_type && isset( $export_format[$file_type] ) ) {
 			// allow other file types to be imported
 			do_action( 'frm_before_import_' . $file_type );
 
@@ -470,7 +470,7 @@ 
 		foreach ( $type as $tb_type ) {
 			$where = array();
 			$join  = '';
-			$table = $tables[ $tb_type ];
+			$table = $tables[$tb_type];
 
 			$select     = $table . '.id';
 			$query_vars = array();
@@ -485,7 +485,7 @@ 
 							$table . '.parent_form_id' => $args['ids'],
 						);
 					} else {
-						$where[ $table . '.status !' ] = 'draft';
+						$where[$table . '.status !'] = 'draft';
 					}
 					break;
 				case 'actions':
@@ -498,7 +498,7 @@ 
 				case 'items':
 					// $join = "INNER JOIN {$wpdb->prefix}frm_item_metas im ON ($table.id = im.item_id)";
 					if ( $args['ids'] ) {
-						$where[ $table . '.form_id' ] = $args['ids'];
+						$where[$table . '.form_id'] = $args['ids'];
 					}
 					break;
 				case 'styles':
@@ -539,7 +539,7 @@ 
 					}
 			}//end switch
 
-			$records[ $tb_type ] = FrmDb::get_col( $table . $join, $where, $select );
+			$records[$tb_type] = FrmDb::get_col( $table . $join, $where, $select );
 			unset( $tb_type );
 		}//end foreach
 
@@ -734,7 +734,7 @@ 
 		$no_export_fields = FrmField::no_save_fields();
 		foreach ( $csv_fields as $k => $f ) {
 			if ( in_array( $f->type, $no_export_fields, true ) ) {
-				unset( $csv_fields[ $k ] );
+				unset( $csv_fields[$k] );
 			}
 		}