Completed
Pull Request — master (#1038)
by Stephanie
01:05
created
classes/helpers/FrmStylesHelper.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -285,7 +285,8 @@
 block discarded – undo
285 285
 	public static function get_settings_for_output( $style ) {
286 286
 		if ( self::previewing_style() ) {
287 287
 			$frm_style = new FrmStyle();
288
-			if ( isset( $_POST['frm_style_setting'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
288
+			if ( isset( $_POST['frm_style_setting'] ) ) {
289
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
289 290
 
290 291
 				// Sanitizing is done later.
291 292
 				$posted = wp_unslash( $_POST['frm_style_setting'] ); //phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 				'-' => 'down',
136 136
 				'+' => 'up',
137 137
 			);
138
-			$class = 'frm_arrow' . $arrow[ $icon ];
138
+			$class = 'frm_arrow' . $arrow[$icon];
139 139
 		} else {
140 140
 			//frm_minus1_icon
141 141
 			$key   = str_replace( 'p', '', $key );
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 				'-' => 'minus',
144 144
 				'+' => 'plus',
145 145
 			);
146
-			$class = 'frm_' . $plus[ $icon ];
146
+			$class = 'frm_' . $plus[$icon];
147 147
 		}
148 148
 
149 149
 		if ( $key ) {
@@ -169,8 +169,8 @@  discard block
 block discarded – undo
169 169
 		?>
170 170
 		<div class="btn-group" id="frm_<?php echo esc_attr( $name ); ?>_select">
171 171
 			<button class="multiselect dropdown-toggle btn btn-default" data-toggle="dropdown" type="button">
172
-				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[ $name ], '+', $type ) ); ?>
173
-				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[ $name ], '-', $type ) ); ?>
172
+				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[$name], '+', $type ) ); ?>
173
+				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[$name], '-', $type ) ); ?>
174 174
 				<b class="caret"></b>
175 175
 			</button>
176 176
 			<ul class="multiselect-container frm-dropdown-menu">
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 					<li <?php echo ( $style->post_content['collapse_icon'] == $key ) ? 'class="active"' : ''; ?>>
179 179
 						<a href="javascript:void(0);">
180 180
 							<label>
181
-								<input type="radio" value="<?php echo esc_attr( $key ); ?>" name="<?php echo esc_attr( $frm_style->get_field_name( $name ) ); ?>" <?php checked( $style->post_content[ $name ], $key ); ?> />
181
+								<input type="radio" value="<?php echo esc_attr( $key ); ?>" name="<?php echo esc_attr( $frm_style->get_field_name( $name ) ); ?>" <?php checked( $style->post_content[$name], $key ); ?> />
182 182
 								<span>
183 183
 									<?php
184 184
 									FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $key, '+', $type ) );
@@ -271,15 +271,15 @@  discard block
 block discarded – undo
271 271
 		$vars   = array_diff( $vars, $remove );
272 272
 
273 273
 		foreach ( $vars as $var ) {
274
-			if ( ! isset( $settings[ $var ] ) ) {
274
+			if ( ! isset( $settings[$var] ) ) {
275 275
 				continue;
276 276
 			}
277
-			if ( ! isset( $defaults[ $var ] ) ) {
278
-				$defaults[ $var ] = '';
277
+			if ( ! isset( $defaults[$var] ) ) {
278
+				$defaults[$var] = '';
279 279
 			}
280
-			$show = empty( $defaults ) || ( $settings[ $var ] !== '' && $settings[ $var ] !== $defaults[ $var ] );
280
+			$show = empty( $defaults ) || ( $settings[$var] !== '' && $settings[$var] !== $defaults[$var] );
281 281
 			if ( $show ) {
282
-				echo '--' . esc_html( str_replace( '_', '-', $var ) ) . ':' . ( $var === 'font' ? FrmAppHelper::kses( $settings[ $var ] ) : esc_html( $settings[ $var ] ) ) . ';'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
282
+				echo '--' . esc_html( str_replace( '_', '-', $var ) ) . ':' . ( $var === 'font' ? FrmAppHelper::kses( $settings[$var] ) : esc_html( $settings[$var] ) ) . ';'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
283 283
 			}
284 284
 		}
285 285
 	}
@@ -328,8 +328,8 @@  discard block
 block discarded – undo
328 328
 
329 329
 		$checkbox_opts = array( 'important_style', 'auto_width', 'submit_style', 'collapse_icon', 'center_form' );
330 330
 		foreach ( $checkbox_opts as $opt ) {
331
-			if ( ! isset( $settings[ $opt ] ) ) {
332
-				$settings[ $opt ] = 0;
331
+			if ( ! isset( $settings[$opt] ) ) {
332
+				$settings[$opt] = 0;
333 333
 			}
334 334
 		}
335 335
 
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
 				$css = '';
358 358
 			}
359 359
 			foreach ( $opts as $opt ) {
360
-				self::get_color_output( $css, $settings[ $opt ] );
360
+				self::get_color_output( $css, $settings[$opt] );
361 361
 			}
362 362
 		}
363 363
 	}
Please login to merge, or discard this patch.
classes/helpers/FrmStylesPreviewHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@
 block discarded – undo
168 168
 			return;
169 169
 		}
170 170
 
171
-		unset( $dependencies[ $index ] );
171
+		unset( $dependencies[$index] );
172 172
 		$dependencies = array_values( $dependencies );
173 173
 
174 174
 		$styles->registered['wp-admin']->deps = $dependencies;
Please login to merge, or discard this patch.
classes/helpers/FrmStylesCardHelper.php 3 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -349,12 +349,12 @@
 block discarded – undo
349 349
 		array_walk(
350 350
 			$styles,
351 351
 			/**
352
-			* Echo a style card for a single style in the $styles array.
353
-			*
354
-			* @param WP_Post $style
355
-			* @param int     $count Used for pagination.
356
-			* @return void
357
-			*/
352
+			 * Echo a style card for a single style in the $styles array.
353
+			 *
354
+			 * @param WP_Post $style
355
+			 * @param int     $count Used for pagination.
356
+			 * @return void
357
+			 */
358 358
 			function( $style ) use ( &$count ) {
359 359
 				$hidden = $count > ( self::PAGE_SIZE - 1 );
360 360
 				$this->echo_style_card( $style, $hidden );
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 	 * @param bool             $hidden
81 81
 	 * @return array
82 82
 	 */
83
-	private function get_params_for_style_card( $style, $hidden = false ) {	
83
+	private function get_params_for_style_card( $style, $hidden = false ) {
84 84
 		if ( ! empty( $style->post_content['position'] ) ) {
85 85
 			$label_position = $style->post_content['position'];
86 86
 		} else {
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -130,11 +130,11 @@  discard block
 block discarded – undo
130 130
 	private static function has_dark_background( $style ) {
131 131
 		$key = 'fieldset_bg_color';
132 132
 
133
-		if ( empty( $style->post_content[ $key ] ) ) {
133
+		if ( empty( $style->post_content[$key] ) ) {
134 134
 			return false;
135 135
 		}
136 136
 
137
-		$color = $style->post_content[ $key ];
137
+		$color = $style->post_content[$key];
138 138
 
139 139
 		if ( 0 === strpos( $color, 'rgba' ) ) {
140 140
 			preg_match_all( "/([\\d.]+)/", $color, $matches );
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 			if ( isset( $matches[1][3] ) && is_numeric( $matches[1][3] ) ) {
143 143
 				// Consider a faded out rgba value as light even when the color is dark.
144 144
 				$color_opacity = floatval( $matches[1][3] );
145
-				if ( $color_opacity  < 0.5 ) {
145
+				if ( $color_opacity < 0.5 ) {
146 146
 					return false;
147 147
 				}
148 148
 			}
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 					),
205 205
 					'/style-templates/' . $style['slug']
206 206
 				);
207
-				$params['data-requires']    = FrmFormsHelper::get_plan_required( $style );
207
+				$params['data-requires'] = FrmFormsHelper::get_plan_required( $style );
208 208
 				return $params;
209 209
 			};
210 210
 		} else {
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
 				continue;
262 262
 			}
263 263
 
264
-			$value = $style->post_content[ $key ];
264
+			$value = $style->post_content[$key];
265 265
 
266 266
 			if ( in_array( $key, $color_settings, true ) && $value && '#' !== $value[0] && false === strpos( $value, 'rgb' ) ) {
267 267
 				$value = '#' . $value;
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
 			function( $style ) use ( &$count ) {
412 412
 				$hidden = $count > ( self::PAGE_SIZE - 1 );
413 413
 				$this->echo_style_card( $style, $hidden );
414
-				++$count;
414
+				++ $count;
415 415
 			}
416 416
 		);
417 417
 
Please login to merge, or discard this patch.
classes/controllers/FrmFormsController.php 2 patches
Braces   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1697,7 +1697,8 @@  discard block
 block discarded – undo
1697 1697
 		$vars   = array();
1698 1698
 		FrmAppHelper::include_svg();
1699 1699
 
1700
-		if ( isset( $_POST['frm_compact_fields'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1700
+		if ( isset( $_POST['frm_compact_fields'] ) ) {
1701
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1701 1702
 			FrmAppHelper::permission_check( 'frm_edit_forms' );
1702 1703
 
1703 1704
 			// Javascript needs to be allowed in some field settings.
@@ -2007,7 +2008,8 @@  discard block
 block discarded – undo
2007 2008
 	private static function maybe_get_form_to_show( $id ) {
2008 2009
 		$form = false;
2009 2010
 
2010
-		if ( ! empty( $id ) ) { // form id or key is set
2011
+		if ( ! empty( $id ) ) {
2012
+// form id or key is set
2011 2013
 			$form = FrmForm::getOne( $id );
2012 2014
 			if ( ! $form || $form->parent_form_id || $form->status === 'trash' ) {
2013 2015
 				$form = false;
@@ -2090,7 +2092,8 @@  discard block
 block discarded – undo
2090 2092
 	private static function get_saved_errors( $form, $params ) {
2091 2093
 		global $frm_vars;
2092 2094
 
2093
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2095
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
2096
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
2094 2097
 			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2095 2098
 		} else {
2096 2099
 			$errors = array();
@@ -2243,7 +2246,8 @@  discard block
 block discarded – undo
2243 2246
 			}
2244 2247
 
2245 2248
 			if ( 'redirect' === FrmOnSubmitHelper::get_action_type( $action ) ) {
2246
-				if ( $has_redirect ) { // Do not process because we run the first redirect action only.
2249
+				if ( $has_redirect ) {
2250
+// Do not process because we run the first redirect action only.
2247 2251
 					continue;
2248 2252
 				}
2249 2253
 
@@ -2402,12 +2406,14 @@  discard block
 block discarded – undo
2402 2406
 
2403 2407
 		$doing_ajax = FrmAppHelper::doing_ajax();
2404 2408
 
2405
-		if ( ! empty( $args['ajax'] ) && $doing_ajax && empty( $args['force_delay_redirect'] ) ) { // Is AJAX submit and there is just one Redirect action runs.
2409
+		if ( ! empty( $args['ajax'] ) && $doing_ajax && empty( $args['force_delay_redirect'] ) ) {
2410
+// Is AJAX submit and there is just one Redirect action runs.
2406 2411
 			echo json_encode( array( 'redirect' => $success_url ) );
2407 2412
 			wp_die();
2408 2413
 		}
2409 2414
 
2410
-		if ( ! headers_sent() && empty( $args['force_delay_redirect'] ) ) { // Not AJAX submit, no headers sent, and there is just one Redirect action runs.
2415
+		if ( ! headers_sent() && empty( $args['force_delay_redirect'] ) ) {
2416
+// Not AJAX submit, no headers sent, and there is just one Redirect action runs.
2411 2417
 			wp_redirect( esc_url_raw( $success_url ) );
2412 2418
 			die(); // do not use wp_die or redirect fails
2413 2419
 		}
@@ -2432,7 +2438,8 @@  discard block
 block discarded – undo
2432 2438
 
2433 2439
 		echo FrmAppHelper::maybe_kses( $redirect_msg ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
2434 2440
 		echo '<script>';
2435
-		if ( empty( $args['doing_ajax'] ) ) { // Not AJAX submit, delay JS until window.load.
2441
+		if ( empty( $args['doing_ajax'] ) ) {
2442
+// Not AJAX submit, delay JS until window.load.
2436 2443
 			echo 'window.onload=function(){';
2437 2444
 		}
2438 2445
 		echo 'setTimeout(function(){window.location="' . esc_url_raw( $args['success_url'] ) . '";}, ' . intval( $delay_time ) . ');';
Please login to merge, or discard this patch.
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -511,11 +511,11 @@  discard block
 block discarded – undo
511 511
 			),
512 512
 		);
513 513
 
514
-		if ( ! isset( $available_status[ $status ] ) ) {
514
+		if ( ! isset( $available_status[$status] ) ) {
515 515
 			return;
516 516
 		}
517 517
 
518
-		FrmAppHelper::permission_check( $available_status[ $status ]['permission'] );
518
+		FrmAppHelper::permission_check( $available_status[$status]['permission'] );
519 519
 
520 520
 		$params = FrmForm::list_page_params();
521 521
 
@@ -523,7 +523,7 @@  discard block
 block discarded – undo
523 523
 		check_admin_referer( $status . '_form_' . $params['id'] );
524 524
 
525 525
 		$count = 0;
526
-		if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
526
+		if ( FrmForm::set_status( $params['id'], $available_status[$status]['new_status'] ) ) {
527 527
 			$count ++;
528 528
 		}
529 529
 
@@ -540,7 +540,7 @@  discard block
 block discarded – undo
540 540
 		/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
541 541
 		$available_status['trash']['message']   = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
542 542
 
543
-		$message = $available_status[ $status ]['message'];
543
+		$message = $available_status[$status]['message'];
544 544
 
545 545
 		self::display_forms_list( $params, $message );
546 546
 	}
@@ -561,7 +561,7 @@  discard block
 block discarded – undo
561 561
 				'type'  => 'request',
562 562
 			)
563 563
 		);
564
-		$message      = sprintf(
564
+		$message = sprintf(
565 565
 			/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
566 566
 			_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
567 567
 			$count,
@@ -1000,11 +1000,11 @@  discard block
 block discarded – undo
1000 1000
 			}
1001 1001
 
1002 1002
 			foreach ( $template['categories'] as $category ) {
1003
-				if ( ! isset( $templates_by_category[ $category ] ) ) {
1004
-					$templates_by_category[ $category ] = array();
1003
+				if ( ! isset( $templates_by_category[$category] ) ) {
1004
+					$templates_by_category[$category] = array();
1005 1005
 				}
1006 1006
 
1007
-				$templates_by_category[ $category ][] = $template;
1007
+				$templates_by_category[$category][] = $template;
1008 1008
 			}
1009 1009
 		}
1010 1010
 		unset( $template );
@@ -1033,7 +1033,7 @@  discard block
 block discarded – undo
1033 1033
 		$forms                    = FrmForm::get_published_forms( $where );
1034 1034
 		$view_path                = FrmAppHelper::plugin_path() . '/classes/views/frm-forms/';
1035 1035
 
1036
-		$templates_by_category[ $my_templates_translation ] = $custom_templates;
1036
+		$templates_by_category[$my_templates_translation] = $custom_templates;
1037 1037
 
1038 1038
 		unset( $pricing, $license_type, $where );
1039 1039
 		wp_enqueue_script( 'accordion' ); // register accordion for template groups
@@ -1276,7 +1276,7 @@  discard block
 block discarded – undo
1276 1276
 
1277 1277
 		foreach ( array( 'landing', 'chat' ) as $feature ) {
1278 1278
 			if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
1279
-				unset( $sections[ $feature ] );
1279
+				unset( $sections[$feature] );
1280 1280
 			}
1281 1281
 		}
1282 1282
 
@@ -1309,7 +1309,7 @@  discard block
 block discarded – undo
1309 1309
 				$section['id'] = $section['anchor'];
1310 1310
 			}
1311 1311
 
1312
-			$sections[ $key ] = $section;
1312
+			$sections[$key] = $section;
1313 1313
 		}
1314 1314
 
1315 1315
 		return $sections;
@@ -1427,7 +1427,7 @@  discard block
 block discarded – undo
1427 1427
 		if ( ! empty( $user_fields ) ) {
1428 1428
 			$user_helpers = array();
1429 1429
 			foreach ( $user_fields as $uk => $uf ) {
1430
-				$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
1430
+				$user_helpers['|user_id| show="' . $uk . '"'] = $uf;
1431 1431
 				unset( $uk, $uf );
1432 1432
 			}
1433 1433
 
@@ -1559,7 +1559,7 @@  discard block
 block discarded – undo
1559 1559
 		if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
1560 1560
 			$frm_vars['js_validate_forms'] = array();
1561 1561
 		}
1562
-		$frm_vars['js_validate_forms'][ $form->id ] = $form;
1562
+		$frm_vars['js_validate_forms'][$form->id] = $form;
1563 1563
 	}
1564 1564
 
1565 1565
 	public static function get_email_html() {
@@ -1714,7 +1714,7 @@  discard block
 block discarded – undo
1714 1714
 				add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
1715 1715
 			} else {
1716 1716
 				$vars   = FrmAppHelper::json_to_array( $json_vars );
1717
-				$action = $vars[ $action ];
1717
+				$action = $vars[$action];
1718 1718
 				unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1719 1719
 				$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1720 1720
 				$_POST    = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -1848,7 +1848,7 @@  discard block
 block discarded – undo
1848 1848
 		$actions = array();
1849 1849
 		foreach ( $frm_vars['forms_loaded'] as $form ) {
1850 1850
 			if ( is_object( $form ) ) {
1851
-				$actions[ $form->id ] = $form->name;
1851
+				$actions[$form->id] = $form->name;
1852 1852
 			}
1853 1853
 			unset( $form );
1854 1854
 		}
@@ -2090,8 +2090,8 @@  discard block
 block discarded – undo
2090 2090
 	private static function get_saved_errors( $form, $params ) {
2091 2091
 		global $frm_vars;
2092 2092
 
2093
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2094
-			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2093
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2094
+			$errors = $frm_vars['created_entries'][$form->id]['errors'];
2095 2095
 		} else {
2096 2096
 			$errors = array();
2097 2097
 		}
@@ -2113,7 +2113,7 @@  discard block
 block discarded – undo
2113 2113
 	public static function just_created_entry( $form_id ) {
2114 2114
 		global $frm_vars;
2115 2115
 
2116
-		return ( isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
2116
+		return ( isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][$form_id] ) && isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ) ? $frm_vars['created_entries'][$form_id]['entry_id'] : 0;
2117 2117
 	}
2118 2118
 
2119 2119
 	/**
@@ -2137,7 +2137,7 @@  discard block
 block discarded – undo
2137 2137
 		}
2138 2138
 
2139 2139
 		$opt    = 'success_action';
2140
-		$method = ( isset( $atts['form']->options[ $opt ] ) && ! empty( $atts['form']->options[ $opt ] ) ) ? $atts['form']->options[ $opt ] : 'message';
2140
+		$method = ( isset( $atts['form']->options[$opt] ) && ! empty( $atts['form']->options[$opt] ) ) ? $atts['form']->options[$opt] : 'message';
2141 2141
 		$method = apply_filters( 'frm_success_filter', $method, $atts['form'], 'create' );
2142 2142
 
2143 2143
 		if ( $method != 'message' && ( ! $atts['entry_id'] || ! is_numeric( $atts['entry_id'] ) ) ) {
@@ -2150,7 +2150,7 @@  discard block
 block discarded – undo
2150 2150
 	public static function maybe_trigger_redirect( $form, $params, $args ) {
2151 2151
 		if ( ! isset( $params['id'] ) ) {
2152 2152
 			global $frm_vars;
2153
-			$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
2153
+			$params['id'] = $frm_vars['created_entries'][$form->id]['entry_id'];
2154 2154
 		}
2155 2155
 
2156 2156
 		$conf_method = self::get_confirmation_method(
@@ -2209,7 +2209,7 @@  discard block
 block discarded – undo
2209 2209
 		$args['success_opt'] = $opt;
2210 2210
 		$args['ajax']        = ! empty( $frm_vars['ajax'] );
2211 2211
 
2212
-		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[ $opt . '_page_id' ] ) ) {
2212
+		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[$opt . '_page_id'] ) ) {
2213 2213
 			self::load_page_after_submit( $args );
2214 2214
 		} elseif ( $args['conf_method'] === 'redirect' ) {
2215 2215
 			self::redirect_after_submit( $args );
@@ -2351,7 +2351,7 @@  discard block
 block discarded – undo
2351 2351
 
2352 2352
 		$opt = 'update' === $args['action'] ? 'edit_' : 'success_';
2353 2353
 
2354
-		$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
2354
+		$new_args['conf_method'] = $new_args['form']->options[$opt . 'action'];
2355 2355
 
2356 2356
 		/**
2357 2357
 		 * Filters the run success action args.
@@ -2371,8 +2371,8 @@  discard block
 block discarded – undo
2371 2371
 	private static function load_page_after_submit( $args ) {
2372 2372
 		global $post;
2373 2373
 		$opt = $args['success_opt'];
2374
-		if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
2375
-			$page     = get_post( $args['form']->options[ $opt . '_page_id' ] );
2374
+		if ( ! $post || $args['form']->options[$opt . '_page_id'] != $post->ID ) {
2375
+			$page     = get_post( $args['form']->options[$opt . '_page_id'] );
2376 2376
 			$old_post = $post;
2377 2377
 			$post     = $page;
2378 2378
 			$content  = apply_filters( 'frm_content', $page->post_content, $args['form'], $args['entry_id'] );
@@ -2389,7 +2389,7 @@  discard block
 block discarded – undo
2389 2389
 		add_filter( 'frm_use_wpautop', '__return_false' );
2390 2390
 
2391 2391
 		$opt         = $args['success_opt'];
2392
-		$success_url = trim( $args['form']->options[ $opt . '_url' ] );
2392
+		$success_url = trim( $args['form']->options[$opt . '_url'] );
2393 2393
 		$success_url = apply_filters( 'frm_content', $success_url, $args['form'], $args['entry_id'] );
2394 2394
 		$success_url = do_shortcode( $success_url );
2395 2395
 
@@ -2561,7 +2561,7 @@  discard block
 block discarded – undo
2561 2561
 			'description' => false,
2562 2562
 			'reset'       => false,
2563 2563
 		);
2564
-		$args     = wp_parse_args( $args, $defaults );
2564
+		$args = wp_parse_args( $args, $defaults );
2565 2565
 	}
2566 2566
 
2567 2567
 	/**
@@ -2813,7 +2813,7 @@  discard block
 block discarded – undo
2813 2813
 
2814 2814
 		check_ajax_referer( 'frm_ajax', 'nonce' );
2815 2815
 
2816
-		$html             = FrmAppHelper::clip(
2816
+		$html = FrmAppHelper::clip(
2817 2817
 			function() {
2818 2818
 				FrmAppHelper::maybe_autocomplete_pages_options(
2819 2819
 					array(
@@ -2884,25 +2884,25 @@  discard block
 block discarded – undo
2884 2884
 	public static function populate_on_submit_data( &$form_options, $action = null, $event = 'create' ) {
2885 2885
 		$opt = 'update' === $event ? 'edit_' : 'success_';
2886 2886
 		if ( ! $action || ! is_object( $action ) ) {
2887
-			$form_options[ $opt . 'action' ] = FrmOnSubmitHelper::get_default_action_type();
2888
-			$form_options[ $opt . 'msg' ]    = FrmOnSubmitHelper::get_default_msg();
2887
+			$form_options[$opt . 'action'] = FrmOnSubmitHelper::get_default_action_type();
2888
+			$form_options[$opt . 'msg']    = FrmOnSubmitHelper::get_default_msg();
2889 2889
 			return;
2890 2890
 		}
2891 2891
 
2892
-		$form_options[ $opt . 'action' ] = isset( $action->post_content['success_action'] ) ? $action->post_content['success_action'] : 'message';
2892
+		$form_options[$opt . 'action'] = isset( $action->post_content['success_action'] ) ? $action->post_content['success_action'] : 'message';
2893 2893
 
2894
-		switch ( $form_options[ $opt . 'action' ] ) {
2894
+		switch ( $form_options[$opt . 'action'] ) {
2895 2895
 			case 'redirect':
2896
-				$form_options[ $opt . 'url' ] = isset( $action->post_content['success_url'] ) ? $action->post_content['success_url'] : '';
2896
+				$form_options[$opt . 'url'] = isset( $action->post_content['success_url'] ) ? $action->post_content['success_url'] : '';
2897 2897
 				break;
2898 2898
 
2899 2899
 			case 'page':
2900
-				$form_options[ $opt . 'page_id' ] = isset( $action->post_content['success_page_id'] ) ? $action->post_content['success_page_id'] : '';
2900
+				$form_options[$opt . 'page_id'] = isset( $action->post_content['success_page_id'] ) ? $action->post_content['success_page_id'] : '';
2901 2901
 				break;
2902 2902
 
2903 2903
 			default:
2904
-				$form_options[ $opt . 'msg' ] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : FrmOnSubmitHelper::get_default_msg();
2905
-				$form_options['show_form']   = ! empty( $action->post_content['show_form'] );
2904
+				$form_options[$opt . 'msg'] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : FrmOnSubmitHelper::get_default_msg();
2905
+				$form_options['show_form'] = ! empty( $action->post_content['show_form'] );
2906 2906
 		}
2907 2907
 	}
2908 2908
 
@@ -2980,20 +2980,20 @@  discard block
 block discarded – undo
2980 2980
 	private static function get_on_submit_action_data_from_form_options( $form_options, $event = 'create' ) {
2981 2981
 		$opt  = 'update' === $event ? 'edit_' : 'success_';
2982 2982
 		$data = array(
2983
-			'success_action' => $form_options[ $opt . 'action' ],
2983
+			'success_action' => $form_options[$opt . 'action'],
2984 2984
 		);
2985 2985
 
2986
-		switch ( $form_options[ $opt . 'action' ] ) {
2986
+		switch ( $form_options[$opt . 'action'] ) {
2987 2987
 			case 'redirect':
2988
-				$data['success_url'] = isset( $form_options[ $opt . 'url' ] ) ? $form_options[ $opt . 'url' ] : '';
2988
+				$data['success_url'] = isset( $form_options[$opt . 'url'] ) ? $form_options[$opt . 'url'] : '';
2989 2989
 				break;
2990 2990
 
2991 2991
 			case 'page':
2992
-				$data['success_page_id'] = isset( $form_options[ $opt . 'page_id' ] ) ? $form_options[ $opt . 'page_id' ] : '';
2992
+				$data['success_page_id'] = isset( $form_options[$opt . 'page_id'] ) ? $form_options[$opt . 'page_id'] : '';
2993 2993
 				break;
2994 2994
 
2995 2995
 			default:
2996
-				$data['success_msg'] = isset( $form_options[ $opt . 'msg' ] ) ? $form_options[ $opt . 'msg' ] : FrmOnSubmitHelper::get_default_msg();
2996
+				$data['success_msg'] = isset( $form_options[$opt . 'msg'] ) ? $form_options[$opt . 'msg'] : FrmOnSubmitHelper::get_default_msg();
2997 2997
 				$data['show_form']   = ! empty( $form_options['show_form'] );
2998 2998
 		}
2999 2999
 
@@ -3028,8 +3028,8 @@  discard block
 block discarded – undo
3028 3028
 		}
3029 3029
 
3030 3030
 		foreach ( $options as $name ) {
3031
-			if ( isset( $form->options[ $name ] ) ) {
3032
-				unset( $form->options[ $name ] );
3031
+			if ( isset( $form->options[$name] ) ) {
3032
+				unset( $form->options[$name] );
3033 3033
 			}
3034 3034
 		}
3035 3035
 
Please login to merge, or discard this patch.
classes/models/FrmStyleApi.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 		// Remove 'Styling Template' from titles.
51 51
 		foreach ( $api_info as $id => $template ) {
52 52
 			if ( isset( $template['name'] ) ) {
53
-				$api_info[ $id ]['name'] = preg_replace( '/(\sStyle|Styling)?(\sTemplate)?$/', '', $template['name'] );
53
+				$api_info[$id]['name'] = preg_replace( '/(\sStyle|Styling)?(\sTemplate)?$/', '', $template['name'] );
54 54
 			}
55 55
 		}
56 56
 
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldType.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -132,8 +132,8 @@  discard block
 block discarded – undo
132 132
 		$field_val = '';
133 133
 		if ( is_object( $this->field ) ) {
134 134
 			$field_val = $this->field->{$column};
135
-		} elseif ( is_array( $this->field ) && isset( $this->field[ $column ] ) ) {
136
-			$field_val = $this->field[ $column ];
135
+		} elseif ( is_array( $this->field ) && isset( $this->field[$column] ) ) {
136
+			$field_val = $this->field[$column];
137 137
 		}
138 138
 
139 139
 		return $field_val;
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 		if ( is_object( $this->field ) ) {
148 148
 			$this->field->{$column} = $value;
149 149
 		} elseif ( is_array( $this->field ) ) {
150
-			$this->field[ $column ] = $value;
150
+			$this->field[$column] = $value;
151 151
 		}
152 152
 	}
153 153
 
@@ -527,7 +527,7 @@  discard block
 block discarded – undo
527 527
 			printf(
528 528
 				/* translators: %s: Field type */
529 529
 				esc_html__( '%s Options', 'formidable' ),
530
-				esc_html( $all_field_types[ $args['display']['type'] ]['name'] )
530
+				esc_html( $all_field_types[$args['display']['type']]['name'] )
531 531
 			);
532 532
 			FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown6_icon', array( 'aria-hidden' => 'true' ) );
533 533
 			?>
@@ -650,8 +650,8 @@  discard block
 block discarded – undo
650 650
 		$fields = FrmField::field_selection();
651 651
 		$fields = array_merge( $fields, FrmField::pro_field_selection() );
652 652
 
653
-		if ( isset( $fields[ $this->type ] ) ) {
654
-			$name = is_array( $fields[ $this->type ] ) ? $fields[ $this->type ]['name'] : $fields[ $this->type ];
653
+		if ( isset( $fields[$this->type] ) ) {
654
+			$name = is_array( $fields[$this->type] ) ? $fields[$this->type]['name'] : $fields[$this->type];
655 655
 		}
656 656
 
657 657
 		return $name;
@@ -662,7 +662,7 @@  discard block
 block discarded – undo
662 662
 	}
663 663
 
664 664
 	public function get_default_field_options() {
665
-		$opts       = array(
665
+		$opts = array(
666 666
 			'size'               => '',
667 667
 			'max'                => '',
668 668
 			'label'              => '',
@@ -1004,7 +1004,7 @@  discard block
 block discarded – undo
1004 1004
 			}
1005 1005
 		} else {
1006 1006
 			$args['save_array'] = $this->is_readonly_array();
1007
-			$hidden             .= $this->show_single_hidden( $selected_value, $args );
1007
+			$hidden .= $this->show_single_hidden( $selected_value, $args );
1008 1008
 		}
1009 1009
 
1010 1010
 		return $hidden;
@@ -1013,7 +1013,7 @@  discard block
 block discarded – undo
1013 1013
 	protected function show_single_hidden( $selected, $args ) {
1014 1014
 		if ( $args['save_array'] ) {
1015 1015
 			$args['field_name'] .= '[]';
1016
-			$id                 = '';
1016
+			$id = '';
1017 1017
 		} else {
1018 1018
 			$id = ' id="' . esc_attr( $args['html_id'] ) . '"';
1019 1019
 		}
@@ -1029,8 +1029,8 @@  discard block
 block discarded – undo
1029 1029
 		$selected = $values['field_value'];
1030 1030
 
1031 1031
 		if ( isset( $values['combo_name'] ) ) {
1032
-			$options  = $options[ $values['combo_name'] ];
1033
-			$selected = ( is_array( $selected ) && isset( $selected[ $values['combo_name'] ] ) ) ? $selected[ $values['combo_name'] ] : '';
1032
+			$options  = $options[$values['combo_name']];
1033
+			$selected = ( is_array( $selected ) && isset( $selected[$values['combo_name']] ) ) ? $selected[$values['combo_name']] : '';
1034 1034
 		}
1035 1035
 
1036 1036
 		$input = $this->select_tag( $values );
@@ -1081,7 +1081,7 @@  discard block
 block discarded – undo
1081 1081
 	}
1082 1082
 
1083 1083
 	protected function fill_display_field_values( $args = array() ) {
1084
-		$defaults        = array(
1084
+		$defaults = array(
1085 1085
 			'field_name'    => 'item_meta[' . $this->get_field_column( 'id' ) . ']',
1086 1086
 			'field_id'      => $this->get_field_column( 'id' ),
1087 1087
 			'field_plus_id' => '',
@@ -1134,7 +1134,7 @@  discard block
 block discarded – undo
1134 1134
 			}
1135 1135
 		}
1136 1136
 
1137
-		if ( isset( $args['errors'][ 'field' . $args['field_id'] ] ) && ! $custom_error_fields ) {
1137
+		if ( isset( $args['errors']['field' . $args['field_id']] ) && ! $custom_error_fields ) {
1138 1138
 			if ( $error_comes_first ) {
1139 1139
 				array_unshift( $describedby, 'frm_error_' . $args['html_id'] );
1140 1140
 			} else {
@@ -1213,11 +1213,11 @@  discard block
 block discarded – undo
1213 1213
 
1214 1214
 		$field_id = $this->get_field_column( 'id' );
1215 1215
 		if ( ! array_key_exists( $field_id, $frm_validated_unique_values ) ) {
1216
-			$frm_validated_unique_values[ $field_id ] = array();
1216
+			$frm_validated_unique_values[$field_id] = array();
1217 1217
 			return false;
1218 1218
 		}
1219 1219
 
1220
-		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[ $field_id ], true );
1220
+		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[$field_id], true );
1221 1221
 		return $already_validated_this_value;
1222 1222
 	}
1223 1223
 
@@ -1242,7 +1242,7 @@  discard block
 block discarded – undo
1242 1242
 	private function value_validated_as_unique( $value ) {
1243 1243
 		global $frm_validated_unique_values;
1244 1244
 		$field_id                                   = $this->get_field_column( 'id' );
1245
-		$frm_validated_unique_values[ $field_id ][] = $value;
1245
+		$frm_validated_unique_values[$field_id][] = $value;
1246 1246
 	}
1247 1247
 
1248 1248
 	public function get_value_to_save( $value, $atts ) {
@@ -1274,8 +1274,8 @@  discard block
 block discarded – undo
1274 1274
 		$value = $this->prepare_display_value( $value, $atts );
1275 1275
 
1276 1276
 		if ( is_array( $value ) ) {
1277
-			if ( isset( $atts['show'] ) && $atts['show'] && isset( $value[ $atts['show'] ] ) ) {
1278
-				$value = $value[ $atts['show'] ];
1277
+			if ( isset( $atts['show'] ) && $atts['show'] && isset( $value[$atts['show']] ) ) {
1278
+				$value = $value[$atts['show']];
1279 1279
 			} elseif ( ! isset( $atts['return_array'] ) || ! $atts['return_array'] ) {
1280 1280
 				$sep   = isset( $atts['sep'] ) ? $atts['sep'] : ', ';
1281 1281
 				$value = implode( $sep, $value );
@@ -1344,8 +1344,8 @@  discard block
 block discarded – undo
1344 1344
 		$saved_entries = $atts['ids'];
1345 1345
 		$new_value     = array();
1346 1346
 		foreach ( (array) $value as $old_child_id ) {
1347
-			if ( isset( $saved_entries[ $old_child_id ] ) ) {
1348
-				$new_value[] = $saved_entries[ $old_child_id ];
1347
+			if ( isset( $saved_entries[$old_child_id] ) ) {
1348
+				$new_value[] = $saved_entries[$old_child_id];
1349 1349
 			}
1350 1350
 		}
1351 1351
 
Please login to merge, or discard this patch.
classes/views/styles/_style-card.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,8 +39,8 @@  discard block
 block discarded – undo
39 39
 				'text-color'      => $style->post_content['text_color'],
40 40
 				'submit-bg-color' => $style->post_content['submit_bg_color'],
41 41
 			);
42
-			$index  = 0;
43
-			foreach( $colors as $css_var_name => $color ) {
42
+			$index = 0;
43
+			foreach ( $colors as $css_var_name => $color ) {
44 44
 				$brightness = FrmStylesHelper::get_color_brightness( $color );
45 45
 
46 46
 				if ( 0 !== strpos( $color, 'rgb' ) ) {
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 					$circle_params['class'] .= ' frm-darker-circle-border';
56 56
 				}
57 57
 
58
-				++$index;
58
+				++ $index;
59 59
 			?>
60 60
 				<div <?php FrmAppHelper::array_to_html_params( $circle_params, true ); ?>></div>
61 61
 				<?php
Please login to merge, or discard this patch.