Completed
Pull Request — master (#448)
by Stephanie
01:08
created
classes/helpers/FrmEntriesListHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 			$s_query['it.form_id'] = $form_id;
26 26
 			$join_form_in_query    = false;
27 27
 		} else {
28
-			$s_query[]          = array(
28
+			$s_query[] = array(
29 29
 				'or'               => 1,
30 30
 				'parent_form_id'   => null,
31 31
 				'parent_form_id <' => 1,
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 
57 57
 		if ( strpos( $orderby, 'meta' ) !== false ) {
58 58
 			$order_field_type = FrmField::get_type( str_replace( 'meta_', '', $orderby ) );
59
-			$orderby          .= in_array( $order_field_type, array( 'number', 'scale', 'star' ) ) ? '+0' : '';
59
+			$orderby .= in_array( $order_field_type, array( 'number', 'scale', 'star' ) ) ? '+0' : '';
60 60
 		}
61 61
 
62 62
 		$order = self::get_param(
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 
190 190
 		$r = "<tr id='item-action-{$item->id}'$style>";
191 191
 
192
-		list( $columns, $hidden, , $primary ) = $this->get_column_info();
192
+		list( $columns, $hidden,, $primary ) = $this->get_column_info();
193 193
 		$action_col                           = false;
194 194
 		$action_columns                       = $this->get_action_columns();
195 195
 
Please login to merge, or discard this patch.
classes/models/FrmFormTemplateApi.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
 
6 6
 class FrmFormTemplateApi extends FrmFormApi {
7 7
 
8
-	protected static $code_option_name  = 'frm_free_license_code';
8
+	protected static $code_option_name = 'frm_free_license_code';
9 9
 
10 10
 	private static $base_api_url = 'https://formidableforms.com/wp-json/form-templates/v1/';
11 11
 
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
 		$templates    = $this->get_api_info();
78 78
 		$contact_form = 20872734;
79
-		return isset( $templates[ $contact_form ] ) && ! empty( $templates[ $contact_form ]['url'] );
79
+		return isset( $templates[$contact_form] ) && ! empty( $templates[$contact_form]['url'] );
80 80
 	}
81 81
 
82 82
 	/**
@@ -137,15 +137,15 @@  discard block
 block discarded – undo
137 137
 					continue;
138 138
 				}
139 139
 
140
-				$data['urlByKey'][ $template['key'] ] = $template['url'];
140
+				$data['urlByKey'][$template['key']] = $template['url'];
141 141
 			}
142 142
 
143
-			if ( ! isset( $data['urlByKey'][ $key ] ) ) {
143
+			if ( ! isset( $data['urlByKey'][$key] ) ) {
144 144
 				$error = new WP_Error( 400, 'We were unable to retrieve the template' );
145 145
 				wp_send_json_error( $error );
146 146
 			}
147 147
 
148
-			$data['url'] = $data['urlByKey'][ $key ];
148
+			$data['url'] = $data['urlByKey'][$key];
149 149
 		}
150 150
 
151 151
 		wp_send_json_success( $data );
Please login to merge, or discard this patch.
classes/models/FrmFormAction.php 1 patch
Spacing   +44 added lines, -44 removed lines patch added patch discarded remove patch
@@ -5,15 +5,15 @@  discard block
 block discarded – undo
5 5
 
6 6
 class FrmFormAction {
7 7
 
8
-	public $id_base;         // Root id for all actions of this type.
9
-	public $name;            // Name for this action type.
8
+	public $id_base; // Root id for all actions of this type.
9
+	public $name; // Name for this action type.
10 10
 	public $option_name;
11
-	public $action_options;  // Option array passed to wp_register_sidebar_widget()
11
+	public $action_options; // Option array passed to wp_register_sidebar_widget()
12 12
 	public $control_options; // Option array passed to wp_register_widget_control()
13 13
 
14
-	public $form_id;         // The ID of the form to evaluate
15
-	public $number = false;  // Unique ID number of the current instance.
16
-	public $id = '';         // Unique ID string of the current instance (id_base-number)
14
+	public $form_id; // The ID of the form to evaluate
15
+	public $number = false; // Unique ID number of the current instance.
16
+	public $id = ''; // Unique ID string of the current instance (id_base-number)
17 17
 	public $updated = false; // Set true when we update the data after a POST submit - makes sure we don't do it twice.
18 18
 
19 19
 	// Member functions that you must over-ride.
@@ -141,9 +141,9 @@  discard block
 block discarded – undo
141 141
 		$groups = FrmFormActionsController::form_action_groups();
142 142
 		$group  = 'misc';
143 143
 
144
-		if ( isset( $action_options['group'] ) && isset( $groups[ $action_options['group'] ] ) ) {
144
+		if ( isset( $action_options['group'] ) && isset( $groups[$action_options['group']] ) ) {
145 145
 			$group = $action_options['group'];
146
-		} elseif ( isset( $groups[ $this->id_base ] ) ) {
146
+		} elseif ( isset( $groups[$this->id_base] ) ) {
147 147
 			$group = $this->id_base;
148 148
 		} else {
149 149
 			foreach ( $groups as $name => $check_group ) {
@@ -154,8 +154,8 @@  discard block
 block discarded – undo
154 154
 			}
155 155
 		}
156 156
 
157
-		$groups[ $group ]['id'] = $group;
158
-		return $groups[ $group ];
157
+		$groups[$group]['id'] = $group;
158
+		return $groups[$group];
159 159
 	}
160 160
 
161 161
 	/**
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 	 * @return integer $post_id
258 258
 	 */
259 259
 	public function maybe_create_action( $action, $forms ) {
260
-		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[ $action['menu_order'] ] ) && $forms[ $action['menu_order'] ] == 'updated' ) {
260
+		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[$action['menu_order']] ) && $forms[$action['menu_order']] == 'updated' ) {
261 261
 			// Update action only
262 262
 			$action['post_content'] = FrmAppHelper::maybe_json_decode( $action['post_content'] );
263 263
 			$post_id                = $this->save_settings( $action );
@@ -277,18 +277,18 @@  discard block
 block discarded – undo
277 277
 		$switch             = $this->get_global_switch_fields();
278 278
 
279 279
 		foreach ( (array) $action->post_content as $key => $val ) {
280
-			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[ $val ] ) ) {
281
-				$action->post_content[ $key ] = $frm_duplicate_ids[ $val ];
280
+			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[$val] ) ) {
281
+				$action->post_content[$key] = $frm_duplicate_ids[$val];
282 282
 			} elseif ( ! is_array( $val ) ) {
283
-				$action->post_content[ $key ] = FrmFieldsHelper::switch_field_ids( $val );
284
-			} elseif ( isset( $switch[ $key ] ) && is_array( $switch[ $key ] ) ) {
283
+				$action->post_content[$key] = FrmFieldsHelper::switch_field_ids( $val );
284
+			} elseif ( isset( $switch[$key] ) && is_array( $switch[$key] ) ) {
285 285
 				// loop through each value if empty
286
-				if ( empty( $switch[ $key ] ) ) {
287
-					$switch[ $key ] = array_keys( $val );
286
+				if ( empty( $switch[$key] ) ) {
287
+					$switch[$key] = array_keys( $val );
288 288
 				}
289 289
 
290
-				foreach ( $switch[ $key ] as $subkey ) {
291
-					$action->post_content[ $key ] = $this->duplicate_array_walk( $action->post_content[ $key ], $subkey, $val );
290
+				foreach ( $switch[$key] as $subkey ) {
291
+					$action->post_content[$key] = $this->duplicate_array_walk( $action->post_content[$key], $subkey, $val );
292 292
 				}
293 293
 			}
294 294
 
@@ -306,20 +306,20 @@  discard block
 block discarded – undo
306 306
 			foreach ( $subkey as $subkey2 ) {
307 307
 				foreach ( (array) $val as $ck => $cv ) {
308 308
 					if ( is_array( $cv ) ) {
309
-						$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey2, $cv );
310
-					} elseif ( isset( $cv[ $subkey ] ) && is_numeric( $cv[ $subkey ] ) && isset( $frm_duplicate_ids[ $cv[ $subkey ] ] ) ) {
311
-						$action[ $ck ][ $subkey ] = $frm_duplicate_ids[ $cv[ $subkey ] ];
309
+						$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey2, $cv );
310
+					} elseif ( isset( $cv[$subkey] ) && is_numeric( $cv[$subkey] ) && isset( $frm_duplicate_ids[$cv[$subkey]] ) ) {
311
+						$action[$ck][$subkey] = $frm_duplicate_ids[$cv[$subkey]];
312 312
 					}
313 313
 				}
314 314
 			}
315 315
 		} else {
316 316
 			foreach ( (array) $val as $ck => $cv ) {
317 317
 				if ( is_array( $cv ) ) {
318
-					$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey, $cv );
319
-				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[ $cv ] ) ) {
320
-					$action[ $ck ] = $frm_duplicate_ids[ $cv ];
318
+					$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey, $cv );
319
+				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[$cv] ) ) {
320
+					$action[$ck] = $frm_duplicate_ids[$cv];
321 321
 				} elseif ( $ck == $subkey ) {
322
-					$action[ $ck ] = $this->maybe_switch_field_ids( $action[ $ck ] );
322
+					$action[$ck] = $this->maybe_switch_field_ids( $action[$ck] );
323 323
 				}
324 324
 			}
325 325
 		}
@@ -342,10 +342,10 @@  discard block
 block discarded – undo
342 342
 			return;
343 343
 		}
344 344
 
345
-		if ( isset( $_POST[ $this->option_name ] ) && is_array( $_POST[ $this->option_name ] ) ) {
345
+		if ( isset( $_POST[$this->option_name] ) && is_array( $_POST[$this->option_name] ) ) {
346 346
 			// Sanitizing removes scripts and <email> type of values.
347 347
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
348
-			$settings = wp_unslash( $_POST[ $this->option_name ] );
348
+			$settings = wp_unslash( $_POST[$this->option_name] );
349 349
 		} else {
350 350
 			return;
351 351
 		}
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 		foreach ( $settings as $number => $new_instance ) {
356 356
 			$this->_set( $number );
357 357
 
358
-			$old_instance = isset( $all_instances[ $number ] ) ? $all_instances[ $number ] : array();
358
+			$old_instance = isset( $all_instances[$number] ) ? $all_instances[$number] : array();
359 359
 
360 360
 			if ( ! isset( $new_instance['post_status'] ) ) {
361 361
 				$new_instance['post_status'] = 'draft';
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
 			$instance['post_content'] = apply_filters( 'frm_before_save_' . $this->id_base . '_action', $new_instance['post_content'], $instance, $new_instance, $old_instance, $this );
396 396
 
397 397
 			if ( false !== $instance ) {
398
-				$all_instances[ $number ] = $instance;
398
+				$all_instances[$number] = $instance;
399 399
 			}
400 400
 
401 401
 			$action_ids[] = $this->save_settings( $instance );
@@ -471,12 +471,12 @@  discard block
 block discarded – undo
471 471
 			// some plugins/themes are formatting the post_excerpt
472 472
 			$action->post_excerpt = sanitize_title( $action->post_excerpt );
473 473
 
474
-			if ( ! isset( $action_controls[ $action->post_excerpt ] ) ) {
474
+			if ( ! isset( $action_controls[$action->post_excerpt] ) ) {
475 475
 				continue;
476 476
 			}
477 477
 
478
-			$action                  = $action_controls[ $action->post_excerpt ]->prepare_action( $action );
479
-			$settings[ $action->ID ] = $action;
478
+			$action                  = $action_controls[$action->post_excerpt]->prepare_action( $action );
479
+			$settings[$action->ID] = $action;
480 480
 
481 481
 			if ( count( $settings ) >= $limit ) {
482 482
 				break;
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
 			'limit'       => 99,
507 507
 			'post_status' => $default_status,
508 508
 		);
509
-		$args     = wp_parse_args( $args, $defaults );
509
+		$args = wp_parse_args( $args, $defaults );
510 510
 	}
511 511
 
512 512
 	/**
@@ -567,7 +567,7 @@  discard block
 block discarded – undo
567 567
 
568 568
 			$action = $this->prepare_action( $action );
569 569
 
570
-			$settings[ $action->ID ] = $action;
570
+			$settings[$action->ID] = $action;
571 571
 		}
572 572
 
573 573
 		if ( 1 === $limit ) {
@@ -604,10 +604,10 @@  discard block
 block discarded – undo
604 604
 
605 605
 		foreach ( $default_values as $k => $vals ) {
606 606
 			if ( is_array( $vals ) && ! empty( $vals ) ) {
607
-				if ( 'event' == $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[ $k ] ) ) {
607
+				if ( 'event' == $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[$k] ) ) {
608 608
 					continue;
609 609
 				}
610
-				$action->post_content[ $k ] = wp_parse_args( $action->post_content[ $k ], $vals );
610
+				$action->post_content[$k] = wp_parse_args( $action->post_content[$k], $vals );
611 611
 			}
612 612
 		}
613 613
 
@@ -682,14 +682,14 @@  discard block
 block discarded – undo
682 682
 	 * Migrate settings from form->options into new action.
683 683
 	 */
684 684
 	public function migrate_to_2( $form, $update = 'update' ) {
685
-		$action        = $this->prepare_new( $form->id );
685
+		$action = $this->prepare_new( $form->id );
686 686
 		FrmAppHelper::unserialize_or_decode( $form->options );
687 687
 
688 688
 		// fill with existing options
689 689
 		foreach ( $action->post_content as $name => $val ) {
690
-			if ( isset( $form->options[ $name ] ) ) {
691
-				$action->post_content[ $name ] = $form->options[ $name ];
692
-				unset( $form->options[ $name ] );
690
+			if ( isset( $form->options[$name] ) ) {
691
+				$action->post_content[$name] = $form->options[$name];
692
+				unset( $form->options[$name] );
693 693
 			}
694 694
 		}
695 695
 
@@ -755,7 +755,7 @@  discard block
 block discarded – undo
755 755
 				$stop = $stop ? false : true;
756 756
 			}
757 757
 
758
-			$met[ $stop ] = $stop;
758
+			$met[$stop] = $stop;
759 759
 		}
760 760
 
761 761
 		if ( $notification['conditions']['any_all'] == 'all' && ! empty( $met ) && isset( $met[0] ) && isset( $met[1] ) ) {
@@ -806,8 +806,8 @@  discard block
 block discarded – undo
806 806
 	private static function get_value_from_entry( $entry, $field_id ) {
807 807
 		$observed_value = '';
808 808
 
809
-		if ( isset( $entry->metas[ $field_id ] ) ) {
810
-			$observed_value = $entry->metas[ $field_id ];
809
+		if ( isset( $entry->metas[$field_id] ) ) {
810
+			$observed_value = $entry->metas[$field_id];
811 811
 		} elseif ( $entry->post_id && FrmAppHelper::pro_is_installed() ) {
812 812
 			$field          = FrmField::getOne( $field_id );
813 813
 			$observed_value = FrmProEntryMetaHelper::get_post_or_meta_value(
Please login to merge, or discard this patch.
classes/controllers/FrmWelcomeController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,8 @@
 block discarded – undo
125 125
 		}
126 126
 
127 127
 		// Only do this for single site installs.
128
-		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) { // WPCS: CSRF ok.
128
+		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) {
129
+// WPCS: CSRF ok.
129 130
 			return;
130 131
 		}
131 132
 
Please login to merge, or discard this patch.
classes/models/FrmInbox.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 			return;
85 85
 		}
86 86
 
87
-		if ( isset( $this->messages[ $message['key'] ] ) && ! isset( $message['force'] ) ) {
87
+		if ( isset( $this->messages[$message['key']] ) && ! isset( $message['force'] ) ) {
88 88
 			// Don't replace messages unless required.
89 89
 			return;
90 90
 		}
@@ -93,13 +93,13 @@  discard block
 block discarded – undo
93 93
 			return;
94 94
 		}
95 95
 
96
-		if ( isset( $this->messages[ $message['key'] ] ) ) {
96
+		if ( isset( $this->messages[$message['key']] ) ) {
97 97
 			// Move up and mark as new.
98
-			unset( $this->messages[ $message['key'] ] );
98
+			unset( $this->messages[$message['key']] );
99 99
 		}
100 100
 
101 101
 		$this->fill_message( $message );
102
-		$this->messages[ $message['key'] ] = $message;
102
+		$this->messages[$message['key']] = $message;
103 103
 
104 104
 		$this->update_list();
105 105
 
@@ -127,11 +127,11 @@  discard block
 block discarded – undo
127 127
 	private function clean_messages() {
128 128
 		$removed  = false;
129 129
 		foreach ( $this->messages as $t => $message ) {
130
-			$read    = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][ get_current_user_id() ] ) && $message['read'][ get_current_user_id() ] < strtotime( '-1 month' );
131
-			$dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][ get_current_user_id() ] ) && $message['dismissed'][ get_current_user_id() ] < strtotime( '-1 week' );
130
+			$read    = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][get_current_user_id()] ) && $message['read'][get_current_user_id()] < strtotime( '-1 month' );
131
+			$dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][get_current_user_id()] ) && $message['dismissed'][get_current_user_id()] < strtotime( '-1 week' );
132 132
 			$expired = $this->is_expired( $message );
133 133
 			if ( $read || $expired || $dismissed ) {
134
-				unset( $this->messages[ $t ] );
134
+				unset( $this->messages[$t] );
135 135
 				$removed = true;
136 136
 			}
137 137
 		}
@@ -144,11 +144,11 @@  discard block
 block discarded – undo
144 144
 	private function filter_messages( &$messages ) {
145 145
 		$user_id = get_current_user_id();
146 146
 		foreach ( $messages as $k => $message ) {
147
-			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][ $user_id ] );
147
+			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][$user_id] );
148 148
 			if ( empty( $k ) || $this->is_expired( $message ) || $dismissed ) {
149
-				unset( $messages[ $k ] );
149
+				unset( $messages[$k] );
150 150
 			} elseif ( ! $this->is_for_user( $message ) ) {
151
-				unset( $messages[ $k ] );
151
+				unset( $messages[$k] );
152 152
 			}
153 153
 		}
154 154
 		$messages = apply_filters( 'frm_filter_inbox', $messages );
@@ -181,14 +181,14 @@  discard block
 block discarded – undo
181 181
 	 * @param string $key
182 182
 	 */
183 183
 	public function mark_read( $key ) {
184
-		if ( ! $key || ! isset( $this->messages[ $key ] ) ) {
184
+		if ( ! $key || ! isset( $this->messages[$key] ) ) {
185 185
 			return;
186 186
 		}
187 187
 
188
-		if ( ! isset( $this->messages[ $key ]['read'] ) ) {
189
-			$this->messages[ $key ]['read'] = array();
188
+		if ( ! isset( $this->messages[$key]['read'] ) ) {
189
+			$this->messages[$key]['read'] = array();
190 190
 		}
191
-		$this->messages[ $key ]['read'][ get_current_user_id() ] = time();
191
+		$this->messages[$key]['read'][get_current_user_id()] = time();
192 192
 
193 193
 		$this->update_list();
194 194
 	}
@@ -199,9 +199,9 @@  discard block
 block discarded – undo
199 199
 	 * @since 4.05.02
200 200
 	 */
201 201
 	public function mark_unread( $key ) {
202
-		$is_read = isset( $this->messages[ $key ] ) && isset( $this->messages[ $key ]['read'] ) && isset( $this->messages[ $key ]['read'][ get_current_user_id() ] );
202
+		$is_read = isset( $this->messages[$key] ) && isset( $this->messages[$key]['read'] ) && isset( $this->messages[$key]['read'][get_current_user_id()] );
203 203
 		if ( $is_read ) {
204
-			unset( $this->messages[ $key ]['read'][ get_current_user_id() ] );
204
+			unset( $this->messages[$key]['read'][get_current_user_id()] );
205 205
 			$this->update_list();
206 206
 		}
207 207
 	}
@@ -215,14 +215,14 @@  discard block
 block discarded – undo
215 215
 			return;
216 216
 		}
217 217
 
218
-		if ( ! isset( $this->messages[ $key ] ) ) {
218
+		if ( ! isset( $this->messages[$key] ) ) {
219 219
 			return;
220 220
 		}
221 221
 
222
-		if ( ! isset( $this->messages[ $key ]['dismissed'] ) ) {
223
-			$this->messages[ $key ]['dismissed'] = array();
222
+		if ( ! isset( $this->messages[$key]['dismissed'] ) ) {
223
+			$this->messages[$key]['dismissed'] = array();
224 224
 		}
225
-		$this->messages[ $key ]['dismissed'][ get_current_user_id() ] = time();
225
+		$this->messages[$key]['dismissed'][get_current_user_id()] = time();
226 226
 
227 227
 		$this->update_list();
228 228
 	}
@@ -234,11 +234,11 @@  discard block
 block discarded – undo
234 234
 		$user_id = get_current_user_id();
235 235
 		foreach ( $this->messages as $key => $message ) {
236 236
 			if ( ! isset( $message['dismissed'] ) ) {
237
-				$this->messages[ $key ]['dismissed'] = array();
237
+				$this->messages[$key]['dismissed'] = array();
238 238
 			}
239 239
 
240
-			if ( ! isset( $message['dismissed'][ $user_id ] ) ) {
241
-				$this->messages[ $key ]['dismissed'][ $user_id ] = time();
240
+			if ( ! isset( $message['dismissed'][$user_id] ) ) {
241
+				$this->messages[$key]['dismissed'][$user_id] = time();
242 242
 			}
243 243
 		}
244 244
 		$this->update_list();
@@ -248,8 +248,8 @@  discard block
 block discarded – undo
248 248
 		$messages = $this->get_messages( 'filter' );
249 249
 		$user_id  = get_current_user_id();
250 250
 		foreach ( $messages as $t => $message ) {
251
-			if ( isset( $message['read'] ) && isset( $message['read'][ $user_id ] ) ) {
252
-				unset( $messages[ $t ] );
251
+			if ( isset( $message['read'] ) && isset( $message['read'][$user_id] ) ) {
252
+				unset( $messages[$t] );
253 253
 			}
254 254
 		}
255 255
 		return $messages;
@@ -273,8 +273,8 @@  discard block
 block discarded – undo
273 273
 	 * @since 4.05.02
274 274
 	 */
275 275
 	public function remove( $key ) {
276
-		if ( isset( $this->messages[ $key ] ) ) {
277
-			unset( $this->messages[ $key ] );
276
+		if ( isset( $this->messages[$key] ) ) {
277
+			unset( $this->messages[$key] );
278 278
 			$this->update_list();
279 279
 		}
280 280
 	}
Please login to merge, or discard this patch.
classes/factories/FrmFieldFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
 			'name'     => 'FrmFieldName',
103 103
 		);
104 104
 
105
-		$class = isset( $type_classes[ $field_type ] ) ? $type_classes[ $field_type ] : '';
105
+		$class = isset( $type_classes[$field_type] ) ? $type_classes[$field_type] : '';
106 106
 
107 107
 		return apply_filters( 'frm_get_field_type_class', $class, $field_type );
108 108
 	}
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldCombo.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,8 @@
 block discarded – undo
39 39
 			}
40 40
 
41 41
 			foreach ( $sub_field['options'] as $option ) {
42
-				if ( 'default_value' === $option ) { // We parse default value from field column.
42
+				if ( 'default_value' === $option ) {
43
+// We parse default value from field column.
43 44
 					continue;
44 45
 				}
45 46
 
Please login to merge, or discard this patch.
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -59,12 +59,12 @@  discard block
 block discarded – undo
59 59
 			if ( is_array( $sub_field ) ) {
60 60
 				$sub_field                 = wp_parse_args( $sub_field, $defaults );
61 61
 				$sub_field['name']         = $name;
62
-				$this->sub_fields[ $name ] = $sub_field;
62
+				$this->sub_fields[$name] = $sub_field;
63 63
 				continue;
64 64
 			}
65 65
 
66 66
 			if ( is_string( $sub_field ) ) {
67
-				$this->sub_fields[ $name ] = wp_parse_args(
67
+				$this->sub_fields[$name] = wp_parse_args(
68 68
 					array(
69 69
 						'name'  => $name,
70 70
 						'label' => $sub_field,
@@ -116,9 +116,9 @@  discard block
 block discarded – undo
116 116
 				}
117 117
 
118 118
 				if ( is_string( $option ) ) {
119
-					$extra_options[ $key . '_' . $option ] = '';
119
+					$extra_options[$key . '_' . $option] = '';
120 120
 				} elseif ( ! empty( $option['name'] ) ) {
121
-					$extra_options[ $key . '_' . $option['name'] ] = '';
121
+					$extra_options[$key . '_' . $option['name']] = '';
122 122
 				}
123 123
 			}
124 124
 		}
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 		foreach ( $this->sub_fields as $name => $sub_field ) {
142 142
 			$sub_field['name'] = $name;
143 143
 			$wrapper_classes   = 'frm_grid_container frm_sub_field_options frm_sub_field_options-' . $sub_field['name'];
144
-			if ( ! isset( $processed_sub_fields[ $name ] ) ) {
144
+			if ( ! isset( $processed_sub_fields[$name] ) ) {
145 145
 				// Options for this subfield should be hidden.
146 146
 				$wrapper_classes .= ' frm_hidden';
147 147
 			}
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 			$default_value = array();
172 172
 
173 173
 			foreach ( $this->sub_fields as $name => $sub_field ) {
174
-				$default_value[ $name ] = '';
174
+				$default_value[$name] = '';
175 175
 			}
176 176
 
177 177
 			return $default_value;
@@ -342,8 +342,8 @@  discard block
 block discarded – undo
342 342
 		// Placeholder.
343 343
 		if ( in_array( 'placeholder', $sub_field['options'], true ) ) {
344 344
 			$placeholders = FrmField::get_option( $field, 'placeholder' );
345
-			if ( ! empty( $placeholders[ $sub_field['name'] ] ) ) {
346
-				$atts[] = 'placeholder="' . esc_attr( $placeholders[ $sub_field['name'] ] ) . '"';
345
+			if ( ! empty( $placeholders[$sub_field['name']] ) ) {
346
+				$atts[] = 'placeholder="' . esc_attr( $placeholders[$sub_field['name']] ) . '"';
347 347
 			}
348 348
 		}
349 349
 
@@ -390,9 +390,9 @@  discard block
 block discarded – undo
390 390
 
391 391
 		// Validate not empty.
392 392
 		foreach ( $sub_fields as $name => $sub_field ) {
393
-			if ( empty( $sub_field['optional'] ) && empty( $args['value'][ $name ] ) ) {
394
-				$errors[ 'field' . $args['id'] . '-' . $name ] = '';
395
-				$errors[ 'field' . $args['id'] ]               = $blank_msg;
393
+			if ( empty( $sub_field['optional'] ) && empty( $args['value'][$name] ) ) {
394
+				$errors['field' . $args['id'] . '-' . $name] = '';
395
+				$errors['field' . $args['id']]               = $blank_msg;
396 396
 			}
397 397
 		}
398 398
 
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
 		$field_key  = isset( $this->field->field_key ) ? $this->field->field_key : $this->field['field_key'];
412 412
 		$sub_fields = $this->get_processed_sub_fields();
413 413
 		foreach ( $sub_fields as $name => $sub_field ) {
414
-			$headings[ $field_id . '_' . $name ] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
414
+			$headings[$field_id . '_' . $name] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
415 415
 		}
416 416
 
417 417
 		return $headings;
Please login to merge, or discard this patch.
classes/views/frm-fields/front-end/combo-field/combo-field.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 			$sub_field_class   = "frm_form_field form-field frm_form_subfield-{$name} {$sub_field['wrapper_classes']}";
41 41
 			$sub_field_desc    = FrmField::get_option( $field, $name . '_desc' );
42 42
 
43
-			if ( isset( $errors[ 'field' . $field_id . '-' . $name ] ) ) {
43
+			if ( isset( $errors['field' . $field_id . '-' . $name] ) ) {
44 44
 				$sub_field_class .= ' frm_blank_field';
45 45
 			}
46 46
 			?>
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 						<input
61 61
 							type="<?php echo esc_attr( $sub_field['type'] ); ?>"
62 62
 							id="<?php echo esc_attr( $html_id . '_' . $name ); ?>"
63
-							value="<?php echo esc_attr( isset( $field_value[ $name ] ) ? $field_value[ $name ] : '' ); ?>"
63
+							value="<?php echo esc_attr( isset( $field_value[$name] ) ? $field_value[$name] : '' ); ?>"
64 64
 							<?php
65 65
 							if ( empty( $args['remove_names'] ) ) {
66 66
 								echo 'name="' . esc_attr( $field_name ) . '[' . esc_attr( $name ) . ']" ';
@@ -77,9 +77,9 @@  discard block
 block discarded – undo
77 77
 				}
78 78
 
79 79
 				// Don't show individual field errors when there is a combo field error.
80
-				if ( ! empty( $errors ) && isset( $errors[ 'field' . $field_id . '-' . $name ] ) && ! isset( $errors[ 'field' . $field_id ] ) ) {
80
+				if ( ! empty( $errors ) && isset( $errors['field' . $field_id . '-' . $name] ) && ! isset( $errors['field' . $field_id] ) ) {
81 81
 					?>
82
-					<div class="frm_error"><?php echo esc_html( $errors[ 'field' . $field_id . '-' . $name ] ); ?></div>
82
+					<div class="frm_error"><?php echo esc_html( $errors['field' . $field_id . '-' . $name] ); ?></div>
83 83
 				<?php } ?>
84 84
 			</div>
85 85
 		<?php } ?>
Please login to merge, or discard this patch.
classes/views/frm-fields/back-end/combo-field/sub-field-options.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -51,13 +51,13 @@  discard block
 block discarded – undo
51 51
 							type="text"
52 52
 							name="<?php echo esc_attr( $input_name ); ?>"
53 53
 							id="<?php echo esc_attr( $input_id ); ?>"
54
-							value="<?php echo esc_attr( isset( $default_value[ $sub_field['name'] ] ) ? $default_value[ $sub_field['name'] ] : '' ); ?>"
54
+							value="<?php echo esc_attr( isset( $default_value[$sub_field['name']] ) ? $default_value[$sub_field['name']] : '' ); ?>"
55 55
 							data-changeme="field_<?php echo esc_attr( $field_key . '_' . $sub_field['name'] ); ?>"
56 56
 							data-changeatt="value"
57 57
 						/>
58 58
 					</span>
59 59
 					<label class="frm_description" for="<?php echo esc_attr( $input_id ); ?>">
60
-						<?php echo esc_html( $labels[ $option ] ); ?>
60
+						<?php echo esc_html( $labels[$option] ); ?>
61 61
 					</label>
62 62
 				</p>
63 63
 				<?php
@@ -74,12 +74,12 @@  discard block
 block discarded – undo
74 74
 						type="text"
75 75
 						name="<?php echo esc_attr( $input_name ); ?>"
76 76
 						id="<?php echo esc_attr( $input_id ); ?>"
77
-						value="<?php echo esc_attr( isset( $input_value[ $sub_field['name'] ] ) ? $input_value[ $sub_field['name'] ] : '' ); ?>"
77
+						value="<?php echo esc_attr( isset( $input_value[$sub_field['name']] ) ? $input_value[$sub_field['name']] : '' ); ?>"
78 78
 						data-changeme="field_<?php echo esc_attr( $field_key . '_' . $sub_field['name'] ); ?>"
79 79
 						data-changeatt="<?php echo esc_attr( $option ); ?>"
80 80
 					/>
81 81
 					<label class="frm_description" for="<?php echo esc_attr( $input_id ); ?>">
82
-						<?php echo esc_html( $labels[ $option ] ); ?>
82
+						<?php echo esc_html( $labels[$option] ); ?>
83 83
 					</label>
84 84
 				</p>
85 85
 				<?php
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 						data-changeme="frm_field_<?php echo esc_attr( $field_id . '_' . $sub_field['name'] ); ?>_desc"
101 101
 					/>
102 102
 					<label class="frm_description" for="<?php echo esc_attr( $input_id ); ?>">
103
-						<?php echo esc_html( $labels[ $option ] ); ?>
103
+						<?php echo esc_html( $labels[$option] ); ?>
104 104
 					</label>
105 105
 				</p>
106 106
 				<?php
Please login to merge, or discard this patch.