Completed
Pull Request — master (#2229)
by
unknown
54s
created
classes/models/FrmApplicationTemplate.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 		 *
38 38
 		 * @param array $keys
39 39
 		 */
40
-		self::$keys             = apply_filters(
40
+		self::$keys = apply_filters(
41 41
 			'frm_application_data_keys',
42 42
 			array( 'key', 'name', 'description', 'link', 'categories', 'views', 'forms', 'used_addons' )
43 43
 		);
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 			self::get_template_keys_with_local_png_images(),
46 46
 			self::get_template_keys_with_local_webp_images()
47 47
 		);
48
-		self::$categories       = array();
48
+		self::$categories = array();
49 49
 	}
50 50
 
51 51
 	/**
@@ -144,20 +144,20 @@  discard block
 block discarded – undo
144 144
 
145 145
 		$application = array();
146 146
 		foreach ( self::$keys as $key ) {
147
-			if ( ! isset( $this->api_data[ $key ] ) ) {
147
+			if ( ! isset( $this->api_data[$key] ) ) {
148 148
 				continue;
149 149
 			}
150 150
 
151
-			$value = $this->api_data[ $key ];
151
+			$value = $this->api_data[$key];
152 152
 
153 153
 			if ( 'icon' === $key ) {
154 154
 				// Icon is an array. The first array item is the image URL.
155
-				$application[ $key ] = reset( $value );
155
+				$application[$key] = reset( $value );
156 156
 			} elseif ( 'categories' === $key ) {
157
-				$application[ $key ] = array_values(
157
+				$application[$key] = array_values(
158 158
 					array_filter(
159 159
 						$value,
160
-						function ( $category ) {
160
+						function( $category ) {
161 161
 							return false === strpos( $category, '+Views' );
162 162
 						}
163 163
 					)
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 					// Strip off the " Template" text at the end of the name as it takes up space.
174 174
 					$value = substr( $value, 0, -9 );
175 175
 				}
176
-				$application[ $key ] = $value;
176
+				$application[$key] = $value;
177 177
 			}//end if
178 178
 		}//end foreach
179 179
 
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldCombo.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -61,12 +61,12 @@  discard block
 block discarded – undo
61 61
 			if ( is_array( $sub_field ) ) {
62 62
 				$sub_field                 = wp_parse_args( $sub_field, $defaults );
63 63
 				$sub_field['name']         = $name;
64
-				$this->sub_fields[ $name ] = $sub_field;
64
+				$this->sub_fields[$name] = $sub_field;
65 65
 				continue;
66 66
 			}
67 67
 
68 68
 			if ( is_string( $sub_field ) ) {
69
-				$this->sub_fields[ $name ] = wp_parse_args(
69
+				$this->sub_fields[$name] = wp_parse_args(
70 70
 					array(
71 71
 						'name'  => $name,
72 72
 						'label' => $sub_field,
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	 */
90 90
 	public function set_aria_invalid_error( &$shortcode_atts, $args ) {
91 91
 		foreach ( $this->get_sub_fields() as $sub_field ) {
92
-			$shortcode_atts[ 'aria-invalid-' . $sub_field['name'] ] = isset( $args['errors'][ 'field' . $this->field_id . '-' . $sub_field['name'] ] ) ? 'true' : 'false';
92
+			$shortcode_atts['aria-invalid-' . $sub_field['name']] = isset( $args['errors']['field' . $this->field_id . '-' . $sub_field['name']] ) ? 'true' : 'false';
93 93
 		}
94 94
 	}
95 95
 
@@ -135,9 +135,9 @@  discard block
 block discarded – undo
135 135
 				}
136 136
 
137 137
 				if ( is_string( $option ) ) {
138
-					$extra_options[ $key . '_' . $option ] = '';
138
+					$extra_options[$key . '_' . $option] = '';
139 139
 				} elseif ( ! empty( $option['name'] ) ) {
140
-					$extra_options[ $key . '_' . $option['name'] ] = '';
140
+					$extra_options[$key . '_' . $option['name']] = '';
141 141
 				}
142 142
 			}
143 143
 		}
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 		foreach ( $this->sub_fields as $name => $sub_field ) {
164 164
 			$sub_field['name'] = $name;
165 165
 			$wrapper_classes   = 'frm_grid_container frm_sub_field_options frm_sub_field_options-' . $sub_field['name'];
166
-			if ( ! isset( $processed_sub_fields[ $name ] ) ) {
166
+			if ( ! isset( $processed_sub_fields[$name] ) ) {
167 167
 				// Options for this subfield should be hidden.
168 168
 				$wrapper_classes .= ' frm_hidden';
169 169
 			}
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 			$default_value = array();
194 194
 
195 195
 			foreach ( $this->sub_fields as $name => $sub_field ) {
196
-				$default_value[ $name ] = '';
196
+				$default_value[$name] = '';
197 197
 			}
198 198
 
199 199
 			return $default_value;
@@ -375,8 +375,8 @@  discard block
 block discarded – undo
375 375
 		// Placeholder.
376 376
 		if ( in_array( 'placeholder', $sub_field['options'], true ) ) {
377 377
 			$placeholders = FrmField::get_option( $field, 'placeholder' );
378
-			if ( ! empty( $placeholders[ $sub_field['name'] ] ) ) {
379
-				$field['placeholder'] = $placeholders[ $sub_field['name'] ];
378
+			if ( ! empty( $placeholders[$sub_field['name']] ) ) {
379
+				$field['placeholder'] = $placeholders[$sub_field['name']];
380 380
 			}
381 381
 		}
382 382
 
@@ -437,9 +437,9 @@  discard block
 block discarded – undo
437 437
 
438 438
 		// Validate not empty.
439 439
 		foreach ( $sub_fields as $name => $sub_field ) {
440
-			if ( empty( $sub_field['optional'] ) && empty( $args['value'][ $name ] ) ) {
441
-				$errors[ 'field' . $args['id'] . '-' . $name ] = '';
442
-				$errors[ 'field' . $args['id'] ]               = $blank_msg;
440
+			if ( empty( $sub_field['optional'] ) && empty( $args['value'][$name] ) ) {
441
+				$errors['field' . $args['id'] . '-' . $name] = '';
442
+				$errors['field' . $args['id']]               = $blank_msg;
443 443
 			}
444 444
 		}
445 445
 
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
458 458
 		$field_key  = isset( $this->field->field_key ) ? $this->field->field_key : $this->field['field_key'];
459 459
 		$sub_fields = $this->get_processed_sub_fields();
460 460
 		foreach ( $sub_fields as $name => $sub_field ) {
461
-			$headings[ $field_id . '_' . $name ] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
461
+			$headings[$field_id . '_' . $name] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
462 462
 		}
463 463
 
464 464
 		return $headings;
Please login to merge, or discard this patch.
classes/helpers/FrmFieldsHelper.php 2 patches
Spacing   +49 added lines, -49 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 			if ( in_array( $type, array( 'data', 'lookup' ), true ) ) {
39 39
 				$values['field_options']['data_type'] = $setting;
40 40
 			} else {
41
-				$values['field_options'][ $setting ] = 1;
41
+				$values['field_options'][$setting] = 1;
42 42
 			}
43 43
 		}
44 44
 
@@ -172,10 +172,10 @@  discard block
 block discarded – undo
172 172
 		}
173 173
 
174 174
 		foreach ( $defaults as $opt => $default ) {
175
-			$values[ $opt ] = isset( $field->field_options[ $opt ] ) ? $field->field_options[ $opt ] : $default;
175
+			$values[$opt] = isset( $field->field_options[$opt] ) ? $field->field_options[$opt] : $default;
176 176
 
177 177
 			if ( $check_post ) {
178
-				self::get_posted_field_setting( $opt . '_' . $field->id, $values[ $opt ] );
178
+				self::get_posted_field_setting( $opt . '_' . $field->id, $values[$opt] );
179 179
 			}
180 180
 		}
181 181
 	}
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 			return self::$context_is_safe_to_load_field_options_from_request_data;
193 193
 		}
194 194
 
195
-		$function = function () {
195
+		$function = function() {
196 196
 			if ( ! FrmAppHelper::is_admin_page() ) {
197 197
 				return false;
198 198
 			}
@@ -300,12 +300,12 @@  discard block
 block discarded – undo
300 300
 	 * @param mixed  $value
301 301
 	 */
302 302
 	private static function get_posted_field_setting( $setting, &$value ) {
303
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
303
+		if ( ! isset( $_POST['field_options'][$setting] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
304 304
 			return;
305 305
 		}
306 306
 
307 307
 		if ( strpos( $setting, 'html' ) !== false ) {
308
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
308
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
309 309
 
310 310
 			// Conditionally strip script tags if the user sending $_POST data is not allowed to use unfiltered HTML.
311 311
 			if ( ! FrmAppHelper::allow_unfiltered_html() ) {
@@ -313,9 +313,9 @@  discard block
 block discarded – undo
313 313
 			}
314 314
 		} elseif ( strpos( $setting, 'format_' ) === 0 ) {
315 315
 			// TODO: Remove stripslashes on output, and use on input only.
316
-			$value = sanitize_text_field( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
316
+			$value = sanitize_text_field( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
317 317
 		} else {
318
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
318
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
319 319
 			FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
320 320
 		}
321 321
 	}
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
 		$values['default_value'] = FrmAppHelper::maybe_json_encode( $field->default_value );
389 389
 
390 390
 		foreach ( array( 'name', 'description', 'type', 'field_order', 'field_options', 'required' ) as $col ) {
391
-			$values[ $col ] = $field->{$col};
391
+			$values[$col] = $field->{$col};
392 392
 		}
393 393
 	}
394 394
 
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
 		);
427 427
 
428 428
 		$msg = FrmField::get_option( $field, $error );
429
-		$msg = empty( $msg ) ? $defaults[ $error ]['part'] : $msg;
429
+		$msg = empty( $msg ) ? $defaults[$error]['part'] : $msg;
430 430
 		$msg = do_shortcode( $msg );
431 431
 
432 432
 		$msg = self::maybe_replace_substrings_with_field_name( $msg, $error, $field );
@@ -694,7 +694,7 @@  discard block
 block discarded – undo
694 694
 			'title'        => '',
695 695
 			'inside_class' => 'inside',
696 696
 		);
697
-		$args     = array_merge( $defaults, $args );
697
+		$args = array_merge( $defaults, $args );
698 698
 
699 699
 		include FrmAppHelper::plugin_path() . '/classes/views/frm-fields/back-end/inline-modal.php';
700 700
 	}
@@ -931,7 +931,7 @@  discard block
 block discarded – undo
931 931
 				continue;
932 932
 			}
933 933
 
934
-			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][ $short_key ] );
934
+			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][$short_key] );
935 935
 			$tag  = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
936 936
 
937 937
 			$atts['entry'] = $entry;
@@ -941,7 +941,7 @@  discard block
 block discarded – undo
941 941
 			if ( $replace_with !== null ) {
942 942
 				$replace_with = self::trigger_shortcode_atts( $replace_with, $atts );
943 943
 				self::sanitize_embedded_shortcodes( compact( 'entry' ), $replace_with );
944
-				$content = str_replace( $shortcodes[0][ $short_key ], $replace_with, $content );
944
+				$content = str_replace( $shortcodes[0][$short_key], $replace_with, $content );
945 945
 			}
946 946
 
947 947
 			unset( $atts, $replace_with );
@@ -959,7 +959,7 @@  discard block
 block discarded – undo
959 959
 		$supported_atts = array( 'remove_accents', 'sanitize', 'sanitize_url' );
960 960
 		$included_atts  = array_intersect( $supported_atts, array_keys( $atts ) );
961 961
 		foreach ( $included_atts as $included_att ) {
962
-			if ( '0' === $atts[ $included_att ] ) {
962
+			if ( '0' === $atts[$included_att] ) {
963 963
 				// Skip any option that uses 0 so sanitize_url=0 does not encode.
964 964
 				continue;
965 965
 			}
@@ -1037,8 +1037,8 @@  discard block
 block discarded – undo
1037 1037
 
1038 1038
 		$dynamic_default = array( 'admin_email', 'siteurl', 'frmurl', 'sitename', 'get', 'default-email', 'default-from-email' );
1039 1039
 
1040
-		if ( isset( $shortcode_values[ $atts['tag'] ] ) ) {
1041
-			$replace_with = $shortcode_values[ $atts['tag'] ];
1040
+		if ( isset( $shortcode_values[$atts['tag']] ) ) {
1041
+			$replace_with = $shortcode_values[$atts['tag']];
1042 1042
 		} elseif ( in_array( $atts['tag'], $dynamic_default, true ) ) {
1043 1043
 			$replace_with = self::dynamic_default_values( $atts['tag'], $atts );
1044 1044
 		} elseif ( $clean_tag === 'user_agent' ) {
@@ -1262,8 +1262,8 @@  discard block
 block discarded – undo
1262 1262
 			self::field_types_for_input( $single_input, $field_selection, $field_types );
1263 1263
 		} elseif ( in_array( $type, $multiple_input, true ) ) {
1264 1264
 			self::field_types_for_input( $multiple_input, $field_selection, $field_types );
1265
-		} elseif ( isset( $field_selection[ $type ] ) ) {
1266
-			$field_types[ $type ] = $field_selection[ $type ];
1265
+		} elseif ( isset( $field_selection[$type] ) ) {
1266
+			$field_types[$type] = $field_selection[$type];
1267 1267
 		}
1268 1268
 
1269 1269
 		$field_types = apply_filters( 'frm_switch_field_types', $field_types, compact( 'type', 'field_selection' ) );
@@ -1304,7 +1304,7 @@  discard block
 block discarded – undo
1304 1304
 		foreach ( $inputs as $input ) {
1305 1305
 			// This may not be set if a field type was removed using the frm_available_fields or frm_pro_available_fields filters.
1306 1306
 			if ( array_key_exists( $input, $fields ) ) {
1307
-				$field_types[ $input ] = $fields[ $input ];
1307
+				$field_types[$input] = $fields[$input];
1308 1308
 			}
1309 1309
 			unset( $input );
1310 1310
 		}
@@ -1337,7 +1337,7 @@  discard block
 block discarded – undo
1337 1337
 			'parent'  => false,
1338 1338
 			'pointer' => false,
1339 1339
 		);
1340
-		$args     = wp_parse_args( $args, $defaults );
1340
+		$args = wp_parse_args( $args, $defaults );
1341 1341
 
1342 1342
 		$opt_key   = $args['opt_key'];
1343 1343
 		$field     = $args['field'];
@@ -1353,25 +1353,25 @@  discard block
 block discarded – undo
1353 1353
 
1354 1354
 		// Check posted vals before checking saved values
1355 1355
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
1356
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1356
+		if ( $parent && isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1357 1357
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1358 1358
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1359
-				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1359
+				$other_val = isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ) : '';
1360 1360
 			} else {
1361
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1361
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1362 1362
 			}
1363 1363
 
1364 1364
 			return $other_val;
1365 1365
 		}
1366 1366
 
1367
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1367
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1368 1368
 			// For normal fields
1369 1369
 
1370 1370
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1371 1371
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1372
-				$other_val = isset( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1372
+				$other_val = isset( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ) : '';
1373 1373
 			} else {
1374
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1374
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1375 1375
 			}
1376 1376
 
1377 1377
 			return $other_val;
@@ -1381,8 +1381,8 @@  discard block
 block discarded – undo
1381 1381
 		if ( $field['type'] === 'checkbox' && is_array( $field['value'] ) ) {
1382 1382
 			// Check if there is an "other" val in saved value and make sure the
1383 1383
 			// "other" val is not equal to the Other checkbox option
1384
-			if ( isset( $field['value'][ $opt_key ] ) && $field['options'][ $opt_key ] != $field['value'][ $opt_key ] ) {
1385
-				$other_val = $field['value'][ $opt_key ];
1384
+			if ( isset( $field['value'][$opt_key] ) && $field['options'][$opt_key] != $field['value'][$opt_key] ) {
1385
+				$other_val = $field['value'][$opt_key];
1386 1386
 			}
1387 1387
 		} else {
1388 1388
 			/**
@@ -1394,8 +1394,8 @@  discard block
 block discarded – undo
1394 1394
 				// Multi-select dropdowns - key is not preserved
1395 1395
 				if ( is_array( $field['value'] ) ) {
1396 1396
 					$o_key = array_search( $temp_val, $field['value'] );
1397
-					if ( isset( $field['value'][ $o_key ] ) ) {
1398
-						unset( $field['value'][ $o_key ], $o_key );
1397
+					if ( isset( $field['value'][$o_key] ) ) {
1398
+						unset( $field['value'][$o_key], $o_key );
1399 1399
 					}
1400 1400
 				} elseif ( $temp_val == $field['value'] ) {
1401 1401
 					// For radio and regular dropdowns
@@ -1603,11 +1603,11 @@  discard block
 block discarded – undo
1603 1603
 			foreach ( $val as $k => $v ) {
1604 1604
 				if ( is_string( $v ) ) {
1605 1605
 					if ( 'custom_html' === $k ) {
1606
-						$val[ $k ] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
1606
+						$val[$k] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
1607 1607
 						unset( $k, $v );
1608 1608
 						continue;
1609 1609
 					}
1610
-					$val[ $k ] = str_replace( $replace, $replace_with, $v );
1610
+					$val[$k] = str_replace( $replace, $replace_with, $v );
1611 1611
 					unset( $k, $v );
1612 1612
 				}
1613 1613
 			}
@@ -1636,8 +1636,8 @@  discard block
 block discarded – undo
1636 1636
 			if ( false === $index ) {
1637 1637
 				continue;
1638 1638
 			}
1639
-			unset( $replace[ $index ] );
1640
-			unset( $replace_with[ $index ] );
1639
+			unset( $replace[$index] );
1640
+			unset( $replace_with[$index] );
1641 1641
 		}
1642 1642
 		$value = str_replace( $replace, $replace_with, $value );
1643 1643
 		return $value;
@@ -1985,7 +1985,7 @@  discard block
 block discarded – undo
1985 1985
 			$countries['class'] = 'frm-countries-opts';
1986 1986
 		}
1987 1987
 
1988
-		$prepop[ __( 'Countries', 'formidable' ) ] = $countries;
1988
+		$prepop[__( 'Countries', 'formidable' )] = $countries;
1989 1989
 
1990 1990
 		// State abv.
1991 1991
 		$states    = self::get_us_states();
@@ -1995,7 +1995,7 @@  discard block
 block discarded – undo
1995 1995
 			$state_abv['class'] = 'frm-state-abv-opts';
1996 1996
 		}
1997 1997
 
1998
-		$prepop[ __( 'U.S. State Abbreviations', 'formidable' ) ] = $state_abv;
1998
+		$prepop[__( 'U.S. State Abbreviations', 'formidable' )] = $state_abv;
1999 1999
 
2000 2000
 		// States.
2001 2001
 		$states = array_values( $states );
@@ -2004,7 +2004,7 @@  discard block
 block discarded – undo
2004 2004
 			$states['class'] = 'frm-states-opts';
2005 2005
 		}
2006 2006
 
2007
-		$prepop[ __( 'U.S. States', 'formidable' ) ] = $states;
2007
+		$prepop[__( 'U.S. States', 'formidable' )] = $states;
2008 2008
 		unset( $state_abv, $states );
2009 2009
 
2010 2010
 		// Age.
@@ -2022,7 +2022,7 @@  discard block
 block discarded – undo
2022 2022
 			$ages['class'] = 'frm-age-opts';
2023 2023
 		}
2024 2024
 
2025
-		$prepop[ __( 'Age', 'formidable' ) ] = $ages;
2025
+		$prepop[__( 'Age', 'formidable' )] = $ages;
2026 2026
 
2027 2027
 		// Satisfaction.
2028 2028
 		$satisfaction = array(
@@ -2037,7 +2037,7 @@  discard block
 block discarded – undo
2037 2037
 			$satisfaction['class'] = 'frm-satisfaction-opts';
2038 2038
 		}
2039 2039
 
2040
-		$prepop[ __( 'Satisfaction', 'formidable' ) ] = $satisfaction;
2040
+		$prepop[__( 'Satisfaction', 'formidable' )] = $satisfaction;
2041 2041
 
2042 2042
 		// Importance.
2043 2043
 		$importance = array(
@@ -2052,7 +2052,7 @@  discard block
 block discarded – undo
2052 2052
 			$importance['class'] = 'frm-importance-opts';
2053 2053
 		}
2054 2054
 
2055
-		$prepop[ __( 'Importance', 'formidable' ) ] = $importance;
2055
+		$prepop[__( 'Importance', 'formidable' )] = $importance;
2056 2056
 
2057 2057
 		// Agreement.
2058 2058
 		$agreement = array(
@@ -2067,7 +2067,7 @@  discard block
 block discarded – undo
2067 2067
 			$agreement['class'] = 'frm-agreement-opts';
2068 2068
 		}
2069 2069
 
2070
-		$prepop[ __( 'Agreement', 'formidable' ) ] = $agreement;
2070
+		$prepop[__( 'Agreement', 'formidable' )] = $agreement;
2071 2071
 
2072 2072
 		// Likely.
2073 2073
 		$likely = array(
@@ -2082,7 +2082,7 @@  discard block
 block discarded – undo
2082 2082
 			$likely['class'] = 'frm-likely-opts';
2083 2083
 		}
2084 2084
 
2085
-		$prepop[ __( 'Likely', 'formidable' ) ] = $likely;
2085
+		$prepop[__( 'Likely', 'formidable' )] = $likely;
2086 2086
 
2087 2087
 		$prepop = apply_filters( 'frm_bulk_field_choices', $prepop );
2088 2088
 	}
@@ -2303,16 +2303,16 @@  discard block
 block discarded – undo
2303 2303
 	 */
2304 2304
 	private static function fill_image_setting_options( $options, &$args ) {
2305 2305
 		foreach ( $options as $key => $option ) {
2306
-			$args['options'][ $key ] = $option;
2306
+			$args['options'][$key] = $option;
2307 2307
 
2308 2308
 			if ( ! empty( $option['addon'] ) ) {
2309
-				$args['options'][ $key ]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2309
+				$args['options'][$key]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2310 2310
 			}
2311 2311
 
2312
-			unset( $args['options'][ $key ]['addon'] );
2312
+			unset( $args['options'][$key]['addon'] );
2313 2313
 			$fill = array( 'upgrade', 'message', 'content' );
2314 2314
 			foreach ( $fill as $f ) {
2315
-				unset( $args['options'][ $key ][ $f ], $f );
2315
+				unset( $args['options'][$key][$f], $f );
2316 2316
 			}
2317 2317
 		}
2318 2318
 	}
@@ -2333,8 +2333,8 @@  discard block
 block discarded – undo
2333 2333
 
2334 2334
 		$fill = array( 'upgrade', 'message', 'content' );
2335 2335
 		foreach ( $fill as $f ) {
2336
-			if ( isset( $option[ $f ] ) ) {
2337
-				$custom_attrs[ 'data-' . $f ] = $option[ $f ];
2336
+			if ( isset( $option[$f] ) ) {
2337
+				$custom_attrs['data-' . $f] = $option[$f];
2338 2338
 			}
2339 2339
 		}
2340 2340
 
@@ -2400,7 +2400,7 @@  discard block
 block discarded – undo
2400 2400
 
2401 2401
 		return array_filter(
2402 2402
 			$rows,
2403
-			function ( $row ) {
2403
+			function( $row ) {
2404 2404
 				FrmAppHelper::unserialize_or_decode( $row->field_options );
2405 2405
 				return is_array( $row->field_options ) && ! empty( $row->field_options['draft'] );
2406 2406
 			}
Please login to merge, or discard this patch.
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -197,7 +197,8 @@  discard block
 block discarded – undo
197 197
 				return false;
198 198
 			}
199 199
 
200
-			if ( ! $_POST || ! isset( $_POST['field_options'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
200
+			if ( ! $_POST || ! isset( $_POST['field_options'] ) ) {
201
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
201 202
 				return false;
202 203
 			}
203 204
 
@@ -300,7 +301,8 @@  discard block
 block discarded – undo
300 301
 	 * @param mixed  $value
301 302
 	 */
302 303
 	private static function get_posted_field_setting( $setting, &$value ) {
303
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
304
+		if ( ! isset( $_POST['field_options'][ $setting ] ) ) {
305
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
304 306
 			return;
305 307
 		}
306 308
 
@@ -1353,7 +1355,8 @@  discard block
 block discarded – undo
1353 1355
 
1354 1356
 		// Check posted vals before checking saved values
1355 1357
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
1356
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1358
+		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) {
1359
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1357 1360
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1358 1361
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1359 1362
 				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
@@ -1364,7 +1367,8 @@  discard block
 block discarded – undo
1364 1367
 			return $other_val;
1365 1368
 		}
1366 1369
 
1367
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1370
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) {
1371
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1368 1372
 			// For normal fields
1369 1373
 
1370 1374
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
Please login to merge, or discard this patch.
classes/helpers/FrmOnSubmitHelper.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -329,17 +329,17 @@  discard block
 block discarded – undo
329 329
 	public static function populate_on_submit_data( &$form_options, $action = null, $event = 'create' ) {
330 330
 		$opt = 'update' === $event ? 'edit_' : 'success_';
331 331
 		if ( ! $action || ! is_object( $action ) ) {
332
-			$form_options[ $opt . 'action' ] = self::get_default_action_type();
333
-			$form_options[ $opt . 'msg' ]    = self::get_default_msg();
332
+			$form_options[$opt . 'action'] = self::get_default_action_type();
333
+			$form_options[$opt . 'msg']    = self::get_default_msg();
334 334
 
335 335
 			return;
336 336
 		}
337 337
 
338
-		$form_options[ $opt . 'action' ] = isset( $action->post_content['success_action'] ) ? $action->post_content['success_action'] : 'message';
338
+		$form_options[$opt . 'action'] = isset( $action->post_content['success_action'] ) ? $action->post_content['success_action'] : 'message';
339 339
 
340
-		switch ( $form_options[ $opt . 'action' ] ) {
340
+		switch ( $form_options[$opt . 'action'] ) {
341 341
 			case 'redirect':
342
-				$form_options[ $opt . 'url' ]        = isset( $action->post_content['success_url'] ) ? $action->post_content['success_url'] : '';
342
+				$form_options[$opt . 'url']        = isset( $action->post_content['success_url'] ) ? $action->post_content['success_url'] : '';
343 343
 				$form_options['open_in_new_tab']     = ! empty( $action->post_content['open_in_new_tab'] );
344 344
 				$form_options['redirect_delay']      = ! empty( $action->post_content['redirect_delay'] );
345 345
 				$form_options['redirect_delay_time'] = $action->post_content['redirect_delay_time'];
@@ -347,11 +347,11 @@  discard block
 block discarded – undo
347 347
 				break;
348 348
 
349 349
 			case 'page':
350
-				$form_options[ $opt . 'page_id' ] = isset( $action->post_content['success_page_id'] ) ? $action->post_content['success_page_id'] : '';
350
+				$form_options[$opt . 'page_id'] = isset( $action->post_content['success_page_id'] ) ? $action->post_content['success_page_id'] : '';
351 351
 				break;
352 352
 
353 353
 			default:
354
-				$form_options[ $opt . 'msg' ] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : self::get_default_msg();
354
+				$form_options[$opt . 'msg'] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : self::get_default_msg();
355 355
 				$form_options['show_form']    = ! empty( $action->post_content['show_form'] );
356 356
 		}
357 357
 	}
@@ -440,20 +440,20 @@  discard block
 block discarded – undo
440 440
 	private static function get_on_submit_action_data_from_form_options( $form_options, $event = 'create' ) {
441 441
 		$opt  = 'update' === $event ? 'edit_' : 'success_';
442 442
 		$data = array(
443
-			'success_action' => isset( $form_options[ $opt . 'action' ] ) ? $form_options[ $opt . 'action' ] : self::get_default_action_type(),
443
+			'success_action' => isset( $form_options[$opt . 'action'] ) ? $form_options[$opt . 'action'] : self::get_default_action_type(),
444 444
 		);
445 445
 
446 446
 		switch ( $data['success_action'] ) {
447 447
 			case 'redirect':
448
-				$data['success_url'] = isset( $form_options[ $opt . 'url' ] ) ? $form_options[ $opt . 'url' ] : '';
448
+				$data['success_url'] = isset( $form_options[$opt . 'url'] ) ? $form_options[$opt . 'url'] : '';
449 449
 				break;
450 450
 
451 451
 			case 'page':
452
-				$data['success_page_id'] = isset( $form_options[ $opt . 'page_id' ] ) ? $form_options[ $opt . 'page_id' ] : '';
452
+				$data['success_page_id'] = isset( $form_options[$opt . 'page_id'] ) ? $form_options[$opt . 'page_id'] : '';
453 453
 				break;
454 454
 
455 455
 			default:
456
-				$data['success_msg'] = isset( $form_options[ $opt . 'msg' ] ) ? $form_options[ $opt . 'msg' ] : self::get_default_msg();
456
+				$data['success_msg'] = isset( $form_options[$opt . 'msg'] ) ? $form_options[$opt . 'msg'] : self::get_default_msg();
457 457
 				$data['show_form']   = ! empty( $form_options['show_form'] );
458 458
 		}
459 459
 
Please login to merge, or discard this patch.
classes/models/FrmEntry.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -54,8 +54,8 @@  discard block
 block discarded – undo
54 54
 	 * @return void
55 55
 	 */
56 56
 	private static function flag_new_unique_key( $unique_id ) {
57
-		if ( ! isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
58
-			self::$unique_id_match_checks[ $unique_id ] = false;
57
+		if ( ! isset( self::$unique_id_match_checks[$unique_id] ) ) {
58
+			self::$unique_id_match_checks[$unique_id] = false;
59 59
 		}
60 60
 	}
61 61
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 				if ( 0 === (int) $meta->field_id ) {
108 108
 					continue;
109 109
 				}
110
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
110
+				$field_metas[$meta->field_id] = $meta->meta_value;
111 111
 			}
112 112
 
113 113
 			$filtered_vals = array_filter( $values['item_meta'] );
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
172 172
 			return false;
173 173
 		}
174 174
 
175
-		if ( isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
176
-			return self::$unique_id_match_checks[ $unique_id ];
175
+		if ( isset( self::$unique_id_match_checks[$unique_id] ) ) {
176
+			return self::$unique_id_match_checks[$unique_id];
177 177
 		}
178 178
 
179 179
 		$timestamp = strtotime( $created_at );
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 			$timestamp = time();
182 182
 		}
183 183
 
184
-		self::$unique_id_match_checks[ $unique_id ] = (bool) FrmDb::get_var(
184
+		self::$unique_id_match_checks[$unique_id] = (bool) FrmDb::get_var(
185 185
 			'frm_item_metas',
186 186
 			array(
187 187
 				'field_id'     => 0,
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 			'id'
192 192
 		);
193 193
 
194
-		return self::$unique_id_match_checks[ $unique_id ];
194
+		return self::$unique_id_match_checks[$unique_id];
195 195
 	}
196 196
 
197 197
 	/**
@@ -221,10 +221,10 @@  discard block
 block discarded – undo
221 221
 		$reduced = array();
222 222
 		foreach ( $filter_vals as $field_id => $value ) {
223 223
 			$field                = FrmFieldFactory::get_field_object( $field_id );
224
-			$reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
225
-			$reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] );
226
-			if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) {
227
-				unset( $reduced[ $field_id ] );
224
+			$reduced[$field_id] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
225
+			$reduced[$field_id] = $field->set_value_before_save( $reduced[$field_id] );
226
+			if ( '' === $reduced[$field_id] || ( is_array( $reduced[$field_id] ) && 0 === count( $reduced[$field_id] ) ) ) {
227
+				unset( $reduced[$field_id] );
228 228
 			}
229 229
 		}
230 230
 		return $reduced;
@@ -487,7 +487,7 @@  discard block
 block discarded – undo
487 487
 	private static function prepare_entries( &$entries ) {
488 488
 		foreach ( $entries as $k => $entry ) {
489 489
 			self::prepare_entry( $entry );
490
-			$entries[ $k ] = $entry;
490
+			$entries[$k] = $entry;
491 491
 		}
492 492
 	}
493 493
 
@@ -513,19 +513,19 @@  discard block
 block discarded – undo
513 513
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
514 514
 
515 515
 			if ( $meta_val->item_id == $entry->id ) {
516
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
516
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
517 517
 				if ( $include_key ) {
518
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
518
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
519 519
 				}
520 520
 				continue;
521 521
 			}
522 522
 
523 523
 			// include sub entries in an array
524
-			if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) {
525
-				$entry->metas[ $meta_val->field_id ] = array();
524
+			if ( ! isset( $entry->metas[$meta_val->field_id] ) ) {
525
+				$entry->metas[$meta_val->field_id] = array();
526 526
 			}
527 527
 
528
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
528
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
529 529
 
530 530
 			unset( $meta_val );
531 531
 		}
@@ -620,16 +620,16 @@  discard block
 block discarded – undo
620 620
 		}
621 621
 
622 622
 		foreach ( $metas as $m_key => $meta_val ) {
623
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
623
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
624 624
 				continue;
625 625
 			}
626 626
 
627
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
628
-				$entries[ $meta_val->item_id ]->metas = array();
627
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
628
+				$entries[$meta_val->item_id]->metas = array();
629 629
 			}
630 630
 
631 631
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
632
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
632
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
633 633
 			unset( $m_key, $meta_val );
634 634
 		}
635 635
 
@@ -812,7 +812,7 @@  discard block
 block discarded – undo
812 812
 	}
813 813
 
814 814
 	private static function get_entry_value( $values, $name, $default ) {
815
-		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
815
+		return isset( $values[$name] ) ? $values[$name] : $default;
816 816
 	}
817 817
 
818 818
 	/**
@@ -1019,7 +1019,7 @@  discard block
 block discarded – undo
1019 1019
 	private static function maybe_add_captcha_meta( $form_id, $entry_id ) {
1020 1020
 		global $frm_vars;
1021 1021
 		if ( array_key_exists( 'captcha_scores', $frm_vars ) && array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) {
1022
-			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] );
1022
+			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][$form_id] );
1023 1023
 			FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) );
1024 1024
 		}
1025 1025
 	}
Please login to merge, or discard this patch.
classes/helpers/FrmAddonsHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 			'convertkit'                      => 'convertkit',
172 172
 		);
173 173
 
174
-		$icon = array_key_exists( $slug, $icons_map ) ? 'frm_' . $icons_map[ $slug ] . '_icon' : 'frm_logo_icon';
174
+		$icon = array_key_exists( $slug, $icons_map ) ? 'frm_' . $icons_map[$slug] . '_icon' : 'frm_logo_icon';
175 175
 		if ( 'ai' === $slug ) {
176 176
 			$icon = str_replace( '_', '-', $icon );
177 177
 		}
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 		?>
272 272
 		<span style="color: <?php echo esc_attr( $color ); ?>;">
273 273
 			<?php
274
-			for ( $i = 0; $i < 5; $i++ ) {
274
+			for ( $i = 0; $i < 5; $i ++ ) {
275 275
 				echo $icon; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
276 276
 			}
277 277
 			?>
Please login to merge, or discard this patch.
classes/controllers/FrmFormActionsController.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -113,19 +113,19 @@  discard block
 block discarded – undo
113 113
 		}
114 114
 
115 115
 		foreach ( $action_controls as $action ) {
116
-			if ( isset( $groups[ $action->id_base ] ) || in_array( $action->id_base, $grouped ) ) {
116
+			if ( isset( $groups[$action->id_base] ) || in_array( $action->id_base, $grouped ) ) {
117 117
 				continue;
118 118
 			}
119 119
 
120 120
 			$this_group = $action->action_options['group'];
121
-			if ( ! isset( $groups[ $this_group ] ) ) {
121
+			if ( ! isset( $groups[$this_group] ) ) {
122 122
 				$this_group = 'misc';
123 123
 			}
124 124
 
125
-			if ( ! isset( $groups[ $this_group ]['actions'] ) ) {
126
-				$groups[ $this_group ]['actions'] = array();
125
+			if ( ! isset( $groups[$this_group]['actions'] ) ) {
126
+				$groups[$this_group]['actions'] = array();
127 127
 			}
128
-			$groups[ $this_group ]['actions'][] = $action->id_base;
128
+			$groups[$this_group]['actions'][] = $action->id_base;
129 129
 
130 130
 			unset( $action );
131 131
 		}
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 				return $a;
280 280
 			}
281 281
 
282
-			$actions[ $a->id_base ] = $a;
282
+			$actions[$a->id_base] = $a;
283 283
 		}
284 284
 
285 285
 		return $actions;
@@ -313,18 +313,18 @@  discard block
 block discarded – undo
313 313
 		$action_map = array();
314 314
 
315 315
 		foreach ( $action_controls as $key => $control ) {
316
-			$action_map[ $control->id_base ] = $key;
316
+			$action_map[$control->id_base] = $key;
317 317
 		}
318 318
 
319 319
 		self::maybe_show_limit_warning( $form->id, $form_actions );
320 320
 
321 321
 		foreach ( $form_actions as $action ) {
322
-			if ( ! isset( $action_map[ $action->post_excerpt ] ) ) {
322
+			if ( ! isset( $action_map[$action->post_excerpt] ) ) {
323 323
 				// don't try and show settings if action no longer exists
324 324
 				continue;
325 325
 			}
326 326
 
327
-			self::action_control( $action, $form, $action->ID, $action_controls[ $action_map[ $action->post_excerpt ] ], $values );
327
+			self::action_control( $action, $form, $action->ID, $action_controls[$action_map[$action->post_excerpt]], $values );
328 328
 		}
329 329
 	}
330 330
 
@@ -592,8 +592,8 @@  discard block
 block discarded – undo
592 592
 			}
593 593
 
594 594
 			// Store actions so they can be triggered with the correct priority.
595
-			$stored_actions[ $action->ID ]  = $action;
596
-			$action_priority[ $action->ID ] = $link_settings[ $action->post_excerpt ]->action_options['priority'];
595
+			$stored_actions[$action->ID]  = $action;
596
+			$action_priority[$action->ID] = $link_settings[$action->post_excerpt]->action_options['priority'];
597 597
 
598 598
 			unset( $action );
599 599
 		}//end foreach
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 			new FrmNotification();
606 606
 
607 607
 			foreach ( $action_priority as $action_id => $priority ) {
608
-				$action = $stored_actions[ $action_id ];
608
+				$action = $stored_actions[$action_id];
609 609
 
610 610
 				/**
611 611
 				 * Allows custom form action trigger.
@@ -669,12 +669,12 @@  discard block
 block discarded – undo
669 669
 	}
670 670
 
671 671
 	public function register( $action_class ) {
672
-		$this->actions[ $action_class ] = new $action_class();
672
+		$this->actions[$action_class] = new $action_class();
673 673
 	}
674 674
 
675 675
 	public function unregister( $action_class ) {
676
-		if ( isset( $this->actions[ $action_class ] ) ) {
677
-			unset( $this->actions[ $action_class ] );
676
+		if ( isset( $this->actions[$action_class] ) ) {
677
+			unset( $this->actions[$action_class] );
678 678
 		}
679 679
 	}
680 680
 
@@ -683,8 +683,8 @@  discard block
 block discarded – undo
683 683
 
684 684
 		foreach ( $keys as $key ) {
685 685
 			// don't register new action if old action with the same id is already registered
686
-			if ( ! isset( $this->actions[ $key ] ) ) {
687
-				$this->actions[ $key ]->_register();
686
+			if ( ! isset( $this->actions[$key] ) ) {
687
+				$this->actions[$key]->_register();
688 688
 			}
689 689
 		}
690 690
 	}
Please login to merge, or discard this patch.
classes/helpers/FrmCSVExportHelper.php 1 patch
Spacing   +54 added lines, -54 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 
129 129
 		unset( $filename );
130 130
 
131
-		$comment_count       = FrmDb::get_count(
131
+		$comment_count = FrmDb::get_count(
132 132
 			'frm_item_metas',
133 133
 			array(
134 134
 				'item_id'         => $atts['entry_ids'],
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 	private static function prepare_csv_headings() {
260 260
 		$headings = array();
261 261
 		self::csv_headings( $headings );
262
-		$headings       = apply_filters(
262
+		$headings = apply_filters(
263 263
 			'frm_csv_columns',
264 264
 			$headings,
265 265
 			self::$form_id,
@@ -283,10 +283,10 @@  discard block
 block discarded – undo
283 283
 		$field_headings  = array();
284 284
 		$separate_values = array( 'user_id', 'file', 'data', 'date' );
285 285
 		if ( ! empty( $col->field_options['separate_value'] ) && ! in_array( $col->type, $separate_values, true ) ) {
286
-			$field_headings[ $col->id . '_label' ] = strip_tags( $col->name . ' ' . __( '(label)', 'formidable' ) );
286
+			$field_headings[$col->id . '_label'] = strip_tags( $col->name . ' ' . __( '(label)', 'formidable' ) );
287 287
 		}
288 288
 
289
-		$field_headings[ $col->id ] = strip_tags( $col->name );
289
+		$field_headings[$col->id] = strip_tags( $col->name );
290 290
 		$field_headings             = apply_filters(
291 291
 			'frm_csv_field_columns',
292 292
 			$field_headings,
@@ -307,14 +307,14 @@  discard block
 block discarded – undo
307 307
 			if ( self::is_the_child_of_a_repeater( $col ) ) {
308 308
 				$repeater_id = $col->field_options['in_section'];
309 309
 				// Set a placeholder to maintain order for repeater fields.
310
-				$headings[ 'repeater' . $repeater_id ] = array();
310
+				$headings['repeater' . $repeater_id] = array();
311 311
 
312
-				if ( ! isset( $fields_by_repeater_id[ $repeater_id ] ) ) {
313
-					$fields_by_repeater_id[ $repeater_id ] = array();
312
+				if ( ! isset( $fields_by_repeater_id[$repeater_id] ) ) {
313
+					$fields_by_repeater_id[$repeater_id] = array();
314 314
 					$repeater_ids[]                        = $repeater_id;
315 315
 				}
316 316
 
317
-				$fields_by_repeater_id[ $repeater_id ][] = $col;
317
+				$fields_by_repeater_id[$repeater_id][] = $col;
318 318
 
319 319
 				continue;
320 320
 			}
@@ -333,8 +333,8 @@  discard block
 block discarded – undo
333 333
 				$end    = strpos( $row->meta_value, ':{' );
334 334
 				$length = substr( $row->meta_value, $start, $end - $start );
335 335
 
336
-				if ( $length > $max[ $row->field_id ] ) {
337
-					$max[ $row->field_id ] = $length;
336
+				if ( $length > $max[$row->field_id] ) {
337
+					$max[$row->field_id] = $length;
338 338
 				}
339 339
 			}
340 340
 			unset( $start, $end, $length, $row, $repeater_meta, $where );
@@ -345,17 +345,17 @@  discard block
 block discarded – undo
345 345
 					$repeater_id = str_replace( 'repeater', '', $key );
346 346
 
347 347
 					$repeater_headings = array();
348
-					foreach ( $fields_by_repeater_id[ $repeater_id ] as $col ) {
348
+					foreach ( $fields_by_repeater_id[$repeater_id] as $col ) {
349 349
 						$repeater_headings += self::field_headings( $col );
350 350
 					}
351 351
 
352
-					for ( $i = 0; $i < $max[ $repeater_id ]; $i++ ) {
352
+					for ( $i = 0; $i < $max[$repeater_id]; $i ++ ) {
353 353
 						foreach ( $repeater_headings as $repeater_key => $repeater_name ) {
354
-							$flat[ $repeater_key . '[' . $i . ']' ] = $repeater_name;
354
+							$flat[$repeater_key . '[' . $i . ']'] = $repeater_name;
355 355
 						}
356 356
 					}
357 357
 				} else {
358
-					$flat[ $key ] = $heading;
358
+					$flat[$key] = $heading;
359 359
 				}
360 360
 			}
361 361
 
@@ -368,10 +368,10 @@  discard block
 block discarded – undo
368 368
 		}//end if
369 369
 
370 370
 		if ( self::$comment_count ) {
371
-			for ( $i = 0; $i < self::$comment_count; $i++ ) {
372
-				$headings[ 'comment' . $i ]            = __( 'Comment', 'formidable' );
373
-				$headings[ 'comment_user_id' . $i ]    = __( 'Comment User', 'formidable' );
374
-				$headings[ 'comment_created_at' . $i ] = __( 'Comment Date', 'formidable' );
371
+			for ( $i = 0; $i < self::$comment_count; $i ++ ) {
372
+				$headings['comment' . $i]            = __( 'Comment', 'formidable' );
373
+				$headings['comment_user_id' . $i]    = __( 'Comment User', 'formidable' );
374
+				$headings['comment_created_at' . $i] = __( 'Comment Date', 'formidable' );
375 375
 			}
376 376
 			unset( $i );
377 377
 		}
@@ -416,7 +416,7 @@  discard block
 block discarded – undo
416 416
 
417 417
 	private static function prepare_next_csv_rows( $next_set ) {
418 418
 		if ( FrmAppHelper::pro_is_installed() ) {
419
-			$where    = array(
419
+			$where = array(
420 420
 				'or'             => 1,
421 421
 				'id'             => $next_set,
422 422
 				'parent_item_id' => $next_set,
@@ -473,32 +473,32 @@  discard block
 block discarded – undo
473 473
 					continue;
474 474
 				}
475 475
 
476
-				if ( ! isset( $entries[ self::$entry->parent_item_id ] ) ) {
477
-					$entries[ self::$entry->parent_item_id ]        = new stdClass();
478
-					$entries[ self::$entry->parent_item_id ]->metas = array();
476
+				if ( ! isset( $entries[self::$entry->parent_item_id] ) ) {
477
+					$entries[self::$entry->parent_item_id]        = new stdClass();
478
+					$entries[self::$entry->parent_item_id]->metas = array();
479 479
 				}
480 480
 
481
-				if ( ! isset( $entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] ) ) {
482
-					$entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] = array();
483
-				} elseif ( ! is_array( $entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] ) ) {
481
+				if ( ! isset( $entries[self::$entry->parent_item_id]->metas[$meta_id] ) ) {
482
+					$entries[self::$entry->parent_item_id]->metas[$meta_id] = array();
483
+				} elseif ( ! is_array( $entries[self::$entry->parent_item_id]->metas[$meta_id] ) ) {
484 484
 					// if the data is here, it should be an array but if this field has collected data
485 485
 					// both while inside and outside of the repeating section, it's possible this is a string.
486
-					$entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] = (array) $entries[ self::$entry->parent_item_id ]->metas[ $meta_id ];
486
+					$entries[self::$entry->parent_item_id]->metas[$meta_id] = (array) $entries[self::$entry->parent_item_id]->metas[$meta_id];
487 487
 				}
488 488
 
489 489
 				// Add the repeated values.
490
-				$entries[ self::$entry->parent_item_id ]->metas[ $meta_id ][] = $meta_value;
490
+				$entries[self::$entry->parent_item_id]->metas[$meta_id][] = $meta_value;
491 491
 			}//end foreach
492 492
 
493 493
 			self::$entry->metas                              = self::fill_missing_repeater_metas( self::$entry->metas, $entries );
494
-			$entries[ self::$entry->parent_item_id ]->metas += self::$entry->metas;
494
+			$entries[self::$entry->parent_item_id]->metas += self::$entry->metas;
495 495
 		}//end if
496 496
 
497 497
 		// add the embedded form id
498
-		if ( ! isset( $entries[ self::$entry->parent_item_id ]->embedded_fields ) ) {
499
-			$entries[ self::$entry->parent_item_id ]->embedded_fields = array();
498
+		if ( ! isset( $entries[self::$entry->parent_item_id]->embedded_fields ) ) {
499
+			$entries[self::$entry->parent_item_id]->embedded_fields = array();
500 500
 		}
501
-		$entries[ self::$entry->parent_item_id ]->embedded_fields[ self::$entry->id ] = self::$entry->form_id;
501
+		$entries[self::$entry->parent_item_id]->embedded_fields[self::$entry->id] = self::$entry->form_id;
502 502
 	}
503 503
 
504 504
 	/**
@@ -519,19 +519,19 @@  discard block
 block discarded – undo
519 519
 		}
520 520
 
521 521
 		$repeater_id = $field->field_options['in_section'];
522
-		if ( ! isset( self::$fields_by_repeater_id[ $repeater_id ] ) ) {
522
+		if ( ! isset( self::$fields_by_repeater_id[$repeater_id] ) ) {
523 523
 			return $metas;
524 524
 		}
525 525
 
526
-		foreach ( self::$fields_by_repeater_id[ $repeater_id ] as $repeater_child ) {
527
-			if ( ! isset( $metas[ $repeater_child->id ] ) ) {
528
-				$metas[ $repeater_child->id ] = '';
526
+		foreach ( self::$fields_by_repeater_id[$repeater_id] as $repeater_child ) {
527
+			if ( ! isset( $metas[$repeater_child->id] ) ) {
528
+				$metas[$repeater_child->id] = '';
529 529
 
530
-				if ( ! isset( $entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ] ) || ! is_array( $entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ] ) ) {
531
-					$entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ] = array();
530
+				if ( ! isset( $entries[self::$entry->parent_item_id]->metas[$repeater_child->id] ) || ! is_array( $entries[self::$entry->parent_item_id]->metas[$repeater_child->id] ) ) {
531
+					$entries[self::$entry->parent_item_id]->metas[$repeater_child->id] = array();
532 532
 				}
533 533
 
534
-				$entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ][] = '';
534
+				$entries[self::$entry->parent_item_id]->metas[$repeater_child->id][] = '';
535 535
 			}
536 536
 		}
537 537
 
@@ -550,7 +550,7 @@  discard block
 block discarded – undo
550 550
 
551 551
 	private static function add_field_values_to_csv( &$row ) {
552 552
 		foreach ( self::$fields as $col ) {
553
-			$field_value = isset( self::$entry->metas[ $col->id ] ) ? self::$entry->metas[ $col->id ] : false;
553
+			$field_value = isset( self::$entry->metas[$col->id] ) ? self::$entry->metas[$col->id] : false;
554 554
 
555 555
 			FrmFieldsHelper::prepare_field_value( $field_value, $col->type );
556 556
 			self::add_array_values_to_columns( $row, compact( 'col', 'field_value' ) );
@@ -569,20 +569,20 @@  discard block
 block discarded – undo
569 569
 			if ( ! empty( $col->field_options['separate_value'] ) ) {
570 570
 				$label_key = $col->id . '_label';
571 571
 				if ( self::is_the_child_of_a_repeater( $col ) ) {
572
-					$row[ $label_key ] = array();
572
+					$row[$label_key] = array();
573 573
 
574 574
 					if ( is_array( $field_value ) ) {
575 575
 						foreach ( $field_value as $value ) {
576
-							$row[ $label_key ][] = self::get_separate_value_label( $value, $col );
576
+							$row[$label_key][] = self::get_separate_value_label( $value, $col );
577 577
 						}
578 578
 					}
579 579
 				} else {
580
-					$row[ $label_key ] = self::get_separate_value_label( $field_value, $col );
580
+					$row[$label_key] = self::get_separate_value_label( $field_value, $col );
581 581
 				}
582 582
 				unset( $label_key );
583 583
 			}
584 584
 
585
-			$row[ $col->id ] = $field_value;
585
+			$row[$col->id] = $field_value;
586 586
 
587 587
 			unset( $col, $field_value );
588 588
 		}//end foreach
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 				'show_icon'         => false,
606 606
 				'entry_id'          => self::$entry->id,
607 607
 				'sep'               => self::$separator,
608
-				'embedded_field_id' => isset( self::$entry->embedded_fields ) && isset( self::$entry->embedded_fields[ self::$entry->id ] ) ? 'form' . self::$entry->embedded_fields[ self::$entry->id ] : 0,
608
+				'embedded_field_id' => isset( self::$entry->embedded_fields ) && isset( self::$entry->embedded_fields[self::$entry->id] ) ? 'form' . self::$entry->embedded_fields[self::$entry->id] : 0,
609 609
 			)
610 610
 		);
611 611
 	}
@@ -620,8 +620,8 @@  discard block
 block discarded – undo
620 620
 					// This is combo field inside repeater. The heading key has this format: [86_first[0]].
621 621
 					foreach ( $sub_value as $sub_key => $sub_sub_value ) {
622 622
 						$column_key = $atts['col']->id . '_' . $sub_key . '[' . $key . ']';
623
-						if ( ! is_numeric( $sub_key ) && isset( self::$headings[ $column_key ] ) ) {
624
-							$row[ $column_key ] = $sub_sub_value;
623
+						if ( ! is_numeric( $sub_key ) && isset( self::$headings[$column_key] ) ) {
624
+							$row[$column_key] = $sub_sub_value;
625 625
 						}
626 626
 					}
627 627
 
@@ -629,8 +629,8 @@  discard block
 block discarded – undo
629 629
 				}
630 630
 
631 631
 				$column_key = $atts['col']->id . '_' . $key;
632
-				if ( ! is_numeric( $key ) && isset( self::$headings[ $column_key ] ) ) {
633
-					$row[ $column_key ] = $sub_value;
632
+				if ( ! is_numeric( $key ) && isset( self::$headings[$column_key] ) ) {
633
+					$row[$column_key] = $sub_value;
634 634
 				}
635 635
 			}
636 636
 		}
@@ -655,18 +655,18 @@  discard block
 block discarded – undo
655 655
 		$echo = 'echo' === self::$mode;
656 656
 
657 657
 		foreach ( self::$headings as $k => $heading ) {
658
-			if ( isset( $rows[ $k ] ) ) {
659
-				$row = $rows[ $k ];
658
+			if ( isset( $rows[$k] ) ) {
659
+				$row = $rows[$k];
660 660
 			} else {
661 661
 				$row = '';
662 662
 				// array indexed data is not at $rows[ $k ]
663
-				if ( $k[ strlen( $k ) - 1 ] === ']' ) {
663
+				if ( $k[strlen( $k ) - 1] === ']' ) {
664 664
 					$start = strrpos( $k, '[' );
665
-					$key   = substr( $k, 0, $start++ );
665
+					$key   = substr( $k, 0, $start ++ );
666 666
 					$index = substr( $k, $start, strlen( $k ) - 1 - $start );
667 667
 
668
-					if ( isset( $rows[ $key ] ) && isset( $rows[ $key ][ $index ] ) ) {
669
-						$row = $rows[ $key ][ $index ];
668
+					if ( isset( $rows[$key] ) && isset( $rows[$key][$index] ) ) {
669
+						$row = $rows[$key][$index];
670 670
 					}
671 671
 
672 672
 					unset( $start, $key, $index );
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldEmail.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 		}
50 50
 		$errors = array();
51 51
 		if ( false !== strpos( $args['value'], '.@' ) || ! is_email( $args['value'] ) ) {
52
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
52
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
53 53
 		}
54 54
 		return $errors;
55 55
 	}
Please login to merge, or discard this patch.