Strategy11 / formidable-forms

classes/models/FrmSettings.php

Spacing +4 added lines, -4 removed lines

@@ -239,8 +239,8 @@ 
 		}
 
 		foreach ( $settings as $setting => $default ) {
-			if ( isset( $params[ 'frm_' . $setting ] ) ) {
-				$this->{$setting} = $params[ 'frm_' . $setting ];
+			if ( isset( $params['frm_' . $setting] ) ) {
+				$this->{$setting} = $params['frm_' . $setting];
 			} elseif ( ! isset( $this->{$setting} ) ) {
 				$this->{$setting} = $default;
 			}
@@ -432,7 +432,7 @@ 
 			'denylist_check',
 		);
 		foreach ( $checkboxes as $set ) {
-			$this->$set = isset( $params[ 'frm_' . $set ] ) ? absint( $params[ 'frm_' . $set ] ) : 0;
+			$this->$set = isset( $params['frm_' . $set] ) ? absint( $params['frm_' . $set] ) : 0;
 		}
 	}
 
@@ -445,7 +445,7 @@ 
 		$frm_roles = FrmAppHelper::frm_capabilities();
 		$roles     = get_editable_roles();
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
-			$this->$frm_role = (array) ( isset( $params[ $frm_role ] ) ? $params[ $frm_role ] : 'administrator' );
+			$this->$frm_role = (array) ( isset( $params[$frm_role] ) ? $params[$frm_role] : 'administrator' );
 
 			// Make sure administrators always have permissions
 			if ( ! in_array( 'administrator', $this->$frm_role, true ) ) {

square/models/FrmSquareLiteSettings.php

Spacing +3 added lines, -3 removed lines

@@ -82,12 +82,12 @@
 		$settings = $this->default_options();
 
 		foreach ( $settings as $setting => $default ) {
-			if ( isset( $params[ 'frm_' . $this->param() . '_' . $setting ] ) ) {
-				$this->settings->{$setting} = trim( sanitize_text_field( $params[ 'frm_' . $this->param() . '_' . $setting ] ) );
+			if ( isset( $params['frm_' . $this->param() . '_' . $setting] ) ) {
+				$this->settings->{$setting} = trim( sanitize_text_field( $params['frm_' . $this->param() . '_' . $setting] ) );
 			}
 		}
 
-		$this->settings->test_mode = isset( $params[ 'frm_' . $this->param() . '_test_mode' ] ) ? absint( $params[ 'frm_' . $this->param() . '_test_mode' ] ) : 0;
+		$this->settings->test_mode = isset( $params['frm_' . $this->param() . '_test_mode'] ) ? absint( $params['frm_' . $this->param() . '_test_mode'] ) : 0;
 	}
 
 	/**

square/controllers/FrmSquareLiteAppController.php

Spacing +5 added lines, -5 removed lines

@@ -123,9 +123,9 @@ 
 		$address_setting    = $action->post_content['billing_address'];
 
 		$entry      = self::generate_false_entry();
-		$first_name = $first_name_setting && isset( $entry->metas[ $first_name_setting ] ) ? $entry->metas[ $first_name_setting ] : '';
-		$last_name  = $last_name_setting && isset( $entry->metas[ $last_name_setting ] ) ? $entry->metas[ $last_name_setting ] : '';
-		$address    = $address_setting && isset( $entry->metas[ $address_setting ] ) ? $entry->metas[ $address_setting ] : '';
+		$first_name = $first_name_setting && isset( $entry->metas[$first_name_setting] ) ? $entry->metas[$first_name_setting] : '';
+		$last_name  = $last_name_setting && isset( $entry->metas[$last_name_setting] ) ? $entry->metas[$last_name_setting] : '';
+		$address    = $address_setting && isset( $entry->metas[$address_setting] ) ? $entry->metas[$address_setting] : '';
 
 		if ( is_array( $first_name ) && isset( $first_name['first'] ) ) {
 			$first_name = $first_name['first'];
@@ -141,7 +141,7 @@ 
 		);
 
 		if ( $email_setting ) {
-			$shortcode_atts   = array(
+			$shortcode_atts = array(
 				'entry' => $entry,
 				'form'  => $action->menu_order,
 				'value' => $email_setting,
@@ -181,7 +181,7 @@ 
 				if ( is_array( $v ) ) {
 					foreach ( $v as $f => $value ) {
 						FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
-						$entry->metas[ absint( $f ) ] = $value;
+						$entry->metas[absint( $f )] = $value;
 					}
 				}
 			} else {

square/controllers/FrmSquareLiteActionsController.php

Braces +4 added lines, -2 removed lines

@@ -139,7 +139,8 @@ 
 	 * @return string|true string on error, true on success.
 	 */
 	private static function trigger_one_time_payment( $atts ) {
-		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return __( 'Please enter a valid credit card', 'formidable' );
 		}
 
@@ -199,7 +200,8 @@ 
 	 * @return bool|string True on success, error message on failure
 	 */
 	private static function trigger_recurring_payment( $atts ) {
-		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return __( 'Please enter a valid credit card', 'formidable' );
 		}
 

Spacing +9 added lines, -9 removed lines

@@ -76,7 +76,7 @@ 
 			$gateway   = $payment_action->post_content['gateway'];
 			$is_square = $gateway === 'square' || ( is_array( $gateway ) && in_array( 'square', $gateway, true ) );
 			if ( ! $is_square || empty( $payment_action->post_content['amount'] ) ) {
-				unset( $payment_actions[ $k ] );
+				unset( $payment_actions[$k] );
 			}
 		}
 		return $payment_actions;
@@ -97,7 +97,7 @@ 
 			'run_triggers' => false,
 			'show_errors'  => true,
 		);
-		$atts     = compact( 'action', 'entry', 'form' );
+		$atts = compact( 'action', 'entry', 'form' );
 
 		$amount = self::prepare_amount( $action->post_content['amount'], $atts );
 		if ( empty( $amount ) || $amount == 000 ) {
@@ -150,7 +150,7 @@ 
 				'value' => $atts['action']->post_content['description'],
 			)
 		);
-		$result             = FrmSquareLiteConnectHelper::create_payment( $atts['amount'], $currency, $square_token, $verification_token, $description );
+		$result = FrmSquareLiteConnectHelper::create_payment( $atts['amount'], $currency, $square_token, $verification_token, $description );
 
 		if ( false === $result ) {
 			return FrmSquareLiteConnectHelper::get_latest_error_from_square_api();
@@ -455,7 +455,7 @@ 
 			false
 		);
 
-		$square_vars     = array(
+		$square_vars = array(
 			'formId'     => $form_id,
 			'nonce'      => wp_create_nonce( 'frm_square_ajax' ),
 			'ajax'       => esc_url_raw( FrmAppHelper::get_ajax_url() ),
@@ -572,7 +572,7 @@ 
 		$disallowed = array( ';', ':', '!important' );
 		foreach ( $settings as $k => $s ) {
 			if ( is_string( $s ) ) {
-				$settings[ $k ] = str_replace( $disallowed, '', $s );
+				$settings[$k] = str_replace( $disallowed, '', $s );
 			}
 		}
 
@@ -598,11 +598,11 @@ 
 
 		$field_id = isset( $field->temp_id ) ? $field->temp_id : $field->id;
 
-		if ( isset( $errors[ 'field' . $field_id . '-cc' ] ) ) {
-			unset( $errors[ 'field' . $field_id . '-cc' ] );
+		if ( isset( $errors['field' . $field_id . '-cc'] ) ) {
+			unset( $errors['field' . $field_id . '-cc'] );
 		}
-		if ( isset( $errors[ 'field' . $field_id ] ) ) {
-			unset( $errors[ 'field' . $field_id ] );
+		if ( isset( $errors['field' . $field_id] ) ) {
+			unset( $errors['field' . $field_id] );
 		}
 
 		return $errors;

stripe/controllers/FrmTransLiteActionsController.php

Spacing +4 added lines, -4 removed lines

@@ -472,8 +472,8 @@ 
 			return $values;
 		}
 
-		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[ $field->id ] ) ) {
-			$values['value'] = $previous_entry->metas[ $field->id ];
+		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[$field->id] ) ) {
+			$values['value'] = $previous_entry->metas[$field->id];
 		}
 
 		$frm_vars['trans_filled'] = true;
@@ -508,7 +508,7 @@ 
 			 * @param Closure    $destroy_callback
 			 * @return void
 			 */
-			function () use ( $entry_id, &$destroy_callback ) {
+			function() use ( $entry_id, &$destroy_callback ) {
 				FrmEntry::destroy( $entry_id );
 				// Only call this once.
 				remove_action( 'frm_entry_form', $destroy_callback );
@@ -528,7 +528,7 @@ 
 	 * @return array
 	 */
 	public static function before_save_settings( $settings, $action ) {
-		$settings['gateway']  = ! empty( $settings['gateway'] ) ? (array) $settings['gateway'] : array( 'stripe' );
+		$settings['gateway'] = ! empty( $settings['gateway'] ) ? (array) $settings['gateway'] : array( 'stripe' );
 
 		if ( in_array( 'square', $settings['gateway'] ) ) {
 			$currency = FrmSquareLiteConnectHelper::get_merchant_currency();

classes/models/fields/FrmFieldType.php

Spacing +22 added lines, -22 removed lines

@@ -156,8 +156,8 @@ 
 		$field_val = '';
 		if ( is_object( $this->field ) ) {
 			$field_val = $this->field->{$column};
-		} elseif ( is_array( $this->field ) && isset( $this->field[ $column ] ) ) {
-			$field_val = $this->field[ $column ];
+		} elseif ( is_array( $this->field ) && isset( $this->field[$column] ) ) {
+			$field_val = $this->field[$column];
 		}
 
 		return $field_val;
@@ -171,7 +171,7 @@ 
 		if ( is_object( $this->field ) ) {
 			$this->field->{$column} = $value;
 		} elseif ( is_array( $this->field ) ) {
-			$this->field[ $column ] = $value;
+			$this->field[$column] = $value;
 		}
 	}
 
@@ -630,7 +630,7 @@ 
 			printf(
 				/* translators: %s: Field type */
 				esc_html__( '%s Options', 'formidable' ),
-				esc_html( $all_field_types[ $args['display']['type'] ]['name'] )
+				esc_html( $all_field_types[$args['display']['type']]['name'] )
 			);
 			FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown8_icon', array( 'aria-hidden' => 'true' ) );
 			?>
@@ -730,7 +730,7 @@ 
 	 * New field
 	 */
 	public function get_new_field_defaults() {
-		$field        = array(
+		$field = array(
 			'name'          => $this->get_new_field_name(),
 			'description'   => '',
 			'type'          => $this->type,
@@ -761,8 +761,8 @@ 
 
 		$fields = array_merge( $fields, $pro_fields );
 
-		if ( isset( $fields[ $this->type ] ) ) {
-			$name = is_array( $fields[ $this->type ] ) ? $fields[ $this->type ]['name'] : $fields[ $this->type ];
+		if ( isset( $fields[$this->type] ) ) {
+			$name = is_array( $fields[$this->type] ) ? $fields[$this->type]['name'] : $fields[$this->type];
 		}
 
 		return $name;
@@ -779,7 +779,7 @@ 
 	 * @return array
 	 */
 	public function get_default_field_options() {
-		$opts        = array(
+		$opts = array(
 			'size'               => '',
 			'max'                => '',
 			'label'              => '',
@@ -1023,7 +1023,7 @@ 
 	 * @return void
 	 */
 	public function set_aria_invalid_error( &$shortcode_atts, $args ) {
-		$shortcode_atts['aria-invalid'] = isset( $args['errors'][ 'field' . $this->field_id ] ) ? 'true' : 'false';
+		$shortcode_atts['aria-invalid'] = isset( $args['errors']['field' . $this->field_id] ) ? 'true' : 'false';
 	}
 
 	/**
@@ -1183,11 +1183,11 @@ 
 		}
 
 		$options = array_values( $this->field['options'] );
-		if ( ! isset( $options[ $opt ] ) ) {
+		if ( ! isset( $options[$opt] ) ) {
 			return $hidden;
 		}
 
-		$option = $options[ $opt ];
+		$option = $options[$opt];
 		if ( is_array( $option ) ) {
 			$option = $option['value'];
 		}
@@ -1251,8 +1251,8 @@ 
 		$selected = $values['field_value'];
 
 		if ( isset( $values['combo_name'] ) ) {
-			$options  = $options[ $values['combo_name'] ];
-			$selected = is_array( $selected ) && isset( $selected[ $values['combo_name'] ] ) ? $selected[ $values['combo_name'] ] : '';
+			$options  = $options[$values['combo_name']];
+			$selected = is_array( $selected ) && isset( $selected[$values['combo_name']] ) ? $selected[$values['combo_name']] : '';
 		}
 
 		$input = $this->select_tag( $values );
@@ -1307,7 +1307,7 @@ 
 	}
 
 	protected function fill_display_field_values( $args = array() ) {
-		$defaults        = array(
+		$defaults = array(
 			'field_name'    => 'item_meta[' . $this->get_field_column( 'id' ) . ']',
 			'field_id'      => $this->get_field_column( 'id' ),
 			'field_plus_id' => '',
@@ -1364,7 +1364,7 @@ 
 			}
 		}
 
-		if ( isset( $args['errors'][ 'field' . $args['field_id'] ] ) && ! $custom_error_fields ) {
+		if ( isset( $args['errors']['field' . $args['field_id']] ) && ! $custom_error_fields ) {
 			if ( $error_comes_first ) {
 				array_unshift( $describedby, 'frm_error_' . $args['html_id'] );
 			} else {
@@ -1442,11 +1442,11 @@ 
 
 		$field_id = $this->get_field_column( 'id' );
 		if ( ! array_key_exists( $field_id, $frm_validated_unique_values ) ) {
-			$frm_validated_unique_values[ $field_id ] = array();
+			$frm_validated_unique_values[$field_id] = array();
 			return false;
 		}
 
-		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[ $field_id ], true );
+		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[$field_id], true );
 		return $already_validated_this_value;
 	}
 
@@ -1471,7 +1471,7 @@ 
 	private function value_validated_as_unique( $value ) {
 		global $frm_validated_unique_values;
 		$field_id                                   = $this->get_field_column( 'id' );
-		$frm_validated_unique_values[ $field_id ][] = $value;
+		$frm_validated_unique_values[$field_id][] = $value;
 	}
 
 	/**
@@ -1516,8 +1516,8 @@ 
 		$value = $this->prepare_display_value( $value, $atts );
 
 		if ( is_array( $value ) ) {
-			if ( ! empty( $atts['show'] ) && isset( $value[ $atts['show'] ] ) ) {
-				$value = $value[ $atts['show'] ];
+			if ( ! empty( $atts['show'] ) && isset( $value[$atts['show']] ) ) {
+				$value = $value[$atts['show']];
 			} elseif ( empty( $atts['return_array'] ) ) {
 				$sep   = isset( $atts['sep'] ) ? $atts['sep'] : ', ';
 				$value = FrmAppHelper::safe_implode( $sep, $value );
@@ -1647,8 +1647,8 @@ 
 		$saved_entries = $atts['ids'];
 		$new_value     = array();
 		foreach ( (array) $value as $old_child_id ) {
-			if ( isset( $saved_entries[ $old_child_id ] ) ) {
-				$new_value[] = $saved_entries[ $old_child_id ];
+			if ( isset( $saved_entries[$old_child_id] ) ) {
+				$new_value[] = $saved_entries[$old_child_id];
 			}
 		}
 

classes/controllers/FrmFieldsController.php

Spacing +26 added lines, -26 removed lines

@@ -25,7 +25,7 @@ 
 
 		$_GET['page'] = 'formidable';
 
-		$values     = array(
+		$values = array(
 			'id'         => FrmAppHelper::get_post_param( 'form_id', '', 'absint' ),
 			'doing_ajax' => true,
 		);
@@ -48,7 +48,7 @@ 
 
 			ob_start();
 			self::load_single_field( $field, $values );
-			$field_html[ absint( $field->id ) ] = ob_get_contents();
+			$field_html[absint( $field->id )] = ob_get_contents();
 			ob_end_clean();
 		}
 
@@ -263,7 +263,7 @@ 
 			foreach ( $opts as $opt_key => $opt ) {
 				if ( strpos( $opt, '|' ) !== false ) {
 					$vals             = explode( '|', $opt );
-					$opts[ $opt_key ] = array(
+					$opts[$opt_key] = array(
 						'label' => trim( $vals[0] ),
 						'value' => trim( $vals[1] ),
 					);
@@ -278,7 +278,7 @@ 
 			$other_array = array();
 			foreach ( $field['options'] as $opt_key => $opt ) {
 				if ( FrmFieldsHelper::is_other_opt( $opt_key ) ) {
-					$other_array[ $opt_key ] = $opt;
+					$other_array[$opt_key] = $opt;
 				}
 				unset( $opt_key, $opt );
 			}
@@ -321,18 +321,18 @@ 
 		$frm_settings         = FrmAppHelper::get_settings();
 		$field_types          = FrmFieldTypeOptionData::get_field_types( $field['type'] );
 
-		if ( ! isset( $all_field_types[ $field['type'] ] ) ) {
+		if ( ! isset( $all_field_types[$field['type']] ) ) {
 			// Add fallback for an add-on field type that has been deactivated.
-			$all_field_types[ $field['type'] ] = array(
+			$all_field_types[$field['type']] = array(
 				'name' => ucfirst( $field['type'] ),
 				'icon' => 'frm_icon_font frm_pencil_icon',
 			);
-		} elseif ( ! is_array( $all_field_types[ $field['type'] ] ) ) {
+		} elseif ( ! is_array( $all_field_types[$field['type']] ) ) {
 			// Fallback for fields added in a more basic way.
-			FrmFormsHelper::prepare_field_type( $all_field_types[ $field['type'] ] );
+			FrmFormsHelper::prepare_field_type( $all_field_types[$field['type']] );
 		}
 
-		$type_name = $all_field_types[ $field['type'] ]['name'];
+		$type_name = $all_field_types[$field['type']]['name'];
 		if ( $field['type'] === 'divider' && FrmField::is_option_true( $field, 'repeat' ) ) {
 			$type_name = $all_field_types['divider|repeat']['name'];
 		}
@@ -409,14 +409,14 @@ 
 
 		if ( FrmAppHelper::pro_is_connected() ) {
 			foreach ( $settings as $type ) {
-				if ( ! empty( $field[ $type ] ) ) {
+				if ( ! empty( $field[$type] ) ) {
 					$active = $type;
 				}
 			}
 		}
 
-		$types[ $active ]['class']  .= ' current';
-		$types[ $active ]['current'] = true;
+		$types[$active]['class']  .= ' current';
+		$types[$active]['current'] = true;
 
 		return $types;
 	}
@@ -434,8 +434,8 @@ 
 			'website' => 'url',
 			'image'   => 'url',
 		);
-		if ( isset( $type_switch[ $type ] ) ) {
-			$type = $type_switch[ $type ];
+		if ( isset( $type_switch[$type] ) ) {
+			$type = $type_switch[$type];
 		}
 
 		$pro_fields = FrmField::pro_field_selection();
@@ -590,11 +590,11 @@ 
 		// include "col" for valid html
 		$unit = trim( preg_replace( '/[0-9]+/', '', $field['size'] ) );
 
-		if ( ! isset( $calc[ $unit ] ) ) {
+		if ( ! isset( $calc[$unit] ) ) {
 			return;
 		}
 
-		$size = (float) str_replace( $unit, '', $field['size'] ) / $calc[ $unit ];
+		$size = (float) str_replace( $unit, '', $field['size'] ) / $calc[$unit];
 
 		$add_html['cols'] = 'cols="' . absint( $size ) . '"';
 	}
@@ -827,11 +827,11 @@ 
 	private static function get_form_for_js_validation( $field ) {
 		global $frm_vars;
 		if ( ! empty( $frm_vars['js_validate_forms'] ) ) {
-			if ( isset( $frm_vars['js_validate_forms'][ $field['form_id'] ] ) ) {
-				return $frm_vars['js_validate_forms'][ $field['form_id'] ];
+			if ( isset( $frm_vars['js_validate_forms'][$field['form_id']] ) ) {
+				return $frm_vars['js_validate_forms'][$field['form_id']];
 			}
-			if ( ! empty( $field['parent_form_id'] ) && isset( $frm_vars['js_validate_forms'][ $field['parent_form_id'] ] ) ) {
-				return $frm_vars['js_validate_forms'][ $field['parent_form_id'] ];
+			if ( ! empty( $field['parent_form_id'] ) && isset( $frm_vars['js_validate_forms'][$field['parent_form_id']] ) ) {
+				return $frm_vars['js_validate_forms'][$field['parent_form_id']];
 			}
 		}
 		return false;
@@ -918,13 +918,13 @@ 
 		foreach ( $field['shortcodes'] as $k => $v ) {
 			if ( isset( $field['subfield_name'] ) && 0 === strpos( $k, 'aria-invalid' ) ) {
 				$subfield_name = $field['subfield_name'];
-				if ( ! isset( $field['shortcodes'][ 'aria-invalid-' . $subfield_name ] ) ) {
+				if ( ! isset( $field['shortcodes']['aria-invalid-' . $subfield_name] ) ) {
 					continue;
 				}
 				// Change the key to the correct aria-invalid value so that $add_html is set correctly for the current subfield of a combo field.
 				$k = 'aria-invalid';
-				$v = $field['shortcodes'][ 'aria-invalid-' . $subfield_name ];
-				unset( $field['shortcodes'][ 'aria-invalid-' . $subfield_name ] );
+				$v = $field['shortcodes']['aria-invalid-' . $subfield_name];
+				unset( $field['shortcodes']['aria-invalid-' . $subfield_name] );
 			}
 			if ( 'opt' === $k || ! self::should_allow_input_attribute( $k ) ) {
 				continue;
@@ -932,10 +932,10 @@ 
 
 			if ( is_numeric( $k ) && strpos( $v, '=' ) ) {
 				$add_html[] = $v;
-			} elseif ( ! empty( $k ) && isset( $add_html[ $k ] ) ) {
-				$add_html[ $k ] = str_replace( $k . '="', $k . '="' . $v, $add_html[ $k ] );
+			} elseif ( ! empty( $k ) && isset( $add_html[$k] ) ) {
+				$add_html[$k] = str_replace( $k . '="', $k . '="' . $v, $add_html[$k] );
 			} else {
-				$add_html[ $k ] = $k . '="' . esc_attr( $v ) . '"';
+				$add_html[$k] = $k . '="' . esc_attr( $v ) . '"';
 			}
 
 			unset( $k, $v );

classes/views/frm-fields/back-end/settings.php

Spacing +2 added lines, -2 removed lines

@@ -189,7 +189,7 @@ 
 						if ( ! is_callable( array( 'FrmProHtmlHelper', 'echo_radio_group' ) ) ) {
 							switch ( $type ) {
 								case 'calc':
-									$default_value_type['data']  = array(
+									$default_value_type['data'] = array(
 										'show'    => '#calc-for-{id}',
 										'disable' => '#default-value-for-{id}',
 									);
@@ -216,7 +216,7 @@ 
 						);
 
 						foreach ( $default_value_type['data'] as $data_key => $data_value ) {
-							$toggle_args['input_html'][ 'data-' . $data_key ] = $data_value . ( substr( $data_value, -1 ) === '-' ? $field['id'] : '' );
+							$toggle_args['input_html']['data-' . $data_key] = $data_value . ( substr( $data_value, -1 ) === '-' ? $field['id'] : '' );
 						}
 
 						?>