Completed
Pull Request — master (#2285)
by
unknown
39s
created
classes/helpers/FrmTipsHelper.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 			'page'  => '',
46 46
 			'class' => 'frm-mt-0',
47 47
 		);
48
-		$tip      = array_merge( $defaults, $tip );
48
+		$tip = array_merge( $defaults, $tip );
49 49
 
50 50
 		if ( isset( $tip['link'] ) && ! isset( $tip['link']['medium'] ) ) {
51 51
 			$tip['link']['medium'] = 'tip';
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
 	 * @return array
373 373
 	 */
374 374
 	public static function get_banner_tip() {
375
-		$tips       = array(
375
+		$tips = array(
376 376
 			array(
377 377
 				'link' => array(
378 378
 					'medium'  => 'banner',
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
 			),
400 400
 		);
401 401
 		$random     = rand( 0, count( $tips ) - 1 );
402
-		$tip        = $tips[ $random ];
402
+		$tip        = $tips[$random];
403 403
 		$tip['num'] = $random;
404 404
 
405 405
 		return $tip;
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
408 408
 	public static function get_random_tip( $tips ) {
409 409
 		$random = rand( 0, count( $tips ) - 1 );
410 410
 
411
-		return $tips[ $random ];
411
+		return $tips[$random];
412 412
 	}
413 413
 
414 414
 	/**
Please login to merge, or discard this patch.
stripe/models/FrmTransLitePayment.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -126,11 +126,11 @@
 block discarded – undo
126 126
 		foreach ( $payments as $payment ) {
127 127
 			list( $amount, $currency ) = FrmTransLiteAppHelper::get_amount_and_currency_from_payment( $payment );
128 128
 
129
-			if ( ! isset( $data[ $currency ] ) ) {
130
-				$data[ $currency ] = 0;
129
+			if ( ! isset( $data[$currency] ) ) {
130
+				$data[$currency] = 0;
131 131
 			}
132 132
 
133
-			$data[ $currency ] += floatval( $amount );
133
+			$data[$currency] += floatval( $amount );
134 134
 		}
135 135
 
136 136
 		return $data;
Please login to merge, or discard this patch.
classes/helpers/FrmEmailSummaryHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -236,11 +236,11 @@  discard block
 block discarded – undo
236 236
 	 */
237 237
 	public static function get_last_sent_date( $type ) {
238 238
 		$options = self::get_options();
239
-		if ( empty( $options[ 'last_' . $type ] ) ) {
239
+		if ( empty( $options['last_' . $type] ) ) {
240 240
 			return false;
241 241
 		}
242 242
 
243
-		return $options[ 'last_' . $type ];
243
+		return $options['last_' . $type];
244 244
 	}
245 245
 
246 246
 	/**
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
 	public static function set_last_sent_date( $type, $value = null ) {
253 253
 		$options = self::get_options();
254 254
 
255
-		$options[ 'last_' . $type ] = null === $value ? self::get_date_from_today() : '';
255
+		$options['last_' . $type] = null === $value ? self::get_date_from_today() : '';
256 256
 		self::save_options( $options );
257 257
 	}
258 258
 
Please login to merge, or discard this patch.
stripe/helpers/FrmStrpLiteConnectHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 			'user_id'               => get_current_user_id(),
109 109
 			'frm_strp_connect_mode' => $mode,
110 110
 		);
111
-		$data            = self::post_to_connect_server( 'initialize', $additional_body );
111
+		$data = self::post_to_connect_server( 'initialize', $additional_body );
112 112
 
113 113
 		if ( is_string( $data ) ) {
114 114
 			return $data;
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	 * @return object|string
144 144
 	 */
145 145
 	private static function post_to_connect_server( $action, $additional_body = array() ) {
146
-		$body    = array(
146
+		$body = array(
147 147
 			'frm_strp_connect_action' => $action,
148 148
 			'frm_strp_connect_mode'   => FrmStrpLiteAppHelper::active_mode(),
149 149
 		);
Please login to merge, or discard this patch.
classes/views/frm-fields/front-end/checkbox-field.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,6 +87,6 @@
 block discarded – undo
87 87
 
88 88
 		?></div>
89 89
 <?php
90
-		++$option_index;
90
+		++ $option_index;
91 91
 	}//end foreach
92 92
 }//end if
Please login to merge, or discard this patch.
classes/views/frm-fields/front-end/combo-field/combo-field.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 			$sub_field_class   = "frm_form_field form-field frm_form_subfield-{$name} {$sub_field['wrapper_classes']}";
42 42
 			$sub_field_desc    = FrmField::get_option( $field, $name . '_desc' );
43 43
 
44
-			if ( isset( $errors[ 'field' . $field_id . '-' . $name ] ) ) {
44
+			if ( isset( $errors['field' . $field_id . '-' . $name] ) ) {
45 45
 				$sub_field_class .= ' frm_blank_field';
46 46
 			}
47 47
 			?>
@@ -61,10 +61,10 @@  discard block
 block discarded – undo
61 61
 						<input
62 62
 							type="<?php echo esc_attr( $sub_field['type'] ); ?>"
63 63
 							id="<?php echo esc_attr( $html_id . '_' . $name ); ?>"
64
-							value="<?php echo esc_attr( isset( $field_value[ $name ] ) ? $field_value[ $name ] : '' ); ?>"
64
+							value="<?php echo esc_attr( isset( $field_value[$name] ) ? $field_value[$name] : '' ); ?>"
65 65
 							<?php
66
-							if ( ! empty( $field_value[ $name ] ) ) {
67
-								echo 'data-frmval="' . esc_attr( $field_value[ $name ] ) . '" ';
66
+							if ( ! empty( $field_value[$name] ) ) {
67
+								echo 'data-frmval="' . esc_attr( $field_value[$name] ) . '" ';
68 68
 							}
69 69
 							if ( empty( $args['remove_names'] ) ) {
70 70
 								echo 'name="' . esc_attr( $field_name ) . '[' . esc_attr( $name ) . ']" ';
@@ -81,9 +81,9 @@  discard block
 block discarded – undo
81 81
 				}
82 82
 
83 83
 				// Don't show individual field errors when there is a combo field error.
84
-				if ( ! empty( $errors ) && isset( $errors[ 'field' . $field_id . '-' . $name ] ) && ! isset( $errors[ 'field' . $field_id ] ) ) {
84
+				if ( ! empty( $errors ) && isset( $errors['field' . $field_id . '-' . $name] ) && ! isset( $errors['field' . $field_id] ) ) {
85 85
 					?>
86
-					<div class="frm_error" role="alert"><?php echo esc_html( $errors[ 'field' . $field_id . '-' . $name ] ); ?></div>
86
+					<div class="frm_error" role="alert"><?php echo esc_html( $errors['field' . $field_id . '-' . $name] ); ?></div>
87 87
 				<?php } ?>
88 88
 			</div>
89 89
 			<?php
Please login to merge, or discard this patch.
classes/controllers/FrmSettingsController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 				$section['function'] = $original;
159 159
 			}
160 160
 
161
-			$sections[ $key ] = $section;
161
+			$sections[$key] = $section;
162 162
 		}//end foreach
163 163
 
164 164
 		return $sections;
@@ -170,11 +170,11 @@  discard block
 block discarded – undo
170 170
 
171 171
 		$section  = FrmAppHelper::get_post_param( 'tab', '', 'sanitize_text_field' );
172 172
 		$sections = self::get_settings_tabs();
173
-		if ( ! isset( $sections[ $section ] ) ) {
173
+		if ( ! isset( $sections[$section] ) ) {
174 174
 			wp_die();
175 175
 		}
176 176
 
177
-		$section = $sections[ $section ];
177
+		$section = $sections[$section];
178 178
 
179 179
 		if ( isset( $section['class'] ) ) {
180 180
 			call_user_func( array( $section['class'], $section['function'] ) );
Please login to merge, or discard this patch.
classes/controllers/FrmFormsController.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1616,7 +1616,8 @@  discard block
 block discarded – undo
1616 1616
 		$vars   = array();
1617 1617
 		FrmAppHelper::include_svg();
1618 1618
 
1619
-		if ( isset( $_POST['frm_compact_fields'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1619
+		if ( isset( $_POST['frm_compact_fields'] ) ) {
1620
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1620 1621
 			FrmAppHelper::permission_check( 'frm_edit_forms' );
1621 1622
 
1622 1623
 			// Javascript needs to be allowed in some field settings.
@@ -2046,7 +2047,8 @@  discard block
 block discarded – undo
2046 2047
 	private static function get_saved_errors( $form, $params ) {
2047 2048
 		global $frm_vars;
2048 2049
 
2049
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2050
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
2051
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
2050 2052
 			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2051 2053
 		} else {
2052 2054
 			$errors = array();
Please login to merge, or discard this patch.
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
 			 * @param string|null $src
648 648
 			 * @return string
649 649
 			 */
650
-			function ( $src ) {
650
+			function( $src ) {
651 651
 				if ( is_null( $src ) ) {
652 652
 					$src = '';
653 653
 				}
@@ -712,11 +712,11 @@  discard block
 block discarded – undo
712 712
 			),
713 713
 		);
714 714
 
715
-		if ( ! isset( $available_status[ $status ] ) ) {
715
+		if ( ! isset( $available_status[$status] ) ) {
716 716
 			return;
717 717
 		}
718 718
 
719
-		FrmAppHelper::permission_check( $available_status[ $status ]['permission'] );
719
+		FrmAppHelper::permission_check( $available_status[$status]['permission'] );
720 720
 
721 721
 		$params = FrmForm::list_page_params();
722 722
 
@@ -724,8 +724,8 @@  discard block
 block discarded – undo
724 724
 		check_admin_referer( $status . '_form_' . $params['id'] );
725 725
 
726 726
 		$count = 0;
727
-		if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
728
-			++$count;
727
+		if ( FrmForm::set_status( $params['id'], $available_status[$status]['new_status'] ) ) {
728
+			++ $count;
729 729
 		}
730 730
 
731 731
 		$form_type = FrmAppHelper::get_simple_request(
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
 		/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
742 742
 		$available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
743 743
 
744
-		$message = $available_status[ $status ]['message'];
744
+		$message = $available_status[$status]['message'];
745 745
 
746 746
 		self::display_forms_list( $params, $message );
747 747
 	}
@@ -756,7 +756,7 @@  discard block
 block discarded – undo
756 756
 		$count = 0;
757 757
 		foreach ( $ids as $id ) {
758 758
 			if ( FrmForm::trash( $id ) ) {
759
-				++$count;
759
+				++ $count;
760 760
 			}
761 761
 		}
762 762
 
@@ -766,7 +766,7 @@  discard block
 block discarded – undo
766 766
 				'type'  => 'request',
767 767
 			)
768 768
 		);
769
-		$message      = sprintf(
769
+		$message = sprintf(
770 770
 			/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
771 771
 			_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
772 772
 			$count,
@@ -787,7 +787,7 @@  discard block
 block discarded – undo
787 787
 
788 788
 		$count = 0;
789 789
 		if ( FrmForm::destroy( $params['id'] ) ) {
790
-			++$count;
790
+			++ $count;
791 791
 		}
792 792
 
793 793
 		/* translators: %1$s: Number of forms */
@@ -807,7 +807,7 @@  discard block
 block discarded – undo
807 807
 		foreach ( $ids as $id ) {
808 808
 			$d = FrmForm::destroy( $id );
809 809
 			if ( $d ) {
810
-				++$count;
810
+				++ $count;
811 811
 			}
812 812
 		}
813 813
 
@@ -1301,7 +1301,7 @@  discard block
 block discarded – undo
1301 1301
 
1302 1302
 		add_action(
1303 1303
 			'wp_enqueue_editor',
1304
-			function () {
1304
+			function() {
1305 1305
 				wp_print_media_templates();
1306 1306
 			}
1307 1307
 		);
@@ -1406,7 +1406,7 @@  discard block
 block discarded – undo
1406 1406
 
1407 1407
 		foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
1408 1408
 			if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
1409
-				unset( $sections[ $feature ] );
1409
+				unset( $sections[$feature] );
1410 1410
 			}
1411 1411
 		}
1412 1412
 
@@ -1434,7 +1434,7 @@  discard block
 block discarded – undo
1434 1434
 				$section['id'] = $section['anchor'];
1435 1435
 			}
1436 1436
 
1437
-			$sections[ $key ] = $section;
1437
+			$sections[$key] = $section;
1438 1438
 		}//end foreach
1439 1439
 
1440 1440
 		return $sections;
@@ -1557,7 +1557,7 @@  discard block
 block discarded – undo
1557 1557
 		if ( $user_fields ) {
1558 1558
 			$user_helpers = array();
1559 1559
 			foreach ( $user_fields as $uk => $uf ) {
1560
-				$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
1560
+				$user_helpers['|user_id| show="' . $uk . '"'] = $uf;
1561 1561
 				unset( $uk, $uf );
1562 1562
 			}
1563 1563
 
@@ -1696,7 +1696,7 @@  discard block
 block discarded – undo
1696 1696
 		if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
1697 1697
 			$frm_vars['js_validate_forms'] = array();
1698 1698
 		}
1699
-		$frm_vars['js_validate_forms'][ $form->id ] = $form;
1699
+		$frm_vars['js_validate_forms'][$form->id] = $form;
1700 1700
 	}
1701 1701
 
1702 1702
 	public static function get_email_html() {
@@ -1867,7 +1867,7 @@  discard block
 block discarded – undo
1867 1867
 				add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
1868 1868
 			} else {
1869 1869
 				$vars   = FrmAppHelper::json_to_array( $json_vars );
1870
-				$action = $vars[ $action ];
1870
+				$action = $vars[$action];
1871 1871
 				unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1872 1872
 				$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1873 1873
 				$_POST    = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -2040,7 +2040,7 @@  discard block
 block discarded – undo
2040 2040
 		$actions = array();
2041 2041
 		foreach ( $frm_vars['forms_loaded'] as $form ) {
2042 2042
 			if ( is_object( $form ) ) {
2043
-				$actions[ $form->id ] = $form->name;
2043
+				$actions[$form->id] = $form->name;
2044 2044
 			}
2045 2045
 			unset( $form );
2046 2046
 		}
@@ -2285,8 +2285,8 @@  discard block
 block discarded – undo
2285 2285
 	private static function get_saved_errors( $form, $params ) {
2286 2286
 		global $frm_vars;
2287 2287
 
2288
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2289
-			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2288
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2289
+			$errors = $frm_vars['created_entries'][$form->id]['errors'];
2290 2290
 		} else {
2291 2291
 			$errors = array();
2292 2292
 		}
@@ -2308,7 +2308,7 @@  discard block
 block discarded – undo
2308 2308
 	public static function just_created_entry( $form_id ) {
2309 2309
 		global $frm_vars;
2310 2310
 
2311
-		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
2311
+		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][$form_id] ) && isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ? $frm_vars['created_entries'][$form_id]['entry_id'] : 0;
2312 2312
 	}
2313 2313
 
2314 2314
 	/**
@@ -2328,7 +2328,7 @@  discard block
 block discarded – undo
2328 2328
 	private static function get_confirmation_method( $atts ) {
2329 2329
 		$action = FrmOnSubmitHelper::current_event( $atts );
2330 2330
 		$opt    = 'update' === $action ? 'edit_action' : 'success_action';
2331
-		$method = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
2331
+		$method = ! empty( $atts['form']->options[$opt] ) ? $atts['form']->options[$opt] : 'message';
2332 2332
 
2333 2333
 		if ( ! empty( $atts['entry_id'] ) ) {
2334 2334
 			$met_actions = self::get_met_on_submit_actions( $atts, $action );
@@ -2349,7 +2349,7 @@  discard block
 block discarded – undo
2349 2349
 	public static function maybe_trigger_redirect( $form, $params, $args ) {
2350 2350
 		if ( ! isset( $params['id'] ) ) {
2351 2351
 			global $frm_vars;
2352
-			$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
2352
+			$params['id'] = $frm_vars['created_entries'][$form->id]['entry_id'];
2353 2353
 		}
2354 2354
 
2355 2355
 		$conf_method = self::get_confirmation_method(
@@ -2431,7 +2431,7 @@  discard block
 block discarded – undo
2431 2431
 		$args['success_opt'] = $opt;
2432 2432
 		$args['ajax']        = ! empty( $frm_vars['ajax'] );
2433 2433
 
2434
-		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[ $opt . '_page_id' ] ) ) {
2434
+		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[$opt . '_page_id'] ) ) {
2435 2435
 			self::load_page_after_submit( $args );
2436 2436
 		} elseif ( $args['conf_method'] === 'redirect' ) {
2437 2437
 			self::redirect_after_submit( $args );
@@ -2455,7 +2455,7 @@  discard block
 block discarded – undo
2455 2455
 		}
2456 2456
 
2457 2457
 		// If a redirect action has already opened the URL in a new tab, we show the default message in the current tab.
2458
-		if ( ! empty( self::$redirected_in_new_tab[ $args['form']->id ] ) ) {
2458
+		if ( ! empty( self::$redirected_in_new_tab[$args['form']->id] ) ) {
2459 2459
 			return array( FrmOnSubmitHelper::get_fallback_action_after_open_in_new_tab( $event ) );
2460 2460
 		}
2461 2461
 
@@ -2643,7 +2643,7 @@  discard block
 block discarded – undo
2643 2643
 
2644 2644
 		$opt = 'update' === $args['action'] ? 'edit_' : 'success_';
2645 2645
 
2646
-		$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
2646
+		$new_args['conf_method'] = $new_args['form']->options[$opt . 'action'];
2647 2647
 
2648 2648
 		/**
2649 2649
 		 * Filters the run success action args.
@@ -2663,8 +2663,8 @@  discard block
 block discarded – undo
2663 2663
 	private static function load_page_after_submit( $args ) {
2664 2664
 		global $post;
2665 2665
 		$opt = $args['success_opt'];
2666
-		if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
2667
-			$page     = get_post( $args['form']->options[ $opt . '_page_id' ] );
2666
+		if ( ! $post || $args['form']->options[$opt . '_page_id'] != $post->ID ) {
2667
+			$page     = get_post( $args['form']->options[$opt . '_page_id'] );
2668 2668
 			$old_post = $post;
2669 2669
 			$post     = $page;
2670 2670
 			$content  = apply_filters( 'frm_content', $page->post_content, $args['form'], $args['entry_id'] );
@@ -2694,7 +2694,7 @@  discard block
 block discarded – undo
2694 2694
 		add_filter( 'frm_use_wpautop', '__return_false' );
2695 2695
 
2696 2696
 		$opt         = $args['success_opt'];
2697
-		$success_url = trim( $args['form']->options[ $opt . '_url' ] );
2697
+		$success_url = trim( $args['form']->options[$opt . '_url'] );
2698 2698
 		$success_url = apply_filters( 'frm_content', $success_url, $args['form'], $args['entry_id'] );
2699 2699
 		$success_url = do_shortcode( $success_url );
2700 2700
 
@@ -2716,7 +2716,7 @@  discard block
 block discarded – undo
2716 2716
 			// Not AJAX submit, no headers sent, and there is just one Redirect action runs.
2717 2717
 			if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
2718 2718
 				self::print_open_in_new_tab_js_with_fallback_handler( $success_url, $args );
2719
-				self::$redirected_in_new_tab[ $args['form']->id ] = 1;
2719
+				self::$redirected_in_new_tab[$args['form']->id] = 1;
2720 2720
 				return;
2721 2721
 			}
2722 2722
 
@@ -2976,7 +2976,7 @@  discard block
 block discarded – undo
2976 2976
 			'description' => false,
2977 2977
 			'reset'       => false,
2978 2978
 		);
2979
-		$args     = wp_parse_args( $args, $defaults );
2979
+		$args = wp_parse_args( $args, $defaults );
2980 2980
 	}
2981 2981
 
2982 2982
 	/**
@@ -3014,7 +3014,7 @@  discard block
 block discarded – undo
3014 3014
 		$opt          = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
3015 3015
 
3016 3016
 		if ( $entry_id && is_numeric( $entry_id ) ) {
3017
-			$message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
3017
+			$message = isset( $form->options[$opt . '_msg'] ) ? $form->options[$opt . '_msg'] : $frm_settings->success_msg;
3018 3018
 			$class   = 'frm_message';
3019 3019
 		} else {
3020 3020
 			$message = $frm_settings->failed_msg;
@@ -3237,8 +3237,8 @@  discard block
 block discarded – undo
3237 3237
 
3238 3238
 		check_ajax_referer( 'frm_ajax', 'nonce' );
3239 3239
 
3240
-		$html             = FrmAppHelper::clip(
3241
-			function () {
3240
+		$html = FrmAppHelper::clip(
3241
+			function() {
3242 3242
 				FrmAppHelper::maybe_autocomplete_pages_options(
3243 3243
 					array(
3244 3244
 						'field_name'  => 'frm_page_dropdown',
Please login to merge, or discard this patch.
classes/models/FrmEntryValidate.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,8 @@
 block discarded – undo
145 145
 
146 146
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
147 147
 			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
148
-		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
148
+		} elseif ( ! isset( $_POST['item_name'] ) ) {
149
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
149 150
 			self::maybe_add_item_name( $value, $posted_field );
150 151
 		}
151 152
 
Please login to merge, or discard this patch.
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 			return $errors;
28 28
 		}
29 29
 
30
-		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) {
30
+		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values['frm_submit_entry_' . $values['form_id']] ) || ! wp_verify_nonce( $values['frm_submit_entry_' . $values['form_id']], 'frm_submit_entry_nonce' ) ) ) {
31 31
 			$frm_settings   = FrmAppHelper::get_settings();
32 32
 			$errors['form'] = $frm_settings->admin_permission;
33 33
 		}
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
 		$args = wp_parse_args( $args, $defaults );
131 131
 
132 132
 		if ( empty( $args['parent_field_id'] ) ) {
133
-			$value = isset( $values['item_meta'][ $args['id'] ] ) ? $values['item_meta'][ $args['id'] ] : '';
133
+			$value = isset( $values['item_meta'][$args['id']] ) ? $values['item_meta'][$args['id']] : '';
134 134
 		} else {
135 135
 			// value is from a nested form
136 136
 			$value = $values;
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 		}
152 152
 
153 153
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
154
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
154
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
155 155
 		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
156 156
 			self::maybe_add_item_name( $value, $posted_field );
157 157
 		}
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 			$pattern = self::phone_format( $field );
234 234
 
235 235
 			if ( ! preg_match( $pattern, $value ) ) {
236
-				$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
236
+				$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
237 237
 			}
238 238
 		}
239 239
 	}
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
 	 */
347 347
 	private static function form_is_in_progress( $values ) {
348 348
 		return FrmAppHelper::pro_is_installed() &&
349
-			( isset( $values[ 'frm_page_order_' . $values['form_id'] ] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
349
+			( isset( $values['frm_page_order_' . $values['form_id']] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
350 350
 			FrmField::get_all_types_in_form( $values['form_id'], 'break' );
351 351
 	}
352 352
 
@@ -592,9 +592,9 @@  discard block
 block discarded – undo
592 592
 			foreach ( $datas['missing_keys'] as $key_index => $key ) {
593 593
 				$found = self::is_akismet_guest_info_value( $key, $value, $field_id, $datas['name_field_ids'], $values );
594 594
 				if ( $found ) {
595
-					$datas[ $key ]             = $value;
595
+					$datas[$key]             = $value;
596 596
 					$datas['frm_duplicated'][] = $field_id;
597
-					unset( $datas['missing_keys'][ $key_index ] );
597
+					unset( $datas['missing_keys'][$key_index] );
598 598
 				}
599 599
 			}
600 600
 		}//end foreach
@@ -637,11 +637,11 @@  discard block
 block discarded – undo
637 637
 					if ( 'Name' !== $field->name ) {
638 638
 						continue;
639 639
 					}
640
-					if ( isset( $fields[ $index + 1 ] ) && 'Last' === $fields[ $index + 1 ]->name ) {
641
-						if ( empty( $values[ absint( $fields[ $index + 1 ]->id ) ] ) ) {
640
+					if ( isset( $fields[$index + 1] ) && 'Last' === $fields[$index + 1]->name ) {
641
+						if ( empty( $values[absint( $fields[$index + 1]->id )] ) ) {
642 642
 							continue;
643 643
 						}
644
-						$value .= ' ' . $values[ $fields[ $index + 1 ]->id ];
644
+						$value .= ' ' . $values[$fields[$index + 1]->id];
645 645
 						return true;
646 646
 					}
647 647
 				}
@@ -660,13 +660,13 @@  discard block
 block discarded – undo
660 660
 	 */
661 661
 	private static function get_name_text_fields( $form_id ) {
662 662
 		$name_text_fields_is_initialized = is_array( self::$name_text_fields );
663
-		if ( $name_text_fields_is_initialized && isset( self::$name_text_fields[ $form_id ] ) ) {
664
-			return self::$name_text_fields[ $form_id ];
663
+		if ( $name_text_fields_is_initialized && isset( self::$name_text_fields[$form_id] ) ) {
664
+			return self::$name_text_fields[$form_id];
665 665
 		}
666 666
 		if ( ! $name_text_fields_is_initialized ) {
667 667
 			self::$name_text_fields = array();
668 668
 		}
669
-		self::$name_text_fields[ $form_id ] = FrmDb::get_results(
669
+		self::$name_text_fields[$form_id] = FrmDb::get_results(
670 670
 			'frm_fields',
671 671
 			array(
672 672
 				'form_id' => $form_id,
@@ -677,7 +677,7 @@  discard block
 block discarded – undo
677 677
 			array( 'order_by' => 'field_order ASC' )
678 678
 		);
679 679
 
680
-		return self::$name_text_fields[ $form_id ];
680
+		return self::$name_text_fields[$form_id];
681 681
 	}
682 682
 
683 683
 	private static function add_server_values_to_akismet( &$datas ) {
@@ -686,7 +686,7 @@  discard block
 block discarded – undo
686 686
 
687 687
 			// Send any potentially useful $_SERVER vars, but avoid sending junk we don't need.
688 688
 			if ( $include_value ) {
689
-				$datas[ $key ] = $value;
689
+				$datas[$key] = $value;
690 690
 			}
691 691
 			unset( $key, $value );
692 692
 		}
@@ -703,10 +703,10 @@  discard block
 block discarded – undo
703 703
 	private static function add_comment_content_to_akismet( &$datas, $values ) {
704 704
 		if ( isset( $datas['frm_duplicated'] ) ) {
705 705
 			foreach ( $datas['frm_duplicated'] as $index ) {
706
-				if ( isset( $values['item_meta'][ $index ] ) ) {
707
-					unset( $values['item_meta'][ $index ] );
706
+				if ( isset( $values['item_meta'][$index] ) ) {
707
+					unset( $values['item_meta'][$index] );
708 708
 				} else {
709
-					unset( $values[ $index ] );
709
+					unset( $values[$index] );
710 710
 				}
711 711
 			}
712 712
 			unset( $datas['frm_duplicated'] );
@@ -725,14 +725,14 @@  discard block
 block discarded – undo
725 725
 	private static function skip_adding_values_to_akismet( &$values ) {
726 726
 		$skipped_fields = self::get_akismet_skipped_field_ids( $values );
727 727
 		foreach ( $skipped_fields as $skipped_field ) {
728
-			if ( ! isset( $values['item_meta'][ $skipped_field->id ] ) ) {
728
+			if ( ! isset( $values['item_meta'][$skipped_field->id] ) ) {
729 729
 				continue;
730 730
 			}
731 731
 
732 732
 			if ( self::should_really_skip_field( $skipped_field, $values ) ) {
733
-				unset( $values['item_meta'][ $skipped_field->id ] );
734
-				if ( isset( $values['item_meta']['other'][ $skipped_field->id ] ) ) {
735
-					unset( $values['item_meta']['other'][ $skipped_field->id ] );
733
+				unset( $values['item_meta'][$skipped_field->id] );
734
+				if ( isset( $values['item_meta']['other'][$skipped_field->id] ) ) {
735
+					unset( $values['item_meta']['other'][$skipped_field->id] );
736 736
 				}
737 737
 			}
738 738
 		}
@@ -768,14 +768,14 @@  discard block
 block discarded – undo
768 768
 		}
769 769
 
770 770
 		// If a choice field has Other option, but Other is not selected.
771
-		if ( empty( $values['item_meta']['other'][ $field_data->id ] ) ) {
771
+		if ( empty( $values['item_meta']['other'][$field_data->id] ) ) {
772 772
 			return true;
773 773
 		}
774 774
 
775 775
 		// Check if submitted value is same as one of field option.
776 776
 		foreach ( $field_data->options as $option ) {
777 777
 			$option_value = ! is_array( $option ) ? $option : ( isset( $option['value'] ) ? $option['value'] : '' );
778
-			if ( $values['item_meta']['other'][ $field_data->id ] === $option_value ) {
778
+			if ( $values['item_meta']['other'][$field_data->id] === $option_value ) {
779 779
 				return true;
780 780
 			}
781 781
 		}
@@ -846,7 +846,7 @@  discard block
 block discarded – undo
846 846
 
847 847
 			// Convert name array to string.
848 848
 			if ( isset( $value['first'] ) && isset( $value['last'] ) ) {
849
-				$values['item_meta'][ $field_id ] = trim( implode( ' ', $value ) );
849
+				$values['item_meta'][$field_id] = trim( implode( ' ', $value ) );
850 850
 				$values['name_field_ids'][]       = $field_id;
851 851
 				continue;
852 852
 			}
@@ -867,8 +867,8 @@  discard block
 block discarded – undo
867 867
 						continue;
868 868
 					}
869 869
 
870
-					if ( ! isset( $values['item_meta'][ $subsubindex ] ) ) {
871
-						$values['item_meta'][ $subsubindex ] = array();
870
+					if ( ! isset( $values['item_meta'][$subsubindex] ) ) {
871
+						$values['item_meta'][$subsubindex] = array();
872 872
 					}
873 873
 
874 874
 					// Convert name array to string.
@@ -878,11 +878,11 @@  discard block
 block discarded – undo
878 878
 						$values['name_field_ids'][] = $subsubindex;
879 879
 					}
880 880
 
881
-					$values['item_meta'][ $subsubindex ][] = $subsubvalue;
881
+					$values['item_meta'][$subsubindex][] = $subsubvalue;
882 882
 				}
883 883
 			}//end foreach
884 884
 
885
-			unset( $values['item_meta'][ $field_id ] );
885
+			unset( $values['item_meta'][$field_id] );
886 886
 		}//end foreach
887 887
 
888 888
 		return $form_ids;
Please login to merge, or discard this patch.