Completed
Pull Request — master (#602)
by Stephanie
48s
created
classes/helpers/FrmEntriesHelper.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -117,10 +117,10 @@  discard block
 block discarded – undo
117 117
 		if ( $_POST ) {
118 118
 			$repeating = isset( $args['repeating'] ) && $args['repeating'];
119 119
 			if ( $repeating ) {
120
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) {
120
+				if ( isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] ) ) {
121 121
 					$value_is_posted = true;
122 122
 				}
123
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) {
123
+			} elseif ( isset( $_POST['item_meta'][$field->id] ) ) {
124 124
 				$value_is_posted = true;
125 125
 			}
126 126
 		}
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 		preg_match_all( "/\[(default-message|default_message)\b(.*?)(?:(\/))?\]/s", $message, $shortcodes, PREG_PATTERN_ORDER );
151 151
 
152 152
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
153
-			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
153
+			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
154 154
 			if ( ! empty( $add_atts ) ) {
155 155
 				$this_atts = array_merge( $atts, $add_atts );
156 156
 			} else {
@@ -160,14 +160,14 @@  discard block
 block discarded – undo
160 160
 			$default = FrmEntriesController::show_entry_shortcode( $this_atts );
161 161
 
162 162
 			// Add the default message.
163
-			$message = str_replace( $shortcodes[0][ $short_key ], $default, $message );
163
+			$message = str_replace( $shortcodes[0][$short_key], $default, $message );
164 164
 		}
165 165
 
166 166
 		return $message;
167 167
 	}
168 168
 
169 169
 	public static function prepare_display_value( $entry, $field, $atts ) {
170
-		$field_value = isset( $entry->metas[ $field->id ] ) ? $entry->metas[ $field->id ] : false;
170
+		$field_value = isset( $entry->metas[$field->id] ) ? $entry->metas[$field->id] : false;
171 171
 
172 172
 		if ( FrmAppHelper::pro_is_installed() ) {
173 173
 			$empty = empty( $field_value );
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 			$child_entries = FrmEntry::getAll( array( 'it.parent_item_id' => $entry->id ) );
191 191
 		} else {
192 192
 			// Get all values for this field.
193
-			$child_values = isset( $entry->metas[ $atts['embedded_field_id'] ] ) ? $entry->metas[ $atts['embedded_field_id'] ] : false;
193
+			$child_values = isset( $entry->metas[$atts['embedded_field_id']] ) ? $entry->metas[$atts['embedded_field_id']] : false;
194 194
 
195 195
 			if ( $child_values ) {
196 196
 				$child_entries = FrmEntry::getAll( array( 'it.id' => (array) $child_values ) );
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
 			$value = $args['temp_value'];
309 309
 		}
310 310
 		if ( empty( $args['parent_field_id'] ) ) {
311
-			$_POST['item_meta'][ $field->id ] = $value;
311
+			$_POST['item_meta'][$field->id] = $value;
312 312
 		} else {
313 313
 			self::set_parent_field_posted_value( $field, $value, $args );
314 314
 		}
@@ -320,20 +320,20 @@  discard block
 block discarded – undo
320 320
 	 * @since 4.01
321 321
 	 */
322 322
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
323
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) &&
324
-			 is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) {
323
+		if ( isset( $_POST['item_meta'][$args['parent_field_id']] ) &&
324
+			 is_array( $_POST['item_meta'][$args['parent_field_id']] ) ) {
325 325
 
326
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ||
327
-				 ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) {
328
-				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array();
326
+			if ( ! isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) ||
327
+				 ! is_array( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) ) {
328
+				$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array();
329 329
 			}
330 330
 		} else {
331 331
 			// All of the section was probably removed.
332
-			$_POST['item_meta'][ $args['parent_field_id'] ] = array();
333
-			$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array();
332
+			$_POST['item_meta'][$args['parent_field_id']] = array();
333
+			$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array();
334 334
 		}
335 335
 
336
-		$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] = $value;
336
+		$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] = $value;
337 337
 	}
338 338
 
339 339
 	public static function get_posted_value( $field, &$value, $args ) {
@@ -364,10 +364,10 @@  discard block
 block discarded – undo
364 364
 		if ( empty( $args['parent_field_id'] ) ) {
365 365
 			// Sanitizing is done next.
366 366
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
367
-			$value = isset( $_POST['item_meta'][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $field_id ] ) : '';
367
+			$value = isset( $_POST['item_meta'][$field_id] ) ? wp_unslash( $_POST['item_meta'][$field_id] ) : '';
368 368
 		} else {
369 369
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
370
-			$value = isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) : '';
370
+			$value = isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) ? wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) : '';
371 371
 		}
372 372
 		return $value;
373 373
 	}
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
 		self::set_other_repeating_vals( $field, $value, $args );
399 399
 
400 400
 		// Check if there are any posted "Other" values.
401
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) {
401
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][$field->id] ) ) {
402 402
 
403 403
 			// Save original value.
404 404
 			$args['temp_value'] = $value;
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 
407 407
 			// Sanitizing is done next.
408 408
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
409
-			$other_vals = wp_unslash( $_POST['item_meta']['other'][ $field->id ] );
409
+			$other_vals = wp_unslash( $_POST['item_meta']['other'][$field->id] );
410 410
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
411 411
 
412 412
 			// Set the validation value now
@@ -429,13 +429,13 @@  discard block
 block discarded – undo
429 429
 		}
430 430
 
431 431
 		// Check if there are any other posted "other" values for this field.
432
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) {
432
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ) ) {
433 433
 			// Save original value
434 434
 			$args['temp_value'] = $value;
435 435
 			$args['other']      = true;
436 436
 
437 437
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
438
-			$other_vals = wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] );
438
+			$other_vals = wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] );
439 439
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
440 440
 
441 441
 			// Set the validation value now.
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
 		if ( is_array( $value ) && $field->type === 'checkbox' ) {
463 463
 			// Combine "Other" values with checked values. "Other" values will override checked box values.
464 464
 			foreach ( $other_vals as $k => $v ) {
465
-				if ( isset( $value[ $k ] ) && trim( $v ) === '' ) {
465
+				if ( isset( $value[$k] ) && trim( $v ) === '' ) {
466 466
 					// If the other box is checked, but doesn't have a value.
467 467
 					$value = '';
468 468
 					break;
@@ -479,25 +479,25 @@  discard block
 block discarded – undo
479 479
 
480 480
 			// Multi-select dropdown.
481 481
 			if ( is_array( $value ) ) {
482
-				$o_key = array_search( $field->options[ $other_key ], $value );
482
+				$o_key = array_search( $field->options[$other_key], $value );
483 483
 
484 484
 				if ( $o_key !== false ) {
485 485
 					// Modify the original value so other key will be preserved.
486
-					$value[ $other_key ] = $value[ $o_key ];
486
+					$value[$other_key] = $value[$o_key];
487 487
 
488 488
 					// By default, the array keys will be numeric for multi-select dropdowns.
489 489
 					// If going backwards and forwards between pages, the array key will match the other key.
490 490
 					if ( $o_key !== $other_key ) {
491
-						unset( $value[ $o_key ] );
491
+						unset( $value[$o_key] );
492 492
 					}
493 493
 
494 494
 					$args['temp_value']  = $value;
495
-					$value[ $other_key ] = reset( $other_vals );
496
-					if ( FrmAppHelper::is_empty_value( $value[ $other_key ] ) ) {
497
-						unset( $value[ $other_key ] );
495
+					$value[$other_key] = reset( $other_vals );
496
+					if ( FrmAppHelper::is_empty_value( $value[$other_key] ) ) {
497
+						unset( $value[$other_key] );
498 498
 					}
499 499
 				}
500
-			} elseif ( $field->options[ $other_key ] == $value ) {
500
+			} elseif ( $field->options[$other_key] == $value ) {
501 501
 				$value = $other_vals;
502 502
 			}
503 503
 		}
Please login to merge, or discard this patch.
classes/models/FrmForm.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
 		foreach ( $values as $value_key => $value ) {
142 142
 			if ( $value_key && in_array( $value_key, $form_fields ) ) {
143
-				$new_values[ $value_key ] = $value;
143
+				$new_values[$value_key] = $value;
144 144
 			}
145 145
 		}
146 146
 
@@ -210,15 +210,15 @@  discard block
 block discarded – undo
210 210
 		$existing_keys = array_keys( $values['item_meta'] );
211 211
 		foreach ( $all_fields as $fid ) {
212 212
 			if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
213
-				$values['item_meta'][ $fid->id ] = '';
213
+				$values['item_meta'][$fid->id] = '';
214 214
 			}
215
-			$field_array[ $fid->id ] = $fid;
215
+			$field_array[$fid->id] = $fid;
216 216
 		}
217 217
 		unset( $all_fields );
218 218
 
219 219
 		foreach ( $values['item_meta'] as $field_id => $default_value ) {
220
-			if ( isset( $field_array[ $field_id ] ) ) {
221
-				$field = $field_array[ $field_id ];
220
+			if ( isset( $field_array[$field_id] ) ) {
221
+				$field = $field_array[$field_id];
222 222
 			} else {
223 223
 				$field = FrmField::getOne( $field_id );
224 224
 			}
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 				continue;
228 228
 			}
229 229
 
230
-			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
230
+			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options']['custom_html_' . $field_id] ) );
231 231
 			if ( $is_settings_page ) {
232 232
 				self::get_settings_page_html( $values, $field );
233 233
 
@@ -242,15 +242,15 @@  discard block
 block discarded – undo
242 242
 			$update_options = apply_filters( 'frm_field_options_to_update', $update_options );
243 243
 
244 244
 			foreach ( $update_options as $opt => $default ) {
245
-				$field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
246
-				self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
245
+				$field->field_options[$opt] = isset( $values['field_options'][$opt . '_' . $field_id] ) ? $values['field_options'][$opt . '_' . $field_id] : $default;
246
+				self::sanitize_field_opt( $opt, $field->field_options[$opt] );
247 247
 			}
248 248
 
249 249
 			$field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
250 250
 
251 251
 			$new_field = array(
252 252
 				'field_options' => $field->field_options,
253
-				'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
253
+				'default_value' => isset( $values['default_value_' . $field_id] ) ? FrmAppHelper::maybe_json_encode( $values['default_value_' . $field_id] ) : '',
254 254
 			);
255 255
 
256 256
 			self::prepare_field_update_values( $field, $values, $new_field );
@@ -283,11 +283,11 @@  discard block
 block discarded – undo
283 283
 	 * Updating the settings page
284 284
 	 */
285 285
 	private static function get_settings_page_html( $values, &$field ) {
286
-		if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
286
+		if ( isset( $values['field_options']['custom_html_' . $field->id] ) ) {
287 287
 			$prev_opts     = array();
288 288
 			$fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
289 289
 
290
-			$field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
290
+			$field->field_options['custom_html'] = isset( $values['field_options']['custom_html_' . $field->id] ) ? $values['field_options']['custom_html_' . $field->id] : $fallback_html;
291 291
 		} elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) {
292 292
 			$prev_opts = $field->field_options;
293 293
 		}
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 		foreach ( $field_cols as $col => $default ) {
314 314
 			$default = ( $default === '' ) ? $field->{$col} : $default;
315 315
 
316
-			$new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
316
+			$new_field[$col] = isset( $values['field_options'][$col . '_' . $field->id] ) ? $values['field_options'][$col . '_' . $field->id] : $default;
317 317
 		}
318 318
 
319 319
 		// Don't save the template option.
@@ -727,8 +727,8 @@  discard block
 block discarded – undo
727 727
 			self::maybe_get_form( $form );
728 728
 		}
729 729
 
730
-		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
731
-			return $frm_vars['form_params'][ $form->id ];
730
+		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][$form->id] ) ) {
731
+			return $frm_vars['form_params'][$form->id];
732 732
 		}
733 733
 
734 734
 		$action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // WPCS: CSRF ok.
@@ -757,15 +757,15 @@  discard block
 block discarded – undo
757 757
 			//if there are two forms on the same page, make sure not to submit both
758 758
 			foreach ( $default_values as $var => $default ) {
759 759
 				if ( $var == 'action' ) {
760
-					$values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
760
+					$values[$var] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
761 761
 				} else {
762
-					$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
762
+					$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
763 763
 				}
764 764
 				unset( $var, $default );
765 765
 			}
766 766
 		} else {
767 767
 			foreach ( $default_values as $var => $default ) {
768
-				$values[ $var ] = $default;
768
+				$values[$var] = $default;
769 769
 				unset( $var, $default );
770 770
 			}
771 771
 		}
@@ -791,7 +791,7 @@  discard block
 block discarded – undo
791 791
 			'sdir'     => '',
792 792
 		);
793 793
 		foreach ( $defaults as $var => $default ) {
794
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
794
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
795 795
 		}
796 796
 
797 797
 		return $values;
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
 			'keep_post' => '',
820 820
 		);
821 821
 		foreach ( $defaults as $var => $default ) {
822
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
822
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
823 823
 		}
824 824
 
825 825
 		return $values;
@@ -905,7 +905,7 @@  discard block
 block discarded – undo
905 905
 		$form = $atts['form'];
906 906
 		$default = isset( $atts['default'] ) ? $atts['default'] : '';
907 907
 
908
-		return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
908
+		return isset( $form->options[$atts['option']] ) ? $form->options[$atts['option']] : $default;
909 909
 	}
910 910
 
911 911
 	/**
Please login to merge, or discard this patch.
classes/helpers/FrmXMLHelper.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,8 @@
 block discarded – undo
78 78
 
79 79
 		if ( ! isset( $imported['form_status'] ) || empty( $imported['form_status'] ) ) {
80 80
 			// Check for an error message in the XML.
81
-			if ( isset( $xml->Code ) && isset( $xml->Message ) ) { // phpcs:ignore WordPress.NamingConventions
81
+			if ( isset( $xml->Code ) && isset( $xml->Message ) ) {
82
+// phpcs:ignore WordPress.NamingConventions
82 83
 				$imported['error'] = reset( $xml->Message ); // phpcs:ignore WordPress.NamingConventions
83 84
 			}
84 85
 		}
Please login to merge, or discard this patch.
Spacing   +76 added lines, -76 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 
130 130
 			if ( $term && is_array( $term ) ) {
131 131
 				$imported['imported']['terms'] ++;
132
-				$imported['terms'][ (int) $t->term_id ] = $term['term_id'];
132
+				$imported['terms'][(int) $t->term_id] = $term['term_id'];
133 133
 			}
134 134
 
135 135
 			unset( $term, $t );
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 					}
186 186
 
187 187
 					// Keep track of whether this specific form was updated or not.
188
-					$imported['form_status'][ $form_id ] = 'imported';
188
+					$imported['form_status'][$form_id] = 'imported';
189 189
 				}
190 190
 			}
191 191
 
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 			// Update field ids/keys to new ones.
201 201
 			do_action( 'frm_after_duplicate_form', $form_id, $form, array( 'old_id' => $old_id ) );
202 202
 
203
-			$imported['forms'][ (int) $item->id ] = $form_id;
203
+			$imported['forms'][(int) $item->id] = $form_id;
204 204
 
205 205
 			// Send pre 2.0 form options through function that creates actions.
206 206
 			self::migrate_form_settings_to_actions( $form['options'], $form_id, $imported, true );
@@ -263,15 +263,15 @@  discard block
 block discarded – undo
263 263
 		}
264 264
 
265 265
 		// Keep track of whether this specific form was updated or not
266
-		$imported['form_status'][ $form_id ] = 'updated';
266
+		$imported['form_status'][$form_id] = 'updated';
267 267
 	}
268 268
 
269 269
 	private static function get_form_fields( $form_id ) {
270 270
 		$form_fields = FrmField::get_all_for_form( $form_id, '', 'exclude', 'exclude' );
271 271
 		$old_fields  = array();
272 272
 		foreach ( $form_fields as $f ) {
273
-			$old_fields[ $f->id ]        = $f;
274
-			$old_fields[ $f->field_key ] = $f->id;
273
+			$old_fields[$f->id]        = $f;
274
+			$old_fields[$f->field_key] = $f->id;
275 275
 			unset( $f );
276 276
 		}
277 277
 		$form_fields = $old_fields;
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 	 */
329 329
 	private static function track_imported_child_forms( $form_id, $parent_form_id, &$child_forms ) {
330 330
 		if ( $parent_form_id ) {
331
-			$child_forms[ $form_id ] = $parent_form_id;
331
+			$child_forms[$form_id] = $parent_form_id;
332 332
 		}
333 333
 	}
334 334
 
@@ -343,9 +343,9 @@  discard block
 block discarded – undo
343 343
 	 */
344 344
 	private static function maybe_update_child_form_parent_id( $imported_forms, $child_forms ) {
345 345
 		foreach ( $child_forms as $child_form_id => $old_parent_form_id ) {
346
-			if ( isset( $imported_forms[ $old_parent_form_id ] ) && (int) $imported_forms[ $old_parent_form_id ] !== (int) $old_parent_form_id ) {
346
+			if ( isset( $imported_forms[$old_parent_form_id] ) && (int) $imported_forms[$old_parent_form_id] !== (int) $old_parent_form_id ) {
347 347
 				// Update all children with this old parent_form_id
348
-				$new_parent_form_id = (int) $imported_forms[ $old_parent_form_id ];
348
+				$new_parent_form_id = (int) $imported_forms[$old_parent_form_id];
349 349
 				FrmForm::update( $child_form_id, array( 'parent_form_id' => $new_parent_form_id ) );
350 350
 				do_action( 'frm_update_child_form_parent_id', $child_form_id, $new_parent_form_id );
351 351
 			}
@@ -375,27 +375,27 @@  discard block
 block discarded – undo
375 375
 
376 376
 			if ( ! empty( $this_form ) ) {
377 377
 				// check for field to edit by field id
378
-				if ( isset( $form_fields[ $f['id'] ] ) ) {
378
+				if ( isset( $form_fields[$f['id']] ) ) {
379 379
 					FrmField::update( $f['id'], $f );
380 380
 					$imported['updated']['fields'] ++;
381 381
 
382
-					unset( $form_fields[ $f['id'] ] );
382
+					unset( $form_fields[$f['id']] );
383 383
 
384 384
 					//unset old field key
385
-					if ( isset( $form_fields[ $f['field_key'] ] ) ) {
386
-						unset( $form_fields[ $f['field_key'] ] );
385
+					if ( isset( $form_fields[$f['field_key']] ) ) {
386
+						unset( $form_fields[$f['field_key']] );
387 387
 					}
388
-				} elseif ( isset( $form_fields[ $f['field_key'] ] ) ) {
389
-					$keys_by_original_field_id[ $f['id'] ] = $f['field_key'];
388
+				} elseif ( isset( $form_fields[$f['field_key']] ) ) {
389
+					$keys_by_original_field_id[$f['id']] = $f['field_key'];
390 390
 
391 391
 					// check for field to edit by field key
392 392
 					unset( $f['id'] );
393 393
 
394
-					FrmField::update( $form_fields[ $f['field_key'] ], $f );
394
+					FrmField::update( $form_fields[$f['field_key']], $f );
395 395
 					$imported['updated']['fields'] ++;
396 396
 
397
-					unset( $form_fields[ $form_fields[ $f['field_key'] ] ] ); //unset old field id
398
-					unset( $form_fields[ $f['field_key'] ] ); //unset old field key
397
+					unset( $form_fields[$form_fields[$f['field_key']]] ); //unset old field id
398
+					unset( $form_fields[$f['field_key']] ); //unset old field key
399 399
 				} else {
400 400
 					// if no matching field id or key in this form, create the field
401 401
 					self::create_imported_field( $f, $imported );
@@ -504,8 +504,8 @@  discard block
 block discarded – undo
504 504
 		if ( $f['type'] == 'form' || ( $f['type'] == 'divider' && FrmField::is_option_true( $f['field_options'], 'repeat' ) ) ) {
505 505
 			if ( FrmField::is_option_true( $f['field_options'], 'form_select' ) ) {
506 506
 				$form_select = (int) $f['field_options']['form_select'];
507
-				if ( isset( $imported['forms'][ $form_select ] ) ) {
508
-					$f['field_options']['form_select'] = $imported['forms'][ $form_select ];
507
+				if ( isset( $imported['forms'][$form_select] ) ) {
508
+					$f['field_options']['form_select'] = $imported['forms'][$form_select];
509 509
 				}
510 510
 			}
511 511
 		}
@@ -526,8 +526,8 @@  discard block
 block discarded – undo
526 526
 
527 527
 		if ( FrmField::is_option_true_in_array( $f['field_options'], 'get_values_form' ) ) {
528 528
 			$old_form = $f['field_options']['get_values_form'];
529
-			if ( isset( $imported['forms'][ $old_form ] ) ) {
530
-				$f['field_options']['get_values_form'] = $imported['forms'][ $old_form ];
529
+			if ( isset( $imported['forms'][$old_form] ) ) {
530
+				$f['field_options']['get_values_form'] = $imported['forms'][$old_form];
531 531
 			}
532 532
 		}
533 533
 	}
@@ -548,12 +548,12 @@  discard block
 block discarded – undo
548 548
 	private static function migrate_placeholders( &$f ) {
549 549
 		$update_values = self::migrate_field_placeholder( $f, 'clear_on_focus' );
550 550
 		foreach ( $update_values as $k => $v ) {
551
-			$f[ $k ] = $v;
551
+			$f[$k] = $v;
552 552
 		}
553 553
 
554 554
 		$update_values = self::migrate_field_placeholder( $f, 'default_blank' );
555 555
 		foreach ( $update_values as $k => $v ) {
556
-			$f[ $k ] = $v;
556
+			$f[$k] = $v;
557 557
 		}
558 558
 	}
559 559
 
@@ -567,7 +567,7 @@  discard block
 block discarded – undo
567 567
 	public static function migrate_field_placeholder( $field, $type ) {
568 568
 		$field = (array) $field;
569 569
 		$field_options = $field['field_options'];
570
-		if ( empty( $field_options[ $type ] ) || empty( $field['default_value'] ) ) {
570
+		if ( empty( $field_options[$type] ) || empty( $field['default_value'] ) ) {
571 571
 			return array();
572 572
 		}
573 573
 
@@ -593,7 +593,7 @@  discard block
 block discarded – undo
593 593
 				}
594 594
 
595 595
 				if ( $opt == $default_value ) {
596
-					unset( $options[ $opt_key ] );
596
+					unset( $options[$opt_key] );
597 597
 					break;
598 598
 				}
599 599
 			}
@@ -793,17 +793,17 @@  discard block
 block discarded – undo
793 793
 			self::update_layout( $post, $post_id );
794 794
 
795 795
 			$this_type = 'posts';
796
-			if ( isset( $post_types[ $post['post_type'] ] ) ) {
797
-				$this_type = $post_types[ $post['post_type'] ];
796
+			if ( isset( $post_types[$post['post_type']] ) ) {
797
+				$this_type = $post_types[$post['post_type']];
798 798
 			}
799 799
 
800 800
 			if ( isset( $post['ID'] ) && $post_id == $post['ID'] ) {
801
-				$imported['updated'][ $this_type ] ++;
801
+				$imported['updated'][$this_type] ++;
802 802
 			} else {
803
-				$imported['imported'][ $this_type ] ++;
803
+				$imported['imported'][$this_type] ++;
804 804
 			}
805 805
 
806
-			$imported['posts'][ (int) $old_id ] = $post_id;
806
+			$imported['posts'][(int) $old_id] = $post_id;
807 807
 
808 808
 			do_action( 'frm_after_import_view', $post_id, $post );
809 809
 
@@ -832,9 +832,9 @@  discard block
 block discarded – undo
832 832
 			$post['attachment_url'] = (string) $item->attachment_url;
833 833
 		}
834 834
 
835
-		if ( $post['post_type'] == FrmFormActionsController::$action_post_type && isset( $imported['forms'][ (int) $post['menu_order'] ] ) ) {
835
+		if ( $post['post_type'] == FrmFormActionsController::$action_post_type && isset( $imported['forms'][(int) $post['menu_order']] ) ) {
836 836
 			// update to new form id
837
-			$post['menu_order'] = $imported['forms'][ (int) $post['menu_order'] ];
837
+			$post['menu_order'] = $imported['forms'][(int) $post['menu_order']];
838 838
 		}
839 839
 
840 840
 		// Don't allow default styles to take over a site's default style
@@ -871,8 +871,8 @@  discard block
 block discarded – undo
871 871
 		);
872 872
 
873 873
 		//switch old form and field ids to new ones
874
-		if ( 'frm_form_id' === $m['key'] && isset( $imported['forms'][ (int) $m['value'] ] ) ) {
875
-			$m['value'] = $imported['forms'][ (int) $m['value'] ];
874
+		if ( 'frm_form_id' === $m['key'] && isset( $imported['forms'][(int) $m['value']] ) ) {
875
+			$m['value'] = $imported['forms'][(int) $m['value']];
876 876
 		} else {
877 877
 			$m['value'] = FrmAppHelper::maybe_json_decode( $m['value'] );
878 878
 
@@ -883,15 +883,15 @@  discard block
 block discarded – undo
883 883
 				} elseif ( 'frm_options' === $m['key'] ) {
884 884
 
885 885
 					foreach ( array( 'date_field_id', 'edate_field_id' ) as $setting_name ) {
886
-						if ( isset( $m['value'][ $setting_name ] ) && is_numeric( $m['value'][ $setting_name ] ) && isset( $frm_duplicate_ids[ $m['value'][ $setting_name ] ] ) ) {
887
-							$m['value'][ $setting_name ] = $frm_duplicate_ids[ $m['value'][ $setting_name ] ];
886
+						if ( isset( $m['value'][$setting_name] ) && is_numeric( $m['value'][$setting_name] ) && isset( $frm_duplicate_ids[$m['value'][$setting_name]] ) ) {
887
+							$m['value'][$setting_name] = $frm_duplicate_ids[$m['value'][$setting_name]];
888 888
 						}
889 889
 					}
890 890
 
891 891
 					$check_dup_array = array();
892 892
 					if ( isset( $m['value']['order_by'] ) && ! empty( $m['value']['order_by'] ) ) {
893
-						if ( is_numeric( $m['value']['order_by'] ) && isset( $frm_duplicate_ids[ $m['value']['order_by'] ] ) ) {
894
-							$m['value']['order_by'] = $frm_duplicate_ids[ $m['value']['order_by'] ];
893
+						if ( is_numeric( $m['value']['order_by'] ) && isset( $frm_duplicate_ids[$m['value']['order_by']] ) ) {
894
+							$m['value']['order_by'] = $frm_duplicate_ids[$m['value']['order_by']];
895 895
 						} elseif ( is_array( $m['value']['order_by'] ) ) {
896 896
 							$check_dup_array[] = 'order_by';
897 897
 						}
@@ -902,9 +902,9 @@  discard block
 block discarded – undo
902 902
 					}
903 903
 
904 904
 					foreach ( $check_dup_array as $check_k ) {
905
-						foreach ( (array) $m['value'][ $check_k ] as $mk => $mv ) {
906
-							if ( isset( $frm_duplicate_ids[ $mv ] ) ) {
907
-								$m['value'][ $check_k ][ $mk ] = $frm_duplicate_ids[ $mv ];
905
+						foreach ( (array) $m['value'][$check_k] as $mk => $mv ) {
906
+							if ( isset( $frm_duplicate_ids[$mv] ) ) {
907
+								$m['value'][$check_k][$mk] = $frm_duplicate_ids[$mv];
908 908
 							}
909 909
 							unset( $mk, $mv );
910 910
 						}
@@ -917,11 +917,11 @@  discard block
 block discarded – undo
917 917
 			$m['value'] = FrmAppHelper::maybe_json_decode( $m['value'] );
918 918
 		}
919 919
 
920
-		$post['postmeta'][ (string) $meta->meta_key ] = $m['value'];
920
+		$post['postmeta'][(string) $meta->meta_key] = $m['value'];
921 921
 	}
922 922
 
923 923
 	private static function populate_layout( &$post, $layout ) {
924
-		$post['layout'][ (string) $layout->type ] = (string) $layout->data;
924
+		$post['layout'][(string) $layout->type] = (string) $layout->data;
925 925
 	}
926 926
 
927 927
 	/**
@@ -949,11 +949,11 @@  discard block
 block discarded – undo
949 949
 				$name = (string) $c;
950 950
 			}
951 951
 
952
-			if ( ! isset( $post['tax_input'][ $taxonomy ] ) ) {
953
-				$post['tax_input'][ $taxonomy ] = array();
952
+			if ( ! isset( $post['tax_input'][$taxonomy] ) ) {
953
+				$post['tax_input'][$taxonomy] = array();
954 954
 			}
955 955
 
956
-			$post['tax_input'][ $taxonomy ][] = $name;
956
+			$post['tax_input'][$taxonomy][] = $name;
957 957
 			unset( $name );
958 958
 		}
959 959
 	}
@@ -1070,7 +1070,7 @@  discard block
 block discarded – undo
1070 1070
 
1071 1071
 		$message = '<ul>';
1072 1072
 		foreach ( $result as $type => $results ) {
1073
-			if ( ! isset( $t_strings[ $type ] ) ) {
1073
+			if ( ! isset( $t_strings[$type] ) ) {
1074 1074
 				// only print imported and updated
1075 1075
 				continue;
1076 1076
 			}
@@ -1082,7 +1082,7 @@  discard block
 block discarded – undo
1082 1082
 			}
1083 1083
 
1084 1084
 			if ( ! empty( $s_message ) ) {
1085
-				$message .= '<li><strong>' . $t_strings[ $type ] . ':</strong> ';
1085
+				$message .= '<li><strong>' . $t_strings[$type] . ':</strong> ';
1086 1086
 				$message .= implode( ', ', $s_message );
1087 1087
 				$message .= '</li>';
1088 1088
 			}
@@ -1122,7 +1122,7 @@  discard block
 block discarded – undo
1122 1122
 			'actions' => sprintf( _n( '%1$s Form Action', '%1$s Form Actions', $m, 'formidable' ), $m ),
1123 1123
 		);
1124 1124
 
1125
-		$s_message[] = isset( $strings[ $type ] ) ? $strings[ $type ] : ' ' . $m . ' ' . ucfirst( $type );
1125
+		$s_message[] = isset( $strings[$type] ) ? $strings[$type] : ' ' . $m . ' ' . ucfirst( $type );
1126 1126
 	}
1127 1127
 
1128 1128
 	/**
@@ -1252,8 +1252,8 @@  discard block
 block discarded – undo
1252 1252
 	 */
1253 1253
 	private static function remove_defaults( $defaults, &$saved ) {
1254 1254
 		foreach ( $saved as $key => $value ) {
1255
-			if ( isset( $defaults[ $key ] ) && $defaults[ $key ] === $value ) {
1256
-				unset( $saved[ $key ] );
1255
+			if ( isset( $defaults[$key] ) && $defaults[$key] === $value ) {
1256
+				unset( $saved[$key] );
1257 1257
 			}
1258 1258
 		}
1259 1259
 	}
@@ -1264,14 +1264,14 @@  discard block
 block discarded – undo
1264 1264
 	 * @since 3.06
1265 1265
 	 */
1266 1266
 	private static function remove_default_html( $html_name, $defaults, &$options ) {
1267
-		if ( ! isset( $options[ $html_name ] ) || ! isset( $defaults[ $html_name ] ) ) {
1267
+		if ( ! isset( $options[$html_name] ) || ! isset( $defaults[$html_name] ) ) {
1268 1268
 			return;
1269 1269
 		}
1270 1270
 
1271
-		$old_html     = str_replace( "\r\n", "\n", $options[ $html_name ] );
1272
-		$default_html = $defaults[ $html_name ];
1271
+		$old_html     = str_replace( "\r\n", "\n", $options[$html_name] );
1272
+		$default_html = $defaults[$html_name];
1273 1273
 		if ( $old_html == $default_html ) {
1274
-			unset( $options[ $html_name ] );
1274
+			unset( $options[$html_name] );
1275 1275
 
1276 1276
 			return;
1277 1277
 		}
@@ -1279,7 +1279,7 @@  discard block
 block discarded – undo
1279 1279
 		// Account for some of the older field default HTML.
1280 1280
 		$default_html = str_replace( ' id="frm_desc_field_[key]"', '', $default_html );
1281 1281
 		if ( $old_html == $default_html ) {
1282
-			unset( $options[ $html_name ] );
1282
+			unset( $options[$html_name] );
1283 1283
 		}
1284 1284
 	}
1285 1285
 
@@ -1366,8 +1366,8 @@  discard block
 block discarded – undo
1366 1366
 		);
1367 1367
 
1368 1368
 		foreach ( $post_settings as $post_setting ) {
1369
-			if ( isset( $form_options[ $post_setting ] ) ) {
1370
-				$new_action['post_content'][ $post_setting ] = $form_options[ $post_setting ];
1369
+			if ( isset( $form_options[$post_setting] ) ) {
1370
+				$new_action['post_content'][$post_setting] = $form_options[$post_setting];
1371 1371
 			}
1372 1372
 			unset( $post_setting );
1373 1373
 		}
@@ -1438,11 +1438,11 @@  discard block
 block discarded – undo
1438 1438
 		foreach ( $post_content as $key => $setting ) {
1439 1439
 			if ( ! is_array( $setting ) && in_array( $key, $basic_fields ) ) {
1440 1440
 				// Replace old IDs with new IDs
1441
-				$post_content[ $key ] = str_replace( $old, $new, $setting );
1441
+				$post_content[$key] = str_replace( $old, $new, $setting );
1442 1442
 			} elseif ( is_array( $setting ) && in_array( $key, $array_fields ) ) {
1443 1443
 				foreach ( $setting as $k => $val ) {
1444 1444
 					// Replace old IDs with new IDs
1445
-					$post_content[ $key ][ $k ] = str_replace( $old, $new, $val );
1445
+					$post_content[$key][$k] = str_replace( $old, $new, $val );
1446 1446
 				}
1447 1447
 			}
1448 1448
 			unset( $key, $setting );
@@ -1518,8 +1518,8 @@  discard block
 block discarded – undo
1518 1518
 	private static function remove_deprecated_notification_settings( $form_id, $form_options ) {
1519 1519
 		$delete_settings = array( 'notification', 'autoresponder', 'email_to' );
1520 1520
 		foreach ( $delete_settings as $index ) {
1521
-			if ( isset( $form_options[ $index ] ) ) {
1522
-				unset( $form_options[ $index ] );
1521
+			if ( isset( $form_options[$index] ) ) {
1522
+				unset( $form_options[$index] );
1523 1523
 			}
1524 1524
 		}
1525 1525
 		FrmForm::update( $form_id, array( 'options' => $form_options ) );
@@ -1572,12 +1572,12 @@  discard block
 block discarded – undo
1572 1572
 			'reply_to_name' => '',
1573 1573
 		);
1574 1574
 		foreach ( $reply_fields as $f => $val ) {
1575
-			if ( isset( $notification[ $f ] ) ) {
1576
-				$atts[ $f ] = $notification[ $f ];
1577
-				if ( 'custom' == $notification[ $f ] ) {
1578
-					$atts[ $f ] = $notification[ 'cust_' . $f ];
1579
-				} elseif ( is_numeric( $atts[ $f ] ) && ! empty( $atts[ $f ] ) ) {
1580
-					$atts[ $f ] = '[' . $atts[ $f ] . ']';
1575
+			if ( isset( $notification[$f] ) ) {
1576
+				$atts[$f] = $notification[$f];
1577
+				if ( 'custom' == $notification[$f] ) {
1578
+					$atts[$f] = $notification['cust_' . $f];
1579
+				} elseif ( is_numeric( $atts[$f] ) && ! empty( $atts[$f] ) ) {
1580
+					$atts[$f] = '[' . $atts[$f] . ']';
1581 1581
 				}
1582 1582
 			}
1583 1583
 			unset( $f, $val );
@@ -1608,13 +1608,13 @@  discard block
 block discarded – undo
1608 1608
 		foreach ( $atts['email_to'] as $key => $email_field ) {
1609 1609
 
1610 1610
 			if ( is_numeric( $email_field ) ) {
1611
-				$atts['email_to'][ $key ] = '[' . $email_field . ']';
1611
+				$atts['email_to'][$key] = '[' . $email_field . ']';
1612 1612
 			}
1613 1613
 
1614 1614
 			if ( strpos( $email_field, '|' ) ) {
1615 1615
 				$email_opt = explode( '|', $email_field );
1616 1616
 				if ( isset( $email_opt[0] ) ) {
1617
-					$atts['email_to'][ $key ] = '[' . $email_opt[0] . ' show=' . $email_opt[1] . ']';
1617
+					$atts['email_to'][$key] = '[' . $email_opt[0] . ' show=' . $email_opt[1] . ']';
1618 1618
 				}
1619 1619
 				unset( $email_opt );
1620 1620
 			}
@@ -1635,12 +1635,12 @@  discard block
 block discarded – undo
1635 1635
 		// Add more fields to the new notification
1636 1636
 		$add_fields = array( 'email_message', 'email_subject', 'plain_text', 'inc_user_info', 'conditions' );
1637 1637
 		foreach ( $add_fields as $add_field ) {
1638
-			if ( isset( $notification[ $add_field ] ) ) {
1639
-				$new_notification['post_content'][ $add_field ] = $notification[ $add_field ];
1638
+			if ( isset( $notification[$add_field] ) ) {
1639
+				$new_notification['post_content'][$add_field] = $notification[$add_field];
1640 1640
 			} elseif ( in_array( $add_field, array( 'plain_text', 'inc_user_info' ) ) ) {
1641
-				$new_notification['post_content'][ $add_field ] = 0;
1641
+				$new_notification['post_content'][$add_field] = 0;
1642 1642
 			} else {
1643
-				$new_notification['post_content'][ $add_field ] = '';
1643
+				$new_notification['post_content'][$add_field] = '';
1644 1644
 			}
1645 1645
 			unset( $add_field );
1646 1646
 		}
@@ -1664,7 +1664,7 @@  discard block
 block discarded – undo
1664 1664
 		if ( isset( $post_content['conditions'] ) && is_array( $post_content['conditions'] ) ) {
1665 1665
 			foreach ( $post_content['conditions'] as $email_key => $val ) {
1666 1666
 				if ( is_numeric( $email_key ) ) {
1667
-					$post_content['conditions'][ $email_key ] = self::switch_action_field_ids( $val, array( 'hide_field' ) );
1667
+					$post_content['conditions'][$email_key] = self::switch_action_field_ids( $val, array( 'hide_field' ) );
1668 1668
 				}
1669 1669
 				unset( $email_key, $val );
1670 1670
 			}
Please login to merge, or discard this patch.
classes/views/solutions/_import.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@  discard block
 block discarded – undo
6 6
 				$info['url'] = $xml;
7 7
 			}
8 8
 
9
-			$disabled = isset( $imported[ $info['form'] ] ) ? ' disabled' : '';
9
+			$disabled = isset( $imported[$info['form']] ) ? ' disabled' : '';
10 10
 			$url   = isset( $info['url'] ) ? $info['url'] : '';
11 11
 			$value = $importing === 'form' ? $info['form'] : $info['key'];
12 12
 			if ( ! isset( $info['img'] ) ) {
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 				continue;
17 17
 			}
18 18
 
19
-			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[ $info['form'] ] ) );
19
+			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[$info['form']] ) );
20 20
 			?>
21 21
 			<div class="frm_radio radio-inline radio frm_image_option<?php echo esc_attr( $importing === 'view' ? ' show_sub_opt show_' . $info['form'] : '' ); ?>" style="<?php echo esc_attr( $hide_views ? 'display:none' : '' ); ?>">
22 22
 				<?php if ( $importing === 'form' ) { ?>
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 					<?php } ?>
37 37
 					/>
38 38
 					<div class="frm_image_option_container frm_label_with_image">
39
-						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) );  // WPCS: XSS ok. ?>
39
+						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) ); // WPCS: XSS ok. ?>
40 40
 						<span class="frm_text_label_for_image">
41 41
 							<?php
42 42
 							if ( ! empty( $disabled ) ) {
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 							}
50 50
 
51 51
 							if ( $importing === 'form' && $disabled ) {
52
-								echo FrmFormsHelper::edit_form_link( $imported[ $info['form'] ] ); // WPCS: XSS ok.
52
+								echo FrmFormsHelper::edit_form_link( $imported[$info['form']] ); // WPCS: XSS ok.
53 53
 							} else {
54 54
 								echo esc_html( $info['name'] );
55 55
 							}
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldCaptcha.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -144,11 +144,11 @@
 block discarded – undo
144 144
 		if ( isset( $response['success'] ) && ! $response['success'] ) {
145 145
 			// What happens when the CAPTCHA was entered incorrectly
146 146
 			$invalid_message                 = FrmField::get_option( $this->field, 'invalid' );
147
-			$errors[ 'field' . $args['id'] ] = ( $invalid_message == '' ? $frm_settings->re_msg : $invalid_message );
147
+			$errors['field' . $args['id']] = ( $invalid_message == '' ? $frm_settings->re_msg : $invalid_message );
148 148
 		} elseif ( is_wp_error( $resp ) ) {
149 149
 			$error_string                     = $resp->get_error_message();
150
-			$errors[ 'field' . $args['id'] ]  = __( 'There was a problem verifying your recaptcha', 'formidable' );
151
-			$errors[ 'field' . $args['id'] ] .= ' ' . $error_string;
150
+			$errors['field' . $args['id']]  = __( 'There was a problem verifying your recaptcha', 'formidable' );
151
+			$errors['field' . $args['id']] .= ' ' . $error_string;
152 152
 		}
153 153
 
154 154
 		return $errors;
Please login to merge, or discard this patch.
classes/models/FrmFieldFormHtml.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
 	 * @param array $atts
42 42
 	 */
43 43
 	private function _set( $param, $atts ) {
44
-		if ( isset( $atts[ $param ] ) ) {
45
-			$this->{$param} = $atts[ $param ];
44
+		if ( isset( $atts[$param] ) ) {
45
+			$this->{$param} = $atts[$param];
46 46
 		}
47 47
 	}
48 48
 
@@ -86,8 +86,8 @@  discard block
 block discarded – undo
86 86
 
87 87
 		$exclude = array( 'field_obj', 'html' );
88 88
 		foreach ( $exclude as $ex ) {
89
-			if ( isset( $atts[ $ex ] ) ) {
90
-				unset( $this->pass_args[ $ex ] );
89
+			if ( isset( $atts[$ex] ) ) {
90
+				unset( $this->pass_args[$ex] );
91 91
 			}
92 92
 		}
93 93
 	}
@@ -99,8 +99,8 @@  discard block
 block discarded – undo
99 99
 	 * @param array $set
100 100
 	 */
101 101
 	private function set_from_field( $atts, $set ) {
102
-		if ( isset( $atts[ $set['param'] ] ) ) {
103
-			$this->{$set['param']} = $atts[ $set['param'] ];
102
+		if ( isset( $atts[$set['param']] ) ) {
103
+			$this->{$set['param']} = $atts[$set['param']];
104 104
 		} else {
105 105
 			$this->{$set['param']} = $this->field_obj->get_field_column( $set['default'] );
106 106
 		}
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 	 */
226 226
 	private function replace_error_shortcode() {
227 227
 		$this->maybe_add_error_id();
228
-		$error = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? $this->pass_args['errors'][ 'field' . $this->field_id ] : false;
228
+		$error = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? $this->pass_args['errors']['field' . $this->field_id] : false;
229 229
 		FrmShortcodeHelper::remove_inline_conditions( ! empty( $error ), 'error', $error, $this->html );
230 230
 	}
231 231
 
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
 	 * @since 3.06.02
237 237
 	 */
238 238
 	private function maybe_add_error_id() {
239
-		if ( ! isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
239
+		if ( ! isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
240 240
 			return;
241 241
 		}
242 242
 
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 		preg_match_all( "/\[(input|deletelink)\b(.*?)(?:(\/))?\]/s", $this->html, $shortcodes, PREG_PATTERN_ORDER );
317 317
 
318 318
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
319
-			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
319
+			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
320 320
 			$tag            = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
321 321
 
322 322
 			$replace_with = '';
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
 				$replace_with = $this->replace_input_shortcode( $shortcode_atts );
328 328
 			}
329 329
 
330
-			$this->html = str_replace( $shortcodes[0][ $short_key ], $replace_with, $this->html );
330
+			$this->html = str_replace( $shortcodes[0][$short_key], $replace_with, $this->html );
331 331
 		}
332 332
 	}
333 333
 
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
 			unset( $shortcode_atts['class'] );
360 360
 		}
361 361
 
362
-		$shortcode_atts['aria-invalid'] = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? 'true' : 'false';
362
+		$shortcode_atts['aria-invalid'] = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? 'true' : 'false';
363 363
 
364 364
 		$this->field_obj->set_field_column( 'shortcodes', $shortcode_atts );
365 365
 
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 	 */
415 415
 	private function get_field_div_classes() {
416 416
 		// Add error class
417
-		$classes = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? ' frm_blank_field' : '';
417
+		$classes = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? ' frm_blank_field' : '';
418 418
 
419 419
 		// Add label position class
420 420
 		$settings = $this->field_obj->display_field_settings();
Please login to merge, or discard this patch.
classes/controllers/FrmXMLController.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 			return;
122 122
 		}
123 123
 
124
-		$selected_xml  = isset( $form['xml'] ) && isset( $form['xml'][ $selected_form ] ) ? $form['xml'][ $selected_form ] : '';
124
+		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][$selected_form] ) ? $form['xml'][$selected_form] : '';
125 125
 		if ( empty( $selected_xml ) || strpos( $selected_xml, 'http' ) !== 0 ) {
126 126
 			return;
127 127
 		}
@@ -133,8 +133,8 @@  discard block
 block discarded – undo
133 133
 	 * @since 4.06.02
134 134
 	 */
135 135
 	private static function get_selected_in_form( $form, $value = 'form' ) {
136
-		if ( ! empty( $form ) && isset( $form[ $value ] ) && ! empty( $form[ $value ] ) ) {
137
-			return $form[ $value ];
136
+		if ( ! empty( $form ) && isset( $form[$value] ) && ! empty( $form[$value] ) ) {
137
+			return $form[$value];
138 138
 		}
139 139
 
140 140
 		return '';
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 			}
164 164
 
165 165
 			if ( $for === 'view' ) {
166
-				$item_key  = is_array( $view_keys ) ? $view_keys[ $form_key ] : $view_keys;
166
+				$item_key  = is_array( $view_keys ) ? $view_keys[$form_key] : $view_keys;
167 167
 				$shortcode = '[display-frm-data id=%1$s filter=limited]';
168 168
 			} elseif ( $for === 'form' ) {
169 169
 				$item_key = $form_key;
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 				continue;
179 179
 			}
180 180
 
181
-			$page_ids[ $for ] = wp_insert_post(
181
+			$page_ids[$for] = wp_insert_post(
182 182
 				array(
183 183
 					'post_title'   => $name,
184 184
 					'post_type'    => 'page',
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
 		// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash
320 320
 		$file_type = sanitize_option( 'upload_path', $_FILES['frm_import_file']['name'] );
321 321
 		$file_type = strtolower( pathinfo( $file_type, PATHINFO_EXTENSION ) );
322
-		if ( 'xml' !== $file_type && isset( $export_format[ $file_type ] ) ) {
322
+		if ( 'xml' !== $file_type && isset( $export_format[$file_type] ) ) {
323 323
 			// allow other file types to be imported
324 324
 			do_action( 'frm_before_import_' . $file_type );
325 325
 
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
 		foreach ( $type as $tb_type ) {
403 403
 			$where = array();
404 404
 			$join  = '';
405
-			$table = $tables[ $tb_type ];
405
+			$table = $tables[$tb_type];
406 406
 
407 407
 			$select     = $table . '.id';
408 408
 			$query_vars = array();
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
 							$table . '.parent_form_id' => $args['ids'],
418 418
 						);
419 419
 					} else {
420
-						$where[ $table . '.status !' ] = 'draft';
420
+						$where[$table . '.status !'] = 'draft';
421 421
 					}
422 422
 					break;
423 423
 				case 'actions':
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
 				case 'items':
431 431
 					// $join = "INNER JOIN {$wpdb->prefix}frm_item_metas im ON ($table.id = im.item_id)";
432 432
 					if ( $args['ids'] ) {
433
-						$where[ $table . '.form_id' ] = $args['ids'];
433
+						$where[$table . '.form_id'] = $args['ids'];
434 434
 					}
435 435
 					break;
436 436
 				case 'styles':
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
 					}
472 472
 			}
473 473
 
474
-			$records[ $tb_type ] = FrmDb::get_col( $table . $join, $where, $select );
474
+			$records[$tb_type] = FrmDb::get_col( $table . $join, $where, $select );
475 475
 			unset( $tb_type );
476 476
 		}
477 477
 
@@ -616,7 +616,7 @@  discard block
 block discarded – undo
616 616
 		$no_export_fields = FrmField::no_save_fields();
617 617
 		foreach ( $csv_fields as $k => $f ) {
618 618
 			if ( in_array( $f->type, $no_export_fields, true ) ) {
619
-				unset( $csv_fields[ $k ] );
619
+				unset( $csv_fields[$k] );
620 620
 			}
621 621
 		}
622 622
 
Please login to merge, or discard this patch.
classes/views/frm-fields/back-end/field-multiple.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,6 +9,6 @@
 block discarded – undo
9 9
 	$type = $field['type'];
10 10
 	do_action( 'frm_after_checkbox', compact( 'field', 'field_name', 'type' ) );
11 11
 } else {
12
-	$read_only  = $field['read_only'];
12
+	$read_only = $field['read_only'];
13 13
 	include dirname( __FILE__ ) . '/' . $field['type'] . '-field.php';
14 14
 }
Please login to merge, or discard this patch.
classes/views/frm-forms/list-templates.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
 	</li><?php
17 17
 	$render_icon = true;
18 18
 	foreach ( array( 20872734, 20874748, 20882522, 20874739 ) as $template ) {
19
-		if ( isset( $templates[ $template ] ) ) {
20
-			$template = $templates[ $template ];
19
+		if ( isset( $templates[$template] ) ) {
20
+			$template = $templates[$template];
21 21
 			require $view_path . 'list-template.php';
22 22
 		}
23 23
 	}
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	<ul class="frm-templates-list frm-categories-list">
46 46
 		<?php foreach ( $categories as $category ) { ?>
47 47
 			<?php
48
-			$category_templates = $templates_by_category[ $category ];
48
+			$category_templates = $templates_by_category[$category];
49 49
 			$count              = count( $category_templates );
50 50
 			$available          = FrmFormsHelper::available_count( $category_templates, $args );
51 51
 			?>
Please login to merge, or discard this patch.