Strategy11 / formidable-forms

classes/controllers/FrmXMLController.php

Spacing +11 added lines, -11 removed lines

@@ -177,7 +177,7 @@ 
 			return;
 		}
 
-		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][ $selected_form ] ) ? $form['xml'][ $selected_form ] : '';
+		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][$selected_form] ) ? $form['xml'][$selected_form] : '';
 
 		if ( empty( $selected_xml ) || strpos( $selected_xml, 'http' ) !== 0 ) {
 			return;
@@ -195,8 +195,8 @@ 
 	 * @return string
 	 */
 	private static function get_selected_in_form( $form, $value = 'form' ) {
-		if ( ! empty( $form ) && ! empty( $form[ $value ] ) ) {
-			return $form[ $value ];
+		if ( ! empty( $form ) && ! empty( $form[$value] ) ) {
+			return $form[$value];
 		}
 
 		return '';
@@ -226,7 +226,7 @@ 
 			}
 
 			if ( $for === 'view' ) {
-				$item_key  = is_array( $view_keys ) ? $view_keys[ $form_key ] : $view_keys;
+				$item_key  = is_array( $view_keys ) ? $view_keys[$form_key] : $view_keys;
 				$shortcode = '[display-frm-data id=%1$s filter=limited]';
 			} elseif ( $for === 'form' ) {
 				$item_key  = $form_key;
@@ -241,7 +241,7 @@ 
 				continue;
 			}
 
-			$page_ids[ $for ] = wp_insert_post(
+			$page_ids[$for] = wp_insert_post(
 				array(
 					'post_title'   => $name,
 					'post_type'    => 'page',
@@ -400,7 +400,7 @@ 
 		$file_type = sanitize_option( 'upload_path', $_FILES['frm_import_file']['name'] );
 		$file_type = strtolower( pathinfo( $file_type, PATHINFO_EXTENSION ) );
 
-		if ( 'xml' !== $file_type && isset( $export_format[ $file_type ] ) ) {
+		if ( 'xml' !== $file_type && isset( $export_format[$file_type] ) ) {
 			// allow other file types to be imported
 			do_action( 'frm_before_import_' . $file_type );
 
@@ -495,7 +495,7 @@ 
 		foreach ( $type as $tb_type ) {
 			$where = array();
 			$join  = '';
-			$table = $tables[ $tb_type ];
+			$table = $tables[$tb_type];
 
 			$select     = $table . '.id';
 			$query_vars = array();
@@ -510,7 +510,7 @@ 
 							$table . '.parent_form_id' => $args['ids'],
 						);
 					} else {
-						$where[ $table . '.status !' ] = 'draft';
+						$where[$table . '.status !'] = 'draft';
 					}
 					break;
 				case 'actions':
@@ -524,7 +524,7 @@ 
 				case 'items':
 					// $join = "INNER JOIN {$wpdb->prefix}frm_item_metas im ON ($table.id = im.item_id)";
 					if ( $args['ids'] ) {
-						$where[ $table . '.form_id' ] = $args['ids'];
+						$where[$table . '.form_id'] = $args['ids'];
 					}
 					break;
 				case 'styles':
@@ -568,7 +568,7 @@ 
 					}
 			}//end switch
 
-			$records[ $tb_type ] = FrmDb::get_col( $table . $join, $where, $select );
+			$records[$tb_type] = FrmDb::get_col( $table . $join, $where, $select );
 			unset( $tb_type );
 		}//end foreach
 
@@ -781,7 +781,7 @@ 
 
 		foreach ( $csv_fields as $k => $f ) {
 			if ( in_array( $f->type, $no_export_fields, true ) ) {
-				unset( $csv_fields[ $k ] );
+				unset( $csv_fields[$k] );
 			}
 		}
 

classes/controllers/FrmStylesController.php

Spacing +18 added lines, -18 removed lines

@@ -160,7 +160,7 @@ 
 			/**
 			 * Update the form data on the "Manage Styles" tab after global settings are saved.
 			 */
-			function () {
+			function() {
 				self::manage_styles();
 			}
 		);
@@ -347,7 +347,7 @@ 
 		$style_id = self::get_style_id_for_styler();
 
 		if ( ! $style_id ) {
-			$error_args   = array(
+			$error_args = array(
 				'title'      => __( 'No styles', 'formidable' ),
 				'body'       => __( 'You must have a style to use the Visual Styler.', 'formidable' ),
 				'cancel_url' => admin_url( 'admin.php?page=formidable' ),
@@ -365,7 +365,7 @@ 
 		$form = FrmForm::getOne( $form_id );
 
 		if ( ! is_object( $form ) ) {
-			$error_args   = array(
+			$error_args = array(
 				'title'      => __( 'No forms', 'formidable' ),
 				'body'       => __( 'You must have a form to use the Visual Styler.', 'formidable' ),
 				'cancel_url' => admin_url( 'admin.php?page=formidable' ),
@@ -442,7 +442,7 @@ 
 		if ( ! $form_id ) {
 			// TODO: Show a message why a random form is being shown (because no form is assigned to the style).
 			// Fallback to any form.
-			$where   = array(
+			$where = array(
 				'status'         => 'published',
 				// Make sure it's not a repeater.
 				'parent_form_id' => array( null, 0 ),
@@ -461,7 +461,7 @@ 
 	private static function disable_admin_page_styling_on_submit_buttons() {
 		add_filter(
 			'frm_submit_button_class',
-			function ( $classes ) {
+			function( $classes ) {
 				$classes[] = 'frm_no_style_button';
 				return $classes;
 			}
@@ -694,13 +694,13 @@ 
 	private static function force_form_style( $style ) {
 		add_filter(
 			'frm_add_form_style_class',
-			function ( $class ) use ( $style ) {
-				$split   = array_filter(
+			function( $class ) use ( $style ) {
+				$split = array_filter(
 					explode( ' ', $class ),
 					/**
 					 * @param string $class
 					 */
-					function ( $class ) {
+					function( $class ) {
 						return $class && 0 !== strpos( $class, 'frm_style_' );
 					}
 				);
@@ -828,11 +828,11 @@ 
 		$forms = FrmForm::get_published_forms();
 
 		foreach ( $forms as $form ) {
-			if ( ! isset( $_POST['style'] ) || ! isset( $_POST['style'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( ! isset( $_POST['style'] ) || ! isset( $_POST['style'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				continue;
 			}
 
-			$new_style = sanitize_text_field( wp_unslash( $_POST['style'][ $form->id ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$new_style = sanitize_text_field( wp_unslash( $_POST['style'][$form->id] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 
 			$form->options['custom_style'] = $new_style;
 			$wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $form->options ) ), array( 'id' => $form->id ) );
@@ -1261,8 +1261,8 @@ 
 	public static function get_style_val( $val, $form = 'default' ) {
 		$style = self::get_form_style( $form );
 
-		if ( $style && isset( $style->post_content[ $val ] ) ) {
-			return $style->post_content[ $val ];
+		if ( $style && isset( $style->post_content[$val] ) ) {
+			return $style->post_content[$val];
 		}
 	}
 
@@ -1287,7 +1287,7 @@ 
 			} elseif ( 'alt_bg_color' == $name ) {
 				$setting = 'bg_color_active';
 			}
-			$default_styles[ $name ] = $style->post_content[ $setting ];
+			$default_styles[$name] = $style->post_content[$setting];
 			unset( $name, $val );
 		}
 
@@ -1343,16 +1343,16 @@ 
 		$i          = 0;
 		$first_open = false;
 
-		if ( isset( $wp_meta_boxes[ $page ][ $context ] ) ) {
+		if ( isset( $wp_meta_boxes[$page][$context] ) ) {
 			foreach ( array( 'high', 'core', 'default', 'low' ) as $priority ) {
-				if ( isset( $wp_meta_boxes[ $page ][ $context ][ $priority ] ) ) {
-					foreach ( $wp_meta_boxes[ $page ][ $context ][ $priority ] as $box ) {
+				if ( isset( $wp_meta_boxes[$page][$context][$priority] ) ) {
+					foreach ( $wp_meta_boxes[$page][$context][$priority] as $box ) {
 						if ( false === $box || ! $box['title'] ) {
 							continue;
 						}
 
-						++$i;
-						$icon_id = array_key_exists( $box['id'], $icon_ids ) ? $icon_ids[ $box['id'] ] : 'frm-' . $box['id'];
+						++ $i;
+						$icon_id = array_key_exists( $box['id'], $icon_ids ) ? $icon_ids[$box['id']] : 'frm-' . $box['id'];
 
 						$open_class = '';
 

classes/controllers/FrmFormTemplatesController.php

Spacing +13 added lines, -15 removed lines

@@ -241,7 +241,7 @@ 
 					'description'        => esc_html__( 'Just add your email address and you\'ll get 30+ free form templates to your account.', 'formidable' ),
 					'submit_button_text' => esc_html_x( 'Get Templates', 'get free templates modal submit button text', 'formidable' ),
 				);
-				$view_parts[]     = 'modals/leave-email-modal.php';
+				$view_parts[] = 'modals/leave-email-modal.php';
 			}
 
 			// Add 'upgrade' modal view for non-elite users.
@@ -340,12 +340,12 @@ 
 
 		// Perform add or remove operation.
 		if ( 'add' === $operation ) {
-			self::$favorite_templates[ $key ][] = $template_id;
+			self::$favorite_templates[$key][] = $template_id;
 		} elseif ( 'remove' === $operation ) {
-			$position = array_search( $template_id, self::$favorite_templates[ $key ], true );
+			$position = array_search( $template_id, self::$favorite_templates[$key], true );
 
 			if ( $position !== false ) {
-				unset( self::$favorite_templates[ $key ][ $position ] );
+				unset( self::$favorite_templates[$key][$position] );
 			}
 		}
 
@@ -503,7 +503,7 @@ 
 		foreach ( self::$templates as $key => &$template ) {
 			// Skip the template if the categories are not set.
 			if ( ! isset( $template['categories'] ) || ! isset( $template['id'] ) ) {
-				unset( self::$templates[ $key ] );
+				unset( self::$templates[$key] );
 				continue;
 			}
 
@@ -517,14 +517,12 @@ 
 				// Add the slug to the new array.
 				$template['category_slugs'][] = $category_slug;
 
-				if ( ! isset( self::$categories[ $category_slug ] ) ) {
-					self::$categories[ $category_slug ] = array(
+				if ( ! isset( self::$categories[$category_slug] ) ) {
+					self::$categories[$category_slug] = array(
 						'name'  => $category,
 						'count' => 0,
 					);
-				}
-
-				++self::$categories[ $category_slug ]['count'];
+				} ++self::$categories[$category_slug]['count'];
 			}
 
 			// Mark the template as favorite if it's in the favorite templates list.
@@ -540,7 +538,7 @@ 
 
 		foreach ( $redundant_cats as $redundant_cat ) {
 			$category_slug = sanitize_title( $redundant_cat );
-			unset( self::$categories[ $category_slug ] );
+			unset( self::$categories[$category_slug] );
 		}
 
 		// Sort the categories by keys alphabetically.
@@ -566,7 +564,7 @@ 
 				'count' => 0,
 			);
 		}
-		$special_categories['all-items']      = array(
+		$special_categories['all-items'] = array(
 			'name'  => __( 'All Templates', 'formidable' ),
 			'count' => self::get_template_count(),
 		);
@@ -589,9 +587,9 @@ 
 	 */
 	private static function assign_featured_templates() {
 		foreach ( self::FEATURED_TEMPLATES_IDS as $key ) {
-			if ( isset( self::$templates[ $key ] ) ) {
-				self::$templates[ $key ]['is_featured'] = true;
-				self::$featured_templates[]             = self::$templates[ $key ];
+			if ( isset( self::$templates[$key] ) ) {
+				self::$templates[$key]['is_featured'] = true;
+				self::$featured_templates[]             = self::$templates[$key];
 			}
 		}
 	}

classes/controllers/FrmDashboardController.php

Spacing +4 added lines, -4 removed lines

@@ -443,7 +443,7 @@ 
 		foreach ( $data as $key => $messages ) {
 			if ( in_array( $key, array( 'unread', 'dismissed' ), true ) ) {
 				foreach ( $messages as $key_msg => $message ) {
-					$data[ $key ][ $key_msg ]['cta'] = self::inbox_clean_messages_cta( $message['cta'] );
+					$data[$key][$key_msg]['cta'] = self::inbox_clean_messages_cta( $message['cta'] );
 				}
 			}
 		}
@@ -536,12 +536,12 @@ 
 	private static function get_dashboard_options( $option_name = null ) {
 		$options = get_option( self::OPTION_META_NAME, array() );
 
-		if ( null !== $option_name && ! isset( $options[ $option_name ] ) ) {
+		if ( null !== $option_name && ! isset( $options[$option_name] ) ) {
 			return array();
 		}
 
 		if ( null !== $option_name ) {
-			return $options[ $option_name ];
+			return $options[$option_name];
 		}
 		return $options;
 	}
@@ -556,7 +556,7 @@ 
 	 */
 	private static function update_dashboard_options( $data, $option_name ) {
 		$options                 = self::get_dashboard_options();
-		$options[ $option_name ] = $data;
+		$options[$option_name] = $data;
 		update_option( self::OPTION_META_NAME, $options, 'no' );
 	}
 

classes/controllers/FrmAddonsController.php

Spacing +26 added lines, -28 removed lines

@@ -119,7 +119,7 @@ 
 				'<span class="frm-upgrade-submenu">' . esc_html( $cta_text ) . '</span>',
 				'frm_view_forms',
 				'formidable-pro-upgrade',
-				function () {
+				function() {
 					// This function doesn't need to do anything.
 					// The redirect is handled earlier to avoid issues with the headers being sent.
 				}
@@ -150,7 +150,7 @@ 
 			unset( $addons['error'] );
 		}
 
-		$pro    = array(
+		$pro = array(
 			'pro' => array(
 				'title'      => 'Formidable Forms Pro',
 				'slug'       => 'formidable-pro',
@@ -192,9 +192,9 @@ 
 
 		// Extract the elements to move
 		foreach ( $plans as $plan ) {
-			if ( isset( self::$categories[ $plan ] ) ) {
-				$bottom_categories[ $plan ] = self::$categories[ $plan ];
-				unset( self::$categories[ $plan ] );
+			if ( isset( self::$categories[$plan] ) ) {
+				$bottom_categories[$plan] = self::$categories[$plan];
+				unset( self::$categories[$plan] );
 			}
 		}
 
@@ -250,14 +250,12 @@ 
 			// Add the slug to the new array.
 			$addon['category-slugs'][] = $category_slug;
 
-			if ( ! isset( self::$categories[ $category_slug ] ) ) {
-				self::$categories[ $category_slug ] = array(
+			if ( ! isset( self::$categories[$category_slug] ) ) {
+				self::$categories[$category_slug] = array(
 					'name'  => $category,
 					'count' => 0,
 				);
-			}
-
-			++self::$categories[ $category_slug ]['count'];
+			} ++self::$categories[$category_slug]['count'];
 		}
 	}
 
@@ -290,7 +288,7 @@ 
 		} else {
 			foreach ( $addons as $k => $addon ) {
 				if ( empty( $addon['excerpt'] ) && $k !== 'error' ) {
-					unset( $addons[ $k ] );
+					unset( $addons[$k] );
 				}
 			}
 		}
@@ -405,7 +403,7 @@ 
 
 		foreach ( $list as $k => $info ) {
 			$info['slug'] = $k;
-			$list[ $k ]   = array_merge( $defaults, $info );
+			$list[$k]   = array_merge( $defaults, $info );
 		}
 		return $list;
 	}
@@ -575,17 +573,17 @@ 
 				continue;
 			}
 
-			$wp_plugin    = $wp_plugins[ $folder ] ?? array();
+			$wp_plugin    = $wp_plugins[$folder] ?? array();
 			$wp_version   = $wp_plugin['Version'] ?? '1.0';
 			$plugin->slug = explode( '/', $folder )[0];
 
 			if ( version_compare( $wp_version, $plugin->new_version, '<' ) ) {
-				$transient->response[ $folder ] = $plugin;
+				$transient->response[$folder] = $plugin;
 			} else {
-				$transient->no_update[ $folder ] = $plugin;
+				$transient->no_update[$folder] = $plugin;
 			}
 
-			$transient->checked[ $folder ] = $wp_version;
+			$transient->checked[$folder] = $wp_version;
 
 		}//end foreach
 
@@ -619,7 +617,7 @@ 
 	 */
 	protected static function is_installed( $plugin ) {
 		$all_plugins = self::get_plugins();
-		return isset( $all_plugins[ $plugin ] );
+		return isset( $all_plugins[$plugin] );
 	}
 
 	/**
@@ -662,14 +660,14 @@ 
 
 			$download_id = $plugin['id'] ?? 0;
 
-			if ( ! empty( $download_id ) && ! isset( $version_info[ $download_id ]['package'] ) ) {
+			if ( ! empty( $download_id ) && ! isset( $version_info[$download_id]['package'] ) ) {
 				// if this addon is using its own license, get the update url
 				$addon_info = $api->get_api_info();
 
-				$version_info[ $download_id ] = $addon_info[ $download_id ];
+				$version_info[$download_id] = $addon_info[$download_id];
 
 				if ( isset( $addon_info['error'] ) ) {
-					$version_info[ $download_id ]['error'] = array(
+					$version_info[$download_id]['error'] = array(
 						'message' => $addon_info['error']['message'],
 						'code'    => $addon_info['error']['code'],
 					);
@@ -777,8 +775,8 @@ 
 					return $addon;
 				}
 			}
-		} elseif ( isset( $addons[ $download_id ] ) ) {
-			$plugin = $addons[ $download_id ];
+		} elseif ( isset( $addons[$download_id] ) ) {
+			$plugin = $addons[$download_id];
 		}
 
 		return $plugin;
@@ -853,7 +851,7 @@ 
 			self::set_addon_status( $addon );
 			self::set_categories( $addon );
 
-			$addons[ $id ] = $addon;
+			$addons[$id] = $addon;
 		}//end foreach
 	}
 
@@ -896,7 +894,7 @@ 
 			$link = $site_url . $link;
 		}
 
-		$link       = FrmAppHelper::make_affiliate_url( $link );
+		$link = FrmAppHelper::make_affiliate_url( $link );
 
 		$utm  = array(
 			'campaign' => 'addons',
@@ -1128,7 +1126,7 @@ 
 	 */
 	public static function ajax_activate_addon() {
 		self::process_addon_action(
-			function ( $plugin ) {
+			function( $plugin ) {
 				return self::handle_addon_action( $plugin, 'activate' );
 			},
 			array( 'FrmAddonsController', 'get_addon_activation_response' )
@@ -1153,7 +1151,7 @@ 
 	 */
 	public static function ajax_deactivate_addon() {
 		self::process_addon_action(
-			function ( $plugin ) {
+			function( $plugin ) {
 				return self::handle_addon_action( $plugin, 'deactivate' );
 			}
 		);
@@ -1168,7 +1166,7 @@ 
 	 */
 	public static function ajax_uninstall_addon() {
 		self::process_addon_action(
-			function ( $plugin ) {
+			function( $plugin ) {
 				return self::handle_addon_action( $plugin, 'uninstall' );
 			}
 		);
@@ -1582,7 +1580,7 @@ 
 		$addons = $api->get_api_info();
 
 		if ( is_array( $addons ) && array_key_exists( $addon_id, $addons ) ) {
-			$dates    = $addons[ $addon_id ];
+			$dates    = $addons[$addon_id];
 			$requires = FrmFormsHelper::get_plan_required( $dates );
 		}
 

classes/controllers/FrmEmailStylesController.php

Spacing +2 added lines, -2 removed lines

@@ -96,7 +96,7 @@ 
 		$styles = self::get_email_styles();
 		$style  = $frm_settings->email_style;
 
-		if ( isset( $styles[ $style ] ) && ! empty( $styles[ $style ]['selectable'] ) ) {
+		if ( isset( $styles[$style] ) && ! empty( $styles[$style]['selectable'] ) ) {
 			return $style;
 		}
 
@@ -278,7 +278,7 @@ 
 
 		$styles = self::get_email_styles();
 
-		if ( ! isset( $styles[ $style_key ] ) ) {
+		if ( ! isset( $styles[$style_key] ) ) {
 			die( esc_html( $not_exist_msg ) );
 		}
 

classes/views/shared/errors.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 
 if ( is_array( $show_messages ) && count( $show_messages ) > 0 ) {
 	// Define a callback function to add 'data-action' attribute to allowed HTML tags
-	$add_data_action_callback = function ( $allowed_html ) {
+	$add_data_action_callback = function( $allowed_html ) {
 		$allowed_html['span']['data-action'] = true;
 		return $allowed_html;
 	};

classes/views/frm-form-actions/_action_inside.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 
 	foreach ( $action_control->action_options['event'] as $event ) {
 		?>
-		<option value="<?php echo esc_attr( $event ); ?>" <?php echo in_array( $event, (array) $form_action->post_content['event'] ) ? ' selected="selected"' : ''; ?> ><?php echo esc_html( $event_labels[ $event ] ?? $event ); ?></option>
+		<option value="<?php echo esc_attr( $event ); ?>" <?php echo in_array( $event, (array) $form_action->post_content['event'] ) ? ' selected="selected"' : ''; ?> ><?php echo esc_html( $event_labels[$event] ?? $event ); ?></option>
 <?php } ?>
 		</select>
 	</p>

classes/views/frm-forms/form.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 			$values['count'] = 0;
 
 			foreach ( $values['fields'] as $field ) {
-				++$values['count'];
+				++ $values['count'];
 				$grid_helper->set_field( $field );
 				$grid_helper->maybe_begin_field_wrapper();
 				FrmFieldsController::load_single_field( $field, $values );