Strategy11 / formidable-forms

classes/models/FrmEntry.php

Doc Comments +4 added lines

@@ -202,6 +202,7 @@ 
 	 *
 	 * @param int $id
 	 * @param array $values
+	 * @param string $update_type
 	 *
 	 * @return boolean|int $query_results
 	 */
@@ -612,6 +613,9 @@ 
 		return $new_values;
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private static function get_entry_value( $values, $name, $default ) {
 		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
 	}

Spacing +14 added lines, -14 removed lines

@@ -76,7 +76,7 @@ 
 			$metas       = FrmEntryMeta::get_entry_meta_info( $entry_exist );
 			$field_metas = array();
 			foreach ( $metas as $meta ) {
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
+				$field_metas[$meta->field_id] = $meta->meta_value;
 			}
 
 			// If prev entry is empty and current entry is not, they are not duplicates
@@ -303,7 +303,7 @@ 
 		$query = "SELECT it.*, fr.name as form_name, fr.form_key as form_key FROM {$wpdb->prefix}frm_items it
                   LEFT OUTER JOIN {$wpdb->prefix}frm_forms fr ON it.form_id=fr.id WHERE ";
 
-		$query      .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s';
+		$query .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s';
 		$query_args = array( $id );
 		$query      = $wpdb->prepare( $query, $query_args ); // WPCS: unprepared SQL ok.
 
@@ -344,19 +344,19 @@ 
 		$include_key = apply_filters( 'frm_include_meta_keys', false, array( 'form_id' => $entry->form_id ) );
 		foreach ( $metas as $meta_val ) {
 			if ( $meta_val->item_id == $entry->id ) {
-				$entry->metas[ $meta_val->field_id ] = maybe_unserialize( $meta_val->meta_value );
+				$entry->metas[$meta_val->field_id] = maybe_unserialize( $meta_val->meta_value );
 				if ( $include_key ) {
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
 				}
 				continue;
 			}
 
 			// include sub entries in an array
-			if ( ! isset( $entry_metas[ $meta_val->field_id ] ) ) {
-				$entry->metas[ $meta_val->field_id ] = array();
+			if ( ! isset( $entry_metas[$meta_val->field_id] ) ) {
+				$entry->metas[$meta_val->field_id] = array();
 			}
 
-			$entry->metas[ $meta_val->field_id ][] = maybe_unserialize( $meta_val->meta_value );
+			$entry->metas[$meta_val->field_id][] = maybe_unserialize( $meta_val->meta_value );
 
 			unset( $meta_val );
 		}
@@ -403,13 +403,13 @@ 
 
 			if ( $inc_form ) {
 				$fields = 'it.*, fr.name as form_name,fr.form_key as form_key';
-				$table  .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id ';
+				$table .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id ';
 			}
 
 			if ( preg_match( '/ meta_([0-9]+)/', $order_by, $order_matches ) ) {
 				// sort by a requested field
 				$field_id = (int) $order_matches[1];
-				$fields   .= ', (SELECT meta_value FROM ' . $wpdb->prefix . 'frm_item_metas WHERE field_id = ' . $field_id . ' AND item_id = it.id) as meta_' . $field_id;
+				$fields .= ', (SELECT meta_value FROM ' . $wpdb->prefix . 'frm_item_metas WHERE field_id = ' . $field_id . ' AND item_id = it.id) as meta_' . $field_id;
 				unset( $order_matches, $field_id );
 			}
 
@@ -447,15 +447,15 @@ 
 		}
 
 		foreach ( $metas as $m_key => $meta_val ) {
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
 				continue;
 			}
 
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
-				$entries[ $meta_val->item_id ]->metas = array();
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
+				$entries[$meta_val->item_id]->metas = array();
 			}
 
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = maybe_unserialize( $meta_val->meta_value );
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = maybe_unserialize( $meta_val->meta_value );
 
 			unset( $m_key, $meta_val );
 		}
@@ -613,7 +613,7 @@ 
 	}
 
 	private static function get_entry_value( $values, $name, $default ) {
-		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
+		return isset( $values[$name] ) ? $values[$name] : $default;
 	}
 
 	/**

classes/models/FrmEntryMeta.php

Doc Comments +1 added lines

@@ -338,6 +338,7 @@
 	 * @param string|array $where
 	 * @param string $order_by
 	 * @param string $limit
+	 * @param boolean $unique
 	 */
 	private static function get_ids_query( $where, $order_by, $limit, $unique, $args, array &$query ) {
 		global $wpdb;

Spacing +10 added lines, -10 removed lines

@@ -54,7 +54,7 @@ 
 
 		global $wpdb;
 
-		$values               = array(
+		$values = array(
 			'item_id'  => $entry_id,
 			'field_id' => $field_id,
 		);
@@ -128,7 +128,7 @@ 
 
 				if ( ( is_array( $meta_value ) && empty( $meta_value ) ) || ( ! is_array( $meta_value ) && trim( $meta_value ) == '' ) ) {
 					// remove blank fields
-					unset( $values[ $field_id ] );
+					unset( $values[$field_id] );
 				} else {
 					// if value exists, then update it
 					self::update_entry_meta( $entry_id, $field_id, '', $meta_value );
@@ -193,7 +193,7 @@ 
 	 */
 	public static function get_meta_value( $entry, $field_id ) {
 		if ( isset( $entry->metas ) ) {
-			return isset( $entry->metas[ $field_id ] ) ? $entry->metas[ $field_id ] : false;
+			return isset( $entry->metas[$field_id] ) ? $entry->metas[$field_id] : false;
 		} else {
 			return self::get_entry_meta_by_field( $entry->id, $field_id );
 		}
@@ -211,8 +211,8 @@ 
 			$cached   = FrmDb::check_cache( $entry_id, 'frm_entry' );
 		}
 
-		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[ $field_id ] ) ) {
-			$result = $cached->metas[ $field_id ];
+		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[$field_id] ) ) {
+			$result = $cached->metas[$field_id];
 
 			return stripslashes_deep( $result );
 		}
@@ -222,7 +222,7 @@ 
 		if ( is_numeric( $field_id ) ) {
 			$query['field_id'] = $field_id;
 		} else {
-			$get_table             .= ' it LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_fields fi ON it.field_id=fi.id';
+			$get_table .= ' it LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_fields fi ON it.field_id=fi.id';
 			$query['fi.field_key'] = $field_id;
 		}
 
@@ -240,7 +240,7 @@ 
 			'stripslashes' => true,
 			'is_draft'     => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$query = array();
 		self::meta_field_query( $field_id, $order, $limit, $args, $query );
@@ -254,7 +254,7 @@ 
 		}
 
 		foreach ( $values as $k => $v ) {
-			$values[ $k ] = maybe_unserialize( $v );
+			$values[$k] = maybe_unserialize( $v );
 			unset( $k, $v );
 		}
 
@@ -310,7 +310,7 @@ 
 		}
 
 		foreach ( $results as $k => $result ) {
-			$results[ $k ]->meta_value = stripslashes_deep( maybe_unserialize( $result->meta_value ) );
+			$results[$k]->meta_value = stripslashes_deep( maybe_unserialize( $result->meta_value ) );
 			unset( $k, $result );
 		}
 
@@ -323,7 +323,7 @@ 
 			'user_id'  => '',
 			'group_by' => '',
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$query = array();
 		self::get_ids_query( $where, $order_by, $limit, $unique, $args, $query );

classes/models/FrmFieldOption.php

Doc Comments +4 added lines

@@ -31,6 +31,10 @@
 	 */
 	protected $option_label = '';
 
+	/**
+	 * @param string $option_key
+	 * @param string $option
+	 */
 	public function __construct( $option_key, $option, $args = array() ) {
 		$this->option_key = $option_key;
 		$this->option     = $option;

classes/models/FrmFormMigrator.php

Doc Comments +14 added lines

@@ -152,6 +152,9 @@ 
 		return $this->add_form( $form );
 	}
 
+	/**
+	 * @param string $source_form_name
+	 */
 	protected function prepare_new_form( $source_id, $source_form_name ) {
 		return array(
 			'import_form_id' => $source_id,
@@ -201,6 +204,11 @@ 
 		// customize this function
 	}
 
+	/**
+	 * @param string $type
+	 *
+	 * @return string
+	 */
 	protected function convert_field_type( $type ) {
 		return $type;
 	}
@@ -314,6 +322,9 @@ 
 		return array();
 	}
 
+	/**
+	 * @param string $type
+	 */
 	private function is_unsupported_field( $type ) {
 		$fields = $this->unsupported_field_types();
 
@@ -329,6 +340,9 @@ 
 		return array();
 	}
 
+	/**
+	 * @param string $type
+	 */
 	private function should_skip_field( $type ) {
 		$skip_pro_fields = $this->skip_pro_fields();
 

Spacing +5 added lines, -5 removed lines

@@ -236,7 +236,7 @@ 
 
 		foreach ( $form['fields'] as $key => $new_field ) {
 			$new_field['form_id']         = $form_id;
-			$form['fields'][ $key ]['id'] = FrmField::create( $new_field );
+			$form['fields'][$key]['id'] = FrmField::create( $new_field );
 		}
 
 		// create emails
@@ -248,7 +248,7 @@ 
 				if ( $key === 'post_title' ) {
 					$new_action->post_title = $value;
 				} else {
-					$new_action->post_content[ $key ] = $this->replace_smart_tags( $value, $form['fields'] );
+					$new_action->post_content[$key] = $this->replace_smart_tags( $value, $form['fields'] );
 				}
 			}
 
@@ -278,7 +278,7 @@ 
 
 		$imported = $this->get_tracked_import();
 
-		$imported[ $this->slug ][ $new_form_id ] = $source_id;
+		$imported[$this->slug][$new_form_id] = $source_id;
 
 		update_option( $this->tracking, $imported, false );
 	}
@@ -298,8 +298,8 @@ 
 	private function is_imported( $source_id ) {
 		$imported    = $this->get_tracked_import();
 		$new_form_id = 0;
-		if ( isset( $imported[ $this->slug ] ) && in_array( $source_id, $imported[ $this->slug ] ) ) {
-			$new_form_id = array_search( $source_id, array_reverse( $imported[ $this->slug ], true ) );
+		if ( isset( $imported[$this->slug] ) && in_array( $source_id, $imported[$this->slug] ) ) {
+			$new_form_id = array_search( $source_id, array_reverse( $imported[$this->slug], true ) );
 		}
 
 		return $new_form_id;

classes/models/FrmReviews.php

Doc Comments -1 removed lines

@@ -63,7 +63,6 @@
 	 *
 	 * @since 3.04.03
 	 *
-	 * @param int $asked
 	 */
 	private function review() {
 

Spacing +2 added lines, -2 removed lines

@@ -71,12 +71,12 @@
 		$show_intervals = array( 50, 200, 500 );
 		$asked          = $this->review_status['asked'];
 
-		if ( ! isset( $show_intervals[ $asked ] ) ) {
+		if ( ! isset( $show_intervals[$asked] ) ) {
 			return;
 		}
 
 		$entries = FrmEntry::getRecordCount();
-		$count   = $show_intervals[ $asked ];
+		$count   = $show_intervals[$asked];
 		$user    = wp_get_current_user();
 
 		// Only show review request if the site has collected enough entries

classes/models/FrmStyle.php

Doc Comments +4 added lines, -1 removed lines

@@ -5,7 +5,7 @@ 
 	public $id = 0; // the id of the post
 
 	/**
-	 * @param int|string $id The id of the stylsheet or 'default'
+	 * @param integer $id The id of the stylsheet or 'default'
 	 */
 	public function __construct( $id = 0 ) {
 		$this->id = $id;
@@ -150,6 +150,9 @@ 
 		set_transient( 'frmpro_css', $css, MONTH_IN_SECONDS );
 	}
 
+	/**
+	 * @param string $filename
+	 */
 	private function get_css_content( $filename ) {
 		$css = '/* ' . __( 'WARNING: Any changes made to this file will be lost when your Formidable settings are updated', 'formidable' ) . ' */' . "\n";
 

Spacing +10 added lines, -10 removed lines

@@ -53,7 +53,7 @@ 
 			$new_instance = stripslashes_deep( (array) $new_instance );
 			$this->id     = $new_instance['ID'];
 			if ( $id != $this->id || ! $_POST || ! isset( $_POST['frm_style_setting'] ) ) {
-				$all_instances[ $number ] = $new_instance;
+				$all_instances[$number] = $new_instance;
 
 				if ( $new_instance['menu_order'] && $_POST && empty( $_POST['prev_menu_order'] ) && isset( $_POST['frm_style_setting']['menu_order'] ) ) {
 					// this style was set to default, so remove default setting on previous default style
@@ -78,22 +78,22 @@ 
 			$default_settings = $this->get_defaults();
 
 			foreach ( $default_settings as $setting => $default ) {
-				if ( ! isset( $new_instance['post_content'][ $setting ] ) ) {
-					$new_instance['post_content'][ $setting ] = $default;
+				if ( ! isset( $new_instance['post_content'][$setting] ) ) {
+					$new_instance['post_content'][$setting] = $default;
 				}
 
 				if ( $this->is_color( $setting ) ) {
-					$new_instance['post_content'][ $setting ] = str_replace( '#', '', $new_instance['post_content'][ $setting ] );
+					$new_instance['post_content'][$setting] = str_replace( '#', '', $new_instance['post_content'][$setting] );
 				} elseif ( in_array( $setting, array( 'submit_style', 'important_style', 'auto_width' ) )
-					&& ! isset( $new_instance['post_content'][ $setting ] )
+					&& ! isset( $new_instance['post_content'][$setting] )
 					) {
-					$new_instance['post_content'][ $setting ] = 0;
+					$new_instance['post_content'][$setting] = 0;
 				} elseif ( $setting == 'font' ) {
-					$new_instance['post_content'][ $setting ] = $this->force_balanced_quotation( $new_instance['post_content'][ $setting ] );
+					$new_instance['post_content'][$setting] = $this->force_balanced_quotation( $new_instance['post_content'][$setting] );
 				}
 			}
 
-			$all_instances[ $number ] = $new_instance;
+			$all_instances[$number] = $new_instance;
 
 			$action_ids[] = $this->save( $new_instance );
 
@@ -265,13 +265,13 @@ 
 			$style->post_content = $this->override_defaults( $style->post_content );
 			$style->post_content = wp_parse_args( $style->post_content, $default_values );
 
-			$styles[ $style->ID ] = $style;
+			$styles[$style->ID] = $style;
 		}
 
 		if ( ! $default_style ) {
 			$default_style = reset( $styles );
 
-			$styles[ $default_style->ID ]->menu_order = 1;
+			$styles[$default_style->ID]->menu_order = 1;
 		}
 
 		return $styles;

classes/models/fields/FrmFieldEmail.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 	public function validate( $args ) {
 		$errors = array();
 		if ( $args['value'] != '' && ! is_email( $args['value'] ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
 		}
 
 		return $errors;

classes/models/fields/FrmFieldUrl.php

Spacing +3 added lines, -3 removed lines

@@ -39,7 +39,7 @@ 
 			'sep'  => ', ',
 			'html' => false,
 		);
-		$atts     = wp_parse_args( $atts, $defaults );
+		$atts = wp_parse_args( $atts, $defaults );
 
 		if ( $atts['html'] ) {
 			$atts['sep'] = ' ';
@@ -61,9 +61,9 @@ 
 
 		// validate the url format
 		if ( ! empty( $value ) && ! preg_match( '/^http(s)?:\/\/(?:localhost|(?:[\da-z\.-]+\.[\da-z\.-]+))/i', $value ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
 		} elseif ( $this->field->required == '1' && empty( $value ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'blank' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'blank' );
 		}
 
 		return $errors;

classes/models/fields/FrmFieldUserID.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 
 		$user_ID      = get_current_user_id();
 		$user_ID      = ( $user_ID ? $user_ID : '' );
-		$posted_value = ( FrmAppHelper::is_admin() && $_POST && isset( $_POST['item_meta'][ $this->field['id'] ] ) ); // WPCS: CSRF ok.
+		$posted_value = ( FrmAppHelper::is_admin() && $_POST && isset( $_POST['item_meta'][$this->field['id']] ) ); // WPCS: CSRF ok.
 		$updating     = ( isset( $args['action'] ) && $args['action'] == 'update' );
 		$value        = ( is_numeric( $this->field['value'] ) || $posted_value || $updating ) ? $this->field['value'] : $user_ID;