Completed
Pull Request — master (#2266)
by
unknown
52s
created
classes/helpers/FrmOnSubmitHelper.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -329,17 +329,17 @@  discard block
 block discarded – undo
329 329
 	public static function populate_on_submit_data( &$form_options, $action = null, $event = 'create' ) {
330 330
 		$opt = 'update' === $event ? 'edit_' : 'success_';
331 331
 		if ( ! $action || ! is_object( $action ) ) {
332
-			$form_options[ $opt . 'action' ] = self::get_default_action_type();
333
-			$form_options[ $opt . 'msg' ]    = self::get_default_msg();
332
+			$form_options[$opt . 'action'] = self::get_default_action_type();
333
+			$form_options[$opt . 'msg']    = self::get_default_msg();
334 334
 
335 335
 			return;
336 336
 		}
337 337
 
338
-		$form_options[ $opt . 'action' ] = isset( $action->post_content['success_action'] ) ? $action->post_content['success_action'] : 'message';
338
+		$form_options[$opt . 'action'] = isset( $action->post_content['success_action'] ) ? $action->post_content['success_action'] : 'message';
339 339
 
340
-		switch ( $form_options[ $opt . 'action' ] ) {
340
+		switch ( $form_options[$opt . 'action'] ) {
341 341
 			case 'redirect':
342
-				$form_options[ $opt . 'url' ]        = isset( $action->post_content['success_url'] ) ? $action->post_content['success_url'] : '';
342
+				$form_options[$opt . 'url']        = isset( $action->post_content['success_url'] ) ? $action->post_content['success_url'] : '';
343 343
 				$form_options['open_in_new_tab']     = ! empty( $action->post_content['open_in_new_tab'] );
344 344
 				$form_options['redirect_delay']      = ! empty( $action->post_content['redirect_delay'] );
345 345
 				$form_options['redirect_delay_time'] = $action->post_content['redirect_delay_time'];
@@ -347,11 +347,11 @@  discard block
 block discarded – undo
347 347
 				break;
348 348
 
349 349
 			case 'page':
350
-				$form_options[ $opt . 'page_id' ] = isset( $action->post_content['success_page_id'] ) ? $action->post_content['success_page_id'] : '';
350
+				$form_options[$opt . 'page_id'] = isset( $action->post_content['success_page_id'] ) ? $action->post_content['success_page_id'] : '';
351 351
 				break;
352 352
 
353 353
 			default:
354
-				$form_options[ $opt . 'msg' ] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : self::get_default_msg();
354
+				$form_options[$opt . 'msg'] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : self::get_default_msg();
355 355
 				$form_options['show_form']    = ! empty( $action->post_content['show_form'] );
356 356
 		}
357 357
 	}
@@ -440,20 +440,20 @@  discard block
 block discarded – undo
440 440
 	private static function get_on_submit_action_data_from_form_options( $form_options, $event = 'create' ) {
441 441
 		$opt  = 'update' === $event ? 'edit_' : 'success_';
442 442
 		$data = array(
443
-			'success_action' => isset( $form_options[ $opt . 'action' ] ) ? $form_options[ $opt . 'action' ] : self::get_default_action_type(),
443
+			'success_action' => isset( $form_options[$opt . 'action'] ) ? $form_options[$opt . 'action'] : self::get_default_action_type(),
444 444
 		);
445 445
 
446 446
 		switch ( $data['success_action'] ) {
447 447
 			case 'redirect':
448
-				$data['success_url'] = isset( $form_options[ $opt . 'url' ] ) ? $form_options[ $opt . 'url' ] : '';
448
+				$data['success_url'] = isset( $form_options[$opt . 'url'] ) ? $form_options[$opt . 'url'] : '';
449 449
 				break;
450 450
 
451 451
 			case 'page':
452
-				$data['success_page_id'] = isset( $form_options[ $opt . 'page_id' ] ) ? $form_options[ $opt . 'page_id' ] : '';
452
+				$data['success_page_id'] = isset( $form_options[$opt . 'page_id'] ) ? $form_options[$opt . 'page_id'] : '';
453 453
 				break;
454 454
 
455 455
 			default:
456
-				$data['success_msg'] = isset( $form_options[ $opt . 'msg' ] ) ? $form_options[ $opt . 'msg' ] : self::get_default_msg();
456
+				$data['success_msg'] = isset( $form_options[$opt . 'msg'] ) ? $form_options[$opt . 'msg'] : self::get_default_msg();
457 457
 				$data['show_form']   = ! empty( $form_options['show_form'] );
458 458
 		}
459 459
 
Please login to merge, or discard this patch.
classes/models/FrmEntry.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -54,8 +54,8 @@  discard block
 block discarded – undo
54 54
 	 * @return void
55 55
 	 */
56 56
 	private static function flag_new_unique_key( $unique_id ) {
57
-		if ( ! isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
58
-			self::$unique_id_match_checks[ $unique_id ] = false;
57
+		if ( ! isset( self::$unique_id_match_checks[$unique_id] ) ) {
58
+			self::$unique_id_match_checks[$unique_id] = false;
59 59
 		}
60 60
 	}
61 61
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 				if ( 0 === (int) $meta->field_id ) {
108 108
 					continue;
109 109
 				}
110
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
110
+				$field_metas[$meta->field_id] = $meta->meta_value;
111 111
 			}
112 112
 
113 113
 			$filtered_vals = array_filter( $values['item_meta'] );
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
172 172
 			return false;
173 173
 		}
174 174
 
175
-		if ( isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
176
-			return self::$unique_id_match_checks[ $unique_id ];
175
+		if ( isset( self::$unique_id_match_checks[$unique_id] ) ) {
176
+			return self::$unique_id_match_checks[$unique_id];
177 177
 		}
178 178
 
179 179
 		$timestamp = strtotime( $created_at );
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 			$timestamp = time();
182 182
 		}
183 183
 
184
-		self::$unique_id_match_checks[ $unique_id ] = (bool) FrmDb::get_var(
184
+		self::$unique_id_match_checks[$unique_id] = (bool) FrmDb::get_var(
185 185
 			'frm_item_metas',
186 186
 			array(
187 187
 				'field_id'     => 0,
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 			'id'
192 192
 		);
193 193
 
194
-		return self::$unique_id_match_checks[ $unique_id ];
194
+		return self::$unique_id_match_checks[$unique_id];
195 195
 	}
196 196
 
197 197
 	/**
@@ -221,10 +221,10 @@  discard block
 block discarded – undo
221 221
 		$reduced = array();
222 222
 		foreach ( $filter_vals as $field_id => $value ) {
223 223
 			$field                = FrmFieldFactory::get_field_object( $field_id );
224
-			$reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
225
-			$reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] );
226
-			if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) {
227
-				unset( $reduced[ $field_id ] );
224
+			$reduced[$field_id] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
225
+			$reduced[$field_id] = $field->set_value_before_save( $reduced[$field_id] );
226
+			if ( '' === $reduced[$field_id] || ( is_array( $reduced[$field_id] ) && 0 === count( $reduced[$field_id] ) ) ) {
227
+				unset( $reduced[$field_id] );
228 228
 			}
229 229
 		}
230 230
 		return $reduced;
@@ -487,7 +487,7 @@  discard block
 block discarded – undo
487 487
 	private static function prepare_entries( &$entries ) {
488 488
 		foreach ( $entries as $k => $entry ) {
489 489
 			self::prepare_entry( $entry );
490
-			$entries[ $k ] = $entry;
490
+			$entries[$k] = $entry;
491 491
 		}
492 492
 	}
493 493
 
@@ -513,19 +513,19 @@  discard block
 block discarded – undo
513 513
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
514 514
 
515 515
 			if ( $meta_val->item_id == $entry->id ) {
516
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
516
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
517 517
 				if ( $include_key ) {
518
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
518
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
519 519
 				}
520 520
 				continue;
521 521
 			}
522 522
 
523 523
 			// include sub entries in an array
524
-			if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) {
525
-				$entry->metas[ $meta_val->field_id ] = array();
524
+			if ( ! isset( $entry->metas[$meta_val->field_id] ) ) {
525
+				$entry->metas[$meta_val->field_id] = array();
526 526
 			}
527 527
 
528
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
528
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
529 529
 
530 530
 			unset( $meta_val );
531 531
 		}
@@ -620,16 +620,16 @@  discard block
 block discarded – undo
620 620
 		}
621 621
 
622 622
 		foreach ( $metas as $m_key => $meta_val ) {
623
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
623
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
624 624
 				continue;
625 625
 			}
626 626
 
627
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
628
-				$entries[ $meta_val->item_id ]->metas = array();
627
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
628
+				$entries[$meta_val->item_id]->metas = array();
629 629
 			}
630 630
 
631 631
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
632
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
632
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
633 633
 			unset( $m_key, $meta_val );
634 634
 		}
635 635
 
@@ -812,7 +812,7 @@  discard block
 block discarded – undo
812 812
 	}
813 813
 
814 814
 	private static function get_entry_value( $values, $name, $default ) {
815
-		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
815
+		return isset( $values[$name] ) ? $values[$name] : $default;
816 816
 	}
817 817
 
818 818
 	/**
@@ -1019,7 +1019,7 @@  discard block
 block discarded – undo
1019 1019
 	private static function maybe_add_captcha_meta( $form_id, $entry_id ) {
1020 1020
 		global $frm_vars;
1021 1021
 		if ( array_key_exists( 'captcha_scores', $frm_vars ) && array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) {
1022
-			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] );
1022
+			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][$form_id] );
1023 1023
 			FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) );
1024 1024
 		}
1025 1025
 	}
Please login to merge, or discard this patch.
classes/helpers/FrmAddonsHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 			'convertkit'                      => 'convertkit',
172 172
 		);
173 173
 
174
-		$icon = array_key_exists( $slug, $icons_map ) ? 'frm_' . $icons_map[ $slug ] . '_icon' : 'frm_logo_icon';
174
+		$icon = array_key_exists( $slug, $icons_map ) ? 'frm_' . $icons_map[$slug] . '_icon' : 'frm_logo_icon';
175 175
 		if ( 'ai' === $slug ) {
176 176
 			$icon = str_replace( '_', '-', $icon );
177 177
 		}
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 		?>
272 272
 		<span style="color: <?php echo esc_attr( $color ); ?>;">
273 273
 			<?php
274
-			for ( $i = 0; $i < 5; $i++ ) {
274
+			for ( $i = 0; $i < 5; $i ++ ) {
275 275
 				echo $icon; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
276 276
 			}
277 277
 			?>
Please login to merge, or discard this patch.
classes/controllers/FrmFormActionsController.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -113,19 +113,19 @@  discard block
 block discarded – undo
113 113
 		}
114 114
 
115 115
 		foreach ( $action_controls as $action ) {
116
-			if ( isset( $groups[ $action->id_base ] ) || in_array( $action->id_base, $grouped ) ) {
116
+			if ( isset( $groups[$action->id_base] ) || in_array( $action->id_base, $grouped ) ) {
117 117
 				continue;
118 118
 			}
119 119
 
120 120
 			$this_group = $action->action_options['group'];
121
-			if ( ! isset( $groups[ $this_group ] ) ) {
121
+			if ( ! isset( $groups[$this_group] ) ) {
122 122
 				$this_group = 'misc';
123 123
 			}
124 124
 
125
-			if ( ! isset( $groups[ $this_group ]['actions'] ) ) {
126
-				$groups[ $this_group ]['actions'] = array();
125
+			if ( ! isset( $groups[$this_group]['actions'] ) ) {
126
+				$groups[$this_group]['actions'] = array();
127 127
 			}
128
-			$groups[ $this_group ]['actions'][] = $action->id_base;
128
+			$groups[$this_group]['actions'][] = $action->id_base;
129 129
 
130 130
 			unset( $action );
131 131
 		}
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 				return $a;
280 280
 			}
281 281
 
282
-			$actions[ $a->id_base ] = $a;
282
+			$actions[$a->id_base] = $a;
283 283
 		}
284 284
 
285 285
 		return $actions;
@@ -313,18 +313,18 @@  discard block
 block discarded – undo
313 313
 		$action_map = array();
314 314
 
315 315
 		foreach ( $action_controls as $key => $control ) {
316
-			$action_map[ $control->id_base ] = $key;
316
+			$action_map[$control->id_base] = $key;
317 317
 		}
318 318
 
319 319
 		self::maybe_show_limit_warning( $form->id, $form_actions );
320 320
 
321 321
 		foreach ( $form_actions as $action ) {
322
-			if ( ! isset( $action_map[ $action->post_excerpt ] ) ) {
322
+			if ( ! isset( $action_map[$action->post_excerpt] ) ) {
323 323
 				// don't try and show settings if action no longer exists
324 324
 				continue;
325 325
 			}
326 326
 
327
-			self::action_control( $action, $form, $action->ID, $action_controls[ $action_map[ $action->post_excerpt ] ], $values );
327
+			self::action_control( $action, $form, $action->ID, $action_controls[$action_map[$action->post_excerpt]], $values );
328 328
 		}
329 329
 	}
330 330
 
@@ -592,8 +592,8 @@  discard block
 block discarded – undo
592 592
 			}
593 593
 
594 594
 			// Store actions so they can be triggered with the correct priority.
595
-			$stored_actions[ $action->ID ]  = $action;
596
-			$action_priority[ $action->ID ] = $link_settings[ $action->post_excerpt ]->action_options['priority'];
595
+			$stored_actions[$action->ID]  = $action;
596
+			$action_priority[$action->ID] = $link_settings[$action->post_excerpt]->action_options['priority'];
597 597
 
598 598
 			unset( $action );
599 599
 		}//end foreach
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 			new FrmNotification();
606 606
 
607 607
 			foreach ( $action_priority as $action_id => $priority ) {
608
-				$action = $stored_actions[ $action_id ];
608
+				$action = $stored_actions[$action_id];
609 609
 
610 610
 				/**
611 611
 				 * Allows custom form action trigger.
@@ -669,12 +669,12 @@  discard block
 block discarded – undo
669 669
 	}
670 670
 
671 671
 	public function register( $action_class ) {
672
-		$this->actions[ $action_class ] = new $action_class();
672
+		$this->actions[$action_class] = new $action_class();
673 673
 	}
674 674
 
675 675
 	public function unregister( $action_class ) {
676
-		if ( isset( $this->actions[ $action_class ] ) ) {
677
-			unset( $this->actions[ $action_class ] );
676
+		if ( isset( $this->actions[$action_class] ) ) {
677
+			unset( $this->actions[$action_class] );
678 678
 		}
679 679
 	}
680 680
 
@@ -683,8 +683,8 @@  discard block
 block discarded – undo
683 683
 
684 684
 		foreach ( $keys as $key ) {
685 685
 			// don't register new action if old action with the same id is already registered
686
-			if ( ! isset( $this->actions[ $key ] ) ) {
687
-				$this->actions[ $key ]->_register();
686
+			if ( ! isset( $this->actions[$key] ) ) {
687
+				$this->actions[$key]->_register();
688 688
 			}
689 689
 		}
690 690
 	}
Please login to merge, or discard this patch.
classes/helpers/FrmCSVExportHelper.php 1 patch
Spacing   +54 added lines, -54 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 
129 129
 		unset( $filename );
130 130
 
131
-		$comment_count       = FrmDb::get_count(
131
+		$comment_count = FrmDb::get_count(
132 132
 			'frm_item_metas',
133 133
 			array(
134 134
 				'item_id'         => $atts['entry_ids'],
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 	private static function prepare_csv_headings() {
260 260
 		$headings = array();
261 261
 		self::csv_headings( $headings );
262
-		$headings       = apply_filters(
262
+		$headings = apply_filters(
263 263
 			'frm_csv_columns',
264 264
 			$headings,
265 265
 			self::$form_id,
@@ -283,10 +283,10 @@  discard block
 block discarded – undo
283 283
 		$field_headings  = array();
284 284
 		$separate_values = array( 'user_id', 'file', 'data', 'date' );
285 285
 		if ( ! empty( $col->field_options['separate_value'] ) && ! in_array( $col->type, $separate_values, true ) ) {
286
-			$field_headings[ $col->id . '_label' ] = strip_tags( $col->name . ' ' . __( '(label)', 'formidable' ) );
286
+			$field_headings[$col->id . '_label'] = strip_tags( $col->name . ' ' . __( '(label)', 'formidable' ) );
287 287
 		}
288 288
 
289
-		$field_headings[ $col->id ] = strip_tags( $col->name );
289
+		$field_headings[$col->id] = strip_tags( $col->name );
290 290
 		$field_headings             = apply_filters(
291 291
 			'frm_csv_field_columns',
292 292
 			$field_headings,
@@ -307,14 +307,14 @@  discard block
 block discarded – undo
307 307
 			if ( self::is_the_child_of_a_repeater( $col ) ) {
308 308
 				$repeater_id = $col->field_options['in_section'];
309 309
 				// Set a placeholder to maintain order for repeater fields.
310
-				$headings[ 'repeater' . $repeater_id ] = array();
310
+				$headings['repeater' . $repeater_id] = array();
311 311
 
312
-				if ( ! isset( $fields_by_repeater_id[ $repeater_id ] ) ) {
313
-					$fields_by_repeater_id[ $repeater_id ] = array();
312
+				if ( ! isset( $fields_by_repeater_id[$repeater_id] ) ) {
313
+					$fields_by_repeater_id[$repeater_id] = array();
314 314
 					$repeater_ids[]                        = $repeater_id;
315 315
 				}
316 316
 
317
-				$fields_by_repeater_id[ $repeater_id ][] = $col;
317
+				$fields_by_repeater_id[$repeater_id][] = $col;
318 318
 
319 319
 				continue;
320 320
 			}
@@ -333,8 +333,8 @@  discard block
 block discarded – undo
333 333
 				$end    = strpos( $row->meta_value, ':{' );
334 334
 				$length = substr( $row->meta_value, $start, $end - $start );
335 335
 
336
-				if ( $length > $max[ $row->field_id ] ) {
337
-					$max[ $row->field_id ] = $length;
336
+				if ( $length > $max[$row->field_id] ) {
337
+					$max[$row->field_id] = $length;
338 338
 				}
339 339
 			}
340 340
 			unset( $start, $end, $length, $row, $repeater_meta, $where );
@@ -345,17 +345,17 @@  discard block
 block discarded – undo
345 345
 					$repeater_id = str_replace( 'repeater', '', $key );
346 346
 
347 347
 					$repeater_headings = array();
348
-					foreach ( $fields_by_repeater_id[ $repeater_id ] as $col ) {
348
+					foreach ( $fields_by_repeater_id[$repeater_id] as $col ) {
349 349
 						$repeater_headings += self::field_headings( $col );
350 350
 					}
351 351
 
352
-					for ( $i = 0; $i < $max[ $repeater_id ]; $i++ ) {
352
+					for ( $i = 0; $i < $max[$repeater_id]; $i ++ ) {
353 353
 						foreach ( $repeater_headings as $repeater_key => $repeater_name ) {
354
-							$flat[ $repeater_key . '[' . $i . ']' ] = $repeater_name;
354
+							$flat[$repeater_key . '[' . $i . ']'] = $repeater_name;
355 355
 						}
356 356
 					}
357 357
 				} else {
358
-					$flat[ $key ] = $heading;
358
+					$flat[$key] = $heading;
359 359
 				}
360 360
 			}
361 361
 
@@ -368,10 +368,10 @@  discard block
 block discarded – undo
368 368
 		}//end if
369 369
 
370 370
 		if ( self::$comment_count ) {
371
-			for ( $i = 0; $i < self::$comment_count; $i++ ) {
372
-				$headings[ 'comment' . $i ]            = __( 'Comment', 'formidable' );
373
-				$headings[ 'comment_user_id' . $i ]    = __( 'Comment User', 'formidable' );
374
-				$headings[ 'comment_created_at' . $i ] = __( 'Comment Date', 'formidable' );
371
+			for ( $i = 0; $i < self::$comment_count; $i ++ ) {
372
+				$headings['comment' . $i]            = __( 'Comment', 'formidable' );
373
+				$headings['comment_user_id' . $i]    = __( 'Comment User', 'formidable' );
374
+				$headings['comment_created_at' . $i] = __( 'Comment Date', 'formidable' );
375 375
 			}
376 376
 			unset( $i );
377 377
 		}
@@ -416,7 +416,7 @@  discard block
 block discarded – undo
416 416
 
417 417
 	private static function prepare_next_csv_rows( $next_set ) {
418 418
 		if ( FrmAppHelper::pro_is_installed() ) {
419
-			$where    = array(
419
+			$where = array(
420 420
 				'or'             => 1,
421 421
 				'id'             => $next_set,
422 422
 				'parent_item_id' => $next_set,
@@ -473,32 +473,32 @@  discard block
 block discarded – undo
473 473
 					continue;
474 474
 				}
475 475
 
476
-				if ( ! isset( $entries[ self::$entry->parent_item_id ] ) ) {
477
-					$entries[ self::$entry->parent_item_id ]        = new stdClass();
478
-					$entries[ self::$entry->parent_item_id ]->metas = array();
476
+				if ( ! isset( $entries[self::$entry->parent_item_id] ) ) {
477
+					$entries[self::$entry->parent_item_id]        = new stdClass();
478
+					$entries[self::$entry->parent_item_id]->metas = array();
479 479
 				}
480 480
 
481
-				if ( ! isset( $entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] ) ) {
482
-					$entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] = array();
483
-				} elseif ( ! is_array( $entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] ) ) {
481
+				if ( ! isset( $entries[self::$entry->parent_item_id]->metas[$meta_id] ) ) {
482
+					$entries[self::$entry->parent_item_id]->metas[$meta_id] = array();
483
+				} elseif ( ! is_array( $entries[self::$entry->parent_item_id]->metas[$meta_id] ) ) {
484 484
 					// if the data is here, it should be an array but if this field has collected data
485 485
 					// both while inside and outside of the repeating section, it's possible this is a string.
486
-					$entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] = (array) $entries[ self::$entry->parent_item_id ]->metas[ $meta_id ];
486
+					$entries[self::$entry->parent_item_id]->metas[$meta_id] = (array) $entries[self::$entry->parent_item_id]->metas[$meta_id];
487 487
 				}
488 488
 
489 489
 				// Add the repeated values.
490
-				$entries[ self::$entry->parent_item_id ]->metas[ $meta_id ][] = $meta_value;
490
+				$entries[self::$entry->parent_item_id]->metas[$meta_id][] = $meta_value;
491 491
 			}//end foreach
492 492
 
493 493
 			self::$entry->metas                              = self::fill_missing_repeater_metas( self::$entry->metas, $entries );
494
-			$entries[ self::$entry->parent_item_id ]->metas += self::$entry->metas;
494
+			$entries[self::$entry->parent_item_id]->metas += self::$entry->metas;
495 495
 		}//end if
496 496
 
497 497
 		// add the embedded form id
498
-		if ( ! isset( $entries[ self::$entry->parent_item_id ]->embedded_fields ) ) {
499
-			$entries[ self::$entry->parent_item_id ]->embedded_fields = array();
498
+		if ( ! isset( $entries[self::$entry->parent_item_id]->embedded_fields ) ) {
499
+			$entries[self::$entry->parent_item_id]->embedded_fields = array();
500 500
 		}
501
-		$entries[ self::$entry->parent_item_id ]->embedded_fields[ self::$entry->id ] = self::$entry->form_id;
501
+		$entries[self::$entry->parent_item_id]->embedded_fields[self::$entry->id] = self::$entry->form_id;
502 502
 	}
503 503
 
504 504
 	/**
@@ -519,19 +519,19 @@  discard block
 block discarded – undo
519 519
 		}
520 520
 
521 521
 		$repeater_id = $field->field_options['in_section'];
522
-		if ( ! isset( self::$fields_by_repeater_id[ $repeater_id ] ) ) {
522
+		if ( ! isset( self::$fields_by_repeater_id[$repeater_id] ) ) {
523 523
 			return $metas;
524 524
 		}
525 525
 
526
-		foreach ( self::$fields_by_repeater_id[ $repeater_id ] as $repeater_child ) {
527
-			if ( ! isset( $metas[ $repeater_child->id ] ) ) {
528
-				$metas[ $repeater_child->id ] = '';
526
+		foreach ( self::$fields_by_repeater_id[$repeater_id] as $repeater_child ) {
527
+			if ( ! isset( $metas[$repeater_child->id] ) ) {
528
+				$metas[$repeater_child->id] = '';
529 529
 
530
-				if ( ! isset( $entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ] ) || ! is_array( $entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ] ) ) {
531
-					$entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ] = array();
530
+				if ( ! isset( $entries[self::$entry->parent_item_id]->metas[$repeater_child->id] ) || ! is_array( $entries[self::$entry->parent_item_id]->metas[$repeater_child->id] ) ) {
531
+					$entries[self::$entry->parent_item_id]->metas[$repeater_child->id] = array();
532 532
 				}
533 533
 
534
-				$entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ][] = '';
534
+				$entries[self::$entry->parent_item_id]->metas[$repeater_child->id][] = '';
535 535
 			}
536 536
 		}
537 537
 
@@ -550,7 +550,7 @@  discard block
 block discarded – undo
550 550
 
551 551
 	private static function add_field_values_to_csv( &$row ) {
552 552
 		foreach ( self::$fields as $col ) {
553
-			$field_value = isset( self::$entry->metas[ $col->id ] ) ? self::$entry->metas[ $col->id ] : false;
553
+			$field_value = isset( self::$entry->metas[$col->id] ) ? self::$entry->metas[$col->id] : false;
554 554
 
555 555
 			FrmFieldsHelper::prepare_field_value( $field_value, $col->type );
556 556
 			self::add_array_values_to_columns( $row, compact( 'col', 'field_value' ) );
@@ -569,20 +569,20 @@  discard block
 block discarded – undo
569 569
 			if ( ! empty( $col->field_options['separate_value'] ) ) {
570 570
 				$label_key = $col->id . '_label';
571 571
 				if ( self::is_the_child_of_a_repeater( $col ) ) {
572
-					$row[ $label_key ] = array();
572
+					$row[$label_key] = array();
573 573
 
574 574
 					if ( is_array( $field_value ) ) {
575 575
 						foreach ( $field_value as $value ) {
576
-							$row[ $label_key ][] = self::get_separate_value_label( $value, $col );
576
+							$row[$label_key][] = self::get_separate_value_label( $value, $col );
577 577
 						}
578 578
 					}
579 579
 				} else {
580
-					$row[ $label_key ] = self::get_separate_value_label( $field_value, $col );
580
+					$row[$label_key] = self::get_separate_value_label( $field_value, $col );
581 581
 				}
582 582
 				unset( $label_key );
583 583
 			}
584 584
 
585
-			$row[ $col->id ] = $field_value;
585
+			$row[$col->id] = $field_value;
586 586
 
587 587
 			unset( $col, $field_value );
588 588
 		}//end foreach
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 				'show_icon'         => false,
606 606
 				'entry_id'          => self::$entry->id,
607 607
 				'sep'               => self::$separator,
608
-				'embedded_field_id' => isset( self::$entry->embedded_fields ) && isset( self::$entry->embedded_fields[ self::$entry->id ] ) ? 'form' . self::$entry->embedded_fields[ self::$entry->id ] : 0,
608
+				'embedded_field_id' => isset( self::$entry->embedded_fields ) && isset( self::$entry->embedded_fields[self::$entry->id] ) ? 'form' . self::$entry->embedded_fields[self::$entry->id] : 0,
609 609
 			)
610 610
 		);
611 611
 	}
@@ -620,8 +620,8 @@  discard block
 block discarded – undo
620 620
 					// This is combo field inside repeater. The heading key has this format: [86_first[0]].
621 621
 					foreach ( $sub_value as $sub_key => $sub_sub_value ) {
622 622
 						$column_key = $atts['col']->id . '_' . $sub_key . '[' . $key . ']';
623
-						if ( ! is_numeric( $sub_key ) && isset( self::$headings[ $column_key ] ) ) {
624
-							$row[ $column_key ] = $sub_sub_value;
623
+						if ( ! is_numeric( $sub_key ) && isset( self::$headings[$column_key] ) ) {
624
+							$row[$column_key] = $sub_sub_value;
625 625
 						}
626 626
 					}
627 627
 
@@ -629,8 +629,8 @@  discard block
 block discarded – undo
629 629
 				}
630 630
 
631 631
 				$column_key = $atts['col']->id . '_' . $key;
632
-				if ( ! is_numeric( $key ) && isset( self::$headings[ $column_key ] ) ) {
633
-					$row[ $column_key ] = $sub_value;
632
+				if ( ! is_numeric( $key ) && isset( self::$headings[$column_key] ) ) {
633
+					$row[$column_key] = $sub_value;
634 634
 				}
635 635
 			}
636 636
 		}
@@ -655,18 +655,18 @@  discard block
 block discarded – undo
655 655
 		$echo = 'echo' === self::$mode;
656 656
 
657 657
 		foreach ( self::$headings as $k => $heading ) {
658
-			if ( isset( $rows[ $k ] ) ) {
659
-				$row = $rows[ $k ];
658
+			if ( isset( $rows[$k] ) ) {
659
+				$row = $rows[$k];
660 660
 			} else {
661 661
 				$row = '';
662 662
 				// array indexed data is not at $rows[ $k ]
663
-				if ( $k[ strlen( $k ) - 1 ] === ']' ) {
663
+				if ( $k[strlen( $k ) - 1] === ']' ) {
664 664
 					$start = strrpos( $k, '[' );
665
-					$key   = substr( $k, 0, $start++ );
665
+					$key   = substr( $k, 0, $start ++ );
666 666
 					$index = substr( $k, $start, strlen( $k ) - 1 - $start );
667 667
 
668
-					if ( isset( $rows[ $key ] ) && isset( $rows[ $key ][ $index ] ) ) {
669
-						$row = $rows[ $key ][ $index ];
668
+					if ( isset( $rows[$key] ) && isset( $rows[$key][$index] ) ) {
669
+						$row = $rows[$key][$index];
670 670
 					}
671 671
 
672 672
 					unset( $start, $key, $index );
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldEmail.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 		}
50 50
 		$errors = array();
51 51
 		if ( false !== strpos( $args['value'], '.@' ) || ! is_email( $args['value'] ) ) {
52
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
52
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
53 53
 		}
54 54
 		return $errors;
55 55
 	}
Please login to merge, or discard this patch.
classes/controllers/FrmAddonsController.php 1 patch
Spacing   +26 added lines, -28 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 				'<span class="frm-upgrade-submenu">' . esc_html( $cta_text ) . '</span>',
117 117
 				'frm_view_forms',
118 118
 				'formidable-pro-upgrade',
119
-				function () {
119
+				function() {
120 120
 					// This function doesn't need to do anything.
121 121
 					// The redirect is handled earlier to avoid issues with the headers being sent.
122 122
 				}
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 			unset( $addons['error'] );
148 148
 		}
149 149
 
150
-		$pro    = array(
150
+		$pro = array(
151 151
 			'pro' => array(
152 152
 				'title'      => 'Formidable Forms Pro',
153 153
 				'slug'       => 'formidable-pro',
@@ -189,9 +189,9 @@  discard block
 block discarded – undo
189 189
 
190 190
 		// Extract the elements to move
191 191
 		foreach ( $plans as $plan ) {
192
-			if ( isset( self::$categories[ $plan ] ) ) {
193
-				$bottom_categories[ $plan ] = self::$categories[ $plan ];
194
-				unset( self::$categories[ $plan ] );
192
+			if ( isset( self::$categories[$plan] ) ) {
193
+				$bottom_categories[$plan] = self::$categories[$plan];
194
+				unset( self::$categories[$plan] );
195 195
 			}
196 196
 		}
197 197
 
@@ -245,14 +245,12 @@  discard block
 block discarded – undo
245 245
 			// Add the slug to the new array.
246 246
 			$addon['category-slugs'][] = $category_slug;
247 247
 
248
-			if ( ! isset( self::$categories[ $category_slug ] ) ) {
249
-				self::$categories[ $category_slug ] = array(
248
+			if ( ! isset( self::$categories[$category_slug] ) ) {
249
+				self::$categories[$category_slug] = array(
250 250
 					'name'  => $category,
251 251
 					'count' => 0,
252 252
 				);
253
-			}
254
-
255
-			++self::$categories[ $category_slug ]['count'];
253
+			} ++self::$categories[$category_slug]['count'];
256 254
 		}
257 255
 	}
258 256
 
@@ -284,7 +282,7 @@  discard block
 block discarded – undo
284 282
 		} else {
285 283
 			foreach ( $addons as $k => $addon ) {
286 284
 				if ( empty( $addon['excerpt'] ) && $k !== 'error' ) {
287
-					unset( $addons[ $k ] );
285
+					unset( $addons[$k] );
288 286
 				}
289 287
 			}
290 288
 		}
@@ -398,7 +396,7 @@  discard block
 block discarded – undo
398 396
 
399 397
 		foreach ( $list as $k => $info ) {
400 398
 			$info['slug'] = $k;
401
-			$list[ $k ]   = array_merge( $defaults, $info );
399
+			$list[$k]   = array_merge( $defaults, $info );
402 400
 		}
403 401
 		return $list;
404 402
 	}
@@ -549,17 +547,17 @@  discard block
 block discarded – undo
549 547
 				continue;
550 548
 			}
551 549
 
552
-			$wp_plugin    = isset( $wp_plugins[ $folder ] ) ? $wp_plugins[ $folder ] : array();
550
+			$wp_plugin    = isset( $wp_plugins[$folder] ) ? $wp_plugins[$folder] : array();
553 551
 			$wp_version   = isset( $wp_plugin['Version'] ) ? $wp_plugin['Version'] : '1.0';
554 552
 			$plugin->slug = explode( '/', $folder )[0];
555 553
 
556 554
 			if ( version_compare( $wp_version, $plugin->new_version, '<' ) ) {
557
-				$transient->response[ $folder ] = $plugin;
555
+				$transient->response[$folder] = $plugin;
558 556
 			} else {
559
-				$transient->no_update[ $folder ] = $plugin;
557
+				$transient->no_update[$folder] = $plugin;
560 558
 			}
561 559
 
562
-			$transient->checked[ $folder ] = $wp_version;
560
+			$transient->checked[$folder] = $wp_version;
563 561
 
564 562
 		}//end foreach
565 563
 
@@ -592,7 +590,7 @@  discard block
 block discarded – undo
592 590
 	 */
593 591
 	protected static function is_installed( $plugin ) {
594 592
 		$all_plugins = self::get_plugins();
595
-		return isset( $all_plugins[ $plugin ] );
593
+		return isset( $all_plugins[$plugin] );
596 594
 	}
597 595
 
598 596
 	/**
@@ -631,13 +629,13 @@  discard block
 block discarded – undo
631 629
 			}
632 630
 
633 631
 			$download_id = isset( $plugin['id'] ) ? $plugin['id'] : 0;
634
-			if ( ! empty( $download_id ) && ! isset( $version_info[ $download_id ]['package'] ) ) {
632
+			if ( ! empty( $download_id ) && ! isset( $version_info[$download_id]['package'] ) ) {
635 633
 				// if this addon is using its own license, get the update url
636 634
 				$addon_info = $api->get_api_info();
637 635
 
638
-				$version_info[ $download_id ] = $addon_info[ $download_id ];
636
+				$version_info[$download_id] = $addon_info[$download_id];
639 637
 				if ( isset( $addon_info['error'] ) ) {
640
-					$version_info[ $download_id ]['error'] = array(
638
+					$version_info[$download_id]['error'] = array(
641 639
 						'message' => $addon_info['error']['message'],
642 640
 						'code'    => $addon_info['error']['code'],
643 641
 					);
@@ -736,8 +734,8 @@  discard block
 block discarded – undo
736 734
 					return $addon;
737 735
 				}
738 736
 			}
739
-		} elseif ( isset( $addons[ $download_id ] ) ) {
740
-			$plugin = $addons[ $download_id ];
737
+		} elseif ( isset( $addons[$download_id] ) ) {
738
+			$plugin = $addons[$download_id];
741 739
 		}
742 740
 
743 741
 		return $plugin;
@@ -803,7 +801,7 @@  discard block
 block discarded – undo
803 801
 			self::set_addon_status( $addon );
804 802
 			self::set_categories( $addon );
805 803
 
806
-			$addons[ $id ] = $addon;
804
+			$addons[$id] = $addon;
807 805
 		}//end foreach
808 806
 	}
809 807
 
@@ -844,7 +842,7 @@  discard block
 block discarded – undo
844 842
 			'utm_medium'   => 'addons',
845 843
 			'utm_campaign' => 'liteplugin',
846 844
 		);
847
-		$link       = add_query_arg( $query_args, $link );
845
+		$link = add_query_arg( $query_args, $link );
848 846
 	}
849 847
 
850 848
 	/**
@@ -1062,7 +1060,7 @@  discard block
 block discarded – undo
1062 1060
 	 */
1063 1061
 	public static function ajax_activate_addon() {
1064 1062
 		self::process_addon_action(
1065
-			function ( $plugin ) {
1063
+			function( $plugin ) {
1066 1064
 				return self::handle_addon_action( $plugin, 'activate' );
1067 1065
 			},
1068 1066
 			array( 'FrmAddonsController', 'get_addon_activation_response' )
@@ -1087,7 +1085,7 @@  discard block
 block discarded – undo
1087 1085
 	 */
1088 1086
 	public static function ajax_deactivate_addon() {
1089 1087
 		self::process_addon_action(
1090
-			function ( $plugin ) {
1088
+			function( $plugin ) {
1091 1089
 				return self::handle_addon_action( $plugin, 'deactivate' );
1092 1090
 			}
1093 1091
 		);
@@ -1102,7 +1100,7 @@  discard block
 block discarded – undo
1102 1100
 	 */
1103 1101
 	public static function ajax_uninstall_addon() {
1104 1102
 		self::process_addon_action(
1105
-			function ( $plugin ) {
1103
+			function( $plugin ) {
1106 1104
 				return self::handle_addon_action( $plugin, 'uninstall' );
1107 1105
 			}
1108 1106
 		);
@@ -1500,7 +1498,7 @@  discard block
 block discarded – undo
1500 1498
 		$addons = $api->get_api_info();
1501 1499
 
1502 1500
 		if ( is_array( $addons ) && array_key_exists( $addon_id, $addons ) ) {
1503
-			$dates    = $addons[ $addon_id ];
1501
+			$dates    = $addons[$addon_id];
1504 1502
 			$requires = FrmFormsHelper::get_plan_required( $dates );
1505 1503
 		}
1506 1504
 
Please login to merge, or discard this patch.
classes/models/FrmSalesApi.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 			return;
90 90
 		}
91 91
 
92
-		self::$sales[ $sale['key'] ] = $this->fill_sale( $sale );
92
+		self::$sales[$sale['key']] = $this->fill_sale( $sale );
93 93
 	}
94 94
 
95 95
 	/**
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 
188 188
 		$sale = self::$instance->get_best_sale();
189 189
 
190
-		return is_array( $sale ) && ! empty( $sale[ $key ] ) ? $sale[ $key ] : false;
190
+		return is_array( $sale ) && ! empty( $sale[$key] ) ? $sale[$key] : false;
191 191
 	}
192 192
 
193 193
 	/**
Please login to merge, or discard this patch.
stripe/controllers/FrmTransLiteHooksController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
 	public static function load_admin_hooks() {
37 37
 		add_action(
38 38
 			'admin_init',
39
-			function () {
39
+			function() {
40 40
 				self::fix_addon_hooks();
41 41
 			}
42 42
 		);
Please login to merge, or discard this patch.