Strategy11 / formidable-forms

square/controllers/FrmSquareLiteActionsController.php

Braces +4 added lines, -2 removed lines

@@ -139,7 +139,8 @@ 
 	 * @return string|true string on error, true on success.
 	 */
 	private static function trigger_one_time_payment( $atts ) {
-		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return __( 'Please enter a valid credit card', 'formidable' );
 		}
 
@@ -199,7 +200,8 @@ 
 	 * @return bool|string True on success, error message on failure
 	 */
 	private static function trigger_recurring_payment( $atts ) {
-		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return __( 'Please enter a valid credit card', 'formidable' );
 		}
 

Spacing +9 added lines, -9 removed lines

@@ -76,7 +76,7 @@ 
 			$gateway   = $payment_action->post_content['gateway'];
 			$is_square = $gateway === 'square' || ( is_array( $gateway ) && in_array( 'square', $gateway, true ) );
 			if ( ! $is_square || empty( $payment_action->post_content['amount'] ) ) {
-				unset( $payment_actions[ $k ] );
+				unset( $payment_actions[$k] );
 			}
 		}
 		return $payment_actions;
@@ -97,7 +97,7 @@ 
 			'run_triggers' => false,
 			'show_errors'  => true,
 		);
-		$atts     = compact( 'action', 'entry', 'form' );
+		$atts = compact( 'action', 'entry', 'form' );
 
 		$amount = self::prepare_amount( $action->post_content['amount'], $atts );
 		if ( empty( $amount ) || $amount == 000 ) {
@@ -150,7 +150,7 @@ 
 				'value' => $atts['action']->post_content['description'],
 			)
 		);
-		$result             = FrmSquareLiteConnectHelper::create_payment( $atts['amount'], $currency, $square_token, $verification_token, $description );
+		$result = FrmSquareLiteConnectHelper::create_payment( $atts['amount'], $currency, $square_token, $verification_token, $description );
 
 		if ( false === $result ) {
 			return FrmSquareLiteConnectHelper::get_latest_error_from_square_api();
@@ -455,7 +455,7 @@ 
 			false
 		);
 
-		$square_vars     = array(
+		$square_vars = array(
 			'formId'     => $form_id,
 			'nonce'      => wp_create_nonce( 'frm_square_ajax' ),
 			'ajax'       => esc_url_raw( FrmAppHelper::get_ajax_url() ),
@@ -572,7 +572,7 @@ 
 		$disallowed = array( ';', ':', '!important' );
 		foreach ( $settings as $k => $s ) {
 			if ( is_string( $s ) ) {
-				$settings[ $k ] = str_replace( $disallowed, '', $s );
+				$settings[$k] = str_replace( $disallowed, '', $s );
 			}
 		}
 
@@ -598,11 +598,11 @@ 
 
 		$field_id = isset( $field->temp_id ) ? $field->temp_id : $field->id;
 
-		if ( isset( $errors[ 'field' . $field_id . '-cc' ] ) ) {
-			unset( $errors[ 'field' . $field_id . '-cc' ] );
+		if ( isset( $errors['field' . $field_id . '-cc'] ) ) {
+			unset( $errors['field' . $field_id . '-cc'] );
 		}
-		if ( isset( $errors[ 'field' . $field_id ] ) ) {
-			unset( $errors[ 'field' . $field_id ] );
+		if ( isset( $errors['field' . $field_id] ) ) {
+			unset( $errors['field' . $field_id] );
 		}
 
 		return $errors;

stripe/controllers/FrmTransLiteActionsController.php

Spacing +4 added lines, -4 removed lines

@@ -472,8 +472,8 @@ 
 			return $values;
 		}
 
-		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[ $field->id ] ) ) {
-			$values['value'] = $previous_entry->metas[ $field->id ];
+		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[$field->id] ) ) {
+			$values['value'] = $previous_entry->metas[$field->id];
 		}
 
 		$frm_vars['trans_filled'] = true;
@@ -508,7 +508,7 @@ 
 			 * @param Closure    $destroy_callback
 			 * @return void
 			 */
-			function () use ( $entry_id, &$destroy_callback ) {
+			function() use ( $entry_id, &$destroy_callback ) {
 				FrmEntry::destroy( $entry_id );
 				// Only call this once.
 				remove_action( 'frm_entry_form', $destroy_callback );
@@ -528,7 +528,7 @@ 
 	 * @return array
 	 */
 	public static function before_save_settings( $settings, $action ) {
-		$settings['gateway']  = ! empty( $settings['gateway'] ) ? (array) $settings['gateway'] : array( 'stripe' );
+		$settings['gateway'] = ! empty( $settings['gateway'] ) ? (array) $settings['gateway'] : array( 'stripe' );
 
 		if ( in_array( 'square', $settings['gateway'] ) ) {
 			$currency = FrmSquareLiteConnectHelper::get_merchant_currency();

classes/models/fields/FrmFieldType.php

Spacing +22 added lines, -22 removed lines

@@ -156,8 +156,8 @@ 
 		$field_val = '';
 		if ( is_object( $this->field ) ) {
 			$field_val = $this->field->{$column};
-		} elseif ( is_array( $this->field ) && isset( $this->field[ $column ] ) ) {
-			$field_val = $this->field[ $column ];
+		} elseif ( is_array( $this->field ) && isset( $this->field[$column] ) ) {
+			$field_val = $this->field[$column];
 		}
 
 		return $field_val;
@@ -171,7 +171,7 @@ 
 		if ( is_object( $this->field ) ) {
 			$this->field->{$column} = $value;
 		} elseif ( is_array( $this->field ) ) {
-			$this->field[ $column ] = $value;
+			$this->field[$column] = $value;
 		}
 	}
 
@@ -637,7 +637,7 @@ 
 			printf(
 				/* translators: %s: Field type */
 				esc_html__( '%s Options', 'formidable' ),
-				esc_html( $all_field_types[ $args['display']['type'] ]['name'] )
+				esc_html( $all_field_types[$args['display']['type']]['name'] )
 			);
 			FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown6_icon', array( 'aria-hidden' => 'true' ) );
 			?>
@@ -737,7 +737,7 @@ 
 	 * New field
 	 */
 	public function get_new_field_defaults() {
-		$field        = array(
+		$field = array(
 			'name'          => $this->get_new_field_name(),
 			'description'   => '',
 			'type'          => $this->type,
@@ -768,8 +768,8 @@ 
 
 		$fields = array_merge( $fields, $pro_fields );
 
-		if ( isset( $fields[ $this->type ] ) ) {
-			$name = is_array( $fields[ $this->type ] ) ? $fields[ $this->type ]['name'] : $fields[ $this->type ];
+		if ( isset( $fields[$this->type] ) ) {
+			$name = is_array( $fields[$this->type] ) ? $fields[$this->type]['name'] : $fields[$this->type];
 		}
 
 		return $name;
@@ -786,7 +786,7 @@ 
 	 * @return array
 	 */
 	public function get_default_field_options() {
-		$opts        = array(
+		$opts = array(
 			'size'               => '',
 			'max'                => '',
 			'label'              => '',
@@ -1030,7 +1030,7 @@ 
 	 * @return void
 	 */
 	public function set_aria_invalid_error( &$shortcode_atts, $args ) {
-		$shortcode_atts['aria-invalid'] = isset( $args['errors'][ 'field' . $this->field_id ] ) ? 'true' : 'false';
+		$shortcode_atts['aria-invalid'] = isset( $args['errors']['field' . $this->field_id] ) ? 'true' : 'false';
 	}
 
 	/**
@@ -1181,11 +1181,11 @@ 
 		}
 
 		$options = array_values( $this->field['options'] );
-		if ( ! isset( $options[ $opt ] ) ) {
+		if ( ! isset( $options[$opt] ) ) {
 			return $hidden;
 		}
 
-		$option = $options[ $opt ];
+		$option = $options[$opt];
 		if ( is_array( $option ) ) {
 			$option = $option['value'];
 		}
@@ -1249,8 +1249,8 @@ 
 		$selected = $values['field_value'];
 
 		if ( isset( $values['combo_name'] ) ) {
-			$options  = $options[ $values['combo_name'] ];
-			$selected = is_array( $selected ) && isset( $selected[ $values['combo_name'] ] ) ? $selected[ $values['combo_name'] ] : '';
+			$options  = $options[$values['combo_name']];
+			$selected = is_array( $selected ) && isset( $selected[$values['combo_name']] ) ? $selected[$values['combo_name']] : '';
 		}
 
 		$input = $this->select_tag( $values );
@@ -1305,7 +1305,7 @@ 
 	}
 
 	protected function fill_display_field_values( $args = array() ) {
-		$defaults        = array(
+		$defaults = array(
 			'field_name'    => 'item_meta[' . $this->get_field_column( 'id' ) . ']',
 			'field_id'      => $this->get_field_column( 'id' ),
 			'field_plus_id' => '',
@@ -1362,7 +1362,7 @@ 
 			}
 		}
 
-		if ( isset( $args['errors'][ 'field' . $args['field_id'] ] ) && ! $custom_error_fields ) {
+		if ( isset( $args['errors']['field' . $args['field_id']] ) && ! $custom_error_fields ) {
 			if ( $error_comes_first ) {
 				array_unshift( $describedby, 'frm_error_' . $args['html_id'] );
 			} else {
@@ -1440,11 +1440,11 @@ 
 
 		$field_id = $this->get_field_column( 'id' );
 		if ( ! array_key_exists( $field_id, $frm_validated_unique_values ) ) {
-			$frm_validated_unique_values[ $field_id ] = array();
+			$frm_validated_unique_values[$field_id] = array();
 			return false;
 		}
 
-		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[ $field_id ], true );
+		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[$field_id], true );
 		return $already_validated_this_value;
 	}
 
@@ -1469,7 +1469,7 @@ 
 	private function value_validated_as_unique( $value ) {
 		global $frm_validated_unique_values;
 		$field_id                                   = $this->get_field_column( 'id' );
-		$frm_validated_unique_values[ $field_id ][] = $value;
+		$frm_validated_unique_values[$field_id][] = $value;
 	}
 
 	/**
@@ -1514,8 +1514,8 @@ 
 		$value = $this->prepare_display_value( $value, $atts );
 
 		if ( is_array( $value ) ) {
-			if ( ! empty( $atts['show'] ) && isset( $value[ $atts['show'] ] ) ) {
-				$value = $value[ $atts['show'] ];
+			if ( ! empty( $atts['show'] ) && isset( $value[$atts['show']] ) ) {
+				$value = $value[$atts['show']];
 			} elseif ( empty( $atts['return_array'] ) ) {
 				$sep   = isset( $atts['sep'] ) ? $atts['sep'] : ', ';
 				$value = FrmAppHelper::safe_implode( $sep, $value );
@@ -1645,8 +1645,8 @@ 
 		$saved_entries = $atts['ids'];
 		$new_value     = array();
 		foreach ( (array) $value as $old_child_id ) {
-			if ( isset( $saved_entries[ $old_child_id ] ) ) {
-				$new_value[] = $saved_entries[ $old_child_id ];
+			if ( isset( $saved_entries[$old_child_id] ) ) {
+				$new_value[] = $saved_entries[$old_child_id];
 			}
 		}
 

classes/controllers/FrmSettingsController.php

Spacing +5 added lines, -5 removed lines

@@ -173,7 +173,7 @@ 
 				$section['function'] = $original;
 			}
 
-			$sections[ $key ] = $section;
+			$sections[$key] = $section;
 		}//end foreach
 
 		return $sections;
@@ -193,8 +193,8 @@ 
 
 		foreach ( $sections as $key => $section ) {
 			if ( in_array( $key, $payment_section_keys, true ) ) {
-				self::$removed_payments_sections[ $key ] = $section;
-				unset( $sections[ $key ] );
+				self::$removed_payments_sections[$key] = $section;
+				unset( $sections[$key] );
 			}
 		}
 
@@ -226,11 +226,11 @@ 
 
 		$section  = FrmAppHelper::get_post_param( 'tab', '', 'sanitize_text_field' );
 		$sections = self::get_settings_tabs();
-		if ( ! isset( $sections[ $section ] ) ) {
+		if ( ! isset( $sections[$section] ) ) {
 			wp_die();
 		}
 
-		$section = $sections[ $section ];
+		$section = $sections[$section];
 
 		if ( isset( $section['class'] ) ) {
 			call_user_func( array( $section['class'], $section['function'] ) );

classes/views/frm-settings/payments.php

Spacing +2 added lines, -2 removed lines

@@ -31,8 +31,8 @@
 	if ( $is_active ) {
 		$input_params['checked'] = 'checked';
 	}
-	$other_section_selectors      = array_map(
-		function ( $section ) {
+	$other_section_selectors = array_map(
+		function( $section ) {
 			return "#frm_{$section}_settings_section";
 		},
 		array_diff( array_keys( $payment_sections ), array( $key ) )

classes/views/frm-fields/front-end/combo-field/combo-field.php

Spacing +6 added lines, -6 removed lines

@@ -41,7 +41,7 @@ 
 			$sub_field_class   = "frm_form_field form-field frm_form_subfield-{$name} {$sub_field['wrapper_classes']}";
 			$sub_field_desc    = FrmField::get_option( $field, $name . '_desc' );
 
-			if ( isset( $errors[ 'field' . $field_id . '-' . $name ] ) ) {
+			if ( isset( $errors['field' . $field_id . '-' . $name] ) ) {
 				$sub_field_class .= ' frm_blank_field';
 			}
 			?>
@@ -60,11 +60,11 @@ 
 						$attrs = array(
 							'type'  => $sub_field['type'],
 							'id'    => $html_id . '_' . $name,
-							'value' => isset( $field_value[ $name ] ) ? $field_value[ $name ] : '',
+							'value' => isset( $field_value[$name] ) ? $field_value[$name] : '',
 						);
 
-						if ( ! empty( $field_value[ $name ] ) ) {
-							$attrs['data-frmval'] = $field_value[ $name ];
+						if ( ! empty( $field_value[$name] ) ) {
+							$attrs['data-frmval'] = $field_value[$name];
 						}
 						if ( empty( $args['remove_names'] ) ) {
 							$attrs['name'] = $field_name . '[' . $name . ']';
@@ -81,9 +81,9 @@ 
 				}
 
 				// Don't show individual field errors when there is a combo field error.
-				if ( ! empty( $errors ) && isset( $errors[ 'field' . $field_id . '-' . $name ] ) && ! isset( $errors[ 'field' . $field_id ] ) ) {
+				if ( ! empty( $errors ) && isset( $errors['field' . $field_id . '-' . $name] ) && ! isset( $errors['field' . $field_id] ) ) {
 					?>
-					<div class="frm_error" role="alert"><?php echo esc_html( $errors[ 'field' . $field_id . '-' . $name ] ); ?></div>
+					<div class="frm_error" role="alert"><?php echo esc_html( $errors['field' . $field_id . '-' . $name] ); ?></div>
 				<?php } ?>
 			</div>
 			<?php

classes/controllers/FrmFormTemplatesController.php

Spacing +13 added lines, -15 removed lines

@@ -232,7 +232,7 @@ 
 					'description'        => esc_html__( 'Just add your email address and you\'ll get 30+ free form templates to your account.', 'formidable' ),
 					'submit_button_text' => esc_html_x( 'Get Templates', 'get free templates modal submit button text', 'formidable' ),
 				);
-				$view_parts[]     = 'modals/leave-email-modal.php';
+				$view_parts[] = 'modals/leave-email-modal.php';
 			}
 
 			// Add 'upgrade' modal view for non-elite users.
@@ -331,11 +331,11 @@ 
 
 		// Perform add or remove operation.
 		if ( 'add' === $operation ) {
-			self::$favorite_templates[ $key ][] = $template_id;
+			self::$favorite_templates[$key][] = $template_id;
 		} elseif ( 'remove' === $operation ) {
-			$position = array_search( $template_id, self::$favorite_templates[ $key ], true );
+			$position = array_search( $template_id, self::$favorite_templates[$key], true );
 			if ( $position !== false ) {
-				unset( self::$favorite_templates[ $key ][ $position ] );
+				unset( self::$favorite_templates[$key][$position] );
 			}
 		}
 
@@ -486,7 +486,7 @@ 
 		foreach ( self::$templates as $key => &$template ) {
 			// Skip the template if the categories are not set.
 			if ( ! isset( $template['categories'] ) || ! isset( $template['id'] ) ) {
-				unset( self::$templates[ $key ] );
+				unset( self::$templates[$key] );
 				continue;
 			}
 
@@ -500,14 +500,12 @@ 
 				// Add the slug to the new array.
 				$template['category_slugs'][] = $category_slug;
 
-				if ( ! isset( self::$categories[ $category_slug ] ) ) {
-					self::$categories[ $category_slug ] = array(
+				if ( ! isset( self::$categories[$category_slug] ) ) {
+					self::$categories[$category_slug] = array(
 						'name'  => $category,
 						'count' => 0,
 					);
-				}
-
-				++self::$categories[ $category_slug ]['count'];
+				} ++self::$categories[$category_slug]['count'];
 			}
 
 			// Mark the template as favorite if it's in the favorite templates list.
@@ -522,7 +520,7 @@ 
 		$redundant_cats = array_merge( array( 'PayPal', 'Stripe', 'Twilio' ), FrmFormsHelper::get_license_types() );
 		foreach ( $redundant_cats as $redundant_cat ) {
 			$category_slug = sanitize_title( $redundant_cat );
-			unset( self::$categories[ $category_slug ] );
+			unset( self::$categories[$category_slug] );
 		}
 
 		// Sort the categories by keys alphabetically.
@@ -547,7 +545,7 @@ 
 				'count' => 0,
 			);
 		}
-		$special_categories['all-items']      = array(
+		$special_categories['all-items'] = array(
 			'name'  => __( 'All Templates', 'formidable' ),
 			'count' => self::get_template_count(),
 		);
@@ -570,9 +568,9 @@ 
 	 */
 	private static function assign_featured_templates() {
 		foreach ( self::FEATURED_TEMPLATES_KEYS as $key ) {
-			if ( isset( self::$templates[ $key ] ) ) {
-				self::$templates[ $key ]['is_featured'] = true;
-				self::$featured_templates[]             = self::$templates[ $key ];
+			if ( isset( self::$templates[$key] ) ) {
+				self::$templates[$key]['is_featured'] = true;
+				self::$featured_templates[]             = self::$templates[$key];
 			}
 		}
 	}

classes/helpers/FrmDashboardHelper.php

Spacing +3 added lines, -3 removed lines

@@ -89,8 +89,8 @@ 
 	public function __construct( $data ) {
 		$sections = array( 'counters', 'license', 'get_free_templates', 'payments', 'entries', 'inbox', 'video', 'payments' );
 		foreach ( $sections as $section ) {
-			if ( isset( $data[ $section ] ) ) {
-				$this->view[ $section ] = $data[ $section ];
+			if ( isset( $data[$section] ) ) {
+				$this->view[$section] = $data[$section];
 			}
 		}
 	}
@@ -365,7 +365,7 @@ 
 	private static function load_entries_list_template( $template ) {
 		add_filter(
 			'formidable_page_formidable_entries_per_page',
-			function () {
+			function() {
 				return 7;
 			}
 		);