Strategy11 / formidable-forms

classes/controllers/FrmFormTemplatesController.php

Spacing +12 added lines, -14 removed lines

@@ -322,11 +322,11 @@ 
 
 		// Perform add or remove operation.
 		if ( 'add' === $operation ) {
-			self::$favorite_templates[ $key ][] = $template_id;
+			self::$favorite_templates[$key][] = $template_id;
 		} elseif ( 'remove' === $operation ) {
-			$position = array_search( $template_id, self::$favorite_templates[ $key ], true );
+			$position = array_search( $template_id, self::$favorite_templates[$key], true );
 			if ( $position !== false ) {
-				unset( self::$favorite_templates[ $key ][ $position ] );
+				unset( self::$favorite_templates[$key][$position] );
 			}
 		}
 
@@ -455,7 +455,7 @@ 
 		foreach ( self::$templates as $key => &$template ) {
 			// Skip the template if the categories are not set.
 			if ( ! isset( $template['categories'] ) || ! isset( $template['id'] ) ) {
-				unset( self::$templates[ $key ] );
+				unset( self::$templates[$key] );
 				continue;
 			}
 
@@ -469,14 +469,12 @@ 
 				// Add the slug to the new array.
 				$template['category_slugs'][] = $category_slug;
 
-				if ( ! isset( self::$categories[ $category_slug ] ) ) {
-					self::$categories[ $category_slug ] = array(
+				if ( ! isset( self::$categories[$category_slug] ) ) {
+					self::$categories[$category_slug] = array(
 						'name'  => $category,
 						'count' => 0,
 					);
-				}
-
-				++self::$categories[ $category_slug ]['count'];
+				} ++self::$categories[$category_slug]['count'];
 			}
 
 			// Mark the template as favorite if it's in the favorite templates list.
@@ -491,7 +489,7 @@ 
 		$redundant_cats = array_merge( array( 'PayPal', 'Stripe', 'Twilio' ), FrmFormsHelper::get_license_types() );
 		foreach ( $redundant_cats as $redundant_cat ) {
 			$category_slug = sanitize_title( $redundant_cat );
-			unset( self::$categories[ $category_slug ] );
+			unset( self::$categories[$category_slug] );
 		}
 
 		// Sort the categories by keys alphabetically.
@@ -516,7 +514,7 @@ 
 				'count' => 0,
 			);
 		}
-		$special_categories['all-items']      = array(
+		$special_categories['all-items'] = array(
 			'name'  => __( 'All Templates', 'formidable' ),
 			'count' => self::get_template_count(),
 		);
@@ -539,9 +537,9 @@ 
 	 */
 	private static function assign_featured_templates() {
 		foreach ( self::FEATURED_TEMPLATES_KEYS as $key ) {
-			if ( isset( self::$templates[ $key ] ) ) {
-				self::$templates[ $key ]['is_featured'] = true;
-				self::$featured_templates[]             = self::$templates[ $key ];
+			if ( isset( self::$templates[$key] ) ) {
+				self::$templates[$key]['is_featured'] = true;
+				self::$featured_templates[]             = self::$templates[$key];
 			}
 		}
 	}

classes/models/fields/FrmFieldGdpr.php

Spacing +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
 
 			if ( ! $required && empty( $args['value'] ) ) {
 				$frm_settings                    = FrmAppHelper::get_settings();
-				$errors[ 'field' . $args['id'] ] = str_replace( '[field_name]', is_object( $this->field ) ? $this->field->name : $this->field['name'], $frm_settings->blank_msg );
+				$errors['field' . $args['id']] = str_replace( '[field_name]', is_object( $this->field ) ? $this->field->name : $this->field['name'], $frm_settings->blank_msg );
 			}
 		}
 

classes/models/FrmHoneypot.php

Spacing +1 added lines, -1 removed lines

@@ -208,7 +208,7 @@
 			return '';
 		}
 
-		return isset( $item_meta[ $field_id ] ) ? $item_meta[ $field_id ] : '';
+		return isset( $item_meta[$field_id] ) ? $item_meta[$field_id] : '';
 	}
 
 	/**

classes/models/FrmFormAction.php

Spacing +38 added lines, -38 removed lines

@@ -208,9 +208,9 @@ 
 		$groups = FrmFormActionsController::form_action_groups();
 		$group  = 'misc';
 
-		if ( isset( $action_options['group'] ) && isset( $groups[ $action_options['group'] ] ) ) {
+		if ( isset( $action_options['group'] ) && isset( $groups[$action_options['group']] ) ) {
 			$group = $action_options['group'];
-		} elseif ( isset( $groups[ $this->id_base ] ) ) {
+		} elseif ( isset( $groups[$this->id_base] ) ) {
 			$group = $this->id_base;
 		} else {
 			foreach ( $groups as $name => $check_group ) {
@@ -221,8 +221,8 @@ 
 			}
 		}
 
-		$groups[ $group ]['id'] = $group;
-		return $groups[ $group ];
+		$groups[$group]['id'] = $group;
+		return $groups[$group];
 	}
 
 	/**
@@ -333,7 +333,7 @@ 
 	 * @return int $post_id
 	 */
 	public function maybe_create_action( $action, $forms ) {
-		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[ $action['menu_order'] ] ) && $forms[ $action['menu_order'] ] === 'updated' ) {
+		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[$action['menu_order']] ) && $forms[$action['menu_order']] === 'updated' ) {
 			// Update action only
 			$action['post_content'] = FrmAppHelper::maybe_json_decode( $action['post_content'] );
 			$post_id                = $this->save_settings( $action );
@@ -356,18 +356,18 @@ 
 		$switch             = $this->get_global_switch_fields();
 
 		foreach ( (array) $action->post_content as $key => $val ) {
-			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[ $val ] ) ) {
-				$action->post_content[ $key ] = $frm_duplicate_ids[ $val ];
+			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[$val] ) ) {
+				$action->post_content[$key] = $frm_duplicate_ids[$val];
 			} elseif ( ! is_array( $val ) ) {
-				$action->post_content[ $key ] = FrmFieldsHelper::switch_field_ids( $val );
-			} elseif ( isset( $switch[ $key ] ) && is_array( $switch[ $key ] ) ) {
+				$action->post_content[$key] = FrmFieldsHelper::switch_field_ids( $val );
+			} elseif ( isset( $switch[$key] ) && is_array( $switch[$key] ) ) {
 				// loop through each value if empty
-				if ( empty( $switch[ $key ] ) ) {
-					$switch[ $key ] = array_keys( $val );
+				if ( empty( $switch[$key] ) ) {
+					$switch[$key] = array_keys( $val );
 				}
 
-				foreach ( $switch[ $key ] as $subkey ) {
-					$action->post_content[ $key ] = $this->duplicate_array_walk( $action->post_content[ $key ], $subkey, $val );
+				foreach ( $switch[$key] as $subkey ) {
+					$action->post_content[$key] = $this->duplicate_array_walk( $action->post_content[$key], $subkey, $val );
 				}
 			}
 
@@ -385,20 +385,20 @@ 
 			foreach ( $subkey as $subkey2 ) {
 				foreach ( (array) $val as $ck => $cv ) {
 					if ( is_array( $cv ) ) {
-						$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey2, $cv );
-					} elseif ( isset( $cv[ $subkey ] ) && is_numeric( $cv[ $subkey ] ) && isset( $frm_duplicate_ids[ $cv[ $subkey ] ] ) ) {
-						$action[ $ck ][ $subkey ] = $frm_duplicate_ids[ $cv[ $subkey ] ];
+						$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey2, $cv );
+					} elseif ( isset( $cv[$subkey] ) && is_numeric( $cv[$subkey] ) && isset( $frm_duplicate_ids[$cv[$subkey]] ) ) {
+						$action[$ck][$subkey] = $frm_duplicate_ids[$cv[$subkey]];
 					}
 				}
 			}
 		} else {
 			foreach ( (array) $val as $ck => $cv ) {
 				if ( is_array( $cv ) ) {
-					$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey, $cv );
-				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[ $cv ] ) ) {
-					$action[ $ck ] = $frm_duplicate_ids[ $cv ];
+					$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey, $cv );
+				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[$cv] ) ) {
+					$action[$ck] = $frm_duplicate_ids[$cv];
 				} elseif ( $ck == $subkey ) {
-					$action[ $ck ] = $this->maybe_switch_field_ids( $action[ $ck ] );
+					$action[$ck] = $this->maybe_switch_field_ids( $action[$ck] );
 				}
 			}
 		}//end if
@@ -422,10 +422,10 @@ 
 		}
 
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
-		if ( isset( $_POST[ $this->option_name ] ) && is_array( $_POST[ $this->option_name ] ) ) {
+		if ( isset( $_POST[$this->option_name] ) && is_array( $_POST[$this->option_name] ) ) {
 			// Sanitizing removes scripts and <email> type of values.
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
-			$settings = wp_unslash( $_POST[ $this->option_name ] );
+			$settings = wp_unslash( $_POST[$this->option_name] );
 		} else {
 			return;
 		}
@@ -435,7 +435,7 @@ 
 		foreach ( $settings as $number => $new_instance ) {
 			$this->_set( $number );
 
-			$old_instance = isset( $all_instances[ $number ] ) ? $all_instances[ $number ] : array();
+			$old_instance = isset( $all_instances[$number] ) ? $all_instances[$number] : array();
 
 			if ( ! isset( $new_instance['post_status'] ) ) {
 				$new_instance['post_status'] = 'draft';
@@ -474,7 +474,7 @@ 
 			$instance['post_content'] = apply_filters( 'frm_before_save_' . $this->id_base . '_action', $instance['post_content'], $instance, $new_instance, $old_instance, $this );
 
 			if ( false !== $instance ) {
-				$all_instances[ $number ] = $instance;
+				$all_instances[$number] = $instance;
 			}
 
 			$action_ids[] = $this->save_settings( $instance );
@@ -560,12 +560,12 @@ 
 			// some plugins/themes are formatting the post_excerpt
 			$action->post_excerpt = sanitize_title( $action->post_excerpt );
 
-			if ( ! isset( $action_controls[ $action->post_excerpt ] ) ) {
+			if ( ! isset( $action_controls[$action->post_excerpt] ) ) {
 				continue;
 			}
 
-			$action                  = $action_controls[ $action->post_excerpt ]->prepare_action( $action );
-			$settings[ $action->ID ] = $action;
+			$action                  = $action_controls[$action->post_excerpt]->prepare_action( $action );
+			$settings[$action->ID] = $action;
 
 			if ( count( $settings ) >= $limit ) {
 				break;
@@ -591,7 +591,7 @@ 
 	 * @return int The filtered limit value.
 	 */
 	public static function get_action_limit( $form_id, $limit = 99 ) {
-		$type  = 'all';
+		$type = 'all';
 		return (int) apply_filters( 'frm_form_action_limit', (int) $limit, compact( 'type', 'form_id' ) );
 	}
 
@@ -614,7 +614,7 @@ 
 			'limit'       => 99,
 			'post_status' => $default_status,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 	}
 
 	/**
@@ -684,7 +684,7 @@ 
 
 			$action = $this->prepare_action( $action );
 
-			$settings[ $action->ID ] = $action;
+			$settings[$action->ID] = $action;
 		}
 
 		if ( 1 === $limit ) {
@@ -727,10 +727,10 @@ 
 
 		foreach ( $default_values as $k => $vals ) {
 			if ( is_array( $vals ) && ! empty( $vals ) ) {
-				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[ $k ] ) ) {
+				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[$k] ) ) {
 					continue;
 				}
-				$action->post_content[ $k ] = wp_parse_args( $action->post_content[ $k ], $vals );
+				$action->post_content[$k] = wp_parse_args( $action->post_content[$k], $vals );
 			}
 		}
 
@@ -818,9 +818,9 @@ 
 
 		// fill with existing options
 		foreach ( $action->post_content as $name => $val ) {
-			if ( isset( $form->options[ $name ] ) ) {
-				$action->post_content[ $name ] = $form->options[ $name ];
-				unset( $form->options[ $name ] );
+			if ( isset( $form->options[$name] ) ) {
+				$action->post_content[$name] = $form->options[$name];
+				unset( $form->options[$name] );
 			}
 		}
 
@@ -906,8 +906,8 @@ 
 	private static function get_value_from_entry( $entry, $field_id ) {
 		$observed_value = '';
 
-		if ( isset( $entry->metas[ $field_id ] ) ) {
-			$observed_value = $entry->metas[ $field_id ];
+		if ( isset( $entry->metas[$field_id] ) ) {
+			$observed_value = $entry->metas[$field_id];
 		} elseif ( $entry->post_id && FrmAppHelper::pro_is_installed() ) {
 			$field          = FrmField::getOne( $field_id );
 			$observed_value = FrmProEntryMetaHelper::get_post_or_meta_value(
@@ -981,7 +981,7 @@ 
 		$form_fields = FrmField::get_all_for_form( $form_id, '', 'include' );
 		return array_filter(
 			$form_fields,
-			function ( $form_field ) {
+			function( $form_field ) {
 				return ! FrmField::is_no_save_field( $form_field->type );
 			}
 		);

classes/views/solutions/_import.php

Spacing +3 added lines, -3 removed lines

@@ -11,7 +11,7 @@ 
 				$info['url'] = $xml;
 			}
 
-			$disabled = isset( $imported[ $info['form'] ] ) ? ' disabled' : '';
+			$disabled = isset( $imported[$info['form']] ) ? ' disabled' : '';
 			$url      = isset( $info['url'] ) ? $info['url'] : '';
 			$value    = $importing === 'form' ? $info['form'] : $info['key'];
 			if ( ! isset( $info['img'] ) ) {
@@ -21,7 +21,7 @@ 
 				continue;
 			}
 
-			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[ $info['form'] ] ) );
+			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[$info['form']] ) );
 			?>
 			<div class="frm_radio radio-inline radio frm_image_option<?php echo esc_attr( $importing === 'view' ? ' show_sub_opt show_' . $info['form'] : '' ); ?>" style="<?php echo esc_attr( $hide_views ? 'display:none' : '' ); ?>">
 				<?php if ( $importing === 'form' ) { ?>
@@ -54,7 +54,7 @@ 
 							}
 
 							if ( $importing === 'form' && $disabled ) {
-								FrmAppHelper::kses_echo( FrmFormsHelper::edit_form_link( $imported[ $info['form'] ] ), array( 'a' ) );
+								FrmAppHelper::kses_echo( FrmFormsHelper::edit_form_link( $imported[$info['form']] ), array( 'a' ) );
 							} else {
 								echo esc_html( $info['name'] );
 							}

classes/models/FrmUsage.php

Spacing +9 added lines, -9 removed lines

@@ -126,7 +126,7 @@ 
 		);
 
 		foreach ( $skipped_keys as $skipped_key ) {
-			unset( $data[ $skipped_key ] );
+			unset( $data[$skipped_key] );
 		}
 
 		return $data;
@@ -224,7 +224,7 @@ 
 
 		foreach ( $pass_settings as $setting ) {
 			if ( isset( $settings_list->$setting ) ) {
-				$settings[ $setting ] = $this->maybe_json( $settings_list->$setting );
+				$settings[$setting] = $this->maybe_json( $settings_list->$setting );
 			}
 		}
 
@@ -260,7 +260,7 @@ 
 
 		$message_settings = array();
 		foreach ( $messages as $message ) {
-			$message_settings[ 'changed-' . $message ] = $settings_list->$message === $default[ $message ] ? 0 : 1;
+			$message_settings['changed-' . $message] = $settings_list->$message === $default[$message] ? 0 : 1;
 		}
 
 		return $message_settings;
@@ -280,7 +280,7 @@ 
 
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
 			if ( isset( $settings_list->$frm_role ) ) {
-				$permissions[ $frm_role ] = $settings_list->$frm_role;
+				$permissions[$frm_role] = $settings_list->$frm_role;
 			}
 		}
 
@@ -351,9 +351,9 @@ 
 			);
 
 			foreach ( $settings as $setting ) {
-				if ( isset( $form->options[ $setting ] ) ) {
+				if ( isset( $form->options[$setting] ) ) {
 					if ( 'custom_style' === $setting ) {
-						$style->id = $form->options[ $setting ];
+						$style->id = $form->options[$setting];
 
 						if ( ! $style->id ) {
 							$style_name = 0;
@@ -364,9 +364,9 @@ 
 							$style_name = $style_post ? $style_post->post_name : 'formidable-style';
 						}
 
-						$new_form[ $setting ] = $style_name;
+						$new_form[$setting] = $style_name;
 					} else {
-						$new_form[ $setting ] = $this->maybe_json( $form->options[ $setting ] );
+						$new_form[$setting] = $this->maybe_json( $form->options[$setting] );
 					}
 				}
 			}
@@ -426,7 +426,7 @@ 
 		$fields = FrmDb::get_results( 'frm_fields', array(), 'id, form_id, name, type, field_options', $args );
 		foreach ( $fields as $k => $field ) {
 			FrmAppHelper::unserialize_or_decode( $field->field_options );
-			$fields[ $k ]->field_options = json_encode( $field->field_options );
+			$fields[$k]->field_options = json_encode( $field->field_options );
 		}
 		return $fields;
 	}

square/helpers/FrmSquareLiteConnectHelper.php

Spacing +1 added lines, -1 removed lines

@@ -160,7 +160,7 @@
 	 * @return object|string
 	 */
 	private static function post_to_connect_server( $action, $additional_body = array() ) {
-		$body    = array(
+		$body = array(
 			'frm_square_api_action' => $action,
 			'frm_square_api_mode'   => FrmSquareLiteAppHelper::active_mode(),
 		);

stripe/helpers/FrmTransLiteAppHelper.php

Spacing +7 added lines, -7 removed lines

@@ -66,7 +66,7 @@ 
 	 */
 	public static function show_status( $status ) {
 		$statuses = array_merge( self::get_payment_statuses(), self::get_subscription_statuses() );
-		return isset( $statuses[ $status ] ) ? $statuses[ $status ] : $status;
+		return isset( $statuses[$status] ) ? $statuses[$status] : $status;
 	}
 
 	/**
@@ -152,7 +152,7 @@ 
 	 */
 	public static function get_action_setting( $option, $atts ) {
 		$settings = self::get_action_settings( $atts );
-		$value    = isset( $settings[ $option ] ) ? $settings[ $option ] : '';
+		$value    = isset( $settings[$option] ) ? $settings[$option] : '';
 		return $value;
 	}
 
@@ -255,8 +255,8 @@ 
 	 */
 	public static function get_repeat_label_from_value( $value, $number ) {
 		$times = self::get_plural_repeat_times( $number );
-		if ( isset( $times[ $value ] ) ) {
-			$value = $times[ $value ];
+		if ( isset( $times[$value] ) ) {
+			$value = $times[$value];
 		}
 		return $value;
 	}
@@ -504,7 +504,7 @@ 
 		$count = 0;
 		foreach ( $payments as $payment ) {
 			if ( $payment->status === 'complete' ) {
-				$count++;
+				$count ++;
 			}
 		}
 
@@ -526,8 +526,8 @@ 
 		if ( is_array( $gateway ) ) {
 			$gateway = reset( $gateway );
 		}
-		if ( isset( $gateways[ $gateway ] ) ) {
-			$value = $gateways[ $gateway ][ $setting ];
+		if ( isset( $gateways[$gateway] ) ) {
+			$value = $gateways[$gateway][$setting];
 		}
 		return $value;
 	}

classes/models/FrmValidate.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 		}
 
 		$form = $this->get_form();
-		return ! empty( $form->options[ $key ] ) && 'off' !== $form->options[ $key ];
+		return ! empty( $form->options[$key] ) && 'off' !== $form->options[$key];
 	}
 
 	/**