Completed
Pull Request — master (#2624)
by
unknown
42s
created
classes/models/FrmHoneypot.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -274,7 +274,7 @@
 block discarded – undo
274 274
 			return '';
275 275
 		}
276 276
 
277
-		return $item_meta[ $field_id ] ?? '';
277
+		return $item_meta[$field_id] ?? '';
278 278
 	}
279 279
 
280 280
 	/**
Please login to merge, or discard this patch.
classes/models/FrmYoutubeFeedApi.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,6 +40,6 @@
 block discarded – undo
40 40
 	 */
41 41
 	public function get_video( $type = 'welcome' ) {
42 42
 		$videos = $this->get_api_info();
43
-		return $videos[ $type ] ?? array();
43
+		return $videos[$type] ?? array();
44 44
 	}
45 45
 }
Please login to merge, or discard this patch.
classes/models/FrmSettings.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -239,8 +239,8 @@  discard block
 block discarded – undo
239 239
 		}
240 240
 
241 241
 		foreach ( $settings as $setting => $default ) {
242
-			if ( isset( $params[ 'frm_' . $setting ] ) ) {
243
-				$this->{$setting} = $params[ 'frm_' . $setting ];
242
+			if ( isset( $params['frm_' . $setting] ) ) {
243
+				$this->{$setting} = $params['frm_' . $setting];
244 244
 			} elseif ( ! isset( $this->{$setting} ) ) {
245 245
 				$this->{$setting} = $default;
246 246
 			}
@@ -432,7 +432,7 @@  discard block
 block discarded – undo
432 432
 			'denylist_check',
433 433
 		);
434 434
 		foreach ( $checkboxes as $set ) {
435
-			$this->$set = isset( $params[ 'frm_' . $set ] ) ? absint( $params[ 'frm_' . $set ] ) : 0;
435
+			$this->$set = isset( $params['frm_' . $set] ) ? absint( $params['frm_' . $set] ) : 0;
436 436
 		}
437 437
 	}
438 438
 
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
 		$frm_roles = FrmAppHelper::frm_capabilities();
446 446
 		$roles     = get_editable_roles();
447 447
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
448
-			$this->$frm_role = (array) ( $params[ $frm_role ] ?? 'administrator' );
448
+			$this->$frm_role = (array) ( $params[$frm_role] ?? 'administrator' );
449 449
 
450 450
 			// Make sure administrators always have permissions
451 451
 			if ( ! in_array( 'administrator', $this->$frm_role, true ) ) {
Please login to merge, or discard this patch.
classes/models/FrmFormAction.php 1 patch
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -208,9 +208,9 @@  discard block
 block discarded – undo
208 208
 		$groups = FrmFormActionsController::form_action_groups();
209 209
 		$group  = 'misc';
210 210
 
211
-		if ( isset( $action_options['group'] ) && isset( $groups[ $action_options['group'] ] ) ) {
211
+		if ( isset( $action_options['group'] ) && isset( $groups[$action_options['group']] ) ) {
212 212
 			$group = $action_options['group'];
213
-		} elseif ( isset( $groups[ $this->id_base ] ) ) {
213
+		} elseif ( isset( $groups[$this->id_base] ) ) {
214 214
 			$group = $this->id_base;
215 215
 		} else {
216 216
 			foreach ( $groups as $name => $check_group ) {
@@ -221,8 +221,8 @@  discard block
 block discarded – undo
221 221
 			}
222 222
 		}
223 223
 
224
-		$groups[ $group ]['id'] = $group;
225
-		return $groups[ $group ];
224
+		$groups[$group]['id'] = $group;
225
+		return $groups[$group];
226 226
 	}
227 227
 
228 228
 	/**
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
 	 * @return int $post_id
334 334
 	 */
335 335
 	public function maybe_create_action( $action, $forms ) {
336
-		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[ $action['menu_order'] ] ) && $forms[ $action['menu_order'] ] === 'updated' ) {
336
+		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[$action['menu_order']] ) && $forms[$action['menu_order']] === 'updated' ) {
337 337
 			// Update action only
338 338
 			$action['post_content'] = FrmAppHelper::maybe_json_decode( $action['post_content'] );
339 339
 			$post_id                = $this->save_settings( $action );
@@ -356,18 +356,18 @@  discard block
 block discarded – undo
356 356
 		$switch             = $this->get_global_switch_fields();
357 357
 
358 358
 		foreach ( (array) $action->post_content as $key => $val ) {
359
-			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[ $val ] ) ) {
360
-				$action->post_content[ $key ] = $frm_duplicate_ids[ $val ];
359
+			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[$val] ) ) {
360
+				$action->post_content[$key] = $frm_duplicate_ids[$val];
361 361
 			} elseif ( ! is_array( $val ) ) {
362
-				$action->post_content[ $key ] = FrmFieldsHelper::switch_field_ids( $val );
363
-			} elseif ( isset( $switch[ $key ] ) && is_array( $switch[ $key ] ) ) {
362
+				$action->post_content[$key] = FrmFieldsHelper::switch_field_ids( $val );
363
+			} elseif ( isset( $switch[$key] ) && is_array( $switch[$key] ) ) {
364 364
 				// loop through each value if empty
365
-				if ( empty( $switch[ $key ] ) ) {
366
-					$switch[ $key ] = array_keys( $val );
365
+				if ( empty( $switch[$key] ) ) {
366
+					$switch[$key] = array_keys( $val );
367 367
 				}
368 368
 
369
-				foreach ( $switch[ $key ] as $subkey ) {
370
-					$action->post_content[ $key ] = $this->duplicate_array_walk( $action->post_content[ $key ], $subkey, $val );
369
+				foreach ( $switch[$key] as $subkey ) {
370
+					$action->post_content[$key] = $this->duplicate_array_walk( $action->post_content[$key], $subkey, $val );
371 371
 				}
372 372
 			}
373 373
 
@@ -385,20 +385,20 @@  discard block
 block discarded – undo
385 385
 			foreach ( $subkey as $subkey2 ) {
386 386
 				foreach ( (array) $val as $ck => $cv ) {
387 387
 					if ( is_array( $cv ) ) {
388
-						$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey2, $cv );
389
-					} elseif ( isset( $cv[ $subkey ] ) && is_numeric( $cv[ $subkey ] ) && isset( $frm_duplicate_ids[ $cv[ $subkey ] ] ) ) {
390
-						$action[ $ck ][ $subkey ] = $frm_duplicate_ids[ $cv[ $subkey ] ];
388
+						$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey2, $cv );
389
+					} elseif ( isset( $cv[$subkey] ) && is_numeric( $cv[$subkey] ) && isset( $frm_duplicate_ids[$cv[$subkey]] ) ) {
390
+						$action[$ck][$subkey] = $frm_duplicate_ids[$cv[$subkey]];
391 391
 					}
392 392
 				}
393 393
 			}
394 394
 		} else {
395 395
 			foreach ( (array) $val as $ck => $cv ) {
396 396
 				if ( is_array( $cv ) ) {
397
-					$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey, $cv );
398
-				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[ $cv ] ) ) {
399
-					$action[ $ck ] = $frm_duplicate_ids[ $cv ];
397
+					$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey, $cv );
398
+				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[$cv] ) ) {
399
+					$action[$ck] = $frm_duplicate_ids[$cv];
400 400
 				} elseif ( $ck == $subkey ) {
401
-					$action[ $ck ] = $this->maybe_switch_field_ids( $action[ $ck ] );
401
+					$action[$ck] = $this->maybe_switch_field_ids( $action[$ck] );
402 402
 				}
403 403
 			}
404 404
 		}//end if
@@ -422,10 +422,10 @@  discard block
 block discarded – undo
422 422
 		}
423 423
 
424 424
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
425
-		if ( isset( $_POST[ $this->option_name ] ) && is_array( $_POST[ $this->option_name ] ) ) {
425
+		if ( isset( $_POST[$this->option_name] ) && is_array( $_POST[$this->option_name] ) ) {
426 426
 			// Sanitizing removes scripts and <email> type of values.
427 427
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
428
-			$settings = wp_unslash( $_POST[ $this->option_name ] );
428
+			$settings = wp_unslash( $_POST[$this->option_name] );
429 429
 		} else {
430 430
 			return;
431 431
 		}
@@ -435,7 +435,7 @@  discard block
 block discarded – undo
435 435
 		foreach ( $settings as $number => $new_instance ) {
436 436
 			$this->_set( $number );
437 437
 
438
-			$old_instance = $all_instances[ $number ] ?? array();
438
+			$old_instance = $all_instances[$number] ?? array();
439 439
 
440 440
 			if ( ! isset( $new_instance['post_status'] ) ) {
441 441
 				$new_instance['post_status'] = 'draft';
@@ -474,7 +474,7 @@  discard block
 block discarded – undo
474 474
 			$instance['post_content'] = apply_filters( 'frm_before_save_' . $this->id_base . '_action', $instance['post_content'], $instance, $new_instance, $old_instance, $this );
475 475
 
476 476
 			if ( false !== $instance ) {
477
-				$all_instances[ $number ] = $instance;
477
+				$all_instances[$number] = $instance;
478 478
 			}
479 479
 
480 480
 			$action_ids[] = $this->save_settings( $instance );
@@ -563,12 +563,12 @@  discard block
 block discarded – undo
563 563
 			// some plugins/themes are formatting the post_excerpt
564 564
 			$action->post_excerpt = sanitize_title( $action->post_excerpt );
565 565
 
566
-			if ( ! isset( $action_controls[ $action->post_excerpt ] ) ) {
566
+			if ( ! isset( $action_controls[$action->post_excerpt] ) ) {
567 567
 				continue;
568 568
 			}
569 569
 
570
-			$action                  = $action_controls[ $action->post_excerpt ]->prepare_action( $action );
571
-			$settings[ $action->ID ] = $action;
570
+			$action                  = $action_controls[$action->post_excerpt]->prepare_action( $action );
571
+			$settings[$action->ID] = $action;
572 572
 
573 573
 			if ( count( $settings ) >= $limit ) {
574 574
 				break;
@@ -594,7 +594,7 @@  discard block
 block discarded – undo
594 594
 	 * @return int The filtered limit value.
595 595
 	 */
596 596
 	public static function get_action_limit( $form_id, $limit = 99 ) {
597
-		$type  = 'all';
597
+		$type = 'all';
598 598
 		return (int) apply_filters( 'frm_form_action_limit', (int) $limit, compact( 'type', 'form_id' ) );
599 599
 	}
600 600
 
@@ -617,7 +617,7 @@  discard block
 block discarded – undo
617 617
 			'limit'       => 99,
618 618
 			'post_status' => $default_status,
619 619
 		);
620
-		$args     = wp_parse_args( $args, $defaults );
620
+		$args = wp_parse_args( $args, $defaults );
621 621
 	}
622 622
 
623 623
 	/**
@@ -687,7 +687,7 @@  discard block
 block discarded – undo
687 687
 
688 688
 			$action = $this->prepare_action( $action );
689 689
 
690
-			$settings[ $action->ID ] = $action;
690
+			$settings[$action->ID] = $action;
691 691
 		}
692 692
 
693 693
 		if ( 1 === $limit ) {
@@ -730,10 +730,10 @@  discard block
 block discarded – undo
730 730
 
731 731
 		foreach ( $default_values as $k => $vals ) {
732 732
 			if ( is_array( $vals ) && ! empty( $vals ) ) {
733
-				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[ $k ] ) ) {
733
+				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[$k] ) ) {
734 734
 					continue;
735 735
 				}
736
-				$action->post_content[ $k ] = wp_parse_args( $action->post_content[ $k ], $vals );
736
+				$action->post_content[$k] = wp_parse_args( $action->post_content[$k], $vals );
737 737
 			}
738 738
 		}
739 739
 
@@ -821,9 +821,9 @@  discard block
 block discarded – undo
821 821
 
822 822
 		// fill with existing options
823 823
 		foreach ( $action->post_content as $name => $val ) {
824
-			if ( isset( $form->options[ $name ] ) ) {
825
-				$action->post_content[ $name ] = $form->options[ $name ];
826
-				unset( $form->options[ $name ] );
824
+			if ( isset( $form->options[$name] ) ) {
825
+				$action->post_content[$name] = $form->options[$name];
826
+				unset( $form->options[$name] );
827 827
 			}
828 828
 		}
829 829
 
@@ -883,8 +883,8 @@  discard block
 block discarded – undo
883 883
 	private static function get_value_from_entry( $entry, $field_id ) {
884 884
 		$observed_value = '';
885 885
 
886
-		if ( isset( $entry->metas[ $field_id ] ) ) {
887
-			$observed_value = $entry->metas[ $field_id ];
886
+		if ( isset( $entry->metas[$field_id] ) ) {
887
+			$observed_value = $entry->metas[$field_id];
888 888
 		} elseif ( $entry->post_id && FrmAppHelper::pro_is_installed() ) {
889 889
 			$field          = FrmField::getOne( $field_id );
890 890
 			$observed_value = FrmProEntryMetaHelper::get_post_or_meta_value(
@@ -958,7 +958,7 @@  discard block
 block discarded – undo
958 958
 		$form_fields = FrmField::get_all_for_form( $form_id, '', 'include' );
959 959
 		return array_filter(
960 960
 			$form_fields,
961
-			function ( $form_field ) {
961
+			function( $form_field ) {
962 962
 				return ! FrmField::is_no_save_field( $form_field->type );
963 963
 			}
964 964
 		);
Please login to merge, or discard this patch.
classes/helpers/FrmHtmlHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 		wp_enqueue_script( 'formidable_settings' );
29 29
 		return FrmAppHelper::clip(
30 30
 			// @phpstan-ignore-next-line
31
-			function () use ( $id, $name, $args ) {
31
+			function() use ( $id, $name, $args ) {
32 32
 				require FrmAppHelper::plugin_path() . '/classes/views/shared/toggle.php';
33 33
 			},
34 34
 			$args['echo'] ?? false
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 			}
98 98
 		}
99 99
 
100
-		$input_number_attrs          = array_merge(
100
+		$input_number_attrs = array_merge(
101 101
 			$args['input_number_attrs'],
102 102
 			array(
103 103
 				'type'  => ! empty( $selected_unit ) ? 'number' : 'text',
Please login to merge, or discard this patch.
classes/helpers/FrmOnSubmitHelper.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -219,17 +219,17 @@  discard block
 block discarded – undo
219 219
 	public static function populate_on_submit_data( &$form_options, $action = null, $event = 'create' ) {
220 220
 		$opt = 'update' === $event ? 'edit_' : 'success_';
221 221
 		if ( ! $action || ! is_object( $action ) ) {
222
-			$form_options[ $opt . 'action' ] = self::get_default_action_type();
223
-			$form_options[ $opt . 'msg' ]    = self::get_default_msg();
222
+			$form_options[$opt . 'action'] = self::get_default_action_type();
223
+			$form_options[$opt . 'msg']    = self::get_default_msg();
224 224
 
225 225
 			return;
226 226
 		}
227 227
 
228
-		$form_options[ $opt . 'action' ] = $action->post_content['success_action'] ?? 'message';
228
+		$form_options[$opt . 'action'] = $action->post_content['success_action'] ?? 'message';
229 229
 
230
-		switch ( $form_options[ $opt . 'action' ] ) {
230
+		switch ( $form_options[$opt . 'action'] ) {
231 231
 			case 'redirect':
232
-				$form_options[ $opt . 'url' ]        = $action->post_content['success_url'] ?? '';
232
+				$form_options[$opt . 'url']        = $action->post_content['success_url'] ?? '';
233 233
 				$form_options['open_in_new_tab']     = ! empty( $action->post_content['open_in_new_tab'] );
234 234
 				$form_options['redirect_delay']      = ! empty( $action->post_content['redirect_delay'] );
235 235
 				$form_options['redirect_delay_time'] = $action->post_content['redirect_delay_time'];
@@ -237,11 +237,11 @@  discard block
 block discarded – undo
237 237
 				break;
238 238
 
239 239
 			case 'page':
240
-				$form_options[ $opt . 'page_id' ] = $action->post_content['success_page_id'] ?? '';
240
+				$form_options[$opt . 'page_id'] = $action->post_content['success_page_id'] ?? '';
241 241
 				break;
242 242
 
243 243
 			default:
244
-				$form_options[ $opt . 'msg' ] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : self::get_default_msg();
244
+				$form_options[$opt . 'msg'] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : self::get_default_msg();
245 245
 				$form_options['show_form']    = ! empty( $action->post_content['show_form'] );
246 246
 		}
247 247
 	}
@@ -330,20 +330,20 @@  discard block
 block discarded – undo
330 330
 	private static function get_on_submit_action_data_from_form_options( $form_options, $event = 'create' ) {
331 331
 		$opt  = 'update' === $event ? 'edit_' : 'success_';
332 332
 		$data = array(
333
-			'success_action' => $form_options[ $opt . 'action' ] ?? self::get_default_action_type(),
333
+			'success_action' => $form_options[$opt . 'action'] ?? self::get_default_action_type(),
334 334
 		);
335 335
 
336 336
 		switch ( $data['success_action'] ) {
337 337
 			case 'redirect':
338
-				$data['success_url'] = $form_options[ $opt . 'url' ] ?? '';
338
+				$data['success_url'] = $form_options[$opt . 'url'] ?? '';
339 339
 				break;
340 340
 
341 341
 			case 'page':
342
-				$data['success_page_id'] = $form_options[ $opt . 'page_id' ] ?? '';
342
+				$data['success_page_id'] = $form_options[$opt . 'page_id'] ?? '';
343 343
 				break;
344 344
 
345 345
 			default:
346
-				$data['success_msg'] = $form_options[ $opt . 'msg' ] ?? self::get_default_msg();
346
+				$data['success_msg'] = $form_options[$opt . 'msg'] ?? self::get_default_msg();
347 347
 				$data['show_form']   = ! empty( $form_options['show_form'] );
348 348
 		}
349 349
 
Please login to merge, or discard this patch.
classes/helpers/FrmFormsHelper.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 			'class'        => '',
38 38
 			'inc_children' => 'exclude',
39 39
 		);
40
-		$args     = wp_parse_args( $args, $defaults );
40
+		$args = wp_parse_args( $args, $defaults );
41 41
 
42 42
 		if ( ! $args['field_id'] ) {
43 43
 			$args['field_id'] = $field_name;
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	 */
79 79
 	public static function add_html_attr( $class, $param, &$add_html ) {
80 80
 		if ( ! empty( $class ) ) {
81
-			$add_html[ $param ] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
81
+			$add_html[$param] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
82 82
 		}
83 83
 	}
84 84
 
@@ -322,8 +322,8 @@  discard block
 block discarded – undo
322 322
 			'description' => '',
323 323
 		);
324 324
 		foreach ( $defaults as $var => $default ) {
325
-			if ( ! isset( $values[ $var ] ) ) {
326
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
325
+			if ( ! isset( $values[$var] ) ) {
326
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
327 327
 			}
328 328
 		}
329 329
 
@@ -338,8 +338,8 @@  discard block
 block discarded – undo
338 338
 			'parent_form_id' => 0,
339 339
 		);
340 340
 		foreach ( $defaults as $var => $default ) {
341
-			if ( ! isset( $values[ $var ] ) ) {
342
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
341
+			if ( ! isset( $values[$var] ) ) {
342
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
343 343
 			}
344 344
 		}
345 345
 		unset( $defaults );
@@ -376,16 +376,16 @@  discard block
 block discarded – undo
376 376
 		$defaults = self::get_default_opts();
377 377
 		foreach ( $defaults as $var => $default ) {
378 378
 			if ( is_array( $default ) ) {
379
-				if ( ! isset( $values[ $var ] ) ) {
380
-					$values[ $var ] = $record && isset( $record->options[ $var ] ) ? $record->options[ $var ] : array();
379
+				if ( ! isset( $values[$var] ) ) {
380
+					$values[$var] = $record && isset( $record->options[$var] ) ? $record->options[$var] : array();
381 381
 				}
382 382
 
383 383
 				foreach ( $default as $k => $v ) {
384
-					$values[ $var ][ $k ] = $post_values && isset( $post_values[ $var ][ $k ] ) ? $post_values[ $var ][ $k ] : ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) ? $record->options[ $var ][ $k ] : $v );
384
+					$values[$var][$k] = $post_values && isset( $post_values[$var][$k] ) ? $post_values[$var][$k] : ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) ? $record->options[$var][$k] : $v );
385 385
 
386 386
 					if ( is_array( $v ) ) {
387 387
 						foreach ( $v as $k1 => $v1 ) {
388
-							$values[ $var ][ $k ][ $k1 ] = $post_values && isset( $post_values[ $var ][ $k ][ $k1 ] ) ? $post_values[ $var ][ $k ][ $k1 ] : ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) && isset( $record->options[ $var ][ $k ][ $k1 ] ) ? $record->options[ $var ][ $k ][ $k1 ] : $v1 );
388
+							$values[$var][$k][$k1] = $post_values && isset( $post_values[$var][$k][$k1] ) ? $post_values[$var][$k][$k1] : ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) && isset( $record->options[$var][$k][$k1] ) ? $record->options[$var][$k][$k1] : $v1 );
389 389
 							unset( $k1, $v1 );
390 390
 						}
391 391
 					}
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
 					unset( $k, $v );
394 394
 				}
395 395
 			} else {
396
-				$values[ $var ] = $post_values && isset( $post_values['options'][ $var ] ) ? $post_values['options'][ $var ] : ( $record && isset( $record->options[ $var ] ) ? $record->options[ $var ] : $default );
396
+				$values[$var] = $post_values && isset( $post_values['options'][$var] ) ? $post_values['options'][$var] : ( $record && isset( $record->options[$var] ) ? $record->options[$var] : $default );
397 397
 			}
398 398
 
399 399
 			unset( $var, $default );
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
 	public static function fill_form_options( &$options, $values ) {
439 439
 		$defaults = self::get_default_opts();
440 440
 		foreach ( $defaults as $var => $default ) {
441
-			$options[ $var ] = $values['options'][ $var ] ?? $default;
441
+			$options[$var] = $values['options'][$var] ?? $default;
442 442
 			unset( $var, $default );
443 443
 		}
444 444
 	}
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
 	public static function insert_opt_html( $args ) {
616 616
 		$class  = $args['class'] ?? '';
617 617
 		$fields = self::get_field_type_data_for_insert_opt_html();
618
-		$field  = $fields[ $args['type'] ] ?? array();
618
+		$field  = $fields[$args['type']] ?? array();
619 619
 
620 620
 		self::prepare_field_type( $field );
621 621
 
@@ -747,7 +747,7 @@  discard block
 block discarded – undo
747 747
 		$last_field         = false;
748 748
 		foreach ( $fields as $field ) {
749 749
 			if ( $prev_order === $field->field_order ) {
750
-				++$add_order;
750
+				++ $add_order;
751 751
 			}
752 752
 
753 753
 			if ( $add_order ) {
@@ -1221,8 +1221,8 @@  discard block
 block discarded – undo
1221 1221
 				$link .= ' onclick="return confirm(\'' . esc_attr( $link_details['confirm'] ) . '\')"';
1222 1222
 			}
1223 1223
 
1224
-			$label = ( $link_details[ $length ] ?? $link_details['label'] );
1225
-			if ( $length === 'icon' && isset( $link_details[ $length ] ) ) {
1224
+			$label = ( $link_details[$length] ?? $link_details['label'] );
1225
+			if ( $length === 'icon' && isset( $link_details[$length] ) ) {
1226 1226
 				$label = '<span class="' . $label . '" title="' . esc_attr( $link_details['label'] ) . '" aria-hidden="true"></span>';
1227 1227
 				$link .= ' aria-label="' . esc_attr( $link_details['label'] ) . '"';
1228 1228
 			}
@@ -1369,7 +1369,7 @@  discard block
 block discarded – undo
1369 1369
 			$status = 'publish';
1370 1370
 		}
1371 1371
 
1372
-		$name = $nice_names[ $status ];
1372
+		$name = $nice_names[$status];
1373 1373
 
1374 1374
 		return $name;
1375 1375
 	}
@@ -1433,7 +1433,7 @@  discard block
 block discarded – undo
1433 1433
 		$icon = $icons[''];
1434 1434
 		if ( count( $categories ) === 1 ) {
1435 1435
 			$category = reset( $categories );
1436
-			$icon     = $icons[ $category ] ?? $icon;
1436
+			$icon     = $icons[$category] ?? $icon;
1437 1437
 		} elseif ( ! empty( $categories ) ) {
1438 1438
 			$icons = array_intersect_key( $icons, array_flip( $categories ) );
1439 1439
 			$icon  = reset( $icons );
@@ -1555,7 +1555,7 @@  discard block
 block discarded – undo
1555 1555
 
1556 1556
 		foreach ( $item['categories'] as $k => $category ) {
1557 1557
 			if ( in_array( $category, $plans, true ) ) {
1558
-				unset( $item['categories'][ $k ] );
1558
+				unset( $item['categories'][$k] );
1559 1559
 
1560 1560
 				$category = self::convert_legacy_package_names( $category );
1561 1561
 
@@ -1594,7 +1594,7 @@  discard block
 block discarded – undo
1594 1594
 			'include_all' => true,
1595 1595
 			'case_lower'  => false,
1596 1596
 		);
1597
-		$args     = wp_parse_args( $args, $defaults );
1597
+		$args = wp_parse_args( $args, $defaults );
1598 1598
 
1599 1599
 		$license_types = array( 'Basic', 'Plus', 'Business', 'Elite' );
1600 1600
 
@@ -1797,9 +1797,9 @@  discard block
 block discarded – undo
1797 1797
 		}
1798 1798
 
1799 1799
 		foreach ( $shortcodes[0] as $key => $shortcode ) {
1800
-			$options = trim( $shortcodes[3][ $key ] );
1800
+			$options = trim( $shortcodes[3][$key] );
1801 1801
 
1802
-			if ( in_array( $shortcodes[1][ $key ], array( 'if ' ), true ) ) {
1802
+			if ( in_array( $shortcodes[1][$key], array( 'if ' ), true ) ) {
1803 1803
 				// Skip if shortcodes.
1804 1804
 				continue;
1805 1805
 			}
@@ -1809,7 +1809,7 @@  discard block
 block discarded – undo
1809 1809
 				continue;
1810 1810
 			}
1811 1811
 
1812
-			$new_shortcode = '[' . $shortcodes[2][ $key ];
1812
+			$new_shortcode = '[' . $shortcodes[2][$key];
1813 1813
 			if ( $options ) {
1814 1814
 				$new_shortcode .= ' ' . $options;
1815 1815
 			}
Please login to merge, or discard this patch.
classes/helpers/FrmSubmitHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	public static function get_current_action_from_global_var( $form_id ) {
86 86
 		global $frm_vars;
87 87
 
88
-		return $frm_vars['form_params'][ $form_id ]['action'] ?? 'create';
88
+		return $frm_vars['form_params'][$form_id]['action'] ?? 'create';
89 89
 	}
90 90
 
91 91
 	/**
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 	public static function remove_submit_field_from_list( &$fields ) {
178 178
 		foreach ( $fields as $key => $field ) {
179 179
 			if ( self::FIELD_TYPE === FrmField::get_field_type( $field ) ) {
180
-				unset( $fields[ $key ] );
180
+				unset( $fields[$key] );
181 181
 				return;
182 182
 			}
183 183
 		}
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 				array( 'field_order' => $new_order )
225 225
 			);
226 226
 			if ( false !== $updated ) {
227
-				self::$last_row_fields_order[ $last_row_field_id ] = $new_order;
227
+				self::$last_row_fields_order[$last_row_field_id] = $new_order;
228 228
 			}
229 229
 		}
230 230
 	}
Please login to merge, or discard this patch.
classes/models/FrmSalesApi.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
 		$cross_sell_links = $data['cross_sell_link'];
113 113
 		$index            = self::determine_cross_sell_index( $cross_sell_text );
114 114
 
115
-		self::$cross_sell_text = sanitize_text_field( $cross_sell_text[ $index ] );
116
-		self::$cross_sell_link = esc_url_raw( $cross_sell_links[ $index ] );
115
+		self::$cross_sell_text = sanitize_text_field( $cross_sell_text[$index] );
116
+		self::$cross_sell_link = esc_url_raw( $cross_sell_links[$index] );
117 117
 	}
118 118
 
119 119
 	/**
@@ -158,13 +158,13 @@  discard block
 block discarded – undo
158 158
 		}
159 159
 
160 160
 		foreach ( $cross_sell_text as $index => $current_text ) {
161
-			if ( ! isset( $cross_sell_settings[ $current_text ] ) ) {
162
-				$cross_sell_settings[ $current_text ] = time();
161
+			if ( ! isset( $cross_sell_settings[$current_text] ) ) {
162
+				$cross_sell_settings[$current_text] = time();
163 163
 				update_option( $option_name, $cross_sell_settings );
164 164
 				return $index;
165 165
 			}
166 166
 
167
-			$time_elapsed = time() - $cross_sell_settings[ $current_text ];
167
+			$time_elapsed = time() - $cross_sell_settings[$current_text];
168 168
 			if ( $time_elapsed < DAY_IN_SECONDS * 30 ) {
169 169
 				return $index;
170 170
 			}
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 			return;
198 198
 		}
199 199
 
200
-		self::$sales[ $sale['key'] ] = $this->fill_sale( $sale );
200
+		self::$sales[$sale['key']] = $this->fill_sale( $sale );
201 201
 	}
202 202
 
203 203
 	/**
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
 
305 305
 		$sale = self::$instance->get_best_sale();
306 306
 
307
-		return is_array( $sale ) && ! empty( $sale[ $key ] ) ? $sale[ $key ] : false;
307
+		return is_array( $sale ) && ! empty( $sale[$key] ) ? $sale[$key] : false;
308 308
 	}
309 309
 
310 310
 	/**
@@ -501,14 +501,14 @@  discard block
 block discarded – undo
501 501
 			esc_html( self::$cross_sell_text ),
502 502
 			'activate_plugins',
503 503
 			'frm-sales-api-cross-sell',
504
-			function () {
504
+			function() {
505 505
 				// There is no page. The redirect logic is handled below, before this callback is triggered.
506 506
 			}
507 507
 		);
508 508
 
509 509
 		add_action(
510 510
 			'admin_init',
511
-			function () {
511
+			function() {
512 512
 				if ( ! current_user_can( 'activate_plugins' ) ) {
513 513
 					return;
514 514
 				}
Please login to merge, or discard this patch.