Completed
Pull Request — master (#1356)
by Stephanie
01:08
created
classes/helpers/FrmEntriesHelper.php 2 patches
Braces   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -114,13 +114,16 @@  discard block
 block discarded – undo
114 114
 	 */
115 115
 	public static function value_is_posted( $field, $args ) {
116 116
 		$value_is_posted = false;
117
-		if ( $_POST ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
117
+		if ( $_POST ) {
118
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
118 119
 			$repeating = isset( $args['repeating'] ) && $args['repeating'];
119 120
 			if ( $repeating ) {
120
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
121
+				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) {
122
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
121 123
 					$value_is_posted = true;
122 124
 				}
123
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
125
+			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) {
126
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
124 127
 				$value_is_posted = true;
125 128
 			}
126 129
 		}
@@ -322,8 +325,10 @@  discard block
 block discarded – undo
322 325
 	 * @since 4.01
323 326
 	 */
324 327
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
325
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
326
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
328
+		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) {
329
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
330
+			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) {
331
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
327 332
 				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
328 333
 			}
329 334
 		} else {
@@ -395,7 +400,8 @@  discard block
 block discarded – undo
395 400
 		self::set_other_repeating_vals( $field, $value, $args );
396 401
 
397 402
 		// Check if there are any posted "Other" values.
398
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
403
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) {
404
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
399 405
 
400 406
 			// Save original value.
401 407
 			$args['temp_value'] = $value;
@@ -425,7 +431,8 @@  discard block
 block discarded – undo
425 431
 		}
426 432
 
427 433
 		// Check if there are any other posted "other" values for this field.
428
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
434
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) {
435
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
429 436
 			// Save original value
430 437
 			$args['temp_value'] = $value;
431 438
 			$args['other']      = true;
Please login to merge, or discard this patch.
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -137,10 +137,10 @@  discard block
 block discarded – undo
137 137
 		if ( $_POST ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
138 138
 			$repeating = isset( $args['repeating'] ) && $args['repeating'];
139 139
 			if ( $repeating ) {
140
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
140
+				if ( isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
141 141
 					$value_is_posted = true;
142 142
 				}
143
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
143
+			} elseif ( isset( $_POST['item_meta'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
144 144
 				$value_is_posted = true;
145 145
 			}
146 146
 		}
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 		preg_match_all( "/\[(default-message|default_message)\b(.*?)(?:(\/))?\]/s", $message, $shortcodes, PREG_PATTERN_ORDER );
173 173
 
174 174
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
175
-			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
175
+			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
176 176
 			if ( ! empty( $add_atts ) ) {
177 177
 				$this_atts = array_merge( $atts, $add_atts );
178 178
 			} else {
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 			$default = FrmEntriesController::show_entry_shortcode( $this_atts );
183 183
 
184 184
 			// Add the default message.
185
-			$message = str_replace( $shortcodes[0][ $short_key ], $default, $message );
185
+			$message = str_replace( $shortcodes[0][$short_key], $default, $message );
186 186
 		}
187 187
 
188 188
 		return $message;
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 	 * @return string
196 196
 	 */
197 197
 	public static function prepare_display_value( $entry, $field, $atts ) {
198
-		$field_value = isset( $entry->metas[ $field->id ] ) ? $entry->metas[ $field->id ] : false;
198
+		$field_value = isset( $entry->metas[$field->id] ) ? $entry->metas[$field->id] : false;
199 199
 
200 200
 		if ( FrmAppHelper::pro_is_installed() ) {
201 201
 			$empty = empty( $field_value );
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
 			$child_entries = FrmEntry::getAll( array( 'it.parent_item_id' => $entry->id ), '', '', true );
221 221
 		} else {
222 222
 			// Get all values for this field.
223
-			$child_values = isset( $entry->metas[ $atts['embedded_field_id'] ] ) ? $entry->metas[ $atts['embedded_field_id'] ] : false;
223
+			$child_values = isset( $entry->metas[$atts['embedded_field_id']] ) ? $entry->metas[$atts['embedded_field_id']] : false;
224 224
 
225 225
 			if ( $child_values ) {
226 226
 				$child_entries = FrmEntry::getAll( array( 'it.id' => (array) $child_values ) );
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
 			$value = $args['temp_value'];
339 339
 		}
340 340
 		if ( empty( $args['parent_field_id'] ) ) {
341
-			$_POST['item_meta'][ $field->id ] = $value;
341
+			$_POST['item_meta'][$field->id] = $value;
342 342
 		} else {
343 343
 			self::set_parent_field_posted_value( $field, $value, $args );
344 344
 		}
@@ -350,17 +350,17 @@  discard block
 block discarded – undo
350 350
 	 * @since 4.01
351 351
 	 */
352 352
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
353
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
354
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
355
-				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
353
+		if ( isset( $_POST['item_meta'][$args['parent_field_id']] ) && is_array( $_POST['item_meta'][$args['parent_field_id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
354
+			if ( ! isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) || ! is_array( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
355
+				$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
356 356
 			}
357 357
 		} else {
358 358
 			// All of the section was probably removed.
359
-			$_POST['item_meta'][ $args['parent_field_id'] ]                         = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
360
-			$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
359
+			$_POST['item_meta'][$args['parent_field_id']]                         = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
360
+			$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
361 361
 		}
362 362
 
363
-		$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] = $value; // phpcs:ignore WordPress.Security.NonceVerification.Missing
363
+		$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] = $value; // phpcs:ignore WordPress.Security.NonceVerification.Missing
364 364
 	}
365 365
 
366 366
 	public static function get_posted_value( $field, &$value, $args ) {
@@ -390,9 +390,9 @@  discard block
 block discarded – undo
390 390
 	private static function get_posted_meta( $field_id, $args ) {
391 391
 		if ( empty( $args['parent_field_id'] ) ) {
392 392
 			// Sanitizing is done next.
393
-			$value = isset( $_POST['item_meta'][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $field_id ] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
393
+			$value = isset( $_POST['item_meta'][$field_id] ) ? wp_unslash( $_POST['item_meta'][$field_id] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
394 394
 		} else {
395
-			$value = isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
395
+			$value = isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) ? wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
396 396
 		}
397 397
 		return $value;
398 398
 	}
@@ -423,14 +423,14 @@  discard block
 block discarded – undo
423 423
 		self::set_other_repeating_vals( $field, $value, $args );
424 424
 
425 425
 		// Check if there are any posted "Other" values.
426
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
426
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
427 427
 
428 428
 			// Save original value.
429 429
 			$args['temp_value'] = $value;
430 430
 			$args['other']      = true;
431 431
 
432 432
 			// Sanitizing is done next.
433
-			$other_vals = wp_unslash( $_POST['item_meta']['other'][ $field->id ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
433
+			$other_vals = wp_unslash( $_POST['item_meta']['other'][$field->id] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
434 434
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
435 435
 
436 436
 			// Set the validation value now
@@ -453,12 +453,12 @@  discard block
 block discarded – undo
453 453
 		}
454 454
 
455 455
 		// Check if there are any other posted "other" values for this field.
456
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
456
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
457 457
 			// Save original value
458 458
 			$args['temp_value'] = $value;
459 459
 			$args['other']      = true;
460 460
 
461
-			$other_vals = wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
461
+			$other_vals = wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
462 462
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
463 463
 
464 464
 			// Set the validation value now.
@@ -485,7 +485,7 @@  discard block
 block discarded – undo
485 485
 		if ( is_array( $value ) && $field->type === 'checkbox' ) {
486 486
 			// Combine "Other" values with checked values. "Other" values will override checked box values.
487 487
 			foreach ( $other_vals as $k => $v ) {
488
-				if ( isset( $value[ $k ] ) && trim( $v ) === '' ) {
488
+				if ( isset( $value[$k] ) && trim( $v ) === '' ) {
489 489
 					// If the other box is checked, but doesn't have a value.
490 490
 					$value = '';
491 491
 					break;
@@ -502,25 +502,25 @@  discard block
 block discarded – undo
502 502
 
503 503
 			// Multi-select dropdown.
504 504
 			if ( is_array( $value ) ) {
505
-				$o_key = array_search( $field->options[ $other_key ], $value );
505
+				$o_key = array_search( $field->options[$other_key], $value );
506 506
 
507 507
 				if ( $o_key !== false ) {
508 508
 					// Modify the original value so other key will be preserved.
509
-					$value[ $other_key ] = $value[ $o_key ];
509
+					$value[$other_key] = $value[$o_key];
510 510
 
511 511
 					// By default, the array keys will be numeric for multi-select dropdowns.
512 512
 					// If going backwards and forwards between pages, the array key will match the other key.
513 513
 					if ( $o_key !== $other_key ) {
514
-						unset( $value[ $o_key ] );
514
+						unset( $value[$o_key] );
515 515
 					}
516 516
 
517 517
 					$args['temp_value']  = $value;
518
-					$value[ $other_key ] = reset( $other_vals );
519
-					if ( FrmAppHelper::is_empty_value( $value[ $other_key ] ) ) {
520
-						unset( $value[ $other_key ] );
518
+					$value[$other_key] = reset( $other_vals );
519
+					if ( FrmAppHelper::is_empty_value( $value[$other_key] ) ) {
520
+						unset( $value[$other_key] );
521 521
 					}
522 522
 				}
523
-			} elseif ( $field->options[ $other_key ] == $value ) {
523
+			} elseif ( $field->options[$other_key] == $value ) {
524 524
 				$value = $other_vals;
525 525
 			}
526 526
 		}
@@ -731,7 +731,7 @@  discard block
 block discarded – undo
731 731
 	 * @return void
732 732
 	 */
733 733
 	public static function maybe_render_captcha_score( $entry_id ) {
734
-		$query                 = array(
734
+		$query = array(
735 735
 			'item_id'  => (int) $entry_id,
736 736
 			'field_id' => 0,
737 737
 		);
@@ -784,7 +784,7 @@  discard block
 block discarded – undo
784 784
 	public static function get_entry_status_label( $status ) {
785 785
 		$statuses = self::get_entry_statuses();
786 786
 
787
-		return $statuses[ self::get_entry_status( $status ) ];
787
+		return $statuses[self::get_entry_status( $status )];
788 788
 	}
789 789
 
790 790
 	/**
Please login to merge, or discard this patch.
deprecated/FrmEDD_SL_Plugin_Updater.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 		$this->beta        = ! empty( $this->api_data['beta'] ) ? true : false;
45 45
 		$this->cache_key   = md5( serialize( $this->slug . $this->version . $this->api_data['license'] . $this->beta ) );
46 46
 
47
-		$frm_edd_plugin_data[ $this->slug ] = $this->api_data;
47
+		$frm_edd_plugin_data[$this->slug] = $this->api_data;
48 48
 
49 49
 		/**
50 50
 		 * Fires after the $frm_edd_plugin_data is setup.
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 			$_transient_data = new stdClass();
94 94
 		}
95 95
 
96
-		if ( ! empty( $_transient_data->response ) && ! empty( $_transient_data->response[ $this->name ] ) && false === $this->wp_override ) {
96
+		if ( ! empty( $_transient_data->response ) && ! empty( $_transient_data->response[$this->name] ) && false === $this->wp_override ) {
97 97
 			return $_transient_data;
98 98
 		}
99 99
 
@@ -120,12 +120,12 @@  discard block
 block discarded – undo
120 120
 					$version_info->plugin = $this->name;
121 121
 				}
122 122
 
123
-				$_transient_data->response[ $this->name ] = $version_info;
123
+				$_transient_data->response[$this->name] = $version_info;
124 124
 
125 125
 			}
126 126
 
127 127
 			$_transient_data->last_checked           = time();
128
-			$_transient_data->checked[ $this->name ] = $this->version;
128
+			$_transient_data->checked[$this->name] = $this->version;
129 129
 
130 130
 		}
131 131
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 		if ( isset( $_data->sections ) && ! is_array( $_data->sections ) ) {
190 190
 			$new_sections = array();
191 191
 			foreach ( $_data->sections as $key => $value ) {
192
-				$new_sections[ $key ] = $value;
192
+				$new_sections[$key] = $value;
193 193
 			}
194 194
 
195 195
 			$_data->sections = $new_sections;
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 		if ( isset( $_data->banners ) && ! is_array( $_data->banners ) ) {
200 200
 			$new_banners = array();
201 201
 			foreach ( $_data->banners as $key => $value ) {
202
-				$new_banners[ $key ] = $value;
202
+				$new_banners[$key] = $value;
203 203
 			}
204 204
 
205 205
 			$_data->banners = $new_banners;
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 		}
317 317
 
318 318
 		$slug         = sanitize_text_field( $_REQUEST['slug'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
319
-		$data         = $frm_edd_plugin_data[ $slug ];
319
+		$data         = $frm_edd_plugin_data[$slug];
320 320
 		$beta         = ! empty( $data['beta'] ) ? true : false;
321 321
 		$cache_key    = md5( 'edd_plugin_' . sanitize_key( $_REQUEST['plugin'] ) . '_' . $beta . '_version_info' ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
322 322
 		$version_info = $this->get_cached_version_info( $cache_key );
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -303,11 +303,13 @@
 block discarded – undo
303 303
 
304 304
 		global $frm_edd_plugin_data;
305 305
 
306
-		if ( empty( $_REQUEST['edd_sl_action'] ) || 'view_plugin_changelog' !== $_REQUEST['edd_sl_action'] ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
306
+		if ( empty( $_REQUEST['edd_sl_action'] ) || 'view_plugin_changelog' !== $_REQUEST['edd_sl_action'] ) {
307
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
307 308
 			return;
308 309
 		}
309 310
 
310
-		if ( empty( $_REQUEST['plugin'] ) || empty( $_REQUEST['slug'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
311
+		if ( empty( $_REQUEST['plugin'] ) || empty( $_REQUEST['slug'] ) ) {
312
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
311 313
 			return;
312 314
 		}
313 315
 
Please login to merge, or discard this patch.
classes/views/solutions/_import.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 				$info['url'] = $xml;
12 12
 			}
13 13
 
14
-			$disabled = isset( $imported[ $info['form'] ] ) ? ' disabled' : '';
14
+			$disabled = isset( $imported[$info['form']] ) ? ' disabled' : '';
15 15
 			$url   = isset( $info['url'] ) ? $info['url'] : '';
16 16
 			$value = $importing === 'form' ? $info['form'] : $info['key'];
17 17
 			if ( ! isset( $info['img'] ) ) {
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 				continue;
22 22
 			}
23 23
 
24
-			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[ $info['form'] ] ) );
24
+			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[$info['form']] ) );
25 25
 			?>
26 26
 			<div class="frm_radio radio-inline radio frm_image_option<?php echo esc_attr( $importing === 'view' ? ' show_sub_opt show_' . $info['form'] : '' ); ?>" style="<?php echo esc_attr( $hide_views ? 'display:none' : '' ); ?>">
27 27
 				<?php if ( $importing === 'form' ) { ?>
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 					<?php } ?>
42 42
 					/>
43 43
 					<div class="frm_image_option_container frm_label_with_image">
44
-						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) );  // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
44
+						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
45 45
 						<span class="frm_text_label_for_image">
46 46
 							<?php
47 47
 							if ( ! empty( $disabled ) ) {
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 							}
55 55
 
56 56
 							if ( $importing === 'form' && $disabled ) {
57
-								echo FrmAppHelper::kses( FrmFormsHelper::edit_form_link( $imported[ $info['form'] ] ), array( 'a' ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
57
+								echo FrmAppHelper::kses( FrmFormsHelper::edit_form_link( $imported[$info['form']] ), array( 'a' ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
58 58
 							} else {
59 59
 								echo esc_html( $info['name'] );
60 60
 							}
Please login to merge, or discard this patch.
deprecated/FrmDeprecated.php 2 patches
Indentation   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -749,8 +749,8 @@  discard block
 block discarded – undo
749 749
 	 */
750 750
 	public static function get_shortcode_tag( $shortcodes, $short_key, $args ) {
751 751
 		_deprecated_function( __FUNCTION__, '3.0', 'FrmShortcodeHelper::get_shortcode_tag' );
752
-        return FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key, $args );
753
-    }
752
+		return FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key, $args );
753
+	}
754 754
 
755 755
 	/**
756 756
 	 * @deprecated 3.01
@@ -763,52 +763,52 @@  discard block
 block discarded – undo
763 763
 	/**
764 764
 	 * @deprecated 3.02.03
765 765
 	 */
766
-    public static function jquery_themes() {
766
+	public static function jquery_themes() {
767 767
 		_deprecated_function( __FUNCTION__, '3.02.03', 'FrmProStylesController::jquery_themes' );
768 768
 
769
-        $themes = array(
770
-            'ui-lightness'  => 'UI Lightness',
771
-            'ui-darkness'   => 'UI Darkness',
772
-            'smoothness'    => 'Smoothness',
773
-            'start'         => 'Start',
774
-            'redmond'       => 'Redmond',
775
-            'sunny'         => 'Sunny',
776
-            'overcast'      => 'Overcast',
777
-            'le-frog'       => 'Le Frog',
778
-            'flick'         => 'Flick',
769
+		$themes = array(
770
+			'ui-lightness'  => 'UI Lightness',
771
+			'ui-darkness'   => 'UI Darkness',
772
+			'smoothness'    => 'Smoothness',
773
+			'start'         => 'Start',
774
+			'redmond'       => 'Redmond',
775
+			'sunny'         => 'Sunny',
776
+			'overcast'      => 'Overcast',
777
+			'le-frog'       => 'Le Frog',
778
+			'flick'         => 'Flick',
779 779
 			'pepper-grinder' => 'Pepper Grinder',
780
-            'eggplant'      => 'Eggplant',
781
-            'dark-hive'     => 'Dark Hive',
782
-            'cupertino'     => 'Cupertino',
783
-            'south-street'  => 'South Street',
784
-            'blitzer'       => 'Blitzer',
785
-            'humanity'      => 'Humanity',
786
-            'hot-sneaks'    => 'Hot Sneaks',
787
-            'excite-bike'   => 'Excite Bike',
788
-            'vader'         => 'Vader',
789
-            'dot-luv'       => 'Dot Luv',
790
-            'mint-choc'     => 'Mint Choc',
791
-            'black-tie'     => 'Black Tie',
792
-            'trontastic'    => 'Trontastic',
793
-            'swanky-purse'  => 'Swanky Purse',
794
-        );
780
+			'eggplant'      => 'Eggplant',
781
+			'dark-hive'     => 'Dark Hive',
782
+			'cupertino'     => 'Cupertino',
783
+			'south-street'  => 'South Street',
784
+			'blitzer'       => 'Blitzer',
785
+			'humanity'      => 'Humanity',
786
+			'hot-sneaks'    => 'Hot Sneaks',
787
+			'excite-bike'   => 'Excite Bike',
788
+			'vader'         => 'Vader',
789
+			'dot-luv'       => 'Dot Luv',
790
+			'mint-choc'     => 'Mint Choc',
791
+			'black-tie'     => 'Black Tie',
792
+			'trontastic'    => 'Trontastic',
793
+			'swanky-purse'  => 'Swanky Purse',
794
+		);
795 795
 
796 796
 		$themes = apply_filters( 'frm_jquery_themes', $themes );
797
-        return $themes;
798
-    }
797
+		return $themes;
798
+	}
799 799
 
800 800
 	/**
801 801
 	 * @deprecated 3.02.03
802 802
 	 */
803
-    public static function enqueue_jquery_css() {
803
+	public static function enqueue_jquery_css() {
804 804
 		_deprecated_function( __FUNCTION__, '3.02.03', 'FrmProStylesController::enqueue_jquery_css' );
805 805
 
806 806
 		$form = self::get_form_for_page();
807 807
 		$theme_css = FrmStylesController::get_style_val( 'theme_css', $form );
808
-        if ( $theme_css != -1 ) {
808
+		if ( $theme_css != -1 ) {
809 809
 			wp_enqueue_style( 'jquery-theme', self::jquery_css_url( $theme_css ), array(), FrmAppHelper::plugin_version() );
810
-        }
811
-    }
810
+		}
811
+	}
812 812
 
813 813
 	/**
814 814
 	 * @deprecated 3.02.03
@@ -821,7 +821,7 @@  discard block
 block discarded – undo
821 821
 		}
822 822
 
823 823
 		return FrmProStylesController::jquery_css_url( $theme_css );
824
-    }
824
+	}
825 825
 
826 826
 	/**
827 827
 	 * @deprecated 3.02.03
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 		FrmAppHelper::permission_check( 'frm_edit_forms' );
28 28
 
29 29
 		$action = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action';
30
-		$action = empty( $values ) ? FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' ) : $values[ $action ];
30
+		$action = empty( $values ) ? FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' ) : $values[$action];
31 31
 
32 32
 		if ( $action === 'create' ) {
33 33
 			FrmFormsController::update( $values );
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 		}
36 36
 
37 37
 		$values = FrmFormsHelper::setup_new_vars( $values );
38
-		$id   = FrmForm::create( $values );
38
+		$id = FrmForm::create( $values );
39 39
 		$values['id'] = $id;
40 40
 
41 41
 		FrmFormsController::edit( $values );
Please login to merge, or discard this patch.
classes/views/frm-fields/back-end/html-content.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 				'title'     => esc_attr__( 'Toggle Options', 'formidable' ),
17 17
 			)
18 18
 		);
19
-		$e_args  = array(
19
+		$e_args = array(
20 20
 			'textarea_name' => 'field_options[description_' . absint( $field['id'] ) . ']',
21 21
 			'textarea_rows' => 8,
22 22
 		);
Please login to merge, or discard this patch.
classes/views/frm-forms/landing-page-preview-option.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 $data_keys = array_keys( $data );
7 7
 $params    = array();
8 8
 foreach ( $data_keys as $key ) {
9
-	$params[ 'data-' . $key ] = $data[ $key ];
9
+	$params['data-' . $key] = $data[$key];
10 10
 }
11 11
 $params['class'] = 'frm_show_upgrade frm_noallow';
12 12
 $params['href']  = '#';
Please login to merge, or discard this patch.
classes/helpers/FrmFormsHelper.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 			'class'        => '',
29 29
 			'inc_children' => 'exclude',
30 30
 		);
31
-		$args     = wp_parse_args( $args, $defaults );
31
+		$args = wp_parse_args( $args, $defaults );
32 32
 
33 33
 		if ( ! $args['field_id'] ) {
34 34
 			$args['field_id'] = $field_name;
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	 */
71 71
 	public static function add_html_attr( $class, $param, &$add_html ) {
72 72
 		if ( ! empty( $class ) ) {
73
-			$add_html[ $param ] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
73
+			$add_html[$param] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
74 74
 		}
75 75
 	}
76 76
 
@@ -276,8 +276,8 @@  discard block
 block discarded – undo
276 276
 			'description' => '',
277 277
 		);
278 278
 		foreach ( $defaults as $var => $default ) {
279
-			if ( ! isset( $values[ $var ] ) ) {
280
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
279
+			if ( ! isset( $values[$var] ) ) {
280
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
281 281
 			}
282 282
 		}
283 283
 
@@ -292,8 +292,8 @@  discard block
 block discarded – undo
292 292
 			'parent_form_id' => 0,
293 293
 		);
294 294
 		foreach ( $defaults as $var => $default ) {
295
-			if ( ! isset( $values[ $var ] ) ) {
296
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
295
+			if ( ! isset( $values[$var] ) ) {
296
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
297 297
 			}
298 298
 		}
299 299
 		unset( $defaults );
@@ -330,16 +330,16 @@  discard block
 block discarded – undo
330 330
 		$defaults = self::get_default_opts();
331 331
 		foreach ( $defaults as $var => $default ) {
332 332
 			if ( is_array( $default ) ) {
333
-				if ( ! isset( $values[ $var ] ) ) {
334
-					$values[ $var ] = ( $record && isset( $record->options[ $var ] ) ) ? $record->options[ $var ] : array();
333
+				if ( ! isset( $values[$var] ) ) {
334
+					$values[$var] = ( $record && isset( $record->options[$var] ) ) ? $record->options[$var] : array();
335 335
 				}
336 336
 
337 337
 				foreach ( $default as $k => $v ) {
338
-					$values[ $var ][ $k ] = ( $post_values && isset( $post_values[ $var ][ $k ] ) ) ? $post_values[ $var ][ $k ] : ( ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) ) ? $record->options[ $var ][ $k ] : $v );
338
+					$values[$var][$k] = ( $post_values && isset( $post_values[$var][$k] ) ) ? $post_values[$var][$k] : ( ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) ) ? $record->options[$var][$k] : $v );
339 339
 
340 340
 					if ( is_array( $v ) ) {
341 341
 						foreach ( $v as $k1 => $v1 ) {
342
-							$values[ $var ][ $k ][ $k1 ] = ( $post_values && isset( $post_values[ $var ][ $k ][ $k1 ] ) ) ? $post_values[ $var ][ $k ][ $k1 ] : ( ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) && isset( $record->options[ $var ][ $k ][ $k1 ] ) ) ? $record->options[ $var ][ $k ][ $k1 ] : $v1 );
342
+							$values[$var][$k][$k1] = ( $post_values && isset( $post_values[$var][$k][$k1] ) ) ? $post_values[$var][$k][$k1] : ( ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) && isset( $record->options[$var][$k][$k1] ) ) ? $record->options[$var][$k][$k1] : $v1 );
343 343
 							unset( $k1, $v1 );
344 344
 						}
345 345
 					}
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
 					unset( $k, $v );
348 348
 				}
349 349
 			} else {
350
-				$values[ $var ] = ( $post_values && isset( $post_values['options'][ $var ] ) ) ? $post_values['options'][ $var ] : ( ( $record && isset( $record->options[ $var ] ) ) ? $record->options[ $var ] : $default );
350
+				$values[$var] = ( $post_values && isset( $post_values['options'][$var] ) ) ? $post_values['options'][$var] : ( ( $record && isset( $record->options[$var] ) ) ? $record->options[$var] : $default );
351 351
 			}
352 352
 
353 353
 			unset( $var, $default );
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 	public static function fill_form_options( &$options, $values ) {
388 388
 		$defaults = self::get_default_opts();
389 389
 		foreach ( $defaults as $var => $default ) {
390
-			$options[ $var ] = isset( $values['options'][ $var ] ) ? $values['options'][ $var ] : $default;
390
+			$options[$var] = isset( $values['options'][$var] ) ? $values['options'][$var] : $default;
391 391
 			unset( $var, $default );
392 392
 		}
393 393
 	}
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
549 549
 	public static function insert_opt_html( $args ) {
550 550
 		$class  = isset( $args['class'] ) ? $args['class'] : '';
551 551
 		$fields = FrmField::all_field_selection();
552
-		$field  = isset( $fields[ $args['type'] ] ) ? $fields[ $args['type'] ] : array();
552
+		$field  = isset( $fields[$args['type']] ) ? $fields[$args['type']] : array();
553 553
 
554 554
 		self::prepare_field_type( $field );
555 555
 
@@ -705,7 +705,7 @@  discard block
 block discarded – undo
705 705
 			FrmField::update( $field->id, array( 'field_order' => $field->field_order + 2 ) );
706 706
 		}
707 707
 
708
-		$add_order    += 2;
708
+		$add_order += 2;
709 709
 		$open         = false;
710 710
 		$reset_fields = true;
711 711
 	}
@@ -1108,10 +1108,10 @@  discard block
 block discarded – undo
1108 1108
 				$link .= ' onclick="return confirm(\'' . esc_attr( $link_details['confirm'] ) . '\')"';
1109 1109
 			}
1110 1110
 
1111
-			$label = ( isset( $link_details[ $length ] ) ? $link_details[ $length ] : $link_details['label'] );
1112
-			if ( $length == 'icon' && isset( $link_details[ $length ] ) ) {
1111
+			$label = ( isset( $link_details[$length] ) ? $link_details[$length] : $link_details['label'] );
1112
+			if ( $length == 'icon' && isset( $link_details[$length] ) ) {
1113 1113
 				$label = '<span class="' . $label . '" title="' . esc_attr( $link_details['label'] ) . '" aria-hidden="true"></span>';
1114
-				$link  .= ' aria-label="' . esc_attr( $link_details['label'] ) . '"';
1114
+				$link .= ' aria-label="' . esc_attr( $link_details['label'] ) . '"';
1115 1115
 			}
1116 1116
 
1117 1117
 			$link .= '>' . $label . '</a>';
@@ -1250,7 +1250,7 @@  discard block
 block discarded – undo
1250 1250
 			$status = 'publish';
1251 1251
 		}
1252 1252
 
1253
-		$name = $nice_names[ $status ];
1253
+		$name = $nice_names[$status];
1254 1254
 
1255 1255
 		return $name;
1256 1256
 	}
@@ -1283,17 +1283,17 @@  discard block
 block discarded – undo
1283 1283
 			''                    => array( 'align_right' ),
1284 1284
 		);
1285 1285
 
1286
-		$icons[ __( 'My Templates', 'formidable' ) ] = array( 'user', 'var(--orange)' );
1286
+		$icons[__( 'My Templates', 'formidable' )] = array( 'user', 'var(--orange)' );
1287 1287
 
1288 1288
 		$icon = $icons[''];
1289 1289
 
1290 1290
 		if ( count( $categories ) === 1 ) {
1291 1291
 			$category = reset( $categories );
1292
-			$icon     = isset( $icons[ $category ] ) ? $icons[ $category ] : $icon;
1292
+			$icon     = isset( $icons[$category] ) ? $icons[$category] : $icon;
1293 1293
 		} elseif ( ! empty( $categories ) ) {
1294 1294
 			foreach ( $icons as $cat => $icon ) {
1295 1295
 				if ( ! in_array( $cat, $categories ) ) {
1296
-					unset( $icons[ $cat ] );
1296
+					unset( $icons[$cat] );
1297 1297
 				}
1298 1298
 			}
1299 1299
 			$icon = reset( $icons );
@@ -1422,7 +1422,7 @@  discard block
 block discarded – undo
1422 1422
 
1423 1423
 		foreach ( $item['categories'] as $k => $category ) {
1424 1424
 			if ( in_array( $category, $plans, true ) ) {
1425
-				unset( $item['categories'][ $k ] );
1425
+				unset( $item['categories'][$k] );
1426 1426
 
1427 1427
 				if ( in_array( $category, array( 'Creator', 'Personal' ), true ) ) {
1428 1428
 					// Show the current package name.
@@ -1650,9 +1650,9 @@  discard block
 block discarded – undo
1650 1650
 		}
1651 1651
 
1652 1652
 		foreach ( $shortcodes[0] as $key => $shortcode ) {
1653
-			$options = trim( $shortcodes[3][ $key ] );
1653
+			$options = trim( $shortcodes[3][$key] );
1654 1654
 
1655
-			if ( in_array( $shortcodes[1][ $key ], array( 'if ' ), true ) ) {
1655
+			if ( in_array( $shortcodes[1][$key], array( 'if ' ), true ) ) {
1656 1656
 				// Skip if shortcodes.
1657 1657
 				continue;
1658 1658
 			}
@@ -1662,7 +1662,7 @@  discard block
 block discarded – undo
1662 1662
 				continue;
1663 1663
 			}
1664 1664
 
1665
-			$new_shortcode = '[' . $shortcodes[2][ $key ];
1665
+			$new_shortcode = '[' . $shortcodes[2][$key];
1666 1666
 			if ( $options ) {
1667 1667
 				$new_shortcode .= ' ' . $options;
1668 1668
 			}
Please login to merge, or discard this patch.
classes/views/frm-forms/list-templates.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
 	</li><?php
17 17
 	$render_icon = true;
18 18
 	foreach ( array( 20872734, 20874748, 20882522, 20874739, 20908981, 28109851 ) as $template ) {
19
-		if ( isset( $templates[ $template ] ) ) {
20
-			$template = $templates[ $template ];
19
+		if ( isset( $templates[$template] ) ) {
20
+			$template = $templates[$template];
21 21
 			require $view_path . 'list-template.php';
22 22
 		}
23 23
 	}
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	<ul class="frm-templates-list frm-categories-list">
46 46
 		<?php foreach ( $categories as $category ) { ?>
47 47
 			<?php
48
-			$category_templates = $templates_by_category[ $category ];
48
+			$category_templates = $templates_by_category[$category];
49 49
 			$count              = count( $category_templates );
50 50
 			$available          = FrmFormsHelper::available_count( $category_templates, $args );
51 51
 			?>
Please login to merge, or discard this patch.
classes/models/FrmEntryValidate.php 2 patches
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 			return $errors;
15 15
 		}
16 16
 
17
-		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) {
17
+		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values['frm_submit_entry_' . $values['form_id']] ) || ! wp_verify_nonce( $values['frm_submit_entry_' . $values['form_id']], 'frm_submit_entry_nonce' ) ) ) {
18 18
 			$frm_settings   = FrmAppHelper::get_settings();
19 19
 			$errors['form'] = $frm_settings->admin_permission;
20 20
 		}
@@ -88,10 +88,10 @@  discard block
 block discarded – undo
88 88
 			'key_pointer'     => '', // the pointer in the posted array
89 89
 			'exclude'         => array(), // exclude these field types from validation
90 90
 		);
91
-		$args     = wp_parse_args( $args, $defaults );
91
+		$args = wp_parse_args( $args, $defaults );
92 92
 
93 93
 		if ( empty( $args['parent_field_id'] ) ) {
94
-			$value = isset( $values['item_meta'][ $args['id'] ] ) ? $values['item_meta'][ $args['id'] ] : '';
94
+			$value = isset( $values['item_meta'][$args['id']] ) ? $values['item_meta'][$args['id']] : '';
95 95
 		} else {
96 96
 			// value is from a nested form
97 97
 			$value = $values;
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 		}
113 113
 
114 114
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
115
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
115
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
116 116
 		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
117 117
 			self::maybe_add_item_name( $value, $posted_field );
118 118
 		}
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 			$pattern = self::phone_format( $field );
189 189
 
190 190
 			if ( ! preg_match( $pattern, $value ) ) {
191
-				$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
191
+				$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
192 192
 			}
193 193
 		}
194 194
 	}
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
 	 */
299 299
 	private static function form_is_in_progress( $values ) {
300 300
 		return FrmAppHelper::pro_is_installed() &&
301
-			( isset( $values[ 'frm_page_order_' . $values['form_id'] ] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
301
+			( isset( $values['frm_page_order_' . $values['form_id']] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
302 302
 			FrmField::get_all_types_in_form( $values['form_id'], 'break' );
303 303
 	}
304 304
 
@@ -543,9 +543,9 @@  discard block
 block discarded – undo
543 543
 			foreach ( $datas['missing_keys'] as $key_index => $key ) {
544 544
 				$found = self::is_akismet_guest_info_value( $key, $value, $field_id, $datas['name_field_ids'] );
545 545
 				if ( $found ) {
546
-					$datas[ $key ]             = $value;
546
+					$datas[$key]             = $value;
547 547
 					$datas['frm_duplicated'][] = $field_id;
548
-					unset( $datas['missing_keys'][ $key_index ] );
548
+					unset( $datas['missing_keys'][$key_index] );
549 549
 				}
550 550
 			}
551 551
 		}
@@ -591,7 +591,7 @@  discard block
 block discarded – undo
591 591
 
592 592
 			// Send any potentially useful $_SERVER vars, but avoid sending junk we don't need.
593 593
 			if ( $include_value ) {
594
-				$datas[ $key ] = $value;
594
+				$datas[$key] = $value;
595 595
 			}
596 596
 			unset( $key, $value );
597 597
 		}
@@ -608,10 +608,10 @@  discard block
 block discarded – undo
608 608
 	private static function add_comment_content_to_akismet( &$datas, $values ) {
609 609
 		if ( isset( $datas['frm_duplicated'] ) ) {
610 610
 			foreach ( $datas['frm_duplicated'] as $index ) {
611
-				if ( isset( $values['item_meta'][ $index ] ) ) {
612
-					unset( $values['item_meta'][ $index ] );
611
+				if ( isset( $values['item_meta'][$index] ) ) {
612
+					unset( $values['item_meta'][$index] );
613 613
 				} else {
614
-					unset( $values[ $index ] );
614
+					unset( $values[$index] );
615 615
 				}
616 616
 			}
617 617
 			unset( $datas['frm_duplicated'] );
@@ -632,14 +632,14 @@  discard block
 block discarded – undo
632 632
 	private static function skip_adding_values_to_akismet( &$values ) {
633 633
 		$skipped_fields = self::get_akismet_skipped_field_ids( $values );
634 634
 		foreach ( $skipped_fields as $skipped_field ) {
635
-			if ( ! isset( $values['item_meta'][ $skipped_field->id ] ) ) {
635
+			if ( ! isset( $values['item_meta'][$skipped_field->id] ) ) {
636 636
 				continue;
637 637
 			}
638 638
 
639 639
 			if ( self::should_really_skip_field( $skipped_field, $values ) ) {
640
-				unset( $values['item_meta'][ $skipped_field->id ] );
641
-				if ( isset( $values['item_meta']['other'][ $skipped_field->id ] ) ) {
642
-					unset( $values['item_meta']['other'][ $skipped_field->id ] );
640
+				unset( $values['item_meta'][$skipped_field->id] );
641
+				if ( isset( $values['item_meta']['other'][$skipped_field->id] ) ) {
642
+					unset( $values['item_meta']['other'][$skipped_field->id] );
643 643
 				}
644 644
 			}
645 645
 		}
@@ -672,14 +672,14 @@  discard block
 block discarded – undo
672 672
 		}
673 673
 
674 674
 		// If a choice field has Other option, but Other is not selected.
675
-		if ( empty( $values['item_meta']['other'][ $field_data->id ] ) ) {
675
+		if ( empty( $values['item_meta']['other'][$field_data->id] ) ) {
676 676
 			return true;
677 677
 		}
678 678
 
679 679
 		// Check if submitted value is same as one of field option.
680 680
 		foreach ( $field_data->options as $option ) {
681 681
 			$option_value = ! is_array( $option ) ? $option : ( isset( $option['value'] ) ? $option['value'] : '' );
682
-			if ( $values['item_meta']['other'][ $field_data->id ] === $option_value ) {
682
+			if ( $values['item_meta']['other'][$field_data->id] === $option_value ) {
683 683
 				return true;
684 684
 			}
685 685
 		}
@@ -749,7 +749,7 @@  discard block
 block discarded – undo
749 749
 
750 750
 			// Convert name array to string.
751 751
 			if ( isset( $value['first'] ) && isset( $value['last'] ) ) {
752
-				$values['item_meta'][ $field_id ] = trim( implode( ' ', $value ) );
752
+				$values['item_meta'][$field_id] = trim( implode( ' ', $value ) );
753 753
 				$values['name_field_ids'][]       = $field_id;
754 754
 				continue;
755 755
 			}
@@ -770,8 +770,8 @@  discard block
 block discarded – undo
770 770
 						continue;
771 771
 					}
772 772
 
773
-					if ( ! isset( $values['item_meta'][ $subsubindex ] ) ) {
774
-						$values['item_meta'][ $subsubindex ] = array();
773
+					if ( ! isset( $values['item_meta'][$subsubindex] ) ) {
774
+						$values['item_meta'][$subsubindex] = array();
775 775
 					}
776 776
 
777 777
 					// Convert name array to string.
@@ -781,11 +781,11 @@  discard block
 block discarded – undo
781 781
 						$values['name_field_ids'][] = $subsubindex;
782 782
 					}
783 783
 
784
-					$values['item_meta'][ $subsubindex ][] = $subsubvalue;
784
+					$values['item_meta'][$subsubindex][] = $subsubvalue;
785 785
 				}
786 786
 			}
787 787
 
788
-			unset( $values['item_meta'][ $field_id ] );
788
+			unset( $values['item_meta'][$field_id] );
789 789
 		}
790 790
 
791 791
 		return $form_ids;
Please login to merge, or discard this patch.
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -113,7 +113,8 @@  discard block
 block discarded – undo
113 113
 
114 114
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
115 115
 			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
116
-		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
116
+		} elseif ( ! isset( $_POST['item_name'] ) ) {
117
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
117 118
 			self::maybe_add_item_name( $value, $posted_field );
118 119
 		}
119 120
 
@@ -655,12 +656,14 @@  discard block
 block discarded – undo
655 656
 	 * @return bool
656 657
 	 */
657 658
 	private static function should_really_skip_field( $field_data, $values ) {
658
-		if ( empty( $field_data->options ) ) { // This is skipped field types.
659
+		if ( empty( $field_data->options ) ) {
660
+// This is skipped field types.
659 661
 			return true;
660 662
 		}
661 663
 
662 664
 		FrmAppHelper::unserialize_or_decode( $field_data->options );
663
-		if ( ! $field_data->options ) { // Check if an error happens when unserializing, or empty options.
665
+		if ( ! $field_data->options ) {
666
+// Check if an error happens when unserializing, or empty options.
664 667
 			return true;
665 668
 		}
666 669
 
@@ -743,7 +746,8 @@  discard block
 block discarded – undo
743 746
 		// Blacklist check for File field in the old version doesn't contain `form_id`.
744 747
 		$form_ids = isset( $values['form_id'] ) ? array( absint( $values['form_id'] ) ) : array();
745 748
 		foreach ( $values['item_meta'] as $field_id => $value ) {
746
-			if ( ! is_numeric( $field_id ) ) { // Maybe `other`.
749
+			if ( ! is_numeric( $field_id ) ) {
750
+// Maybe `other`.
747 751
 				continue;
748 752
 			}
749 753
 
Please login to merge, or discard this patch.