Strategy11 / formidable-forms

classes/models/FrmFormMigrator.php

Doc Comments +10 added lines

@@ -172,6 +172,9 @@ 
 		return $response;
 	}
 
+	/**
+	 * @param string $source_form_name
+	 */
 	protected function prepare_new_form( $source_id, $source_form_name ) {
 		return array(
 			'import_form_id' => $source_id,
@@ -307,6 +310,7 @@ 
 	 * This switches the name field to individual fields.
 	 *
 	 * @since 4.04.03
+	 * @param integer $remove
 	 */
 	protected function insert_fields_in_array( $subs, $start, $remove, &$fields ) {
 		array_splice( $fields, $start, $remove, $subs );
@@ -476,6 +480,9 @@ 
 		return array();
 	}
 
+	/**
+	 * @param string $type
+	 */
 	private function is_unsupported_field( $type ) {
 		$fields = $this->unsupported_field_types();
 
@@ -491,6 +498,9 @@ 
 		return array();
 	}
 
+	/**
+	 * @param string $type
+	 */
 	protected function should_skip_field( $type ) {
 		$skip_pro_fields = $this->skip_pro_fields();
 

Spacing +6 added lines, -6 removed lines

@@ -396,7 +396,7 @@ 
 	protected function create_fields( $form_id, &$form ) {
 		foreach ( $form['fields'] as $key => $new_field ) {
 			$new_field['form_id']         = $form_id;
-			$form['fields'][ $key ]['id'] = FrmField::create( $new_field );
+			$form['fields'][$key]['id'] = FrmField::create( $new_field );
 		}
 	}
 
@@ -426,9 +426,9 @@ 
 			} elseif ( $key === 'the_post_title' ) {
 				$new_action->post_content['post_title'] = $value;
 			} elseif ( is_string( $value ) ) {
-				$new_action->post_content[ $key ] = $this->replace_smart_tags( $value, $form['fields'] );
+				$new_action->post_content[$key] = $this->replace_smart_tags( $value, $form['fields'] );
 			} else {
-				$new_action->post_content[ $key ] = $value;
+				$new_action->post_content[$key] = $value;
 			}
 		}
 
@@ -447,7 +447,7 @@ 
 
 		$imported = $this->get_tracked_import();
 
-		$imported[ $this->slug ][ $new_form_id ] = $source_id;
+		$imported[$this->slug][$new_form_id] = $source_id;
 
 		update_option( $this->tracking, $imported, false );
 	}
@@ -467,11 +467,11 @@ 
 	private function is_imported( $source_id ) {
 		$imported    = $this->get_tracked_import();
 		$new_form_id = 0;
-		if ( ! isset( $imported[ $this->slug ] ) || ! in_array( $source_id, $imported[ $this->slug ] ) ) {
+		if ( ! isset( $imported[$this->slug] ) || ! in_array( $source_id, $imported[$this->slug] ) ) {
 			return $new_form_id;
 		}
 
-		$new_form_id = array_search( $source_id, array_reverse( $imported[ $this->slug ], true ) );
+		$new_form_id = array_search( $source_id, array_reverse( $imported[$this->slug], true ) );
 		if ( ! empty( $new_form_id ) && empty( FrmForm::get_key_by_id( $new_form_id ) ) ) {
 			// Allow reimport if the form was deleted.
 			$new_form_id = 0;

classes/controllers/FrmSMTPController.php

Doc Comments +2 added lines, -2 removed lines

@@ -279,7 +279,7 @@ 
 	 *
 	 * @since 4.04.04
 	 *
-	 * @return array Step data.
+	 * @return string Step data.
 	 */
 	protected function get_data_step_install() {
 
@@ -326,7 +326,7 @@ 
 	 *
 	 * @since 4.04.04
 	 *
-	 * @return array Step data.
+	 * @return string Step data.
 	 */
 	protected function get_data_step_setup() {
 

Spacing +1 added lines, -1 removed lines

@@ -235,7 +235,7 @@
 		if ( is_array( $upsell ) ) {
 			foreach ( $upsell as $k => $plugin ) {
 				if ( strpos( $plugin['slug'], 'wpforms' ) !== false ) {
-					unset( $upsell[ $k ] );
+					unset( $upsell[$k] );
 				}
 			}
 		}

css/_single_theme.css.php

Spacing +4 added lines, -4 removed lines

@@ -129,11 +129,11 @@ 
 <?php } ?>
 
 .<?php echo esc_html( $style_class ); ?> .frm_icon_font.frm_minus_icon:before{
-	content:"\e<?php echo esc_html( isset( $minus_icons[ $repeat_icon ] ) ? $minus_icons[ $repeat_icon ]['-'] : $minus_icons[1]['-'] ); ?>";
+	content:"\e<?php echo esc_html( isset( $minus_icons[$repeat_icon] ) ? $minus_icons[$repeat_icon]['-'] : $minus_icons[1]['-'] ); ?>";
 }
 
 .<?php echo esc_html( $style_class ); ?> .frm_icon_font.frm_plus_icon:before{
-	content:"\e<?php echo esc_html( isset( $minus_icons[ $repeat_icon ] ) ? $minus_icons[ $repeat_icon ]['+'] : $minus_icons[1]['+'] ); ?>";
+	content:"\e<?php echo esc_html( isset( $minus_icons[$repeat_icon] ) ? $minus_icons[$repeat_icon]['+'] : $minus_icons[1]['+'] ); ?>";
 }
 
 .<?php echo esc_html( $style_class ); ?> .frm_icon_font.frm_minus_icon:before,
@@ -145,14 +145,14 @@ 
 }
 
 .<?php echo esc_html( $style_class ); ?> .frm_trigger.active .frm_icon_font.frm_arrow_icon:before{
-	content:"\e<?php echo esc_html( isset( $arrow_icons[ $collapse_icon ] ) ? $arrow_icons[ $collapse_icon ]['-'] : $arrow_icons[1]['-'] ); ?>";
+	content:"\e<?php echo esc_html( isset( $arrow_icons[$collapse_icon] ) ? $arrow_icons[$collapse_icon]['-'] : $arrow_icons[1]['-'] ); ?>";
 	<?php if ( ! empty( $section_color ) ) { ?>
 		color:<?php echo esc_html( $section_color . $important ); ?>;
 	<?php } ?>
 }
 
 .<?php echo esc_html( $style_class ); ?> .frm_trigger .frm_icon_font.frm_arrow_icon:before{
-	content:"\e<?php echo esc_html( isset( $arrow_icons[ $collapse_icon ] ) ? $arrow_icons[ $collapse_icon ]['+'] : $arrow_icons[1]['+'] ); ?>";
+	content:"\e<?php echo esc_html( isset( $arrow_icons[$collapse_icon] ) ? $arrow_icons[$collapse_icon]['+'] : $arrow_icons[1]['+'] ); ?>";
 	<?php if ( ! empty( $section_color ) ) { ?>
 		color:<?php echo esc_html( $section_color . $important ); ?>;
 	<?php } ?>

classes/controllers/FrmInboxController.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 	private static function get_notice_count() {
 		FrmFormMigratorsHelper::maybe_add_to_inbox();
 
-		$inbox  = new FrmInbox();
+		$inbox = new FrmInbox();
 		return $inbox->unread_html();
 	}
 

classes/helpers/FrmAppHelper.php

Doc Comments +25 added lines

@@ -69,6 +69,9 @@ 
 		return $url;
 	}
 
+	/**
+	 * @return string
+	 */
 	public static function get_affiliate() {
 		return absint( apply_filters( 'frm_affiliate_id', 0 ) );
 	}
@@ -134,6 +137,9 @@ 
 		return $frm_settings;
 	}
 
+	/**
+	 * @return string
+	 */
 	public static function get_menu_name() {
 		$frm_settings = self::get_settings();
 
@@ -1063,6 +1069,8 @@ 
 	 * This is for reverse compatibility with switching 3 params to 1.
 	 *
 	 * @since 4.03.06
+	 * @param string $page_id
+	 * @param boolean $truncate
 	 */
 	private static function prep_page_dropdown_params( $page_id, $truncate, &$args ) {
 		if ( ! is_array( $args ) ) {
@@ -1300,6 +1308,9 @@ 
 		return ( is_array( $values ) && in_array( $current, $values ) ) || ( ! is_array( $values ) && $values == $current );
 	}
 
+	/**
+	 * @param string $function
+	 */
 	public static function recursive_function_map( $value, $function ) {
 		if ( is_array( $value ) ) {
 			$original_function = $function;
@@ -1348,6 +1359,9 @@ 
 		return $return;
 	}
 
+	/**
+	 * @return string
+	 */
 	public static function esc_textarea( $text, $is_rich_text = false ) {
 		$safe_text = str_replace( '"', '"', $text );
 		if ( ! $is_rich_text ) {
@@ -1548,6 +1562,9 @@ 
 		return $values;
 	}
 
+	/**
+	 * @param string $fields
+	 */
 	private static function prepare_field_arrays( $fields, $record, array &$values, $args ) {
 		if ( ! empty( $fields ) ) {
 			foreach ( (array) $fields as $field ) {
@@ -1754,6 +1771,9 @@ 
 		return $sub . ( ( $len < $original_len ) ? $continue : '' );
 	}
 
+	/**
+	 * @param string[] $function_names
+	 */
 	public static function mb_function( $function_names, $args ) {
 		$mb_function_name = $function_names[0];
 		$function_name    = $function_names[1];
@@ -1788,6 +1808,9 @@ 
 		return $formatted;
 	}
 
+	/**
+	 * @param string $time_format
+	 */
 	private static function add_time_to_date( $time_format, $date ) {
 		if ( empty( $time_format ) ) {
 			$time_format = get_option( 'time_format' );
@@ -1898,6 +1921,7 @@ 
 
 	/**
 	 * @since 4.05.01
+	 * @param string $from
 	 */
 	private static function convert_time( $from, $to ) {
 		$convert = array(
@@ -2371,6 +2395,7 @@ 
 	 * If Pro is far outdated, show a message.
 	 *
 	 * @since 4.0.01
+	 * @param string $min_version
 	 */
 	public static function min_pro_version_notice( $min_version ) {
 		if ( ! self::is_formidable_admin() ) {

Spacing +69 added lines, -69 removed lines

@@ -150,7 +150,7 @@ 
 			'fill'   => '#4d4d4d',
 			'orange' => '#f05a24',
 		);
-		$atts     = array_merge( $defaults, $atts );
+		$atts = array_merge( $defaults, $atts );
 
 		return '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 599.68 601.37" width="' . esc_attr( $atts['width'] ) . '" height="' . esc_attr( $atts['height'] ) . '">
 			<path fill="' . esc_attr( $atts['orange'] ) . '" d="M289.6 384h140v76h-140z"/>
@@ -349,7 +349,7 @@ 
 	 * @return string
 	 */
 	public static function get_server_value( $value ) {
-		return isset( $_SERVER[ $value ] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[ $value ] ) ) : '';
+		return isset( $_SERVER[$value] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[$value] ) ) : '';
 	}
 
 	/**
@@ -372,7 +372,7 @@ 
 		);
 		$ip = '';
 		foreach ( $ip_options as $key ) {
-			if ( ! isset( $_SERVER[ $key ] ) ) {
+			if ( ! isset( $_SERVER[$key] ) ) {
 				continue;
 			}
 
@@ -397,10 +397,10 @@ 
 
 		if ( $src == 'get' ) {
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-			$value = isset( $_POST[ $param ] ) ? wp_unslash( $_POST[ $param ] ) : ( isset( $_GET[ $param ] ) ? wp_unslash( $_GET[ $param ] ) : $default );
-			if ( ! isset( $_POST[ $param ] ) && isset( $_GET[ $param ] ) && ! is_array( $value ) ) {
+			$value = isset( $_POST[$param] ) ? wp_unslash( $_POST[$param] ) : ( isset( $_GET[$param] ) ? wp_unslash( $_GET[$param] ) : $default );
+			if ( ! isset( $_POST[$param] ) && isset( $_GET[$param] ) && ! is_array( $value ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = htmlspecialchars_decode( wp_unslash( $_GET[ $param ] ) );
+				$value = htmlspecialchars_decode( wp_unslash( $_GET[$param] ) );
 			}
 			self::sanitize_value( $sanitize, $value );
 		} else {
@@ -421,7 +421,7 @@ 
 				}
 
 				$p     = trim( $p, ']' );
-				$value = isset( $value[ $p ] ) ? $value[ $p ] : $default;
+				$value = isset( $value[$p] ) ? $value[$p] : $default;
 			}
 		}
 
@@ -477,26 +477,26 @@ 
 			'sanitize' => 'sanitize_text_field',
 			'serialized' => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$value = $args['default'];
 		if ( $args['type'] == 'get' ) {
-			if ( $_GET && isset( $_GET[ $args['param'] ] ) ) {
+			if ( $_GET && isset( $_GET[$args['param']] ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = wp_unslash( $_GET[ $args['param'] ] );
+				$value = wp_unslash( $_GET[$args['param']] );
 			}
 		} elseif ( $args['type'] == 'post' ) {
-			if ( isset( $_POST[ $args['param'] ] ) ) {
+			if ( isset( $_POST[$args['param']] ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = wp_unslash( $_POST[ $args['param'] ] );
+				$value = wp_unslash( $_POST[$args['param']] );
 				if ( $args['serialized'] === true && is_serialized_string( $value ) && is_serialized( $value ) ) {
 					self::unserialize_or_decode( $value );
 				}
 			}
 		} else {
-			if ( isset( $_REQUEST[ $args['param'] ] ) ) {
+			if ( isset( $_REQUEST[$args['param']] ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = wp_unslash( $_REQUEST[ $args['param'] ] );
+				$value = wp_unslash( $_REQUEST[$args['param']] );
 			}
 		}
 
@@ -528,7 +528,7 @@ 
 			if ( is_array( $value ) ) {
 				$temp_values = $value;
 				foreach ( $temp_values as $k => $v ) {
-					self::sanitize_value( $sanitize, $value[ $k ] );
+					self::sanitize_value( $sanitize, $value[$k] );
 				}
 			} else {
 				$value = call_user_func( $sanitize, $value );
@@ -539,8 +539,8 @@ 
 	public static function sanitize_request( $sanitize_method, &$values ) {
 		$temp_values = $values;
 		foreach ( $temp_values as $k => $val ) {
-			if ( isset( $sanitize_method[ $k ] ) ) {
-				$values[ $k ] = call_user_func( $sanitize_method[ $k ], $val );
+			if ( isset( $sanitize_method[$k] ) ) {
+				$values[$k] = call_user_func( $sanitize_method[$k], $val );
 			}
 		}
 	}
@@ -563,7 +563,7 @@ 
 		if ( is_array( $value ) ) {
 			$temp_values = $value;
 			foreach ( $temp_values as $k => $v ) {
-				self::decode_specialchars( $value[ $k ] );
+				self::decode_specialchars( $value[$k] );
 			}
 		} else {
 			self::decode_amp( $value );
@@ -640,7 +640,7 @@ 
 			$allowed_html = $html;
 		} elseif ( ! empty( $allowed ) ) {
 			foreach ( (array) $allowed as $a ) {
-				$allowed_html[ $a ] = isset( $html[ $a ] ) ? $html[ $a ] : array();
+				$allowed_html[$a] = isset( $html[$a] ) ? $html[$a] : array();
 			}
 		}
 
@@ -797,8 +797,8 @@ 
 		}
 
 		global $wp_query;
-		if ( isset( $wp_query->query_vars[ $param ] ) ) {
-			$value = $wp_query->query_vars[ $param ];
+		if ( isset( $wp_query->query_vars[$param] ) ) {
+			$value = $wp_query->query_vars[$param];
 		}
 
 		return $value;
@@ -965,7 +965,7 @@ 
 				'new_file_path' => self::plugin_path() . '/js',
 			)
 		);
-		$new_file  = new FrmCreateFile( $file_atts );
+		$new_file = new FrmCreateFile( $file_atts );
 
 		$files = array(
 			self::plugin_path() . '/js/jquery/jquery.placeholder.min.js',
@@ -1277,8 +1277,8 @@ 
 			return $error;
 		}
 
-		$nonce_value = ( $_REQUEST && isset( $_REQUEST[ $nonce_name ] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST[ $nonce_name ] ) ) : '';
-		if ( $_REQUEST && ( ! isset( $_REQUEST[ $nonce_name ] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
+		$nonce_value = ( $_REQUEST && isset( $_REQUEST[$nonce_name] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST[$nonce_name] ) ) : '';
+		if ( $_REQUEST && ( ! isset( $_REQUEST[$nonce_name] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
 			$frm_settings = self::get_settings();
 			$error        = $frm_settings->admin_permission;
 		}
@@ -1313,7 +1313,7 @@ 
 			} else {
 				foreach ( $value as $k => $v ) {
 					if ( ! is_array( $v ) ) {
-						$value[ $k ] = call_user_func( $original_function, $v );
+						$value[$k] = call_user_func( $original_function, $v );
 					}
 				}
 			}
@@ -1338,7 +1338,7 @@ 
 				$return = array_merge( $return, self::array_flatten( $value, $keys ) );
 			} else {
 				if ( $keys == 'keep' ) {
-					$return[ $key ] = $value;
+					$return[$key] = $value;
 				} else {
 					$return[] = $value;
 				}
@@ -1402,11 +1402,11 @@ 
 		}
 
 		$ver = $default;
-		if ( ! isset( $wp_scripts->registered[ $handle ] ) ) {
+		if ( ! isset( $wp_scripts->registered[$handle] ) ) {
 			return $ver;
 		}
 
-		$query = $wp_scripts->registered[ $handle ];
+		$query = $wp_scripts->registered[$handle];
 		if ( is_object( $query ) && ! empty( $query->ver ) ) {
 			$ver = $query->ver;
 		}
@@ -1529,7 +1529,7 @@ 
 
 		foreach ( array( 'name', 'description' ) as $var ) {
 			$default_val    = isset( $record->{$var} ) ? $record->{$var} : '';
-			$values[ $var ] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
+			$values[$var] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
 			unset( $var, $default_val );
 		}
 
@@ -1587,9 +1587,9 @@ 
 			}
 		}
 
-		$field_type = isset( $post_values['field_options'][ 'type_' . $field->id ] ) ? $post_values['field_options'][ 'type_' . $field->id ] : $field->type;
-		if ( isset( $post_values['item_meta'][ $field->id ] ) ) {
-			$new_value = $post_values['item_meta'][ $field->id ];
+		$field_type = isset( $post_values['field_options']['type_' . $field->id] ) ? $post_values['field_options']['type_' . $field->id] : $field->type;
+		if ( isset( $post_values['item_meta'][$field->id] ) ) {
+			$new_value = $post_values['item_meta'][$field->id];
 			self::unserialize_or_decode( $new_value );
 		} else {
 			$new_value = $meta_value;
@@ -1610,7 +1610,7 @@ 
 
 		$field_array = array_merge( (array) $field->field_options, $field_array );
 
-		$values['fields'][ $field->id ] = $field_array;
+		$values['fields'][$field->id] = $field_array;
 	}
 
 	/**
@@ -1657,11 +1657,11 @@ 
 		}
 
 		foreach ( $form->options as $opt => $value ) {
-			if ( isset( $post_values[ $opt ] ) ) {
-				$values[ $opt ] = $post_values[ $opt ];
-				self::unserialize_or_decode( $values[ $opt ] );
+			if ( isset( $post_values[$opt] ) ) {
+				$values[$opt] = $post_values[$opt];
+				self::unserialize_or_decode( $values[$opt] );
 			} else {
-				$values[ $opt ] = $value;
+				$values[$opt] = $value;
 			}
 		}
 
@@ -1675,8 +1675,8 @@ 
 		$form_defaults = FrmFormsHelper::get_default_opts();
 
 		foreach ( $form_defaults as $opt => $default ) {
-			if ( ! isset( $values[ $opt ] ) || $values[ $opt ] == '' ) {
-				$values[ $opt ] = ( $post_values && isset( $post_values['options'][ $opt ] ) ) ? $post_values['options'][ $opt ] : $default;
+			if ( ! isset( $values[$opt] ) || $values[$opt] == '' ) {
+				$values[$opt] = ( $post_values && isset( $post_values['options'][$opt] ) ) ? $post_values['options'][$opt] : $default;
 			}
 
 			unset( $opt, $default );
@@ -1687,8 +1687,8 @@ 
 		}
 
 		foreach ( array( 'before', 'after', 'submit' ) as $h ) {
-			if ( ! isset( $values[ $h . '_html' ] ) ) {
-				$values[ $h . '_html' ] = ( isset( $post_values['options'][ $h . '_html' ] ) ? $post_values['options'][ $h . '_html' ] : FrmFormsHelper::get_default_html( $h ) );
+			if ( ! isset( $values[$h . '_html'] ) ) {
+				$values[$h . '_html'] = ( isset( $post_values['options'][$h . '_html'] ) ? $post_values['options'][$h . '_html'] : FrmFormsHelper::get_default_html( $h ) );
 			}
 			unset( $h );
 		}
@@ -1840,25 +1840,25 @@ 
 		if ( ! is_numeric( $levels ) ) {
 			// Show time in specified unit.
 			$levels = self::get_unit( $levels );
-			if ( isset( $time_strings[ $levels ] ) ) {
+			if ( isset( $time_strings[$levels] ) ) {
 				$diff = array(
 					$levels => self::time_format( $levels, $diff ),
 				);
 				$time_strings = array(
-					$levels => $time_strings[ $levels ],
+					$levels => $time_strings[$levels],
 				);
 			}
 			$levels = 1;
 		}
 
 		foreach ( $time_strings as $k => $v ) {
-			if ( isset( $diff[ $k ] ) && $diff[ $k ] ) {
-				$time_strings[ $k ] = $diff[ $k ] . ' ' . ( $diff[ $k ] > 1 ? $v[1] : $v[0] );
-			} elseif ( isset( $diff[ $k ] ) && count( $time_strings ) === 1 ) {
+			if ( isset( $diff[$k] ) && $diff[$k] ) {
+				$time_strings[$k] = $diff[$k] . ' ' . ( $diff[$k] > 1 ? $v[1] : $v[0] );
+			} elseif ( isset( $diff[$k] ) && count( $time_strings ) === 1 ) {
 				// Account for 0.
-				$time_strings[ $k ] = $diff[ $k ] . ' ' . $v[1];
+				$time_strings[$k] = $diff[$k] . ' ' . $v[1];
 			} else {
-				unset( $time_strings[ $k ] );
+				unset( $time_strings[$k] );
 			}
 		}
 
@@ -1877,8 +1877,8 @@ 
 			'y' => 'y',
 			'd' => 'days',
 		);
-		if ( isset( $return[ $unit ] ) ) {
-			return $diff[ $return[ $unit ] ];
+		if ( isset( $return[$unit] ) ) {
+			return $diff[$return[$unit]];
 		}
 
 		$total = $diff['days'] * self::convert_time( 'd', $unit );
@@ -1886,11 +1886,11 @@ 
 		$times = array( 'h', 'i', 's' );
 
 		foreach ( $times as $time ) {
-			if ( ! isset( $diff[ $time ] ) ) {
+			if ( ! isset( $diff[$time] ) ) {
 				continue;
 			}
 
-			$total += $diff[ $time ] * self::convert_time( $time, $unit );
+			$total += $diff[$time] * self::convert_time( $time, $unit );
 		}
 
 		return floor( $total );
@@ -1910,7 +1910,7 @@ 
 			'y' => DAY_IN_SECONDS * 365.25,
 		);
 
-		return $convert[ $from ] / $convert[ $to ];
+		return $convert[$from] / $convert[$to];
 	}
 
 	/**
@@ -1918,7 +1918,7 @@ 
 	 */
 	private static function get_unit( $unit ) {
 		$units = self::get_time_strings();
-		if ( isset( $units[ $unit ] ) || is_numeric( $unit ) ) {
+		if ( isset( $units[$unit] ) || is_numeric( $unit ) ) {
 			return $unit;
 		}
 
@@ -1999,17 +1999,17 @@ 
 
 					case 1:
 						$l2 = $name;
-						self::add_value_to_array( $name, $l2, $this_val, $vars[ $l1 ] );
+						self::add_value_to_array( $name, $l2, $this_val, $vars[$l1] );
 						break;
 
 					case 2:
 						$l3 = $name;
-						self::add_value_to_array( $name, $l3, $this_val, $vars[ $l1 ][ $l2 ] );
+						self::add_value_to_array( $name, $l3, $this_val, $vars[$l1][$l2] );
 						break;
 
 					case 3:
 						$l4 = $name;
-						self::add_value_to_array( $name, $l4, $this_val, $vars[ $l1 ][ $l2 ][ $l3 ] );
+						self::add_value_to_array( $name, $l4, $this_val, $vars[$l1][$l2][$l3] );
 				}
 
 				unset( $this_val, $n );
@@ -2028,8 +2028,8 @@ 
 	public static function add_value_to_array( $name, $l1, $val, &$vars ) {
 		if ( $name == '' ) {
 			$vars[] = $val;
-		} elseif ( ! isset( $vars[ $l1 ] ) ) {
-			$vars[ $l1 ] = $val;
+		} elseif ( ! isset( $vars[$l1] ) ) {
+			$vars[$l1] = $val;
 		}
 	}
 
@@ -2045,7 +2045,7 @@ 
 			'email_subject' => esc_attr( sprintf( __( 'If you leave the subject blank, the default will be used: %1$s Form submitted on %2$s', 'formidable' ), $form_name, self::site_name() ) ),
 		);
 
-		if ( ! isset( $tooltips[ $name ] ) ) {
+		if ( ! isset( $tooltips[$name] ) ) {
 			return;
 		}
 
@@ -2055,7 +2055,7 @@ 
 			echo ' class="frm_help"';
 		}
 
-		echo ' title="' . esc_attr( $tooltips[ $name ] );
+		echo ' title="' . esc_attr( $tooltips[$name] );
 
 		if ( 'open' != $class ) {
 			echo '"';
@@ -2108,13 +2108,13 @@ 
 	}
 
 	private static function prepare_action_slashes( $val, $key, &$post_content ) {
-		if ( ! isset( $post_content[ $key ] ) ) {
+		if ( ! isset( $post_content[$key] ) ) {
 			return;
 		}
 
 		if ( is_array( $val ) ) {
 			foreach ( $val as $k1 => $v1 ) {
-				self::prepare_action_slashes( $v1, $k1, $post_content[ $key ] );
+				self::prepare_action_slashes( $v1, $k1, $post_content[$key] );
 				unset( $k1, $v1 );
 			}
 		} else {
@@ -2122,7 +2122,7 @@ 
 			$val = stripslashes( $val );
 
 			// Add backslashes before double quotes and forward slashes only
-			$post_content[ $key ] = addcslashes( $val, '"\\/' );
+			$post_content[$key] = addcslashes( $val, '"\\/' );
 		}
 	}
 
@@ -2181,14 +2181,14 @@ 
 				continue;
 			}
 			$key = $input['name'];
-			if ( isset( $formatted[ $key ] ) ) {
-				if ( is_array( $formatted[ $key ] ) ) {
-					$formatted[ $key ][] = $input['value'];
+			if ( isset( $formatted[$key] ) ) {
+				if ( is_array( $formatted[$key] ) ) {
+					$formatted[$key][] = $input['value'];
 				} else {
-					$formatted[ $key ] = array( $formatted[ $key ], $input['value'] );
+					$formatted[$key] = array( $formatted[$key], $input['value'] );
 				}
 			} else {
-				$formatted[ $key ] = $input['value'];
+				$formatted[$key] = $input['value'];
 			}
 		}
 

classes/models/FrmReviews.php

Spacing +4 added lines, -4 removed lines

@@ -71,12 +71,12 @@ 
 		$show_intervals = array( 50, 200, 500 );
 		$asked          = $this->review_status['asked'];
 
-		if ( ! isset( $show_intervals[ $asked ] ) ) {
+		if ( ! isset( $show_intervals[$asked] ) ) {
 			return;
 		}
 
 		$entries = FrmEntry::getRecordCount();
-		$count   = $show_intervals[ $asked ];
+		$count   = $show_intervals[$asked];
 		$user    = wp_get_current_user();
 
 		// Only show review request if the site has collected enough entries
@@ -118,7 +118,7 @@ 
 		$requests = $message->get_messages();
 		$key      = $this->inbox_key . ( $asked ? $asked : '' );
 
-		if ( isset( $requests[ $key ] ) ) {
+		if ( isset( $requests[$key] ) ) {
 			return;
 		}
 
@@ -154,7 +154,7 @@ 
 	 * @since 4.05.02
 	 */
 	private function has_later_request( $requests, $asked ) {
-		return isset( $requests[ $this->inbox_key . ( $asked + 1 ) ] ) || isset( $requests[ $this->inbox_key . ( $asked + 2 ) ] );
+		return isset( $requests[$this->inbox_key . ( $asked + 1 )] ) || isset( $requests[$this->inbox_key . ( $asked + 2 )] );
 	}
 
 	/**

classes/models/FrmSolution.php

Braces +2 added lines, -1 removed lines

@@ -125,7 +125,8 @@
 		}
 
 		// Only do this for single site installs.
-		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) { // WPCS: CSRF ok.
+		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) {
+// WPCS: CSRF ok.
 			return;
 		}
 

Doc Comments +3 added lines

@@ -546,6 +546,9 @@
 		$this->show_import_options( $this->view_options(), 'view' );
 	}
 
+	/**
+	 * @param string $importing
+	 */
 	protected function show_import_options( $options, $importing, $xml = '' ) {
 		if ( empty( $options ) ) {
 			return;

Spacing +10 added lines, -10 removed lines

@@ -159,7 +159,7 @@ 
 	 */
 	public function add_settings( $sections ) {
 		wp_enqueue_style( 'formidable-pro-fields' );
-		$sections[ $this->plugin_slug ] = array(
+		$sections[$this->plugin_slug] = array(
 			'class'    => $this,
 			'function' => 'settings_page',
 			'name'     => $this->plugin_name(),
@@ -316,9 +316,9 @@ 
 			// Set the current step.
 			if ( ! isset( $step['current'] ) ) {
 				if ( $step['complete'] ) {
-					$steps[ $k ]['current'] = false;
+					$steps[$k]['current'] = false;
 				} else {
-					$steps[ $k ]['current'] = ! $has_current;
+					$steps[$k]['current'] = ! $has_current;
 					$has_current = true;
 				}
 			} elseif ( $step['current'] ) {
@@ -328,10 +328,10 @@ 
 			// Set disabled buttons.
 			$class = isset( $step['button_class'] ) ? $step['button_class'] : '';
 			$class .= ' button-primary frm-button-primary';
-			if ( ! $steps[ $k ]['current'] ) {
+			if ( ! $steps[$k]['current'] ) {
 				$class .= ' frm_grey disabled';
 			}
-			$steps[ $k ]['button_class'] = $class;
+			$steps[$k]['button_class'] = $class;
 		}
 
 		return $steps;
@@ -353,7 +353,7 @@ 
 			if ( $plugin['status'] === 'active' ) {
 				continue;
 			}
-			$links[ $plugin_key ] = $plugin;
+			$links[$plugin_key] = $plugin;
 			if ( isset( $plugin['url'] ) ) {
 				$rel[] = $plugin['url'];
 			} else {
@@ -468,7 +468,7 @@ 
 		$addons = $api->get_api_info();
 
 		$id = $this->download_id();
-		$has_file = isset( $addons[ $id ] ) && isset( $addons[ $id ]['beta'] );
+		$has_file = isset( $addons[$id] ) && isset( $addons[$id]['beta'] );
 
 		if ( ! $step['current'] ) {
 			?>
@@ -483,10 +483,10 @@ 
 
 		if ( ! $has_file ) {
 			echo '<p class="frm_error_style">' . esc_html__( 'We didn\'t find anything to import. Please contact our team.', 'formidable' ) . '</p>';
-		} elseif ( ! isset( $addons[ $id ]['beta']['package'] ) ) {
+		} elseif ( ! isset( $addons[$id]['beta']['package'] ) ) {
 			echo '<p class="frm_error_style">' . esc_html__( 'Looks like you may not have a current subscription for this solution. Please check your account.', 'formidable' ) . '</p>';
 		} else {
-			$xml = $addons[ $id ]['beta']['package'];
+			$xml = $addons[$id]['beta']['package'];
 			if ( is_array( $xml ) ) {
 				$xml = reset( $xml );
 			}
@@ -624,7 +624,7 @@ 
 		foreach ( $forms as $form ) {
 			$was_imported = isset( $form['form'] ) ? FrmForm::get_id_by_key( $form['form'] ) : false;
 			if ( $was_imported ) {
-				$imported[ $form['form'] ] = $was_imported;
+				$imported[$form['form']] = $was_imported;
 			}
 		}
 

classes/views/inbox/list.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 			</h3>
 			<span class="frm_inbox_date">
 				<?php
-				if ( ! isset( $message['read'] ) || ! isset( $message['read'][ $user->ID ] ) ) {
+				if ( ! isset( $message['read'] ) || ! isset( $message['read'][$user->ID] ) ) {
 					$inbox->mark_read( $key );
 					?>
 					<span class="frm_inbox_unread"></span>

classes/models/FrmInbox.php

Doc Comments +4 added lines

@@ -132,6 +132,9 @@ 
 		}
 	}
 
+	/**
+	 * @param boolean $messages
+	 */
 	private function filter_messages( &$messages ) {
 		$user_id = get_current_user_id();
 		foreach ( $messages as $k => $message ) {
@@ -256,6 +259,7 @@ 
 
 	/**
 	 * @since 4.05.02
+	 * @param string $key
 	 */
 	public function remove( $key ) {
 		if ( isset( $this->messages[ $key ] ) ) {

Spacing +27 added lines, -27 removed lines

@@ -84,7 +84,7 @@ 
 			return;
 		}
 
-		if ( isset( $this->messages[ $message['key'] ] ) && ! isset( $message['force'] ) ) {
+		if ( isset( $this->messages[$message['key']] ) && ! isset( $message['force'] ) ) {
 			// Don't replace messages unless required.
 			return;
 		}
@@ -93,13 +93,13 @@ 
 			return;
 		}
 
-		if ( isset( $this->messages[ $message['key'] ] ) ) {
+		if ( isset( $this->messages[$message['key']] ) ) {
 			// Move up and mark as new.
-			unset( $this->messages[ $message['key'] ] );
+			unset( $this->messages[$message['key']] );
 		}
 
 		$this->fill_message( $message );
-		$this->messages[ $message['key'] ] = $message;
+		$this->messages[$message['key']] = $message;
 
 		$this->update_list();
 
@@ -127,11 +127,11 @@ 
 	private function clean_messages() {
 		$removed  = false;
 		foreach ( $this->messages as $t => $message ) {
-			$read    = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][ get_current_user_id() ] ) && $message['read'][ get_current_user_id() ] < strtotime( '-1 month' );
-			$dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][ get_current_user_id() ] ) && $message['dismissed'][ get_current_user_id() ] < strtotime( '-1 week' );
+			$read    = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][get_current_user_id()] ) && $message['read'][get_current_user_id()] < strtotime( '-1 month' );
+			$dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][get_current_user_id()] ) && $message['dismissed'][get_current_user_id()] < strtotime( '-1 week' );
 			$expired = $this->is_expired( $message );
 			if ( $read || $expired || $dismissed ) {
-				unset( $this->messages[ $t ] );
+				unset( $this->messages[$t] );
 				$removed = true;
 			}
 		}
@@ -144,11 +144,11 @@ 
 	private function filter_messages( &$messages ) {
 		$user_id = get_current_user_id();
 		foreach ( $messages as $k => $message ) {
-			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][ $user_id ] );
+			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][$user_id] );
 			if ( empty( $k ) || $this->is_expired( $message ) || $dismissed ) {
-				unset( $messages[ $k ] );
+				unset( $messages[$k] );
 			} elseif ( ! $this->is_for_user( $message ) ) {
-				unset( $messages[ $k ] );
+				unset( $messages[$k] );
 			}
 		}
 		$messages = apply_filters( 'frm_filter_inbox', $messages );
@@ -181,14 +181,14 @@ 
 	 * @param string $key
 	 */
 	public function mark_read( $key ) {
-		if ( ! $key || ! isset( $this->messages[ $key ] ) ) {
+		if ( ! $key || ! isset( $this->messages[$key] ) ) {
 			return;
 		}
 
-		if ( ! isset( $this->messages[ $key ]['read'] ) ) {
-			$this->messages[ $key ]['read'] = array();
+		if ( ! isset( $this->messages[$key]['read'] ) ) {
+			$this->messages[$key]['read'] = array();
 		}
-		$this->messages[ $key ]['read'][ get_current_user_id() ] = time();
+		$this->messages[$key]['read'][get_current_user_id()] = time();
 
 		$this->update_list();
 	}
@@ -199,9 +199,9 @@ 
 	 * @since 4.05.02
 	 */
 	public function mark_unread( $key ) {
-		$is_read = isset( $this->messages[ $key ] ) && isset( $this->messages[ $key ]['read'] ) && isset( $this->messages[ $key ]['read'][ get_current_user_id() ] );
+		$is_read = isset( $this->messages[$key] ) && isset( $this->messages[$key]['read'] ) && isset( $this->messages[$key]['read'][get_current_user_id()] );
 		if ( $is_read ) {
-			unset( $this->messages[ $key ]['read'][ get_current_user_id() ] );
+			unset( $this->messages[$key]['read'][get_current_user_id()] );
 			$this->update_list();
 		}
 	}
@@ -215,14 +215,14 @@ 
 			return;
 		}
 
-		if ( ! isset( $this->messages[ $key ] ) ) {
+		if ( ! isset( $this->messages[$key] ) ) {
 			return;
 		}
 
-		if ( ! isset( $this->messages[ $key ]['dismissed'] ) ) {
-			$this->messages[ $key ]['dismissed'] = array();
+		if ( ! isset( $this->messages[$key]['dismissed'] ) ) {
+			$this->messages[$key]['dismissed'] = array();
 		}
-		$this->messages[ $key ]['dismissed'][ get_current_user_id() ] = time();
+		$this->messages[$key]['dismissed'][get_current_user_id()] = time();
 
 		$this->update_list();
 	}
@@ -234,11 +234,11 @@ 
 		$user_id = get_current_user_id();
 		foreach ( $this->messages as $key => $message ) {
 			if ( ! isset( $message['dismissed'] ) ) {
-				$this->messages[ $key ]['dismissed'] = array();
+				$this->messages[$key]['dismissed'] = array();
 			}
 
-			if ( ! isset( $message['dismissed'][ $user_id ] ) ) {
-				$this->messages[ $key ]['dismissed'][ $user_id ] = time();
+			if ( ! isset( $message['dismissed'][$user_id] ) ) {
+				$this->messages[$key]['dismissed'][$user_id] = time();
 			}
 		}
 		$this->update_list();
@@ -248,8 +248,8 @@ 
 		$messages = $this->get_messages( 'filter' );
 		$user_id  = get_current_user_id();
 		foreach ( $messages as $t => $message ) {
-			if ( isset( $message['read'] ) && isset( $message['read'][ $user_id ] ) ) {
-				unset( $messages[ $t ] );
+			if ( isset( $message['read'] ) && isset( $message['read'][$user_id] ) ) {
+				unset( $messages[$t] );
 			}
 		}
 		return $messages;
@@ -273,8 +273,8 @@ 
 	 * @since 4.05.02
 	 */
 	public function remove( $key ) {
-		if ( isset( $this->messages[ $key ] ) ) {
-			unset( $this->messages[ $key ] );
+		if ( isset( $this->messages[$key] ) ) {
+			unset( $this->messages[$key] );
 			$this->update_list();
 		}
 	}