Completed
Push — master ( c99203...9f8d32 )
by
unknown
21s queued 13s
created
classes/helpers/FrmFieldsHelper.php 1 patch
Spacing   +49 added lines, -49 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 			if ( in_array( $type, array( 'data', 'lookup' ), true ) ) {
39 39
 				$values['field_options']['data_type'] = $setting;
40 40
 			} else {
41
-				$values['field_options'][ $setting ] = 1;
41
+				$values['field_options'][$setting] = 1;
42 42
 			}
43 43
 		}
44 44
 
@@ -172,10 +172,10 @@  discard block
 block discarded – undo
172 172
 		}
173 173
 
174 174
 		foreach ( $defaults as $opt => $default ) {
175
-			$values[ $opt ] = isset( $field->field_options[ $opt ] ) ? $field->field_options[ $opt ] : $default;
175
+			$values[$opt] = isset( $field->field_options[$opt] ) ? $field->field_options[$opt] : $default;
176 176
 
177 177
 			if ( $check_post ) {
178
-				self::get_posted_field_setting( $opt . '_' . $field->id, $values[ $opt ] );
178
+				self::get_posted_field_setting( $opt . '_' . $field->id, $values[$opt] );
179 179
 			}
180 180
 		}
181 181
 	}
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 			return self::$context_is_safe_to_load_field_options_from_request_data;
193 193
 		}
194 194
 
195
-		$function = function () {
195
+		$function = function() {
196 196
 			if ( ! FrmAppHelper::is_admin_page() ) {
197 197
 				return false;
198 198
 			}
@@ -300,12 +300,12 @@  discard block
 block discarded – undo
300 300
 	 * @param mixed  $value
301 301
 	 */
302 302
 	private static function get_posted_field_setting( $setting, &$value ) {
303
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
303
+		if ( ! isset( $_POST['field_options'][$setting] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
304 304
 			return;
305 305
 		}
306 306
 
307 307
 		if ( strpos( $setting, 'html' ) !== false ) {
308
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
308
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
309 309
 
310 310
 			// Conditionally strip script tags if the user sending $_POST data is not allowed to use unfiltered HTML.
311 311
 			if ( ! FrmAppHelper::allow_unfiltered_html() ) {
@@ -313,9 +313,9 @@  discard block
 block discarded – undo
313 313
 			}
314 314
 		} elseif ( strpos( $setting, 'format_' ) === 0 ) {
315 315
 			// TODO: Remove stripslashes on output, and use on input only.
316
-			$value = sanitize_text_field( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
316
+			$value = sanitize_text_field( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
317 317
 		} else {
318
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
318
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
319 319
 			FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
320 320
 		}
321 321
 	}
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
 		$values['default_value'] = FrmAppHelper::maybe_json_encode( $field->default_value );
389 389
 
390 390
 		foreach ( array( 'name', 'description', 'type', 'field_order', 'field_options', 'required' ) as $col ) {
391
-			$values[ $col ] = $field->{$col};
391
+			$values[$col] = $field->{$col};
392 392
 		}
393 393
 	}
394 394
 
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
 		);
427 427
 
428 428
 		$msg = FrmField::get_option( $field, $error );
429
-		$msg = empty( $msg ) ? $defaults[ $error ]['part'] : $msg;
429
+		$msg = empty( $msg ) ? $defaults[$error]['part'] : $msg;
430 430
 		$msg = do_shortcode( $msg );
431 431
 
432 432
 		$msg = self::maybe_replace_substrings_with_field_name( $msg, $error, $field );
@@ -694,7 +694,7 @@  discard block
 block discarded – undo
694 694
 			'title'        => '',
695 695
 			'inside_class' => 'inside',
696 696
 		);
697
-		$args     = array_merge( $defaults, $args );
697
+		$args = array_merge( $defaults, $args );
698 698
 
699 699
 		include FrmAppHelper::plugin_path() . '/classes/views/frm-fields/back-end/inline-modal.php';
700 700
 	}
@@ -931,7 +931,7 @@  discard block
 block discarded – undo
931 931
 				continue;
932 932
 			}
933 933
 
934
-			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][ $short_key ] );
934
+			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][$short_key] );
935 935
 			$tag  = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
936 936
 
937 937
 			$atts['entry'] = $entry;
@@ -941,7 +941,7 @@  discard block
 block discarded – undo
941 941
 			if ( $replace_with !== null ) {
942 942
 				$replace_with = self::trigger_shortcode_atts( $replace_with, $atts );
943 943
 				self::sanitize_embedded_shortcodes( compact( 'entry' ), $replace_with );
944
-				$content = str_replace( $shortcodes[0][ $short_key ], $replace_with, $content );
944
+				$content = str_replace( $shortcodes[0][$short_key], $replace_with, $content );
945 945
 			}
946 946
 
947 947
 			unset( $atts, $replace_with );
@@ -959,7 +959,7 @@  discard block
 block discarded – undo
959 959
 		$supported_atts = array( 'remove_accents', 'sanitize', 'sanitize_url' );
960 960
 		$included_atts  = array_intersect( $supported_atts, array_keys( $atts ) );
961 961
 		foreach ( $included_atts as $included_att ) {
962
-			if ( '0' === $atts[ $included_att ] ) {
962
+			if ( '0' === $atts[$included_att] ) {
963 963
 				// Skip any option that uses 0 so sanitize_url=0 does not encode.
964 964
 				continue;
965 965
 			}
@@ -1037,8 +1037,8 @@  discard block
 block discarded – undo
1037 1037
 
1038 1038
 		$dynamic_default = array( 'admin_email', 'siteurl', 'frmurl', 'sitename', 'get', 'default-email', 'default-from-email' );
1039 1039
 
1040
-		if ( isset( $shortcode_values[ $atts['tag'] ] ) ) {
1041
-			$replace_with = $shortcode_values[ $atts['tag'] ];
1040
+		if ( isset( $shortcode_values[$atts['tag']] ) ) {
1041
+			$replace_with = $shortcode_values[$atts['tag']];
1042 1042
 		} elseif ( in_array( $atts['tag'], $dynamic_default, true ) ) {
1043 1043
 			$replace_with = self::dynamic_default_values( $atts['tag'], $atts );
1044 1044
 		} elseif ( $clean_tag === 'user_agent' ) {
@@ -1262,8 +1262,8 @@  discard block
 block discarded – undo
1262 1262
 			self::field_types_for_input( $single_input, $field_selection, $field_types );
1263 1263
 		} elseif ( in_array( $type, $multiple_input, true ) ) {
1264 1264
 			self::field_types_for_input( $multiple_input, $field_selection, $field_types );
1265
-		} elseif ( isset( $field_selection[ $type ] ) ) {
1266
-			$field_types[ $type ] = $field_selection[ $type ];
1265
+		} elseif ( isset( $field_selection[$type] ) ) {
1266
+			$field_types[$type] = $field_selection[$type];
1267 1267
 		}
1268 1268
 
1269 1269
 		$field_types = apply_filters( 'frm_switch_field_types', $field_types, compact( 'type', 'field_selection' ) );
@@ -1304,7 +1304,7 @@  discard block
 block discarded – undo
1304 1304
 		foreach ( $inputs as $input ) {
1305 1305
 			// This may not be set if a field type was removed using the frm_available_fields or frm_pro_available_fields filters.
1306 1306
 			if ( array_key_exists( $input, $fields ) ) {
1307
-				$field_types[ $input ] = $fields[ $input ];
1307
+				$field_types[$input] = $fields[$input];
1308 1308
 			}
1309 1309
 			unset( $input );
1310 1310
 		}
@@ -1337,7 +1337,7 @@  discard block
 block discarded – undo
1337 1337
 			'parent'  => false,
1338 1338
 			'pointer' => false,
1339 1339
 		);
1340
-		$args     = wp_parse_args( $args, $defaults );
1340
+		$args = wp_parse_args( $args, $defaults );
1341 1341
 
1342 1342
 		$opt_key   = $args['opt_key'];
1343 1343
 		$field     = $args['field'];
@@ -1353,25 +1353,25 @@  discard block
 block discarded – undo
1353 1353
 
1354 1354
 		// Check posted vals before checking saved values
1355 1355
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
1356
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1356
+		if ( $parent && isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1357 1357
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1358 1358
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1359
-				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1359
+				$other_val = isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ) : '';
1360 1360
 			} else {
1361
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1361
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1362 1362
 			}
1363 1363
 
1364 1364
 			return $other_val;
1365 1365
 		}
1366 1366
 
1367
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1367
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1368 1368
 			// For normal fields
1369 1369
 
1370 1370
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1371 1371
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1372
-				$other_val = isset( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1372
+				$other_val = isset( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ) : '';
1373 1373
 			} else {
1374
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1374
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1375 1375
 			}
1376 1376
 
1377 1377
 			return $other_val;
@@ -1381,8 +1381,8 @@  discard block
 block discarded – undo
1381 1381
 		if ( $field['type'] === 'checkbox' && is_array( $field['value'] ) ) {
1382 1382
 			// Check if there is an "other" val in saved value and make sure the
1383 1383
 			// "other" val is not equal to the Other checkbox option
1384
-			if ( isset( $field['value'][ $opt_key ] ) && $field['options'][ $opt_key ] != $field['value'][ $opt_key ] ) {
1385
-				$other_val = $field['value'][ $opt_key ];
1384
+			if ( isset( $field['value'][$opt_key] ) && $field['options'][$opt_key] != $field['value'][$opt_key] ) {
1385
+				$other_val = $field['value'][$opt_key];
1386 1386
 			}
1387 1387
 		} else {
1388 1388
 			/**
@@ -1394,8 +1394,8 @@  discard block
 block discarded – undo
1394 1394
 				// Multi-select dropdowns - key is not preserved
1395 1395
 				if ( is_array( $field['value'] ) ) {
1396 1396
 					$o_key = array_search( $temp_val, $field['value'] );
1397
-					if ( isset( $field['value'][ $o_key ] ) ) {
1398
-						unset( $field['value'][ $o_key ], $o_key );
1397
+					if ( isset( $field['value'][$o_key] ) ) {
1398
+						unset( $field['value'][$o_key], $o_key );
1399 1399
 					}
1400 1400
 				} elseif ( $temp_val == $field['value'] ) {
1401 1401
 					// For radio and regular dropdowns
@@ -1603,11 +1603,11 @@  discard block
 block discarded – undo
1603 1603
 			foreach ( $val as $k => $v ) {
1604 1604
 				if ( is_string( $v ) ) {
1605 1605
 					if ( 'custom_html' === $k ) {
1606
-						$val[ $k ] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
1606
+						$val[$k] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
1607 1607
 						unset( $k, $v );
1608 1608
 						continue;
1609 1609
 					}
1610
-					$val[ $k ] = str_replace( $replace, $replace_with, $v );
1610
+					$val[$k] = str_replace( $replace, $replace_with, $v );
1611 1611
 					unset( $k, $v );
1612 1612
 				}
1613 1613
 			}
@@ -1636,8 +1636,8 @@  discard block
 block discarded – undo
1636 1636
 			if ( false === $index ) {
1637 1637
 				continue;
1638 1638
 			}
1639
-			unset( $replace[ $index ] );
1640
-			unset( $replace_with[ $index ] );
1639
+			unset( $replace[$index] );
1640
+			unset( $replace_with[$index] );
1641 1641
 		}
1642 1642
 		$value = str_replace( $replace, $replace_with, $value );
1643 1643
 		return $value;
@@ -1985,7 +1985,7 @@  discard block
 block discarded – undo
1985 1985
 			$countries['class'] = 'frm-countries-opts';
1986 1986
 		}
1987 1987
 
1988
-		$prepop[ __( 'Countries', 'formidable' ) ] = $countries;
1988
+		$prepop[__( 'Countries', 'formidable' )] = $countries;
1989 1989
 
1990 1990
 		// State abv.
1991 1991
 		$states    = self::get_us_states();
@@ -1995,7 +1995,7 @@  discard block
 block discarded – undo
1995 1995
 			$state_abv['class'] = 'frm-state-abv-opts';
1996 1996
 		}
1997 1997
 
1998
-		$prepop[ __( 'U.S. State Abbreviations', 'formidable' ) ] = $state_abv;
1998
+		$prepop[__( 'U.S. State Abbreviations', 'formidable' )] = $state_abv;
1999 1999
 
2000 2000
 		// States.
2001 2001
 		$states = array_values( $states );
@@ -2004,7 +2004,7 @@  discard block
 block discarded – undo
2004 2004
 			$states['class'] = 'frm-states-opts';
2005 2005
 		}
2006 2006
 
2007
-		$prepop[ __( 'U.S. States', 'formidable' ) ] = $states;
2007
+		$prepop[__( 'U.S. States', 'formidable' )] = $states;
2008 2008
 		unset( $state_abv, $states );
2009 2009
 
2010 2010
 		// Age.
@@ -2022,7 +2022,7 @@  discard block
 block discarded – undo
2022 2022
 			$ages['class'] = 'frm-age-opts';
2023 2023
 		}
2024 2024
 
2025
-		$prepop[ __( 'Age', 'formidable' ) ] = $ages;
2025
+		$prepop[__( 'Age', 'formidable' )] = $ages;
2026 2026
 
2027 2027
 		// Satisfaction.
2028 2028
 		$satisfaction = array(
@@ -2037,7 +2037,7 @@  discard block
 block discarded – undo
2037 2037
 			$satisfaction['class'] = 'frm-satisfaction-opts';
2038 2038
 		}
2039 2039
 
2040
-		$prepop[ __( 'Satisfaction', 'formidable' ) ] = $satisfaction;
2040
+		$prepop[__( 'Satisfaction', 'formidable' )] = $satisfaction;
2041 2041
 
2042 2042
 		// Importance.
2043 2043
 		$importance = array(
@@ -2052,7 +2052,7 @@  discard block
 block discarded – undo
2052 2052
 			$importance['class'] = 'frm-importance-opts';
2053 2053
 		}
2054 2054
 
2055
-		$prepop[ __( 'Importance', 'formidable' ) ] = $importance;
2055
+		$prepop[__( 'Importance', 'formidable' )] = $importance;
2056 2056
 
2057 2057
 		// Agreement.
2058 2058
 		$agreement = array(
@@ -2067,7 +2067,7 @@  discard block
 block discarded – undo
2067 2067
 			$agreement['class'] = 'frm-agreement-opts';
2068 2068
 		}
2069 2069
 
2070
-		$prepop[ __( 'Agreement', 'formidable' ) ] = $agreement;
2070
+		$prepop[__( 'Agreement', 'formidable' )] = $agreement;
2071 2071
 
2072 2072
 		// Likely.
2073 2073
 		$likely = array(
@@ -2082,7 +2082,7 @@  discard block
 block discarded – undo
2082 2082
 			$likely['class'] = 'frm-likely-opts';
2083 2083
 		}
2084 2084
 
2085
-		$prepop[ __( 'Likely', 'formidable' ) ] = $likely;
2085
+		$prepop[__( 'Likely', 'formidable' )] = $likely;
2086 2086
 
2087 2087
 		$prepop = apply_filters( 'frm_bulk_field_choices', $prepop );
2088 2088
 	}
@@ -2303,16 +2303,16 @@  discard block
 block discarded – undo
2303 2303
 	 */
2304 2304
 	private static function fill_image_setting_options( $options, &$args ) {
2305 2305
 		foreach ( $options as $key => $option ) {
2306
-			$args['options'][ $key ] = $option;
2306
+			$args['options'][$key] = $option;
2307 2307
 
2308 2308
 			if ( ! empty( $option['addon'] ) ) {
2309
-				$args['options'][ $key ]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2309
+				$args['options'][$key]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2310 2310
 			}
2311 2311
 
2312
-			unset( $args['options'][ $key ]['addon'] );
2312
+			unset( $args['options'][$key]['addon'] );
2313 2313
 			$fill = array( 'upgrade', 'message', 'content' );
2314 2314
 			foreach ( $fill as $f ) {
2315
-				unset( $args['options'][ $key ][ $f ], $f );
2315
+				unset( $args['options'][$key][$f], $f );
2316 2316
 			}
2317 2317
 		}
2318 2318
 	}
@@ -2333,8 +2333,8 @@  discard block
 block discarded – undo
2333 2333
 
2334 2334
 		$fill = array( 'upgrade', 'message', 'content' );
2335 2335
 		foreach ( $fill as $f ) {
2336
-			if ( isset( $option[ $f ] ) ) {
2337
-				$custom_attrs[ 'data-' . $f ] = $option[ $f ];
2336
+			if ( isset( $option[$f] ) ) {
2337
+				$custom_attrs['data-' . $f] = $option[$f];
2338 2338
 			}
2339 2339
 		}
2340 2340
 
@@ -2400,7 +2400,7 @@  discard block
 block discarded – undo
2400 2400
 
2401 2401
 		return array_filter(
2402 2402
 			$rows,
2403
-			function ( $row ) {
2403
+			function( $row ) {
2404 2404
 				FrmAppHelper::unserialize_or_decode( $row->field_options );
2405 2405
 				return is_array( $row->field_options ) && ! empty( $row->field_options['draft'] );
2406 2406
 			}
Please login to merge, or discard this patch.