Strategy11 / formidable-forms

classes/controllers/FrmEntriesController.php

Spacing +22 added lines, -22 removed lines

@@ -65,19 +65,19 @@ 
 		global $frm_vars;
 		$form_id = FrmForm::get_current_form_id();
 
-		$columns[ $form_id . '_id' ]       = 'ID';
-		$columns[ $form_id . '_item_key' ] = esc_html__( 'Entry Key', 'formidable' );
+		$columns[$form_id . '_id']       = 'ID';
+		$columns[$form_id . '_item_key'] = esc_html__( 'Entry Key', 'formidable' );
 
 		if ( $form_id ) {
 			self::get_columns_for_form( $form_id, $columns );
 		} else {
-			$columns[ $form_id . '_form_id' ] = __( 'Form', 'formidable' );
-			$columns[ $form_id . '_name' ]    = __( 'Entry Name', 'formidable' );
-			$columns[ $form_id . '_user_id' ] = __( 'Created By', 'formidable' );
+			$columns[$form_id . '_form_id'] = __( 'Form', 'formidable' );
+			$columns[$form_id . '_name']    = __( 'Entry Name', 'formidable' );
+			$columns[$form_id . '_user_id'] = __( 'Created By', 'formidable' );
 		}
 
-		$columns[ $form_id . '_created_at' ] = __( 'Entry creation date', 'formidable' );
-		$columns[ $form_id . '_updated_at' ] = __( 'Entry update date', 'formidable' );
+		$columns[$form_id . '_created_at'] = __( 'Entry creation date', 'formidable' );
+		$columns[$form_id . '_updated_at'] = __( 'Entry update date', 'formidable' );
 		self::maybe_add_ip_col( $form_id, $columns );
 
 		$frm_vars['cols'] = $columns;
@@ -125,10 +125,10 @@ 
 
 		foreach ( $sub_form_cols as $k => $sub_form_col ) {
 			if ( FrmField::is_no_save_field( $sub_form_col->type ) ) {
-				unset( $sub_form_cols[ $k ] );
+				unset( $sub_form_cols[$k] );
 				continue;
 			}
-			$columns[ $form_id . '_' . $sub_form_col->field_key . '-_-' . $field->id ] = FrmAppHelper::truncate( $sub_form_col->name, 35 );
+			$columns[$form_id . '_' . $sub_form_col->field_key . '-_-' . $field->id] = FrmAppHelper::truncate( $sub_form_col->name, 35 );
 			unset( $sub_form_col );
 		}
 	}
@@ -145,15 +145,15 @@ 
 		$has_separate_value = ! FrmField::is_option_empty( $field, 'separate_value' );
 		$is_post_status     = FrmField::is_option_true( $field, 'post_field' ) && $field->field_options['post_field'] == 'post_status';
 		if ( $has_separate_value && ! $is_post_status ) {
-			$columns[ $form_id . '_frmsep_' . $col_id ] = FrmAppHelper::truncate( $field->name, 35 );
+			$columns[$form_id . '_frmsep_' . $col_id] = FrmAppHelper::truncate( $field->name, 35 );
 		}
 
-		$columns[ $form_id . '_' . $col_id ] = FrmAppHelper::truncate( $field->name, 35 );
+		$columns[$form_id . '_' . $col_id] = FrmAppHelper::truncate( $field->name, 35 );
 	}
 
 	private static function maybe_add_ip_col( $form_id, &$columns ) {
 		if ( FrmAppHelper::ips_saved() ) {
-			$columns[ $form_id . '_ip' ] = 'IP';
+			$columns[$form_id . '_ip'] = 'IP';
 		}
 	}
 
@@ -191,7 +191,7 @@ 
 		foreach ( $meta_value as $mk => $mv ) {
 			// Remove blank values.
 			if ( empty( $mv ) ) {
-				unset( $meta_value[ $mk ] );
+				unset( $meta_value[$mk] );
 			}
 		}
 
@@ -268,7 +268,7 @@ 
 		foreach ( $fields as $field ) {
 			if ( $field->type != 'checkbox' && ( ! isset( $field->field_options['post_field'] ) || $field->field_options['post_field'] == '' ) ) {
 				// Can't sort on checkboxes because they are stored serialized, or post fields
-				$columns[ $form_id . '_' . $field->field_key ] = 'meta_' . $field->id;
+				$columns[$form_id . '_' . $field->field_key] = 'meta_' . $field->id;
 			}
 		}
 
@@ -332,7 +332,7 @@ 
 			$atts['form_id'] . '_item_key' => '',
 			$atts['form_id'] . '_id'       => '',
 		);
-		$cols         = $remove_first + array_reverse( $frm_vars['cols'], true );
+		$cols = $remove_first + array_reverse( $frm_vars['cols'], true );
 
 		$i = $atts['i'];
 
@@ -343,7 +343,7 @@ 
 
 			if ( empty( $result ) || ! in_array( $col_key, $result, true ) ) {
 				$result[] = $col_key;
-				$i--;
+				$i --;
 			}
 
 			unset( $col_key, $col );
@@ -476,9 +476,9 @@ 
 		if ( ! isset( $frm_vars['form_params'] ) ) {
 			$frm_vars['form_params'] = array();
 		}
-		$frm_vars['form_params'][ $form->id ] = $params;
+		$frm_vars['form_params'][$form->id] = $params;
 
-		if ( isset( $frm_vars['created_entries'][ $form_id ] ) ) {
+		if ( isset( $frm_vars['created_entries'][$form_id] ) ) {
 			return;
 		}
 
@@ -494,16 +494,16 @@ 
 		 */
 		$errors = apply_filters( 'frm_entries_before_create', $errors, $form );
 
-		$frm_vars['created_entries'][ $form_id ] = array( 'errors' => $errors );
+		$frm_vars['created_entries'][$form_id] = array( 'errors' => $errors );
 
 		if ( empty( $errors ) ) {
 			$_POST['frm_skip_cookie'] = 1;
 			$do_success               = false;
 			if ( $params['action'] == 'create' ) {
-				if ( apply_filters( 'frm_continue_to_create', true, $form_id ) && ! isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ) {
-					$frm_vars['created_entries'][ $form_id ]['entry_id'] = FrmEntry::create( $_POST );
+				if ( apply_filters( 'frm_continue_to_create', true, $form_id ) && ! isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ) {
+					$frm_vars['created_entries'][$form_id]['entry_id'] = FrmEntry::create( $_POST );
 
-					$params['id'] = $frm_vars['created_entries'][ $form_id ]['entry_id'];
+					$params['id'] = $frm_vars['created_entries'][$form_id]['entry_id'];
 					$do_success   = true;
 				}
 			}

classes/helpers/FrmAppHelper.php

Spacing +59 added lines, -59 removed lines

@@ -149,7 +149,7 @@ 
 			'fill'   => '#4d4d4d',
 			'orange' => '#f05a24',
 		);
-		$atts     = array_merge( $defaults, $atts );
+		$atts = array_merge( $defaults, $atts );
 
 		return '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 599.68 601.37" width="' . esc_attr( $atts['width'] ) . '" height="' . esc_attr( $atts['height'] ) . '">
 			<path fill="' . esc_attr( $atts['orange'] ) . '" d="M289.6 384h140v76h-140z"/>
@@ -337,7 +337,7 @@ 
 	 * @return string
 	 */
 	public static function get_server_value( $value ) {
-		return isset( $_SERVER[ $value ] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[ $value ] ) ) : '';
+		return isset( $_SERVER[$value] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[$value] ) ) : '';
 	}
 
 	/**
@@ -360,7 +360,7 @@ 
 		);
 		$ip = '';
 		foreach ( $ip_options as $key ) {
-			if ( ! isset( $_SERVER[ $key ] ) ) {
+			if ( ! isset( $_SERVER[$key] ) ) {
 				continue;
 			}
 
@@ -385,10 +385,10 @@ 
 
 		if ( $src == 'get' ) {
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-			$value = isset( $_POST[ $param ] ) ? wp_unslash( $_POST[ $param ] ) : ( isset( $_GET[ $param ] ) ? wp_unslash( $_GET[ $param ] ) : $default );
-			if ( ! isset( $_POST[ $param ] ) && isset( $_GET[ $param ] ) && ! is_array( $value ) ) {
+			$value = isset( $_POST[$param] ) ? wp_unslash( $_POST[$param] ) : ( isset( $_GET[$param] ) ? wp_unslash( $_GET[$param] ) : $default );
+			if ( ! isset( $_POST[$param] ) && isset( $_GET[$param] ) && ! is_array( $value ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = htmlspecialchars_decode( wp_unslash( $_GET[ $param ] ) );
+				$value = htmlspecialchars_decode( wp_unslash( $_GET[$param] ) );
 			}
 			self::sanitize_value( $sanitize, $value );
 		} else {
@@ -409,7 +409,7 @@ 
 				}
 
 				$p     = trim( $p, ']' );
-				$value = isset( $value[ $p ] ) ? $value[ $p ] : $default;
+				$value = isset( $value[$p] ) ? $value[$p] : $default;
 			}
 		}
 
@@ -465,26 +465,26 @@ 
 			'sanitize' => 'sanitize_text_field',
 			'serialized' => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$value = $args['default'];
 		if ( $args['type'] == 'get' ) {
-			if ( $_GET && isset( $_GET[ $args['param'] ] ) ) {
+			if ( $_GET && isset( $_GET[$args['param']] ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = wp_unslash( $_GET[ $args['param'] ] );
+				$value = wp_unslash( $_GET[$args['param']] );
 			}
 		} elseif ( $args['type'] == 'post' ) {
-			if ( isset( $_POST[ $args['param'] ] ) ) {
+			if ( isset( $_POST[$args['param']] ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = wp_unslash( $_POST[ $args['param'] ] );
+				$value = wp_unslash( $_POST[$args['param']] );
 				if ( $args['serialized'] === true && is_serialized_string( $value ) && is_serialized( $value ) ) {
 					self::unserialize_or_decode( $value );
 				}
 			}
 		} else {
-			if ( isset( $_REQUEST[ $args['param'] ] ) ) {
+			if ( isset( $_REQUEST[$args['param']] ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = wp_unslash( $_REQUEST[ $args['param'] ] );
+				$value = wp_unslash( $_REQUEST[$args['param']] );
 			}
 		}
 
@@ -516,7 +516,7 @@ 
 			if ( is_array( $value ) ) {
 				$temp_values = $value;
 				foreach ( $temp_values as $k => $v ) {
-					self::sanitize_value( $sanitize, $value[ $k ] );
+					self::sanitize_value( $sanitize, $value[$k] );
 				}
 			} else {
 				$value = call_user_func( $sanitize, $value );
@@ -527,8 +527,8 @@ 
 	public static function sanitize_request( $sanitize_method, &$values ) {
 		$temp_values = $values;
 		foreach ( $temp_values as $k => $val ) {
-			if ( isset( $sanitize_method[ $k ] ) ) {
-				$values[ $k ] = call_user_func( $sanitize_method[ $k ], $val );
+			if ( isset( $sanitize_method[$k] ) ) {
+				$values[$k] = call_user_func( $sanitize_method[$k], $val );
 			}
 		}
 	}
@@ -551,7 +551,7 @@ 
 		if ( is_array( $value ) ) {
 			$temp_values = $value;
 			foreach ( $temp_values as $k => $v ) {
-				self::decode_specialchars( $value[ $k ] );
+				self::decode_specialchars( $value[$k] );
 			}
 		} else {
 			self::decode_amp( $value );
@@ -628,7 +628,7 @@ 
 			$allowed_html = $html;
 		} elseif ( ! empty( $allowed ) ) {
 			foreach ( (array) $allowed as $a ) {
-				$allowed_html[ $a ] = isset( $html[ $a ] ) ? $html[ $a ] : array();
+				$allowed_html[$a] = isset( $html[$a] ) ? $html[$a] : array();
 			}
 		}
 
@@ -785,8 +785,8 @@ 
 		}
 
 		global $wp_query;
-		if ( isset( $wp_query->query_vars[ $param ] ) ) {
-			$value = $wp_query->query_vars[ $param ];
+		if ( isset( $wp_query->query_vars[$param] ) ) {
+			$value = $wp_query->query_vars[$param];
 		}
 
 		return $value;
@@ -950,7 +950,7 @@ 
 				'new_file_path' => self::plugin_path() . '/js',
 			)
 		);
-		$new_file  = new FrmCreateFile( $file_atts );
+		$new_file = new FrmCreateFile( $file_atts );
 
 		$files = array(
 			self::plugin_path() . '/js/jquery/jquery.placeholder.min.js',
@@ -1208,8 +1208,8 @@ 
 			return $error;
 		}
 
-		$nonce_value = ( $_REQUEST && isset( $_REQUEST[ $nonce_name ] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST[ $nonce_name ] ) ) : '';
-		if ( $_REQUEST && ( ! isset( $_REQUEST[ $nonce_name ] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
+		$nonce_value = ( $_REQUEST && isset( $_REQUEST[$nonce_name] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST[$nonce_name] ) ) : '';
+		if ( $_REQUEST && ( ! isset( $_REQUEST[$nonce_name] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
 			$frm_settings = self::get_settings();
 			$error        = $frm_settings->admin_permission;
 		}
@@ -1244,7 +1244,7 @@ 
 			} else {
 				foreach ( $value as $k => $v ) {
 					if ( ! is_array( $v ) ) {
-						$value[ $k ] = call_user_func( $original_function, $v );
+						$value[$k] = call_user_func( $original_function, $v );
 					}
 				}
 			}
@@ -1269,7 +1269,7 @@ 
 				$return = array_merge( $return, self::array_flatten( $value, $keys ) );
 			} else {
 				if ( $keys == 'keep' ) {
-					$return[ $key ] = $value;
+					$return[$key] = $value;
 				} else {
 					$return[] = $value;
 				}
@@ -1333,11 +1333,11 @@ 
 		}
 
 		$ver = $default;
-		if ( ! isset( $wp_scripts->registered[ $handle ] ) ) {
+		if ( ! isset( $wp_scripts->registered[$handle] ) ) {
 			return $ver;
 		}
 
-		$query = $wp_scripts->registered[ $handle ];
+		$query = $wp_scripts->registered[$handle];
 		if ( is_object( $query ) && ! empty( $query->ver ) ) {
 			$ver = $query->ver;
 		}
@@ -1472,7 +1472,7 @@ 
 
 		foreach ( array( 'name', 'description' ) as $var ) {
 			$default_val    = isset( $record->{$var} ) ? $record->{$var} : '';
-			$values[ $var ] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
+			$values[$var] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
 			unset( $var, $default_val );
 		}
 
@@ -1527,9 +1527,9 @@ 
 			}
 		}
 
-		$field_type = isset( $post_values['field_options'][ 'type_' . $field->id ] ) ? $post_values['field_options'][ 'type_' . $field->id ] : $field->type;
-		if ( isset( $post_values['item_meta'][ $field->id ] ) ) {
-			$new_value = $post_values['item_meta'][ $field->id ];
+		$field_type = isset( $post_values['field_options']['type_' . $field->id] ) ? $post_values['field_options']['type_' . $field->id] : $field->type;
+		if ( isset( $post_values['item_meta'][$field->id] ) ) {
+			$new_value = $post_values['item_meta'][$field->id];
 			self::unserialize_or_decode( $new_value );
 		} else {
 			$new_value = $meta_value;
@@ -1550,7 +1550,7 @@ 
 
 		$field_array = array_merge( $field->field_options, $field_array );
 
-		$values['fields'][ $field->id ] = $field_array;
+		$values['fields'][$field->id] = $field_array;
 	}
 
 	/**
@@ -1597,11 +1597,11 @@ 
 		}
 
 		foreach ( $form->options as $opt => $value ) {
-			if ( isset( $post_values[ $opt ] ) ) {
-				$values[ $opt ] = $post_values[ $opt ];
-				self::unserialize_or_decode( $values[ $opt ] );
+			if ( isset( $post_values[$opt] ) ) {
+				$values[$opt] = $post_values[$opt];
+				self::unserialize_or_decode( $values[$opt] );
 			} else {
-				$values[ $opt ] = $value;
+				$values[$opt] = $value;
 			}
 		}
 
@@ -1615,8 +1615,8 @@ 
 		$form_defaults = FrmFormsHelper::get_default_opts();
 
 		foreach ( $form_defaults as $opt => $default ) {
-			if ( ! isset( $values[ $opt ] ) || $values[ $opt ] == '' ) {
-				$values[ $opt ] = ( $post_values && isset( $post_values['options'][ $opt ] ) ) ? $post_values['options'][ $opt ] : $default;
+			if ( ! isset( $values[$opt] ) || $values[$opt] == '' ) {
+				$values[$opt] = ( $post_values && isset( $post_values['options'][$opt] ) ) ? $post_values['options'][$opt] : $default;
 			}
 
 			unset( $opt, $default );
@@ -1627,8 +1627,8 @@ 
 		}
 
 		foreach ( array( 'before', 'after', 'submit' ) as $h ) {
-			if ( ! isset( $values[ $h . '_html' ] ) ) {
-				$values[ $h . '_html' ] = ( isset( $post_values['options'][ $h . '_html' ] ) ? $post_values['options'][ $h . '_html' ] : FrmFormsHelper::get_default_html( $h ) );
+			if ( ! isset( $values[$h . '_html'] ) ) {
+				$values[$h . '_html'] = ( isset( $post_values['options'][$h . '_html'] ) ? $post_values['options'][$h . '_html'] : FrmFormsHelper::get_default_html( $h ) );
 			}
 			unset( $h );
 		}
@@ -1778,10 +1778,10 @@ 
 		$time_strings = self::get_time_strings();
 
 		foreach ( $time_strings as $k => $v ) {
-			if ( $diff[ $k ] ) {
-				$time_strings[ $k ] = $diff[ $k ] . ' ' . ( $diff[ $k ] > 1 ? $v[1] : $v[0] );
+			if ( $diff[$k] ) {
+				$time_strings[$k] = $diff[$k] . ' ' . ( $diff[$k] > 1 ? $v[1] : $v[0] );
 			} else {
-				unset( $time_strings[ $k ] );
+				unset( $time_strings[$k] );
 			}
 		}
 
@@ -1862,17 +1862,17 @@ 
 
 					case 1:
 						$l2 = $name;
-						self::add_value_to_array( $name, $l2, $this_val, $vars[ $l1 ] );
+						self::add_value_to_array( $name, $l2, $this_val, $vars[$l1] );
 						break;
 
 					case 2:
 						$l3 = $name;
-						self::add_value_to_array( $name, $l3, $this_val, $vars[ $l1 ][ $l2 ] );
+						self::add_value_to_array( $name, $l3, $this_val, $vars[$l1][$l2] );
 						break;
 
 					case 3:
 						$l4 = $name;
-						self::add_value_to_array( $name, $l4, $this_val, $vars[ $l1 ][ $l2 ][ $l3 ] );
+						self::add_value_to_array( $name, $l4, $this_val, $vars[$l1][$l2][$l3] );
 				}
 
 				unset( $this_val, $n );
@@ -1891,8 +1891,8 @@ 
 	public static function add_value_to_array( $name, $l1, $val, &$vars ) {
 		if ( $name == '' ) {
 			$vars[] = $val;
-		} elseif ( ! isset( $vars[ $l1 ] ) ) {
-			$vars[ $l1 ] = $val;
+		} elseif ( ! isset( $vars[$l1] ) ) {
+			$vars[$l1] = $val;
 		}
 	}
 
@@ -1908,7 +1908,7 @@ 
 			'email_subject' => esc_attr( sprintf( __( 'If you leave the subject blank, the default will be used: %1$s Form submitted on %2$s', 'formidable' ), $form_name, self::site_name() ) ),
 		);
 
-		if ( ! isset( $tooltips[ $name ] ) ) {
+		if ( ! isset( $tooltips[$name] ) ) {
 			return;
 		}
 
@@ -1918,7 +1918,7 @@ 
 			echo ' class="frm_help"';
 		}
 
-		echo ' title="' . esc_attr( $tooltips[ $name ] );
+		echo ' title="' . esc_attr( $tooltips[$name] );
 
 		if ( 'open' != $class ) {
 			echo '"';
@@ -1971,13 +1971,13 @@ 
 	}
 
 	private static function prepare_action_slashes( $val, $key, &$post_content ) {
-		if ( ! isset( $post_content[ $key ] ) ) {
+		if ( ! isset( $post_content[$key] ) ) {
 			return;
 		}
 
 		if ( is_array( $val ) ) {
 			foreach ( $val as $k1 => $v1 ) {
-				self::prepare_action_slashes( $v1, $k1, $post_content[ $key ] );
+				self::prepare_action_slashes( $v1, $k1, $post_content[$key] );
 				unset( $k1, $v1 );
 			}
 		} else {
@@ -1985,7 +1985,7 @@ 
 			$val = stripslashes( $val );
 
 			// Add backslashes before double quotes and forward slashes only
-			$post_content[ $key ] = addcslashes( $val, '"\\/' );
+			$post_content[$key] = addcslashes( $val, '"\\/' );
 		}
 	}
 
@@ -2044,14 +2044,14 @@ 
 				continue;
 			}
 			$key = $input['name'];
-			if ( isset( $formatted[ $key ] ) ) {
-				if ( is_array( $formatted[ $key ] ) ) {
-					$formatted[ $key ][] = $input['value'];
+			if ( isset( $formatted[$key] ) ) {
+				if ( is_array( $formatted[$key] ) ) {
+					$formatted[$key][] = $input['value'];
 				} else {
-					$formatted[ $key ] = array( $formatted[ $key ], $input['value'] );
+					$formatted[$key] = array( $formatted[$key], $input['value'] );
 				}
 			} else {
-				$formatted[ $key ] = $input['value'];
+				$formatted[$key] = $input['value'];
 			}
 		}
 

Doc Comments +24 added lines

@@ -69,6 +69,9 @@ 
 		return $url;
 	}
 
+	/**
+	 * @return string
+	 */
 	public static function get_affiliate() {
 		return absint( apply_filters( 'frm_affiliate_id', 0 ) );
 	}
@@ -134,6 +137,9 @@ 
 		return $frm_settings;
 	}
 
+	/**
+	 * @return string
+	 */
 	public static function get_menu_name() {
 		$frm_settings = self::get_settings();
 
@@ -1116,6 +1122,8 @@ 
 	 * This is for reverse compatibility with switching 3 params to 1.
 	 *
 	 * @since 4.03.06
+	 * @param string $page_id
+	 * @param boolean $truncate
 	 */
 	private static function prep_page_dropdown_params( $page_id, $truncate, &$args ) {
 		if ( ! is_array( $args ) ) {
@@ -1353,6 +1361,9 @@ 
 		return ( is_array( $values ) && in_array( $current, $values ) ) || ( ! is_array( $values ) && $values == $current );
 	}
 
+	/**
+	 * @param string $function
+	 */
 	public static function recursive_function_map( $value, $function ) {
 		if ( is_array( $value ) ) {
 			$original_function = $function;
@@ -1401,6 +1412,9 @@ 
 		return $return;
 	}
 
+	/**
+	 * @return string
+	 */
 	public static function esc_textarea( $text, $is_rich_text = false ) {
 		$safe_text = str_replace( '"', '"', $text );
 		if ( ! $is_rich_text ) {
@@ -1613,6 +1627,9 @@ 
 		return $values;
 	}
 
+	/**
+	 * @param string $fields
+	 */
 	private static function prepare_field_arrays( $fields, $record, array &$values, $args ) {
 		if ( ! empty( $fields ) ) {
 			foreach ( (array) $fields as $field ) {
@@ -1816,6 +1833,9 @@ 
 		return $sub . ( ( $len < $original_len ) ? $continue : '' );
 	}
 
+	/**
+	 * @param string[] $function_names
+	 */
 	public static function mb_function( $function_names, $args ) {
 		$mb_function_name = $function_names[0];
 		$function_name    = $function_names[1];
@@ -1850,6 +1870,9 @@ 
 		return $formatted;
 	}
 
+	/**
+	 * @param string $time_format
+	 */
 	private static function add_time_to_date( $time_format, $date ) {
 		if ( empty( $time_format ) ) {
 			$time_format = get_option( 'time_format' );
@@ -2337,6 +2360,7 @@ 
 	 * If Pro is far outdated, show a message.
 	 *
 	 * @since 4.0.01
+	 * @param string $min_version
 	 */
 	public static function min_pro_version_notice( $min_version ) {
 		if ( ! self::is_formidable_admin() ) {

classes/helpers/FrmFormsHelper.php

Spacing +21 added lines, -21 removed lines

@@ -28,7 +28,7 @@ 
 			'class'        => '',
 			'inc_children' => 'exclude',
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		if ( ! $args['field_id'] ) {
 			$args['field_id'] = $field_name;
@@ -70,7 +70,7 @@ 
 	 */
 	public static function add_html_attr( $class, $param, &$add_html ) {
 		if ( ! empty( $class ) ) {
-			$add_html[ $param ] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
+			$add_html[$param] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
 		}
 	}
 
@@ -276,8 +276,8 @@ 
 			'description' => '',
 		);
 		foreach ( $defaults as $var => $default ) {
-			if ( ! isset( $values[ $var ] ) ) {
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			if ( ! isset( $values[$var] ) ) {
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 			}
 		}
 
@@ -292,8 +292,8 @@ 
 			'parent_form_id' => 0,
 		);
 		foreach ( $defaults as $var => $default ) {
-			if ( ! isset( $values[ $var ] ) ) {
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			if ( ! isset( $values[$var] ) ) {
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 			}
 		}
 		unset( $defaults );
@@ -330,16 +330,16 @@ 
 		$defaults = self::get_default_opts();
 		foreach ( $defaults as $var => $default ) {
 			if ( is_array( $default ) ) {
-				if ( ! isset( $values[ $var ] ) ) {
-					$values[ $var ] = ( $record && isset( $record->options[ $var ] ) ) ? $record->options[ $var ] : array();
+				if ( ! isset( $values[$var] ) ) {
+					$values[$var] = ( $record && isset( $record->options[$var] ) ) ? $record->options[$var] : array();
 				}
 
 				foreach ( $default as $k => $v ) {
-					$values[ $var ][ $k ] = ( $post_values && isset( $post_values[ $var ][ $k ] ) ) ? $post_values[ $var ][ $k ] : ( ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) ) ? $record->options[ $var ][ $k ] : $v );
+					$values[$var][$k] = ( $post_values && isset( $post_values[$var][$k] ) ) ? $post_values[$var][$k] : ( ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) ) ? $record->options[$var][$k] : $v );
 
 					if ( is_array( $v ) ) {
 						foreach ( $v as $k1 => $v1 ) {
-							$values[ $var ][ $k ][ $k1 ] = ( $post_values && isset( $post_values[ $var ][ $k ][ $k1 ] ) ) ? $post_values[ $var ][ $k ][ $k1 ] : ( ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) && isset( $record->options[ $var ][ $k ][ $k1 ] ) ) ? $record->options[ $var ][ $k ][ $k1 ] : $v1 );
+							$values[$var][$k][$k1] = ( $post_values && isset( $post_values[$var][$k][$k1] ) ) ? $post_values[$var][$k][$k1] : ( ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) && isset( $record->options[$var][$k][$k1] ) ) ? $record->options[$var][$k][$k1] : $v1 );
 							unset( $k1, $v1 );
 						}
 					}
@@ -347,7 +347,7 @@ 
 					unset( $k, $v );
 				}
 			} else {
-				$values[ $var ] = ( $post_values && isset( $post_values['options'][ $var ] ) ) ? $post_values['options'][ $var ] : ( ( $record && isset( $record->options[ $var ] ) ) ? $record->options[ $var ] : $default );
+				$values[$var] = ( $post_values && isset( $post_values['options'][$var] ) ) ? $post_values['options'][$var] : ( ( $record && isset( $record->options[$var] ) ) ? $record->options[$var] : $default );
 			}
 
 			unset( $var, $default );
@@ -385,7 +385,7 @@ 
 	public static function fill_form_options( &$options, $values ) {
 		$defaults = self::get_default_opts();
 		foreach ( $defaults as $var => $default ) {
-			$options[ $var ] = isset( $values['options'][ $var ] ) ? $values['options'][ $var ] : $default;
+			$options[$var] = isset( $values['options'][$var] ) ? $values['options'][$var] : $default;
 			unset( $var, $default );
 		}
 	}
@@ -541,7 +541,7 @@ 
 	public static function insert_opt_html( $args ) {
 		$class  = isset( $args['class'] ) ? $args['class'] : '';
 		$fields = FrmField::all_field_selection();
-		$field  = isset( $fields[ $args['type'] ] ) ? $fields[ $args['type'] ] : array();
+		$field  = isset( $fields[$args['type']] ) ? $fields[$args['type']] : array();
 
 		self::prepare_field_type( $field );
 
@@ -693,7 +693,7 @@ 
 			FrmField::update( $field->id, array( 'field_order' => $field->field_order + 2 ) );
 		}
 
-		$add_order    += 2;
+		$add_order += 2;
 		$open         = false;
 		$reset_fields = true;
 	}
@@ -1045,10 +1045,10 @@ 
 				$link .= ' onclick="return confirm(\'' . esc_attr( $link_details['confirm'] ) . '\')"';
 			}
 
-			$label = ( isset( $link_details[ $length ] ) ? $link_details[ $length ] : $link_details['label'] );
-			if ( $length == 'icon' && isset( $link_details[ $length ] ) ) {
+			$label = ( isset( $link_details[$length] ) ? $link_details[$length] : $link_details['label'] );
+			if ( $length == 'icon' && isset( $link_details[$length] ) ) {
 				$label = '<span class="' . $label . '" title="' . esc_attr( $link_details['label'] ) . '" aria-hidden="true"></span>';
-				$link  .= ' aria-label="' . esc_attr( $link_details['label'] ) . '"';
+				$link .= ' aria-label="' . esc_attr( $link_details['label'] ) . '"';
 			}
 
 			$link .= '>' . $label . '</a>';
@@ -1196,7 +1196,7 @@ 
 			$status = 'publish';
 		}
 
-		$name = $nice_names[ $status ];
+		$name = $nice_names[$status];
 
 		return $name;
 	}
@@ -1223,11 +1223,11 @@ 
 
 		if ( count( $categories ) === 1 ) {
 			$category = reset( $categories );
-			$icon     = isset( $icons[ $category ] ) ? $icons[ $category ] : $icon;
+			$icon     = isset( $icons[$category] ) ? $icons[$category] : $icon;
 		} elseif ( ! empty( $categories ) ) {
 			foreach ( $icons as $cat => $icon ) {
 				if ( ! in_array( $cat, $categories ) ) {
-					unset( $icons[ $cat ] );
+					unset( $icons[$cat] );
 				}
 			}
 			$icon = reset( $icons );
@@ -1353,7 +1353,7 @@ 
 
 		foreach ( $item['categories'] as $k => $category ) {
 			if ( in_array( $category, $plans ) ) {
-				unset( $item['categories'][ $k ] );
+				unset( $item['categories'][$k] );
 				return $category;
 			}
 		}

Doc Comments +8 added lines, -4 removed lines

@@ -219,6 +219,7 @@ 
 
 	/**
 	 * @since 3.0
+	 * @return string
 	 */
 	public static function get_field_link_icon( $field_type ) {
 		if ( is_array( $field_type ) && isset( $field_type['icon'] ) ) {
@@ -698,6 +699,9 @@ 
 		$reset_fields = true;
 	}
 
+	/**
+	 * @return string
+	 */
 	public static function replace_shortcodes( $html, $form, $title = false, $description = false, $values = array() ) {
 		$codes = array(
 			'form_name'        => $title,
@@ -858,7 +862,7 @@ 
 	}
 
 	/**
-	 * @param object|string|boolean $form
+	 * @param string|boolean $form
 	 *
 	 * @return string
 	 */
@@ -1389,7 +1393,7 @@ 
 	 *
 	 * @param array $values The $_POST array, which contains the values submitted in a form.
 	 *
-	 * @return bool|string A warning message about unsafe params or false.
+	 * @return false|string A warning message about unsafe params or false.
 	 */
 	private static function check_redirect_url_for_unsafe_params( $values ) {
 		if ( ! isset( $values['options'] ) ) {
@@ -1434,7 +1438,7 @@ 
 	 *
 	 * @param array $unsafe_params_in_redirect Array of params from the redirect URL whose names are reserved words.
 	 *
-	 * @return bool|string A string with an unsafe param message or false.
+	 * @return false|string A string with an unsafe param message or false.
 	 */
 	private static function create_unsafe_param_warning( $unsafe_params_in_redirect ) {
 		$count                = count( $unsafe_params_in_redirect );
@@ -1465,7 +1469,7 @@ 
 	 *
 	 * @since 4.04
 	 *
-	 * @return array Array of WordPress reserved words.
+	 * @return string[] Array of WordPress reserved words.
 	 */
 	public static function reserved_words() {
 		return array(

classes/models/fields/FrmFieldUserID.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 	protected function get_field_value( $args ) {
 		$user_ID      = get_current_user_id();
 		$user_ID      = ( $user_ID ? $user_ID : '' );
-		$posted_value = ( FrmAppHelper::is_admin() && $_POST && isset( $_POST['item_meta'][ $this->field['id'] ] ) ); // WPCS: CSRF ok.
+		$posted_value = ( FrmAppHelper::is_admin() && $_POST && isset( $_POST['item_meta'][$this->field['id']] ) ); // WPCS: CSRF ok.
 		$action       = ( isset( $args['action'] ) ? $args['action'] : ( isset( $args['form_action'] ) ? $args['form_action'] : '' ) );
 		$updating     = $action == 'update';
 		return ( is_numeric( $this->field['value'] ) || $posted_value || $updating ) ? $this->field['value'] : $user_ID;

classes/views/frm-forms/add_field_links.php

Spacing +3 added lines, -3 removed lines

@@ -49,10 +49,10 @@
 foreach ( $pro_fields as $field_key => $field_type ) {
 
 	if ( isset( $field_type['section'] ) ) {
-		if ( ! isset( $field_sections[ $field_type['section'] ] ) ) {
-			$field_sections[ $field_type['section'] ] = array();
+		if ( ! isset( $field_sections[$field_type['section']] ) ) {
+			$field_sections[$field_type['section']] = array();
 		}
-		$field_sections[ $field_type['section'] ][ $field_key ] = $field_type;
+		$field_sections[$field_type['section']][$field_key] = $field_type;
 		continue;
 	}
 

classes/models/FrmField.php

Spacing +28 added lines, -28 removed lines

@@ -217,7 +217,7 @@ 
 		$new_values['field_key'] = FrmAppHelper::get_unique_key( $key, $wpdb->prefix . 'frm_fields', 'field_key' );
 
 		foreach ( array( 'name', 'description', 'type', 'default_value' ) as $col ) {
-			$new_values[ $col ] = $values[ $col ];
+			$new_values[$col] = $values[$col];
 		}
 
 		$new_values['options'] = $values['options'];
@@ -229,7 +229,7 @@ 
 		$new_values['created_at']    = current_time( 'mysql', 1 );
 
 		if ( isset( $values['id'] ) ) {
-			$frm_duplicate_ids[ $values['field_key'] ] = $new_values['field_key'];
+			$frm_duplicate_ids[$values['field_key']] = $new_values['field_key'];
 			$new_values                                = apply_filters( 'frm_duplicated_field', $new_values );
 		}
 
@@ -238,9 +238,9 @@ 
 		foreach ( $new_values as $k => $v ) {
 			if ( is_array( $v ) ) {
 				if ( $k === 'default_value' ) {
-					$new_values[ $k ] = FrmAppHelper::maybe_json_encode( $v );
+					$new_values[$k] = FrmAppHelper::maybe_json_encode( $v );
 				} else {
-					$new_values[ $k ] = serialize( $v );
+					$new_values[$k] = serialize( $v );
 				}
 			}
 			unset( $k, $v );
@@ -262,7 +262,7 @@ 
 
 		if ( $query_results ) {
 			if ( isset( $values['id'] ) ) {
-				$frm_duplicate_ids[ $values['id'] ] = $new_id;
+				$frm_duplicate_ids[$values['id']] = $new_id;
 			}
 
 			return $new_id;
@@ -274,7 +274,7 @@ 
 	public static function duplicate( $old_form_id, $form_id, $copy_keys = false, $blog_id = false ) {
 		global $frm_duplicate_ids;
 
-		$where  = array(
+		$where = array(
 			array(
 				'or'                => 1,
 				'fi.form_id'        => $old_form_id,
@@ -320,8 +320,8 @@ 
 
 			$values                                 = apply_filters( 'frm_duplicated_field', $values );
 			$new_id                                 = self::create( $values );
-			$frm_duplicate_ids[ $field->id ]        = $new_id;
-			$frm_duplicate_ids[ $field->field_key ] = $new_id;
+			$frm_duplicate_ids[$field->id]        = $new_id;
+			$frm_duplicate_ids[$field->field_key] = $new_id;
 			unset( $field );
 		}
 	}
@@ -352,8 +352,8 @@ 
 
 		// serialize array values
 		foreach ( array( 'field_options', 'options' ) as $opt ) {
-			if ( isset( $values[ $opt ] ) && is_array( $values[ $opt ] ) ) {
-				$values[ $opt ] = serialize( $values[ $opt ] );
+			if ( isset( $values[$opt] ) && is_array( $values[$opt] ) ) {
+				$values[$opt] = serialize( $values[$opt] );
 			}
 		}
 		if ( isset( $values['default_value'] ) && is_array( $values['default_value'] ) ) {
@@ -505,7 +505,7 @@ 
 				'id'        => $id,
 				'field_key' => $id,
 			);
-			$type  = FrmDb::get_var( 'frm_fields', $where, $col );
+			$type = FrmDb::get_var( 'frm_fields', $where, $col );
 		}
 
 		return $type;
@@ -531,7 +531,7 @@ 
 					continue;
 				}
 
-				$fields[ $result->id ] = $result;
+				$fields[$result->id] = $result;
 				$count ++;
 				if ( $limit == 1 ) {
 					$fields = $result;
@@ -577,7 +577,7 @@ 
 			$count  = 0;
 			foreach ( $results as $result ) {
 				$count ++;
-				$fields[ $result->id ] = $result;
+				$fields[$result->id] = $result;
 				if ( ! empty( $limit ) && $count >= $limit ) {
 					break;
 				}
@@ -646,7 +646,7 @@ 
 			}
 
 			if ( ! empty( $sub_fields ) ) {
-				$index        = $k + $index_offset;
+				$index = $k + $index_offset;
 				$index_offset += count( $sub_fields );
 				array_splice( $results, $index, 0, $sub_fields );
 			}
@@ -691,7 +691,7 @@ 
 		$query_type = ( $limit == ' LIMIT 1' || $limit == 1 ) ? 'row' : 'results';
 
 		if ( is_array( $where ) ) {
-			$args    = array(
+			$args = array(
 				'order_by' => $order_by,
 				'limit'    => $limit,
 			);
@@ -722,9 +722,9 @@ 
 				FrmDb::set_cache( $result->field_key, $result, 'frm_field' );
 
 				self::prepare_options( $result );
-				$results[ $r_key ]->field_options = $result->field_options;
-				$results[ $r_key ]->options       = $result->options;
-				$results[ $r_key ]->default_value = $result->default_value;
+				$results[$r_key]->field_options = $result->field_options;
+				$results[$r_key]->options       = $result->options;
+				$results[$r_key]->default_value = $result->default_value;
 
 				unset( $r_key, $result );
 			}
@@ -926,23 +926,23 @@ 
 	}
 
 	public static function is_option_true_in_array( $field, $option ) {
-		return isset( $field[ $option ] ) && $field[ $option ];
+		return isset( $field[$option] ) && $field[$option];
 	}
 
 	public static function is_option_true_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ];
+		return isset( $field->field_options[$option] ) && $field->field_options[$option];
 	}
 
 	public static function is_option_empty_in_array( $field, $option ) {
-		return ! isset( $field[ $option ] ) || empty( $field[ $option ] );
+		return ! isset( $field[$option] ) || empty( $field[$option] );
 	}
 
 	public static function is_option_empty_in_object( $field, $option ) {
-		return ! isset( $field->field_options[ $option ] ) || empty( $field->field_options[ $option ] );
+		return ! isset( $field->field_options[$option] ) || empty( $field->field_options[$option] );
 	}
 
 	public static function is_option_value_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ] != '';
+		return isset( $field->field_options[$option] ) && $field->field_options[$option] != '';
 	}
 
 	/**
@@ -960,10 +960,10 @@ 
 
 	public static function get_option_in_array( $field, $option ) {
 
-		if ( isset( $field[ $option ] ) ) {
-			$this_option = $field[ $option ];
-		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][ $option ] ) ) {
-			$this_option = $field['field_options'][ $option ];
+		if ( isset( $field[$option] ) ) {
+			$this_option = $field[$option];
+		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][$option] ) ) {
+			$this_option = $field['field_options'][$option];
 		} else {
 			$this_option = '';
 		}
@@ -972,7 +972,7 @@ 
 	}
 
 	public static function get_option_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) ? $field->field_options[ $option ] : '';
+		return isset( $field->field_options[$option] ) ? $field->field_options[$option] : '';
 	}
 
 	/**