Strategy11 / formidable-forms

classes/controllers/FrmAddonsController.php

Doc Comments +2 added lines, -1 removed lines

@@ -300,7 +300,6 @@ 
 	 * Get the action link for an addon that isn't active.
 	 *
 	 * @since 3.06.03
-	 * @param string $addon The plugin slug
 	 * @return array
 	 */
 	public static function install_link( $plugin ) {
@@ -403,6 +402,7 @@ 
 
 	/**
 	 * @since 3.04.02
+	 * @param string $link
 	 */
 	private static function prepare_addon_link( &$link ) {
 		$site_url = 'https://formidableforms.com/';
@@ -736,6 +736,7 @@ 
 	 * so let's install the plugin.
 	 *
 	 * @since 3.04.02
+	 * @return string
 	 */
 	private static function install_addon() {
 		require_once( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );

Spacing +13 added lines, -13 removed lines

@@ -63,7 +63,7 @@ 
 		} else {
 			foreach ( $addons as $k => $addon ) {
 				if ( empty( $addon['excerpt'] ) && $k !== 'error' ) {
-					unset( $addons[ $k ] );
+					unset( $addons[$k] );
 				}
 			}
 		}
@@ -222,16 +222,16 @@ 
 				continue;
 			}
 
-			$wp_plugin  = isset( $wp_plugins[ $folder ] ) ? $wp_plugins[ $folder ] : array();
+			$wp_plugin  = isset( $wp_plugins[$folder] ) ? $wp_plugins[$folder] : array();
 			$wp_version = isset( $wp_plugin['Version'] ) ? $wp_plugin['Version'] : '1.0';
 
 			if ( version_compare( $wp_version, $plugin->new_version, '<' ) ) {
 				$slug                           = explode( '/', $folder );
 				$plugin->slug                   = $slug[0];
-				$transient->response[ $folder ] = $plugin;
+				$transient->response[$folder] = $plugin;
 			}
 
-			$transient->checked[ $folder ] = $wp_version;
+			$transient->checked[$folder] = $wp_version;
 
 		}
 
@@ -254,7 +254,7 @@ 
 
 		$all_plugins = get_plugins();
 
-		return isset( $all_plugins[ $plugin ] );
+		return isset( $all_plugins[$plugin] );
 	}
 
 	/**
@@ -293,13 +293,13 @@ 
 			}
 
 			$download_id = isset( $plugin['id'] ) ? $plugin['id'] : 0;
-			if ( ! empty( $download_id ) && ! isset( $version_info[ $download_id ]['package'] ) ) {
+			if ( ! empty( $download_id ) && ! isset( $version_info[$download_id]['package'] ) ) {
 				// if this addon is using its own license, get the update url
 				$addon_info = $api->get_api_info();
 
-				$version_info[ $download_id ] = $addon_info[ $download_id ];
+				$version_info[$download_id] = $addon_info[$download_id];
 				if ( isset( $addon_info['error'] ) ) {
-					$version_info[ $download_id ]['error'] = array(
+					$version_info[$download_id]['error'] = array(
 						'message' => $addon_info['error']['message'],
 						'code'    => $addon_info['error']['code'],
 					);
@@ -318,7 +318,7 @@ 
 	 * @return array
 	 */
 	public static function install_link( $plugin ) {
-		$link    = array();
+		$link = array();
 		$addons = self::get_api_addons();
 		self::prepare_addons( $addons );
 
@@ -365,8 +365,8 @@ 
 					return $addon;
 				}
 			}
-		} elseif ( isset( $addons[ $download_id ] ) ) {
-			$plugin = $addons[ $download_id ];
+		} elseif ( isset( $addons[$download_id] ) ) {
+			$plugin = $addons[$download_id];
 		}
 
 		return $plugin;
@@ -417,7 +417,7 @@ 
 			self::prepare_addon_link( $addon['link'] );
 
 			self::set_addon_status( $addon );
-			$addons[ $id ] = $addon;
+			$addons[$id] = $addon;
 		}
 	}
 
@@ -435,7 +435,7 @@ 
 			'utm_medium'   => 'addons',
 			'utm_campaign' => 'liteplugin',
 		);
-		$link       = add_query_arg( $query_args, $link );
+		$link = add_query_arg( $query_args, $link );
 	}
 
 	/**

classes/models/FrmUsage.php

Doc Comments +2 added lines

@@ -147,6 +147,7 @@ 
 	 * Include the permissions settings for each capability.
 	 *
 	 * @since 3.06.04
+	 * @param FrmSettings $settings_list
 	 * @return array
 	 */
 	private function messages( $settings_list ) {
@@ -173,6 +174,7 @@ 
 	 * Include the permissions settings for each capability.
 	 *
 	 * @since 3.06.04
+	 * @param FrmSettings $settings_list
 	 * @return array
 	 */
 	private function permissions( $settings_list ) {

Spacing +7 added lines, -7 removed lines

@@ -139,7 +139,7 @@ 
 
 		foreach ( $pass_settings as $setting ) {
 			if ( isset( $settings_list->$setting ) ) {
-				$settings[ $setting ] = $this->maybe_json( $settings_list->$setting );
+				$settings[$setting] = $this->maybe_json( $settings_list->$setting );
 			}
 		}
 
@@ -171,7 +171,7 @@ 
 
 		$message_settings = array();
 		foreach ( $messages as $message ) {
-			$message_settings[ $message ] = $settings_list->$message;
+			$message_settings[$message] = $settings_list->$message;
 		}
 
 		return $message_settings;
@@ -189,7 +189,7 @@ 
 
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
 			if ( isset( $settings_list->$frm_role ) ) {
-				$permissions[ $frm_role ] = $settings_list->$frm_role;
+				$permissions[$frm_role] = $settings_list->$frm_role;
 			}
 		}
 
@@ -256,8 +256,8 @@ 
 			);
 
 			foreach ( $settings as $setting ) {
-				if ( isset( $form->options[ $setting ] ) ) {
-					$new_form[ $setting ] = $this->maybe_json( $form->options[ $setting ] );
+				if ( isset( $form->options[$setting] ) ) {
+					$new_form[$setting] = $this->maybe_json( $form->options[$setting] );
 				}
 			}
 
@@ -308,7 +308,7 @@ 
 	 * @return array
 	 */
 	private function fields() {
-		$args   = array(
+		$args = array(
 			'limit'    => 50,
 			'order_by' => 'id DESC',
 		);
@@ -316,7 +316,7 @@ 
 		$fields = FrmDb::get_results( 'frm_fields', array(), 'form_id, name, type, field_options', $args );
 		foreach ( $fields as $k => $field ) {
 			FrmAppHelper::unserialize_or_decode( $field->field_options );
-			$fields[ $k ]->field_options = json_encode( $field->field_options );
+			$fields[$k]->field_options = json_encode( $field->field_options );
 		}
 		return $fields;
 	}

classes/controllers/FrmXMLController.php

Doc Comments +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
 	 *
 	 * @since 3.06
 	 *
-	 * @param object $xml The values included in the XML.
+	 * @param SimpleXMLElement $xml The values included in the XML.
 	 */
 	private static function set_new_form_name( &$xml ) {
 		if ( ! isset( $xml->form ) ) {

Spacing +6 added lines, -6 removed lines

@@ -196,7 +196,7 @@ 
 		// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash
 		$file_type = sanitize_option( 'upload_path', $_FILES['frm_import_file']['name'] );
 		$file_type = strtolower( pathinfo( $file_type, PATHINFO_EXTENSION ) );
-		if ( 'xml' !== $file_type && isset( $export_format[ $file_type ] ) ) {
+		if ( 'xml' !== $file_type && isset( $export_format[$file_type] ) ) {
 			// allow other file types to be imported
 			do_action( 'frm_before_import_' . $file_type );
 
@@ -279,7 +279,7 @@ 
 		foreach ( $type as $tb_type ) {
 			$where = array();
 			$join  = '';
-			$table = $tables[ $tb_type ];
+			$table = $tables[$tb_type];
 
 			$select     = $table . '.id';
 			$query_vars = array();
@@ -294,7 +294,7 @@ 
 							$table . '.parent_form_id' => $args['ids'],
 						);
 					} else {
-						$where[ $table . '.status !' ] = 'draft';
+						$where[$table . '.status !'] = 'draft';
 					}
 					break;
 				case 'actions':
@@ -307,7 +307,7 @@ 
 				case 'items':
 					// $join = "INNER JOIN {$wpdb->prefix}frm_item_metas im ON ($table.id = im.item_id)";
 					if ( $args['ids'] ) {
-						$where[ $table . '.form_id' ] = $args['ids'];
+						$where[$table . '.form_id'] = $args['ids'];
 					}
 					break;
 				case 'styles':
@@ -348,7 +348,7 @@ 
 					}
 			}
 
-			$records[ $tb_type ] = FrmDb::get_col( $table . $join, $where, $select );
+			$records[$tb_type] = FrmDb::get_col( $table . $join, $where, $select );
 			unset( $tb_type );
 		}
 
@@ -493,7 +493,7 @@ 
 		$no_export_fields = FrmField::no_save_fields();
 		foreach ( $csv_fields as $k => $f ) {
 			if ( in_array( $f->type, $no_export_fields ) ) {
-				unset( $csv_fields[ $k ] );
+				unset( $csv_fields[$k] );
 			}
 		}
 

classes/helpers/FrmFieldsHelper.php

Doc Comments +4 added lines, -4 removed lines

@@ -109,7 +109,7 @@ 
 	 *
 	 * @param string $type
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public static function get_default_field_options( $type ) {
 		$field_type = FrmFieldFactory::get_field_type( $type );
@@ -212,7 +212,7 @@ 
 	 *
 	 * @param object $field
 	 *
-	 * @return array
+	 * @return stdClass
 	 */
 	private static function get_original_field( $field ) {
 		$original_type = FrmField::get_option( $field, 'original_type' );
@@ -240,7 +240,7 @@ 
 	 *
 	 * @param string $type
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public static function get_default_field( $type ) {
 		$field_type = FrmFieldFactory::get_field_type( $type );
@@ -265,7 +265,7 @@ 
 	 * @since 2.0
 	 *
 	 * @param $field
-	 * @param $error
+	 * @param string $error
 	 *
 	 * @return string
 	 */

Spacing +36 added lines, -36 removed lines

@@ -26,7 +26,7 @@ 
 			if ( in_array( $type, array( 'data', 'lookup' ) ) ) {
 				$values['field_options']['data_type'] = $setting;
 			} else {
-				$values['field_options'][ $setting ] = 1;
+				$values['field_options'][$setting] = 1;
 			}
 		}
 
@@ -133,10 +133,10 @@ 
 		}
 
 		foreach ( $defaults as $opt => $default ) {
-			$values[ $opt ] = isset( $field->field_options[ $opt ] ) ? $field->field_options[ $opt ] : $default;
+			$values[$opt] = isset( $field->field_options[$opt] ) ? $field->field_options[$opt] : $default;
 
 			if ( $check_post ) {
-				self::get_posted_field_setting( $opt . '_' . $field->id, $values[ $opt ] );
+				self::get_posted_field_setting( $opt . '_' . $field->id, $values[$opt] );
 			}
 
 			unset( $opt, $default );
@@ -180,19 +180,19 @@ 
 	 * @param mixed $value
 	 */
 	private static function get_posted_field_setting( $setting, &$value ) {
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) {
+		if ( ! isset( $_POST['field_options'][$setting] ) ) {
 			return;
 		}
 
 		if ( strpos( $setting, 'html' ) !== false ) {
 			// Strip slashes from HTML but not regex or script tags.
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-			$value = wp_unslash( $_POST['field_options'][ $setting ] );
+			$value = wp_unslash( $_POST['field_options'][$setting] );
 		} elseif ( strpos( $setting, 'format_' ) === 0 ) {
 			// TODO: Remove stripslashes on output, and use on input only.
-			$value = sanitize_text_field( $_POST['field_options'][ $setting ] ); // WPCS: sanitization ok.
+			$value = sanitize_text_field( $_POST['field_options'][$setting] ); // WPCS: sanitization ok.
 		} else {
-			$value = wp_kses_post( wp_unslash( $_POST['field_options'][ $setting ] ) );
+			$value = wp_kses_post( wp_unslash( $_POST['field_options'][$setting] ) );
 		}
 	}
 
@@ -264,7 +264,7 @@ 
 		$values['default_value'] = FrmAppHelper::maybe_json_encode( $field->default_value );
 
 		foreach ( array( 'name', 'description', 'type', 'field_order', 'field_options', 'required' ) as $col ) {
-			$values[ $col ] = $field->{$col};
+			$values[$col] = $field->{$col};
 		}
 	}
 
@@ -304,7 +304,7 @@ 
 		);
 
 		$msg = FrmField::get_option( $field, $error );
-		$msg = empty( $msg ) ? $defaults[ $error ]['part'] : $msg;
+		$msg = empty( $msg ) ? $defaults[$error]['part'] : $msg;
 		$msg = do_shortcode( $msg );
 
 		return $msg;
@@ -412,7 +412,7 @@ 
 		}
 
 		$base_name = 'default_value_' . $field['id'];
-		$html_id    = isset( $field['html_id'] ) ? $field['html_id'] : self::get_html_id( $field );
+		$html_id = isset( $field['html_id'] ) ? $field['html_id'] : self::get_html_id( $field );
 
 		$default_type = self::get_default_value_type( $field );
 
@@ -708,7 +708,7 @@ 
 				continue;
 			}
 
-			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][ $short_key ] );
+			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][$short_key] );
 			$tag  = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
 
 			$atts['entry'] = $entry;
@@ -717,7 +717,7 @@ 
 
 			if ( $replace_with !== null ) {
 				self::sanitize_embedded_shortcodes( compact( 'entry' ), $replace_with );
-				$content = str_replace( $shortcodes[0][ $short_key ], $replace_with, $content );
+				$content = str_replace( $shortcodes[0][$short_key], $replace_with, $content );
 			}
 
 			unset( $atts, $replace_with );
@@ -760,8 +760,8 @@ 
 
 		$dynamic_default = array( 'admin_email', 'siteurl', 'frmurl', 'sitename', 'get' );
 
-		if ( isset( $shortcode_values[ $atts['tag'] ] ) ) {
-			$replace_with = $shortcode_values[ $atts['tag'] ];
+		if ( isset( $shortcode_values[$atts['tag']] ) ) {
+			$replace_with = $shortcode_values[$atts['tag']];
 		} elseif ( in_array( $atts['tag'], $dynamic_default ) ) {
 			$replace_with = self::dynamic_default_values( $atts['tag'], $atts );
 		} elseif ( $clean_tag == 'user_agent' ) {
@@ -970,8 +970,8 @@ 
 			self::field_types_for_input( $single_input, $field_selection, $field_types );
 		} elseif ( in_array( $type, $multiple_input ) ) {
 			self::field_types_for_input( $multiple_input, $field_selection, $field_types );
-		} elseif ( isset( $field_selection[ $type ] ) ) {
-			$field_types[ $type ] = $field_selection[ $type ];
+		} elseif ( isset( $field_selection[$type] ) ) {
+			$field_types[$type] = $field_selection[$type];
 		}
 
 		$field_types = apply_filters( 'frm_switch_field_types', $field_types, compact( 'type' ) );
@@ -1004,7 +1004,7 @@ 
 
 	private static function field_types_for_input( $inputs, $fields, &$field_types ) {
 		foreach ( $inputs as $input ) {
-			$field_types[ $input ] = $fields[ $input ];
+			$field_types[$input] = $fields[$input];
 			unset( $input );
 		}
 	}
@@ -1036,7 +1036,7 @@ 
 			'parent'  => false,
 			'pointer' => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$opt_key   = $args['opt_key'];
 		$field     = $args['field'];
@@ -1053,22 +1053,22 @@ 
 		// Check posted vals before checking saved values
 
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) {
+		if ( $parent && isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ) {
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
-				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
+				$other_val = isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ) : '';
 			} else {
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) );
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) );
 			}
 
 			return $other_val;
 
-		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) {
+		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][$field['id']] ) ) {
 			// For normal fields
 
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
-				$other_val = isset( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ) : '';
+				$other_val = isset( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ) : '';
 			} else {
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ] ) );
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']] ) );
 			}
 
 			return $other_val;
@@ -1078,8 +1078,8 @@ 
 		if ( $field['type'] == 'checkbox' && is_array( $field['value'] ) ) {
 			// Check if there is an "other" val in saved value and make sure the
 			// "other" val is not equal to the Other checkbox option
-			if ( isset( $field['value'][ $opt_key ] ) && $field['options'][ $opt_key ] != $field['value'][ $opt_key ] ) {
-				$other_val = $field['value'][ $opt_key ];
+			if ( isset( $field['value'][$opt_key] ) && $field['options'][$opt_key] != $field['value'][$opt_key] ) {
+				$other_val = $field['value'][$opt_key];
 			}
 		} else {
 			/**
@@ -1091,8 +1091,8 @@ 
 				// Multi-select dropdowns - key is not preserved
 				if ( is_array( $field['value'] ) ) {
 					$o_key = array_search( $temp_val, $field['value'] );
-					if ( isset( $field['value'][ $o_key ] ) ) {
-						unset( $field['value'][ $o_key ], $o_key );
+					if ( isset( $field['value'][$o_key] ) ) {
+						unset( $field['value'][$o_key], $o_key );
 					}
 				} elseif ( $temp_val == $field['value'] ) {
 					// For radio and regular dropdowns
@@ -1279,7 +1279,7 @@ 
 		}
 		if ( is_array( $val ) ) {
 			foreach ( $val as $k => $v ) {
-				$val[ $k ] = str_replace( $replace, $replace_with, $v );
+				$val[$k] = str_replace( $replace, $replace_with, $v );
 				unset( $k, $v );
 			}
 		} else {
@@ -1589,19 +1589,19 @@ 
 	}
 
 	public static function get_bulk_prefilled_opts( array &$prepop ) {
-		$prepop[ __( 'Countries', 'formidable' ) ] = self::get_countries();
+		$prepop[__( 'Countries', 'formidable' )] = self::get_countries();
 
 		$states    = self::get_us_states();
 		$state_abv = array_keys( $states );
 		sort( $state_abv );
-		$prepop[ __( 'U.S. State Abbreviations', 'formidable' ) ] = $state_abv;
+		$prepop[__( 'U.S. State Abbreviations', 'formidable' )] = $state_abv;
 
 		$states = array_values( $states );
 		sort( $states );
-		$prepop[ __( 'U.S. States', 'formidable' ) ] = $states;
+		$prepop[__( 'U.S. States', 'formidable' )] = $states;
 		unset( $state_abv, $states );
 
-		$prepop[ __( 'Age', 'formidable' ) ] = array(
+		$prepop[__( 'Age', 'formidable' )] = array(
 			__( 'Under 18', 'formidable' ),
 			__( '18-24', 'formidable' ),
 			__( '25-34', 'formidable' ),
@@ -1612,7 +1612,7 @@ 
 			__( 'Prefer Not to Answer', 'formidable' ),
 		);
 
-		$prepop[ __( 'Satisfaction', 'formidable' ) ] = array(
+		$prepop[__( 'Satisfaction', 'formidable' )] = array(
 			__( 'Very Satisfied', 'formidable' ),
 			__( 'Satisfied', 'formidable' ),
 			__( 'Neutral', 'formidable' ),
@@ -1621,7 +1621,7 @@ 
 			__( 'N/A', 'formidable' ),
 		);
 
-		$prepop[ __( 'Importance', 'formidable' ) ] = array(
+		$prepop[__( 'Importance', 'formidable' )] = array(
 			__( 'Very Important', 'formidable' ),
 			__( 'Important', 'formidable' ),
 			__( 'Neutral', 'formidable' ),
@@ -1630,7 +1630,7 @@ 
 			__( 'N/A', 'formidable' ),
 		);
 
-		$prepop[ __( 'Agreement', 'formidable' ) ] = array(
+		$prepop[__( 'Agreement', 'formidable' )] = array(
 			__( 'Strongly Agree', 'formidable' ),
 			__( 'Agree', 'formidable' ),
 			__( 'Neutral', 'formidable' ),

classes/helpers/FrmFormsHelper.php

Doc Comments +4 added lines, -1 removed lines

@@ -658,6 +658,9 @@ 
 		$reset_fields = true;
 	}
 
+	/**
+	 * @return string
+	 */
 	public static function replace_shortcodes( $html, $form, $title = false, $description = false, $values = array() ) {
 		$codes = array(
 			'form_name'        => $title,
@@ -818,7 +821,7 @@ 
 	}
 
 	/**
-	 * @param object|string|boolean $form
+	 * @param string|boolean $form
 	 *
 	 * @return string
 	 */

Spacing +21 added lines, -21 removed lines

@@ -28,7 +28,7 @@ 
 			'class'        => '',
 			'inc_children' => 'exclude',
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		if ( ! $args['field_id'] ) {
 			$args['field_id'] = $field_name;
@@ -70,7 +70,7 @@ 
 	 */
 	public static function add_html_attr( $class, $param, &$add_html ) {
 		if ( ! empty( $class ) ) {
-			$add_html[ $param ] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
+			$add_html[$param] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
 		}
 	}
 
@@ -264,8 +264,8 @@ 
 			'description' => '',
 		);
 		foreach ( $defaults as $var => $default ) {
-			if ( ! isset( $values[ $var ] ) ) {
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			if ( ! isset( $values[$var] ) ) {
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 			}
 		}
 
@@ -280,8 +280,8 @@ 
 			'parent_form_id' => 0,
 		);
 		foreach ( $defaults as $var => $default ) {
-			if ( ! isset( $values[ $var ] ) ) {
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			if ( ! isset( $values[$var] ) ) {
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 			}
 		}
 		unset( $defaults );
@@ -318,16 +318,16 @@ 
 		$defaults = self::get_default_opts();
 		foreach ( $defaults as $var => $default ) {
 			if ( is_array( $default ) ) {
-				if ( ! isset( $values[ $var ] ) ) {
-					$values[ $var ] = ( $record && isset( $record->options[ $var ] ) ) ? $record->options[ $var ] : array();
+				if ( ! isset( $values[$var] ) ) {
+					$values[$var] = ( $record && isset( $record->options[$var] ) ) ? $record->options[$var] : array();
 				}
 
 				foreach ( $default as $k => $v ) {
-					$values[ $var ][ $k ] = ( $post_values && isset( $post_values[ $var ][ $k ] ) ) ? $post_values[ $var ][ $k ] : ( ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) ) ? $record->options[ $var ][ $k ] : $v );
+					$values[$var][$k] = ( $post_values && isset( $post_values[$var][$k] ) ) ? $post_values[$var][$k] : ( ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) ) ? $record->options[$var][$k] : $v );
 
 					if ( is_array( $v ) ) {
 						foreach ( $v as $k1 => $v1 ) {
-							$values[ $var ][ $k ][ $k1 ] = ( $post_values && isset( $post_values[ $var ][ $k ][ $k1 ] ) ) ? $post_values[ $var ][ $k ][ $k1 ] : ( ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) && isset( $record->options[ $var ][ $k ][ $k1 ] ) ) ? $record->options[ $var ][ $k ][ $k1 ] : $v1 );
+							$values[$var][$k][$k1] = ( $post_values && isset( $post_values[$var][$k][$k1] ) ) ? $post_values[$var][$k][$k1] : ( ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) && isset( $record->options[$var][$k][$k1] ) ) ? $record->options[$var][$k][$k1] : $v1 );
 							unset( $k1, $v1 );
 						}
 					}
@@ -335,7 +335,7 @@ 
 					unset( $k, $v );
 				}
 			} else {
-				$values[ $var ] = ( $post_values && isset( $post_values['options'][ $var ] ) ) ? $post_values['options'][ $var ] : ( ( $record && isset( $record->options[ $var ] ) ) ? $record->options[ $var ] : $default );
+				$values[$var] = ( $post_values && isset( $post_values['options'][$var] ) ) ? $post_values['options'][$var] : ( ( $record && isset( $record->options[$var] ) ) ? $record->options[$var] : $default );
 			}
 
 			unset( $var, $default );
@@ -373,7 +373,7 @@ 
 	public static function fill_form_options( &$options, $values ) {
 		$defaults = self::get_default_opts();
 		foreach ( $defaults as $var => $default ) {
-			$options[ $var ] = isset( $values['options'][ $var ] ) ? $values['options'][ $var ] : $default;
+			$options[$var] = isset( $values['options'][$var] ) ? $values['options'][$var] : $default;
 			unset( $var, $default );
 		}
 	}
@@ -529,7 +529,7 @@ 
 	public static function insert_opt_html( $args ) {
 		$class  = isset( $args['class'] ) ? $args['class'] : '';
 		$fields = FrmField::all_field_selection();
-		$field  = isset( $fields[ $args['type'] ] ) ? $fields[ $args['type'] ] : array();
+		$field  = isset( $fields[$args['type']] ) ? $fields[$args['type']] : array();
 
 		self::prepare_field_type( $field );
 
@@ -681,7 +681,7 @@ 
 			FrmField::update( $field->id, array( 'field_order' => $field->field_order + 2 ) );
 		}
 
-		$add_order    += 2;
+		$add_order += 2;
 		$open         = false;
 		$reset_fields = true;
 	}
@@ -1033,10 +1033,10 @@ 
 				$link .= ' onclick="return confirm(\'' . esc_attr( $link_details['confirm'] ) . '\')"';
 			}
 
-			$label = ( isset( $link_details[ $length ] ) ? $link_details[ $length ] : $link_details['label'] );
-			if ( $length == 'icon' && isset( $link_details[ $length ] ) ) {
+			$label = ( isset( $link_details[$length] ) ? $link_details[$length] : $link_details['label'] );
+			if ( $length == 'icon' && isset( $link_details[$length] ) ) {
 				$label = '<span class="' . $label . '" title="' . esc_attr( $link_details['label'] ) . '" aria-hidden="true"></span>';
-				$link  .= ' aria-label="' . esc_attr( $link_details['label'] ) . '"';
+				$link .= ' aria-label="' . esc_attr( $link_details['label'] ) . '"';
 			}
 
 			$link .= '>' . $label . '</a>';
@@ -1184,7 +1184,7 @@ 
 			$status = 'publish';
 		}
 
-		$name = $nice_names[ $status ];
+		$name = $nice_names[$status];
 
 		return $name;
 	}
@@ -1211,11 +1211,11 @@ 
 			$icon = $icons[''];
 		} elseif ( count( $categories ) === 1 ) {
 			$category = reset( $categories );
-			$icon     = $icons[ $category ];
+			$icon     = $icons[$category];
 		} else {
 			foreach ( $icons as $cat => $icon ) {
 				if ( ! in_array( $cat, $categories ) ) {
-					unset( $icons[ $cat ] );
+					unset( $icons[$cat] );
 				}
 			}
 			$icon = reset( $icons );
@@ -1304,7 +1304,7 @@ 
 
 		foreach ( $item['categories'] as $k => $category ) {
 			if ( in_array( $category, $plans ) ) {
-				unset( $item['categories'][ $k ] );
+				unset( $item['categories'][$k] );
 				return $category;
 			}
 		}

classes/helpers/FrmListHelper.php

Doc Comments +6 added lines

@@ -278,6 +278,9 @@ 
 		FrmAppHelper::show_search_box( compact( 'text', 'input_id' ) );
 	}
 
+	/**
+	 * @param string $param_name
+	 */
 	private function hidden_search_inputs( $param_name ) {
 		if ( ! empty( $_REQUEST[ $param_name ] ) ) {
 			$value = sanitize_text_field( wp_unslash( $_REQUEST[ $param_name ] ) );
@@ -418,6 +421,9 @@ 
 		return $action;
 	}
 
+	/**
+	 * @param string $action_name
+	 */
 	private static function get_bulk_action( $action_name ) {
 		$action       = false;
 		$action_param = self::get_param(

Spacing +12 added lines, -12 removed lines

@@ -230,8 +230,8 @@ 
 			return $this->get_pagenum();
 		}
 
-		if ( isset( $this->_pagination_args[ $key ] ) ) {
-			return $this->_pagination_args[ $key ];
+		if ( isset( $this->_pagination_args[$key] ) ) {
+			return $this->_pagination_args[$key];
 		}
 	}
 
@@ -279,8 +279,8 @@ 
 	}
 
 	private function hidden_search_inputs( $param_name ) {
-		if ( ! empty( $_REQUEST[ $param_name ] ) ) {
-			$value = sanitize_text_field( wp_unslash( $_REQUEST[ $param_name ] ) );
+		if ( ! empty( $_REQUEST[$param_name] ) ) {
+			$value = sanitize_text_field( wp_unslash( $_REQUEST[$param_name] ) );
 			echo '<input type="hidden" name="' . esc_attr( $param_name ) . '" value="' . esc_attr( $value ) . '" />';
 		}
 	}
@@ -324,7 +324,7 @@ 
 
 		echo "<ul class='subsubsub'>\n";
 		foreach ( $views as $class => $view ) {
-			$views[ $class ] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
+			$views[$class] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
 		}
 		echo implode( " |</li>\n", $views ) . "</li>\n"; // WPCS: XSS ok.
 		echo '</ul>';
@@ -682,7 +682,7 @@ 
 			'next'  => __( 'Next page', 'formidable' ),
 		);
 
-		return $labels[ $link ];
+		return $labels[$link];
 	}
 
 	private function current_url() {
@@ -775,7 +775,7 @@ 
 
 		// If the primary column doesn't exist fall back to the
 		// first non-checkbox column.
-		if ( ! isset( $columns[ $default ] ) ) {
+		if ( ! isset( $columns[$default] ) ) {
 			$default = self::get_default_primary_column_name();
 		}
 
@@ -789,7 +789,7 @@ 
 		 */
 		$column = apply_filters( 'list_table_primary_column', $default, $this->screen->id );
 
-		if ( empty( $column ) || ! isset( $columns[ $column ] ) ) {
+		if ( empty( $column ) || ! isset( $columns[$column] ) ) {
 			$column = $default;
 		}
 
@@ -811,7 +811,7 @@ 
 			// In 4.3, we added a fourth argument for primary column.
 			$column_headers = array( array(), array(), array(), $this->get_primary_column_name() );
 			foreach ( $this->_column_headers as $key => $value ) {
-				$column_headers[ $key ] = $value;
+				$column_headers[$key] = $value;
 			}
 
 			return $column_headers;
@@ -844,7 +844,7 @@ 
 				$data[1] = false;
 			}
 
-			$sortable[ $id ] = $data;
+			$sortable[$id] = $data;
 		}
 
 		$primary = $this->get_primary_column_name();
@@ -921,8 +921,8 @@ 
 				$class[] = 'column-primary';
 			}
 
-			if ( isset( $sortable[ $column_key ] ) ) {
-				list( $orderby, $desc_first ) = $sortable[ $column_key ];
+			if ( isset( $sortable[$column_key] ) ) {
+				list( $orderby, $desc_first ) = $sortable[$column_key];
 
 				if ( $current_orderby == $orderby ) {
 					$order   = 'asc' == $current_order ? 'desc' : 'asc';

classes/helpers/FrmStylesHelper.php

Doc Comments +2 added lines, -1 removed lines

@@ -182,7 +182,7 @@ 
 
 	/**
 	 * @since 2.0
-	 * @return The class for this icon
+	 * @return string class for this icon
 	 */
 	public static function icon_key_to_class( $key, $icon = '+', $type = 'arrow' ) {
 		if ( 'arrow' == $type && is_numeric( $key ) ) {
@@ -379,6 +379,7 @@ 
 
 	/**
 	 * @since 2.3
+	 * @param string $default
 	 */
 	private static function get_color_output( $default, &$color ) {
 		$color = trim( $color );

Spacing +9 added lines, -9 removed lines

@@ -191,7 +191,7 @@ 
 				'-' => 'down',
 				'+' => 'up',
 			);
-			$class = 'frm_arrow' . $arrow[ $icon ];
+			$class = 'frm_arrow' . $arrow[$icon];
 		} else {
 			//frm_minus1_icon
 			$key   = str_replace( 'p', '', $key );
@@ -199,7 +199,7 @@ 
 				'-' => 'minus',
 				'+' => 'plus',
 			);
-			$class = 'frm_' . $plus[ $icon ];
+			$class = 'frm_' . $plus[$icon];
 		}
 
 		if ( $key ) {
@@ -219,8 +219,8 @@ 
 		?>
 		<div class="btn-group" id="frm_<?php echo esc_attr( $name ); ?>_select">
 			<button class="multiselect dropdown-toggle btn btn-default" data-toggle="dropdown" type="button">
-				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[ $name ], '+', $type ) ); ?>
-				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[ $name ], '-', $type ) ); ?>
+				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[$name], '+', $type ) ); ?>
+				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[$name], '-', $type ) ); ?>
 				<b class="caret"></b>
 			</button>
 			<ul class="multiselect-container frm-dropdown-menu">
@@ -228,7 +228,7 @@ 
 					<li <?php echo ( $style->post_content['collapse_icon'] == $key ) ? 'class="active"' : ''; ?>>
 						<a href="javascript:void(0);">
 							<label>
-								<input type="radio" value="<?php echo esc_attr( $key ); ?>" name="<?php echo esc_attr( $frm_style->get_field_name( $name ) ); ?>" <?php checked( $style->post_content[ $name ], $key ); ?>/>
+								<input type="radio" value="<?php echo esc_attr( $key ); ?>" name="<?php echo esc_attr( $frm_style->get_field_name( $name ) ); ?>" <?php checked( $style->post_content[$name], $key ); ?>/>
 								<span>
 									<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $key, '+', $type ) ); ?>
 									<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $key, '-', $type ) ); ?>
@@ -313,14 +313,14 @@ 
 			$settings['style_class'] = 'frm_style_' . $style->post_name . '.';
 		}
 
-		$settings['style_class']   .= 'with_frm_style';
+		$settings['style_class'] .= 'with_frm_style';
 		$settings['font']          = stripslashes( $settings['font'] );
 		$settings['change_margin'] = self::description_margin_for_screensize( $settings['width'] );
 
 		$checkbox_opts = array( 'important_style', 'auto_width', 'submit_style', 'collapse_icon', 'center_form' );
 		foreach ( $checkbox_opts as $opt ) {
-			if ( ! isset( $settings[ $opt ] ) ) {
-				$settings[ $opt ] = 0;
+			if ( ! isset( $settings[$opt] ) ) {
+				$settings[$opt] = 0;
 			}
 		}
 
@@ -339,7 +339,7 @@ 
 				$css = '';
 			}
 			foreach ( $opts as $opt ) {
-				self::get_color_output( $css, $settings[ $opt ] );
+				self::get_color_output( $css, $settings[$opt] );
 			}
 		}
 	}

classes/models/FrmDb.php

Doc Comments +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
 	 * @since 2.02.05
 	 *
 	 * @param string $key
-	 * @param int|string $value
+	 * @param string $value
 	 * @param string $where
 	 */
 	private static function add_query_placeholder( $key, $value, &$where ) {

Spacing +15 added lines, -15 removed lines

@@ -61,7 +61,7 @@ 
 		}
 
 		foreach ( $args as $key => $value ) {
-			$where          .= empty( $where ) ? $base_where : $condition;
+			$where .= empty( $where ) ? $base_where : $condition;
 			$array_inc_null = ( ! is_numeric( $key ) && is_array( $value ) && in_array( null, $value ) );
 			if ( is_numeric( $key ) || $array_inc_null ) {
 				$where        .= ' ( ';
@@ -96,7 +96,7 @@ 
 
 		if ( strpos( $key, 'created_at' ) !== false || strpos( $key, 'updated_at' ) !== false ) {
 			$k        = explode( ' ', $key );
-			$where    .= ' DATE_FORMAT(' . reset( $k ) . ', %s) ' . str_replace( reset( $k ), '', $key );
+			$where .= ' DATE_FORMAT(' . reset( $k ) . ', %s) ' . str_replace( reset( $k ), '', $key );
 			$values[] = '%Y-%m-%d %H:%i:%s';
 		} else {
 			$where .= ' ' . $key;
@@ -116,12 +116,12 @@ 
 						$where .= ' OR ';
 					}
 					$start    = false;
-					$where    .= $key . ' %s';
+					$where .= $key . ' %s';
 					$values[] = '%' . self::esc_like( $v ) . '%';
 				}
 				$where .= ')';
 			} elseif ( ! empty( $value ) ) {
-				$where  .= ' in (' . self::prepare_array_values( $value, '%s' ) . ')';
+				$where .= ' in (' . self::prepare_array_values( $value, '%s' ) . ')';
 				$values = array_merge( $values, $value );
 			}
 		} elseif ( strpos( $lowercase_key, 'like' ) !== false ) {
@@ -141,7 +141,7 @@ 
 				$where .= 'like';
 			}
 
-			$where    .= ' %s';
+			$where .= ' %s';
 			$values[] = $start . self::esc_like( $value ) . $end;
 
 		} elseif ( $value === null ) {
@@ -306,8 +306,8 @@ 
 		);
 
 		$where_is = strtolower( $where_is );
-		if ( isset( $switch_to[ $where_is ] ) ) {
-			return ' ' . $switch_to[ $where_is ];
+		if ( isset( $switch_to[$where_is] ) ) {
+			return ' ' . $switch_to[$where_is];
 		}
 
 		// > and < need a little more work since we don't want them switched to >= and <=
@@ -360,13 +360,13 @@ 
 		$temp_args = $args;
 		foreach ( $temp_args as $k => $v ) {
 			if ( $v == '' ) {
-				unset( $args[ $k ] );
+				unset( $args[$k] );
 				continue;
 			}
 
 			$db_name = strtoupper( str_replace( '_', ' ', $k ) );
 			if ( strpos( $v, $db_name ) === false ) {
-				$args[ $k ] = $db_name . ' ' . $v;
+				$args[$k] = $db_name . ' ' . $v;
 			}
 		}
 
@@ -440,13 +440,13 @@ 
 	private static function esc_query_args( &$args ) {
 		foreach ( $args as $param => $value ) {
 			if ( $param == 'order_by' ) {
-				$args[ $param ] = self::esc_order( $value );
+				$args[$param] = self::esc_order( $value );
 			} elseif ( $param == 'limit' ) {
-				$args[ $param ] = self::esc_limit( $value );
+				$args[$param] = self::esc_limit( $value );
 			}
 
-			if ( $args[ $param ] == '' ) {
-				unset( $args[ $param ] );
+			if ( $args[$param] == '' ) {
+				unset( $args[$param] );
 			}
 		}
 	}
@@ -529,7 +529,7 @@ 
 		$limit = explode( ',', trim( $limit ) );
 		foreach ( $limit as $k => $l ) {
 			if ( is_numeric( $l ) ) {
-				$limit[ $k ] = $l;
+				$limit[$k] = $l;
 			}
 		}
 
@@ -665,7 +665,7 @@ 
 	 */
 	public static function add_key_to_group_cache( $key, $group ) {
 		$cached         = self::get_group_cached_keys( $group );
-		$cached[ $key ] = $key;
+		$cached[$key] = $key;
 		wp_cache_set( 'cached_keys', $cached, $group, 300 );
 	}
 

classes/models/FrmEntry.php

Doc Comments +4 added lines

@@ -202,6 +202,7 @@ 
 	 *
 	 * @param int $id
 	 * @param array $values
+	 * @param string $update_type
 	 *
 	 * @return boolean|int $query_results
 	 */
@@ -612,6 +613,9 @@ 
 		return $new_values;
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private static function get_entry_value( $values, $name, $default ) {
 		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
 	}

Spacing +15 added lines, -15 removed lines

@@ -76,7 +76,7 @@ 
 			$metas       = FrmEntryMeta::get_entry_meta_info( $entry_exist );
 			$field_metas = array();
 			foreach ( $metas as $meta ) {
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
+				$field_metas[$meta->field_id] = $meta->meta_value;
 			}
 
 			// If prev entry is empty and current entry is not, they are not duplicates
@@ -303,7 +303,7 @@ 
 		$query = "SELECT it.*, fr.name as form_name, fr.form_key as form_key FROM {$wpdb->prefix}frm_items it
                   LEFT OUTER JOIN {$wpdb->prefix}frm_forms fr ON it.form_id=fr.id WHERE ";
 
-		$query      .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s';
+		$query .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s';
 		$query_args = array( $id );
 		$query      = $wpdb->prepare( $query, $query_args ); // WPCS: unprepared SQL ok.
 
@@ -348,7 +348,7 @@ 
 	private static function prepare_entries( &$entries ) {
 		foreach ( $entries as $k => $entry ) {
 			self::prepare_entry( $entry );
-			$entries[ $k ] = $entry;
+			$entries[$k] = $entry;
 		}
 	}
 
@@ -373,20 +373,20 @@ 
 		foreach ( $metas as $meta_val ) {
 			if ( $meta_val->item_id == $entry->id ) {
 				FrmAppHelper::unserialize_or_decode( $meta_val->meta_value );
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
 				if ( $include_key ) {
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
 				}
 				continue;
 			}
 
 			// include sub entries in an array
-			if ( ! isset( $entry_metas[ $meta_val->field_id ] ) ) {
-				$entry->metas[ $meta_val->field_id ] = array();
+			if ( ! isset( $entry_metas[$meta_val->field_id] ) ) {
+				$entry->metas[$meta_val->field_id] = array();
 			}
 
 			FrmAppHelper::unserialize_or_decode( $meta_val->meta_value );
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
 
 			unset( $meta_val );
 		}
@@ -433,13 +433,13 @@ 
 
 			if ( $inc_form ) {
 				$fields = 'it.*, fr.name as form_name,fr.form_key as form_key';
-				$table  .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id ';
+				$table .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id ';
 			}
 
 			if ( preg_match( '/ meta_([0-9]+)/', $order_by, $order_matches ) ) {
 				// sort by a requested field
 				$field_id = (int) $order_matches[1];
-				$fields   .= ', (SELECT meta_value FROM ' . $wpdb->prefix . 'frm_item_metas WHERE field_id = ' . $field_id . ' AND item_id = it.id) as meta_' . $field_id;
+				$fields .= ', (SELECT meta_value FROM ' . $wpdb->prefix . 'frm_item_metas WHERE field_id = ' . $field_id . ' AND item_id = it.id) as meta_' . $field_id;
 				unset( $order_matches, $field_id );
 			}
 
@@ -479,16 +479,16 @@ 
 		}
 
 		foreach ( $metas as $m_key => $meta_val ) {
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
 				continue;
 			}
 
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
-				$entries[ $meta_val->item_id ]->metas = array();
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
+				$entries[$meta_val->item_id]->metas = array();
 			}
 
 			FrmAppHelper::unserialize_or_decode( $meta_val->meta_value );
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
 			unset( $m_key, $meta_val );
 		}
 
@@ -646,7 +646,7 @@ 
 	}
 
 	private static function get_entry_value( $values, $name, $default ) {
-		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
+		return isset( $values[$name] ) ? $values[$name] : $default;
 	}
 
 	/**