Completed
Pull Request — master (#1415)
by Stephanie
31s
created
stripe/controllers/FrmTransLiteActionsController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -391,8 +391,8 @@
 block discarded – undo
391 391
 			return $values;
392 392
 		}
393 393
 
394
-		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[ $field->id ] ) ) {
395
-			$values['value'] = $previous_entry->metas[ $field->id ];
394
+		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[$field->id] ) ) {
395
+			$values['value'] = $previous_entry->metas[$field->id];
396 396
 		}
397 397
 
398 398
 		$frm_vars['trans_filled'] = true;
Please login to merge, or discard this patch.
stripe/models/FrmStrpLiteAuth.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 			return $html;
40 40
 		}
41 41
 
42
-		$atts    = array(
42
+		$atts = array(
43 43
 			'fields' => FrmFieldsHelper::get_form_fields( $form_id ),
44 44
 			'entry'  => $details['entry'],
45 45
 		);
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
 		$atts['form']        = FrmForm::getOne( $atts['entry']->form_id );
162 162
 		$atts['entry_id']    = $atts['entry']->id;
163 163
 		$opt                 = 'success_action';
164
-		$atts['conf_method'] = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
164
+		$atts['conf_method'] = ! empty( $atts['form']->options[$opt] ) ? $atts['form']->options[$opt] : 'message';
165 165
 	}
166 166
 
167 167
 	/**
@@ -238,10 +238,10 @@  discard block
 block discarded – undo
238 238
 	 */
239 239
 	public static function get_payment_intents( $name ) {
240 240
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
241
-		if ( ! isset( $_POST[ $name ] ) ) {
241
+		if ( ! isset( $_POST[$name] ) ) {
242 242
 			return array();
243 243
 		}
244
-		$intents = $_POST[ $name ]; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
244
+		$intents = $_POST[$name]; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
245 245
 		FrmAppHelper::sanitize_value( 'sanitize_text_field', $intents );
246 246
 		return $intents;
247 247
 	}
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 		self::format_form_data( $form );
269 269
 
270 270
 		$form_id = absint( $form['form_id'] );
271
-		$intents = isset( $form[ 'frmintent' . $form_id ] ) ? $form[ 'frmintent' . $form_id ] : array();
271
+		$intents = isset( $form['frmintent' . $form_id] ) ? $form['frmintent' . $form_id] : array();
272 272
 
273 273
 		if ( empty( $intents ) ) {
274 274
 			wp_die();
@@ -278,8 +278,8 @@  discard block
 block discarded – undo
278 278
 			$intents = array( $intents );
279 279
 		} else {
280 280
 			foreach ( $intents as $k => $intent ) {
281
-				if ( is_array( $intent ) && isset( $intent[ $k ] ) ) {
282
-					$intents[ $k ] = $intent[ $k ];
281
+				if ( is_array( $intent ) && isset( $intent[$k] ) ) {
282
+					$intents[$k] = $intent[$k];
283 283
 				}
284 284
 			}
285 285
 		}
@@ -327,12 +327,12 @@  discard block
 block discarded – undo
327 327
 				continue;
328 328
 			}
329 329
 
330
-			$saved     = FrmStrpLiteAppHelper::call_stripe_helper_class( 'get_intent', $intent_id );
330
+			$saved = FrmStrpLiteAppHelper::call_stripe_helper_class( 'get_intent', $intent_id );
331 331
 			foreach ( $actions as $action ) {
332 332
 				if ( $saved->metadata->action != $action->ID ) {
333 333
 					continue;
334 334
 				}
335
-				$intents[ $k ] = array(
335
+				$intents[$k] = array(
336 336
 					'id'     => $intent,
337 337
 					'action' => $action->ID,
338 338
 				);
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 			if ( $k === 'item_meta' ) {
376 376
 				foreach ( $v as $f => $value ) {
377 377
 					FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
378
-					$entry->metas[ absint( $f ) ] = $value;
378
+					$entry->metas[absint( $f )] = $value;
379 379
 				}
380 380
 			} else {
381 381
 				FrmAppHelper::sanitize_value( 'wp_kses_post', $v );
@@ -399,14 +399,14 @@  discard block
 block discarded – undo
399 399
 
400 400
 		foreach ( $form as $input ) {
401 401
 			$key = $input['name'];
402
-			if ( isset( $formatted[ $key ] ) ) {
403
-				if ( is_array( $formatted[ $key ] ) ) {
404
-					$formatted[ $key ][] = $input['value'];
402
+			if ( isset( $formatted[$key] ) ) {
403
+				if ( is_array( $formatted[$key] ) ) {
404
+					$formatted[$key][] = $input['value'];
405 405
 				} else {
406
-					$formatted[ $key ] = array( $formatted[ $key ], $input['value'] );
406
+					$formatted[$key] = array( $formatted[$key], $input['value'] );
407 407
 				}
408 408
 			} else {
409
-				$formatted[ $key ] = $input['value'];
409
+				$formatted[$key] = $input['value'];
410 410
 			}
411 411
 		}
412 412
 
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
 
543 543
 		foreach ( $actions as $k => $action ) {
544 544
 			$amount = self::get_amount_before_submit( compact( 'action', 'form' ) );
545
-			$actions[ $k ]->post_content['amount'] = $amount;
545
+			$actions[$k]->post_content['amount'] = $amount;
546 546
 		}
547 547
 	}
548 548
 
Please login to merge, or discard this patch.
stripe/helpers/FrmStrpLiteUrlParamHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -23,10 +23,10 @@  discard block
 block discarded – undo
23 23
 	 * @return array|false
24 24
 	 */
25 25
 	public static function get_details_for_form( $form_id ) {
26
-		if ( ! isset( self::$details_by_form_id[ $form_id ] ) ) {
26
+		if ( ! isset( self::$details_by_form_id[$form_id] ) ) {
27 27
 			self::set_details_for_form( (int) $form_id );
28 28
 		}
29
-		return isset( self::$details_by_form_id[ $form_id ] ) ? self::$details_by_form_id[ $form_id ] : false;
29
+		return isset( self::$details_by_form_id[$form_id] ) ? self::$details_by_form_id[$form_id] : false;
30 30
 	}
31 31
 
32 32
 	/**
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 			return;
88 88
 		}
89 89
 
90
-		self::$details_by_form_id[ $form_id ] = array(
90
+		self::$details_by_form_id[$form_id] = array(
91 91
 			'entry'   => $entry,
92 92
 			'intent'  => $intent,
93 93
 			'payment' => $payment,
Please login to merge, or discard this patch.
classes/helpers/FrmEntriesListHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
 		if ( strpos( $orderby, 'meta' ) !== false ) {
72 72
 			$order_field_type = FrmField::get_type( str_replace( 'meta_', '', $orderby ) );
73
-			$orderby          .= in_array( $order_field_type, array( 'number', 'scale', 'star' ) ) ? '+0' : '';
73
+			$orderby .= in_array( $order_field_type, array( 'number', 'scale', 'star' ) ) ? '+0' : '';
74 74
 		}
75 75
 
76 76
 		$order = self::get_param(
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 			$form_ids              = $this->get_form_ids( $form_id );
117 117
 			$s_query['it.form_id'] = count( $form_ids ) > 1 ? $form_ids : $form_ids[0];
118 118
 		} else {
119
-			$s_query[]          = array(
119
+			$s_query[] = array(
120 120
 				'or'               => 1,
121 121
 				'parent_form_id'   => null,
122 122
 				'parent_form_id <' => 1,
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 
266 266
 		$r = "<tr id='item-action-{$item->id}'$style>";
267 267
 
268
-		list( $columns, $hidden, , $primary ) = $this->get_column_info();
268
+		list( $columns, $hidden,, $primary ) = $this->get_column_info();
269 269
 		$action_col                           = false;
270 270
 		$action_columns                       = $this->get_action_columns();
271 271
 
Please login to merge, or discard this patch.
classes/models/FrmDb.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 		}
65 65
 
66 66
 		foreach ( $args as $key => $value ) {
67
-			$where          .= empty( $where ) ? $base_where : $condition;
67
+			$where .= empty( $where ) ? $base_where : $condition;
68 68
 			$array_inc_null = ( ! is_numeric( $key ) && is_array( $value ) && in_array( null, $value ) );
69 69
 			if ( is_numeric( $key ) || $array_inc_null ) {
70 70
 				$where        .= ' ( ';
@@ -113,12 +113,12 @@  discard block
 block discarded – undo
113 113
 						$where .= ' OR ';
114 114
 					}
115 115
 					$start    = false;
116
-					$where    .= $key . ' %s';
116
+					$where .= $key . ' %s';
117 117
 					$values[] = '%' . self::esc_like( $v ) . '%';
118 118
 				}
119 119
 				$where .= ')';
120 120
 			} elseif ( ! empty( $value ) ) {
121
-				$where  .= ' in (' . self::prepare_array_values( $value, '%s' ) . ')';
121
+				$where .= ' in (' . self::prepare_array_values( $value, '%s' ) . ')';
122 122
 				$values = array_merge( $values, $value );
123 123
 			}
124 124
 		} elseif ( strpos( $lowercase_key, 'like' ) !== false ) {
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 				$where .= 'like';
139 139
 			}
140 140
 
141
-			$where    .= ' %s';
141
+			$where .= ' %s';
142 142
 			$values[] = $start . self::esc_like( $value ) . $end;
143 143
 
144 144
 		} elseif ( $value === null ) {
@@ -306,8 +306,8 @@  discard block
 block discarded – undo
306 306
 		);
307 307
 
308 308
 		$where_is = strtolower( $where_is );
309
-		if ( isset( $switch_to[ $where_is ] ) ) {
310
-			return ' ' . $switch_to[ $where_is ];
309
+		if ( isset( $switch_to[$where_is] ) ) {
310
+			return ' ' . $switch_to[$where_is];
311 311
 		}
312 312
 
313 313
 		// > and < need a little more work since we don't want them switched to >= and <=
@@ -371,13 +371,13 @@  discard block
 block discarded – undo
371 371
 		$temp_args = $args;
372 372
 		foreach ( $temp_args as $k => $v ) {
373 373
 			if ( $v == '' ) {
374
-				unset( $args[ $k ] );
374
+				unset( $args[$k] );
375 375
 				continue;
376 376
 			}
377 377
 
378 378
 			$db_name = strtoupper( str_replace( '_', ' ', $k ) );
379 379
 			if ( strpos( $v, $db_name ) === false ) {
380
-				$args[ $k ] = $db_name . ' ' . $v;
380
+				$args[$k] = $db_name . ' ' . $v;
381 381
 			}
382 382
 		}
383 383
 
@@ -451,13 +451,13 @@  discard block
 block discarded – undo
451 451
 	private static function esc_query_args( &$args ) {
452 452
 		foreach ( $args as $param => $value ) {
453 453
 			if ( $param == 'order_by' ) {
454
-				$args[ $param ] = self::esc_order( $value );
454
+				$args[$param] = self::esc_order( $value );
455 455
 			} elseif ( $param == 'limit' ) {
456
-				$args[ $param ] = self::esc_limit( $value );
456
+				$args[$param] = self::esc_limit( $value );
457 457
 			}
458 458
 
459
-			if ( $args[ $param ] == '' ) {
460
-				unset( $args[ $param ] );
459
+			if ( $args[$param] == '' ) {
460
+				unset( $args[$param] );
461 461
 			}
462 462
 		}
463 463
 	}
@@ -540,7 +540,7 @@  discard block
 block discarded – undo
540 540
 		$limit = explode( ',', trim( $limit ) );
541 541
 		foreach ( $limit as $k => $l ) {
542 542
 			if ( is_numeric( $l ) ) {
543
-				$limit[ $k ] = $l;
543
+				$limit[$k] = $l;
544 544
 			}
545 545
 		}
546 546
 
@@ -691,7 +691,7 @@  discard block
 block discarded – undo
691 691
 	 */
692 692
 	public static function add_key_to_group_cache( $key, $group ) {
693 693
 		$cached         = self::get_group_cached_keys( $group );
694
-		$cached[ $key ] = $key;
694
+		$cached[$key] = $key;
695 695
 		wp_cache_set( 'cached_keys', $cached, $group, 300 );
696 696
 	}
697 697
 
Please login to merge, or discard this patch.
classes/views/frm-fields/front-end/combo-field/combo-field.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 			$sub_field_class   = "frm_form_field form-field frm_form_subfield-{$name} {$sub_field['wrapper_classes']}";
42 42
 			$sub_field_desc    = FrmField::get_option( $field, $name . '_desc' );
43 43
 
44
-			if ( isset( $errors[ 'field' . $field_id . '-' . $name ] ) ) {
44
+			if ( isset( $errors['field' . $field_id . '-' . $name] ) ) {
45 45
 				$sub_field_class .= ' frm_blank_field';
46 46
 			}
47 47
 			?>
@@ -61,10 +61,10 @@  discard block
 block discarded – undo
61 61
 						<input
62 62
 							type="<?php echo esc_attr( $sub_field['type'] ); ?>"
63 63
 							id="<?php echo esc_attr( $html_id . '_' . $name ); ?>"
64
-							value="<?php echo esc_attr( isset( $field_value[ $name ] ) ? $field_value[ $name ] : '' ); ?>"
64
+							value="<?php echo esc_attr( isset( $field_value[$name] ) ? $field_value[$name] : '' ); ?>"
65 65
 							<?php
66
-							if ( ! empty( $field_value[ $name ] ) ) {
67
-								echo 'data-frmval="' . esc_attr( $field_value[ $name ] ) . '" ';
66
+							if ( ! empty( $field_value[$name] ) ) {
67
+								echo 'data-frmval="' . esc_attr( $field_value[$name] ) . '" ';
68 68
 							}
69 69
 							if ( empty( $args['remove_names'] ) ) {
70 70
 								echo 'name="' . esc_attr( $field_name ) . '[' . esc_attr( $name ) . ']" ';
@@ -81,9 +81,9 @@  discard block
 block discarded – undo
81 81
 				}
82 82
 
83 83
 				// Don't show individual field errors when there is a combo field error.
84
-				if ( ! empty( $errors ) && isset( $errors[ 'field' . $field_id . '-' . $name ] ) && ! isset( $errors[ 'field' . $field_id ] ) ) {
84
+				if ( ! empty( $errors ) && isset( $errors['field' . $field_id . '-' . $name] ) && ! isset( $errors['field' . $field_id] ) ) {
85 85
 					?>
86
-					<div class="frm_error" role="alert"><?php echo esc_html( $errors[ 'field' . $field_id . '-' . $name ] ); ?></div>
86
+					<div class="frm_error" role="alert"><?php echo esc_html( $errors['field' . $field_id . '-' . $name] ); ?></div>
87 87
 				<?php } ?>
88 88
 			</div>
89 89
 		<?php } ?>
Please login to merge, or discard this patch.
classes/views/frm-fields/front-end/checkbox-field.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,6 +83,6 @@
 block discarded – undo
83 83
 
84 84
 		?></div>
85 85
 <?php
86
-		++$option_index;
86
+		++ $option_index;
87 87
 	}
88 88
 }
Please login to merge, or discard this patch.
classes/helpers/FrmCurrencyHelper.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,10 +16,10 @@
 block discarded – undo
16 16
 	public static function get_currency( $currency ) {
17 17
 		$currency   = strtoupper( $currency );
18 18
 		$currencies = self::get_currencies();
19
-		if ( isset( $currencies[ $currency ] ) ) {
20
-			$currency = $currencies[ $currency ];
21
-		} elseif ( isset( $currencies[ strtolower( $currency ) ] ) ) {
22
-			$currency = $currencies[ strtolower( $currency ) ];
19
+		if ( isset( $currencies[$currency] ) ) {
20
+			$currency = $currencies[$currency];
21
+		} elseif ( isset( $currencies[strtolower( $currency )] ) ) {
22
+			$currency = $currencies[strtolower( $currency )];
23 23
 		} else {
24 24
 			$currency = $currencies['USD'];
25 25
 		}
Please login to merge, or discard this patch.
classes/controllers/FrmAddonsController.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 		} else {
102 102
 			foreach ( $addons as $k => $addon ) {
103 103
 				if ( empty( $addon['excerpt'] ) && $k !== 'error' ) {
104
-					unset( $addons[ $k ] );
104
+					unset( $addons[$k] );
105 105
 				}
106 106
 			}
107 107
 		}
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 
203 203
 		foreach ( $list as $k => $info ) {
204 204
 			$info['slug'] = $k;
205
-			$list[ $k ]   = array_merge( $defaults, $info );
205
+			$list[$k]   = array_merge( $defaults, $info );
206 206
 		}
207 207
 		return $list;
208 208
 	}
@@ -352,17 +352,17 @@  discard block
 block discarded – undo
352 352
 				continue;
353 353
 			}
354 354
 
355
-			$wp_plugin    = isset( $wp_plugins[ $folder ] ) ? $wp_plugins[ $folder ] : array();
355
+			$wp_plugin    = isset( $wp_plugins[$folder] ) ? $wp_plugins[$folder] : array();
356 356
 			$wp_version   = isset( $wp_plugin['Version'] ) ? $wp_plugin['Version'] : '1.0';
357 357
 			$plugin->slug = explode( '/', $folder )[0];
358 358
 
359 359
 			if ( version_compare( $wp_version, $plugin->new_version, '<' ) ) {
360
-				$transient->response[ $folder ] = $plugin;
360
+				$transient->response[$folder] = $plugin;
361 361
 			} else {
362
-				$transient->no_update[ $folder ] = $plugin;
362
+				$transient->no_update[$folder] = $plugin;
363 363
 			}
364 364
 
365
-			$transient->checked[ $folder ] = $wp_version;
365
+			$transient->checked[$folder] = $wp_version;
366 366
 
367 367
 		}
368 368
 
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
 	 */
396 396
 	protected static function is_installed( $plugin ) {
397 397
 		$all_plugins = self::get_plugins();
398
-		return isset( $all_plugins[ $plugin ] );
398
+		return isset( $all_plugins[$plugin] );
399 399
 	}
400 400
 
401 401
 	/**
@@ -434,13 +434,13 @@  discard block
 block discarded – undo
434 434
 			}
435 435
 
436 436
 			$download_id = isset( $plugin['id'] ) ? $plugin['id'] : 0;
437
-			if ( ! empty( $download_id ) && ! isset( $version_info[ $download_id ]['package'] ) ) {
437
+			if ( ! empty( $download_id ) && ! isset( $version_info[$download_id]['package'] ) ) {
438 438
 				// if this addon is using its own license, get the update url
439 439
 				$addon_info = $api->get_api_info();
440 440
 
441
-				$version_info[ $download_id ] = $addon_info[ $download_id ];
441
+				$version_info[$download_id] = $addon_info[$download_id];
442 442
 				if ( isset( $addon_info['error'] ) ) {
443
-					$version_info[ $download_id ]['error'] = array(
443
+					$version_info[$download_id]['error'] = array(
444 444
 						'message' => $addon_info['error']['message'],
445 445
 						'code'    => $addon_info['error']['code'],
446 446
 					);
@@ -539,8 +539,8 @@  discard block
 block discarded – undo
539 539
 					return $addon;
540 540
 				}
541 541
 			}
542
-		} elseif ( isset( $addons[ $download_id ] ) ) {
543
-			$plugin = $addons[ $download_id ];
542
+		} elseif ( isset( $addons[$download_id] ) ) {
543
+			$plugin = $addons[$download_id];
544 544
 		}
545 545
 
546 546
 		return $plugin;
@@ -604,7 +604,7 @@  discard block
 block discarded – undo
604 604
 			self::prepare_addon_link( $addon['link'] );
605 605
 
606 606
 			self::set_addon_status( $addon );
607
-			$addons[ $id ] = $addon;
607
+			$addons[$id] = $addon;
608 608
 		}
609 609
 	}
610 610
 
@@ -645,7 +645,7 @@  discard block
 block discarded – undo
645 645
 			'utm_medium'   => 'addons',
646 646
 			'utm_campaign' => 'liteplugin',
647 647
 		);
648
-		$link       = add_query_arg( $query_args, $link );
648
+		$link = add_query_arg( $query_args, $link );
649 649
 	}
650 650
 
651 651
 	/**
@@ -1373,7 +1373,7 @@  discard block
 block discarded – undo
1373 1373
 		$addons = $api->get_api_info();
1374 1374
 
1375 1375
 		if ( is_array( $addons ) && array_key_exists( $addon_id, $addons ) ) {
1376
-			$dates    = $addons[ $addon_id ];
1376
+			$dates    = $addons[$addon_id];
1377 1377
 			$requires = FrmFormsHelper::get_plan_required( $dates );
1378 1378
 		}
1379 1379
 
Please login to merge, or discard this patch.