Completed
Pull Request — master (#1839)
by Stephanie
45s
created
classes/helpers/FrmFieldGridHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -217,7 +217,7 @@
 block discarded – undo
217 217
 		}
218 218
 
219 219
 		if ( false !== $this->parent_li ) {
220
-			++$this->current_field_count;
220
+			++ $this->current_field_count;
221 221
 			$this->current_list_size += $this->active_field_size;
222 222
 			if ( 12 === $this->current_list_size ) {
223 223
 				$this->close_field_wrapper();
Please login to merge, or discard this patch.
classes/helpers/FrmEntriesListHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 			$form_ids              = $this->get_form_ids( $form_id );
135 135
 			$s_query['it.form_id'] = count( $form_ids ) > 1 ? $form_ids : $form_ids[0];
136 136
 		} else {
137
-			$s_query[]          = array(
137
+			$s_query[] = array(
138 138
 				'or'               => 1,
139 139
 				'parent_form_id'   => null,
140 140
 				'parent_form_id <' => 1,
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
 
284 284
 		$r = "<tr id='item-action-{$item->id}'$style>";
285 285
 
286
-		list( $columns, $hidden, , $primary ) = $this->get_column_info();
286
+		list( $columns, $hidden,, $primary ) = $this->get_column_info();
287 287
 		$action_col                           = false;
288 288
 		$action_columns                       = $this->get_action_columns();
289 289
 
Please login to merge, or discard this patch.
classes/helpers/FrmOnboardingWizardHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
 			'secondary-button-role'      => 'button',
101 101
 			'secondary-button-skip-step' => true,
102 102
 		);
103
-		$args     = wp_parse_args( $args, $defaults );
103
+		$args = wp_parse_args( $args, $defaults );
104 104
 
105 105
 		// Set the primary button attributes.
106 106
 		$primary_button_attributes          = array(
Please login to merge, or discard this patch.
classes/models/FrmEmailStats.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
 		// Build total for each currency.
151 151
 		foreach ( $payment_data['total'] as $currency => $amount ) {
152
-			$stats[ 'payments_total_' . $currency ] = array(
152
+			$stats['payments_total_' . $currency] = array(
153 153
 				// translators: currency name.
154 154
 				'label'   => sprintf( __( 'Total %s', 'formidable' ), strtoupper( $currency ) ),
155 155
 				'count'   => $amount,
@@ -171,23 +171,23 @@  discard block
 block discarded – undo
171 171
 
172 172
 			// Compare total for each currency.
173 173
 			foreach ( $payment_data['total'] as $currency => $amount ) {
174
-				if ( ! isset( $prev_payment_data['total'][ $currency ] ) ) {
175
-					$stats[ 'payments_total_' . $currency ]['compare'] = 1;
174
+				if ( ! isset( $prev_payment_data['total'][$currency] ) ) {
175
+					$stats['payments_total_' . $currency]['compare'] = 1;
176 176
 					continue;
177 177
 				}
178 178
 
179
-				$stats[ 'payments_total_' . $currency ]['compare'] = $this->get_compare_diff( $amount, $prev_payment_data['total'][ $currency ] );
180
-				unset( $prev_payment_data['total'][ $currency ] );
179
+				$stats['payments_total_' . $currency]['compare'] = $this->get_compare_diff( $amount, $prev_payment_data['total'][$currency] );
180
+				unset( $prev_payment_data['total'][$currency] );
181 181
 			}
182 182
 
183 183
 			// If prev month has more currencies.
184 184
 			foreach ( $prev_payment_data['total'] as $currency => $amount ) {
185
-				$stats[ 'payments_total_' . $currency ] = array(
185
+				$stats['payments_total_' . $currency] = array(
186 186
 					// translators: currency name.
187 187
 					'label'   => sprintf( __( 'Total %s', 'formidable' ), strtoupper( $currency ) ),
188 188
 					'count'   => 0,
189 189
 					'display' => $this->get_formatted_price( 0, $currency ),
190
-					'compare' => -1,
190
+					'compare' => - 1,
191 191
 				);
192 192
 			}
193 193
 		}//end if
Please login to merge, or discard this patch.
classes/models/FrmFieldFormHtml.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
 	 * @param array  $atts
45 45
 	 */
46 46
 	private function _set( $param, $atts ) {
47
-		if ( isset( $atts[ $param ] ) ) {
48
-			$this->{$param} = $atts[ $param ];
47
+		if ( isset( $atts[$param] ) ) {
48
+			$this->{$param} = $atts[$param];
49 49
 		}
50 50
 	}
51 51
 
@@ -89,8 +89,8 @@  discard block
 block discarded – undo
89 89
 
90 90
 		$exclude = array( 'field_obj', 'html' );
91 91
 		foreach ( $exclude as $ex ) {
92
-			if ( isset( $atts[ $ex ] ) ) {
93
-				unset( $this->pass_args[ $ex ] );
92
+			if ( isset( $atts[$ex] ) ) {
93
+				unset( $this->pass_args[$ex] );
94 94
 			}
95 95
 		}
96 96
 	}
@@ -102,8 +102,8 @@  discard block
 block discarded – undo
102 102
 	 * @param array $set
103 103
 	 */
104 104
 	private function set_from_field( $atts, $set ) {
105
-		if ( isset( $atts[ $set['param'] ] ) ) {
106
-			$this->{$set['param']} = $atts[ $set['param'] ];
105
+		if ( isset( $atts[$set['param']] ) ) {
106
+			$this->{$set['param']} = $atts[$set['param']];
107 107
 		} else {
108 108
 			$this->{$set['param']} = $this->field_obj->get_field_column( $set['default'] );
109 109
 		}
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	 */
231 231
 	private function replace_error_shortcode() {
232 232
 		$this->maybe_add_error_id();
233
-		$error = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? $this->pass_args['errors'][ 'field' . $this->field_id ] : false;
233
+		$error = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? $this->pass_args['errors']['field' . $this->field_id] : false;
234 234
 
235 235
 		if ( ! empty( $error ) && false === strpos( $this->html, 'role="alert"' ) && FrmAppHelper::should_include_alert_role_on_field_errors() ) {
236 236
 			$error_body = self::get_error_body( $this->html );
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 	 * @since 3.06.02
272 272
 	 */
273 273
 	private function maybe_add_error_id() {
274
-		if ( ! isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
274
+		if ( ! isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
275 275
 			return;
276 276
 		}
277 277
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 		preg_match_all( "/\[(input|deletelink)\b(.*?)(?:(\/))?\]/s", $this->html, $shortcodes, PREG_PATTERN_ORDER );
352 352
 
353 353
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
354
-			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
354
+			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
355 355
 			$tag            = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
356 356
 
357 357
 			$replace_with = '';
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
 				$replace_with = $this->replace_input_shortcode( $shortcode_atts );
363 363
 			}
364 364
 
365
-			$this->html = str_replace( $shortcodes[0][ $short_key ], $replace_with, $this->html );
365
+			$this->html = str_replace( $shortcodes[0][$short_key], $replace_with, $this->html );
366 366
 		}
367 367
 	}
368 368
 
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 	 */
385 385
 	private function prepare_input_shortcode_atts( $shortcode_atts ) {
386 386
 		if ( isset( $shortcode_atts['opt'] ) ) {
387
-			--$shortcode_atts['opt'];
387
+			-- $shortcode_atts['opt'];
388 388
 		}
389 389
 
390 390
 		$field_class = isset( $shortcode_atts['class'] ) ? $shortcode_atts['class'] : '';
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
 			unset( $shortcode_atts['class'] );
395 395
 		}
396 396
 
397
-		$shortcode_atts['aria-invalid'] = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? 'true' : 'false';
397
+		$shortcode_atts['aria-invalid'] = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? 'true' : 'false';
398 398
 
399 399
 		$this->field_obj->set_field_column( 'shortcodes', $shortcode_atts );
400 400
 
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
 	 */
447 447
 	private function get_field_div_classes() {
448 448
 		// Add error class
449
-		$classes = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? ' frm_blank_field' : '';
449
+		$classes = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? ' frm_blank_field' : '';
450 450
 
451 451
 		// Add label position class
452 452
 		$settings = $this->field_obj->display_field_settings();
Please login to merge, or discard this patch.
classes/models/FrmUsage.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 
145 145
 		foreach ( $pass_settings as $setting ) {
146 146
 			if ( isset( $settings_list->$setting ) ) {
147
-				$settings[ $setting ] = $this->maybe_json( $settings_list->$setting );
147
+				$settings[$setting] = $this->maybe_json( $settings_list->$setting );
148 148
 			}
149 149
 		}
150 150
 
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 
179 179
 		$message_settings = array();
180 180
 		foreach ( $messages as $message ) {
181
-			$message_settings[ $message ] = $settings_list->$message;
181
+			$message_settings[$message] = $settings_list->$message;
182 182
 		}
183 183
 
184 184
 		return $message_settings;
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
200 200
 			if ( isset( $settings_list->$frm_role ) ) {
201
-				$permissions[ $frm_role ] = $settings_list->$frm_role;
201
+				$permissions[$frm_role] = $settings_list->$frm_role;
202 202
 			}
203 203
 		}
204 204
 
@@ -268,8 +268,8 @@  discard block
 block discarded – undo
268 268
 			);
269 269
 
270 270
 			foreach ( $settings as $setting ) {
271
-				if ( isset( $form->options[ $setting ] ) ) {
272
-					$new_form[ $setting ] = $this->maybe_json( $form->options[ $setting ] );
271
+				if ( isset( $form->options[$setting] ) ) {
272
+					$new_form[$setting] = $this->maybe_json( $form->options[$setting] );
273 273
 				}
274 274
 			}
275 275
 
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 		$fields = FrmDb::get_results( 'frm_fields', array(), 'form_id, name, type, field_options', $args );
329 329
 		foreach ( $fields as $k => $field ) {
330 330
 			FrmAppHelper::unserialize_or_decode( $field->field_options );
331
-			$fields[ $k ]->field_options = json_encode( $field->field_options );
331
+			$fields[$k]->field_options = json_encode( $field->field_options );
332 332
 		}
333 333
 		return $fields;
334 334
 	}
Please login to merge, or discard this patch.
classes/models/FrmPluginSearch.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -80,20 +80,20 @@  discard block
 block discarded – undo
80 80
 			'name'              => sprintf(
81 81
 				/* translators: Formidable addon name */
82 82
 				esc_html_x( 'Formidable %s', 'Formidable Addon Name', 'formidable' ),
83
-				$addon_list[ $matching_addon ]['name']
83
+				$addon_list[$matching_addon]['name']
84 84
 			),
85
-			'addon'             => $addon_list[ $matching_addon ]['slug'],
86
-			'short_description' => $addon_list[ $matching_addon ]['excerpt'],
85
+			'addon'             => $addon_list[$matching_addon]['slug'],
86
+			'short_description' => $addon_list[$matching_addon]['excerpt'],
87 87
 			'slug'              => self::$slug,
88
-			'version'           => $addon_list[ $matching_addon ]['version'],
88
+			'version'           => $addon_list[$matching_addon]['version'],
89 89
 		);
90 90
 
91
-		if ( ! empty( $addon_list[ $matching_addon ]['external'] ) ) {
91
+		if ( ! empty( $addon_list[$matching_addon]['external'] ) ) {
92 92
 			unset( $overrides['name'] );
93 93
 		}
94 94
 
95 95
 		// Splice in the base addon data.
96
-		$inject = array_merge( $inject, $addon_list[ $matching_addon ], $overrides );
96
+		$inject = array_merge( $inject, $addon_list[$matching_addon], $overrides );
97 97
 
98 98
 		// Add it to the top of the list.
99 99
 		array_unshift( $result->plugins, $inject );
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
 		// Plugin installed, active, feature not enabled; prompt to enable.
309 309
 		if ( ! $is_active && $is_installed ) {
310 310
 			if ( current_user_can( 'activate_plugins' ) ) {
311
-				$activate_url             = add_query_arg(
311
+				$activate_url = add_query_arg(
312 312
 					array(
313 313
 						'action'   => 'activate',
314 314
 						'_wpnonce' => wp_create_nonce( 'activate-plugin_' . $plugin['plugin'] ),
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
 	 */
353 353
 	protected function is_installed( $plugin ) {
354 354
 		$all_plugins = FrmAppHelper::get_plugins();
355
-		return isset( $all_plugins[ $plugin ] );
355
+		return isset( $all_plugins[$plugin] );
356 356
 	}
357 357
 
358 358
 	/**
Please login to merge, or discard this patch.
classes/models/FrmFormTemplateApi.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
 		$templates    = $this->get_api_info();
96 96
 		$contact_form = 20872734;
97
-		return isset( $templates[ $contact_form ] ) && ! empty( $templates[ $contact_form ]['url'] );
97
+		return isset( $templates[$contact_form] ) && ! empty( $templates[$contact_form]['url'] );
98 98
 	}
99 99
 
100 100
 	/**
@@ -169,15 +169,15 @@  discard block
 block discarded – undo
169 169
 					continue;
170 170
 				}
171 171
 
172
-				$data['urlByKey'][ $template['key'] ] = $template['url'];
172
+				$data['urlByKey'][$template['key']] = $template['url'];
173 173
 			}
174 174
 
175
-			if ( ! isset( $data['urlByKey'][ $key ] ) ) {
175
+			if ( ! isset( $data['urlByKey'][$key] ) ) {
176 176
 				$error = new WP_Error( 400, 'We were unable to retrieve the template' );
177 177
 				wp_send_json_error( $error );
178 178
 			}
179 179
 
180
-			$data['url'] = $data['urlByKey'][ $key ];
180
+			$data['url'] = $data['urlByKey'][$key];
181 181
 		}//end if
182 182
 
183 183
 		wp_send_json_success( $data );
Please login to merge, or discard this patch.
classes/models/FrmEntry.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 			$metas       = FrmEntryMeta::get_entry_meta_info( $entry_exist );
81 81
 			$field_metas = array();
82 82
 			foreach ( $metas as $meta ) {
83
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
83
+				$field_metas[$meta->field_id] = $meta->meta_value;
84 84
 			}
85 85
 
86 86
 			$filtered_vals = array_filter( $values['item_meta'] );
@@ -136,10 +136,10 @@  discard block
 block discarded – undo
136 136
 		$reduced = array();
137 137
 		foreach ( $filter_vals as $field_id => $value ) {
138 138
 			$field                = FrmFieldFactory::get_field_object( $field_id );
139
-			$reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
140
-			$reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] );
141
-			if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) {
142
-				unset( $reduced[ $field_id ] );
139
+			$reduced[$field_id] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
140
+			$reduced[$field_id] = $field->set_value_before_save( $reduced[$field_id] );
141
+			if ( '' === $reduced[$field_id] || ( is_array( $reduced[$field_id] ) && 0 === count( $reduced[$field_id] ) ) ) {
142
+				unset( $reduced[$field_id] );
143 143
 			}
144 144
 		}
145 145
 		return $reduced;
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
 	private static function prepare_entries( &$entries ) {
402 402
 		foreach ( $entries as $k => $entry ) {
403 403
 			self::prepare_entry( $entry );
404
-			$entries[ $k ] = $entry;
404
+			$entries[$k] = $entry;
405 405
 		}
406 406
 	}
407 407
 
@@ -427,19 +427,19 @@  discard block
 block discarded – undo
427 427
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
428 428
 
429 429
 			if ( $meta_val->item_id == $entry->id ) {
430
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
430
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
431 431
 				if ( $include_key ) {
432
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
432
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
433 433
 				}
434 434
 				continue;
435 435
 			}
436 436
 
437 437
 			// include sub entries in an array
438
-			if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) {
439
-				$entry->metas[ $meta_val->field_id ] = array();
438
+			if ( ! isset( $entry->metas[$meta_val->field_id] ) ) {
439
+				$entry->metas[$meta_val->field_id] = array();
440 440
 			}
441 441
 
442
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
442
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
443 443
 
444 444
 			unset( $meta_val );
445 445
 		}
@@ -534,16 +534,16 @@  discard block
 block discarded – undo
534 534
 		}
535 535
 
536 536
 		foreach ( $metas as $m_key => $meta_val ) {
537
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
537
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
538 538
 				continue;
539 539
 			}
540 540
 
541
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
542
-				$entries[ $meta_val->item_id ]->metas = array();
541
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
542
+				$entries[$meta_val->item_id]->metas = array();
543 543
 			}
544 544
 
545 545
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
546
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
546
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
547 547
 			unset( $m_key, $meta_val );
548 548
 		}
549 549
 
@@ -725,7 +725,7 @@  discard block
 block discarded – undo
725 725
 	}
726 726
 
727 727
 	private static function get_entry_value( $values, $name, $default ) {
728
-		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
728
+		return isset( $values[$name] ) ? $values[$name] : $default;
729 729
 	}
730 730
 
731 731
 	/**
@@ -910,7 +910,7 @@  discard block
 block discarded – undo
910 910
 	private static function maybe_add_captcha_meta( $form_id, $entry_id ) {
911 911
 		global $frm_vars;
912 912
 		if ( array_key_exists( 'captcha_scores', $frm_vars ) && array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) {
913
-			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] );
913
+			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][$form_id] );
914 914
 			FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) );
915 915
 		}
916 916
 	}
Please login to merge, or discard this patch.