Completed
Pull Request — master (#1839)
by Stephanie
45s
created
stripe/controllers/FrmStrpLiteSettingsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 			 * @param object $frm_settings
25 25
 			 * @return void
26 26
 			 */
27
-			function ( $frm_settings ) {
27
+			function( $frm_settings ) {
28 28
 				$stripe_settings = FrmStrpLiteAppHelper::get_settings()->settings;
29 29
 				require FrmStrpLiteAppHelper::plugin_path() . '/views/settings/messages.php';
30 30
 			}
Please login to merge, or discard this patch.
stripe/controllers/FrmStrpLiteAppController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -148,13 +148,13 @@  discard block
 block discarded – undo
148 148
 
149 149
 		$is_setup_intent = 0 === strpos( $intent->id, 'seti_' );
150 150
 		if ( $is_setup_intent ) {
151
-			$errors[ 'field' . $cc_field_id ] = is_object( $intent->last_setup_error ) ? $intent->last_setup_error->message : '';
151
+			$errors['field' . $cc_field_id] = is_object( $intent->last_setup_error ) ? $intent->last_setup_error->message : '';
152 152
 		} else {
153
-			$errors[ 'field' . $cc_field_id ] = is_object( $intent->last_payment_error ) ? $intent->last_payment_error->message : '';
153
+			$errors['field' . $cc_field_id] = is_object( $intent->last_payment_error ) ? $intent->last_payment_error->message : '';
154 154
 		}
155 155
 
156
-		if ( ! $errors[ 'field' . $cc_field_id ] ) {
157
-			$errors[ 'field' . $cc_field_id ] = 'Payment was not successfully processed.';
156
+		if ( ! $errors['field' . $cc_field_id] ) {
157
+			$errors['field' . $cc_field_id] = 'Payment was not successfully processed.';
158 158
 		}
159 159
 
160 160
 		global $frm_vars;
@@ -182,10 +182,10 @@  discard block
 block discarded – undo
182 182
 		$save_draft = ! empty( $form->options['save_draft'] );
183 183
 
184 184
 		global $frm_vars;
185
-		$frm_vars['created_entries'][ $form_id ]['errors'] = $errors;
185
+		$frm_vars['created_entries'][$form_id]['errors'] = $errors;
186 186
 
187 187
 		// Set to true to get FrmProFieldsHelper::get_page_with_error() run.
188
-		$_POST[ 'frm_page_order_' . $form_id ] = true;
188
+		$_POST['frm_page_order_' . $form_id] = true;
189 189
 
190 190
 		if ( ! $save_draft ) {
191 191
 			// If draft saving is not on, delete the entry.
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
 		}
195 195
 
196 196
 		// If draft saving is on, load the draft entry.
197
-		$frm_vars['created_entries'][ $form_id ]['entry_id'] = $entry_id;
197
+		$frm_vars['created_entries'][$form_id]['entry_id'] = $entry_id;
198 198
 		add_action(
199 199
 			'frm_filter_final_form',
200 200
 			/**
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 			 * @param int    $entry_id
205 205
 			 * @return string
206 206
 			 */
207
-			function ( $html ) use ( $entry_id ) {
207
+			function( $html ) use ( $entry_id ) {
208 208
 				global $wpdb;
209 209
 				$wpdb->update( $wpdb->prefix . 'frm_items', array( 'is_draft' => 1 ), array( 'id' => $entry_id ) );
210 210
 				return $html;
Please login to merge, or discard this patch.
stripe/controllers/FrmTransLiteActionsController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -393,8 +393,8 @@  discard block
 block discarded – undo
393 393
 			return $values;
394 394
 		}
395 395
 
396
-		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[ $field->id ] ) ) {
397
-			$values['value'] = $previous_entry->metas[ $field->id ];
396
+		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[$field->id] ) ) {
397
+			$values['value'] = $previous_entry->metas[$field->id];
398 398
 		}
399 399
 
400 400
 		$frm_vars['trans_filled'] = true;
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
 			 * @param Closure    $destroy_callback
430 430
 			 * @return void
431 431
 			 */
432
-			function () use ( $entry_id, &$destroy_callback ) {
432
+			function() use ( $entry_id, &$destroy_callback ) {
433 433
 				FrmEntry::destroy( $entry_id );
434 434
 				// Only call this once.
435 435
 				remove_action( 'frm_entry_form', $destroy_callback );
Please login to merge, or discard this patch.
formidable.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@
 block discarded – undo
148 148
 
149 149
 register_deactivation_hook(
150 150
 	__FILE__,
151
-	function () {
151
+	function() {
152 152
 		if ( ! class_exists( 'FrmCronController', false ) ) {
153 153
 			require_once __DIR__ . '/classes/controllers/FrmCronController.php';
154 154
 		}
Please login to merge, or discard this patch.
stripe/controllers/FrmStrpLiteLinkController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
 			'form'  => $entry->form_id,
150 150
 			'value' => $action->post_content['description'],
151 151
 		);
152
-		$new_values     = array( 'description' => FrmTransLiteAppHelper::process_shortcodes( $shortcode_atts ) );
152
+		$new_values = array( 'description' => FrmTransLiteAppHelper::process_shortcodes( $shortcode_atts ) );
153 153
 		FrmStrpLiteAppHelper::call_stripe_helper_class( 'update_intent', $intent->id, $new_values );
154 154
 	}
155 155
 
Please login to merge, or discard this patch.
stripe/models/FrmStrpLiteAuth.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 		$intent_is_processing = 'processing' === $intent->status;
58 58
 		if ( $intent_is_processing ) {
59 59
 			// Append an additional processing message to the end of the success message.
60
-			$filter = function ( $message ) {
60
+			$filter = function( $message ) {
61 61
 				$stripe_settings = FrmStrpLiteAppHelper::get_settings();
62 62
 				$message        .= '<p>' . esc_html( $stripe_settings->settings->processing_message ) . '</p>';
63 63
 				return $message;
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
 		$atts['form']        = FrmForm::getOne( $atts['entry']->form_id );
162 162
 		$atts['entry_id']    = $atts['entry']->id;
163 163
 		$opt                 = 'success_action';
164
-		$atts['conf_method'] = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
164
+		$atts['conf_method'] = ! empty( $atts['form']->options[$opt] ) ? $atts['form']->options[$opt] : 'message';
165 165
 	}
166 166
 
167 167
 	/**
@@ -238,10 +238,10 @@  discard block
 block discarded – undo
238 238
 	 */
239 239
 	public static function get_payment_intents( $name ) {
240 240
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
241
-		if ( ! isset( $_POST[ $name ] ) ) {
241
+		if ( ! isset( $_POST[$name] ) ) {
242 242
 			return array();
243 243
 		}
244
-		$intents = $_POST[ $name ]; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
244
+		$intents = $_POST[$name]; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
245 245
 		FrmAppHelper::sanitize_value( 'sanitize_text_field', $intents );
246 246
 		return $intents;
247 247
 	}
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 		self::format_form_data( $form );
269 269
 
270 270
 		$form_id = absint( $form['form_id'] );
271
-		$intents = isset( $form[ 'frmintent' . $form_id ] ) ? $form[ 'frmintent' . $form_id ] : array();
271
+		$intents = isset( $form['frmintent' . $form_id] ) ? $form['frmintent' . $form_id] : array();
272 272
 
273 273
 		if ( empty( $intents ) ) {
274 274
 			wp_die();
@@ -278,8 +278,8 @@  discard block
 block discarded – undo
278 278
 			$intents = array( $intents );
279 279
 		} else {
280 280
 			foreach ( $intents as $k => $intent ) {
281
-				if ( is_array( $intent ) && isset( $intent[ $k ] ) ) {
282
-					$intents[ $k ] = $intent[ $k ];
281
+				if ( is_array( $intent ) && isset( $intent[$k] ) ) {
282
+					$intents[$k] = $intent[$k];
283 283
 				}
284 284
 			}
285 285
 		}
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
 				if ( $saved->metadata->action != $action->ID ) {
333 333
 					continue;
334 334
 				}
335
-				$intents[ $k ] = array(
335
+				$intents[$k] = array(
336 336
 					'id'     => $intent,
337 337
 					'action' => $action->ID,
338 338
 				);
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 			if ( $k === 'item_meta' ) {
376 376
 				foreach ( $v as $f => $value ) {
377 377
 					FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
378
-					$entry->metas[ absint( $f ) ] = $value;
378
+					$entry->metas[absint( $f )] = $value;
379 379
 				}
380 380
 			} else {
381 381
 				FrmAppHelper::sanitize_value( 'wp_kses_post', $v );
@@ -399,14 +399,14 @@  discard block
 block discarded – undo
399 399
 
400 400
 		foreach ( $form as $input ) {
401 401
 			$key = $input['name'];
402
-			if ( isset( $formatted[ $key ] ) ) {
403
-				if ( is_array( $formatted[ $key ] ) ) {
404
-					$formatted[ $key ][] = $input['value'];
402
+			if ( isset( $formatted[$key] ) ) {
403
+				if ( is_array( $formatted[$key] ) ) {
404
+					$formatted[$key][] = $input['value'];
405 405
 				} else {
406
-					$formatted[ $key ] = array( $formatted[ $key ], $input['value'] );
406
+					$formatted[$key] = array( $formatted[$key], $input['value'] );
407 407
 				}
408 408
 			} else {
409
-				$formatted[ $key ] = $input['value'];
409
+				$formatted[$key] = $input['value'];
410 410
 			}
411 411
 		}
412 412
 
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
549 549
 
550 550
 		foreach ( $actions as $k => $action ) {
551 551
 			$amount                                = self::get_amount_before_submit( compact( 'action', 'form' ) );
552
-			$actions[ $k ]->post_content['amount'] = $amount;
552
+			$actions[$k]->post_content['amount'] = $amount;
553 553
 		}
554 554
 	}
555 555
 
Please login to merge, or discard this patch.
classes/views/solutions/_import.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 				$info['url'] = $xml;
12 12
 			}
13 13
 
14
-			$disabled = isset( $imported[ $info['form'] ] ) ? ' disabled' : '';
14
+			$disabled = isset( $imported[$info['form']] ) ? ' disabled' : '';
15 15
 			$url      = isset( $info['url'] ) ? $info['url'] : '';
16 16
 			$value    = $importing === 'form' ? $info['form'] : $info['key'];
17 17
 			if ( ! isset( $info['img'] ) ) {
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 				continue;
22 22
 			}
23 23
 
24
-			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[ $info['form'] ] ) );
24
+			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[$info['form']] ) );
25 25
 			?>
26 26
 			<div class="frm_radio radio-inline radio frm_image_option<?php echo esc_attr( $importing === 'view' ? ' show_sub_opt show_' . $info['form'] : '' ); ?>" style="<?php echo esc_attr( $hide_views ? 'display:none' : '' ); ?>">
27 27
 				<?php if ( $importing === 'form' ) { ?>
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 					<?php } ?>
42 42
 					/>
43 43
 					<div class="frm_image_option_container frm_label_with_image">
44
-						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) );  // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
44
+						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
45 45
 						<span class="frm_text_label_for_image">
46 46
 							<?php
47 47
 							if ( ! empty( $disabled ) ) {
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 							}
55 55
 
56 56
 							if ( $importing === 'form' && $disabled ) {
57
-								echo FrmAppHelper::kses( FrmFormsHelper::edit_form_link( $imported[ $info['form'] ] ), array( 'a' ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
57
+								echo FrmAppHelper::kses( FrmFormsHelper::edit_form_link( $imported[$info['form']] ), array( 'a' ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
58 58
 							} else {
59 59
 								echo esc_html( $info['name'] );
60 60
 							}
Please login to merge, or discard this patch.
classes/views/frm-forms/form.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 			$grid_helper     = new FrmFieldGridHelper();
53 53
 			$values['count'] = 0;
54 54
 			foreach ( $values['fields'] as $field ) {
55
-				++$values['count'];
55
+				++ $values['count'];
56 56
 				$grid_helper->set_field( $field );
57 57
 				$grid_helper->maybe_begin_field_wrapper();
58 58
 				FrmFieldsController::load_single_field( $field, $values );
Please login to merge, or discard this patch.
classes/controllers/FrmFormTemplatesController.php 1 patch
Spacing   +12 added lines, -14 removed lines patch added patch discarded remove patch
@@ -328,11 +328,11 @@  discard block
 block discarded – undo
328 328
 
329 329
 		// Perform add or remove operation.
330 330
 		if ( 'add' === $operation ) {
331
-			self::$favorite_templates[ $key ][] = $template_id;
331
+			self::$favorite_templates[$key][] = $template_id;
332 332
 		} elseif ( 'remove' === $operation ) {
333
-			$position = array_search( $template_id, self::$favorite_templates[ $key ], true );
333
+			$position = array_search( $template_id, self::$favorite_templates[$key], true );
334 334
 			if ( $position !== false ) {
335
-				unset( self::$favorite_templates[ $key ][ $position ] );
335
+				unset( self::$favorite_templates[$key][$position] );
336 336
 			}
337 337
 		}
338 338
 
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
 		foreach ( self::$templates as $key => &$template ) {
462 462
 			// Skip the template if the categories are not set.
463 463
 			if ( ! isset( $template['categories'] ) ) {
464
-				unset( self::$templates[ $key ] );
464
+				unset( self::$templates[$key] );
465 465
 				continue;
466 466
 			}
467 467
 
@@ -475,14 +475,12 @@  discard block
 block discarded – undo
475 475
 				// Add the slug to the new array.
476 476
 				$template['category_slugs'][] = $category_slug;
477 477
 
478
-				if ( ! isset( self::$categories[ $category_slug ] ) ) {
479
-					self::$categories[ $category_slug ] = array(
478
+				if ( ! isset( self::$categories[$category_slug] ) ) {
479
+					self::$categories[$category_slug] = array(
480 480
 						'name'  => $category,
481 481
 						'count' => 0,
482 482
 					);
483
-				}
484
-
485
-				++self::$categories[ $category_slug ]['count'];
483
+				} ++self::$categories[$category_slug]['count'];
486 484
 			}
487 485
 
488 486
 			// Mark the template as favorite if it's in the favorite templates list.
@@ -497,7 +495,7 @@  discard block
 block discarded – undo
497 495
 		$redundant_cats = array_merge( array( 'PayPal', 'Stripe', 'Twilio' ), FrmFormsHelper::ignore_template_categories() );
498 496
 		foreach ( $redundant_cats as $redundant_cat ) {
499 497
 			$category_slug = sanitize_title( $redundant_cat );
500
-			unset( self::$categories[ $category_slug ] );
498
+			unset( self::$categories[$category_slug] );
501 499
 		}
502 500
 
503 501
 		// Sort the categories by keys alphabetically.
@@ -522,7 +520,7 @@  discard block
 block discarded – undo
522 520
 				'count' => 0,
523 521
 			);
524 522
 		}
525
-		$special_categories['all-templates']  = array(
523
+		$special_categories['all-templates'] = array(
526 524
 			'name'  => __( 'All Templates', 'formidable' ),
527 525
 			'count' => self::get_template_count(),
528 526
 		);
@@ -550,9 +548,9 @@  discard block
 block discarded – undo
550 548
 	 */
551 549
 	private static function assign_featured_templates() {
552 550
 		foreach ( self::FEATURED_TEMPLATES_KEYS as $key ) {
553
-			if ( isset( self::$templates[ $key ] ) ) {
554
-				self::$templates[ $key ]['is_featured'] = true;
555
-				self::$featured_templates[]             = self::$templates[ $key ];
551
+			if ( isset( self::$templates[$key] ) ) {
552
+				self::$templates[$key]['is_featured'] = true;
553
+				self::$featured_templates[]             = self::$templates[$key];
556 554
 			}
557 555
 		}
558 556
 	}
Please login to merge, or discard this patch.