Completed
Pull Request — master (#1839)
by Stephanie
45s
created
classes/models/fields/FrmFieldNumber.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
 		// Validate the number format.
64 64
 		if ( ! is_numeric( $args['value'] ) && '' !== $args['value'] ) {
65
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
65
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
66 66
 		}
67 67
 
68 68
 		// validate number settings
@@ -73,9 +73,9 @@  discard block
 block discarded – undo
73 73
 			if ( $maxnum !== '' && $minnum !== '' ) {
74 74
 				$value = (float) $args['value'];
75 75
 				if ( $value < $minnum ) {
76
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a higher number', 'formidable' );
76
+					$errors['field' . $args['id']] = __( 'Please select a higher number', 'formidable' );
77 77
 				} elseif ( $value > $maxnum ) {
78
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a lower number', 'formidable' );
78
+					$errors['field' . $args['id']] = __( 'Please select a lower number', 'formidable' );
79 79
 				}
80 80
 			}
81 81
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	 * @return void
97 97
 	 */
98 98
 	private function validate_step( &$errors, $args ) {
99
-		if ( isset( $errors[ 'field' . $args['id'] ] ) ) {
99
+		if ( isset( $errors['field' . $args['id']] ) ) {
100 100
 			// Don't need to check if value is invalid before.
101 101
 			return;
102 102
 		}
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 			return;
112 112
 		}
113 113
 
114
-		$errors[ 'field' . $args['id'] ] = sprintf(
114
+		$errors['field' . $args['id']] = sprintf(
115 115
 			// Translators: %1$s: the first nearest value; %2$s: the second nearest value.
116 116
 			__( 'Please enter a valid value. Two nearest valid values are %1$s and %2$s', 'formidable' ),
117 117
 			floatval( $result[0] ),
Please login to merge, or discard this patch.
stripe/helpers/FrmTransLiteListHelper.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 			'payments'      => $frm_payment->get_count(),
124 124
 			'subscriptions' => $frm_sub->get_count(),
125 125
 		);
126
-		$type        = FrmAppHelper::get_simple_request(
126
+		$type = FrmAppHelper::get_simple_request(
127 127
 			array(
128 128
 				'param'   => 'trans_type',
129 129
 				'type'    => 'request',
@@ -138,10 +138,10 @@  discard block
 block discarded – undo
138 138
 				$class = '';
139 139
 			}
140 140
 
141
-			if ( $counts[ $status ] || 'published' === $status ) {
142
-				$links[ $status ] = '<a href="' . esc_url( '?page=formidable-payments&trans_type=' . $status ) . '" ' . $class . '>'
141
+			if ( $counts[$status] || 'published' === $status ) {
142
+				$links[$status] = '<a href="' . esc_url( '?page=formidable-payments&trans_type=' . $status ) . '" ' . $class . '>'
143 143
 					// translators: %1$s: Transaction type (Payments or Subscriptions), %2$s: Span start tag, %3$s: Count, %3$s: Span close tag.
144
-					. sprintf( esc_html__( '%1$s %2$s(%3$s)%4$s', 'formidable' ), esc_html( $name ), '<span class="count">', number_format_i18n( $counts[ $status ] ), '</span>' )
144
+					. sprintf( esc_html__( '%1$s %2$s(%3$s)%4$s', 'formidable' ), esc_html( $name ), '<span class="count">', number_format_i18n( $counts[$status] ), '</span>' )
145 145
 					. '</a>';
146 146
 			}
147 147
 
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
 			echo '<tr id="payment-' . esc_attr( $item->id ) . '" ';
219 219
 
220 220
 			$is_alternate = 0 === $alt % 2;
221
-			++$alt;
221
+			++ $alt;
222 222
 
223 223
 			if ( $is_alternate ) {
224 224
 				echo 'class="alternate"';
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
 
310 310
 		$form_ids = array();
311 311
 		foreach ( $forms as $form ) {
312
-			$form_ids[ $form->id ] = $form;
312
+			$form_ids[$form->id] = $form;
313 313
 			unset( $form );
314 314
 		}
315 315
 
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
 			'href'  => esc_url( $link ),
361 361
 			'title' => __( 'View', 'formidable' ),
362 362
 		);
363
-		$link        = '<a ' . FrmAppHelper::array_to_html_params( $link_params ) . '>'
363
+		$link = '<a ' . FrmAppHelper::array_to_html_params( $link_params ) . '>'
364 364
 			. $item->{$field}
365 365
 			. '</a>';
366 366
 
@@ -415,8 +415,8 @@  discard block
 block discarded – undo
415 415
 	 * @return mixed
416 416
 	 */
417 417
 	private function get_form_id_column( $item, $atts ) {
418
-		if ( isset( $atts['form_ids'][ $item->item_id ] ) ) {
419
-			$form_link = FrmFormsHelper::edit_form_link( $atts['form_ids'][ $item->item_id ]->form_id );
418
+		if ( isset( $atts['form_ids'][$item->item_id] ) ) {
419
+			$form_link = FrmFormsHelper::edit_form_link( $atts['form_ids'][$item->item_id]->form_id );
420 420
 			return $form_link;
421 421
 		}
422 422
 
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
 	 */
492 492
 	private function get_processing_tooltip() {
493 493
 		return FrmAppHelper::clip(
494
-			function () {
494
+			function() {
495 495
 				FrmAppHelper::tooltip_icon( __( 'This payment method may take between 4-5 business days to process.', 'formidable' ) );
496 496
 			}
497 497
 		);
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldText.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 		$max_length = intval( FrmField::get_option( $this->field, 'max' ) );
43 43
 
44 44
 		if ( $max_length && FrmAppHelper::mb_function( array( 'mb_strlen', 'strlen' ), array( $args['value'] ) ) > $max_length ) {
45
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
45
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
46 46
 		}
47 47
 
48 48
 		return $errors;
Please login to merge, or discard this patch.
classes/models/FrmEntryMeta.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
 		global $wpdb;
60 60
 
61
-		$values               = array(
61
+		$values = array(
62 62
 			'item_id'  => $entry_id,
63 63
 			'field_id' => $field_id,
64 64
 		);
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 				}
139 139
 			}
140 140
 
141
-			$values_indexed_by_field_id[ $field_id ] = $meta_value;
141
+			$values_indexed_by_field_id[$field_id] = $meta_value;
142 142
 
143 143
 			self::get_value_to_save( compact( 'field', 'field_id', 'entry_id' ), $meta_value );
144 144
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
 				if ( ( is_array( $meta_value ) && empty( $meta_value ) ) || ( ! is_array( $meta_value ) && trim( $meta_value ) == '' ) ) {
148 148
 					// Remove blank fields.
149
-					unset( $values_indexed_by_field_id[ $field_id ] );
149
+					unset( $values_indexed_by_field_id[$field_id] );
150 150
 				} else {
151 151
 					// if value exists, then update it
152 152
 					self::update_entry_meta( $entry_id, $field_id, '', $meta_value );
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 */
225 225
 	public static function get_meta_value( $entry, $field_id ) {
226 226
 		if ( isset( $entry->metas ) ) {
227
-			return isset( $entry->metas[ $field_id ] ) ? $entry->metas[ $field_id ] : false;
227
+			return isset( $entry->metas[$field_id] ) ? $entry->metas[$field_id] : false;
228 228
 		}
229 229
 		return self::get_entry_meta_by_field( $entry->id, $field_id );
230 230
 	}
@@ -241,8 +241,8 @@  discard block
 block discarded – undo
241 241
 			$cached   = FrmDb::check_cache( $entry_id, 'frm_entry' );
242 242
 		}
243 243
 
244
-		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[ $field_id ] ) ) {
245
-			$result = $cached->metas[ $field_id ];
244
+		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[$field_id] ) ) {
245
+			$result = $cached->metas[$field_id];
246 246
 
247 247
 			return wp_unslash( $result );
248 248
 		}
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
 			'stripslashes' => true,
274 274
 			'is_draft'     => false,
275 275
 		);
276
-		$args     = wp_parse_args( $args, $defaults );
276
+		$args = wp_parse_args( $args, $defaults );
277 277
 
278 278
 		$query = array();
279 279
 		self::meta_field_query( $field_id, $order, $limit, $args, $query );
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
 
289 289
 		foreach ( $values as $k => $v ) {
290 290
 			FrmAppHelper::unserialize_or_decode( $v );
291
-			$values[ $k ] = $v;
291
+			$values[$k] = $v;
292 292
 			unset( $k, $v );
293 293
 		}
294 294
 
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 
356 356
 		foreach ( $results as $k => $result ) {
357 357
 			FrmAppHelper::unserialize_or_decode( $result->meta_value );
358
-			$results[ $k ]->meta_value = wp_unslash( $result->meta_value );
358
+			$results[$k]->meta_value = wp_unslash( $result->meta_value );
359 359
 			unset( $k, $result );
360 360
 		}
361 361
 
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
 			'user_id'  => '',
369 369
 			'group_by' => '',
370 370
 		);
371
-		$args     = wp_parse_args( $args, $defaults );
371
+		$args = wp_parse_args( $args, $defaults );
372 372
 
373 373
 		$query = array();
374 374
 		self::get_ids_query( $where, $order_by, $limit, $unique, $args, $query );
@@ -435,7 +435,7 @@  discard block
 block discarded – undo
435 435
 			} elseif ( false !== strpos( $args['is_draft'], ',' ) ) {
436 436
 				$is_draft = array_reduce(
437 437
 					explode( ',', $args['is_draft'] ),
438
-					function ( $total, $current ) {
438
+					function( $total, $current ) {
439 439
 						if ( is_numeric( $current ) ) {
440 440
 							$total[] = absint( $current );
441 441
 						}
Please login to merge, or discard this patch.
classes/views/styles/components/templates/slider.php 1 patch
Braces   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -137,10 +137,13 @@  discard block
 block discarded – undo
137 137
 		</div>
138 138
 		<input type="hidden" <?php echo esc_attr( $field_name ); ?> value="<?php echo esc_attr( $field_value ); ?>" id="<?php echo esc_attr( $component['id'] ); ?>" />
139 139
 	</div>
140
-<?php else : ?>
140
+<?php else {
141
+	: ?>
141 142
 	<div>
142 143
 		<?php if ( empty( $component['independent_fields'] ) ) : ?>
143
-			<div class="frm-slider-component <?php echo esc_attr( $component_class ); ?>" <?php echo esc_attr( $component_attr ); ?> data-display-sliders="top,bottom" data-type="vertical" data-max-value="<?php echo (int) $component['max_value']; ?>">
144
+			<div class="frm-slider-component <?php echo esc_attr( $component_class );
145
+}
146
+?>" <?php echo esc_attr( $component_attr ); ?> data-display-sliders="top,bottom" data-type="vertical" data-max-value="<?php echo (int) $component['max_value']; ?>">
144 147
 				<div class="frm-flex-justify">
145 148
 					<div class="frm-slider-container">
146 149
 						<?php if ( ! empty( $component['icon'] ) ) : ?>
@@ -165,8 +168,11 @@  discard block
 block discarded – undo
165 168
 					</div>
166 169
 				</div>
167 170
 			</div>
168
-		<?php else : ?>
169
-			<div class="<?php echo esc_attr( $component_class ); ?>" <?php echo esc_attr( $component_attr ); ?> >
171
+		<?php else {
172
+	: ?>
173
+			<div class="<?php echo esc_attr( $component_class );
174
+}
175
+?>" <?php echo esc_attr( $component_attr ); ?> >
170 176
 				<div class="frm-slider-component frm-group-sliders frm-has-independent-fields" data-display-sliders="top,bottom" data-max-value="<?php echo (int) $component['max_value']; ?>">
171 177
 					<div class="frm-flex-justify">
172 178
 						<div class="frm-slider-container">
Please login to merge, or discard this patch.
stripe/models/FrmTransLiteAction.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -181,7 +181,7 @@
 block discarded – undo
181 181
 				$has_field  = true;
182 182
 				$key_exists = array_key_exists( $field_atts['name'], $form_atts['form_action']->post_content );
183 183
 				?>
184
-				<option value="<?php echo esc_attr( $field->id ); ?>" <?php selected( $key_exists ? $form_atts['form_action']->post_content[ $field_atts['name'] ] : 0, $field->id ); ?>>
184
+				<option value="<?php echo esc_attr( $field->id ); ?>" <?php selected( $key_exists ? $form_atts['form_action']->post_content[$field_atts['name']] : 0, $field->id ); ?>>
185 185
 					<?php
186 186
 					echo esc_attr( FrmAppHelper::truncate( $field->name, 50, 1 ) );
187 187
 
Please login to merge, or discard this patch.
classes/controllers/FrmAppController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1340,15 +1340,15 @@
 block discarded – undo
1340 1340
 		global $wp_filter;
1341 1341
 
1342 1342
 		foreach ( $actions as $action ) {
1343
-			if ( empty( $wp_filter[ $action ]->callbacks ) ) {
1343
+			if ( empty( $wp_filter[$action]->callbacks ) ) {
1344 1344
 				continue;
1345 1345
 			}
1346
-			foreach ( $wp_filter[ $action ]->callbacks as $priority => $callbacks ) {
1346
+			foreach ( $wp_filter[$action]->callbacks as $priority => $callbacks ) {
1347 1347
 				foreach ( $callbacks as $callback_name => $callback ) {
1348 1348
 					if ( self::is_our_callback_string( $callback_name ) || self::is_our_callback_array( $callback ) ) {
1349 1349
 						continue;
1350 1350
 					}
1351
-					unset( $wp_filter[ $action ]->callbacks[ $priority ][ $callback_name ] );
1351
+					unset( $wp_filter[$action]->callbacks[$priority][$callback_name] );
1352 1352
 				}
1353 1353
 			}
1354 1354
 		}
Please login to merge, or discard this patch.
classes/views/frm-settings/license_box.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 	die( 'You are not allowed to call this page directly.' );
4 4
 }
5 5
 
6
-$button_upgrade_link      = FrmAppHelper::admin_upgrade_link(
6
+$button_upgrade_link = FrmAppHelper::admin_upgrade_link(
7 7
 	array(
8 8
 		'medium'  => 'settings-license',
9 9
 		'content' => 'global-settings-license-box-get-formidable-button',
Please login to merge, or discard this patch.