Strategy11 / formidable-forms

classes/models/FrmEntryValidate.php

Braces +2 added lines, -1 removed lines

@@ -145,7 +145,8 @@
 
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
 			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
-		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		} elseif ( ! isset( $_POST['item_name'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			self::maybe_add_item_name( $value, $posted_field );
 		}
 

Spacing +29 added lines, -29 removed lines

@@ -27,7 +27,7 @@ 
 			return $errors;
 		}
 
-		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) {
+		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values['frm_submit_entry_' . $values['form_id']] ) || ! wp_verify_nonce( $values['frm_submit_entry_' . $values['form_id']], 'frm_submit_entry_nonce' ) ) ) {
 			$frm_settings   = FrmAppHelper::get_settings();
 			$errors['form'] = $frm_settings->admin_permission;
 		}
@@ -130,7 +130,7 @@ 
 		$args = wp_parse_args( $args, $defaults );
 
 		if ( empty( $args['parent_field_id'] ) ) {
-			$value = isset( $values['item_meta'][ $args['id'] ] ) ? $values['item_meta'][ $args['id'] ] : '';
+			$value = isset( $values['item_meta'][$args['id']] ) ? $values['item_meta'][$args['id']] : '';
 		} else {
 			// value is from a nested form
 			$value = $values;
@@ -151,7 +151,7 @@ 
 		}
 
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
 		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			self::maybe_add_item_name( $value, $posted_field );
 		}
@@ -233,7 +233,7 @@ 
 			$pattern = self::phone_format( $field );
 
 			if ( ! preg_match( $pattern, $value ) ) {
-				$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
+				$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
 			}
 		}
 	}
@@ -346,7 +346,7 @@ 
 	 */
 	private static function form_is_in_progress( $values ) {
 		return FrmAppHelper::pro_is_installed() &&
-			( isset( $values[ 'frm_page_order_' . $values['form_id'] ] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
+			( isset( $values['frm_page_order_' . $values['form_id']] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
 			FrmField::get_all_types_in_form( $values['form_id'], 'break' );
 	}
 
@@ -592,9 +592,9 @@ 
 			foreach ( $datas['missing_keys'] as $key_index => $key ) {
 				$found = self::is_akismet_guest_info_value( $key, $value, $field_id, $datas['name_field_ids'], $values );
 				if ( $found ) {
-					$datas[ $key ]             = $value;
+					$datas[$key]             = $value;
 					$datas['frm_duplicated'][] = $field_id;
-					unset( $datas['missing_keys'][ $key_index ] );
+					unset( $datas['missing_keys'][$key_index] );
 				}
 			}
 		}//end foreach
@@ -637,11 +637,11 @@ 
 					if ( 'Name' !== $field->name ) {
 						continue;
 					}
-					if ( isset( $fields[ $index + 1 ] ) && 'Last' === $fields[ $index + 1 ]->name ) {
-						if ( empty( $values[ absint( $fields[ $index + 1 ]->id ) ] ) ) {
+					if ( isset( $fields[$index + 1] ) && 'Last' === $fields[$index + 1]->name ) {
+						if ( empty( $values[absint( $fields[$index + 1]->id )] ) ) {
 							continue;
 						}
-						$value .= ' ' . $values[ $fields[ $index + 1 ]->id ];
+						$value .= ' ' . $values[$fields[$index + 1]->id];
 						return true;
 					}
 				}
@@ -660,13 +660,13 @@ 
 	 */
 	private static function get_name_text_fields( $form_id ) {
 		$name_text_fields_is_initialized = is_array( self::$name_text_fields );
-		if ( $name_text_fields_is_initialized && isset( self::$name_text_fields[ $form_id ] ) ) {
-			return self::$name_text_fields[ $form_id ];
+		if ( $name_text_fields_is_initialized && isset( self::$name_text_fields[$form_id] ) ) {
+			return self::$name_text_fields[$form_id];
 		}
 		if ( ! $name_text_fields_is_initialized ) {
 			self::$name_text_fields = array();
 		}
-		self::$name_text_fields[ $form_id ] = FrmDb::get_results(
+		self::$name_text_fields[$form_id] = FrmDb::get_results(
 			'frm_fields',
 			array(
 				'form_id' => $form_id,
@@ -677,7 +677,7 @@ 
 			array( 'order_by' => 'field_order ASC' )
 		);
 
-		return self::$name_text_fields[ $form_id ];
+		return self::$name_text_fields[$form_id];
 	}
 
 	private static function add_server_values_to_akismet( &$datas ) {
@@ -686,7 +686,7 @@ 
 
 			// Send any potentially useful $_SERVER vars, but avoid sending junk we don't need.
 			if ( $include_value ) {
-				$datas[ $key ] = $value;
+				$datas[$key] = $value;
 			}
 			unset( $key, $value );
 		}
@@ -703,10 +703,10 @@ 
 	private static function add_comment_content_to_akismet( &$datas, $values ) {
 		if ( isset( $datas['frm_duplicated'] ) ) {
 			foreach ( $datas['frm_duplicated'] as $index ) {
-				if ( isset( $values['item_meta'][ $index ] ) ) {
-					unset( $values['item_meta'][ $index ] );
+				if ( isset( $values['item_meta'][$index] ) ) {
+					unset( $values['item_meta'][$index] );
 				} else {
-					unset( $values[ $index ] );
+					unset( $values[$index] );
 				}
 			}
 			unset( $datas['frm_duplicated'] );
@@ -725,14 +725,14 @@ 
 	private static function skip_adding_values_to_akismet( &$values ) {
 		$skipped_fields = self::get_akismet_skipped_field_ids( $values );
 		foreach ( $skipped_fields as $skipped_field ) {
-			if ( ! isset( $values['item_meta'][ $skipped_field->id ] ) ) {
+			if ( ! isset( $values['item_meta'][$skipped_field->id] ) ) {
 				continue;
 			}
 
 			if ( self::should_really_skip_field( $skipped_field, $values ) ) {
-				unset( $values['item_meta'][ $skipped_field->id ] );
-				if ( isset( $values['item_meta']['other'][ $skipped_field->id ] ) ) {
-					unset( $values['item_meta']['other'][ $skipped_field->id ] );
+				unset( $values['item_meta'][$skipped_field->id] );
+				if ( isset( $values['item_meta']['other'][$skipped_field->id] ) ) {
+					unset( $values['item_meta']['other'][$skipped_field->id] );
 				}
 			}
 		}
@@ -768,14 +768,14 @@ 
 		}
 
 		// If a choice field has Other option, but Other is not selected.
-		if ( empty( $values['item_meta']['other'][ $field_data->id ] ) ) {
+		if ( empty( $values['item_meta']['other'][$field_data->id] ) ) {
 			return true;
 		}
 
 		// Check if submitted value is same as one of field option.
 		foreach ( $field_data->options as $option ) {
 			$option_value = ! is_array( $option ) ? $option : ( isset( $option['value'] ) ? $option['value'] : '' );
-			if ( $values['item_meta']['other'][ $field_data->id ] === $option_value ) {
+			if ( $values['item_meta']['other'][$field_data->id] === $option_value ) {
 				return true;
 			}
 		}
@@ -846,7 +846,7 @@ 
 
 			// Convert name array to string.
 			if ( isset( $value['first'] ) && isset( $value['last'] ) ) {
-				$values['item_meta'][ $field_id ] = trim( implode( ' ', $value ) );
+				$values['item_meta'][$field_id] = trim( implode( ' ', $value ) );
 				$values['name_field_ids'][]       = $field_id;
 				continue;
 			}
@@ -867,8 +867,8 @@ 
 						continue;
 					}
 
-					if ( ! isset( $values['item_meta'][ $subsubindex ] ) ) {
-						$values['item_meta'][ $subsubindex ] = array();
+					if ( ! isset( $values['item_meta'][$subsubindex] ) ) {
+						$values['item_meta'][$subsubindex] = array();
 					}
 
 					// Convert name array to string.
@@ -878,11 +878,11 @@ 
 						$values['name_field_ids'][] = $subsubindex;
 					}
 
-					$values['item_meta'][ $subsubindex ][] = $subsubvalue;
+					$values['item_meta'][$subsubindex][] = $subsubvalue;
 				}
 			}//end foreach
 
-			unset( $values['item_meta'][ $field_id ] );
+			unset( $values['item_meta'][$field_id] );
 		}//end foreach
 
 		return $form_ids;

classes/models/FrmAddon.php

Braces +2 added lines, -1 removed lines

@@ -465,7 +465,8 @@
 	}
 
 	private function is_license_revoked() {
-		if ( empty( $this->license ) || empty( $this->plugin_slug ) || isset( $_POST['license'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( empty( $this->license ) || empty( $this->plugin_slug ) || isset( $_POST['license'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return;
 		}
 

Spacing +15 added lines, -15 removed lines

@@ -70,7 +70,7 @@ 
 	}
 
 	public function insert_installed_addon( $plugins ) {
-		$plugins[ $this->plugin_slug ] = $this;
+		$plugins[$this->plugin_slug] = $this;
 
 		return $plugins;
 	}
@@ -78,8 +78,8 @@ 
 	public static function get_addon( $plugin_slug ) {
 		$plugins = apply_filters( 'frm_installed_addons', array() );
 		$plugin  = false;
-		if ( isset( $plugins[ $plugin_slug ] ) ) {
-			$plugin = $plugins[ $plugin_slug ];
+		if ( isset( $plugins[$plugin_slug] ) ) {
+			$plugin = $plugins[$plugin_slug];
 		}
 
 		return $plugin;
@@ -139,7 +139,7 @@ 
 		} else {
 			$api     = new FrmFormApi( $this->license );
 			$plugins = $api->get_api_info();
-			$_data   = $plugins[ $item_id ];
+			$_data   = $plugins[$item_id];
 		}
 
 		$_data['sections'] = array(
@@ -380,19 +380,19 @@ 
 
 		if ( $this->is_current_version( $transient ) ) {
 			// Make sure it doesn't show there is an update if plugin is up-to-date.
-			if ( isset( $transient->response[ $this->plugin_folder ] ) ) {
-				unset( $transient->response[ $this->plugin_folder ] );
+			if ( isset( $transient->response[$this->plugin_folder] ) ) {
+				unset( $transient->response[$this->plugin_folder] );
 			}
-		} elseif ( isset( $transient->response ) && isset( $transient->response[ $this->plugin_folder ] ) ) {
-			$this->prepare_update_details( $transient->response[ $this->plugin_folder ] );
+		} elseif ( isset( $transient->response ) && isset( $transient->response[$this->plugin_folder] ) ) {
+			$this->prepare_update_details( $transient->response[$this->plugin_folder] );
 
 			// if the transient has expired, clear the update and trigger it again
-			if ( $transient->response[ $this->plugin_folder ] === false ) {
+			if ( $transient->response[$this->plugin_folder] === false ) {
 				if ( ! $this->has_been_cleared() ) {
 					$this->cleared_plugins();
 					$this->manually_queue_update();
 				}
-				unset( $transient->response[ $this->plugin_folder ] );
+				unset( $transient->response[$this->plugin_folder] );
 			}
 		}
 
@@ -482,7 +482,7 @@ 
 	}
 
 	private function is_current_version( $transient ) {
-		if ( empty( $transient->checked ) || ! isset( $transient->checked[ $this->plugin_folder ] ) ) {
+		if ( empty( $transient->checked ) || ! isset( $transient->checked[$this->plugin_folder] ) ) {
 			return false;
 		}
 
@@ -491,7 +491,7 @@ 
 			return true;
 		}
 
-		return isset( $transient->response ) && isset( $transient->response[ $this->plugin_folder ] ) && $transient->checked[ $this->plugin_folder ] === $transient->response[ $this->plugin_folder ]->new_version;
+		return isset( $transient->response ) && isset( $transient->response[$this->plugin_folder] ) && $transient->checked[$this->plugin_folder] === $transient->response[$this->plugin_folder]->new_version;
 	}
 
 	/**
@@ -633,8 +633,8 @@ 
 			$response['message'] = $response['status'];
 		} else {
 			$messages = $this->get_messages();
-			if ( is_string( $response['status'] ) && isset( $messages[ $response['status'] ] ) ) {
-				$response['message'] = $messages[ $response['status'] ];
+			if ( is_string( $response['status'] ) && isset( $messages[$response['status']] ) ) {
+				$response['message'] = $messages[$response['status']];
 			} else {
 				$response['message'] = FrmAppHelper::kses( $response['status'], array( 'a' ) );
 			}
@@ -796,7 +796,7 @@ 
 			'user-agent' => $this->plugin_slug . '/' . $this->version . '; ' . get_bloginfo( 'url' ),
 		);
 
-		$resp              = wp_remote_post(
+		$resp = wp_remote_post(
 			$this->store_url . '?l=' . urlencode( base64_encode( $this->license ) ),
 			$arg_array
 		);

stripe/controllers/FrmStrpLiteActionsController.php

Spacing +8 added lines, -8 removed lines

@@ -47,7 +47,7 @@ 
 			$gateway   = $payment_action->post_content['gateway'];
 			$is_stripe = $gateway === 'stripe' || ( is_array( $gateway ) && in_array( 'stripe', $gateway, true ) );
 			if ( ! $is_stripe || empty( $payment_action->post_content['amount'] ) ) {
-				unset( $payment_actions[ $k ] );
+				unset( $payment_actions[$k] );
 			}
 		}
 		return $payment_actions;
@@ -84,7 +84,7 @@ 
 			'run_triggers' => false,
 			'show_errors'  => true,
 		);
-		$atts     = compact( 'action', 'entry', 'form' );
+		$atts = compact( 'action', 'entry', 'form' );
 
 		$amount = self::prepare_amount( $action->post_content['amount'], $atts );
 		if ( empty( $amount ) || $amount == 000 ) {
@@ -502,7 +502,7 @@ 
 		$disallowed = array( ';', ':', '!important' );
 		foreach ( $settings as $k => $s ) {
 			if ( is_string( $s ) ) {
-				$settings[ $k ] = str_replace( $disallowed, '', $s );
+				$settings[$k] = str_replace( $disallowed, '', $s );
 			}
 		}
 
@@ -574,18 +574,18 @@ 
 	 * @return array
 	 */
 	public static function remove_cc_validation( $errors, $field, $values ) {
-		$has_processed = isset( $_POST[ 'frmintent' . $field->form_id ] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		$has_processed = isset( $_POST['frmintent' . $field->form_id] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 		if ( ! $has_processed ) {
 			return $errors;
 		}
 
 		$field_id = isset( $field->temp_id ) ? $field->temp_id : $field->id;
 
-		if ( isset( $errors[ 'field' . $field_id . '-cc' ] ) ) {
-			unset( $errors[ 'field' . $field_id . '-cc' ] );
+		if ( isset( $errors['field' . $field_id . '-cc'] ) ) {
+			unset( $errors['field' . $field_id . '-cc'] );
 		}
-		if ( isset( $errors[ 'field' . $field_id ] ) ) {
-			unset( $errors[ 'field' . $field_id ] );
+		if ( isset( $errors['field' . $field_id] ) ) {
+			unset( $errors['field' . $field_id] );
 		}
 
 		return $errors;

classes/models/FrmEntryFormatter.php

Spacing +7 added lines, -7 removed lines

@@ -164,8 +164,8 @@ 
 
 		$conditionally_add = array( 'include_fields', 'fields', 'exclude_fields', 'entry' );
 		foreach ( $conditionally_add as $index ) {
-			if ( isset( $atts[ $index ] ) ) {
-				$entry_atts[ $index ] = $atts[ $index ];
+			if ( isset( $atts[$index] ) ) {
+				$entry_atts[$index] = $atts[$index];
 			}
 		}
 
@@ -351,8 +351,8 @@ 
 
 		$unset = array( 'id', 'form_id', 'format' );
 		foreach ( $unset as $param ) {
-			if ( isset( $atts[ $param ] ) ) {
-				unset( $atts[ $param ] );
+			if ( isset( $atts[$param] ) ) {
+				unset( $atts[$param] );
 			}
 		}
 
@@ -523,11 +523,11 @@ 
 
 			$displayed_value = $this->prepare_display_value_for_array( $field_value->get_displayed_value() );
 
-			$output[ $this->get_key_or_id( $field_value ) ] = $displayed_value;
+			$output[$this->get_key_or_id( $field_value )] = $displayed_value;
 
 			$has_separate_value = (bool) $field_value->get_field_option( 'separate_value' );
 			if ( $has_separate_value || $displayed_value !== $field_value->get_saved_value() ) {
-				$output[ $this->get_key_or_id( $field_value ) . '-value' ] = $field_value->get_saved_value();
+				$output[$this->get_key_or_id( $field_value ) . '-value'] = $field_value->get_saved_value();
 			}
 		}
 	}
@@ -917,7 +917,7 @@ 
 
 			if ( is_array( $value ) ) {
 				foreach ( $value as $key => $single_value ) {
-					$value[ $key ] = $this->strip_html( $single_value );
+					$value[$key] = $this->strip_html( $single_value );
 				}
 			} elseif ( $this->is_plain_text && ! is_array( $value ) ) {
 				if ( strpos( $value, '<img' ) !== false ) {

classes/views/frm-fields/back-end/html-content.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 		<?php esc_html_e( 'Content', 'formidable' ); ?>
 	</label>
 	<?php
-	$e_args  = array(
+	$e_args = array(
 		'textarea_name' => 'field_options[description_' . absint( $field['id'] ) . ']',
 		'textarea_rows' => 8,
 	);

classes/models/FrmYoutubeFeedApi.php

Spacing +2 added lines, -2 removed lines

@@ -40,8 +40,8 @@
 	 */
 	public function get_video( $type = 'welcome' ) {
 		$videos = $this->get_api_info();
-		if ( isset( $videos[ $type ] ) ) {
-			return $videos[ $type ];
+		if ( isset( $videos[$type] ) ) {
+			return $videos[$type];
 		}
 		return array();
 	}

classes/factories/FrmCaptchaFactory.php

Spacing +2 added lines, -2 removed lines

@@ -33,10 +33,10 @@
 			'turnstile' => 'FrmTurnstileSettings',
 		);
 
-		if ( ! isset( $settings_classes[ $active_captcha ] ) ) {
+		if ( ! isset( $settings_classes[$active_captcha] ) ) {
 			$active_captcha = 'recaptcha';
 		}
 
-		return $settings_classes[ $active_captcha ];
+		return $settings_classes[$active_captcha];
 	}
 }

classes/models/fields/FrmFieldCaptcha.php

Spacing +6 added lines, -6 removed lines

@@ -255,8 +255,8 @@ 
 
 		if ( is_wp_error( $resp ) ) {
 			$error_string                     = $resp->get_error_message();
-			$errors[ 'field' . $args['id'] ]  = __( 'There was a problem verifying your captcha', 'formidable' );
-			$errors[ 'field' . $args['id'] ] .= ' ' . $error_string;
+			$errors['field' . $args['id']]  = __( 'There was a problem verifying your captcha', 'formidable' );
+			$errors['field' . $args['id']] .= ' ' . $error_string;
 			return $errors;
 		}
 
@@ -283,7 +283,7 @@ 
 			if ( $invalid_message === __( 'The reCAPTCHA was not entered correctly', 'formidable' ) ) {
 				$invalid_message = '';
 			}
-			$errors[ 'field' . $args['id'] ] = ( $invalid_message === '' ? $frm_settings->re_msg : $invalid_message );
+			$errors['field' . $args['id']] = ( $invalid_message === '' ? $frm_settings->re_msg : $invalid_message );
 		}
 
 		return $errors;
@@ -299,8 +299,8 @@ 
 			$frm_vars['captcha_scores'] = array();
 		}
 		$form_id = is_object( $this->field ) ? $this->field->form_id : $this->field['form_id'];
-		if ( ! isset( $frm_vars['captcha_scores'][ $form_id ] ) ) {
-			$frm_vars['captcha_scores'][ $form_id ] = $score;
+		if ( ! isset( $frm_vars['captcha_scores'][$form_id] ) ) {
+			$frm_vars['captcha_scores'][$form_id] = $score;
 		}
 	}
 
@@ -329,7 +329,7 @@ 
 	protected static function post_data_includes_token() {
 		$settings = FrmCaptchaFactory::get_settings_object();
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
-		return ! empty( $_POST[ $settings->token_field ] );
+		return ! empty( $_POST[$settings->token_field] );
 	}
 
 	/**

classes/controllers/FrmDashboardController.php

Spacing +4 added lines, -4 removed lines

@@ -478,7 +478,7 @@ 
 		foreach ( $data as $key => $messages ) {
 			if ( in_array( $key, array( 'unread', 'dismissed' ), true ) ) {
 				foreach ( $messages as $key_msg => $message ) {
-					$data[ $key ][ $key_msg ]['cta'] = self::inbox_clean_messages_cta( $message['cta'] );
+					$data[$key][$key_msg]['cta'] = self::inbox_clean_messages_cta( $message['cta'] );
 				}
 			}
 		}
@@ -557,11 +557,11 @@ 
 	 */
 	private static function get_dashboard_options( $option_name = null ) {
 		$options = get_option( self::OPTION_META_NAME, array() );
-		if ( null !== $option_name && ! isset( $options[ $option_name ] ) ) {
+		if ( null !== $option_name && ! isset( $options[$option_name] ) ) {
 			return array();
 		}
 		if ( null !== $option_name ) {
-			return $options[ $option_name ];
+			return $options[$option_name];
 		}
 		return $options;
 	}
@@ -576,7 +576,7 @@ 
 	 */
 	private static function update_dashboard_options( $data, $option_name ) {
 		$options                 = self::get_dashboard_options();
-		$options[ $option_name ] = $data;
+		$options[$option_name] = $data;
 		update_option( self::OPTION_META_NAME, $options, 'no' );
 	}