Strategy11 / formidable-forms

classes/helpers/FrmListHelper.php

Spacing +15 added lines, -15 removed lines

@@ -230,8 +230,8 @@ 
 			return $this->get_pagenum();
 		}
 
-		if ( isset( $this->_pagination_args[ $key ] ) ) {
-			return $this->_pagination_args[ $key ];
+		if ( isset( $this->_pagination_args[$key] ) ) {
+			return $this->_pagination_args[$key];
 		}
 	}
 
@@ -281,8 +281,8 @@ 
 	 * @return void
 	 */
 	private function hidden_search_inputs( $param_name ) {
-		if ( ! empty( $_REQUEST[ $param_name ] ) ) {
-			$value = sanitize_text_field( wp_unslash( $_REQUEST[ $param_name ] ) );
+		if ( ! empty( $_REQUEST[$param_name] ) ) {
+			$value = sanitize_text_field( wp_unslash( $_REQUEST[$param_name] ) );
 			echo '<input type="hidden" name="' . esc_attr( $param_name ) . '" value="' . esc_attr( $value ) . '" />';
 		}
 	}
@@ -324,7 +324,7 @@ 
 
 		echo "<ul class='subsubsub'>\n";
 		foreach ( $views as $class => $view ) {
-			$views[ $class ] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
+			$views[$class] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
 		}
 		echo implode( " |</li>\n", $views ) . "</li>\n"; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 		echo '</ul>';
@@ -490,7 +490,7 @@ 
 
 		$out = '<div class="' . ( $always_visible ? 'row-actions visible' : 'row-actions' ) . '">';
 		foreach ( $actions as $action => $link ) {
-			++$i;
+			++ $i;
 			$sep  = $i === $action_count ? '' : ' | ';
 			$out .= "<span class='$action'>$link$sep</span>";
 		}
@@ -723,7 +723,7 @@ 
 			'next'  => __( 'Next page', 'formidable' ),
 		);
 
-		return $labels[ $link ];
+		return $labels[$link];
 	}
 
 	private function current_url() {
@@ -828,7 +828,7 @@ 
 
 		// If the primary column doesn't exist fall back to the
 		// first non-checkbox column.
-		if ( ! isset( $columns[ $default ] ) ) {
+		if ( ! isset( $columns[$default] ) ) {
 			$default = self::get_default_primary_column_name();
 		}
 
@@ -842,7 +842,7 @@ 
 		 */
 		$column = apply_filters( 'list_table_primary_column', $default, $this->screen->id );
 
-		if ( empty( $column ) || ! isset( $columns[ $column ] ) ) {
+		if ( empty( $column ) || ! isset( $columns[$column] ) ) {
 			$column = $default;
 		}
 
@@ -863,7 +863,7 @@ 
 			// In 4.3, we added a fourth argument for primary column.
 			$column_headers = array( array(), array(), array(), $this->get_primary_column_name() );
 			foreach ( $this->_column_headers as $key => $value ) {
-				$column_headers[ $key ] = $value;
+				$column_headers[$key] = $value;
 			}
 
 			return $column_headers;
@@ -896,7 +896,7 @@ 
 				$data[1] = false;
 			}
 
-			$sortable[ $id ] = $data;
+			$sortable[$id] = $data;
 		}
 
 		$primary = $this->get_primary_column_name();
@@ -954,7 +954,7 @@ 
 			static $cb_counter = 1;
 			$columns['cb']     = '<label class="screen-reader-text" for="cb-select-all-' . $cb_counter . '">' . __( 'Select All', 'formidable' ) . '</label>';
 			$columns['cb']    .= '<input id="cb-select-all-' . esc_attr( $cb_counter ) . '" type="checkbox" />';
-			++$cb_counter;
+			++ $cb_counter;
 		}
 
 		foreach ( $columns as $column_key => $column_display_name ) {
@@ -976,8 +976,8 @@ 
 				$class[] = 'column-primary';
 			}
 
-			if ( isset( $sortable[ $column_key ] ) ) {
-				list( $orderby, $desc_first ) = $sortable[ $column_key ];
+			if ( isset( $sortable[$column_key] ) ) {
+				list( $orderby, $desc_first ) = $sortable[$column_key];
 
 				if ( $current_orderby == $orderby ) {
 					// The sorted column. The `aria-sort` attribute must be set only on the sorted column.
@@ -1094,7 +1094,7 @@ 
 	 * @return bool Returns true if the setting is not set or if it is not false; otherwise, returns false.
 	 */
 	protected function should_display( $args, $settings ) {
-		return ! isset( $args[ $settings ] ) || false !== $args[ $settings ];
+		return ! isset( $args[$settings] ) || false !== $args[$settings];
 	}
 
 	/**

classes/helpers/FrmAppHelper.php

Spacing +86 added lines, -86 removed lines

@@ -327,7 +327,7 @@ 
 			'fill'   => '#4d4d4d',
 			'orange' => '#f05a24',
 		);
-		$atts     = array_merge( $defaults, $atts );
+		$atts = array_merge( $defaults, $atts );
 
 		return '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 599.68 601.37" width="' . esc_attr( $atts['width'] ) . '" height="' . esc_attr( $atts['height'] ) . '">
 			<path fill="' . esc_attr( $atts['orange'] ) . '" d="M289.6 384h140v76h-140z"/>
@@ -615,7 +615,7 @@ 
 	 * @return string
 	 */
 	public static function get_server_value( $value ) {
-		return isset( $_SERVER[ $value ] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[ $value ] ) ) : '';
+		return isset( $_SERVER[$value] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[$value] ) ) : '';
 	}
 
 	/**
@@ -649,7 +649,7 @@ 
 		$ip         = '';
 
 		foreach ( $ip_options as $key ) {
-			if ( ! isset( $_SERVER[ $key ] ) ) {
+			if ( ! isset( $_SERVER[$key] ) ) {
 				continue;
 			}
 
@@ -726,10 +726,10 @@ 
 		}
 
 		if ( $src === 'get' ) {
-			$value = isset( $_POST[ $param ] ) ? wp_unslash( $_POST[ $param ] ) : ( isset( $_GET[ $param ] ) ? wp_unslash( $_GET[ $param ] ) : $default ); // phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-			if ( ! isset( $_POST[ $param ] ) && isset( $_GET[ $param ] ) && ! is_array( $value ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$value = isset( $_POST[$param] ) ? wp_unslash( $_POST[$param] ) : ( isset( $_GET[$param] ) ? wp_unslash( $_GET[$param] ) : $default ); // phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
+			if ( ! isset( $_POST[$param] ) && isset( $_GET[$param] ) && ! is_array( $value ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = htmlspecialchars_decode( wp_unslash( $_GET[ $param ] ) );
+				$value = htmlspecialchars_decode( wp_unslash( $_GET[$param] ) );
 			}
 			self::sanitize_value( $sanitize, $value );
 		} else {
@@ -750,7 +750,7 @@ 
 				}
 
 				$p     = trim( $p, ']' );
-				$value = $value[ $p ] ?? $default;
+				$value = $value[$p] ?? $default;
 			}
 		}
 
@@ -815,26 +815,26 @@ 
 			'sanitize'   => 'sanitize_text_field',
 			'serialized' => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$value = $args['default'];
 		if ( $args['type'] === 'get' ) {
-			if ( $_GET && isset( $_GET[ $args['param'] ] ) ) {
+			if ( $_GET && isset( $_GET[$args['param']] ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
-				$value = wp_unslash( $_GET[ $args['param'] ] );
+				$value = wp_unslash( $_GET[$args['param']] );
 			}
 		} elseif ( $args['type'] === 'post' ) {
-			if ( isset( $_POST[ $args['param'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( isset( $_POST[$args['param']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
-				$value = wp_unslash( $_POST[ $args['param'] ] );
+				$value = wp_unslash( $_POST[$args['param']] );
 				if ( $args['serialized'] === true && is_serialized_string( $value ) && is_serialized( $value ) ) {
 					self::unserialize_or_decode( $value );
 				}
 			}
-		} elseif ( isset( $_REQUEST[ $args['param'] ] ) ) {
+		} elseif ( isset( $_REQUEST[$args['param']] ) ) {
 			// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = wp_unslash( $_REQUEST[ $args['param'] ] );
+				$value = wp_unslash( $_REQUEST[$args['param']] );
 		}
 
 		self::sanitize_value( $args['sanitize'], $value );
@@ -881,7 +881,7 @@ 
 		if ( is_array( $value ) ) {
 			$temp_values = $value;
 			foreach ( $temp_values as $k => $v ) {
-				self::sanitize_value( $sanitize, $value[ $k ] );
+				self::sanitize_value( $sanitize, $value[$k] );
 			}
 			return;
 		}
@@ -898,8 +898,8 @@ 
 	public static function sanitize_request( $sanitize_method, &$values ) {
 		$temp_values = $values;
 		foreach ( $temp_values as $k => $val ) {
-			if ( isset( $sanitize_method[ $k ] ) ) {
-				$values[ $k ] = call_user_func( $sanitize_method[ $k ], $val );
+			if ( isset( $sanitize_method[$k] ) ) {
+				$values[$k] = call_user_func( $sanitize_method[$k], $val );
 			}
 		}
 	}
@@ -961,7 +961,7 @@ 
 		if ( is_array( $value ) ) {
 			$temp_values = $value;
 			foreach ( $temp_values as $k => $v ) {
-				self::decode_specialchars( $value[ $k ] );
+				self::decode_specialchars( $value[$k] );
 			}
 		} else {
 			self::decode_amp( $value );
@@ -1096,7 +1096,7 @@ 
 	 * @return array
 	 */
 	public static function add_allowed_submit_button_tags( $allowed_html ) {
-		$allowed_html['input']                    = array(
+		$allowed_html['input'] = array(
 			'type'           => true,
 			'value'          => true,
 			'formnovalidate' => true,
@@ -1122,7 +1122,7 @@ 
 			$allowed_html = $html;
 		} elseif ( ! empty( $allowed ) ) {
 			foreach ( (array) $allowed as $a ) {
-				$allowed_html[ $a ] = $html[ $a ] ?? array();
+				$allowed_html[$a] = $html[$a] ?? array();
 			}
 		}
 
@@ -1310,8 +1310,8 @@ 
 		}
 
 		global $wp_query;
-		if ( isset( $wp_query->query_vars[ $param ] ) ) {
-			$value = $wp_query->query_vars[ $param ];
+		if ( isset( $wp_query->query_vars[$param] ) ) {
+			$value = $wp_query->query_vars[$param];
 		}
 
 		return $value;
@@ -1342,9 +1342,9 @@ 
 			'frm_keyalt_icon'       => 'frm_key_icon',
 			'frm_keyalt_solid_icon' => 'frm_key_solid_icon',
 		);
-		if ( isset( $deprecated[ $icon ] ) ) {
-			$icon  = $deprecated[ $icon ];
-			$class = str_replace( $icon, $deprecated[ $icon ], $class );
+		if ( isset( $deprecated[$icon] ) ) {
+			$icon  = $deprecated[$icon];
+			$class = str_replace( $icon, $deprecated[$icon], $class );
 		}
 
 		if ( $icon === $class ) {
@@ -1467,7 +1467,7 @@ 
 	 * @return string|void
 	 */
 	public static function array_to_html_params( $atts, $echo = false ) {
-		$callback = function () use ( $atts ) {
+		$callback = function() use ( $atts ) {
 			if ( $atts ) {
 				foreach ( $atts as $key => $value ) {
 					echo ' ' . esc_attr( $key ) . '="' . esc_attr( $value ) . '"';
@@ -1648,7 +1648,7 @@ 
 			'value'       => false,
 			'class'       => '',
 		);
-		$atts     = array_merge( $defaults, $atts );
+		$atts = array_merge( $defaults, $atts );
 
 		if ( $atts['input_id'] === 'template' && empty( $atts['tosearch'] ) ) {
 			$atts['tosearch'] = 'frm-card';
@@ -1725,7 +1725,7 @@ 
 				'new_file_path' => self::plugin_path() . '/js',
 			)
 		);
-		$new_file  = new FrmCreateFile( $file_atts );
+		$new_file = new FrmCreateFile( $file_atts );
 
 		$files = array(
 			self::plugin_path() . '/js/formidable.min.js',
@@ -1939,8 +1939,8 @@ 
 	 */
 	private static function get_dropdown_value_and_label_from_option( $option, $key, $args ) {
 		if ( is_array( $option ) ) {
-			$value = $option[ $args['value_key'] ] ?? '';
-			$label = $option[ $args['label_key'] ] ?? '';
+			$value = $option[$args['value_key']] ?? '';
+			$label = $option[$args['label_key']] ?? '';
 		} else {
 			$value = $key;
 			$label = $option;
@@ -2334,8 +2334,8 @@ 
 			return $error;
 		}
 
-		$nonce_value = $_REQUEST && isset( $_REQUEST[ $nonce_name ] ) ? sanitize_text_field( wp_unslash( $_REQUEST[ $nonce_name ] ) ) : '';
-		if ( $_REQUEST && ( ! isset( $_REQUEST[ $nonce_name ] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
+		$nonce_value = $_REQUEST && isset( $_REQUEST[$nonce_name] ) ? sanitize_text_field( wp_unslash( $_REQUEST[$nonce_name] ) ) : '';
+		if ( $_REQUEST && ( ! isset( $_REQUEST[$nonce_name] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
 			$frm_settings = self::get_settings();
 			$error        = $frm_settings->admin_permission;
 		}
@@ -2389,7 +2389,7 @@ 
 			} else {
 				foreach ( $value as $k => $v ) {
 					if ( ! is_array( $v ) ) {
-						$value[ $k ] = call_user_func( $original_function, $v );
+						$value[$k] = call_user_func( $original_function, $v );
 					}
 				}
 			}
@@ -2440,7 +2440,7 @@ 
 			if ( is_array( $value ) ) {
 				$return = array_merge( $return, self::array_flatten( $value, $keys ) );
 			} elseif ( $keys === 'keep' ) {
-					$return[ $key ] = $value;
+					$return[$key] = $value;
 			} else {
 				$return[] = $value;
 			}
@@ -2527,11 +2527,11 @@ 
 		}
 
 		$ver = $default;
-		if ( ! isset( $wp_scripts->registered[ $handle ] ) ) {
+		if ( ! isset( $wp_scripts->registered[$handle] ) ) {
 			return $ver;
 		}
 
-		$query = $wp_scripts->registered[ $handle ];
+		$query = $wp_scripts->registered[$handle];
 		if ( is_object( $query ) && ! empty( $query->ver ) ) {
 			$ver = $query->ver;
 		}
@@ -2547,7 +2547,7 @@ 
 	 * @return string|null
 	 */
 	public static function js_redirect( $url, $echo = false ) {
-		$callback = function () use ( $url ) {
+		$callback = function() use ( $url ) {
 			echo '<script type="text/javascript">window.location="' . esc_url_raw( $url ) . '"</script>';
 		};
 		return self::clip( $callback, $echo );
@@ -2647,7 +2647,7 @@ 
 			$suffix = 2;
 			do {
 				$key_check = $key . $separator . $suffix;
-				++$suffix;
+				++ $suffix;
 			} while ( in_array( $key_check, $similar_keys, true ) );
 
 			$key = $key_check;
@@ -2757,7 +2757,7 @@ 
 
 		foreach ( array( 'name', 'description' ) as $var ) {
 			$default_val    = $record->{$var} ?? '';
-			$values[ $var ] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
+			$values[$var] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
 			unset( $var, $default_val );
 		}
 
@@ -2829,9 +2829,9 @@ 
 			$meta_value = FrmEntryMeta::get_meta_value( $record, $field->id );
 		}//end if
 
-		$field_type = $post_values['field_options'][ 'type_' . $field->id ] ?? $field->type;
-		if ( isset( $post_values['item_meta'][ $field->id ] ) ) {
-			$new_value = $post_values['item_meta'][ $field->id ];
+		$field_type = $post_values['field_options']['type_' . $field->id] ?? $field->type;
+		if ( isset( $post_values['item_meta'][$field->id] ) ) {
+			$new_value = $post_values['item_meta'][$field->id];
 			self::unserialize_or_decode( $new_value );
 		} else {
 			$new_value = $meta_value;
@@ -2852,7 +2852,7 @@ 
 
 		$field_array = array_merge( (array) $field->field_options, $field_array );
 
-		$values['fields'][ $field->id ] = $field_array;
+		$values['fields'][$field->id] = $field_array;
 	}
 
 	/**
@@ -2902,11 +2902,11 @@ 
 		}
 
 		foreach ( $form->options as $opt => $value ) {
-			if ( isset( $post_values[ $opt ] ) ) {
-				$values[ $opt ] = $post_values[ $opt ];
-				self::unserialize_or_decode( $values[ $opt ] );
+			if ( isset( $post_values[$opt] ) ) {
+				$values[$opt] = $post_values[$opt];
+				self::unserialize_or_decode( $values[$opt] );
 			} else {
-				$values[ $opt ] = $value;
+				$values[$opt] = $value;
 			}
 		}
 
@@ -2925,8 +2925,8 @@ 
 		$form_defaults = FrmFormsHelper::get_default_opts();
 
 		foreach ( $form_defaults as $opt => $default ) {
-			if ( ! isset( $values[ $opt ] ) || $values[ $opt ] == '' ) {
-				$values[ $opt ] = $post_values && isset( $post_values['options'][ $opt ] ) ? $post_values['options'][ $opt ] : $default;
+			if ( ! isset( $values[$opt] ) || $values[$opt] == '' ) {
+				$values[$opt] = $post_values && isset( $post_values['options'][$opt] ) ? $post_values['options'][$opt] : $default;
 			}
 
 			unset( $opt, $default );
@@ -2937,8 +2937,8 @@ 
 		}
 
 		foreach ( array( 'before', 'after', 'submit' ) as $h ) {
-			if ( ! isset( $values[ $h . '_html' ] ) ) {
-				$values[ $h . '_html' ] = ( $post_values['options'][ $h . '_html' ] ?? FrmFormsHelper::get_default_html( $h ) );
+			if ( ! isset( $values[$h . '_html'] ) ) {
+				$values[$h . '_html'] = ( $post_values['options'][$h . '_html'] ?? FrmFormsHelper::get_default_html( $h ) );
 			}
 			unset( $h );
 		}
@@ -3152,25 +3152,25 @@ 
 		if ( ! is_numeric( $levels ) ) {
 			// Show time in specified unit.
 			$levels = self::get_unit( $levels );
-			if ( isset( $time_strings[ $levels ] ) ) {
+			if ( isset( $time_strings[$levels] ) ) {
 				$diff         = array(
 					$levels => self::time_format( $levels, $diff ),
 				);
 				$time_strings = array(
-					$levels => $time_strings[ $levels ],
+					$levels => $time_strings[$levels],
 				);
 			}
 			$levels = 1;
 		}
 
 		foreach ( $time_strings as $k => $v ) {
-			if ( isset( $diff[ $k ] ) && $diff[ $k ] ) {
-				$time_strings[ $k ] = $diff[ $k ] . ' ' . ( $diff[ $k ] > 1 ? $v[1] : $v[0] );
-			} elseif ( isset( $diff[ $k ] ) && count( $time_strings ) === 1 ) {
+			if ( isset( $diff[$k] ) && $diff[$k] ) {
+				$time_strings[$k] = $diff[$k] . ' ' . ( $diff[$k] > 1 ? $v[1] : $v[0] );
+			} elseif ( isset( $diff[$k] ) && count( $time_strings ) === 1 ) {
 				// Account for 0.
-				$time_strings[ $k ] = $diff[ $k ] . ' ' . $v[1];
+				$time_strings[$k] = $diff[$k] . ' ' . $v[1];
 			} else {
-				unset( $time_strings[ $k ] );
+				unset( $time_strings[$k] );
 			}
 		}
 
@@ -3194,8 +3194,8 @@ 
 			'y' => 'y',
 			'd' => 'days',
 		);
-		if ( isset( $return[ $unit ] ) ) {
-			return $diff[ $return[ $unit ] ];
+		if ( isset( $return[$unit] ) ) {
+			return $diff[$return[$unit]];
 		}
 
 		$total = $diff['days'] * self::convert_time( 'd', $unit );
@@ -3203,11 +3203,11 @@ 
 		$times = array( 'h', 'i', 's' );
 
 		foreach ( $times as $time ) {
-			if ( ! isset( $diff[ $time ] ) ) {
+			if ( ! isset( $diff[$time] ) ) {
 				continue;
 			}
 
-			$total += $diff[ $time ] * self::convert_time( $time, $unit );
+			$total += $diff[$time] * self::convert_time( $time, $unit );
 		}
 
 		return floor( $total );
@@ -3232,7 +3232,7 @@ 
 			'y' => DAY_IN_SECONDS * 365.25,
 		);
 
-		return $convert[ $from ] / $convert[ $to ];
+		return $convert[$from] / $convert[$to];
 	}
 
 	/**
@@ -3244,7 +3244,7 @@ 
 	 */
 	private static function get_unit( $unit ) {
 		$units = self::get_time_strings();
-		if ( isset( $units[ $unit ] ) || is_numeric( $unit ) ) {
+		if ( isset( $units[$unit] ) || is_numeric( $unit ) ) {
 			return $unit;
 		}
 
@@ -3362,17 +3362,17 @@ 
 
 					case 1:
 						$l2 = $name;
-						self::add_value_to_array( $name, $l2, $this_val, $vars[ $l1 ] );
+						self::add_value_to_array( $name, $l2, $this_val, $vars[$l1] );
 						break;
 
 					case 2:
 						$l3 = $name;
-						self::add_value_to_array( $name, $l3, $this_val, $vars[ $l1 ][ $l2 ] );
+						self::add_value_to_array( $name, $l3, $this_val, $vars[$l1][$l2] );
 						break;
 
 					case 3:
 						$l4 = $name;
-						self::add_value_to_array( $name, $l4, $this_val, $vars[ $l1 ][ $l2 ][ $l3 ] );
+						self::add_value_to_array( $name, $l4, $this_val, $vars[$l1][$l2][$l3] );
 				}
 
 				unset( $this_val, $n );
@@ -3395,8 +3395,8 @@ 
 	public static function add_value_to_array( $name, $l1, $val, &$vars ) {
 		if ( $name == '' ) {
 			$vars[] = $val;
-		} elseif ( ! isset( $vars[ $l1 ] ) ) {
-			$vars[ $l1 ] = $val;
+		} elseif ( ! isset( $vars[$l1] ) ) {
+			$vars[$l1] = $val;
 		}
 	}
 
@@ -3420,7 +3420,7 @@ 
 			'new_tab'       => __( 'This option will open the link in a new browser tab. Please note that some popup blockers may prevent this from happening, in which case the link will be displayed.', 'formidable' ),
 		);
 
-		if ( ! isset( $tooltips[ $name ] ) ) {
+		if ( ! isset( $tooltips[$name] ) ) {
 			return;
 		}
 
@@ -3430,7 +3430,7 @@ 
 			echo ' class="frm_help"';
 		}
 
-		echo ' title="' . esc_attr( $tooltips[ $name ] );
+		echo ' title="' . esc_attr( $tooltips[$name] );
 
 		if ( 'open' != $class ) {
 			echo '"';
@@ -3502,13 +3502,13 @@ 
 	 * @return void
 	 */
 	private static function prepare_action_slashes( $val, $key, &$post_content ) {
-		if ( ! isset( $post_content[ $key ] ) || is_numeric( $val ) ) {
+		if ( ! isset( $post_content[$key] ) || is_numeric( $val ) ) {
 			return;
 		}
 
 		if ( is_array( $val ) ) {
 			foreach ( $val as $k1 => $v1 ) {
-				self::prepare_action_slashes( $v1, $k1, $post_content[ $key ] );
+				self::prepare_action_slashes( $v1, $k1, $post_content[$key] );
 				unset( $k1, $v1 );
 			}
 		} else {
@@ -3516,7 +3516,7 @@ 
 			$val = stripslashes( $val );
 
 			// Add backslashes before double quotes and forward slashes only
-			$post_content[ $key ] = addcslashes( $val, '"\\/' );
+			$post_content[$key] = addcslashes( $val, '"\\/' );
 		}
 	}
 
@@ -3640,14 +3640,14 @@ 
 				continue;
 			}
 			$key = $input['name'];
-			if ( isset( $formatted[ $key ] ) ) {
-				if ( is_array( $formatted[ $key ] ) ) {
-					$formatted[ $key ][] = $input['value'];
+			if ( isset( $formatted[$key] ) ) {
+				if ( is_array( $formatted[$key] ) ) {
+					$formatted[$key][] = $input['value'];
 				} else {
-					$formatted[ $key ] = array( $formatted[ $key ], $input['value'] );
+					$formatted[$key] = array( $formatted[$key], $input['value'] );
 				}
 			} else {
-				$formatted[ $key ] = $input['value'];
+				$formatted[$key] = $input['value'];
 			}
 		}
 
@@ -4354,8 +4354,8 @@ 
 		}
 
 		foreach ( $keys as $key ) {
-			if ( isset( $values[ $key ] ) ) {
-				$values[ $key ] = self::kses( $values[ $key ], 'all' );
+			if ( isset( $values[$key] ) ) {
+				$values[$key] = self::kses( $values[$key], 'all' );
 			}
 		}
 
@@ -4420,7 +4420,7 @@ 
 				'role',
 				'style',
 			);
-			$safe      = in_array( $key, $safe_keys, true );
+			$safe = in_array( $key, $safe_keys, true );
 		}//end if
 
 		/**
@@ -4559,7 +4559,7 @@ 
 			return 0;
 		}
 
-		return strlen( $parts[ count( $parts ) - 1 ] );
+		return strlen( $parts[count( $parts ) - 1] );
 	}
 
 	/**
@@ -4579,7 +4579,7 @@ 
 
 		add_filter(
 			'option_gmt_offset',
-			function ( $offset ) {
+			function( $offset ) {
 				if ( ! is_string( $offset ) || is_numeric( $offset ) ) {
 					// Leave a valid value alone.
 					return $offset;
@@ -4676,7 +4676,7 @@ 
 			return;
 		}
 
-		$ajax_callback = function () use ( $option ) {
+		$ajax_callback = function() use ( $option ) {
 			self::dismiss_warning_message( $option );
 		};
 
@@ -4686,7 +4686,7 @@ 
 
 		add_filter(
 			'frm_message_list',
-			function ( $show_messages ) use ( $message, $option ) {
+			function( $show_messages ) use ( $message, $option ) {
 				if ( get_option( $option, false ) ) {
 					return $show_messages;
 				}

classes/helpers/FrmFieldsHelper.php

Spacing +50 added lines, -50 removed lines

@@ -44,7 +44,7 @@ 
 			if ( in_array( $type, array( 'data', 'lookup' ), true ) ) {
 				$values['field_options']['data_type'] = $setting;
 			} else {
-				$values['field_options'][ $setting ] = 1;
+				$values['field_options'][$setting] = 1;
 			}
 		}
 
@@ -206,10 +206,10 @@ 
 		}
 
 		foreach ( $defaults as $opt => $default ) {
-			$values[ $opt ] = $field->field_options[ $opt ] ?? $default;
+			$values[$opt] = $field->field_options[$opt] ?? $default;
 
 			if ( $check_post ) {
-				self::get_posted_field_setting( $opt . '_' . $field->id, $values[ $opt ] );
+				self::get_posted_field_setting( $opt . '_' . $field->id, $values[$opt] );
 			}
 		}
 	}
@@ -226,7 +226,7 @@ 
 			return self::$context_is_safe_to_load_field_options_from_request_data;
 		}
 
-		$function = function () {
+		$function = function() {
 			if ( ! FrmAppHelper::is_admin_page() ) {
 				return false;
 			}
@@ -338,12 +338,12 @@ 
 	 * @return void
 	 */
 	private static function get_posted_field_setting( $setting, &$value ) {
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( ! isset( $_POST['field_options'][$setting] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return;
 		}
 
 		if ( strpos( $setting, 'html' ) !== false ) {
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 
 			// Conditionally strip script tags if the user sending $_POST data is not allowed to use unfiltered HTML.
 			if ( ! FrmAppHelper::allow_unfiltered_html() ) {
@@ -351,9 +351,9 @@ 
 			}
 		} elseif ( strpos( $setting, 'format_' ) === 0 ) {
 			// TODO: Remove stripslashes on output, and use on input only.
-			$value = sanitize_text_field( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
+			$value = sanitize_text_field( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
 		} else {
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
 		}
 	}
@@ -436,7 +436,7 @@ 
 		$values['default_value'] = FrmAppHelper::maybe_json_encode( $field->default_value );
 
 		foreach ( array( 'name', 'description', 'type', 'field_order', 'field_options', 'required' ) as $col ) {
-			$values[ $col ] = $field->{$col};
+			$values[$col] = $field->{$col};
 		}
 	}
 
@@ -474,7 +474,7 @@ 
 		);
 
 		$msg = FrmField::get_option( $field, $error );
-		$msg = empty( $msg ) ? $defaults[ $error ]['part'] : $msg;
+		$msg = empty( $msg ) ? $defaults[$error]['part'] : $msg;
 		$msg = do_shortcode( $msg );
 
 		$msg = self::maybe_replace_substrings_with_field_name( $msg, $error, $field );
@@ -798,7 +798,7 @@ 
 			'inside_class' => 'inside',
 			'dismiss-icon' => true,
 		);
-		$args     = array_merge( $defaults, $args );
+		$args = array_merge( $defaults, $args );
 
 		include FrmAppHelper::plugin_path() . '/classes/views/frm-fields/back-end/inline-modal.php';
 	}
@@ -1082,7 +1082,7 @@ 
 				continue;
 			}
 
-			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][ $short_key ] );
+			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][$short_key] );
 			$tag  = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
 
 			$atts['entry'] = $entry;
@@ -1092,7 +1092,7 @@ 
 			if ( $replace_with !== null ) {
 				$replace_with = self::trigger_shortcode_atts( $replace_with, $atts );
 				self::sanitize_embedded_shortcodes( compact( 'entry' ), $replace_with );
-				$content = str_replace( $shortcodes[0][ $short_key ], $replace_with, $content );
+				$content = str_replace( $shortcodes[0][$short_key], $replace_with, $content );
 			}
 
 			unset( $atts, $replace_with );
@@ -1110,7 +1110,7 @@ 
 		$supported_atts = array( 'remove_accents', 'sanitize', 'sanitize_url' );
 		$included_atts  = array_intersect( $supported_atts, array_keys( $atts ) );
 		foreach ( $included_atts as $included_att ) {
-			if ( '0' === $atts[ $included_att ] ) {
+			if ( '0' === $atts[$included_att] ) {
 				// Skip any option that uses 0 so sanitize_url=0 does not encode.
 				continue;
 			}
@@ -1188,8 +1188,8 @@ 
 
 		$dynamic_default = array( 'admin_email', 'siteurl', 'frmurl', 'sitename', 'get', 'default-email', 'default-from-email' );
 
-		if ( isset( $shortcode_values[ $atts['tag'] ] ) ) {
-			$replace_with = $shortcode_values[ $atts['tag'] ];
+		if ( isset( $shortcode_values[$atts['tag']] ) ) {
+			$replace_with = $shortcode_values[$atts['tag']];
 		} elseif ( in_array( $atts['tag'], $dynamic_default, true ) ) {
 			$replace_with = self::dynamic_default_values( $atts['tag'], $atts );
 		} elseif ( $clean_tag === 'user_agent' ) {
@@ -1435,8 +1435,8 @@ 
 			self::field_types_for_input( $single_input, $field_selection, $field_types );
 		} elseif ( in_array( $type, $multiple_input, true ) ) {
 			self::field_types_for_input( $multiple_input, $field_selection, $field_types );
-		} elseif ( isset( $field_selection[ $type ] ) ) {
-			$field_types[ $type ] = $field_selection[ $type ];
+		} elseif ( isset( $field_selection[$type] ) ) {
+			$field_types[$type] = $field_selection[$type];
 		}
 
 		$field_types = apply_filters( 'frm_switch_field_types', $field_types, compact( 'type', 'field_selection' ) );
@@ -1480,7 +1480,7 @@ 
 		foreach ( $inputs as $input ) {
 			// This may not be set if a field type was removed using the frm_available_fields or frm_pro_available_fields filters.
 			if ( array_key_exists( $input, $fields ) ) {
-				$field_types[ $input ] = $fields[ $input ];
+				$field_types[$input] = $fields[$input];
 			}
 			unset( $input );
 		}
@@ -1515,7 +1515,7 @@ 
 			'parent'  => false,
 			'pointer' => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$opt_key   = $args['opt_key'];
 		$field     = $args['field'];
@@ -1531,25 +1531,25 @@ 
 
 		// Check posted vals before checking saved values
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $parent && isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
-				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
+				$other_val = isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ) : '';
 			} else {
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 
 			return $other_val;
 		}
 
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			// For normal fields
 
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
-				$other_val = isset( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ) : '';
+				$other_val = isset( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ) : '';
 			} else {
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 
 			return $other_val;
@@ -1559,8 +1559,8 @@ 
 		if ( $field['type'] === 'checkbox' && is_array( $field['value'] ) ) {
 			// Check if there is an "other" val in saved value and make sure the
 			// "other" val is not equal to the Other checkbox option
-			if ( isset( $field['value'][ $opt_key ] ) && $field['options'][ $opt_key ] != $field['value'][ $opt_key ] ) {
-				$other_val = $field['value'][ $opt_key ];
+			if ( isset( $field['value'][$opt_key] ) && $field['options'][$opt_key] != $field['value'][$opt_key] ) {
+				$other_val = $field['value'][$opt_key];
 			}
 		} else {
 			/**
@@ -1572,8 +1572,8 @@ 
 				// Multi-select dropdowns - key is not preserved
 				if ( is_array( $field['value'] ) ) {
 					$o_key = array_search( $temp_val, $field['value'] );
-					if ( isset( $field['value'][ $o_key ] ) ) {
-						unset( $field['value'][ $o_key ], $o_key );
+					if ( isset( $field['value'][$o_key] ) ) {
+						unset( $field['value'][$o_key], $o_key );
 					}
 				} elseif ( $temp_val == $field['value'] ) {
 					// For radio and regular dropdowns
@@ -1798,11 +1798,11 @@ 
 			foreach ( $val as $k => $v ) {
 				if ( is_string( $v ) ) {
 					if ( 'custom_html' === $k ) {
-						$val[ $k ] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
+						$val[$k] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
 						unset( $k, $v );
 						continue;
 					}
-					$val[ $k ] = str_replace( $replace, $replace_with, $v );
+					$val[$k] = str_replace( $replace, $replace_with, $v );
 					unset( $k, $v );
 				}
 			}
@@ -1831,8 +1831,8 @@ 
 			if ( false === $index ) {
 				continue;
 			}
-			unset( $replace[ $index ] );
-			unset( $replace_with[ $index ] );
+			unset( $replace[$index] );
+			unset( $replace_with[$index] );
 		}
 		$value = str_replace( $replace, $replace_with, $value );
 		return $value;
@@ -2190,7 +2190,7 @@ 
 			$countries['class'] = 'frm-countries-opts';
 		}
 
-		$prepop[ __( 'Countries', 'formidable' ) ] = $countries;
+		$prepop[__( 'Countries', 'formidable' )] = $countries;
 
 		// State abv.
 		$states    = self::get_us_states();
@@ -2200,7 +2200,7 @@ 
 			$state_abv['class'] = 'frm-state-abv-opts';
 		}
 
-		$prepop[ __( 'U.S. State Abbreviations', 'formidable' ) ] = $state_abv;
+		$prepop[__( 'U.S. State Abbreviations', 'formidable' )] = $state_abv;
 
 		// States.
 		$states = array_values( $states );
@@ -2209,7 +2209,7 @@ 
 			$states['class'] = 'frm-states-opts';
 		}
 
-		$prepop[ __( 'U.S. States', 'formidable' ) ] = $states;
+		$prepop[__( 'U.S. States', 'formidable' )] = $states;
 		unset( $state_abv, $states );
 
 		// Age.
@@ -2227,7 +2227,7 @@ 
 			$ages['class'] = 'frm-age-opts';
 		}
 
-		$prepop[ __( 'Age', 'formidable' ) ] = $ages;
+		$prepop[__( 'Age', 'formidable' )] = $ages;
 
 		// Satisfaction.
 		$satisfaction = array(
@@ -2242,7 +2242,7 @@ 
 			$satisfaction['class'] = 'frm-satisfaction-opts';
 		}
 
-		$prepop[ __( 'Satisfaction', 'formidable' ) ] = $satisfaction;
+		$prepop[__( 'Satisfaction', 'formidable' )] = $satisfaction;
 
 		// Importance.
 		$importance = array(
@@ -2257,7 +2257,7 @@ 
 			$importance['class'] = 'frm-importance-opts';
 		}
 
-		$prepop[ __( 'Importance', 'formidable' ) ] = $importance;
+		$prepop[__( 'Importance', 'formidable' )] = $importance;
 
 		// Agreement.
 		$agreement = array(
@@ -2272,7 +2272,7 @@ 
 			$agreement['class'] = 'frm-agreement-opts';
 		}
 
-		$prepop[ __( 'Agreement', 'formidable' ) ] = $agreement;
+		$prepop[__( 'Agreement', 'formidable' )] = $agreement;
 
 		// Likely.
 		$likely = array(
@@ -2287,7 +2287,7 @@ 
 			$likely['class'] = 'frm-likely-opts';
 		}
 
-		$prepop[ __( 'Likely', 'formidable' ) ] = $likely;
+		$prepop[__( 'Likely', 'formidable' )] = $likely;
 
 		$prepop = apply_filters( 'frm_bulk_field_choices', $prepop );
 	}
@@ -2516,16 +2516,16 @@ 
 	 */
 	private static function fill_image_setting_options( $options, &$args ) {
 		foreach ( $options as $key => $option ) {
-			$args['options'][ $key ] = $option;
+			$args['options'][$key] = $option;
 
 			if ( ! empty( $option['addon'] ) ) {
-				$args['options'][ $key ]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
+				$args['options'][$key]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
 			}
 
-			unset( $args['options'][ $key ]['addon'] );
+			unset( $args['options'][$key]['addon'] );
 			$fill = array( 'upgrade', 'message', 'content' );
 			foreach ( $fill as $f ) {
-				unset( $args['options'][ $key ][ $f ], $f );
+				unset( $args['options'][$key][$f], $f );
 			}
 		}
 	}
@@ -2548,8 +2548,8 @@ 
 
 		$fill = array( 'upgrade', 'message', 'content' );
 		foreach ( $fill as $f ) {
-			if ( isset( $option[ $f ] ) ) {
-				$custom_attrs[ 'data-' . $f ] = $option[ $f ];
+			if ( isset( $option[$f] ) ) {
+				$custom_attrs['data-' . $f] = $option[$f];
 			}
 		}
 
@@ -2615,7 +2615,7 @@ 
 
 		return array_filter(
 			$rows,
-			function ( $row ) {
+			function( $row ) {
 				FrmAppHelper::unserialize_or_decode( $row->field_options );
 				return is_array( $row->field_options ) && ! empty( $row->field_options['draft'] );
 			}
@@ -2680,7 +2680,7 @@ 
 		if ( empty( $attributes['data-fid'] ) ) {
 			unset( $data['plugin-status'] );
 			foreach ( $data as $key => $value ) {
-				$attributes[ 'data-' . $key ] = $value;
+				$attributes['data-' . $key] = $value;
 			}
 		}
 

Braces +8 added lines, -4 removed lines

@@ -231,7 +231,8 @@ 
 				return false;
 			}
 
-			if ( ! $_POST || ! isset( $_POST['field_options'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( ! $_POST || ! isset( $_POST['field_options'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				return false;
 			}
 
@@ -338,7 +339,8 @@ 
 	 * @return void
 	 */
 	private static function get_posted_field_setting( $setting, &$value ) {
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( ! isset( $_POST['field_options'][ $setting ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return;
 		}
 
@@ -1531,7 +1533,8 @@ 
 
 		// Check posted vals before checking saved values
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
@@ -1542,7 +1545,8 @@ 
 			return $other_val;
 		}
 
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			// For normal fields
 
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {

classes/models/FrmFieldFormHtml.php

Spacing +13 added lines, -13 removed lines

@@ -46,8 +46,8 @@ 
 	 * @return void
 	 */
 	private function _set( $param, $atts ) {
-		if ( isset( $atts[ $param ] ) ) {
-			$this->{$param} = $atts[ $param ];
+		if ( isset( $atts[$param] ) ) {
+			$this->{$param} = $atts[$param];
 		}
 	}
 
@@ -97,8 +97,8 @@ 
 
 		$exclude = array( 'field_obj', 'html' );
 		foreach ( $exclude as $ex ) {
-			if ( isset( $atts[ $ex ] ) ) {
-				unset( $this->pass_args[ $ex ] );
+			if ( isset( $atts[$ex] ) ) {
+				unset( $this->pass_args[$ex] );
 			}
 		}
 	}
@@ -112,8 +112,8 @@ 
 	 * @return void
 	 */
 	private function set_from_field( $atts, $set ) {
-		if ( isset( $atts[ $set['param'] ] ) ) {
-			$this->{$set['param']} = $atts[ $set['param'] ];
+		if ( isset( $atts[$set['param']] ) ) {
+			$this->{$set['param']} = $atts[$set['param']];
 		} else {
 			$this->{$set['param']} = $this->field_obj->get_field_column( $set['default'] );
 		}
@@ -264,7 +264,7 @@ 
 	 */
 	private function replace_error_shortcode() {
 		$this->maybe_add_error_id();
-		$error = $this->pass_args['errors'][ 'field' . $this->field_id ] ?? false;
+		$error = $this->pass_args['errors']['field' . $this->field_id] ?? false;
 
 		if ( ! empty( $error ) && false === strpos( $this->html, 'role="alert"' ) && FrmAppHelper::should_include_alert_role_on_field_errors() ) {
 			$error_body = self::get_error_body( $this->html );
@@ -307,7 +307,7 @@ 
 	 * @return void
 	 */
 	private function maybe_add_error_id() {
-		if ( ! isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
+		if ( ! isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
 			return;
 		}
 
@@ -399,7 +399,7 @@ 
 		preg_match_all( "/\[(input|deletelink)\b(.*?)(?:(\/))?\]/s", $this->html, $shortcodes, PREG_PATTERN_ORDER );
 
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
-			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
+			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
 			$tag            = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
 
 			$replace_with = '';
@@ -410,7 +410,7 @@ 
 				$replace_with = $this->replace_input_shortcode( $shortcode_atts );
 			}
 
-			$this->html = str_replace( $shortcodes[0][ $short_key ], $replace_with, $this->html );
+			$this->html = str_replace( $shortcodes[0][$short_key], $replace_with, $this->html );
 		}
 	}
 
@@ -432,7 +432,7 @@ 
 	 */
 	private function prepare_input_shortcode_atts( $shortcode_atts ) {
 		if ( isset( $shortcode_atts['opt'] ) ) {
-			--$shortcode_atts['opt'];
+			-- $shortcode_atts['opt'];
 		}
 
 		$field_class = $shortcode_atts['class'] ?? '';
@@ -502,7 +502,7 @@ 
 	 */
 	private function get_field_div_classes() {
 		// Add error class
-		$classes = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? ' frm_blank_field' : '';
+		$classes = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? ' frm_blank_field' : '';
 
 		// Add label position class
 		$settings = $this->field_obj->display_field_settings();
@@ -583,7 +583,7 @@ 
 		}
 
 		// Add 'aria-invalid' attribute to the group if there are errors.
-		if ( isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
+		if ( isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
 			$attributes['aria-invalid'] = 'true';
 		}
 

classes/models/fields/FrmFieldType.php

Spacing +22 added lines, -22 removed lines

@@ -160,8 +160,8 @@ 
 		$field_val = '';
 		if ( is_object( $this->field ) ) {
 			$field_val = $this->field->{$column};
-		} elseif ( is_array( $this->field ) && isset( $this->field[ $column ] ) ) {
-			$field_val = $this->field[ $column ];
+		} elseif ( is_array( $this->field ) && isset( $this->field[$column] ) ) {
+			$field_val = $this->field[$column];
 		}
 
 		return $field_val;
@@ -177,7 +177,7 @@ 
 		if ( is_object( $this->field ) ) {
 			$this->field->{$column} = $value;
 		} elseif ( is_array( $this->field ) ) {
-			$this->field[ $column ] = $value;
+			$this->field[$column] = $value;
 		}
 	}
 
@@ -723,7 +723,7 @@ 
 			printf(
 				/* translators: %s: Field type */
 				esc_html__( '%s Options', 'formidable' ),
-				esc_html( $all_field_types[ $args['display']['type'] ]['name'] )
+				esc_html( $all_field_types[$args['display']['type']]['name'] )
 			);
 			FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown8_icon', array( 'aria-hidden' => 'true' ) );
 			?>
@@ -832,7 +832,7 @@ 
 	 * @return array
 	 */
 	public function get_new_field_defaults() {
-		$field        = array(
+		$field = array(
 			'name'          => $this->get_new_field_name(),
 			'description'   => '',
 			'type'          => $this->type,
@@ -863,8 +863,8 @@ 
 
 		$fields = array_merge( $fields, $pro_fields );
 
-		if ( isset( $fields[ $this->type ] ) ) {
-			$name = is_array( $fields[ $this->type ] ) ? $fields[ $this->type ]['name'] : $fields[ $this->type ];
+		if ( isset( $fields[$this->type] ) ) {
+			$name = is_array( $fields[$this->type] ) ? $fields[$this->type]['name'] : $fields[$this->type];
 		}
 
 		return $name;
@@ -881,7 +881,7 @@ 
 	 * @return array
 	 */
 	public function get_default_field_options() {
-		$opts        = array(
+		$opts = array(
 			'size'               => '',
 			'max'                => '',
 			'label'              => '',
@@ -1135,7 +1135,7 @@ 
 	 * @return void
 	 */
 	public function set_aria_invalid_error( &$shortcode_atts, $args ) {
-		$shortcode_atts['aria-invalid'] = isset( $args['errors'][ 'field' . $this->field_id ] ) ? 'true' : 'false';
+		$shortcode_atts['aria-invalid'] = isset( $args['errors']['field' . $this->field_id] ) ? 'true' : 'false';
 	}
 
 	/**
@@ -1316,11 +1316,11 @@ 
 		}
 
 		$options = array_values( $this->field['options'] );
-		if ( ! isset( $options[ $opt ] ) ) {
+		if ( ! isset( $options[$opt] ) ) {
 			return $hidden;
 		}
 
-		$option = $options[ $opt ];
+		$option = $options[$opt];
 		if ( is_array( $option ) ) {
 			$option = $option['value'];
 		}
@@ -1403,8 +1403,8 @@ 
 		$selected = $values['field_value'];
 
 		if ( isset( $values['combo_name'] ) ) {
-			$options  = $options[ $values['combo_name'] ];
-			$selected = is_array( $selected ) && isset( $selected[ $values['combo_name'] ] ) ? $selected[ $values['combo_name'] ] : '';
+			$options  = $options[$values['combo_name']];
+			$selected = is_array( $selected ) && isset( $selected[$values['combo_name']] ) ? $selected[$values['combo_name']] : '';
 		}
 
 		$input = $this->select_tag( $values );
@@ -1474,7 +1474,7 @@ 
 	 * @return array
 	 */
 	protected function fill_display_field_values( $args = array() ) {
-		$defaults        = array(
+		$defaults = array(
 			'field_name'    => 'item_meta[' . $this->get_field_column( 'id' ) . ']',
 			'field_id'      => $this->get_field_column( 'id' ),
 			'field_plus_id' => '',
@@ -1536,7 +1536,7 @@ 
 			}
 		}
 
-		if ( isset( $args['errors'][ 'field' . $args['field_id'] ] ) && ! $custom_error_fields ) {
+		if ( isset( $args['errors']['field' . $args['field_id']] ) && ! $custom_error_fields ) {
 			if ( $error_comes_first ) {
 				array_unshift( $describedby, 'frm_error_' . $args['html_id'] );
 			} else {
@@ -1618,11 +1618,11 @@ 
 
 		$field_id = $this->get_field_column( 'id' );
 		if ( ! array_key_exists( $field_id, $frm_validated_unique_values ) ) {
-			$frm_validated_unique_values[ $field_id ] = array();
+			$frm_validated_unique_values[$field_id] = array();
 			return false;
 		}
 
-		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[ $field_id ], true );
+		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[$field_id], true );
 		return $already_validated_this_value;
 	}
 
@@ -1649,7 +1649,7 @@ 
 	private function value_validated_as_unique( $value ) {
 		global $frm_validated_unique_values;
 		$field_id                                   = $this->get_field_column( 'id' );
-		$frm_validated_unique_values[ $field_id ][] = $value;
+		$frm_validated_unique_values[$field_id][] = $value;
 	}
 
 	/**
@@ -1694,8 +1694,8 @@ 
 		$value = $this->prepare_display_value( $value, $atts );
 
 		if ( is_array( $value ) ) {
-			if ( ! empty( $atts['show'] ) && isset( $value[ $atts['show'] ] ) ) {
-				$value = $value[ $atts['show'] ];
+			if ( ! empty( $atts['show'] ) && isset( $value[$atts['show']] ) ) {
+				$value = $value[$atts['show']];
 			} elseif ( empty( $atts['return_array'] ) ) {
 				$sep   = $atts['sep'] ?? ', ';
 				$value = FrmAppHelper::safe_implode( $sep, $value );
@@ -1825,8 +1825,8 @@ 
 		$saved_entries = $atts['ids'];
 		$new_value     = array();
 		foreach ( (array) $value as $old_child_id ) {
-			if ( isset( $saved_entries[ $old_child_id ] ) ) {
-				$new_value[] = $saved_entries[ $old_child_id ];
+			if ( isset( $saved_entries[$old_child_id] ) ) {
+				$new_value[] = $saved_entries[$old_child_id];
 			}
 		}
 

classes/models/FrmEntryFormatter.php

Spacing +7 added lines, -7 removed lines

@@ -169,8 +169,8 @@ 
 
 		$conditionally_add = array( 'include_fields', 'fields', 'exclude_fields', 'entry' );
 		foreach ( $conditionally_add as $index ) {
-			if ( isset( $atts[ $index ] ) ) {
-				$entry_atts[ $index ] = $atts[ $index ];
+			if ( isset( $atts[$index] ) ) {
+				$entry_atts[$index] = $atts[$index];
 			}
 		}
 
@@ -376,8 +376,8 @@ 
 
 		$unset = array( 'id', 'form_id', 'format' );
 		foreach ( $unset as $param ) {
-			if ( isset( $atts[ $param ] ) ) {
-				unset( $atts[ $param ] );
+			if ( isset( $atts[$param] ) ) {
+				unset( $atts[$param] );
 			}
 		}
 
@@ -553,11 +553,11 @@ 
 
 			$displayed_value = $this->prepare_display_value_for_array( $field_value->get_displayed_value() );
 
-			$output[ $this->get_key_or_id( $field_value ) ] = $displayed_value;
+			$output[$this->get_key_or_id( $field_value )] = $displayed_value;
 
 			$has_separate_value = (bool) $field_value->get_field_option( 'separate_value' );
 			if ( $has_separate_value || $displayed_value !== $field_value->get_saved_value() ) {
-				$output[ $this->get_key_or_id( $field_value ) . '-value' ] = $field_value->get_saved_value();
+				$output[$this->get_key_or_id( $field_value ) . '-value'] = $field_value->get_saved_value();
 			}
 		}
 	}
@@ -975,7 +975,7 @@ 
 		if ( $this->is_plain_text ) {
 			if ( is_array( $value ) ) {
 				foreach ( $value as $key => $single_value ) {
-					$value[ $key ] = $this->strip_html( $single_value );
+					$value[$key] = $this->strip_html( $single_value );
 				}
 			} elseif ( $this->is_plain_text && ! is_array( $value ) ) {
 				if ( strpos( $value, '<img' ) !== false ) {