Strategy11 / formidable-forms

classes/controllers/FrmFormsController.php

Braces +4 added lines, -2 removed lines

@@ -1889,7 +1889,8 @@ 
 		$action = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action';
 		$vars   = array();
 		FrmAppHelper::include_svg();
-		if ( isset( $_POST['frm_compact_fields'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $_POST['frm_compact_fields'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::permission_check( 'frm_edit_forms' );
 
 			// Javascript needs to be allowed in some field settings.
@@ -2314,7 +2315,8 @@ 
 	private static function get_saved_errors( $form, $params ) {
 		global $frm_vars;
 
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
 		} else {
 			$errors = array();

Spacing +34 added lines, -34 removed lines

@@ -438,7 +438,7 @@ 
 		if ( FrmTestModeController::should_add_test_mode_container() ) {
 			add_action(
 				'wp_enqueue_scripts',
-				function () {
+				function() {
 					// Enqueue multiselect dropdown requirements.
 					$plugin_url = FrmAppHelper::plugin_url();
 					$version    = FrmAppHelper::plugin_version();
@@ -741,7 +741,7 @@ 
 			 * @param string|null $src
 			 * @return string
 			 */
-			function ( $src ) {
+			function( $src ) {
 				if ( is_null( $src ) ) {
 					$src = '';
 				}
@@ -806,11 +806,11 @@ 
 			),
 		);
 
-		if ( ! isset( $available_status[ $status ] ) ) {
+		if ( ! isset( $available_status[$status] ) ) {
 			return;
 		}
 
-		FrmAppHelper::permission_check( $available_status[ $status ]['permission'] );
+		FrmAppHelper::permission_check( $available_status[$status]['permission'] );
 
 		$params = FrmForm::list_page_params();
 
@@ -818,8 +818,8 @@ 
 		check_admin_referer( $status . '_form_' . $params['id'] );
 
 		$count = 0;
-		if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
-			++$count;
+		if ( FrmForm::set_status( $params['id'], $available_status[$status]['new_status'] ) ) {
+			++ $count;
 		}
 
 		$form_type = FrmAppHelper::get_simple_request(
@@ -835,7 +835,7 @@ 
 		/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 		$available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
 
-		$message = $available_status[ $status ]['message'];
+		$message = $available_status[$status]['message'];
 
 		self::display_forms_list( $params, $message );
 	}
@@ -850,7 +850,7 @@ 
 		$count = 0;
 		foreach ( $ids as $id ) {
 			if ( FrmForm::trash( $id ) ) {
-				++$count;
+				++ $count;
 			}
 		}
 
@@ -864,7 +864,7 @@ 
 				'type'  => 'request',
 			)
 		);
-		$message      = sprintf(
+		$message = sprintf(
 			/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 			_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
 			$count,
@@ -885,7 +885,7 @@ 
 
 		$count = 0;
 		if ( FrmForm::destroy( $params['id'] ) ) {
-			++$count;
+			++ $count;
 		}
 
 		/* translators: %1$s: Number of forms */
@@ -905,7 +905,7 @@ 
 		foreach ( $ids as $id ) {
 			$d = FrmForm::destroy( $id );
 			if ( $d ) {
-				++$count;
+				++ $count;
 			}
 		}
 
@@ -1406,7 +1406,7 @@ 
 
 		add_action(
 			'wp_enqueue_editor',
-			function () {
+			function() {
 				wp_print_media_templates();
 			}
 		);
@@ -1515,7 +1515,7 @@ 
 
 		foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
 			if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
-				unset( $sections[ $feature ] );
+				unset( $sections[$feature] );
 			}
 		}
 
@@ -1543,7 +1543,7 @@ 
 				$section['id'] = $section['anchor'];
 			}
 
-			$sections[ $key ] = $section;
+			$sections[$key] = $section;
 		}//end foreach
 
 		return $sections;
@@ -1666,7 +1666,7 @@ 
 		if ( $user_fields ) {
 			$user_helpers = array();
 			foreach ( $user_fields as $uk => $uf ) {
-				$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
+				$user_helpers['|user_id| show="' . $uk . '"'] = $uf;
 				unset( $uk, $uf );
 			}
 
@@ -1800,7 +1800,7 @@ 
 		if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
 			$frm_vars['js_validate_forms'] = array();
 		}
-		$frm_vars['js_validate_forms'][ $form->id ] = $form;
+		$frm_vars['js_validate_forms'][$form->id] = $form;
 	}
 
 	public static function get_email_html() {
@@ -1984,7 +1984,7 @@ 
 				add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
 			} else {
 				$vars   = FrmAppHelper::json_to_array( $json_vars );
-				$action = $vars[ $action ];
+				$action = $vars[$action];
 				unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_POST    = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -2147,7 +2147,7 @@ 
 		$actions = array();
 		foreach ( $frm_vars['forms_loaded'] as $form ) {
 			if ( is_object( $form ) ) {
-				$actions[ $form->id ] = $form->name;
+				$actions[$form->id] = $form->name;
 			}
 			unset( $form );
 		}
@@ -2392,8 +2392,8 @@ 
 	private static function get_saved_errors( $form, $params ) {
 		global $frm_vars;
 
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$errors = $frm_vars['created_entries'][$form->id]['errors'];
 		} else {
 			$errors = array();
 		}
@@ -2415,7 +2415,7 @@ 
 	public static function just_created_entry( $form_id ) {
 		global $frm_vars;
 
-		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
+		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][$form_id] ) && isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ? $frm_vars['created_entries'][$form_id]['entry_id'] : 0;
 	}
 
 	/**
@@ -2435,7 +2435,7 @@ 
 	private static function get_confirmation_method( $atts ) {
 		$action = FrmOnSubmitHelper::current_event( $atts );
 		$opt    = 'update' === $action ? 'edit_action' : 'success_action';
-		$method = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
+		$method = ! empty( $atts['form']->options[$opt] ) ? $atts['form']->options[$opt] : 'message';
 
 		if ( ! empty( $atts['entry_id'] ) ) {
 			$met_actions = self::get_met_on_submit_actions( $atts, $action );
@@ -2456,7 +2456,7 @@ 
 	public static function maybe_trigger_redirect( $form, $params, $args ) {
 		if ( ! isset( $params['id'] ) ) {
 			global $frm_vars;
-			$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
+			$params['id'] = $frm_vars['created_entries'][$form->id]['entry_id'];
 		}
 
 		$conf_method = self::get_confirmation_method(
@@ -2538,7 +2538,7 @@ 
 		$args['success_opt'] = $opt;
 		$args['ajax']        = ! empty( $frm_vars['ajax'] );
 
-		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[ $opt . '_page_id' ] ) ) {
+		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[$opt . '_page_id'] ) ) {
 			self::load_page_after_submit( $args );
 		} elseif ( $args['conf_method'] === 'redirect' ) {
 			self::redirect_after_submit( $args );
@@ -2562,7 +2562,7 @@ 
 		}
 
 		// If a redirect action has already opened the URL in a new tab, we show the default message in the current tab.
-		if ( ! empty( self::$redirected_in_new_tab[ $args['form']->id ] ) ) {
+		if ( ! empty( self::$redirected_in_new_tab[$args['form']->id] ) ) {
 			return array( FrmOnSubmitHelper::get_fallback_action_after_open_in_new_tab( $event ) );
 		}
 
@@ -2750,7 +2750,7 @@ 
 
 		$opt = 'update' === $args['action'] ? 'edit_' : 'success_';
 
-		$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
+		$new_args['conf_method'] = $new_args['form']->options[$opt . 'action'];
 
 		/**
 		 * Filters the run success action args.
@@ -2770,8 +2770,8 @@ 
 	private static function load_page_after_submit( $args ) {
 		global $post;
 		$opt = $args['success_opt'];
-		if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
-			$page     = get_post( $args['form']->options[ $opt . '_page_id' ] );
+		if ( ! $post || $args['form']->options[$opt . '_page_id'] != $post->ID ) {
+			$page     = get_post( $args['form']->options[$opt . '_page_id'] );
 			$old_post = $post;
 			$post     = $page;
 			$content  = apply_filters( 'frm_content', $page->post_content, $args['form'], $args['entry_id'] );
@@ -2801,7 +2801,7 @@ 
 		add_filter( 'frm_use_wpautop', '__return_false' );
 
 		$opt         = $args['success_opt'];
-		$success_url = trim( $args['form']->options[ $opt . '_url' ] );
+		$success_url = trim( $args['form']->options[$opt . '_url'] );
 		$success_url = apply_filters( 'frm_content', $success_url, $args['form'], $args['entry_id'] );
 		$success_url = do_shortcode( $success_url );
 
@@ -2823,7 +2823,7 @@ 
 			// Not AJAX submit, no headers sent, and there is just one Redirect action runs.
 			if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
 				self::print_open_in_new_tab_js_with_fallback_handler( $success_url, $args );
-				self::$redirected_in_new_tab[ $args['form']->id ] = 1;
+				self::$redirected_in_new_tab[$args['form']->id] = 1;
 				return;
 			}
 
@@ -3103,7 +3103,7 @@ 
 			'description' => false,
 			'reset'       => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 	}
 
 	/**
@@ -3141,7 +3141,7 @@ 
 		$opt          = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
 
 		if ( $entry_id && is_numeric( $entry_id ) ) {
-			$message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
+			$message = isset( $form->options[$opt . '_msg'] ) ? $form->options[$opt . '_msg'] : $frm_settings->success_msg;
 			$class   = 'frm_message';
 		} else {
 			$message = $frm_settings->failed_msg;
@@ -3366,8 +3366,8 @@ 
 
 		check_ajax_referer( 'frm_ajax', 'nonce' );
 
-		$html             = FrmAppHelper::clip(
-			function () {
+		$html = FrmAppHelper::clip(
+			function() {
 				FrmAppHelper::maybe_autocomplete_pages_options(
 					array(
 						'field_name'  => 'frm_page_dropdown',

classes/helpers/FrmFieldGdprHelper.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 	 * @return array
 	 */
 	public static function add_gdpr_field( $fields ) {
-		$fields[ self::FIELD_TYPE ] = array(
+		$fields[self::FIELD_TYPE] = array(
 			'name' => __( 'GDPR', 'formidable' ),
 			'icon' => 'frm_icon_font frm-gdpr-icon',
 		);

classes/controllers/FrmAppController.php

Spacing +4 added lines, -4 removed lines

@@ -1356,15 +1356,15 @@ 
 		global $wp_filter;
 
 		foreach ( $actions as $action ) {
-			if ( empty( $wp_filter[ $action ]->callbacks ) ) {
+			if ( empty( $wp_filter[$action]->callbacks ) ) {
 				continue;
 			}
-			foreach ( $wp_filter[ $action ]->callbacks as $priority => $callbacks ) {
+			foreach ( $wp_filter[$action]->callbacks as $priority => $callbacks ) {
 				foreach ( $callbacks as $callback_name => $callback ) {
 					if ( self::is_our_callback_string( $callback_name ) || self::is_our_callback_array( $callback ) ) {
 						continue;
 					}
-					unset( $wp_filter[ $action ]->callbacks[ $priority ][ $callback_name ] );
+					unset( $wp_filter[$action]->callbacks[$priority][$callback_name] );
 				}
 			}
 		}
@@ -1376,7 +1376,7 @@ 
 	 * @return void
 	 */
 	private static function remember_custom_sort() {
-		$screen  = get_current_screen();
+		$screen = get_current_screen();
 		if ( ! $screen ) {
 			return;
 		}

classes/factories/FrmFieldFactory.php

Spacing +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
 			FrmFieldGdprHelper::FIELD_TYPE => FrmFieldGdprHelper::get_gdpr_field_class( $field_type ),
 		);
 
-		$class = isset( $type_classes[ $field_type ] ) ? $type_classes[ $field_type ] : '';
+		$class = isset( $type_classes[$field_type] ) ? $type_classes[$field_type] : '';
 
 		return apply_filters( 'frm_get_field_type_class', $class, $field_type );
 	}

classes/models/FrmField.php

Spacing +36 added lines, -36 removed lines

@@ -309,8 +309,8 @@ 
 			require_once ABSPATH . 'wp-admin/includes/plugin.php';
 		}
 		$plugins = get_plugins();
-		if ( isset( $plugins[ $plugin ] ) && ! empty( $plugins[ $plugin ]['Version'] ) ) {
-			return $plugins[ $plugin ]['Version'];
+		if ( isset( $plugins[$plugin] ) && ! empty( $plugins[$plugin]['Version'] ) ) {
+			return $plugins[$plugin]['Version'];
 		}
 		return false;
 	}
@@ -383,8 +383,8 @@ 
 		$values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
 
 		foreach ( array( 'name', 'description', 'type', 'default_value' ) as $col ) {
-			if ( isset( $values[ $col ] ) ) {
-				$new_values[ $col ] = $values[ $col ];
+			if ( isset( $values[$col] ) ) {
+				$new_values[$col] = $values[$col];
 			}
 		}
 
@@ -396,7 +396,7 @@ 
 		$new_values['created_at']    = current_time( 'mysql', 1 );
 
 		if ( isset( $values['id'] ) ) {
-			$frm_duplicate_ids[ $values['field_key'] ] = $new_values['field_key'];
+			$frm_duplicate_ids[$values['field_key']] = $new_values['field_key'];
 			$new_values                                = apply_filters( 'frm_duplicated_field', $new_values );
 		}
 
@@ -405,9 +405,9 @@ 
 		foreach ( $new_values as $k => $v ) {
 			if ( is_array( $v ) ) {
 				if ( $k === 'default_value' ) {
-					$new_values[ $k ] = FrmAppHelper::maybe_json_encode( $v );
+					$new_values[$k] = FrmAppHelper::maybe_json_encode( $v );
 				} else {
-					$new_values[ $k ] = serialize( $v );
+					$new_values[$k] = serialize( $v );
 				}
 			}
 			unset( $k, $v );
@@ -427,7 +427,7 @@ 
 		}
 
 		if ( isset( $values['id'] ) ) {
-			$frm_duplicate_ids[ $values['id'] ] = $new_id;
+			$frm_duplicate_ids[$values['id']] = $new_id;
 		}
 
 		return $new_id;
@@ -478,7 +478,7 @@ 
 			 * @param array $match Shortcode data.
 			 * @return string
 			 */
-			function ( $match ) {
+			function( $match ) {
 				$attr = shortcode_parse_atts( $match[3] );
 
 				if ( ! is_array( $attr ) ) {
@@ -503,7 +503,7 @@ 
 					}
 
 					if ( FrmAppHelper::input_key_is_safe( $key, 'update' ) ) {
-						$safe_atts[ $key ] = $value;
+						$safe_atts[$key] = $value;
 					}
 				}
 
@@ -561,7 +561,7 @@ 
 	public static function duplicate( $old_form_id, $form_id, $copy_keys = false, $blog_id = false ) {
 		global $frm_duplicate_ids;
 
-		$where  = array(
+		$where = array(
 			array(
 				'or'                => 1,
 				'fi.form_id'        => $old_form_id,
@@ -607,8 +607,8 @@ 
 
 			$values                                 = apply_filters( 'frm_duplicated_field', $values );
 			$new_id                                 = self::create( $values );
-			$frm_duplicate_ids[ $field->id ]        = $new_id;
-			$frm_duplicate_ids[ $field->field_key ] = $new_id;
+			$frm_duplicate_ids[$field->id]        = $new_id;
+			$frm_duplicate_ids[$field->field_key] = $new_id;
 			unset( $field );
 		}//end foreach
 	}
@@ -657,11 +657,11 @@ 
 
 		// serialize array values
 		foreach ( array( 'field_options', 'options' ) as $opt ) {
-			if ( isset( $values[ $opt ] ) && is_array( $values[ $opt ] ) ) {
+			if ( isset( $values[$opt] ) && is_array( $values[$opt] ) ) {
 				if ( 'field_options' === $opt ) {
-					$values[ $opt ] = self::maybe_filter_options( $values[ $opt ] );
+					$values[$opt] = self::maybe_filter_options( $values[$opt] );
 				}
-				$values[ $opt ] = serialize( $values[ $opt ] );
+				$values[$opt] = serialize( $values[$opt] );
 			}
 		}
 		if ( isset( $values['default_value'] ) && is_array( $values['default_value'] ) ) {
@@ -848,8 +848,8 @@ 
 					continue;
 				}
 
-				$fields[ $result->id ] = $result;
-				++$count;
+				$fields[$result->id] = $result;
+				++ $count;
 				if ( $limit == 1 ) {
 					$fields = $result;
 					break;
@@ -900,8 +900,8 @@ 
 			$fields = array();
 			$count  = 0;
 			foreach ( $results as $result ) {
-				++$count;
-				$fields[ $result->id ] = $result;
+				++ $count;
+				$fields[$result->id] = $result;
 				if ( ! empty( $limit ) && $count >= $limit ) {
 					break;
 				}
@@ -1015,7 +1015,7 @@ 
 		$query_type = $limit === ' LIMIT 1' || $limit == 1 ? 'row' : 'results';
 
 		if ( is_array( $where ) ) {
-			$args    = array(
+			$args = array(
 				'order_by' => $order_by,
 				'limit'    => $limit,
 			);
@@ -1048,9 +1048,9 @@ 
 				FrmDb::set_cache( $result->field_key, $result, 'frm_field' );
 
 				self::prepare_options( $result );
-				$results[ $r_key ]->field_options = $result->field_options;
-				$results[ $r_key ]->options       = $result->options;
-				$results[ $r_key ]->default_value = $result->default_value;
+				$results[$r_key]->field_options = $result->field_options;
+				$results[$r_key]->options       = $result->options;
+				$results[$r_key]->default_value = $result->default_value;
 
 				unset( $r_key, $result );
 			}
@@ -1129,7 +1129,7 @@ 
 
 			if ( count( $next_fields ) >= self::$transient_size ) {
 				// if this transient is full, check for another
-				++$next;
+				++ $next;
 				self::get_next_transient( $fields, $base_name, $next );
 			}
 		}
@@ -1157,7 +1157,7 @@ 
 				return;
 			}
 
-			++$next;
+			++ $next;
 		}
 	}
 
@@ -1305,7 +1305,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_true_in_array( $field, $option ) {
-		return ! empty( $field[ $option ] );
+		return ! empty( $field[$option] );
 	}
 
 	/**
@@ -1314,7 +1314,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_true_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ];
+		return isset( $field->field_options[$option] ) && $field->field_options[$option];
 	}
 
 	/**
@@ -1323,7 +1323,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_empty_in_array( $field, $option ) {
-		return empty( $field[ $option ] );
+		return empty( $field[$option] );
 	}
 
 	/**
@@ -1332,7 +1332,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_empty_in_object( $field, $option ) {
-		return empty( $field->field_options[ $option ] );
+		return empty( $field->field_options[$option] );
 	}
 
 	/**
@@ -1341,7 +1341,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_value_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ] != '';
+		return isset( $field->field_options[$option] ) && $field->field_options[$option] != '';
 	}
 
 	/**
@@ -1367,10 +1367,10 @@ 
 	 * @return mixed
 	 */
 	public static function get_option_in_array( $field, $option ) {
-		if ( isset( $field[ $option ] ) ) {
-			$this_option = $field[ $option ];
-		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][ $option ] ) ) {
-			$this_option = $field['field_options'][ $option ];
+		if ( isset( $field[$option] ) ) {
+			$this_option = $field[$option];
+		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][$option] ) ) {
+			$this_option = $field['field_options'][$option];
 		} else {
 			$this_option = '';
 		}
@@ -1384,7 +1384,7 @@ 
 	 * @return mixed
 	 */
 	public static function get_option_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) ? $field->field_options[ $option ] : '';
+		return isset( $field->field_options[$option] ) ? $field->field_options[$option] : '';
 	}
 
 	/**

classes/controllers/FrmFormTemplatesController.php

Spacing +12 added lines, -14 removed lines

@@ -322,11 +322,11 @@ 
 
 		// Perform add or remove operation.
 		if ( 'add' === $operation ) {
-			self::$favorite_templates[ $key ][] = $template_id;
+			self::$favorite_templates[$key][] = $template_id;
 		} elseif ( 'remove' === $operation ) {
-			$position = array_search( $template_id, self::$favorite_templates[ $key ], true );
+			$position = array_search( $template_id, self::$favorite_templates[$key], true );
 			if ( $position !== false ) {
-				unset( self::$favorite_templates[ $key ][ $position ] );
+				unset( self::$favorite_templates[$key][$position] );
 			}
 		}
 
@@ -455,7 +455,7 @@ 
 		foreach ( self::$templates as $key => &$template ) {
 			// Skip the template if the categories are not set.
 			if ( ! isset( $template['categories'] ) || ! isset( $template['id'] ) ) {
-				unset( self::$templates[ $key ] );
+				unset( self::$templates[$key] );
 				continue;
 			}
 
@@ -469,14 +469,12 @@ 
 				// Add the slug to the new array.
 				$template['category_slugs'][] = $category_slug;
 
-				if ( ! isset( self::$categories[ $category_slug ] ) ) {
-					self::$categories[ $category_slug ] = array(
+				if ( ! isset( self::$categories[$category_slug] ) ) {
+					self::$categories[$category_slug] = array(
 						'name'  => $category,
 						'count' => 0,
 					);
-				}
-
-				++self::$categories[ $category_slug ]['count'];
+				} ++self::$categories[$category_slug]['count'];
 			}
 
 			// Mark the template as favorite if it's in the favorite templates list.
@@ -491,7 +489,7 @@ 
 		$redundant_cats = array_merge( array( 'PayPal', 'Stripe', 'Twilio' ), FrmFormsHelper::get_license_types() );
 		foreach ( $redundant_cats as $redundant_cat ) {
 			$category_slug = sanitize_title( $redundant_cat );
-			unset( self::$categories[ $category_slug ] );
+			unset( self::$categories[$category_slug] );
 		}
 
 		// Sort the categories by keys alphabetically.
@@ -516,7 +514,7 @@ 
 				'count' => 0,
 			);
 		}
-		$special_categories['all-items']      = array(
+		$special_categories['all-items'] = array(
 			'name'  => __( 'All Templates', 'formidable' ),
 			'count' => self::get_template_count(),
 		);
@@ -539,9 +537,9 @@ 
 	 */
 	private static function assign_featured_templates() {
 		foreach ( self::FEATURED_TEMPLATES_KEYS as $key ) {
-			if ( isset( self::$templates[ $key ] ) ) {
-				self::$templates[ $key ]['is_featured'] = true;
-				self::$featured_templates[]             = self::$templates[ $key ];
+			if ( isset( self::$templates[$key] ) ) {
+				self::$templates[$key]['is_featured'] = true;
+				self::$featured_templates[]             = self::$templates[$key];
 			}
 		}
 	}

classes/models/fields/FrmFieldGdpr.php

Spacing +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
 
 			if ( ! $required && empty( $args['value'] ) ) {
 				$frm_settings                    = FrmAppHelper::get_settings();
-				$errors[ 'field' . $args['id'] ] = str_replace( '[field_name]', is_object( $this->field ) ? $this->field->name : $this->field['name'], $frm_settings->blank_msg );
+				$errors['field' . $args['id']] = str_replace( '[field_name]', is_object( $this->field ) ? $this->field->name : $this->field['name'], $frm_settings->blank_msg );
 			}
 		}
 

classes/models/FrmHoneypot.php

Spacing +1 added lines, -1 removed lines

@@ -208,7 +208,7 @@
 			return '';
 		}
 
-		return isset( $item_meta[ $field_id ] ) ? $item_meta[ $field_id ] : '';
+		return isset( $item_meta[$field_id] ) ? $item_meta[$field_id] : '';
 	}
 
 	/**

classes/models/FrmFormAction.php

Spacing +38 added lines, -38 removed lines

@@ -208,9 +208,9 @@ 
 		$groups = FrmFormActionsController::form_action_groups();
 		$group  = 'misc';
 
-		if ( isset( $action_options['group'] ) && isset( $groups[ $action_options['group'] ] ) ) {
+		if ( isset( $action_options['group'] ) && isset( $groups[$action_options['group']] ) ) {
 			$group = $action_options['group'];
-		} elseif ( isset( $groups[ $this->id_base ] ) ) {
+		} elseif ( isset( $groups[$this->id_base] ) ) {
 			$group = $this->id_base;
 		} else {
 			foreach ( $groups as $name => $check_group ) {
@@ -221,8 +221,8 @@ 
 			}
 		}
 
-		$groups[ $group ]['id'] = $group;
-		return $groups[ $group ];
+		$groups[$group]['id'] = $group;
+		return $groups[$group];
 	}
 
 	/**
@@ -333,7 +333,7 @@ 
 	 * @return int $post_id
 	 */
 	public function maybe_create_action( $action, $forms ) {
-		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[ $action['menu_order'] ] ) && $forms[ $action['menu_order'] ] === 'updated' ) {
+		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[$action['menu_order']] ) && $forms[$action['menu_order']] === 'updated' ) {
 			// Update action only
 			$action['post_content'] = FrmAppHelper::maybe_json_decode( $action['post_content'] );
 			$post_id                = $this->save_settings( $action );
@@ -356,18 +356,18 @@ 
 		$switch             = $this->get_global_switch_fields();
 
 		foreach ( (array) $action->post_content as $key => $val ) {
-			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[ $val ] ) ) {
-				$action->post_content[ $key ] = $frm_duplicate_ids[ $val ];
+			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[$val] ) ) {
+				$action->post_content[$key] = $frm_duplicate_ids[$val];
 			} elseif ( ! is_array( $val ) ) {
-				$action->post_content[ $key ] = FrmFieldsHelper::switch_field_ids( $val );
-			} elseif ( isset( $switch[ $key ] ) && is_array( $switch[ $key ] ) ) {
+				$action->post_content[$key] = FrmFieldsHelper::switch_field_ids( $val );
+			} elseif ( isset( $switch[$key] ) && is_array( $switch[$key] ) ) {
 				// loop through each value if empty
-				if ( empty( $switch[ $key ] ) ) {
-					$switch[ $key ] = array_keys( $val );
+				if ( empty( $switch[$key] ) ) {
+					$switch[$key] = array_keys( $val );
 				}
 
-				foreach ( $switch[ $key ] as $subkey ) {
-					$action->post_content[ $key ] = $this->duplicate_array_walk( $action->post_content[ $key ], $subkey, $val );
+				foreach ( $switch[$key] as $subkey ) {
+					$action->post_content[$key] = $this->duplicate_array_walk( $action->post_content[$key], $subkey, $val );
 				}
 			}
 
@@ -385,20 +385,20 @@ 
 			foreach ( $subkey as $subkey2 ) {
 				foreach ( (array) $val as $ck => $cv ) {
 					if ( is_array( $cv ) ) {
-						$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey2, $cv );
-					} elseif ( isset( $cv[ $subkey ] ) && is_numeric( $cv[ $subkey ] ) && isset( $frm_duplicate_ids[ $cv[ $subkey ] ] ) ) {
-						$action[ $ck ][ $subkey ] = $frm_duplicate_ids[ $cv[ $subkey ] ];
+						$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey2, $cv );
+					} elseif ( isset( $cv[$subkey] ) && is_numeric( $cv[$subkey] ) && isset( $frm_duplicate_ids[$cv[$subkey]] ) ) {
+						$action[$ck][$subkey] = $frm_duplicate_ids[$cv[$subkey]];
 					}
 				}
 			}
 		} else {
 			foreach ( (array) $val as $ck => $cv ) {
 				if ( is_array( $cv ) ) {
-					$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey, $cv );
-				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[ $cv ] ) ) {
-					$action[ $ck ] = $frm_duplicate_ids[ $cv ];
+					$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey, $cv );
+				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[$cv] ) ) {
+					$action[$ck] = $frm_duplicate_ids[$cv];
 				} elseif ( $ck == $subkey ) {
-					$action[ $ck ] = $this->maybe_switch_field_ids( $action[ $ck ] );
+					$action[$ck] = $this->maybe_switch_field_ids( $action[$ck] );
 				}
 			}
 		}//end if
@@ -422,10 +422,10 @@ 
 		}
 
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
-		if ( isset( $_POST[ $this->option_name ] ) && is_array( $_POST[ $this->option_name ] ) ) {
+		if ( isset( $_POST[$this->option_name] ) && is_array( $_POST[$this->option_name] ) ) {
 			// Sanitizing removes scripts and <email> type of values.
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
-			$settings = wp_unslash( $_POST[ $this->option_name ] );
+			$settings = wp_unslash( $_POST[$this->option_name] );
 		} else {
 			return;
 		}
@@ -435,7 +435,7 @@ 
 		foreach ( $settings as $number => $new_instance ) {
 			$this->_set( $number );
 
-			$old_instance = isset( $all_instances[ $number ] ) ? $all_instances[ $number ] : array();
+			$old_instance = isset( $all_instances[$number] ) ? $all_instances[$number] : array();
 
 			if ( ! isset( $new_instance['post_status'] ) ) {
 				$new_instance['post_status'] = 'draft';
@@ -474,7 +474,7 @@ 
 			$instance['post_content'] = apply_filters( 'frm_before_save_' . $this->id_base . '_action', $instance['post_content'], $instance, $new_instance, $old_instance, $this );
 
 			if ( false !== $instance ) {
-				$all_instances[ $number ] = $instance;
+				$all_instances[$number] = $instance;
 			}
 
 			$action_ids[] = $this->save_settings( $instance );
@@ -560,12 +560,12 @@ 
 			// some plugins/themes are formatting the post_excerpt
 			$action->post_excerpt = sanitize_title( $action->post_excerpt );
 
-			if ( ! isset( $action_controls[ $action->post_excerpt ] ) ) {
+			if ( ! isset( $action_controls[$action->post_excerpt] ) ) {
 				continue;
 			}
 
-			$action                  = $action_controls[ $action->post_excerpt ]->prepare_action( $action );
-			$settings[ $action->ID ] = $action;
+			$action                  = $action_controls[$action->post_excerpt]->prepare_action( $action );
+			$settings[$action->ID] = $action;
 
 			if ( count( $settings ) >= $limit ) {
 				break;
@@ -591,7 +591,7 @@ 
 	 * @return int The filtered limit value.
 	 */
 	public static function get_action_limit( $form_id, $limit = 99 ) {
-		$type  = 'all';
+		$type = 'all';
 		return (int) apply_filters( 'frm_form_action_limit', (int) $limit, compact( 'type', 'form_id' ) );
 	}
 
@@ -614,7 +614,7 @@ 
 			'limit'       => 99,
 			'post_status' => $default_status,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 	}
 
 	/**
@@ -684,7 +684,7 @@ 
 
 			$action = $this->prepare_action( $action );
 
-			$settings[ $action->ID ] = $action;
+			$settings[$action->ID] = $action;
 		}
 
 		if ( 1 === $limit ) {
@@ -727,10 +727,10 @@ 
 
 		foreach ( $default_values as $k => $vals ) {
 			if ( is_array( $vals ) && ! empty( $vals ) ) {
-				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[ $k ] ) ) {
+				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[$k] ) ) {
 					continue;
 				}
-				$action->post_content[ $k ] = wp_parse_args( $action->post_content[ $k ], $vals );
+				$action->post_content[$k] = wp_parse_args( $action->post_content[$k], $vals );
 			}
 		}
 
@@ -818,9 +818,9 @@ 
 
 		// fill with existing options
 		foreach ( $action->post_content as $name => $val ) {
-			if ( isset( $form->options[ $name ] ) ) {
-				$action->post_content[ $name ] = $form->options[ $name ];
-				unset( $form->options[ $name ] );
+			if ( isset( $form->options[$name] ) ) {
+				$action->post_content[$name] = $form->options[$name];
+				unset( $form->options[$name] );
 			}
 		}
 
@@ -906,8 +906,8 @@ 
 	private static function get_value_from_entry( $entry, $field_id ) {
 		$observed_value = '';
 
-		if ( isset( $entry->metas[ $field_id ] ) ) {
-			$observed_value = $entry->metas[ $field_id ];
+		if ( isset( $entry->metas[$field_id] ) ) {
+			$observed_value = $entry->metas[$field_id];
 		} elseif ( $entry->post_id && FrmAppHelper::pro_is_installed() ) {
 			$field          = FrmField::getOne( $field_id );
 			$observed_value = FrmProEntryMetaHelper::get_post_or_meta_value(
@@ -981,7 +981,7 @@ 
 		$form_fields = FrmField::get_all_for_form( $form_id, '', 'include' );
 		return array_filter(
 			$form_fields,
-			function ( $form_field ) {
+			function( $form_field ) {
 				return ! FrmField::is_no_save_field( $form_field->type );
 			}
 		);