Completed
Pull Request — master (#1580)
by Stephanie
47s
created
deprecated/FrmDeprecated.php 2 patches
Indentation   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -749,8 +749,8 @@  discard block
 block discarded – undo
749 749
 	 */
750 750
 	public static function get_shortcode_tag( $shortcodes, $short_key, $args ) {
751 751
 		_deprecated_function( __FUNCTION__, '3.0', 'FrmShortcodeHelper::get_shortcode_tag' );
752
-        return FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key, $args );
753
-    }
752
+		return FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key, $args );
753
+	}
754 754
 
755 755
 	/**
756 756
 	 * @deprecated 3.01
@@ -763,52 +763,52 @@  discard block
 block discarded – undo
763 763
 	/**
764 764
 	 * @deprecated 3.02.03
765 765
 	 */
766
-    public static function jquery_themes() {
766
+	public static function jquery_themes() {
767 767
 		_deprecated_function( __FUNCTION__, '3.02.03', 'FrmProStylesController::jquery_themes' );
768 768
 
769
-        $themes = array(
770
-            'ui-lightness'  => 'UI Lightness',
771
-            'ui-darkness'   => 'UI Darkness',
772
-            'smoothness'    => 'Smoothness',
773
-            'start'         => 'Start',
774
-            'redmond'       => 'Redmond',
775
-            'sunny'         => 'Sunny',
776
-            'overcast'      => 'Overcast',
777
-            'le-frog'       => 'Le Frog',
778
-            'flick'         => 'Flick',
769
+		$themes = array(
770
+			'ui-lightness'  => 'UI Lightness',
771
+			'ui-darkness'   => 'UI Darkness',
772
+			'smoothness'    => 'Smoothness',
773
+			'start'         => 'Start',
774
+			'redmond'       => 'Redmond',
775
+			'sunny'         => 'Sunny',
776
+			'overcast'      => 'Overcast',
777
+			'le-frog'       => 'Le Frog',
778
+			'flick'         => 'Flick',
779 779
 			'pepper-grinder' => 'Pepper Grinder',
780
-            'eggplant'      => 'Eggplant',
781
-            'dark-hive'     => 'Dark Hive',
782
-            'cupertino'     => 'Cupertino',
783
-            'south-street'  => 'South Street',
784
-            'blitzer'       => 'Blitzer',
785
-            'humanity'      => 'Humanity',
786
-            'hot-sneaks'    => 'Hot Sneaks',
787
-            'excite-bike'   => 'Excite Bike',
788
-            'vader'         => 'Vader',
789
-            'dot-luv'       => 'Dot Luv',
790
-            'mint-choc'     => 'Mint Choc',
791
-            'black-tie'     => 'Black Tie',
792
-            'trontastic'    => 'Trontastic',
793
-            'swanky-purse'  => 'Swanky Purse',
794
-        );
780
+			'eggplant'      => 'Eggplant',
781
+			'dark-hive'     => 'Dark Hive',
782
+			'cupertino'     => 'Cupertino',
783
+			'south-street'  => 'South Street',
784
+			'blitzer'       => 'Blitzer',
785
+			'humanity'      => 'Humanity',
786
+			'hot-sneaks'    => 'Hot Sneaks',
787
+			'excite-bike'   => 'Excite Bike',
788
+			'vader'         => 'Vader',
789
+			'dot-luv'       => 'Dot Luv',
790
+			'mint-choc'     => 'Mint Choc',
791
+			'black-tie'     => 'Black Tie',
792
+			'trontastic'    => 'Trontastic',
793
+			'swanky-purse'  => 'Swanky Purse',
794
+		);
795 795
 
796 796
 		$themes = apply_filters( 'frm_jquery_themes', $themes );
797
-        return $themes;
798
-    }
797
+		return $themes;
798
+	}
799 799
 
800 800
 	/**
801 801
 	 * @deprecated 3.02.03
802 802
 	 */
803
-    public static function enqueue_jquery_css() {
803
+	public static function enqueue_jquery_css() {
804 804
 		_deprecated_function( __FUNCTION__, '3.02.03', 'FrmProStylesController::enqueue_jquery_css' );
805 805
 
806 806
 		$form = self::get_form_for_page();
807 807
 		$theme_css = FrmStylesController::get_style_val( 'theme_css', $form );
808
-        if ( $theme_css != -1 ) {
808
+		if ( $theme_css != -1 ) {
809 809
 			wp_enqueue_style( 'jquery-theme', self::jquery_css_url( $theme_css ), array(), FrmAppHelper::plugin_version() );
810
-        }
811
-    }
810
+		}
811
+	}
812 812
 
813 813
 	/**
814 814
 	 * @deprecated 3.02.03
@@ -821,7 +821,7 @@  discard block
 block discarded – undo
821 821
 		}
822 822
 
823 823
 		return FrmProStylesController::jquery_css_url( $theme_css );
824
-    }
824
+	}
825 825
 
826 826
 	/**
827 827
 	 * @deprecated 3.02.03
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 		FrmAppHelper::permission_check( 'frm_edit_forms' );
28 28
 
29 29
 		$action = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action';
30
-		$action = empty( $values ) ? FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' ) : $values[ $action ];
30
+		$action = empty( $values ) ? FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' ) : $values[$action];
31 31
 
32 32
 		if ( $action === 'create' ) {
33 33
 			FrmFormsController::update( $values );
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 		}
36 36
 
37 37
 		$values = FrmFormsHelper::setup_new_vars( $values );
38
-		$id   = FrmForm::create( $values );
38
+		$id = FrmForm::create( $values );
39 39
 		$values['id'] = $id;
40 40
 
41 41
 		FrmFormsController::edit( $values );
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldCombo.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -59,12 +59,12 @@  discard block
 block discarded – undo
59 59
 			if ( is_array( $sub_field ) ) {
60 60
 				$sub_field                 = wp_parse_args( $sub_field, $defaults );
61 61
 				$sub_field['name']         = $name;
62
-				$this->sub_fields[ $name ] = $sub_field;
62
+				$this->sub_fields[$name] = $sub_field;
63 63
 				continue;
64 64
 			}
65 65
 
66 66
 			if ( is_string( $sub_field ) ) {
67
-				$this->sub_fields[ $name ] = wp_parse_args(
67
+				$this->sub_fields[$name] = wp_parse_args(
68 68
 					array(
69 69
 						'name'  => $name,
70 70
 						'label' => $sub_field,
@@ -116,9 +116,9 @@  discard block
 block discarded – undo
116 116
 				}
117 117
 
118 118
 				if ( is_string( $option ) ) {
119
-					$extra_options[ $key . '_' . $option ] = '';
119
+					$extra_options[$key . '_' . $option] = '';
120 120
 				} elseif ( ! empty( $option['name'] ) ) {
121
-					$extra_options[ $key . '_' . $option['name'] ] = '';
121
+					$extra_options[$key . '_' . $option['name']] = '';
122 122
 				}
123 123
 			}
124 124
 		}
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 		foreach ( $this->sub_fields as $name => $sub_field ) {
142 142
 			$sub_field['name'] = $name;
143 143
 			$wrapper_classes   = 'frm_grid_container frm_sub_field_options frm_sub_field_options-' . $sub_field['name'];
144
-			if ( ! isset( $processed_sub_fields[ $name ] ) ) {
144
+			if ( ! isset( $processed_sub_fields[$name] ) ) {
145 145
 				// Options for this subfield should be hidden.
146 146
 				$wrapper_classes .= ' frm_hidden';
147 147
 			}
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 			$default_value = array();
172 172
 
173 173
 			foreach ( $this->sub_fields as $name => $sub_field ) {
174
-				$default_value[ $name ] = '';
174
+				$default_value[$name] = '';
175 175
 			}
176 176
 
177 177
 			return $default_value;
@@ -343,8 +343,8 @@  discard block
 block discarded – undo
343 343
 		// Placeholder.
344 344
 		if ( in_array( 'placeholder', $sub_field['options'], true ) ) {
345 345
 			$placeholders = FrmField::get_option( $field, 'placeholder' );
346
-			if ( ! empty( $placeholders[ $sub_field['name'] ] ) ) {
347
-				$field['placeholder'] = $placeholders[ $sub_field['name'] ];
346
+			if ( ! empty( $placeholders[$sub_field['name']] ) ) {
347
+				$field['placeholder'] = $placeholders[$sub_field['name']];
348 348
 			}
349 349
 		}
350 350
 
@@ -401,9 +401,9 @@  discard block
 block discarded – undo
401 401
 
402 402
 		// Validate not empty.
403 403
 		foreach ( $sub_fields as $name => $sub_field ) {
404
-			if ( empty( $sub_field['optional'] ) && empty( $args['value'][ $name ] ) ) {
405
-				$errors[ 'field' . $args['id'] . '-' . $name ] = '';
406
-				$errors[ 'field' . $args['id'] ]               = $blank_msg;
404
+			if ( empty( $sub_field['optional'] ) && empty( $args['value'][$name] ) ) {
405
+				$errors['field' . $args['id'] . '-' . $name] = '';
406
+				$errors['field' . $args['id']]               = $blank_msg;
407 407
 			}
408 408
 		}
409 409
 
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
 		$field_key  = isset( $this->field->field_key ) ? $this->field->field_key : $this->field['field_key'];
423 423
 		$sub_fields = $this->get_processed_sub_fields();
424 424
 		foreach ( $sub_fields as $name => $sub_field ) {
425
-			$headings[ $field_id . '_' . $name ] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
425
+			$headings[$field_id . '_' . $name] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
426 426
 		}
427 427
 
428 428
 		return $headings;
Please login to merge, or discard this patch.
classes/views/frm-forms/landing-page-preview-option.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 $data_keys = array_keys( $data );
7 7
 $params    = array();
8 8
 foreach ( $data_keys as $key ) {
9
-	$params[ 'data-' . $key ] = $data[ $key ];
9
+	$params['data-' . $key] = $data[$key];
10 10
 }
11 11
 $params['class'] = 'frm_show_upgrade frm_noallow';
12 12
 $params['href']  = '#';
Please login to merge, or discard this patch.
classes/helpers/FrmXMLHelper.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,8 @@
 block discarded – undo
87 87
 
88 88
 		if ( ! isset( $imported['form_status'] ) || empty( $imported['form_status'] ) ) {
89 89
 			// Check for an error message in the XML.
90
-			if ( isset( $xml->Code ) && isset( $xml->Message ) ) { // phpcs:ignore WordPress.NamingConventions
90
+			if ( isset( $xml->Code ) && isset( $xml->Message ) ) {
91
+// phpcs:ignore WordPress.NamingConventions
91 92
 				$imported['error'] = (string) $xml->Message; // phpcs:ignore WordPress.NamingConventions
92 93
 			}
93 94
 		}
Please login to merge, or discard this patch.
Spacing   +86 added lines, -86 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 
178 178
 			if ( $term && is_array( $term ) ) {
179 179
 				$imported['imported']['terms'] ++;
180
-				$imported['terms'][ (int) $t->term_id ] = $term['term_id'];
180
+				$imported['terms'][(int) $t->term_id] = $term['term_id'];
181 181
 			}
182 182
 
183 183
 			unset( $term, $t );
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 					}
234 234
 
235 235
 					// Keep track of whether this specific form was updated or not.
236
-					$imported['form_status'][ $form_id ] = 'imported';
236
+					$imported['form_status'][$form_id] = 'imported';
237 237
 				}
238 238
 			}
239 239
 
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
 			// Update field ids/keys to new ones.
249 249
 			do_action( 'frm_after_duplicate_form', $form_id, $form, array( 'old_id' => $old_id ) );
250 250
 
251
-			$imported['forms'][ (int) $item->id ] = $form_id;
251
+			$imported['forms'][(int) $item->id] = $form_id;
252 252
 
253 253
 			// Send pre 2.0 form options through function that creates actions.
254 254
 			self::migrate_form_settings_to_actions( $form['options'], $form_id, $imported, true );
@@ -322,15 +322,15 @@  discard block
 block discarded – undo
322 322
 		}
323 323
 
324 324
 		// Keep track of whether this specific form was updated or not
325
-		$imported['form_status'][ $form_id ] = 'updated';
325
+		$imported['form_status'][$form_id] = 'updated';
326 326
 	}
327 327
 
328 328
 	private static function get_form_fields( $form_id ) {
329 329
 		$form_fields = FrmField::get_all_for_form( $form_id, '', 'exclude', 'exclude' );
330 330
 		$old_fields  = array();
331 331
 		foreach ( $form_fields as $f ) {
332
-			$old_fields[ $f->id ]        = $f;
333
-			$old_fields[ $f->field_key ] = $f->id;
332
+			$old_fields[$f->id]        = $f;
333
+			$old_fields[$f->field_key] = $f->id;
334 334
 			unset( $f );
335 335
 		}
336 336
 		$form_fields = $old_fields;
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 	 */
388 388
 	private static function track_imported_child_forms( $form_id, $parent_form_id, &$child_forms ) {
389 389
 		if ( $parent_form_id ) {
390
-			$child_forms[ $form_id ] = $parent_form_id;
390
+			$child_forms[$form_id] = $parent_form_id;
391 391
 		}
392 392
 	}
393 393
 
@@ -402,9 +402,9 @@  discard block
 block discarded – undo
402 402
 	 */
403 403
 	private static function maybe_update_child_form_parent_id( $imported_forms, $child_forms ) {
404 404
 		foreach ( $child_forms as $child_form_id => $old_parent_form_id ) {
405
-			if ( isset( $imported_forms[ $old_parent_form_id ] ) && (int) $imported_forms[ $old_parent_form_id ] !== (int) $old_parent_form_id ) {
405
+			if ( isset( $imported_forms[$old_parent_form_id] ) && (int) $imported_forms[$old_parent_form_id] !== (int) $old_parent_form_id ) {
406 406
 				// Update all children with this old parent_form_id
407
-				$new_parent_form_id = (int) $imported_forms[ $old_parent_form_id ];
407
+				$new_parent_form_id = (int) $imported_forms[$old_parent_form_id];
408 408
 				FrmForm::update( $child_form_id, array( 'parent_form_id' => $new_parent_form_id ) );
409 409
 				do_action( 'frm_update_child_form_parent_id', $child_form_id, $new_parent_form_id );
410 410
 			}
@@ -434,34 +434,34 @@  discard block
 block discarded – undo
434 434
 
435 435
 			if ( ! empty( $this_form ) ) {
436 436
 				// check for field to edit by field id
437
-				if ( isset( $form_fields[ $f['id'] ] ) ) {
437
+				if ( isset( $form_fields[$f['id']] ) ) {
438 438
 					FrmField::update( $f['id'], $f );
439 439
 					$imported['updated']['fields'] ++;
440 440
 
441
-					unset( $form_fields[ $f['id'] ] );
441
+					unset( $form_fields[$f['id']] );
442 442
 
443 443
 					// Unset old field key.
444
-					if ( isset( $form_fields[ $f['field_key'] ] ) ) {
445
-						unset( $form_fields[ $f['field_key'] ] );
444
+					if ( isset( $form_fields[$f['field_key']] ) ) {
445
+						unset( $form_fields[$f['field_key']] );
446 446
 					}
447
-				} elseif ( isset( $form_fields[ $f['field_key'] ] ) ) {
448
-					$keys_by_original_field_id[ $f['id'] ] = $f['field_key'];
447
+				} elseif ( isset( $form_fields[$f['field_key']] ) ) {
448
+					$keys_by_original_field_id[$f['id']] = $f['field_key'];
449 449
 
450 450
 					$old_field_id = $f['id'];
451 451
 
452 452
 					// check for field to edit by field key
453 453
 					unset( $f['id'] );
454 454
 
455
-					FrmField::update( $form_fields[ $f['field_key'] ], $f );
455
+					FrmField::update( $form_fields[$f['field_key']], $f );
456 456
 					$imported['updated']['fields'] ++;
457 457
 
458 458
 					self::do_after_field_imported_action( $f, $form_fields, $old_field_id );
459 459
 
460 460
 					// Unset old field id.
461
-					unset( $form_fields[ $form_fields[ $f['field_key'] ] ] );
461
+					unset( $form_fields[$form_fields[$f['field_key']]] );
462 462
 
463 463
 					// Unset old field key.
464
-					unset( $form_fields[ $f['field_key'] ] );
464
+					unset( $form_fields[$f['field_key']] );
465 465
 				} else {
466 466
 					// If no matching field id or key in this form, create the field.
467 467
 					self::create_imported_field( $f, $imported );
@@ -501,7 +501,7 @@  discard block
 block discarded – undo
501 501
 	 */
502 502
 	private static function do_after_field_imported_action( $field_array, $form_fields, $old_field_id ) {
503 503
 		// Assign field array the update field's ID.
504
-		$field_array['id'] = $form_fields[ $field_array['field_key'] ];
504
+		$field_array['id'] = $form_fields[$field_array['field_key']];
505 505
 
506 506
 		/**
507 507
 		 * Fires when an existing field is imported.
@@ -512,7 +512,7 @@  discard block
 block discarded – undo
512 512
 		 * @param int   $field_id
513 513
 		 * @param int   $old_field_id
514 514
 		 */
515
-		do_action( 'frm_after_existing_field_is_imported', $field_array, $form_fields[ $field_array['field_key'] ], $old_field_id );
515
+		do_action( 'frm_after_existing_field_is_imported', $field_array, $form_fields[$field_array['field_key']], $old_field_id );
516 516
 	}
517 517
 
518 518
 	private static function fill_field( $field, $form_id ) {
@@ -608,8 +608,8 @@  discard block
 block discarded – undo
608 608
 		if ( $f['type'] == 'form' || ( $f['type'] == 'divider' && FrmField::is_option_true( $f['field_options'], 'repeat' ) ) ) {
609 609
 			if ( FrmField::is_option_true( $f['field_options'], 'form_select' ) ) {
610 610
 				$form_select = (int) $f['field_options']['form_select'];
611
-				if ( isset( $imported['forms'][ $form_select ] ) ) {
612
-					$f['field_options']['form_select'] = $imported['forms'][ $form_select ];
611
+				if ( isset( $imported['forms'][$form_select] ) ) {
612
+					$f['field_options']['form_select'] = $imported['forms'][$form_select];
613 613
 				}
614 614
 			}
615 615
 		}
@@ -630,8 +630,8 @@  discard block
 block discarded – undo
630 630
 
631 631
 		if ( FrmField::is_option_true_in_array( $f['field_options'], 'get_values_form' ) ) {
632 632
 			$old_form = $f['field_options']['get_values_form'];
633
-			if ( isset( $imported['forms'][ $old_form ] ) ) {
634
-				$f['field_options']['get_values_form'] = $imported['forms'][ $old_form ];
633
+			if ( isset( $imported['forms'][$old_form] ) ) {
634
+				$f['field_options']['get_values_form'] = $imported['forms'][$old_form];
635 635
 			}
636 636
 		}
637 637
 	}
@@ -652,12 +652,12 @@  discard block
 block discarded – undo
652 652
 	private static function migrate_placeholders( &$f ) {
653 653
 		$update_values = self::migrate_field_placeholder( $f, 'clear_on_focus' );
654 654
 		foreach ( $update_values as $k => $v ) {
655
-			$f[ $k ] = $v;
655
+			$f[$k] = $v;
656 656
 		}
657 657
 
658 658
 		$update_values = self::migrate_field_placeholder( $f, 'default_blank' );
659 659
 		foreach ( $update_values as $k => $v ) {
660
-			$f[ $k ] = $v;
660
+			$f[$k] = $v;
661 661
 		}
662 662
 	}
663 663
 
@@ -671,7 +671,7 @@  discard block
 block discarded – undo
671 671
 	public static function migrate_field_placeholder( $field, $type ) {
672 672
 		$field = (array) $field;
673 673
 		$field_options = $field['field_options'];
674
-		if ( empty( $field_options[ $type ] ) || empty( $field['default_value'] ) ) {
674
+		if ( empty( $field_options[$type] ) || empty( $field['default_value'] ) ) {
675 675
 			return array();
676 676
 		}
677 677
 
@@ -697,7 +697,7 @@  discard block
 block discarded – undo
697 697
 				}
698 698
 
699 699
 				if ( $opt == $default_value ) {
700
-					unset( $options[ $opt_key ] );
700
+					unset( $options[$opt_key] );
701 701
 					break;
702 702
 				}
703 703
 			}
@@ -753,10 +753,10 @@  discard block
 block discarded – undo
753 753
 
754 754
 			$image_id = FrmProFileImport::import_attachment( $option['src'], $field_object );
755 755
 			// Remove the src from options as it isn't required after import.
756
-			unset( $field['options'][ $key ]['src'] );
756
+			unset( $field['options'][$key]['src'] );
757 757
 
758 758
 			if ( is_numeric( $image_id ) ) {
759
-				$field['options'][ $key ]['image'] = $image_id;
759
+				$field['options'][$key]['image'] = $image_id;
760 760
 			}
761 761
 		}
762 762
 
@@ -924,8 +924,8 @@  discard block
 block discarded – undo
924 924
 			} else {
925 925
 				if ( $post['post_type'] === 'frm_display' ) {
926 926
 					$post['post_content'] = self::maybe_prepare_json_view_content( $post['post_content'] );
927
-				} elseif ( 'page' === $post['post_type'] && isset( $imported['posts'][ $post['post_parent'] ] ) ) {
928
-					$post['post_parent'] = $imported['posts'][ $post['post_parent'] ];
927
+				} elseif ( 'page' === $post['post_type'] && isset( $imported['posts'][$post['post_parent']] ) ) {
928
+					$post['post_parent'] = $imported['posts'][$post['post_parent']];
929 929
 				}
930 930
 				// Create/update post now
931 931
 				$post_id = wp_insert_post( $post );
@@ -936,27 +936,27 @@  discard block
 block discarded – undo
936 936
 			}
937 937
 
938 938
 			if ( false !== strpos( $post['post_content'], '[display-frm-data' ) || false !== strpos( $post['post_content'], '[formidable' ) ) {
939
-				$posts_with_shortcodes[ $post_id ] = $post;
939
+				$posts_with_shortcodes[$post_id] = $post;
940 940
 			}
941 941
 
942 942
 			self::update_postmeta( $post, $post_id );
943 943
 			self::update_layout( $post, $post_id );
944 944
 
945 945
 			$this_type = 'posts';
946
-			if ( isset( $post_types[ $post['post_type'] ] ) ) {
947
-				$this_type = $post_types[ $post['post_type'] ];
946
+			if ( isset( $post_types[$post['post_type']] ) ) {
947
+				$this_type = $post_types[$post['post_type']];
948 948
 			}
949 949
 
950 950
 			if ( isset( $post['ID'] ) && $post_id == $post['ID'] ) {
951
-				$imported['updated'][ $this_type ] ++;
951
+				$imported['updated'][$this_type] ++;
952 952
 			} else {
953
-				$imported['imported'][ $this_type ] ++;
953
+				$imported['imported'][$this_type] ++;
954 954
 			}
955 955
 
956
-			$imported['posts'][ (int) $old_id ] = $post_id;
956
+			$imported['posts'][(int) $old_id] = $post_id;
957 957
 
958 958
 			if ( $post['post_type'] === 'frm_display' ) {
959
-				$view_ids[ (int) $old_id ] = $post_id;
959
+				$view_ids[(int) $old_id] = $post_id;
960 960
 			}
961 961
 
962 962
 			do_action( 'frm_after_import_view', $post_id, $post );
@@ -1117,9 +1117,9 @@  discard block
 block discarded – undo
1117 1117
 			$post['attachment_url'] = (string) $item->attachment_url;
1118 1118
 		}
1119 1119
 
1120
-		if ( $post['post_type'] == FrmFormActionsController::$action_post_type && isset( $imported['forms'][ (int) $post['menu_order'] ] ) ) {
1120
+		if ( $post['post_type'] == FrmFormActionsController::$action_post_type && isset( $imported['forms'][(int) $post['menu_order']] ) ) {
1121 1121
 			// update to new form id
1122
-			$post['menu_order'] = $imported['forms'][ (int) $post['menu_order'] ];
1122
+			$post['menu_order'] = $imported['forms'][(int) $post['menu_order']];
1123 1123
 		}
1124 1124
 
1125 1125
 		// Don't allow default styles to take over a site's default style
@@ -1156,8 +1156,8 @@  discard block
 block discarded – undo
1156 1156
 		);
1157 1157
 
1158 1158
 		// Switch old form and field ids to new ones.
1159
-		if ( 'frm_form_id' === $m['key'] && isset( $imported['forms'][ (int) $m['value'] ] ) ) {
1160
-			$m['value'] = $imported['forms'][ (int) $m['value'] ];
1159
+		if ( 'frm_form_id' === $m['key'] && isset( $imported['forms'][(int) $m['value']] ) ) {
1160
+			$m['value'] = $imported['forms'][(int) $m['value']];
1161 1161
 		} else {
1162 1162
 			$m['value'] = FrmAppHelper::maybe_json_decode( $m['value'] );
1163 1163
 
@@ -1168,15 +1168,15 @@  discard block
 block discarded – undo
1168 1168
 				} elseif ( 'frm_options' === $m['key'] ) {
1169 1169
 
1170 1170
 					foreach ( array( 'date_field_id', 'edate_field_id' ) as $setting_name ) {
1171
-						if ( isset( $m['value'][ $setting_name ] ) && is_numeric( $m['value'][ $setting_name ] ) && isset( $frm_duplicate_ids[ $m['value'][ $setting_name ] ] ) ) {
1172
-							$m['value'][ $setting_name ] = $frm_duplicate_ids[ $m['value'][ $setting_name ] ];
1171
+						if ( isset( $m['value'][$setting_name] ) && is_numeric( $m['value'][$setting_name] ) && isset( $frm_duplicate_ids[$m['value'][$setting_name]] ) ) {
1172
+							$m['value'][$setting_name] = $frm_duplicate_ids[$m['value'][$setting_name]];
1173 1173
 						}
1174 1174
 					}
1175 1175
 
1176 1176
 					$check_dup_array = array();
1177 1177
 					if ( isset( $m['value']['order_by'] ) && ! empty( $m['value']['order_by'] ) ) {
1178
-						if ( is_numeric( $m['value']['order_by'] ) && isset( $frm_duplicate_ids[ $m['value']['order_by'] ] ) ) {
1179
-							$m['value']['order_by'] = $frm_duplicate_ids[ $m['value']['order_by'] ];
1178
+						if ( is_numeric( $m['value']['order_by'] ) && isset( $frm_duplicate_ids[$m['value']['order_by']] ) ) {
1179
+							$m['value']['order_by'] = $frm_duplicate_ids[$m['value']['order_by']];
1180 1180
 						} elseif ( is_array( $m['value']['order_by'] ) ) {
1181 1181
 							$check_dup_array[] = 'order_by';
1182 1182
 						}
@@ -1187,9 +1187,9 @@  discard block
 block discarded – undo
1187 1187
 					}
1188 1188
 
1189 1189
 					foreach ( $check_dup_array as $check_k ) {
1190
-						foreach ( (array) $m['value'][ $check_k ] as $mk => $mv ) {
1191
-							if ( isset( $frm_duplicate_ids[ $mv ] ) ) {
1192
-								$m['value'][ $check_k ][ $mk ] = $frm_duplicate_ids[ $mv ];
1190
+						foreach ( (array) $m['value'][$check_k] as $mk => $mv ) {
1191
+							if ( isset( $frm_duplicate_ids[$mv] ) ) {
1192
+								$m['value'][$check_k][$mk] = $frm_duplicate_ids[$mv];
1193 1193
 							}
1194 1194
 							unset( $mk, $mv );
1195 1195
 						}
@@ -1202,11 +1202,11 @@  discard block
 block discarded – undo
1202 1202
 			$m['value'] = FrmAppHelper::maybe_json_decode( $m['value'] );
1203 1203
 		}
1204 1204
 
1205
-		$post['postmeta'][ (string) $meta->meta_key ] = $m['value'];
1205
+		$post['postmeta'][(string) $meta->meta_key] = $m['value'];
1206 1206
 	}
1207 1207
 
1208 1208
 	private static function populate_layout( &$post, $layout ) {
1209
-		$post['layout'][ (string) $layout->type ] = (string) $layout->data;
1209
+		$post['layout'][(string) $layout->type] = (string) $layout->data;
1210 1210
 	}
1211 1211
 
1212 1212
 	/**
@@ -1234,11 +1234,11 @@  discard block
 block discarded – undo
1234 1234
 				$name = (string) $c;
1235 1235
 			}
1236 1236
 
1237
-			if ( ! isset( $post['tax_input'][ $taxonomy ] ) ) {
1238
-				$post['tax_input'][ $taxonomy ] = array();
1237
+			if ( ! isset( $post['tax_input'][$taxonomy] ) ) {
1238
+				$post['tax_input'][$taxonomy] = array();
1239 1239
 			}
1240 1240
 
1241
-			$post['tax_input'][ $taxonomy ][] = $name;
1241
+			$post['tax_input'][$taxonomy][] = $name;
1242 1242
 			unset( $name );
1243 1243
 		}//end foreach
1244 1244
 	}
@@ -1377,7 +1377,7 @@  discard block
 block discarded – undo
1377 1377
 
1378 1378
 		$message = '<ul>';
1379 1379
 		foreach ( $result as $type => $results ) {
1380
-			if ( ! isset( $t_strings[ $type ] ) ) {
1380
+			if ( ! isset( $t_strings[$type] ) ) {
1381 1381
 				// only print imported and updated
1382 1382
 				continue;
1383 1383
 			}
@@ -1389,7 +1389,7 @@  discard block
 block discarded – undo
1389 1389
 			}
1390 1390
 
1391 1391
 			if ( ! empty( $s_message ) ) {
1392
-				$message .= '<li><strong>' . $t_strings[ $type ] . ':</strong> ';
1392
+				$message .= '<li><strong>' . $t_strings[$type] . ':</strong> ';
1393 1393
 				$message .= implode( ', ', $s_message );
1394 1394
 				$message .= '</li>';
1395 1395
 			}
@@ -1441,8 +1441,8 @@  discard block
 block discarded – undo
1441 1441
 			'actions' => sprintf( _n( '%1$s Form Action', '%1$s Form Actions', $m, 'formidable' ), $m ),
1442 1442
 		);
1443 1443
 
1444
-		if ( isset( $strings[ $type ] ) ) {
1445
-			$s_message[] = $strings[ $type ];
1444
+		if ( isset( $strings[$type] ) ) {
1445
+			$s_message[] = $strings[$type];
1446 1446
 		} else {
1447 1447
 			$string = ' ' . $m . ' ' . ucfirst( $type );
1448 1448
 
@@ -1590,7 +1590,7 @@  discard block
 block discarded – undo
1590 1590
 
1591 1591
 		foreach ( $options as $key => $option ) {
1592 1592
 			if ( is_array( $option ) && ! empty( $option['image'] ) ) {
1593
-				$options[ $key ]['src'] = wp_get_attachment_url( $option['image'] );
1593
+				$options[$key]['src'] = wp_get_attachment_url( $option['image'] );
1594 1594
 				$updated                = true;
1595 1595
 			}
1596 1596
 		}
@@ -1619,8 +1619,8 @@  discard block
 block discarded – undo
1619 1619
 	 */
1620 1620
 	private static function remove_defaults( $defaults, &$saved ) {
1621 1621
 		foreach ( $saved as $key => $value ) {
1622
-			if ( isset( $defaults[ $key ] ) && $defaults[ $key ] === $value ) {
1623
-				unset( $saved[ $key ] );
1622
+			if ( isset( $defaults[$key] ) && $defaults[$key] === $value ) {
1623
+				unset( $saved[$key] );
1624 1624
 			}
1625 1625
 		}
1626 1626
 	}
@@ -1631,14 +1631,14 @@  discard block
 block discarded – undo
1631 1631
 	 * @since 3.06
1632 1632
 	 */
1633 1633
 	private static function remove_default_html( $html_name, $defaults, &$options ) {
1634
-		if ( ! isset( $options[ $html_name ] ) || ! isset( $defaults[ $html_name ] ) ) {
1634
+		if ( ! isset( $options[$html_name] ) || ! isset( $defaults[$html_name] ) ) {
1635 1635
 			return;
1636 1636
 		}
1637 1637
 
1638
-		$old_html     = str_replace( "\r\n", "\n", $options[ $html_name ] );
1639
-		$default_html = $defaults[ $html_name ];
1638
+		$old_html     = str_replace( "\r\n", "\n", $options[$html_name] );
1639
+		$default_html = $defaults[$html_name];
1640 1640
 		if ( $old_html == $default_html ) {
1641
-			unset( $options[ $html_name ] );
1641
+			unset( $options[$html_name] );
1642 1642
 
1643 1643
 			return;
1644 1644
 		}
@@ -1646,7 +1646,7 @@  discard block
 block discarded – undo
1646 1646
 		// Account for some of the older field default HTML.
1647 1647
 		$default_html = str_replace( ' id="frm_desc_field_[key]"', '', $default_html );
1648 1648
 		if ( $old_html == $default_html ) {
1649
-			unset( $options[ $html_name ] );
1649
+			unset( $options[$html_name] );
1650 1650
 		}
1651 1651
 	}
1652 1652
 
@@ -1737,8 +1737,8 @@  discard block
 block discarded – undo
1737 1737
 		);
1738 1738
 
1739 1739
 		foreach ( $post_settings as $post_setting ) {
1740
-			if ( isset( $form_options[ $post_setting ] ) ) {
1741
-				$new_action['post_content'][ $post_setting ] = $form_options[ $post_setting ];
1740
+			if ( isset( $form_options[$post_setting] ) ) {
1741
+				$new_action['post_content'][$post_setting] = $form_options[$post_setting];
1742 1742
 			}
1743 1743
 			unset( $post_setting );
1744 1744
 		}
@@ -1809,11 +1809,11 @@  discard block
 block discarded – undo
1809 1809
 		foreach ( $post_content as $key => $setting ) {
1810 1810
 			if ( ! is_array( $setting ) && in_array( $key, $basic_fields ) ) {
1811 1811
 				// Replace old IDs with new IDs
1812
-				$post_content[ $key ] = str_replace( $old, $new, $setting );
1812
+				$post_content[$key] = str_replace( $old, $new, $setting );
1813 1813
 			} elseif ( is_array( $setting ) && in_array( $key, $array_fields ) ) {
1814 1814
 				foreach ( $setting as $k => $val ) {
1815 1815
 					// Replace old IDs with new IDs
1816
-					$post_content[ $key ][ $k ] = str_replace( $old, $new, $val );
1816
+					$post_content[$key][$k] = str_replace( $old, $new, $val );
1817 1817
 				}
1818 1818
 			}
1819 1819
 			unset( $key, $setting );
@@ -1889,8 +1889,8 @@  discard block
 block discarded – undo
1889 1889
 	private static function remove_deprecated_notification_settings( $form_id, $form_options ) {
1890 1890
 		$delete_settings = array( 'notification', 'autoresponder', 'email_to' );
1891 1891
 		foreach ( $delete_settings as $index ) {
1892
-			if ( isset( $form_options[ $index ] ) ) {
1893
-				unset( $form_options[ $index ] );
1892
+			if ( isset( $form_options[$index] ) ) {
1893
+				unset( $form_options[$index] );
1894 1894
 			}
1895 1895
 		}
1896 1896
 		FrmForm::update( $form_id, array( 'options' => $form_options ) );
@@ -1943,12 +1943,12 @@  discard block
 block discarded – undo
1943 1943
 			'reply_to_name' => '',
1944 1944
 		);
1945 1945
 		foreach ( $reply_fields as $f => $val ) {
1946
-			if ( isset( $notification[ $f ] ) ) {
1947
-				$atts[ $f ] = $notification[ $f ];
1948
-				if ( 'custom' == $notification[ $f ] ) {
1949
-					$atts[ $f ] = $notification[ 'cust_' . $f ];
1950
-				} elseif ( is_numeric( $atts[ $f ] ) && ! empty( $atts[ $f ] ) ) {
1951
-					$atts[ $f ] = '[' . $atts[ $f ] . ']';
1946
+			if ( isset( $notification[$f] ) ) {
1947
+				$atts[$f] = $notification[$f];
1948
+				if ( 'custom' == $notification[$f] ) {
1949
+					$atts[$f] = $notification['cust_' . $f];
1950
+				} elseif ( is_numeric( $atts[$f] ) && ! empty( $atts[$f] ) ) {
1951
+					$atts[$f] = '[' . $atts[$f] . ']';
1952 1952
 				}
1953 1953
 			}
1954 1954
 			unset( $f, $val );
@@ -1979,13 +1979,13 @@  discard block
 block discarded – undo
1979 1979
 		foreach ( $atts['email_to'] as $key => $email_field ) {
1980 1980
 
1981 1981
 			if ( is_numeric( $email_field ) ) {
1982
-				$atts['email_to'][ $key ] = '[' . $email_field . ']';
1982
+				$atts['email_to'][$key] = '[' . $email_field . ']';
1983 1983
 			}
1984 1984
 
1985 1985
 			if ( strpos( $email_field, '|' ) ) {
1986 1986
 				$email_opt = explode( '|', $email_field );
1987 1987
 				if ( isset( $email_opt[0] ) ) {
1988
-					$atts['email_to'][ $key ] = '[' . $email_opt[0] . ' show=' . $email_opt[1] . ']';
1988
+					$atts['email_to'][$key] = '[' . $email_opt[0] . ' show=' . $email_opt[1] . ']';
1989 1989
 				}
1990 1990
 				unset( $email_opt );
1991 1991
 			}
@@ -2006,12 +2006,12 @@  discard block
 block discarded – undo
2006 2006
 		// Add more fields to the new notification
2007 2007
 		$add_fields = array( 'email_message', 'email_subject', 'plain_text', 'inc_user_info', 'conditions' );
2008 2008
 		foreach ( $add_fields as $add_field ) {
2009
-			if ( isset( $notification[ $add_field ] ) ) {
2010
-				$new_notification['post_content'][ $add_field ] = $notification[ $add_field ];
2009
+			if ( isset( $notification[$add_field] ) ) {
2010
+				$new_notification['post_content'][$add_field] = $notification[$add_field];
2011 2011
 			} elseif ( in_array( $add_field, array( 'plain_text', 'inc_user_info' ) ) ) {
2012
-				$new_notification['post_content'][ $add_field ] = 0;
2012
+				$new_notification['post_content'][$add_field] = 0;
2013 2013
 			} else {
2014
-				$new_notification['post_content'][ $add_field ] = '';
2014
+				$new_notification['post_content'][$add_field] = '';
2015 2015
 			}
2016 2016
 			unset( $add_field );
2017 2017
 		}
@@ -2035,7 +2035,7 @@  discard block
 block discarded – undo
2035 2035
 		if ( isset( $post_content['conditions'] ) && is_array( $post_content['conditions'] ) ) {
2036 2036
 			foreach ( $post_content['conditions'] as $email_key => $val ) {
2037 2037
 				if ( is_numeric( $email_key ) ) {
2038
-					$post_content['conditions'][ $email_key ] = self::switch_action_field_ids( $val, array( 'hide_field' ) );
2038
+					$post_content['conditions'][$email_key] = self::switch_action_field_ids( $val, array( 'hide_field' ) );
2039 2039
 				}
2040 2040
 				unset( $email_key, $val );
2041 2041
 			}
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldText.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 		$max_length = intval( FrmField::get_option( $this->field, 'max' ) );
35 35
 
36 36
 		if ( $max_length && strlen( $args['value'] ) > $max_length ) {
37
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
37
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
38 38
 		}
39 39
 
40 40
 		return $errors;
Please login to merge, or discard this patch.
classes/models/FrmPluginSearch.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -75,20 +75,20 @@  discard block
 block discarded – undo
75 75
 			'name'                => sprintf(
76 76
 				/* translators: Formidable addon name */
77 77
 				esc_html_x( 'Formidable %s', 'Formidable Addon Name', 'formidable' ),
78
-				$addon_list[ $matching_addon ]['name']
78
+				$addon_list[$matching_addon]['name']
79 79
 			),
80
-			'addon'               => $addon_list[ $matching_addon ]['slug'],
81
-			'short_description'   => $addon_list[ $matching_addon ]['excerpt'],
80
+			'addon'               => $addon_list[$matching_addon]['slug'],
81
+			'short_description'   => $addon_list[$matching_addon]['excerpt'],
82 82
 			'slug'                => self::$slug,
83
-			'version'             => $addon_list[ $matching_addon ]['version'],
83
+			'version'             => $addon_list[$matching_addon]['version'],
84 84
 		);
85 85
 
86
-		if ( ! empty( $addon_list[ $matching_addon ]['external'] ) ) {
86
+		if ( ! empty( $addon_list[$matching_addon]['external'] ) ) {
87 87
 			unset( $overrides['name'] );
88 88
 		}
89 89
 
90 90
 		// Splice in the base addon data.
91
-		$inject = array_merge( $inject, $addon_list[ $matching_addon ], $overrides );
91
+		$inject = array_merge( $inject, $addon_list[$matching_addon], $overrides );
92 92
 
93 93
 		// Add it to the top of the list.
94 94
 		array_unshift( $result->plugins, $inject );
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
 	 */
340 340
 	protected function is_installed( $plugin ) {
341 341
 		$all_plugins = FrmAppHelper::get_plugins();
342
-		return isset( $all_plugins[ $plugin ] );
342
+		return isset( $all_plugins[$plugin] );
343 343
 	}
344 344
 
345 345
 	/**
Please login to merge, or discard this patch.
classes/controllers/FrmStylesController.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -119,7 +119,8 @@
 block discarded – undo
119 119
 	 * @return void
120 120
 	 */
121 121
 	private static function maybe_hook_into_global_settings_save() {
122
-		if ( empty( $_POST ) || ! isset( $_POST['style'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
122
+		if ( empty( $_POST ) || ! isset( $_POST['style'] ) ) {
123
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
123 124
 			// Avoid changing any style data if the style array is not sent in the request.
124 125
 			return;
125 126
 		}
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -711,7 +711,7 @@  discard block
 block discarded – undo
711 711
 		}
712 712
 
713 713
 		parse_str( $query, $parsed_query );
714
-		$form_id      = ! empty( $parsed_query['form'] ) ? absint( $parsed_query['form'] ) : 0;
714
+		$form_id = ! empty( $parsed_query['form'] ) ? absint( $parsed_query['form'] ) : 0;
715 715
 
716 716
 		$style     = new stdClass();
717 717
 		$style->ID = end( $ids );
@@ -749,8 +749,8 @@  discard block
 block discarded – undo
749 749
 
750 750
 		$forms = FrmForm::get_published_forms();
751 751
 		foreach ( $forms as $form ) {
752
-			$new_style      = ( isset( $_POST['style'] ) && isset( $_POST['style'][ $form->id ] ) ) ? sanitize_text_field( wp_unslash( $_POST['style'][ $form->id ] ) ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
753
-			$previous_style = ( isset( $_POST['prev_style'] ) && isset( $_POST['prev_style'][ $form->id ] ) ) ? sanitize_text_field( wp_unslash( $_POST['prev_style'][ $form->id ] ) ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
752
+			$new_style      = ( isset( $_POST['style'] ) && isset( $_POST['style'][$form->id] ) ) ? sanitize_text_field( wp_unslash( $_POST['style'][$form->id] ) ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
753
+			$previous_style = ( isset( $_POST['prev_style'] ) && isset( $_POST['prev_style'][$form->id] ) ) ? sanitize_text_field( wp_unslash( $_POST['prev_style'][$form->id] ) ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
754 754
 			if ( $new_style == $previous_style ) {
755 755
 				continue;
756 756
 			}
@@ -1159,8 +1159,8 @@  discard block
 block discarded – undo
1159 1159
 	 */
1160 1160
 	public static function get_style_val( $val, $form = 'default' ) {
1161 1161
 		$style = self::get_form_style( $form );
1162
-		if ( $style && isset( $style->post_content[ $val ] ) ) {
1163
-			return $style->post_content[ $val ];
1162
+		if ( $style && isset( $style->post_content[$val] ) ) {
1163
+			return $style->post_content[$val];
1164 1164
 		}
1165 1165
 	}
1166 1166
 
@@ -1179,7 +1179,7 @@  discard block
 block discarded – undo
1179 1179
 			} elseif ( 'alt_bg_color' == $name ) {
1180 1180
 				$setting = 'bg_color_active';
1181 1181
 			}
1182
-			$default_styles[ $name ] = $style->post_content[ $setting ];
1182
+			$default_styles[$name] = $style->post_content[$setting];
1183 1183
 			unset( $name, $val );
1184 1184
 		}
1185 1185
 
@@ -1225,16 +1225,16 @@  discard block
 block discarded – undo
1225 1225
 		$i          = 0;
1226 1226
 		$first_open = false;
1227 1227
 
1228
-		if ( isset( $wp_meta_boxes[ $page ][ $context ] ) ) {
1228
+		if ( isset( $wp_meta_boxes[$page][$context] ) ) {
1229 1229
 			foreach ( array( 'high', 'core', 'default', 'low' ) as $priority ) {
1230
-				if ( isset( $wp_meta_boxes[ $page ][ $context ][ $priority ] ) ) {
1231
-					foreach ( $wp_meta_boxes[ $page ][ $context ][ $priority ] as $box ) {
1230
+				if ( isset( $wp_meta_boxes[$page][$context][$priority] ) ) {
1231
+					foreach ( $wp_meta_boxes[$page][$context][$priority] as $box ) {
1232 1232
 						if ( false === $box || ! $box['title'] ) {
1233 1233
 							continue;
1234 1234
 						}
1235 1235
 
1236
-						++$i;
1237
-						$icon_id = array_key_exists( $box['id'], $icon_ids ) ? $icon_ids[ $box['id'] ] : 'frm-' . $box['id'];
1236
+						++ $i;
1237
+						$icon_id = array_key_exists( $box['id'], $icon_ids ) ? $icon_ids[$box['id']] : 'frm-' . $box['id'];
1238 1238
 
1239 1239
 						$open_class = '';
1240 1240
 						if ( ! $first_open ) {
Please login to merge, or discard this patch.
classes/models/FrmStyle.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,8 @@
 block discarded – undo
67 67
 			$new_instance = (array) $new_instance;
68 68
 			$this->id     = $new_instance['ID'];
69 69
 
70
-			if ( $id != $this->id || ! $_POST || ! isset( $_POST['frm_style_setting'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
70
+			if ( $id != $this->id || ! $_POST || ! isset( $_POST['frm_style_setting'] ) ) {
71
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
71 72
 				// Don't continue if not saving this style.
72 73
 				continue;
73 74
 			}
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -102,21 +102,21 @@  discard block
 block discarded – undo
102 102
 			$default_settings = $this->get_defaults();
103 103
 
104 104
 			foreach ( $default_settings as $setting => $default ) {
105
-				if ( ! isset( $new_instance['post_content'][ $setting ] ) ) {
106
-					$new_instance['post_content'][ $setting ] = $default;
105
+				if ( ! isset( $new_instance['post_content'][$setting] ) ) {
106
+					$new_instance['post_content'][$setting] = $default;
107 107
 				}
108 108
 
109 109
 				if ( $this->is_color( $setting ) ) {
110
-					$color_val = $new_instance['post_content'][ $setting ];
110
+					$color_val = $new_instance['post_content'][$setting];
111 111
 					if ( $color_val !== '' && false !== strpos( $color_val, 'rgb' ) ) {
112 112
 						// Maybe sanitize if invalid rgba value is entered.
113 113
 						$this->maybe_sanitize_rgba_value( $color_val );
114 114
 					}
115
-					$new_instance['post_content'][ $setting ] = str_replace( '#', '', $color_val );
116
-				} elseif ( in_array( $setting, array( 'submit_style', 'important_style', 'auto_width' ), true ) && ! isset( $new_instance['post_content'][ $setting ] ) ) {
117
-					$new_instance['post_content'][ $setting ] = 0;
115
+					$new_instance['post_content'][$setting] = str_replace( '#', '', $color_val );
116
+				} elseif ( in_array( $setting, array( 'submit_style', 'important_style', 'auto_width' ), true ) && ! isset( $new_instance['post_content'][$setting] ) ) {
117
+					$new_instance['post_content'][$setting] = 0;
118 118
 				} elseif ( $setting === 'font' ) {
119
-					$new_instance['post_content'][ $setting ] = $this->force_balanced_quotation( $new_instance['post_content'][ $setting ] );
119
+					$new_instance['post_content'][$setting] = $this->force_balanced_quotation( $new_instance['post_content'][$setting] );
120 120
 				}
121 121
 			}
122 122
 
@@ -236,14 +236,14 @@  discard block
 block discarded – undo
236 236
 		$valid_keys         = array_keys( $defaults );
237 237
 		$sanitized_settings = array();
238 238
 		foreach ( $valid_keys as $key ) {
239
-			if ( isset( $settings[ $key ] ) ) {
240
-				$sanitized_settings[ $key ] = sanitize_textarea_field( $settings[ $key ] );
239
+			if ( isset( $settings[$key] ) ) {
240
+				$sanitized_settings[$key] = sanitize_textarea_field( $settings[$key] );
241 241
 			} else {
242
-				$sanitized_settings[ $key ] = $defaults[ $key ];
242
+				$sanitized_settings[$key] = $defaults[$key];
243 243
 			}
244 244
 			
245 245
 			if ( 'custom_css' !== $key ) {
246
-				$sanitized_settings[ $key ] = $this->strip_invalid_characters( $sanitized_settings[ $key ] );
246
+				$sanitized_settings[$key] = $this->strip_invalid_characters( $sanitized_settings[$key] );
247 247
 			}
248 248
 		}
249 249
 		return $sanitized_settings;
@@ -493,13 +493,13 @@  discard block
 block discarded – undo
493 493
 			$style->post_content = $this->override_defaults( $style->post_content );
494 494
 			$style->post_content = wp_parse_args( $style->post_content, $default_values );
495 495
 
496
-			$styles[ $style->ID ] = $style;
496
+			$styles[$style->ID] = $style;
497 497
 		}
498 498
 
499 499
 		if ( ! $default_style ) {
500 500
 			$default_style = reset( $styles );
501 501
 
502
-			$styles[ $default_style->ID ]->menu_order = 1;
502
+			$styles[$default_style->ID]->menu_order = 1;
503 503
 		}
504 504
 
505 505
 		return $styles;
@@ -743,7 +743,7 @@  discard block
 block discarded – undo
743 743
 				continue;
744 744
 			}
745 745
 
746
-			if ( $value && $char === $value[ strlen( $value ) - 1 ] ) {
746
+			if ( $value && $char === $value[strlen( $value ) - 1] ) {
747 747
 				$value = $char . $value;
748 748
 			} else {
749 749
 				$value .= $char;
Please login to merge, or discard this patch.
classes/helpers/FrmStylesHelper.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -285,7 +285,8 @@
 block discarded – undo
285 285
 	public static function get_settings_for_output( $style ) {
286 286
 		if ( self::previewing_style() ) {
287 287
 			$frm_style = new FrmStyle();
288
-			if ( isset( $_POST['frm_style_setting'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
288
+			if ( isset( $_POST['frm_style_setting'] ) ) {
289
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
289 290
 
290 291
 				// Sanitizing is done later.
291 292
 				$posted = wp_unslash( $_POST['frm_style_setting'] ); //phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 				'-' => 'down',
127 127
 				'+' => 'up',
128 128
 			);
129
-			$class = 'frm_arrow' . $arrow[ $icon ];
129
+			$class = 'frm_arrow' . $arrow[$icon];
130 130
 		} else {
131 131
 			// frm_minus1_icon.
132 132
 			$key   = str_replace( 'p', '', $key );
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 				'-' => 'minus',
135 135
 				'+' => 'plus',
136 136
 			);
137
-			$class = 'frm_' . $plus[ $icon ];
137
+			$class = 'frm_' . $plus[$icon];
138 138
 		}
139 139
 
140 140
 		if ( $key ) {
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
 		?>
161 161
 		<div class="btn-group" id="frm_<?php echo esc_attr( $name ); ?>_select">
162 162
 			<button class="multiselect dropdown-toggle btn btn-default" data-toggle="dropdown" type="button">
163
-				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[ $name ], '+', $type ) ); ?>
164
-				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[ $name ], '-', $type ) ); ?>
163
+				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[$name], '+', $type ) ); ?>
164
+				<?php FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $style->post_content[$name], '-', $type ) ); ?>
165 165
 				<b class="caret"></b>
166 166
 			</button>
167 167
 			<ul class="multiselect-container frm-dropdown-menu">
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 					<li <?php echo ( $style->post_content['collapse_icon'] == $key ) ? 'class="active"' : ''; ?>>
170 170
 						<a href="javascript:void(0);">
171 171
 							<label>
172
-								<input type="radio" value="<?php echo esc_attr( $key ); ?>" name="<?php echo esc_attr( $frm_style->get_field_name( $name ) ); ?>" <?php checked( $style->post_content[ $name ], $key ); ?> />
172
+								<input type="radio" value="<?php echo esc_attr( $key ); ?>" name="<?php echo esc_attr( $frm_style->get_field_name( $name ) ); ?>" <?php checked( $style->post_content[$name], $key ); ?> />
173 173
 								<span>
174 174
 									<?php
175 175
 									FrmAppHelper::icon_by_class( 'frmfont ' . self::icon_key_to_class( $key, '+', $type ) );
@@ -306,15 +306,15 @@  discard block
 block discarded – undo
306 306
 		$vars   = array_diff( $vars, $remove );
307 307
 
308 308
 		foreach ( $vars as $var ) {
309
-			if ( ! isset( $settings[ $var ] ) ) {
309
+			if ( ! isset( $settings[$var] ) ) {
310 310
 				continue;
311 311
 			}
312
-			if ( ! isset( $defaults[ $var ] ) ) {
313
-				$defaults[ $var ] = '';
312
+			if ( ! isset( $defaults[$var] ) ) {
313
+				$defaults[$var] = '';
314 314
 			}
315
-			$show = empty( $defaults ) || ( $settings[ $var ] !== '' && $settings[ $var ] !== $defaults[ $var ] );
315
+			$show = empty( $defaults ) || ( $settings[$var] !== '' && $settings[$var] !== $defaults[$var] );
316 316
 			if ( $show ) {
317
-				echo '--' . esc_html( str_replace( '_', '-', $var ) ) . ':' . ( $var === 'font' ? FrmAppHelper::kses( $settings[ $var ] ) : esc_html( $settings[ $var ] ) ) . ';'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
317
+				echo '--' . esc_html( str_replace( '_', '-', $var ) ) . ':' . ( $var === 'font' ? FrmAppHelper::kses( $settings[$var] ) : esc_html( $settings[$var] ) ) . ';'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
318 318
 			}
319 319
 		}
320 320
 	}
@@ -363,8 +363,8 @@  discard block
 block discarded – undo
363 363
 
364 364
 		$checkbox_opts = array( 'important_style', 'auto_width', 'submit_style', 'collapse_icon', 'center_form' );
365 365
 		foreach ( $checkbox_opts as $opt ) {
366
-			if ( ! isset( $settings[ $opt ] ) ) {
367
-				$settings[ $opt ] = 0;
366
+			if ( ! isset( $settings[$opt] ) ) {
367
+				$settings[$opt] = 0;
368 368
 			}
369 369
 		}
370 370
 
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
 				$css = '';
393 393
 			}
394 394
 			foreach ( $opts as $opt ) {
395
-				self::get_color_output( $css, $settings[ $opt ] );
395
+				self::get_color_output( $css, $settings[$opt] );
396 396
 			}
397 397
 		}
398 398
 	}
Please login to merge, or discard this patch.