Strategy11 / formidable-forms

classes/controllers/FrmXMLController.php

Spacing +11 added lines, -11 removed lines

@@ -163,7 +163,7 @@ 
 			return;
 		}
 
-		$selected_xml  = isset( $form['xml'] ) && isset( $form['xml'][ $selected_form ] ) ? $form['xml'][ $selected_form ] : '';
+		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][$selected_form] ) ? $form['xml'][$selected_form] : '';
 		if ( empty( $selected_xml ) || strpos( $selected_xml, 'http' ) !== 0 ) {
 			return;
 		}
@@ -178,8 +178,8 @@ 
 	 * @param array $form
 	 */
 	private static function get_selected_in_form( $form, $value = 'form' ) {
-		if ( ! empty( $form ) && isset( $form[ $value ] ) && ! empty( $form[ $value ] ) ) {
-			return $form[ $value ];
+		if ( ! empty( $form ) && isset( $form[$value] ) && ! empty( $form[$value] ) ) {
+			return $form[$value];
 		}
 
 		return '';
@@ -208,7 +208,7 @@ 
 			}
 
 			if ( $for === 'view' ) {
-				$item_key  = is_array( $view_keys ) ? $view_keys[ $form_key ] : $view_keys;
+				$item_key  = is_array( $view_keys ) ? $view_keys[$form_key] : $view_keys;
 				$shortcode = '[display-frm-data id=%1$s filter=limited]';
 			} elseif ( $for === 'form' ) {
 				$item_key = $form_key;
@@ -223,7 +223,7 @@ 
 				continue;
 			}
 
-			$page_ids[ $for ] = wp_insert_post(
+			$page_ids[$for] = wp_insert_post(
 				array(
 					'post_title'   => $name,
 					'post_type'    => 'page',
@@ -377,7 +377,7 @@ 
 		// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash
 		$file_type = sanitize_option( 'upload_path', $_FILES['frm_import_file']['name'] );
 		$file_type = strtolower( pathinfo( $file_type, PATHINFO_EXTENSION ) );
-		if ( 'xml' !== $file_type && isset( $export_format[ $file_type ] ) ) {
+		if ( 'xml' !== $file_type && isset( $export_format[$file_type] ) ) {
 			// allow other file types to be imported
 			do_action( 'frm_before_import_' . $file_type );
 
@@ -470,7 +470,7 @@ 
 		foreach ( $type as $tb_type ) {
 			$where = array();
 			$join  = '';
-			$table = $tables[ $tb_type ];
+			$table = $tables[$tb_type];
 
 			$select     = $table . '.id';
 			$query_vars = array();
@@ -485,7 +485,7 @@ 
 							$table . '.parent_form_id' => $args['ids'],
 						);
 					} else {
-						$where[ $table . '.status !' ] = 'draft';
+						$where[$table . '.status !'] = 'draft';
 					}
 					break;
 				case 'actions':
@@ -498,7 +498,7 @@ 
 				case 'items':
 					// $join = "INNER JOIN {$wpdb->prefix}frm_item_metas im ON ($table.id = im.item_id)";
 					if ( $args['ids'] ) {
-						$where[ $table . '.form_id' ] = $args['ids'];
+						$where[$table . '.form_id'] = $args['ids'];
 					}
 					break;
 				case 'styles':
@@ -539,7 +539,7 @@ 
 					}
 			}
 
-			$records[ $tb_type ] = FrmDb::get_col( $table . $join, $where, $select );
+			$records[$tb_type] = FrmDb::get_col( $table . $join, $where, $select );
 			unset( $tb_type );
 		}
 
@@ -710,7 +710,7 @@ 
 		$no_export_fields = FrmField::no_save_fields();
 		foreach ( $csv_fields as $k => $f ) {
 			if ( in_array( $f->type, $no_export_fields, true ) ) {
-				unset( $csv_fields[ $k ] );
+				unset( $csv_fields[$k] );
 			}
 		}
 

classes/models/fields/FrmFieldNumber.php

Spacing +5 added lines, -5 removed lines

@@ -63,7 +63,7 @@ 
 
 		//validate the number format
 		if ( ! is_numeric( $args['value'] ) && '' !== $args['value'] ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
 		}
 
 		// validate number settings
@@ -75,9 +75,9 @@ 
 			if ( $frm_settings->use_html && $maxnum !== '' && $minnum !== '' ) {
 				$value = (float) $args['value'];
 				if ( $value < $minnum ) {
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a higher number', 'formidable' );
+					$errors['field' . $args['id']] = __( 'Please select a higher number', 'formidable' );
 				} elseif ( $value > $maxnum ) {
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a lower number', 'formidable' );
+					$errors['field' . $args['id']] = __( 'Please select a lower number', 'formidable' );
 				}
 			}
 
@@ -98,7 +98,7 @@ 
 	 * @return void
 	 */
 	private function validate_step( &$errors, $args ) {
-		if ( isset( $errors[ 'field' . $args['id'] ] ) ) {
+		if ( isset( $errors['field' . $args['id']] ) ) {
 			return; // Don't need to check if value is invalid before.
 		}
 
@@ -112,7 +112,7 @@ 
 			return;
 		}
 
-		$errors[ 'field' . $args['id'] ] = sprintf(
+		$errors['field' . $args['id']] = sprintf(
 			// Translators: %1$s: the first nearest value; %2$s: the second nearest value.
 			__( 'Please enter a valid value. Two nearest valid values are %1$s and %2$s', 'formidable' ),
 			floatval( $result[0] ),

classes/models/FrmEntryValues.php

Spacing +6 added lines, -6 removed lines

@@ -181,12 +181,12 @@ 
 	 * @return array
 	 */
 	private function prepare_array_property( $index, $atts ) {
-		if ( isset( $atts[ $index ] ) && ! empty( $atts[ $index ] ) ) {
+		if ( isset( $atts[$index] ) && ! empty( $atts[$index] ) ) {
 
-			if ( is_array( $atts[ $index ] ) ) {
-				$property = $atts[ $index ];
+			if ( is_array( $atts[$index] ) ) {
+				$property = $atts[$index];
 			} else {
-				$property = explode( ',', $atts[ $index ] );
+				$property = explode( ',', $atts[$index] );
 			}
 		} else {
 			$property = array();
@@ -266,7 +266,7 @@ 
 			);
 		}
 
-		$ip      = array(
+		$ip = array(
 			'label' => __( 'IP Address', 'formidable' ),
 			'value' => $this->entry->ip,
 		);
@@ -356,6 +356,6 @@ 
 	 * @return void
 	 */
 	protected function add_field_values( $field ) {
-		$this->field_values[ $field->id ] = new FrmFieldValue( $field, $this->entry );
+		$this->field_values[$field->id] = new FrmFieldValue( $field, $this->entry );
 	}
 }

classes/models/FrmReviews.php

Spacing +4 added lines, -4 removed lines

@@ -80,12 +80,12 @@ 
 		$show_intervals = array( 50, 200, 500 );
 		$asked          = $this->review_status['asked'];
 
-		if ( ! isset( $show_intervals[ $asked ] ) ) {
+		if ( ! isset( $show_intervals[$asked] ) ) {
 			return;
 		}
 
 		$entries = FrmEntry::getRecordCount();
-		$count   = $show_intervals[ $asked ];
+		$count   = $show_intervals[$asked];
 		$user    = wp_get_current_user();
 
 		// Only show review request if the site has collected enough entries
@@ -134,7 +134,7 @@ 
 		$requests = $message->get_messages();
 		$key      = $this->inbox_key . ( $asked ? $asked : '' );
 
-		if ( isset( $requests[ $key ] ) ) {
+		if ( isset( $requests[$key] ) ) {
 			return;
 		}
 
@@ -173,7 +173,7 @@ 
 	 * @return bool
 	 */
 	private function has_later_request( $requests, $asked ) {
-		return isset( $requests[ $this->inbox_key . ( $asked + 1 ) ] ) || isset( $requests[ $this->inbox_key . ( $asked + 2 ) ] );
+		return isset( $requests[$this->inbox_key . ( $asked + 1 )] ) || isset( $requests[$this->inbox_key . ( $asked + 2 )] );
 	}
 
 	/**

classes/models/FrmInbox.php

Spacing +27 added lines, -27 removed lines

@@ -105,7 +105,7 @@ 
 			return;
 		}
 
-		if ( isset( self::$messages[ $message['key'] ] ) && ! isset( $message['force'] ) ) {
+		if ( isset( self::$messages[$message['key']] ) && ! isset( $message['force'] ) ) {
 			// Don't replace messages unless required.
 			return;
 		}
@@ -114,13 +114,13 @@ 
 			return;
 		}
 
-		if ( isset( self::$messages[ $message['key'] ] ) ) {
+		if ( isset( self::$messages[$message['key']] ) ) {
 			// Move up and mark as new.
-			unset( self::$messages[ $message['key'] ] );
+			unset( self::$messages[$message['key']] );
 		}
 
 		$this->fill_message( $message );
-		self::$messages[ $message['key'] ] = $message;
+		self::$messages[$message['key']] = $message;
 
 		$this->update_list();
 
@@ -156,11 +156,11 @@ 
 	private function clean_messages() {
 		$removed = false;
 		foreach ( self::$messages as $t => $message ) {
-			$read      = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][ get_current_user_id() ] ) && $message['read'][ get_current_user_id() ] < strtotime( '-1 month' );
-			$dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][ get_current_user_id() ] ) && $message['dismissed'][ get_current_user_id() ] < strtotime( '-1 week' );
+			$read      = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][get_current_user_id()] ) && $message['read'][get_current_user_id()] < strtotime( '-1 month' );
+			$dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][get_current_user_id()] ) && $message['dismissed'][get_current_user_id()] < strtotime( '-1 week' );
 			$expired   = $this->is_expired( $message );
 			if ( $read || $expired || $dismissed ) {
-				unset( self::$messages[ $t ] );
+				unset( self::$messages[$t] );
 				$removed = true;
 			}
 		}
@@ -176,11 +176,11 @@ 
 	private function filter_messages( &$messages ) {
 		$user_id = get_current_user_id();
 		foreach ( $messages as $k => $message ) {
-			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][ $user_id ] );
+			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][$user_id] );
 			if ( empty( $k ) || $this->is_expired( $message ) || $dismissed ) {
-				unset( $messages[ $k ] );
+				unset( $messages[$k] );
 			} elseif ( ! $this->is_for_user( $message ) ) {
-				unset( $messages[ $k ] );
+				unset( $messages[$k] );
 			}
 		}
 		$messages = apply_filters( 'frm_filter_inbox', $messages );
@@ -226,14 +226,14 @@ 
 	 * @return void
 	 */
 	public function mark_read( $key ) {
-		if ( ! $key || ! isset( self::$messages[ $key ] ) ) {
+		if ( ! $key || ! isset( self::$messages[$key] ) ) {
 			return;
 		}
 
-		if ( ! isset( self::$messages[ $key ]['read'] ) ) {
-			self::$messages[ $key ]['read'] = array();
+		if ( ! isset( self::$messages[$key]['read'] ) ) {
+			self::$messages[$key]['read'] = array();
 		}
-		self::$messages[ $key ]['read'][ get_current_user_id() ] = time();
+		self::$messages[$key]['read'][get_current_user_id()] = time();
 
 		$this->update_list();
 	}
@@ -246,9 +246,9 @@ 
 	 * @return void
 	 */
 	public function mark_unread( $key ) {
-		$is_read = isset( self::$messages[ $key ] ) && isset( self::$messages[ $key ]['read'] ) && isset( self::$messages[ $key ]['read'][ get_current_user_id() ] );
+		$is_read = isset( self::$messages[$key] ) && isset( self::$messages[$key]['read'] ) && isset( self::$messages[$key]['read'][get_current_user_id()] );
 		if ( $is_read ) {
-			unset( self::$messages[ $key ]['read'][ get_current_user_id() ] );
+			unset( self::$messages[$key]['read'][get_current_user_id()] );
 			$this->update_list();
 		}
 	}
@@ -264,14 +264,14 @@ 
 			return;
 		}
 
-		if ( ! isset( self::$messages[ $key ] ) ) {
+		if ( ! isset( self::$messages[$key] ) ) {
 			return;
 		}
 
-		if ( ! isset( self::$messages[ $key ]['dismissed'] ) ) {
-			self::$messages[ $key ]['dismissed'] = array();
+		if ( ! isset( self::$messages[$key]['dismissed'] ) ) {
+			self::$messages[$key]['dismissed'] = array();
 		}
-		self::$messages[ $key ]['dismissed'][ get_current_user_id() ] = time();
+		self::$messages[$key]['dismissed'][get_current_user_id()] = time();
 
 		$this->update_list();
 	}
@@ -285,11 +285,11 @@ 
 		$user_id = get_current_user_id();
 		foreach ( self::$messages as $key => $message ) {
 			if ( ! isset( $message['dismissed'] ) ) {
-				self::$messages[ $key ]['dismissed'] = array();
+				self::$messages[$key]['dismissed'] = array();
 			}
 
-			if ( ! isset( $message['dismissed'][ $user_id ] ) ) {
-				self::$messages[ $key ]['dismissed'][ $user_id ] = time();
+			if ( ! isset( $message['dismissed'][$user_id] ) ) {
+				self::$messages[$key]['dismissed'][$user_id] = time();
 			}
 		}
 		$this->update_list();
@@ -299,8 +299,8 @@ 
 		$messages = $this->get_messages( 'filter' );
 		$user_id  = get_current_user_id();
 		foreach ( $messages as $t => $message ) {
-			if ( isset( $message['read'] ) && isset( $message['read'][ $user_id ] ) ) {
-				unset( $messages[ $t ] );
+			if ( isset( $message['read'] ) && isset( $message['read'][$user_id] ) ) {
+				unset( $messages[$t] );
 			}
 		}
 		return $messages;
@@ -328,8 +328,8 @@ 
 	 * @return void
 	 */
 	public function remove( $key ) {
-		if ( isset( self::$messages[ $key ] ) ) {
-			unset( self::$messages[ $key ] );
+		if ( isset( self::$messages[$key] ) ) {
+			unset( self::$messages[$key] );
 			$this->update_list();
 		}
 	}

classes/models/FrmTableHTMLGenerator.php

Spacing +4 added lines, -4 removed lines

@@ -86,7 +86,7 @@ 
 	 * @return void
 	 */
 	private function init_style_settings( $atts ) {
-		$style_settings       = array(
+		$style_settings = array(
 			'border_color' => 'dddddd',
 			'bg_color'     => 'f7f7f7',
 			'text_color'   => '444444',
@@ -97,12 +97,12 @@ 
 		$this->style_settings = apply_filters( 'frm_show_entry_styles', $style_settings );
 
 		foreach ( $this->style_settings as $key => $setting ) {
-			if ( isset( $atts[ $key ] ) && $atts[ $key ] !== '' ) {
-				$this->style_settings[ $key ] = $atts[ $key ];
+			if ( isset( $atts[$key] ) && $atts[$key] !== '' ) {
+				$this->style_settings[$key] = $atts[$key];
 			}
 
 			if ( $this->is_color_setting( $key ) ) {
-				$this->style_settings[ $key ] = $this->get_color_markup( $this->style_settings[ $key ] );
+				$this->style_settings[$key] = $this->get_color_markup( $this->style_settings[$key] );
 			}
 		}
 

classes/models/FrmFormState.php

Spacing +4 added lines, -4 removed lines

@@ -59,7 +59,7 @@ 
 	 * @return void
 	 */
 	public function set( $key, $value ) {
-		$this->state[ $key ] = $value;
+		$this->state[$key] = $value;
 	}
 
 	/**
@@ -75,8 +75,8 @@ 
 	}
 
 	public function get( $key, $default ) {
-		if ( isset( $this->state[ $key ] ) ) {
-			return $this->state[ $key ];
+		if ( isset( $this->state[$key] ) ) {
+			return $this->state[$key];
 		}
 		return $default;
 	}
@@ -171,7 +171,7 @@ 
 	private function compressed_state() {
 		$compressed = array();
 		foreach ( $this->state as $key => $value ) {
-			$compressed[ self::compressed_key( $key ) ] = $value;
+			$compressed[self::compressed_key( $key )] = $value;
 		}
 		return $compressed;
 	}

classes/controllers/FrmEntriesAJAXSubmitController.php

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 			foreach ( $errors as $field => $error ) {
 				$field_id         = str_replace( 'field', '', $field );
 				$error            = self::maybe_modify_ajax_error( $error, $field_id, $form, $errors );
-				$obj[ $field_id ] = $error;
+				$obj[$field_id] = $error;
 			}
 
 			$response['errors']        = $obj;

classes/models/FrmEntry.php

Spacing +19 added lines, -19 removed lines

@@ -80,7 +80,7 @@ 
 			$metas       = FrmEntryMeta::get_entry_meta_info( $entry_exist );
 			$field_metas = array();
 			foreach ( $metas as $meta ) {
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
+				$field_metas[$meta->field_id] = $meta->meta_value;
 			}
 
 			$filtered_vals = array_filter( $values['item_meta'] );
@@ -136,10 +136,10 @@ 
 		$reduced = array();
 		foreach ( $filter_vals as $field_id => $value ) {
 			$field                = FrmFieldFactory::get_field_object( $field_id );
-			$reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
-			$reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] );
-			if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) {
-				unset( $reduced[ $field_id ] );
+			$reduced[$field_id] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
+			$reduced[$field_id] = $field->set_value_before_save( $reduced[$field_id] );
+			if ( '' === $reduced[$field_id] || ( is_array( $reduced[$field_id] ) && 0 === count( $reduced[$field_id] ) ) ) {
+				unset( $reduced[$field_id] );
 			}
 		}
 		return $reduced;
@@ -354,7 +354,7 @@ 
 		$query = "SELECT it.*, fr.name as form_name, fr.form_key as form_key FROM {$wpdb->prefix}frm_items it
                   LEFT OUTER JOIN {$wpdb->prefix}frm_forms fr ON it.form_id=fr.id WHERE ";
 
-		$query      .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s';
+		$query .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s';
 		$query_args = array( $id );
 		$query      = $wpdb->prepare( $query, $query_args ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
 
@@ -399,7 +399,7 @@ 
 	private static function prepare_entries( &$entries ) {
 		foreach ( $entries as $k => $entry ) {
 			self::prepare_entry( $entry );
-			$entries[ $k ] = $entry;
+			$entries[$k] = $entry;
 		}
 	}
 
@@ -425,19 +425,19 @@ 
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
 
 			if ( $meta_val->item_id == $entry->id ) {
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
 				if ( $include_key ) {
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
 				}
 				continue;
 			}
 
 			// include sub entries in an array
-			if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) {
-				$entry->metas[ $meta_val->field_id ] = array();
+			if ( ! isset( $entry->metas[$meta_val->field_id] ) ) {
+				$entry->metas[$meta_val->field_id] = array();
 			}
 
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
 
 			unset( $meta_val );
 		}
@@ -484,7 +484,7 @@ 
 
 			if ( $inc_form ) {
 				$fields = 'it.*, fr.name as form_name,fr.form_key as form_key';
-				$table  .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id ';
+				$table .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id ';
 			}
 
 			if ( preg_match( '/ meta_([0-9]+)/', $order_by, $order_matches ) ) {
@@ -532,16 +532,16 @@ 
 		}
 
 		foreach ( $metas as $m_key => $meta_val ) {
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
 				continue;
 			}
 
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
-				$entries[ $meta_val->item_id ]->metas = array();
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
+				$entries[$meta_val->item_id]->metas = array();
 			}
 
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
 			unset( $m_key, $meta_val );
 		}
 
@@ -719,7 +719,7 @@ 
 	}
 
 	private static function get_entry_value( $values, $name, $default ) {
-		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
+		return isset( $values[$name] ) ? $values[$name] : $default;
 	}
 
 	/**
@@ -900,7 +900,7 @@ 
 	private static function maybe_add_captcha_meta( $form_id, $entry_id ) {
 		global $frm_vars;
 		if ( array_key_exists( 'captcha_scores', $frm_vars ) && array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) {
-			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] );
+			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][$form_id] );
 			FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) );
 		}
 	}