Completed
Pull Request — master (#1839)
by Stephanie
01:04
created
classes/controllers/FrmAppController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -64,14 +64,14 @@  discard block
 block discarded – undo
64 64
 
65 65
 		add_action(
66 66
 			'admin_menu',
67
-			function () use ( $black_friday_menu_label ) {
67
+			function() use ( $black_friday_menu_label ) {
68 68
 				add_submenu_page(
69 69
 					'formidable',
70 70
 					'Formidable',
71 71
 					$black_friday_menu_label,
72 72
 					'frm_change_settings',
73 73
 					'formidable-black-friday',
74
-					function () {
74
+					function() {
75 75
 						// This function should do nothing. The redirect is handled earlier to avoid header conflicts.
76 76
 					}
77 77
 				);
@@ -1395,15 +1395,15 @@  discard block
 block discarded – undo
1395 1395
 		global $wp_filter;
1396 1396
 
1397 1397
 		foreach ( $actions as $action ) {
1398
-			if ( empty( $wp_filter[ $action ]->callbacks ) ) {
1398
+			if ( empty( $wp_filter[$action]->callbacks ) ) {
1399 1399
 				continue;
1400 1400
 			}
1401
-			foreach ( $wp_filter[ $action ]->callbacks as $priority => $callbacks ) {
1401
+			foreach ( $wp_filter[$action]->callbacks as $priority => $callbacks ) {
1402 1402
 				foreach ( $callbacks as $callback_name => $callback ) {
1403 1403
 					if ( self::is_our_callback_string( $callback_name ) || self::is_our_callback_array( $callback ) ) {
1404 1404
 						continue;
1405 1405
 					}
1406
-					unset( $wp_filter[ $action ]->callbacks[ $priority ][ $callback_name ] );
1406
+					unset( $wp_filter[$action]->callbacks[$priority][$callback_name] );
1407 1407
 				}
1408 1408
 			}
1409 1409
 		}
Please login to merge, or discard this patch.
classes/controllers/FrmAddonsController.php 1 patch
Spacing   +26 added lines, -28 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 				'<span class="frm-upgrade-submenu">' . __( 'Upgrade', 'formidable' ) . '</span>',
112 112
 				'frm_view_forms',
113 113
 				'formidable-pro-upgrade',
114
-				function () {
114
+				function() {
115 115
 					// This function doesn't need to do anything.
116 116
 					// The redirect is handled earlier to avoid issues with the headers being sent.
117 117
 				}
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 			unset( $addons['error'] );
143 143
 		}
144 144
 
145
-		$pro    = array(
145
+		$pro = array(
146 146
 			'pro' => array(
147 147
 				'title'      => 'Formidable Forms Pro',
148 148
 				'slug'       => 'formidable-pro',
@@ -184,9 +184,9 @@  discard block
 block discarded – undo
184 184
 
185 185
 		// Extract the elements to move
186 186
 		foreach ( $plans as $plan ) {
187
-			if ( isset( self::$categories[ $plan ] ) ) {
188
-				$bottom_categories[ $plan ] = self::$categories[ $plan ];
189
-				unset( self::$categories[ $plan ] );
187
+			if ( isset( self::$categories[$plan] ) ) {
188
+				$bottom_categories[$plan] = self::$categories[$plan];
189
+				unset( self::$categories[$plan] );
190 190
 			}
191 191
 		}
192 192
 
@@ -240,14 +240,12 @@  discard block
 block discarded – undo
240 240
 			// Add the slug to the new array.
241 241
 			$addon['category-slugs'][] = $category_slug;
242 242
 
243
-			if ( ! isset( self::$categories[ $category_slug ] ) ) {
244
-				self::$categories[ $category_slug ] = array(
243
+			if ( ! isset( self::$categories[$category_slug] ) ) {
244
+				self::$categories[$category_slug] = array(
245 245
 					'name'  => $category,
246 246
 					'count' => 0,
247 247
 				);
248
-			}
249
-
250
-			++self::$categories[ $category_slug ]['count'];
248
+			} ++self::$categories[$category_slug]['count'];
251 249
 		}
252 250
 	}
253 251
 
@@ -279,7 +277,7 @@  discard block
 block discarded – undo
279 277
 		} else {
280 278
 			foreach ( $addons as $k => $addon ) {
281 279
 				if ( empty( $addon['excerpt'] ) && $k !== 'error' ) {
282
-					unset( $addons[ $k ] );
280
+					unset( $addons[$k] );
283 281
 				}
284 282
 			}
285 283
 		}
@@ -393,7 +391,7 @@  discard block
 block discarded – undo
393 391
 
394 392
 		foreach ( $list as $k => $info ) {
395 393
 			$info['slug'] = $k;
396
-			$list[ $k ]   = array_merge( $defaults, $info );
394
+			$list[$k]   = array_merge( $defaults, $info );
397 395
 		}
398 396
 		return $list;
399 397
 	}
@@ -544,17 +542,17 @@  discard block
 block discarded – undo
544 542
 				continue;
545 543
 			}
546 544
 
547
-			$wp_plugin    = isset( $wp_plugins[ $folder ] ) ? $wp_plugins[ $folder ] : array();
545
+			$wp_plugin    = isset( $wp_plugins[$folder] ) ? $wp_plugins[$folder] : array();
548 546
 			$wp_version   = isset( $wp_plugin['Version'] ) ? $wp_plugin['Version'] : '1.0';
549 547
 			$plugin->slug = explode( '/', $folder )[0];
550 548
 
551 549
 			if ( version_compare( $wp_version, $plugin->new_version, '<' ) ) {
552
-				$transient->response[ $folder ] = $plugin;
550
+				$transient->response[$folder] = $plugin;
553 551
 			} else {
554
-				$transient->no_update[ $folder ] = $plugin;
552
+				$transient->no_update[$folder] = $plugin;
555 553
 			}
556 554
 
557
-			$transient->checked[ $folder ] = $wp_version;
555
+			$transient->checked[$folder] = $wp_version;
558 556
 
559 557
 		}//end foreach
560 558
 
@@ -587,7 +585,7 @@  discard block
 block discarded – undo
587 585
 	 */
588 586
 	protected static function is_installed( $plugin ) {
589 587
 		$all_plugins = self::get_plugins();
590
-		return isset( $all_plugins[ $plugin ] );
588
+		return isset( $all_plugins[$plugin] );
591 589
 	}
592 590
 
593 591
 	/**
@@ -626,13 +624,13 @@  discard block
 block discarded – undo
626 624
 			}
627 625
 
628 626
 			$download_id = isset( $plugin['id'] ) ? $plugin['id'] : 0;
629
-			if ( ! empty( $download_id ) && ! isset( $version_info[ $download_id ]['package'] ) ) {
627
+			if ( ! empty( $download_id ) && ! isset( $version_info[$download_id]['package'] ) ) {
630 628
 				// if this addon is using its own license, get the update url
631 629
 				$addon_info = $api->get_api_info();
632 630
 
633
-				$version_info[ $download_id ] = $addon_info[ $download_id ];
631
+				$version_info[$download_id] = $addon_info[$download_id];
634 632
 				if ( isset( $addon_info['error'] ) ) {
635
-					$version_info[ $download_id ]['error'] = array(
633
+					$version_info[$download_id]['error'] = array(
636 634
 						'message' => $addon_info['error']['message'],
637 635
 						'code'    => $addon_info['error']['code'],
638 636
 					);
@@ -731,8 +729,8 @@  discard block
 block discarded – undo
731 729
 					return $addon;
732 730
 				}
733 731
 			}
734
-		} elseif ( isset( $addons[ $download_id ] ) ) {
735
-			$plugin = $addons[ $download_id ];
732
+		} elseif ( isset( $addons[$download_id] ) ) {
733
+			$plugin = $addons[$download_id];
736 734
 		}
737 735
 
738 736
 		return $plugin;
@@ -798,7 +796,7 @@  discard block
 block discarded – undo
798 796
 			self::set_addon_status( $addon );
799 797
 			self::set_categories( $addon );
800 798
 
801
-			$addons[ $id ] = $addon;
799
+			$addons[$id] = $addon;
802 800
 		}//end foreach
803 801
 	}
804 802
 
@@ -839,7 +837,7 @@  discard block
 block discarded – undo
839 837
 			'utm_medium'   => 'addons',
840 838
 			'utm_campaign' => 'liteplugin',
841 839
 		);
842
-		$link       = add_query_arg( $query_args, $link );
840
+		$link = add_query_arg( $query_args, $link );
843 841
 	}
844 842
 
845 843
 	/**
@@ -1057,7 +1055,7 @@  discard block
 block discarded – undo
1057 1055
 	 */
1058 1056
 	public static function ajax_activate_addon() {
1059 1057
 		self::process_addon_action(
1060
-			function ( $plugin ) {
1058
+			function( $plugin ) {
1061 1059
 				return self::handle_addon_action( $plugin, 'activate' );
1062 1060
 			},
1063 1061
 			array( 'FrmAddonsController', 'get_addon_activation_response' )
@@ -1082,7 +1080,7 @@  discard block
 block discarded – undo
1082 1080
 	 */
1083 1081
 	public static function ajax_deactivate_addon() {
1084 1082
 		self::process_addon_action(
1085
-			function ( $plugin ) {
1083
+			function( $plugin ) {
1086 1084
 				return self::handle_addon_action( $plugin, 'deactivate' );
1087 1085
 			}
1088 1086
 		);
@@ -1097,7 +1095,7 @@  discard block
 block discarded – undo
1097 1095
 	 */
1098 1096
 	public static function ajax_uninstall_addon() {
1099 1097
 		self::process_addon_action(
1100
-			function ( $plugin ) {
1098
+			function( $plugin ) {
1101 1099
 				return self::handle_addon_action( $plugin, 'uninstall' );
1102 1100
 			}
1103 1101
 		);
@@ -1494,7 +1492,7 @@  discard block
 block discarded – undo
1494 1492
 		$addons = $api->get_api_info();
1495 1493
 
1496 1494
 		if ( is_array( $addons ) && array_key_exists( $addon_id, $addons ) ) {
1497
-			$dates    = $addons[ $addon_id ];
1495
+			$dates    = $addons[$addon_id];
1498 1496
 			$requires = FrmFormsHelper::get_plan_required( $dates );
1499 1497
 		}
1500 1498
 
Please login to merge, or discard this patch.
classes/views/frm-entries/direct.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 
6 6
 add_filter(
7 7
 	'document_title',
8
-	function ( $title ) use ( $form ) {
8
+	function( $title ) use ( $form ) {
9 9
 		$form_name = '' === $form->name ? FrmFormsHelper::get_no_title_text() : $form->name;
10 10
 		return get_bloginfo( 'name', 'display' ) . ' | ' . wp_strip_all_tags( $form_name );
11 11
 	}
Please login to merge, or discard this patch.
classes/widgets/FrmElementorWidget.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
 
76 76
 			foreach ( $forms as $form ) {
77 77
 				$form_title           = '' === $form->name ? FrmFormsHelper::get_no_title_text() : FrmAppHelper::truncate( $form->name, 50 );
78
-				$options[ $form->id ] = esc_html( $form_title );
78
+				$options[$form->id] = esc_html( $form_title );
79 79
 			}
80 80
 
81 81
 			return $options;
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldType.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -156,8 +156,8 @@  discard block
 block discarded – undo
156 156
 		$field_val = '';
157 157
 		if ( is_object( $this->field ) ) {
158 158
 			$field_val = $this->field->{$column};
159
-		} elseif ( is_array( $this->field ) && isset( $this->field[ $column ] ) ) {
160
-			$field_val = $this->field[ $column ];
159
+		} elseif ( is_array( $this->field ) && isset( $this->field[$column] ) ) {
160
+			$field_val = $this->field[$column];
161 161
 		}
162 162
 
163 163
 		return $field_val;
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 		if ( is_object( $this->field ) ) {
172 172
 			$this->field->{$column} = $value;
173 173
 		} elseif ( is_array( $this->field ) ) {
174
-			$this->field[ $column ] = $value;
174
+			$this->field[$column] = $value;
175 175
 		}
176 176
 	}
177 177
 
@@ -613,7 +613,7 @@  discard block
 block discarded – undo
613 613
 			printf(
614 614
 				/* translators: %s: Field type */
615 615
 				esc_html__( '%s Options', 'formidable' ),
616
-				esc_html( $all_field_types[ $args['display']['type'] ]['name'] )
616
+				esc_html( $all_field_types[$args['display']['type']]['name'] )
617 617
 			);
618 618
 			FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown6_icon', array( 'aria-hidden' => 'true' ) );
619 619
 			?>
@@ -713,7 +713,7 @@  discard block
 block discarded – undo
713 713
 	 * New field
714 714
 	 */
715 715
 	public function get_new_field_defaults() {
716
-		$field        = array(
716
+		$field = array(
717 717
 			'name'          => $this->get_new_field_name(),
718 718
 			'description'   => '',
719 719
 			'type'          => $this->type,
@@ -744,8 +744,8 @@  discard block
 block discarded – undo
744 744
 
745 745
 		$fields = array_merge( $fields, $pro_fields );
746 746
 
747
-		if ( isset( $fields[ $this->type ] ) ) {
748
-			$name = is_array( $fields[ $this->type ] ) ? $fields[ $this->type ]['name'] : $fields[ $this->type ];
747
+		if ( isset( $fields[$this->type] ) ) {
748
+			$name = is_array( $fields[$this->type] ) ? $fields[$this->type]['name'] : $fields[$this->type];
749 749
 		}
750 750
 
751 751
 		return $name;
@@ -762,7 +762,7 @@  discard block
 block discarded – undo
762 762
 	 * @return array
763 763
 	 */
764 764
 	public function get_default_field_options() {
765
-		$opts        = array(
765
+		$opts = array(
766 766
 			'size'               => '',
767 767
 			'max'                => '',
768 768
 			'label'              => '',
@@ -1178,8 +1178,8 @@  discard block
 block discarded – undo
1178 1178
 		$selected = $values['field_value'];
1179 1179
 
1180 1180
 		if ( isset( $values['combo_name'] ) ) {
1181
-			$options  = $options[ $values['combo_name'] ];
1182
-			$selected = is_array( $selected ) && isset( $selected[ $values['combo_name'] ] ) ? $selected[ $values['combo_name'] ] : '';
1181
+			$options  = $options[$values['combo_name']];
1182
+			$selected = is_array( $selected ) && isset( $selected[$values['combo_name']] ) ? $selected[$values['combo_name']] : '';
1183 1183
 		}
1184 1184
 
1185 1185
 		$input = $this->select_tag( $values );
@@ -1234,7 +1234,7 @@  discard block
 block discarded – undo
1234 1234
 	}
1235 1235
 
1236 1236
 	protected function fill_display_field_values( $args = array() ) {
1237
-		$defaults        = array(
1237
+		$defaults = array(
1238 1238
 			'field_name'    => 'item_meta[' . $this->get_field_column( 'id' ) . ']',
1239 1239
 			'field_id'      => $this->get_field_column( 'id' ),
1240 1240
 			'field_plus_id' => '',
@@ -1291,7 +1291,7 @@  discard block
 block discarded – undo
1291 1291
 			}
1292 1292
 		}
1293 1293
 
1294
-		if ( isset( $args['errors'][ 'field' . $args['field_id'] ] ) && ! $custom_error_fields ) {
1294
+		if ( isset( $args['errors']['field' . $args['field_id']] ) && ! $custom_error_fields ) {
1295 1295
 			if ( $error_comes_first ) {
1296 1296
 				array_unshift( $describedby, 'frm_error_' . $args['html_id'] );
1297 1297
 			} else {
@@ -1370,11 +1370,11 @@  discard block
 block discarded – undo
1370 1370
 
1371 1371
 		$field_id = $this->get_field_column( 'id' );
1372 1372
 		if ( ! array_key_exists( $field_id, $frm_validated_unique_values ) ) {
1373
-			$frm_validated_unique_values[ $field_id ] = array();
1373
+			$frm_validated_unique_values[$field_id] = array();
1374 1374
 			return false;
1375 1375
 		}
1376 1376
 
1377
-		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[ $field_id ], true );
1377
+		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[$field_id], true );
1378 1378
 		return $already_validated_this_value;
1379 1379
 	}
1380 1380
 
@@ -1399,7 +1399,7 @@  discard block
 block discarded – undo
1399 1399
 	private function value_validated_as_unique( $value ) {
1400 1400
 		global $frm_validated_unique_values;
1401 1401
 		$field_id                                   = $this->get_field_column( 'id' );
1402
-		$frm_validated_unique_values[ $field_id ][] = $value;
1402
+		$frm_validated_unique_values[$field_id][] = $value;
1403 1403
 	}
1404 1404
 
1405 1405
 	/**
@@ -1440,8 +1440,8 @@  discard block
 block discarded – undo
1440 1440
 		$value = $this->prepare_display_value( $value, $atts );
1441 1441
 
1442 1442
 		if ( is_array( $value ) ) {
1443
-			if ( ! empty( $atts['show'] ) && isset( $value[ $atts['show'] ] ) ) {
1444
-				$value = $value[ $atts['show'] ];
1443
+			if ( ! empty( $atts['show'] ) && isset( $value[$atts['show']] ) ) {
1444
+				$value = $value[$atts['show']];
1445 1445
 			} elseif ( empty( $atts['return_array'] ) ) {
1446 1446
 				$sep   = isset( $atts['sep'] ) ? $atts['sep'] : ', ';
1447 1447
 				$value = FrmAppHelper::safe_implode( $sep, $value );
@@ -1571,8 +1571,8 @@  discard block
 block discarded – undo
1571 1571
 		$saved_entries = $atts['ids'];
1572 1572
 		$new_value     = array();
1573 1573
 		foreach ( (array) $value as $old_child_id ) {
1574
-			if ( isset( $saved_entries[ $old_child_id ] ) ) {
1575
-				$new_value[] = $saved_entries[ $old_child_id ];
1574
+			if ( isset( $saved_entries[$old_child_id] ) ) {
1575
+				$new_value[] = $saved_entries[$old_child_id];
1576 1576
 			}
1577 1577
 		}
1578 1578
 
Please login to merge, or discard this patch.
classes/models/FrmUsage.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
 		);
131 131
 
132 132
 		foreach ( $skipped_keys as $skipped_key ) {
133
-			unset( $data[ $skipped_key ] );
133
+			unset( $data[$skipped_key] );
134 134
 		}
135 135
 
136 136
 		return $data;
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 
216 216
 		foreach ( $pass_settings as $setting ) {
217 217
 			if ( isset( $settings_list->$setting ) ) {
218
-				$settings[ $setting ] = $this->maybe_json( $settings_list->$setting );
218
+				$settings[$setting] = $this->maybe_json( $settings_list->$setting );
219 219
 			}
220 220
 		}
221 221
 
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
 
250 250
 		$message_settings = array();
251 251
 		foreach ( $messages as $message ) {
252
-			$message_settings[ $message ] = $settings_list->$message;
252
+			$message_settings[$message] = $settings_list->$message;
253 253
 		}
254 254
 
255 255
 		return $message_settings;
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
 
270 270
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
271 271
 			if ( isset( $settings_list->$frm_role ) ) {
272
-				$permissions[ $frm_role ] = $settings_list->$frm_role;
272
+				$permissions[$frm_role] = $settings_list->$frm_role;
273 273
 			}
274 274
 		}
275 275
 
@@ -340,9 +340,9 @@  discard block
 block discarded – undo
340 340
 			);
341 341
 
342 342
 			foreach ( $settings as $setting ) {
343
-				if ( isset( $form->options[ $setting ] ) ) {
343
+				if ( isset( $form->options[$setting] ) ) {
344 344
 					if ( 'custom_style' === $setting ) {
345
-						$style->id = $form->options[ $setting ];
345
+						$style->id = $form->options[$setting];
346 346
 
347 347
 						if ( ! $style->id ) {
348 348
 							$style_name = 0;
@@ -353,9 +353,9 @@  discard block
 block discarded – undo
353 353
 							$style_name = $style_post ? $style_post->post_name : 'formidable-style';
354 354
 						}
355 355
 
356
-						$new_form[ $setting ] = $style_name;
356
+						$new_form[$setting] = $style_name;
357 357
 					} else {
358
-						$new_form[ $setting ] = $this->maybe_json( $form->options[ $setting ] );
358
+						$new_form[$setting] = $this->maybe_json( $form->options[$setting] );
359 359
 					}
360 360
 				}
361 361
 			}
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 		$fields = FrmDb::get_results( 'frm_fields', array(), 'form_id, name, type, field_options', $args );
416 416
 		foreach ( $fields as $k => $field ) {
417 417
 			FrmAppHelper::unserialize_or_decode( $field->field_options );
418
-			$fields[ $k ]->field_options = json_encode( $field->field_options );
418
+			$fields[$k]->field_options = json_encode( $field->field_options );
419 419
 		}
420 420
 		return $fields;
421 421
 	}
Please login to merge, or discard this patch.
classes/controllers/FrmUsageController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -133,15 +133,15 @@
 block discarded – undo
133 133
 			return;
134 134
 		}
135 135
 
136
-		if ( ! isset( $flows_data[ $key ] ) ) {
137
-			$flows_data[ $key ] = array();
136
+		if ( ! isset( $flows_data[$key] ) ) {
137
+			$flows_data[$key] = array();
138 138
 		}
139 139
 
140
-		if ( ! isset( $flows_data[ $key ][ $value ] ) ) {
141
-			$flows_data[ $key ][ $value ] = 0;
140
+		if ( ! isset( $flows_data[$key][$value] ) ) {
141
+			$flows_data[$key][$value] = 0;
142 142
 		}
143 143
 
144
-		$flows_data[ $key ][ $value ]++;
144
+		$flows_data[$key][$value] ++;
145 145
 		update_option( self::FLOWS_ACTION_NAME, $flows_data );
146 146
 	}
147 147
 
Please login to merge, or discard this patch.
classes/models/FrmForm.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 			}
210 210
 
211 211
 			if ( $new_val !== $value ) {
212
-				$new_values[ $key ] = $new_val;
212
+				$new_values[$key] = $new_val;
213 213
 			}
214 214
 		}//end foreach
215 215
 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 
241 241
 		foreach ( $values as $value_key => $value ) {
242 242
 			if ( $value_key && in_array( $value_key, $form_fields ) ) {
243
-				$new_values[ $value_key ] = $value;
243
+				$new_values[$value_key] = $value;
244 244
 			}
245 245
 		}
246 246
 
@@ -323,15 +323,15 @@  discard block
 block discarded – undo
323 323
 		$existing_keys = array_keys( $values['item_meta'] );
324 324
 		foreach ( $all_fields as $fid ) {
325 325
 			if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
326
-				$values['item_meta'][ $fid->id ] = '';
326
+				$values['item_meta'][$fid->id] = '';
327 327
 			}
328
-			$field_array[ $fid->id ] = $fid;
328
+			$field_array[$fid->id] = $fid;
329 329
 		}
330 330
 		unset( $all_fields );
331 331
 
332 332
 		foreach ( $values['item_meta'] as $field_id => $default_value ) {
333
-			if ( isset( $field_array[ $field_id ] ) ) {
334
-				$field = $field_array[ $field_id ];
333
+			if ( isset( $field_array[$field_id] ) ) {
334
+				$field = $field_array[$field_id];
335 335
 			} else {
336 336
 				$field = FrmField::getOne( $field_id );
337 337
 			}
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 				continue;
341 341
 			}
342 342
 
343
-			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
343
+			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options']['custom_html_' . $field_id] ) );
344 344
 			if ( $is_settings_page ) {
345 345
 				self::get_settings_page_html( $values, $field );
346 346
 
@@ -356,22 +356,22 @@  discard block
 block discarded – undo
356 356
 			$update_options = apply_filters( 'frm_field_options_to_update', $update_options );
357 357
 
358 358
 			foreach ( $update_options as $opt => $default ) {
359
-				$field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
360
-				self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
359
+				$field->field_options[$opt] = isset( $values['field_options'][$opt . '_' . $field_id] ) ? $values['field_options'][$opt . '_' . $field_id] : $default;
360
+				self::sanitize_field_opt( $opt, $field->field_options[$opt] );
361 361
 			}
362 362
 
363 363
 			$field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
364 364
 
365 365
 			$new_field = array(
366 366
 				'field_options' => $field->field_options,
367
-				'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
367
+				'default_value' => isset( $values['default_value_' . $field_id] ) ? FrmAppHelper::maybe_json_encode( $values['default_value_' . $field_id] ) : '',
368 368
 			);
369 369
 
370
-			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) {
371
-				foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
370
+			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options']['options_' . $field_id] ) && is_array( $values['field_options']['options_' . $field_id] ) ) {
371
+				foreach ( $values['field_options']['options_' . $field_id] as $option_key => $option ) {
372 372
 					if ( is_array( $option ) ) {
373 373
 						foreach ( $option as $key => $item ) {
374
-							$values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
374
+							$values['field_options']['options_' . $field_id][$option_key][$key] = FrmAppHelper::kses( $item, 'all' );
375 375
 						}
376 376
 					}
377 377
 				}
@@ -401,8 +401,8 @@  discard block
 block discarded – undo
401 401
 	 */
402 402
 	private static function maybe_update_max_option( $field, $values, &$new_field ) {
403 403
 		if ( $field->type === 'textarea' &&
404
-			! empty( $values['field_options'][ 'type_' . $field->id ] ) &&
405
-			in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
404
+			! empty( $values['field_options']['type_' . $field->id] ) &&
405
+			in_array( $values['field_options']['type_' . $field->id], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
406 406
 
407 407
 			$new_field['field_options']['max'] = '';
408 408
 
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
 			 * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
411 411
 			 * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
412 412
 			 */
413
-			$_POST['field_options'][ 'max_' . $field->id ] = '';
413
+			$_POST['field_options']['max_' . $field->id] = '';
414 414
 		}
415 415
 	}
416 416
 
@@ -486,11 +486,11 @@  discard block
 block discarded – undo
486 486
 	 * Updating the settings page
487 487
 	 */
488 488
 	private static function get_settings_page_html( $values, &$field ) {
489
-		if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
489
+		if ( isset( $values['field_options']['custom_html_' . $field->id] ) ) {
490 490
 			$prev_opts     = array();
491 491
 			$fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
492 492
 
493
-			$field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
493
+			$field->field_options['custom_html'] = isset( $values['field_options']['custom_html_' . $field->id] ) ? $values['field_options']['custom_html_' . $field->id] : $fallback_html;
494 494
 		} elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
495 495
 			$prev_opts = $field->field_options;
496 496
 		}
@@ -515,7 +515,7 @@  discard block
 block discarded – undo
515 515
 		);
516 516
 		foreach ( $field_cols as $col => $default ) {
517 517
 			$default           = $default === '' ? $field->{$col} : $default;
518
-			$new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
518
+			$new_field[$col] = isset( $values['field_options'][$col . '_' . $field->id] ) ? $values['field_options'][$col . '_' . $field->id] : $default;
519 519
 		}
520 520
 
521 521
 		if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
@@ -702,7 +702,7 @@  discard block
 block discarded – undo
702 702
 			if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
703 703
 				self::destroy( $form->id );
704 704
 				if ( empty( $form->parent_form_id ) ) {
705
-					++$count;
705
+					++ $count;
706 706
 				}
707 707
 			}
708 708
 
@@ -925,16 +925,16 @@  discard block
 block discarded – undo
925 925
 		foreach ( $results as $row ) {
926 926
 			if ( 'trash' != $row->status ) {
927 927
 				if ( $row->is_template ) {
928
-					++$counts['template'];
928
+					++ $counts['template'];
929 929
 				} else {
930
-					++$counts['published'];
930
+					++ $counts['published'];
931 931
 				}
932 932
 			} else {
933
-				++$counts['trash'];
933
+				++ $counts['trash'];
934 934
 			}
935 935
 
936 936
 			if ( 'draft' == $row->status ) {
937
-				++$counts['draft'];
937
+				++ $counts['draft'];
938 938
 			}
939 939
 
940 940
 			unset( $row );
@@ -975,8 +975,8 @@  discard block
 block discarded – undo
975 975
 			self::maybe_get_form( $form );
976 976
 		}
977 977
 
978
-		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
979
-			return $frm_vars['form_params'][ $form->id ];
978
+		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][$form->id] ) ) {
979
+			return $frm_vars['form_params'][$form->id];
980 980
 		}
981 981
 
982 982
 		$action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -1005,15 +1005,15 @@  discard block
 block discarded – undo
1005 1005
 			// If there are two forms on the same page, make sure not to submit both.
1006 1006
 			foreach ( $default_values as $var => $default ) {
1007 1007
 				if ( $var === 'action' ) {
1008
-					$values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1008
+					$values[$var] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1009 1009
 				} else {
1010
-					$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1010
+					$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1011 1011
 				}
1012 1012
 				unset( $var, $default );
1013 1013
 			}
1014 1014
 		} else {
1015 1015
 			foreach ( $default_values as $var => $default ) {
1016
-				$values[ $var ] = $default;
1016
+				$values[$var] = $default;
1017 1017
 				unset( $var, $default );
1018 1018
 			}
1019 1019
 		}
@@ -1039,7 +1039,7 @@  discard block
 block discarded – undo
1039 1039
 			'sdir'     => '',
1040 1040
 		);
1041 1041
 		foreach ( $defaults as $var => $default ) {
1042
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1042
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1043 1043
 		}
1044 1044
 
1045 1045
 		return $values;
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
 			'keep_post' => '',
1068 1068
 		);
1069 1069
 		foreach ( $defaults as $var => $default ) {
1070
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1070
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1071 1071
 		}
1072 1072
 
1073 1073
 		return $values;
@@ -1170,7 +1170,7 @@  discard block
 block discarded – undo
1170 1170
 		$form    = $atts['form'];
1171 1171
 		$default = isset( $atts['default'] ) ? $atts['default'] : '';
1172 1172
 
1173
-		return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
1173
+		return isset( $form->options[$atts['option']] ) ? $form->options[$atts['option']] : $default;
1174 1174
 	}
1175 1175
 
1176 1176
 	/**
Please login to merge, or discard this patch.
classes/models/FrmApplicationTemplate.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 		 *
38 38
 		 * @param array $keys
39 39
 		 */
40
-		self::$keys             = apply_filters(
40
+		self::$keys = apply_filters(
41 41
 			'frm_application_data_keys',
42 42
 			array( 'key', 'name', 'description', 'link', 'categories', 'views', 'forms', 'used_addons' )
43 43
 		);
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 			self::get_template_keys_with_local_png_images(),
46 46
 			self::get_template_keys_with_local_webp_images()
47 47
 		);
48
-		self::$categories       = array();
48
+		self::$categories = array();
49 49
 	}
50 50
 
51 51
 	/**
@@ -144,20 +144,20 @@  discard block
 block discarded – undo
144 144
 
145 145
 		$application = array();
146 146
 		foreach ( self::$keys as $key ) {
147
-			if ( ! isset( $this->api_data[ $key ] ) ) {
147
+			if ( ! isset( $this->api_data[$key] ) ) {
148 148
 				continue;
149 149
 			}
150 150
 
151
-			$value = $this->api_data[ $key ];
151
+			$value = $this->api_data[$key];
152 152
 
153 153
 			if ( 'icon' === $key ) {
154 154
 				// Icon is an array. The first array item is the image URL.
155
-				$application[ $key ] = reset( $value );
155
+				$application[$key] = reset( $value );
156 156
 			} elseif ( 'categories' === $key ) {
157
-				$application[ $key ] = array_values(
157
+				$application[$key] = array_values(
158 158
 					array_filter(
159 159
 						$value,
160
-						function ( $category ) {
160
+						function( $category ) {
161 161
 							return false === strpos( $category, '+Views' );
162 162
 						}
163 163
 					)
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 					// Strip off the " Template" text at the end of the name as it takes up space.
174 174
 					$value = substr( $value, 0, -9 );
175 175
 				}
176
-				$application[ $key ] = $value;
176
+				$application[$key] = $value;
177 177
 			}//end if
178 178
 		}//end foreach
179 179
 
Please login to merge, or discard this patch.