Completed
Pull Request — master (#2574)
by
unknown
39s
created
classes/models/FrmUsage.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 		);
127 127
 
128 128
 		foreach ( $skipped_keys as $skipped_key ) {
129
-			unset( $data[ $skipped_key ] );
129
+			unset( $data[$skipped_key] );
130 130
 		}
131 131
 
132 132
 		return $data;
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 
225 225
 		foreach ( $pass_settings as $setting ) {
226 226
 			if ( isset( $settings_list->$setting ) ) {
227
-				$settings[ $setting ] = $this->maybe_json( $settings_list->$setting );
227
+				$settings[$setting] = $this->maybe_json( $settings_list->$setting );
228 228
 			}
229 229
 		}
230 230
 
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
 
261 261
 		$message_settings = array();
262 262
 		foreach ( $messages as $message ) {
263
-			$message_settings[ 'changed-' . $message ] = $settings_list->$message === $default[ $message ] ? 0 : 1;
263
+			$message_settings['changed-' . $message] = $settings_list->$message === $default[$message] ? 0 : 1;
264 264
 		}
265 265
 
266 266
 		return $message_settings;
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 
281 281
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
282 282
 			if ( isset( $settings_list->$frm_role ) ) {
283
-				$permissions[ $frm_role ] = $settings_list->$frm_role;
283
+				$permissions[$frm_role] = $settings_list->$frm_role;
284 284
 			}
285 285
 		}
286 286
 
@@ -351,9 +351,9 @@  discard block
 block discarded – undo
351 351
 			);
352 352
 
353 353
 			foreach ( $settings as $setting ) {
354
-				if ( isset( $form->options[ $setting ] ) ) {
354
+				if ( isset( $form->options[$setting] ) ) {
355 355
 					if ( 'custom_style' === $setting ) {
356
-						$style->id = $form->options[ $setting ];
356
+						$style->id = $form->options[$setting];
357 357
 
358 358
 						if ( ! $style->id ) {
359 359
 							$style_name = 0;
@@ -364,9 +364,9 @@  discard block
 block discarded – undo
364 364
 							$style_name = $style_post ? $style_post->post_name : 'formidable-style';
365 365
 						}
366 366
 
367
-						$new_form[ $setting ] = $style_name;
367
+						$new_form[$setting] = $style_name;
368 368
 					} else {
369
-						$new_form[ $setting ] = $this->maybe_json( $form->options[ $setting ] );
369
+						$new_form[$setting] = $this->maybe_json( $form->options[$setting] );
370 370
 					}
371 371
 				}
372 372
 			}
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
 		$fields = FrmDb::get_results( 'frm_fields', array(), 'id, form_id, name, type, field_options', $args );
427 427
 		foreach ( $fields as $k => $field ) {
428 428
 			FrmAppHelper::unserialize_or_decode( $field->field_options );
429
-			$fields[ $k ]->field_options = json_encode( $field->field_options );
429
+			$fields[$k]->field_options = json_encode( $field->field_options );
430 430
 		}
431 431
 		return $fields;
432 432
 	}
Please login to merge, or discard this patch.
square/helpers/FrmSquareLiteConnectHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@
 block discarded – undo
160 160
 	 * @return object|string
161 161
 	 */
162 162
 	private static function post_to_connect_server( $action, $additional_body = array() ) {
163
-		$body    = array(
163
+		$body = array(
164 164
 			'frm_square_api_action' => $action,
165 165
 			'frm_square_api_mode'   => FrmSquareLiteAppHelper::active_mode(),
166 166
 		);
Please login to merge, or discard this patch.
classes/models/FrmValidate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 		}
50 50
 
51 51
 		$form = $this->get_form();
52
-		return ! empty( $form->options[ $key ] ) && 'off' !== $form->options[ $key ];
52
+		return ! empty( $form->options[$key] ) && 'off' !== $form->options[$key];
53 53
 	}
54 54
 
55 55
 	/**
Please login to merge, or discard this patch.
classes/helpers/FrmEntriesListHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 				'default' => 'id',
97 97
 			)
98 98
 		);
99
-		$order   = self::get_param(
99
+		$order = self::get_param(
100 100
 			array(
101 101
 				'param'   => 'order',
102 102
 				'default' => 'DESC',
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 			$form_ids              = $this->get_form_ids( $form_id );
149 149
 			$s_query['it.form_id'] = count( $form_ids ) > 1 ? $form_ids : $form_ids[0];
150 150
 		} else {
151
-			$s_query[]          = array(
151
+			$s_query[] = array(
152 152
 				'or'               => 1,
153 153
 				'parent_form_id'   => null,
154 154
 				'parent_form_id <' => 1,
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
 
316 316
 		$r = "<tr id='item-action-{$item->id}'$style>";
317 317
 
318
-		list( $columns, $hidden, , $primary ) = $this->get_column_info();
318
+		list( $columns, $hidden,, $primary ) = $this->get_column_info();
319 319
 		$action_col                           = false;
320 320
 		$action_columns                       = $this->get_action_columns();
321 321
 
Please login to merge, or discard this patch.
stripe/controllers/FrmStrpLiteHooksController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,10 +29,10 @@
 block discarded – undo
29 29
 		// This filter hides gateway fields from the entries list.
30 30
 		add_filter(
31 31
 			'frm_fields_in_entries_list_table',
32
-			function ( $form_cols ) {
32
+			function( $form_cols ) {
33 33
 				return array_filter(
34 34
 					$form_cols,
35
-					function ( $form_col ) {
35
+					function( $form_col ) {
36 36
 						return 'gateway' !== $form_col->type;
37 37
 					}
38 38
 				);
Please login to merge, or discard this patch.
square/models/FrmSquareLiteSettings.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -82,12 +82,12 @@
 block discarded – undo
82 82
 		$settings = $this->default_options();
83 83
 
84 84
 		foreach ( $settings as $setting => $default ) {
85
-			if ( isset( $params[ 'frm_' . $this->param() . '_' . $setting ] ) ) {
86
-				$this->settings->{$setting} = trim( sanitize_text_field( $params[ 'frm_' . $this->param() . '_' . $setting ] ) );
85
+			if ( isset( $params['frm_' . $this->param() . '_' . $setting] ) ) {
86
+				$this->settings->{$setting} = trim( sanitize_text_field( $params['frm_' . $this->param() . '_' . $setting] ) );
87 87
 			}
88 88
 		}
89 89
 
90
-		$this->settings->test_mode = isset( $params[ 'frm_' . $this->param() . '_test_mode' ] ) ? absint( $params[ 'frm_' . $this->param() . '_test_mode' ] ) : 0;
90
+		$this->settings->test_mode = isset( $params['frm_' . $this->param() . '_test_mode'] ) ? absint( $params['frm_' . $this->param() . '_test_mode'] ) : 0;
91 91
 	}
92 92
 
93 93
 	/**
Please login to merge, or discard this patch.
square/controllers/FrmSquareLiteAppController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -123,9 +123,9 @@  discard block
 block discarded – undo
123 123
 		$address_setting    = $action->post_content['billing_address'];
124 124
 
125 125
 		$entry      = self::generate_false_entry();
126
-		$first_name = $first_name_setting && isset( $entry->metas[ $first_name_setting ] ) ? $entry->metas[ $first_name_setting ] : '';
127
-		$last_name  = $last_name_setting && isset( $entry->metas[ $last_name_setting ] ) ? $entry->metas[ $last_name_setting ] : '';
128
-		$address    = $address_setting && isset( $entry->metas[ $address_setting ] ) ? $entry->metas[ $address_setting ] : '';
126
+		$first_name = $first_name_setting && isset( $entry->metas[$first_name_setting] ) ? $entry->metas[$first_name_setting] : '';
127
+		$last_name  = $last_name_setting && isset( $entry->metas[$last_name_setting] ) ? $entry->metas[$last_name_setting] : '';
128
+		$address    = $address_setting && isset( $entry->metas[$address_setting] ) ? $entry->metas[$address_setting] : '';
129 129
 
130 130
 		if ( is_array( $first_name ) && isset( $first_name['first'] ) ) {
131 131
 			$first_name = $first_name['first'];
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 		);
142 142
 
143 143
 		if ( $email_setting ) {
144
-			$shortcode_atts   = array(
144
+			$shortcode_atts = array(
145 145
 				'entry' => $entry,
146 146
 				'form'  => $action->menu_order,
147 147
 				'value' => $email_setting,
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 				if ( is_array( $v ) ) {
182 182
 					foreach ( $v as $f => $value ) {
183 183
 						FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
184
-						$entry->metas[ absint( $f ) ] = $value;
184
+						$entry->metas[absint( $f )] = $value;
185 185
 					}
186 186
 				}
187 187
 			} else {
Please login to merge, or discard this patch.
square/controllers/FrmSquareLiteActionsController.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -139,7 +139,8 @@  discard block
 block discarded – undo
139 139
 	 * @return string|true string on error, true on success.
140 140
 	 */
141 141
 	private static function trigger_one_time_payment( $atts ) {
142
-		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
142
+		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) {
143
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
143 144
 			return __( 'Please enter a valid credit card', 'formidable' );
144 145
 		}
145 146
 
@@ -199,7 +200,8 @@  discard block
 block discarded – undo
199 200
 	 * @return bool|string True on success, error message on failure
200 201
 	 */
201 202
 	private static function trigger_recurring_payment( $atts ) {
202
-		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
203
+		if ( empty( $_POST['square-token'] ) || empty( $_POST['square-verification-token'] ) ) {
204
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
203 205
 			return __( 'Please enter a valid credit card', 'formidable' );
204 206
 		}
205 207
 
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 			$gateway   = $payment_action->post_content['gateway'];
77 77
 			$is_square = $gateway === 'square' || ( is_array( $gateway ) && in_array( 'square', $gateway, true ) );
78 78
 			if ( ! $is_square || empty( $payment_action->post_content['amount'] ) ) {
79
-				unset( $payment_actions[ $k ] );
79
+				unset( $payment_actions[$k] );
80 80
 			}
81 81
 		}
82 82
 		return $payment_actions;
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 			'run_triggers' => false,
98 98
 			'show_errors'  => true,
99 99
 		);
100
-		$atts     = compact( 'action', 'entry', 'form' );
100
+		$atts = compact( 'action', 'entry', 'form' );
101 101
 
102 102
 		$amount = self::prepare_amount( $action->post_content['amount'], $atts );
103 103
 		if ( empty( $amount ) || $amount == 000 ) {
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 				'value' => $atts['action']->post_content['description'],
151 151
 			)
152 152
 		);
153
-		$result             = FrmSquareLiteConnectHelper::create_payment( $atts['amount'], $currency, $square_token, $verification_token, $description );
153
+		$result = FrmSquareLiteConnectHelper::create_payment( $atts['amount'], $currency, $square_token, $verification_token, $description );
154 154
 
155 155
 		if ( false === $result ) {
156 156
 			return FrmSquareLiteConnectHelper::get_latest_error_from_square_api();
@@ -455,7 +455,7 @@  discard block
 block discarded – undo
455 455
 			false
456 456
 		);
457 457
 
458
-		$square_vars     = array(
458
+		$square_vars = array(
459 459
 			'formId'     => $form_id,
460 460
 			'nonce'      => wp_create_nonce( 'frm_square_ajax' ),
461 461
 			'ajax'       => esc_url_raw( FrmAppHelper::get_ajax_url() ),
@@ -572,7 +572,7 @@  discard block
 block discarded – undo
572 572
 		$disallowed = array( ';', ':', '!important' );
573 573
 		foreach ( $settings as $k => $s ) {
574 574
 			if ( is_string( $s ) ) {
575
-				$settings[ $k ] = str_replace( $disallowed, '', $s );
575
+				$settings[$k] = str_replace( $disallowed, '', $s );
576 576
 			}
577 577
 		}
578 578
 
@@ -598,11 +598,11 @@  discard block
 block discarded – undo
598 598
 
599 599
 		$field_id = isset( $field->temp_id ) ? $field->temp_id : $field->id;
600 600
 
601
-		if ( isset( $errors[ 'field' . $field_id . '-cc' ] ) ) {
602
-			unset( $errors[ 'field' . $field_id . '-cc' ] );
601
+		if ( isset( $errors['field' . $field_id . '-cc'] ) ) {
602
+			unset( $errors['field' . $field_id . '-cc'] );
603 603
 		}
604
-		if ( isset( $errors[ 'field' . $field_id ] ) ) {
605
-			unset( $errors[ 'field' . $field_id ] );
604
+		if ( isset( $errors['field' . $field_id] ) ) {
605
+			unset( $errors['field' . $field_id] );
606 606
 		}
607 607
 
608 608
 		return $errors;
Please login to merge, or discard this patch.
stripe/controllers/FrmTransLiteActionsController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -472,8 +472,8 @@  discard block
 block discarded – undo
472 472
 			return $values;
473 473
 		}
474 474
 
475
-		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[ $field->id ] ) ) {
476
-			$values['value'] = $previous_entry->metas[ $field->id ];
475
+		if ( is_array( $previous_entry->metas ) && isset( $previous_entry->metas[$field->id] ) ) {
476
+			$values['value'] = $previous_entry->metas[$field->id];
477 477
 		}
478 478
 
479 479
 		$frm_vars['trans_filled'] = true;
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 			 * @param Closure    $destroy_callback
509 509
 			 * @return void
510 510
 			 */
511
-			function () use ( $entry_id, &$destroy_callback ) {
511
+			function() use ( $entry_id, &$destroy_callback ) {
512 512
 				FrmEntry::destroy( $entry_id );
513 513
 				// Only call this once.
514 514
 				remove_action( 'frm_entry_form', $destroy_callback );
@@ -528,7 +528,7 @@  discard block
 block discarded – undo
528 528
 	 * @return array
529 529
 	 */
530 530
 	public static function before_save_settings( $settings, $action ) {
531
-		$settings['gateway']  = ! empty( $settings['gateway'] ) ? (array) $settings['gateway'] : array( 'stripe' );
531
+		$settings['gateway'] = ! empty( $settings['gateway'] ) ? (array) $settings['gateway'] : array( 'stripe' );
532 532
 
533 533
 		if ( in_array( 'square', $settings['gateway'] ) ) {
534 534
 			$currency = FrmSquareLiteConnectHelper::get_merchant_currency();
Please login to merge, or discard this patch.