Strategy11 / formidable-forms

classes/models/FrmEntry.php

Spacing +19 added lines, -19 removed lines

@@ -80,7 +80,7 @@ 
 			$metas       = FrmEntryMeta::get_entry_meta_info( $entry_exist );
 			$field_metas = array();
 			foreach ( $metas as $meta ) {
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
+				$field_metas[$meta->field_id] = $meta->meta_value;
 			}
 
 			$filtered_vals = array_filter( $values['item_meta'] );
@@ -136,10 +136,10 @@ 
 		$reduced = array();
 		foreach ( $filter_vals as $field_id => $value ) {
 			$field                = FrmFieldFactory::get_field_object( $field_id );
-			$reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
-			$reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] );
-			if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) {
-				unset( $reduced[ $field_id ] );
+			$reduced[$field_id] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
+			$reduced[$field_id] = $field->set_value_before_save( $reduced[$field_id] );
+			if ( '' === $reduced[$field_id] || ( is_array( $reduced[$field_id] ) && 0 === count( $reduced[$field_id] ) ) ) {
+				unset( $reduced[$field_id] );
 			}
 		}
 		return $reduced;
@@ -354,7 +354,7 @@ 
 		$query = "SELECT it.*, fr.name as form_name, fr.form_key as form_key FROM {$wpdb->prefix}frm_items it
                   LEFT OUTER JOIN {$wpdb->prefix}frm_forms fr ON it.form_id=fr.id WHERE ";
 
-		$query      .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s';
+		$query .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s';
 		$query_args = array( $id );
 		$query      = $wpdb->prepare( $query, $query_args ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
 
@@ -399,7 +399,7 @@ 
 	private static function prepare_entries( &$entries ) {
 		foreach ( $entries as $k => $entry ) {
 			self::prepare_entry( $entry );
-			$entries[ $k ] = $entry;
+			$entries[$k] = $entry;
 		}
 	}
 
@@ -425,19 +425,19 @@ 
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
 
 			if ( $meta_val->item_id == $entry->id ) {
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
 				if ( $include_key ) {
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
 				}
 				continue;
 			}
 
 			// include sub entries in an array
-			if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) {
-				$entry->metas[ $meta_val->field_id ] = array();
+			if ( ! isset( $entry->metas[$meta_val->field_id] ) ) {
+				$entry->metas[$meta_val->field_id] = array();
 			}
 
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
 
 			unset( $meta_val );
 		}
@@ -484,7 +484,7 @@ 
 
 			if ( $inc_form ) {
 				$fields = 'it.*, fr.name as form_name,fr.form_key as form_key';
-				$table  .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id ';
+				$table .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id ';
 			}
 
 			if ( preg_match( '/ meta_([0-9]+)/', $order_by, $order_matches ) ) {
@@ -532,16 +532,16 @@ 
 		}
 
 		foreach ( $metas as $m_key => $meta_val ) {
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
 				continue;
 			}
 
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
-				$entries[ $meta_val->item_id ]->metas = array();
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
+				$entries[$meta_val->item_id]->metas = array();
 			}
 
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
 			unset( $m_key, $meta_val );
 		}
 
@@ -719,7 +719,7 @@ 
 	}
 
 	private static function get_entry_value( $values, $name, $default ) {
-		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
+		return isset( $values[$name] ) ? $values[$name] : $default;
 	}
 
 	/**
@@ -900,7 +900,7 @@ 
 	private static function maybe_add_captcha_meta( $form_id, $entry_id ) {
 		global $frm_vars;
 		if ( array_key_exists( 'captcha_scores', $frm_vars ) && array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) {
-			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] );
+			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][$form_id] );
 			FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) );
 		}
 	}

classes/helpers/FrmStringReaderHelper.php

Spacing +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
 
 		while ( $count > 0 && ! is_null( $one = $this->read_one() ) ) {
 			$value .= $one;
-			--$count;
+			-- $count;
 		}
 
 		return $this->strip_quotes( $value );
@@ -92,7 +92,7 @@ 
 	 */
 	private function read_one() {
 		if ( $this->pos <= $this->max ) {
-			$value = $this->string[ $this->pos ];
+			$value = $this->string[$this->pos];
 			$this->pos += 1;
 		} else {
 			$value = null;

classes/helpers/FrmSerializedStringParserHelper.php

Spacing +2 added lines, -2 removed lines

@@ -65,12 +65,12 @@
 				$string->read( 1 );
 
 				$val = array();
-				for ( $i = 0; $i < $count; $i++ ) {
+				for ( $i = 0; $i < $count; $i ++ ) {
 					$array_key   = $this->do_parse( $string );
 					$array_value = $this->do_parse( $string );
 
 					if ( ! is_array( $array_key ) ) {
-						$val[ $array_key ] = $array_value;
+						$val[$array_key] = $array_value;
 					}
 				}
 

classes/helpers/FrmOnSubmitHelper.php

Spacing +11 added lines, -11 removed lines

@@ -240,26 +240,26 @@ 
 	public static function populate_on_submit_data( &$form_options, $action = null, $event = 'create' ) {
 		$opt = 'update' === $event ? 'edit_' : 'success_';
 		if ( ! $action || ! is_object( $action ) ) {
-			$form_options[ $opt . 'action' ] = self::get_default_action_type();
-			$form_options[ $opt . 'msg' ]    = self::get_default_msg();
+			$form_options[$opt . 'action'] = self::get_default_action_type();
+			$form_options[$opt . 'msg']    = self::get_default_msg();
 
 			return;
 		}
 
-		$form_options[ $opt . 'action' ] = isset( $action->post_content['success_action'] ) ? $action->post_content['success_action'] : 'message';
+		$form_options[$opt . 'action'] = isset( $action->post_content['success_action'] ) ? $action->post_content['success_action'] : 'message';
 
-		switch ( $form_options[ $opt . 'action' ] ) {
+		switch ( $form_options[$opt . 'action'] ) {
 			case 'redirect':
-				$form_options[ $opt . 'url' ]    = isset( $action->post_content['success_url'] ) ? $action->post_content['success_url'] : '';
+				$form_options[$opt . 'url']    = isset( $action->post_content['success_url'] ) ? $action->post_content['success_url'] : '';
 				$form_options['open_in_new_tab'] = ! empty( $action->post_content['open_in_new_tab'] );
 				break;
 
 			case 'page':
-				$form_options[ $opt . 'page_id' ] = isset( $action->post_content['success_page_id'] ) ? $action->post_content['success_page_id'] : '';
+				$form_options[$opt . 'page_id'] = isset( $action->post_content['success_page_id'] ) ? $action->post_content['success_page_id'] : '';
 				break;
 
 			default:
-				$form_options[ $opt . 'msg' ] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : self::get_default_msg();
+				$form_options[$opt . 'msg'] = ! empty( $action->post_content['success_msg'] ) ? $action->post_content['success_msg'] : self::get_default_msg();
 				$form_options['show_form']    = ! empty( $action->post_content['show_form'] );
 		}
 	}
@@ -348,20 +348,20 @@ 
 	private static function get_on_submit_action_data_from_form_options( $form_options, $event = 'create' ) {
 		$opt  = 'update' === $event ? 'edit_' : 'success_';
 		$data = array(
-			'success_action' => isset( $form_options[ $opt . 'action' ] ) ? $form_options[ $opt . 'action' ] : self::get_default_action_type(),
+			'success_action' => isset( $form_options[$opt . 'action'] ) ? $form_options[$opt . 'action'] : self::get_default_action_type(),
 		);
 
 		switch ( $data['success_action'] ) {
 			case 'redirect':
-				$data['success_url'] = isset( $form_options[ $opt . 'url' ] ) ? $form_options[ $opt . 'url' ] : '';
+				$data['success_url'] = isset( $form_options[$opt . 'url'] ) ? $form_options[$opt . 'url'] : '';
 				break;
 
 			case 'page':
-				$data['success_page_id'] = isset( $form_options[ $opt . 'page_id' ] ) ? $form_options[ $opt . 'page_id' ] : '';
+				$data['success_page_id'] = isset( $form_options[$opt . 'page_id'] ) ? $form_options[$opt . 'page_id'] : '';
 				break;
 
 			default:
-				$data['success_msg'] = isset( $form_options[ $opt . 'msg' ] ) ? $form_options[ $opt . 'msg' ] : self::get_default_msg();
+				$data['success_msg'] = isset( $form_options[$opt . 'msg'] ) ? $form_options[$opt . 'msg'] : self::get_default_msg();
 				$data['show_form']   = ! empty( $form_options['show_form'] );
 		}
 

classes/controllers/FrmFormsController.php

Braces +14 added lines, -7 removed lines

@@ -1708,7 +1708,8 @@ 
 		$vars   = array();
 		FrmAppHelper::include_svg();
 
-		if ( isset( $_POST['frm_compact_fields'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $_POST['frm_compact_fields'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::permission_check( 'frm_edit_forms' );
 
 			// Javascript needs to be allowed in some field settings.
@@ -2018,7 +2019,8 @@ 
 	private static function maybe_get_form_to_show( $id ) {
 		$form = false;
 
-		if ( ! empty( $id ) ) { // form id or key is set
+		if ( ! empty( $id ) ) {
+// form id or key is set
 			$form = FrmForm::getOne( $id );
 			if ( ! $form || $form->parent_form_id || $form->status === 'trash' ) {
 				$form = false;
@@ -2103,7 +2105,8 @@ 
 	private static function get_saved_errors( $form, $params ) {
 		global $frm_vars;
 
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
 		} else {
 			$errors = array();
@@ -2294,7 +2297,8 @@ 
 			$action_type = FrmOnSubmitHelper::get_action_type( $action );
 
 			if ( 'redirect' === $action_type ) {
-				if ( $has_redirect ) { // Do not process because we run the first redirect action only.
+				if ( $has_redirect ) {
+// Do not process because we run the first redirect action only.
 					continue;
 				}
 			}
@@ -2523,12 +2527,14 @@ 
 
 		$doing_ajax = FrmAppHelper::doing_ajax();
 
-		if ( ! empty( $args['ajax'] ) && $doing_ajax && empty( $args['force_delay_redirect'] ) ) { // Is AJAX submit and there is just one Redirect action runs.
+		if ( ! empty( $args['ajax'] ) && $doing_ajax && empty( $args['force_delay_redirect'] ) ) {
+// Is AJAX submit and there is just one Redirect action runs.
 			echo json_encode( self::get_ajax_redirect_response_data( $args + compact( 'success_url' ) ) );
 			wp_die();
 		}
 
-		if ( ! headers_sent() && empty( $args['force_delay_redirect'] ) ) { // Not AJAX submit, no headers sent, and there is just one Redirect action runs.
+		if ( ! headers_sent() && empty( $args['force_delay_redirect'] ) ) {
+// Not AJAX submit, no headers sent, and there is just one Redirect action runs.
 			if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
 				self::print_open_in_new_tab_js_with_fallback_handler( $success_url, $args );
 				self::$redirected_in_new_tab[ $args['form']->id ] = 1;
@@ -2628,7 +2634,8 @@ 
 
 		echo FrmAppHelper::maybe_kses( $redirect_msg ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 		echo '<script>';
-		if ( empty( $args['doing_ajax'] ) ) { // Not AJAX submit, delay JS until window.load.
+		if ( empty( $args['doing_ajax'] ) ) {
+// Not AJAX submit, delay JS until window.load.
 			echo 'window.onload=function(){';
 		}
 		echo 'setTimeout(function(){' . $redirect_js . '}, ' . intval( $delay_time ) . ');'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped

Spacing +26 added lines, -26 removed lines

@@ -546,11 +546,11 @@ 
 			),
 		);
 
-		if ( ! isset( $available_status[ $status ] ) ) {
+		if ( ! isset( $available_status[$status] ) ) {
 			return;
 		}
 
-		FrmAppHelper::permission_check( $available_status[ $status ]['permission'] );
+		FrmAppHelper::permission_check( $available_status[$status]['permission'] );
 
 		$params = FrmForm::list_page_params();
 
@@ -558,7 +558,7 @@ 
 		check_admin_referer( $status . '_form_' . $params['id'] );
 
 		$count = 0;
-		if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
+		if ( FrmForm::set_status( $params['id'], $available_status[$status]['new_status'] ) ) {
 			$count ++;
 		}
 
@@ -575,7 +575,7 @@ 
 		/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 		$available_status['trash']['message']   = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
 
-		$message = $available_status[ $status ]['message'];
+		$message = $available_status[$status]['message'];
 
 		self::display_forms_list( $params, $message );
 	}
@@ -596,7 +596,7 @@ 
 				'type'  => 'request',
 			)
 		);
-		$message      = sprintf(
+		$message = sprintf(
 			/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 			_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
 			$count,
@@ -1145,7 +1145,7 @@ 
 
 		foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
 			if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
-				unset( $sections[ $feature ] );
+				unset( $sections[$feature] );
 			}
 		}
 
@@ -1178,7 +1178,7 @@ 
 				$section['id'] = $section['anchor'];
 			}
 
-			$sections[ $key ] = $section;
+			$sections[$key] = $section;
 		}
 
 		return $sections;
@@ -1296,7 +1296,7 @@ 
 		if ( ! empty( $user_fields ) ) {
 			$user_helpers = array();
 			foreach ( $user_fields as $uk => $uf ) {
-				$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
+				$user_helpers['|user_id| show="' . $uk . '"'] = $uf;
 				unset( $uk, $uf );
 			}
 
@@ -1435,7 +1435,7 @@ 
 		if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
 			$frm_vars['js_validate_forms'] = array();
 		}
-		$frm_vars['js_validate_forms'][ $form->id ] = $form;
+		$frm_vars['js_validate_forms'][$form->id] = $form;
 	}
 
 	public static function get_email_html() {
@@ -1594,7 +1594,7 @@ 
 				add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
 			} else {
 				$vars   = FrmAppHelper::json_to_array( $json_vars );
-				$action = $vars[ $action ];
+				$action = $vars[$action];
 				unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_POST    = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -1753,7 +1753,7 @@ 
 		$actions = array();
 		foreach ( $frm_vars['forms_loaded'] as $form ) {
 			if ( is_object( $form ) ) {
-				$actions[ $form->id ] = $form->name;
+				$actions[$form->id] = $form->name;
 			}
 			unset( $form );
 		}
@@ -1997,8 +1997,8 @@ 
 	private static function get_saved_errors( $form, $params ) {
 		global $frm_vars;
 
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$errors = $frm_vars['created_entries'][$form->id]['errors'];
 		} else {
 			$errors = array();
 		}
@@ -2020,7 +2020,7 @@ 
 	public static function just_created_entry( $form_id ) {
 		global $frm_vars;
 
-		return ( isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
+		return ( isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][$form_id] ) && isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ) ? $frm_vars['created_entries'][$form_id]['entry_id'] : 0;
 	}
 
 	/**
@@ -2040,7 +2040,7 @@ 
 	private static function get_confirmation_method( $atts ) {
 		$action = FrmOnSubmitHelper::current_event( $atts );
 		$opt    = 'update' === $action ? 'edit_action' : 'success_action';
-		$method = ( isset( $atts['form']->options[ $opt ] ) && ! empty( $atts['form']->options[ $opt ] ) ) ? $atts['form']->options[ $opt ] : 'message';
+		$method = ( isset( $atts['form']->options[$opt] ) && ! empty( $atts['form']->options[$opt] ) ) ? $atts['form']->options[$opt] : 'message';
 
 		if ( ! empty( $atts['entry_id'] ) ) {
 			$met_actions = self::get_met_on_submit_actions( $atts, $action );
@@ -2061,7 +2061,7 @@ 
 	public static function maybe_trigger_redirect( $form, $params, $args ) {
 		if ( ! isset( $params['id'] ) ) {
 			global $frm_vars;
-			$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
+			$params['id'] = $frm_vars['created_entries'][$form->id]['entry_id'];
 		}
 
 		$conf_method = self::get_confirmation_method(
@@ -2143,7 +2143,7 @@ 
 		$args['success_opt'] = $opt;
 		$args['ajax']        = ! empty( $frm_vars['ajax'] );
 
-		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[ $opt . '_page_id' ] ) ) {
+		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[$opt . '_page_id'] ) ) {
 			self::load_page_after_submit( $args );
 		} elseif ( $args['conf_method'] === 'redirect' ) {
 			self::redirect_after_submit( $args );
@@ -2167,7 +2167,7 @@ 
 		}
 
 		// If a redirect action has already opened the URL in a new tab, we show the default message in the currect tab.
-		if ( ! empty( self::$redirected_in_new_tab[ $args['form']->id ] ) ) {
+		if ( ! empty( self::$redirected_in_new_tab[$args['form']->id] ) ) {
 			return array( FrmOnSubmitHelper::get_fallback_action_after_open_in_new_tab( $event ) );
 		}
 
@@ -2354,7 +2354,7 @@ 
 
 		$opt = 'update' === $args['action'] ? 'edit_' : 'success_';
 
-		$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
+		$new_args['conf_method'] = $new_args['form']->options[$opt . 'action'];
 
 		/**
 		 * Filters the run success action args.
@@ -2374,8 +2374,8 @@ 
 	private static function load_page_after_submit( $args ) {
 		global $post;
 		$opt = $args['success_opt'];
-		if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
-			$page     = get_post( $args['form']->options[ $opt . '_page_id' ] );
+		if ( ! $post || $args['form']->options[$opt . '_page_id'] != $post->ID ) {
+			$page     = get_post( $args['form']->options[$opt . '_page_id'] );
 			$old_post = $post;
 			$post     = $page;
 			$content  = apply_filters( 'frm_content', $page->post_content, $args['form'], $args['entry_id'] );
@@ -2405,7 +2405,7 @@ 
 		add_filter( 'frm_use_wpautop', '__return_false' );
 
 		$opt         = $args['success_opt'];
-		$success_url = trim( $args['form']->options[ $opt . '_url' ] );
+		$success_url = trim( $args['form']->options[$opt . '_url'] );
 		$success_url = apply_filters( 'frm_content', $success_url, $args['form'], $args['entry_id'] );
 		$success_url = do_shortcode( $success_url );
 
@@ -2425,7 +2425,7 @@ 
 		if ( ! headers_sent() && empty( $args['force_delay_redirect'] ) ) { // Not AJAX submit, no headers sent, and there is just one Redirect action runs.
 			if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
 				self::print_open_in_new_tab_js_with_fallback_handler( $success_url, $args );
-				self::$redirected_in_new_tab[ $args['form']->id ] = 1;
+				self::$redirected_in_new_tab[$args['form']->id] = 1;
 				return;
 			}
 
@@ -2685,7 +2685,7 @@ 
 			'description' => false,
 			'reset'       => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 	}
 
 	/**
@@ -2723,7 +2723,7 @@ 
 		$opt          = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
 
 		if ( $entry_id && is_numeric( $entry_id ) ) {
-			$message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
+			$message = isset( $form->options[$opt . '_msg'] ) ? $form->options[$opt . '_msg'] : $frm_settings->success_msg;
 			$class   = 'frm_message';
 		} else {
 			$message = $frm_settings->failed_msg;
@@ -2947,7 +2947,7 @@ 
 
 		check_ajax_referer( 'frm_ajax', 'nonce' );
 
-		$html             = FrmAppHelper::clip(
+		$html = FrmAppHelper::clip(
 			function() {
 				FrmAppHelper::maybe_autocomplete_pages_options(
 					array(

classes/controllers/FrmSimpleBlocksController.php

Spacing +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
 			return false;
 		}
 
-		return $addons[ $addon_id ];
+		return $addons[$addon_id];
 	}
 
 	/**

classes/factories/FrmFieldFactory.php

Spacing +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
 			'credit_card' => 'FrmFieldCreditCard',
 		);
 
-		$class = isset( $type_classes[ $field_type ] ) ? $type_classes[ $field_type ] : '';
+		$class = isset( $type_classes[$field_type] ) ? $type_classes[$field_type] : '';
 
 		return apply_filters( 'frm_get_field_type_class', $class, $field_type );
 	}

classes/models/FrmField.php

Spacing +29 added lines, -29 removed lines

@@ -272,7 +272,7 @@ 
 		$values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
 
 		foreach ( array( 'name', 'description', 'type', 'default_value' ) as $col ) {
-			$new_values[ $col ] = $values[ $col ];
+			$new_values[$col] = $values[$col];
 		}
 
 		$new_values['options']       = self::maybe_filter_options( $values['options'] );
@@ -283,7 +283,7 @@ 
 		$new_values['created_at']    = current_time( 'mysql', 1 );
 
 		if ( isset( $values['id'] ) ) {
-			$frm_duplicate_ids[ $values['field_key'] ] = $new_values['field_key'];
+			$frm_duplicate_ids[$values['field_key']] = $new_values['field_key'];
 			$new_values                                = apply_filters( 'frm_duplicated_field', $new_values );
 		}
 
@@ -292,9 +292,9 @@ 
 		foreach ( $new_values as $k => $v ) {
 			if ( is_array( $v ) ) {
 				if ( $k === 'default_value' ) {
-					$new_values[ $k ] = FrmAppHelper::maybe_json_encode( $v );
+					$new_values[$k] = FrmAppHelper::maybe_json_encode( $v );
 				} else {
-					$new_values[ $k ] = serialize( $v );
+					$new_values[$k] = serialize( $v );
 				}
 			}
 			unset( $k, $v );
@@ -314,7 +314,7 @@ 
 		}
 
 		if ( isset( $values['id'] ) ) {
-			$frm_duplicate_ids[ $values['id'] ] = $new_id;
+			$frm_duplicate_ids[$values['id']] = $new_id;
 		}
 
 		return $new_id;
@@ -374,7 +374,7 @@ 
 	public static function duplicate( $old_form_id, $form_id, $copy_keys = false, $blog_id = false ) {
 		global $frm_duplicate_ids;
 
-		$where  = array(
+		$where = array(
 			array(
 				'or'                => 1,
 				'fi.form_id'        => $old_form_id,
@@ -420,8 +420,8 @@ 
 
 			$values                                 = apply_filters( 'frm_duplicated_field', $values );
 			$new_id                                 = self::create( $values );
-			$frm_duplicate_ids[ $field->id ]        = $new_id;
-			$frm_duplicate_ids[ $field->field_key ] = $new_id;
+			$frm_duplicate_ids[$field->id]        = $new_id;
+			$frm_duplicate_ids[$field->field_key] = $new_id;
 			unset( $field );
 		}
 	}
@@ -453,11 +453,11 @@ 
 
 		// serialize array values
 		foreach ( array( 'field_options', 'options' ) as $opt ) {
-			if ( isset( $values[ $opt ] ) && is_array( $values[ $opt ] ) ) {
+			if ( isset( $values[$opt] ) && is_array( $values[$opt] ) ) {
 				if ( 'field_options' === $opt ) {
-					$values[ $opt ] = self::maybe_filter_options( $values[ $opt ] );
+					$values[$opt] = self::maybe_filter_options( $values[$opt] );
 				}
-				$values[ $opt ] = serialize( $values[ $opt ] );
+				$values[$opt] = serialize( $values[$opt] );
 			}
 		}
 		if ( isset( $values['default_value'] ) && is_array( $values['default_value'] ) ) {
@@ -609,7 +609,7 @@ 
 				'id'        => $id,
 				'field_key' => $id,
 			);
-			$type  = FrmDb::get_var( 'frm_fields', $where, $col );
+			$type = FrmDb::get_var( 'frm_fields', $where, $col );
 		}
 
 		return $type;
@@ -635,7 +635,7 @@ 
 					continue;
 				}
 
-				$fields[ $result->id ] = $result;
+				$fields[$result->id] = $result;
 				$count ++;
 				if ( $limit == 1 ) {
 					$fields = $result;
@@ -681,7 +681,7 @@ 
 			$count  = 0;
 			foreach ( $results as $result ) {
 				$count ++;
-				$fields[ $result->id ] = $result;
+				$fields[$result->id] = $result;
 				if ( ! empty( $limit ) && $count >= $limit ) {
 					break;
 				}
@@ -750,7 +750,7 @@ 
 			}
 
 			if ( ! empty( $sub_fields ) ) {
-				$index        = $k + $index_offset;
+				$index = $k + $index_offset;
 				$index_offset += count( $sub_fields );
 				array_splice( $results, $index, 0, $sub_fields );
 			}
@@ -795,7 +795,7 @@ 
 		$query_type = ( $limit == ' LIMIT 1' || $limit == 1 ) ? 'row' : 'results';
 
 		if ( is_array( $where ) ) {
-			$args    = array(
+			$args = array(
 				'order_by' => $order_by,
 				'limit'    => $limit,
 			);
@@ -826,9 +826,9 @@ 
 				FrmDb::set_cache( $result->field_key, $result, 'frm_field' );
 
 				self::prepare_options( $result );
-				$results[ $r_key ]->field_options = $result->field_options;
-				$results[ $r_key ]->options       = $result->options;
-				$results[ $r_key ]->default_value = $result->default_value;
+				$results[$r_key]->field_options = $result->field_options;
+				$results[$r_key]->options       = $result->options;
+				$results[$r_key]->default_value = $result->default_value;
 
 				unset( $r_key, $result );
 			}
@@ -1030,23 +1030,23 @@ 
 	}
 
 	public static function is_option_true_in_array( $field, $option ) {
-		return isset( $field[ $option ] ) && $field[ $option ];
+		return isset( $field[$option] ) && $field[$option];
 	}
 
 	public static function is_option_true_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ];
+		return isset( $field->field_options[$option] ) && $field->field_options[$option];
 	}
 
 	public static function is_option_empty_in_array( $field, $option ) {
-		return ! isset( $field[ $option ] ) || empty( $field[ $option ] );
+		return ! isset( $field[$option] ) || empty( $field[$option] );
 	}
 
 	public static function is_option_empty_in_object( $field, $option ) {
-		return ! isset( $field->field_options[ $option ] ) || empty( $field->field_options[ $option ] );
+		return ! isset( $field->field_options[$option] ) || empty( $field->field_options[$option] );
 	}
 
 	public static function is_option_value_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ] != '';
+		return isset( $field->field_options[$option] ) && $field->field_options[$option] != '';
 	}
 
 	/**
@@ -1064,10 +1064,10 @@ 
 
 	public static function get_option_in_array( $field, $option ) {
 
-		if ( isset( $field[ $option ] ) ) {
-			$this_option = $field[ $option ];
-		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][ $option ] ) ) {
-			$this_option = $field['field_options'][ $option ];
+		if ( isset( $field[$option] ) ) {
+			$this_option = $field[$option];
+		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][$option] ) ) {
+			$this_option = $field['field_options'][$option];
 		} else {
 			$this_option = '';
 		}
@@ -1076,7 +1076,7 @@ 
 	}
 
 	public static function get_option_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) ? $field->field_options[ $option ] : '';
+		return isset( $field->field_options[$option] ) ? $field->field_options[$option] : '';
 	}
 
 	/**

classes/models/FrmFormAction.php

Spacing +44 added lines, -44 removed lines

@@ -5,15 +5,15 @@ 
 
 class FrmFormAction {
 
-	public $id_base;         // Root id for all actions of this type.
-	public $name;            // Name for this action type.
+	public $id_base; // Root id for all actions of this type.
+	public $name; // Name for this action type.
 	public $option_name;
-	public $action_options;  // Option array passed to wp_register_sidebar_widget()
+	public $action_options; // Option array passed to wp_register_sidebar_widget()
 	public $control_options; // Option array passed to wp_register_widget_control()
 
-	public $form_id;         // The ID of the form to evaluate
-	public $number = false;  // Unique ID number of the current instance.
-	public $id = '';         // Unique ID string of the current instance (id_base-number)
+	public $form_id; // The ID of the form to evaluate
+	public $number = false; // Unique ID number of the current instance.
+	public $id = ''; // Unique ID string of the current instance (id_base-number)
 	public $updated = false; // Set true when we update the data after a POST submit - makes sure we don't do it twice.
 
 	// Member functions that you must over-ride.
@@ -156,9 +156,9 @@ 
 		$groups = FrmFormActionsController::form_action_groups();
 		$group  = 'misc';
 
-		if ( isset( $action_options['group'] ) && isset( $groups[ $action_options['group'] ] ) ) {
+		if ( isset( $action_options['group'] ) && isset( $groups[$action_options['group']] ) ) {
 			$group = $action_options['group'];
-		} elseif ( isset( $groups[ $this->id_base ] ) ) {
+		} elseif ( isset( $groups[$this->id_base] ) ) {
 			$group = $this->id_base;
 		} else {
 			foreach ( $groups as $name => $check_group ) {
@@ -169,8 +169,8 @@ 
 			}
 		}
 
-		$groups[ $group ]['id'] = $group;
-		return $groups[ $group ];
+		$groups[$group]['id'] = $group;
+		return $groups[$group];
 	}
 
 	/**
@@ -280,7 +280,7 @@ 
 	 * @return integer $post_id
 	 */
 	public function maybe_create_action( $action, $forms ) {
-		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[ $action['menu_order'] ] ) && $forms[ $action['menu_order'] ] == 'updated' ) {
+		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[$action['menu_order']] ) && $forms[$action['menu_order']] == 'updated' ) {
 			// Update action only
 			$action['post_content'] = FrmAppHelper::maybe_json_decode( $action['post_content'] );
 			$post_id                = $this->save_settings( $action );
@@ -303,18 +303,18 @@ 
 		$switch             = $this->get_global_switch_fields();
 
 		foreach ( (array) $action->post_content as $key => $val ) {
-			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[ $val ] ) ) {
-				$action->post_content[ $key ] = $frm_duplicate_ids[ $val ];
+			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[$val] ) ) {
+				$action->post_content[$key] = $frm_duplicate_ids[$val];
 			} elseif ( ! is_array( $val ) ) {
-				$action->post_content[ $key ] = FrmFieldsHelper::switch_field_ids( $val );
-			} elseif ( isset( $switch[ $key ] ) && is_array( $switch[ $key ] ) ) {
+				$action->post_content[$key] = FrmFieldsHelper::switch_field_ids( $val );
+			} elseif ( isset( $switch[$key] ) && is_array( $switch[$key] ) ) {
 				// loop through each value if empty
-				if ( empty( $switch[ $key ] ) ) {
-					$switch[ $key ] = array_keys( $val );
+				if ( empty( $switch[$key] ) ) {
+					$switch[$key] = array_keys( $val );
 				}
 
-				foreach ( $switch[ $key ] as $subkey ) {
-					$action->post_content[ $key ] = $this->duplicate_array_walk( $action->post_content[ $key ], $subkey, $val );
+				foreach ( $switch[$key] as $subkey ) {
+					$action->post_content[$key] = $this->duplicate_array_walk( $action->post_content[$key], $subkey, $val );
 				}
 			}
 
@@ -332,20 +332,20 @@ 
 			foreach ( $subkey as $subkey2 ) {
 				foreach ( (array) $val as $ck => $cv ) {
 					if ( is_array( $cv ) ) {
-						$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey2, $cv );
-					} elseif ( isset( $cv[ $subkey ] ) && is_numeric( $cv[ $subkey ] ) && isset( $frm_duplicate_ids[ $cv[ $subkey ] ] ) ) {
-						$action[ $ck ][ $subkey ] = $frm_duplicate_ids[ $cv[ $subkey ] ];
+						$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey2, $cv );
+					} elseif ( isset( $cv[$subkey] ) && is_numeric( $cv[$subkey] ) && isset( $frm_duplicate_ids[$cv[$subkey]] ) ) {
+						$action[$ck][$subkey] = $frm_duplicate_ids[$cv[$subkey]];
 					}
 				}
 			}
 		} else {
 			foreach ( (array) $val as $ck => $cv ) {
 				if ( is_array( $cv ) ) {
-					$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey, $cv );
-				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[ $cv ] ) ) {
-					$action[ $ck ] = $frm_duplicate_ids[ $cv ];
+					$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey, $cv );
+				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[$cv] ) ) {
+					$action[$ck] = $frm_duplicate_ids[$cv];
 				} elseif ( $ck == $subkey ) {
-					$action[ $ck ] = $this->maybe_switch_field_ids( $action[ $ck ] );
+					$action[$ck] = $this->maybe_switch_field_ids( $action[$ck] );
 				}
 			}
 		}
@@ -369,10 +369,10 @@ 
 		}
 
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
-		if ( isset( $_POST[ $this->option_name ] ) && is_array( $_POST[ $this->option_name ] ) ) {
+		if ( isset( $_POST[$this->option_name] ) && is_array( $_POST[$this->option_name] ) ) {
 			// Sanitizing removes scripts and <email> type of values.
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
-			$settings = wp_unslash( $_POST[ $this->option_name ] );
+			$settings = wp_unslash( $_POST[$this->option_name] );
 		} else {
 			return;
 		}
@@ -382,7 +382,7 @@ 
 		foreach ( $settings as $number => $new_instance ) {
 			$this->_set( $number );
 
-			$old_instance = isset( $all_instances[ $number ] ) ? $all_instances[ $number ] : array();
+			$old_instance = isset( $all_instances[$number] ) ? $all_instances[$number] : array();
 
 			if ( ! isset( $new_instance['post_status'] ) ) {
 				$new_instance['post_status'] = 'draft';
@@ -421,7 +421,7 @@ 
 			$instance['post_content'] = apply_filters( 'frm_before_save_' . $this->id_base . '_action', $instance['post_content'], $instance, $new_instance, $old_instance, $this );
 
 			if ( false !== $instance ) {
-				$all_instances[ $number ] = $instance;
+				$all_instances[$number] = $instance;
 			}
 
 			$action_ids[] = $this->save_settings( $instance );
@@ -503,12 +503,12 @@ 
 			// some plugins/themes are formatting the post_excerpt
 			$action->post_excerpt = sanitize_title( $action->post_excerpt );
 
-			if ( ! isset( $action_controls[ $action->post_excerpt ] ) ) {
+			if ( ! isset( $action_controls[$action->post_excerpt] ) ) {
 				continue;
 			}
 
-			$action                  = $action_controls[ $action->post_excerpt ]->prepare_action( $action );
-			$settings[ $action->ID ] = $action;
+			$action                  = $action_controls[$action->post_excerpt]->prepare_action( $action );
+			$settings[$action->ID] = $action;
 
 			if ( count( $settings ) >= $limit ) {
 				break;
@@ -541,7 +541,7 @@ 
 			'limit'       => 99,
 			'post_status' => $default_status,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 	}
 
 	/**
@@ -607,7 +607,7 @@ 
 
 			$action = $this->prepare_action( $action );
 
-			$settings[ $action->ID ] = $action;
+			$settings[$action->ID] = $action;
 		}
 
 		if ( 1 === $limit ) {
@@ -650,10 +650,10 @@ 
 
 		foreach ( $default_values as $k => $vals ) {
 			if ( is_array( $vals ) && ! empty( $vals ) ) {
-				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[ $k ] ) ) {
+				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[$k] ) ) {
 					continue;
 				}
-				$action->post_content[ $k ] = wp_parse_args( $action->post_content[ $k ], $vals );
+				$action->post_content[$k] = wp_parse_args( $action->post_content[$k], $vals );
 			}
 		}
 
@@ -736,14 +736,14 @@ 
 	 * Migrate settings from form->options into new action.
 	 */
 	public function migrate_to_2( $form, $update = 'update' ) {
-		$action        = $this->prepare_new( $form->id );
+		$action = $this->prepare_new( $form->id );
 		FrmAppHelper::unserialize_or_decode( $form->options );
 
 		// fill with existing options
 		foreach ( $action->post_content as $name => $val ) {
-			if ( isset( $form->options[ $name ] ) ) {
-				$action->post_content[ $name ] = $form->options[ $name ];
-				unset( $form->options[ $name ] );
+			if ( isset( $form->options[$name] ) ) {
+				$action->post_content[$name] = $form->options[$name];
+				unset( $form->options[$name] );
 			}
 		}
 
@@ -809,7 +809,7 @@ 
 				$stop = $stop ? false : true;
 			}
 
-			$met[ $stop ] = $stop;
+			$met[$stop] = $stop;
 		}
 
 		if ( $notification['conditions']['any_all'] == 'all' && ! empty( $met ) && isset( $met[0] ) && isset( $met[1] ) ) {
@@ -863,8 +863,8 @@ 
 	private static function get_value_from_entry( $entry, $field_id ) {
 		$observed_value = '';
 
-		if ( isset( $entry->metas[ $field_id ] ) ) {
-			$observed_value = $entry->metas[ $field_id ];
+		if ( isset( $entry->metas[$field_id] ) ) {
+			$observed_value = $entry->metas[$field_id];
 		} elseif ( $entry->post_id && FrmAppHelper::pro_is_installed() ) {
 			$field          = FrmField::getOne( $field_id );
 			$observed_value = FrmProEntryMetaHelper::get_post_or_meta_value(