Completed
Pull Request — master (#1839)
by Stephanie
01:06
created
classes/models/FrmEmailStats.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
 		// Build total for each currency.
151 151
 		foreach ( $payment_data['total'] as $currency => $amount ) {
152
-			$stats[ 'payments_total_' . $currency ] = array(
152
+			$stats['payments_total_' . $currency] = array(
153 153
 				// translators: currency name.
154 154
 				'label'   => sprintf( __( 'Total %s', 'formidable' ), strtoupper( $currency ) ),
155 155
 				'count'   => $amount,
@@ -171,23 +171,23 @@  discard block
 block discarded – undo
171 171
 
172 172
 			// Compare total for each currency.
173 173
 			foreach ( $payment_data['total'] as $currency => $amount ) {
174
-				if ( ! isset( $prev_payment_data['total'][ $currency ] ) ) {
175
-					$stats[ 'payments_total_' . $currency ]['compare'] = 1;
174
+				if ( ! isset( $prev_payment_data['total'][$currency] ) ) {
175
+					$stats['payments_total_' . $currency]['compare'] = 1;
176 176
 					continue;
177 177
 				}
178 178
 
179
-				$stats[ 'payments_total_' . $currency ]['compare'] = $this->get_compare_diff( $amount, $prev_payment_data['total'][ $currency ] );
180
-				unset( $prev_payment_data['total'][ $currency ] );
179
+				$stats['payments_total_' . $currency]['compare'] = $this->get_compare_diff( $amount, $prev_payment_data['total'][$currency] );
180
+				unset( $prev_payment_data['total'][$currency] );
181 181
 			}
182 182
 
183 183
 			// If prev month has more currencies.
184 184
 			foreach ( $prev_payment_data['total'] as $currency => $amount ) {
185
-				$stats[ 'payments_total_' . $currency ] = array(
185
+				$stats['payments_total_' . $currency] = array(
186 186
 					// translators: currency name.
187 187
 					'label'   => sprintf( __( 'Total %s', 'formidable' ), strtoupper( $currency ) ),
188 188
 					'count'   => 0,
189 189
 					'display' => $this->get_formatted_price( 0, $currency ),
190
-					'compare' => -1,
190
+					'compare' => - 1,
191 191
 				);
192 192
 			}
193 193
 		}//end if
Please login to merge, or discard this patch.
classes/models/FrmFieldFormHtml.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
 	 * @param array  $atts
45 45
 	 */
46 46
 	private function _set( $param, $atts ) {
47
-		if ( isset( $atts[ $param ] ) ) {
48
-			$this->{$param} = $atts[ $param ];
47
+		if ( isset( $atts[$param] ) ) {
48
+			$this->{$param} = $atts[$param];
49 49
 		}
50 50
 	}
51 51
 
@@ -89,8 +89,8 @@  discard block
 block discarded – undo
89 89
 
90 90
 		$exclude = array( 'field_obj', 'html' );
91 91
 		foreach ( $exclude as $ex ) {
92
-			if ( isset( $atts[ $ex ] ) ) {
93
-				unset( $this->pass_args[ $ex ] );
92
+			if ( isset( $atts[$ex] ) ) {
93
+				unset( $this->pass_args[$ex] );
94 94
 			}
95 95
 		}
96 96
 	}
@@ -102,8 +102,8 @@  discard block
 block discarded – undo
102 102
 	 * @param array $set
103 103
 	 */
104 104
 	private function set_from_field( $atts, $set ) {
105
-		if ( isset( $atts[ $set['param'] ] ) ) {
106
-			$this->{$set['param']} = $atts[ $set['param'] ];
105
+		if ( isset( $atts[$set['param']] ) ) {
106
+			$this->{$set['param']} = $atts[$set['param']];
107 107
 		} else {
108 108
 			$this->{$set['param']} = $this->field_obj->get_field_column( $set['default'] );
109 109
 		}
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	 */
231 231
 	private function replace_error_shortcode() {
232 232
 		$this->maybe_add_error_id();
233
-		$error = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? $this->pass_args['errors'][ 'field' . $this->field_id ] : false;
233
+		$error = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? $this->pass_args['errors']['field' . $this->field_id] : false;
234 234
 
235 235
 		if ( ! empty( $error ) && false === strpos( $this->html, 'role="alert"' ) && FrmAppHelper::should_include_alert_role_on_field_errors() ) {
236 236
 			$error_body = self::get_error_body( $this->html );
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 	 * @since 3.06.02
272 272
 	 */
273 273
 	private function maybe_add_error_id() {
274
-		if ( ! isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
274
+		if ( ! isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
275 275
 			return;
276 276
 		}
277 277
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 		preg_match_all( "/\[(input|deletelink)\b(.*?)(?:(\/))?\]/s", $this->html, $shortcodes, PREG_PATTERN_ORDER );
352 352
 
353 353
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
354
-			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
354
+			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
355 355
 			$tag            = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
356 356
 
357 357
 			$replace_with = '';
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
 				$replace_with = $this->replace_input_shortcode( $shortcode_atts );
363 363
 			}
364 364
 
365
-			$this->html = str_replace( $shortcodes[0][ $short_key ], $replace_with, $this->html );
365
+			$this->html = str_replace( $shortcodes[0][$short_key], $replace_with, $this->html );
366 366
 		}
367 367
 	}
368 368
 
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 	 */
385 385
 	private function prepare_input_shortcode_atts( $shortcode_atts ) {
386 386
 		if ( isset( $shortcode_atts['opt'] ) ) {
387
-			--$shortcode_atts['opt'];
387
+			-- $shortcode_atts['opt'];
388 388
 		}
389 389
 
390 390
 		$field_class = isset( $shortcode_atts['class'] ) ? $shortcode_atts['class'] : '';
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
 			unset( $shortcode_atts['class'] );
395 395
 		}
396 396
 
397
-		$shortcode_atts['aria-invalid'] = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? 'true' : 'false';
397
+		$shortcode_atts['aria-invalid'] = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? 'true' : 'false';
398 398
 
399 399
 		$this->field_obj->set_field_column( 'shortcodes', $shortcode_atts );
400 400
 
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
 	 */
447 447
 	private function get_field_div_classes() {
448 448
 		// Add error class
449
-		$classes = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? ' frm_blank_field' : '';
449
+		$classes = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? ' frm_blank_field' : '';
450 450
 
451 451
 		// Add label position class
452 452
 		$settings = $this->field_obj->display_field_settings();
Please login to merge, or discard this patch.
classes/models/FrmUsage.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 
145 145
 		foreach ( $pass_settings as $setting ) {
146 146
 			if ( isset( $settings_list->$setting ) ) {
147
-				$settings[ $setting ] = $this->maybe_json( $settings_list->$setting );
147
+				$settings[$setting] = $this->maybe_json( $settings_list->$setting );
148 148
 			}
149 149
 		}
150 150
 
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 
179 179
 		$message_settings = array();
180 180
 		foreach ( $messages as $message ) {
181
-			$message_settings[ $message ] = $settings_list->$message;
181
+			$message_settings[$message] = $settings_list->$message;
182 182
 		}
183 183
 
184 184
 		return $message_settings;
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
200 200
 			if ( isset( $settings_list->$frm_role ) ) {
201
-				$permissions[ $frm_role ] = $settings_list->$frm_role;
201
+				$permissions[$frm_role] = $settings_list->$frm_role;
202 202
 			}
203 203
 		}
204 204
 
@@ -268,8 +268,8 @@  discard block
 block discarded – undo
268 268
 			);
269 269
 
270 270
 			foreach ( $settings as $setting ) {
271
-				if ( isset( $form->options[ $setting ] ) ) {
272
-					$new_form[ $setting ] = $this->maybe_json( $form->options[ $setting ] );
271
+				if ( isset( $form->options[$setting] ) ) {
272
+					$new_form[$setting] = $this->maybe_json( $form->options[$setting] );
273 273
 				}
274 274
 			}
275 275
 
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 		$fields = FrmDb::get_results( 'frm_fields', array(), 'form_id, name, type, field_options', $args );
329 329
 		foreach ( $fields as $k => $field ) {
330 330
 			FrmAppHelper::unserialize_or_decode( $field->field_options );
331
-			$fields[ $k ]->field_options = json_encode( $field->field_options );
331
+			$fields[$k]->field_options = json_encode( $field->field_options );
332 332
 		}
333 333
 		return $fields;
334 334
 	}
Please login to merge, or discard this patch.
classes/models/FrmPluginSearch.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -80,20 +80,20 @@  discard block
 block discarded – undo
80 80
 			'name'              => sprintf(
81 81
 				/* translators: Formidable addon name */
82 82
 				esc_html_x( 'Formidable %s', 'Formidable Addon Name', 'formidable' ),
83
-				$addon_list[ $matching_addon ]['name']
83
+				$addon_list[$matching_addon]['name']
84 84
 			),
85
-			'addon'             => $addon_list[ $matching_addon ]['slug'],
86
-			'short_description' => $addon_list[ $matching_addon ]['excerpt'],
85
+			'addon'             => $addon_list[$matching_addon]['slug'],
86
+			'short_description' => $addon_list[$matching_addon]['excerpt'],
87 87
 			'slug'              => self::$slug,
88
-			'version'           => $addon_list[ $matching_addon ]['version'],
88
+			'version'           => $addon_list[$matching_addon]['version'],
89 89
 		);
90 90
 
91
-		if ( ! empty( $addon_list[ $matching_addon ]['external'] ) ) {
91
+		if ( ! empty( $addon_list[$matching_addon]['external'] ) ) {
92 92
 			unset( $overrides['name'] );
93 93
 		}
94 94
 
95 95
 		// Splice in the base addon data.
96
-		$inject = array_merge( $inject, $addon_list[ $matching_addon ], $overrides );
96
+		$inject = array_merge( $inject, $addon_list[$matching_addon], $overrides );
97 97
 
98 98
 		// Add it to the top of the list.
99 99
 		array_unshift( $result->plugins, $inject );
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
 		// Plugin installed, active, feature not enabled; prompt to enable.
309 309
 		if ( ! $is_active && $is_installed ) {
310 310
 			if ( current_user_can( 'activate_plugins' ) ) {
311
-				$activate_url             = add_query_arg(
311
+				$activate_url = add_query_arg(
312 312
 					array(
313 313
 						'action'   => 'activate',
314 314
 						'_wpnonce' => wp_create_nonce( 'activate-plugin_' . $plugin['plugin'] ),
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
 	 */
353 353
 	protected function is_installed( $plugin ) {
354 354
 		$all_plugins = FrmAppHelper::get_plugins();
355
-		return isset( $all_plugins[ $plugin ] );
355
+		return isset( $all_plugins[$plugin] );
356 356
 	}
357 357
 
358 358
 	/**
Please login to merge, or discard this patch.
classes/models/FrmFormTemplateApi.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
 		$templates    = $this->get_api_info();
96 96
 		$contact_form = 20872734;
97
-		return isset( $templates[ $contact_form ] ) && ! empty( $templates[ $contact_form ]['url'] );
97
+		return isset( $templates[$contact_form] ) && ! empty( $templates[$contact_form]['url'] );
98 98
 	}
99 99
 
100 100
 	/**
@@ -169,15 +169,15 @@  discard block
 block discarded – undo
169 169
 					continue;
170 170
 				}
171 171
 
172
-				$data['urlByKey'][ $template['key'] ] = $template['url'];
172
+				$data['urlByKey'][$template['key']] = $template['url'];
173 173
 			}
174 174
 
175
-			if ( ! isset( $data['urlByKey'][ $key ] ) ) {
175
+			if ( ! isset( $data['urlByKey'][$key] ) ) {
176 176
 				$error = new WP_Error( 400, 'We were unable to retrieve the template' );
177 177
 				wp_send_json_error( $error );
178 178
 			}
179 179
 
180
-			$data['url'] = $data['urlByKey'][ $key ];
180
+			$data['url'] = $data['urlByKey'][$key];
181 181
 		}//end if
182 182
 
183 183
 		wp_send_json_success( $data );
Please login to merge, or discard this patch.
classes/models/FrmEntry.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 			$metas       = FrmEntryMeta::get_entry_meta_info( $entry_exist );
81 81
 			$field_metas = array();
82 82
 			foreach ( $metas as $meta ) {
83
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
83
+				$field_metas[$meta->field_id] = $meta->meta_value;
84 84
 			}
85 85
 
86 86
 			$filtered_vals = array_filter( $values['item_meta'] );
@@ -136,10 +136,10 @@  discard block
 block discarded – undo
136 136
 		$reduced = array();
137 137
 		foreach ( $filter_vals as $field_id => $value ) {
138 138
 			$field                = FrmFieldFactory::get_field_object( $field_id );
139
-			$reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
140
-			$reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] );
141
-			if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) {
142
-				unset( $reduced[ $field_id ] );
139
+			$reduced[$field_id] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
140
+			$reduced[$field_id] = $field->set_value_before_save( $reduced[$field_id] );
141
+			if ( '' === $reduced[$field_id] || ( is_array( $reduced[$field_id] ) && 0 === count( $reduced[$field_id] ) ) ) {
142
+				unset( $reduced[$field_id] );
143 143
 			}
144 144
 		}
145 145
 		return $reduced;
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
 	private static function prepare_entries( &$entries ) {
402 402
 		foreach ( $entries as $k => $entry ) {
403 403
 			self::prepare_entry( $entry );
404
-			$entries[ $k ] = $entry;
404
+			$entries[$k] = $entry;
405 405
 		}
406 406
 	}
407 407
 
@@ -427,19 +427,19 @@  discard block
 block discarded – undo
427 427
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
428 428
 
429 429
 			if ( $meta_val->item_id == $entry->id ) {
430
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
430
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
431 431
 				if ( $include_key ) {
432
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
432
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
433 433
 				}
434 434
 				continue;
435 435
 			}
436 436
 
437 437
 			// include sub entries in an array
438
-			if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) {
439
-				$entry->metas[ $meta_val->field_id ] = array();
438
+			if ( ! isset( $entry->metas[$meta_val->field_id] ) ) {
439
+				$entry->metas[$meta_val->field_id] = array();
440 440
 			}
441 441
 
442
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
442
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
443 443
 
444 444
 			unset( $meta_val );
445 445
 		}
@@ -534,16 +534,16 @@  discard block
 block discarded – undo
534 534
 		}
535 535
 
536 536
 		foreach ( $metas as $m_key => $meta_val ) {
537
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
537
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
538 538
 				continue;
539 539
 			}
540 540
 
541
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
542
-				$entries[ $meta_val->item_id ]->metas = array();
541
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
542
+				$entries[$meta_val->item_id]->metas = array();
543 543
 			}
544 544
 
545 545
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
546
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
546
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
547 547
 			unset( $m_key, $meta_val );
548 548
 		}
549 549
 
@@ -725,7 +725,7 @@  discard block
 block discarded – undo
725 725
 	}
726 726
 
727 727
 	private static function get_entry_value( $values, $name, $default ) {
728
-		return isset( $values[ $name ] ) ? $values[ $name ] : $default;
728
+		return isset( $values[$name] ) ? $values[$name] : $default;
729 729
 	}
730 730
 
731 731
 	/**
@@ -910,7 +910,7 @@  discard block
 block discarded – undo
910 910
 	private static function maybe_add_captcha_meta( $form_id, $entry_id ) {
911 911
 		global $frm_vars;
912 912
 		if ( array_key_exists( 'captcha_scores', $frm_vars ) && array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) {
913
-			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] );
913
+			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][$form_id] );
914 914
 			FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) );
915 915
 		}
916 916
 	}
Please login to merge, or discard this patch.
classes/controllers/FrmOverlayController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	private function update_next_execution_time() {
86 86
 		$config_option_name = $this->config['config-option-name'];
87 87
 
88
-		$this->options_data[ $config_option_name ] = $this->get_next_execution();
88
+		$this->options_data[$config_option_name] = $this->get_next_execution();
89 89
 		$this->update_options_data();
90 90
 	}
91 91
 
@@ -104,11 +104,11 @@  discard block
 block discarded – undo
104 104
 	 * @return bool
105 105
 	 */
106 106
 	private function is_time_to_execute() {
107
-		if ( ! isset( $this->options_data[ $this->config['config-option-name'] ] ) ) {
107
+		if ( ! isset( $this->options_data[$this->config['config-option-name']] ) ) {
108 108
 			return true;
109 109
 		}
110 110
 
111
-		$options = $this->options_data[ $this->config['config-option-name'] ];
111
+		$options = $this->options_data[$this->config['config-option-name']];
112 112
 
113 113
 		return ! ( isset( $options['timestamp'] ) && (int) $options['timestamp'] > $this->get_time() );
114 114
 	}
Please login to merge, or discard this patch.
classes/models/FrmEmail.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 		$to = $this->prepare_email_setting( $this->settings['email_to'], $user_id_args );
163 163
 		$to = $this->explode_emails( $to );
164 164
 
165
-		$where  = array(
165
+		$where = array(
166 166
 			'it.field_id !' => 0,
167 167
 			'it.item_id'    => $this->entry->id,
168 168
 		);
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 			'entry'     => $this->entry,
173 173
 			'form'      => $this->form,
174 174
 		);
175
-		$to     = apply_filters( 'frm_to_email', $to, $values, $this->form->id, $args );
175
+		$to = apply_filters( 'frm_to_email', $to, $values, $this->form->id, $args );
176 176
 
177 177
 		$this->to = array_unique( (array) $to );
178 178
 
@@ -702,11 +702,11 @@  discard block
 block discarded – undo
702 702
 				$name = trim( str_replace( $email, '', $val ) );
703 703
 			} else {
704 704
 				// If user enters a name without an email
705
-				unset( $recipients[ $key ] );
705
+				unset( $recipients[$key] );
706 706
 				continue;
707 707
 			}
708 708
 
709
-			$recipients[ $key ] = $this->format_from_email( $name, $email );
709
+			$recipients[$key] = $this->format_from_email( $name, $email );
710 710
 		}//end foreach
711 711
 
712 712
 		return $recipients;
@@ -856,7 +856,7 @@  discard block
 block discarded – undo
856 856
 				);
857 857
 
858 858
 				// Remove phone number from to addresses
859
-				unset( $this->to[ $key ] );
859
+				unset( $this->to[$key] );
860 860
 			}//end if
861 861
 		}//end foreach
862 862
 	}
Please login to merge, or discard this patch.
classes/helpers/FrmFieldsHelper.php 2 patches
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -228,7 +228,8 @@  discard block
 block discarded – undo
228 228
 	 * @param mixed  $value
229 229
 	 */
230 230
 	private static function get_posted_field_setting( $setting, &$value ) {
231
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
231
+		if ( ! isset( $_POST['field_options'][ $setting ] ) ) {
232
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
232 233
 			return;
233 234
 		}
234 235
 
@@ -1251,7 +1252,8 @@  discard block
 block discarded – undo
1251 1252
 
1252 1253
 		// Check posted vals before checking saved values
1253 1254
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
1254
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1255
+		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) {
1256
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1255 1257
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1256 1258
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1257 1259
 				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
@@ -1262,7 +1264,8 @@  discard block
 block discarded – undo
1262 1264
 			return $other_val;
1263 1265
 		}
1264 1266
 
1265
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1267
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) {
1268
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1266 1269
 			// For normal fields
1267 1270
 
1268 1271
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
Please login to merge, or discard this patch.
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 			if ( in_array( $type, array( 'data', 'lookup' ), true ) ) {
32 32
 				$values['field_options']['data_type'] = $setting;
33 33
 			} else {
34
-				$values['field_options'][ $setting ] = 1;
34
+				$values['field_options'][$setting] = 1;
35 35
 			}
36 36
 		}
37 37
 
@@ -165,10 +165,10 @@  discard block
 block discarded – undo
165 165
 		}
166 166
 
167 167
 		foreach ( $defaults as $opt => $default ) {
168
-			$values[ $opt ] = isset( $field->field_options[ $opt ] ) ? $field->field_options[ $opt ] : $default;
168
+			$values[$opt] = isset( $field->field_options[$opt] ) ? $field->field_options[$opt] : $default;
169 169
 
170 170
 			if ( $check_post ) {
171
-				self::get_posted_field_setting( $opt . '_' . $field->id, $values[ $opt ] );
171
+				self::get_posted_field_setting( $opt . '_' . $field->id, $values[$opt] );
172 172
 			}
173 173
 
174 174
 			unset( $opt, $default );
@@ -244,18 +244,18 @@  discard block
 block discarded – undo
244 244
 	 * @param mixed  $value
245 245
 	 */
246 246
 	private static function get_posted_field_setting( $setting, &$value ) {
247
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
247
+		if ( ! isset( $_POST['field_options'][$setting] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
248 248
 			return;
249 249
 		}
250 250
 
251 251
 		if ( strpos( $setting, 'html' ) !== false ) {
252 252
 			// Strip slashes from HTML but not regex or script tags.
253
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
253
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
254 254
 		} elseif ( strpos( $setting, 'format_' ) === 0 ) {
255 255
 			// TODO: Remove stripslashes on output, and use on input only.
256
-			$value = sanitize_text_field( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
256
+			$value = sanitize_text_field( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
257 257
 		} else {
258
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
258
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
259 259
 			FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
260 260
 		}
261 261
 	}
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 		$values['default_value'] = FrmAppHelper::maybe_json_encode( $field->default_value );
329 329
 
330 330
 		foreach ( array( 'name', 'description', 'type', 'field_order', 'field_options', 'required' ) as $col ) {
331
-			$values[ $col ] = $field->{$col};
331
+			$values[$col] = $field->{$col};
332 332
 		}
333 333
 	}
334 334
 
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
 		);
367 367
 
368 368
 		$msg = FrmField::get_option( $field, $error );
369
-		$msg = empty( $msg ) ? $defaults[ $error ]['part'] : $msg;
369
+		$msg = empty( $msg ) ? $defaults[$error]['part'] : $msg;
370 370
 		$msg = do_shortcode( $msg );
371 371
 
372 372
 		$msg = self::maybe_replace_substrings_with_field_name( $msg, $error, $field );
@@ -634,7 +634,7 @@  discard block
 block discarded – undo
634 634
 			'title'        => '',
635 635
 			'inside_class' => 'inside',
636 636
 		);
637
-		$args     = array_merge( $defaults, $args );
637
+		$args = array_merge( $defaults, $args );
638 638
 
639 639
 		include FrmAppHelper::plugin_path() . '/classes/views/frm-fields/back-end/inline-modal.php';
640 640
 	}
@@ -871,7 +871,7 @@  discard block
 block discarded – undo
871 871
 				continue;
872 872
 			}
873 873
 
874
-			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][ $short_key ] );
874
+			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][$short_key] );
875 875
 			$tag  = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
876 876
 
877 877
 			$atts['entry'] = $entry;
@@ -881,7 +881,7 @@  discard block
 block discarded – undo
881 881
 			if ( $replace_with !== null ) {
882 882
 				$replace_with = self::trigger_shortcode_atts( $replace_with, $atts );
883 883
 				self::sanitize_embedded_shortcodes( compact( 'entry' ), $replace_with );
884
-				$content = str_replace( $shortcodes[0][ $short_key ], $replace_with, $content );
884
+				$content = str_replace( $shortcodes[0][$short_key], $replace_with, $content );
885 885
 			}
886 886
 
887 887
 			unset( $atts, $replace_with );
@@ -899,7 +899,7 @@  discard block
 block discarded – undo
899 899
 		$supported_atts = array( 'remove_accents', 'sanitize', 'sanitize_url' );
900 900
 		$included_atts  = array_intersect( $supported_atts, array_keys( $atts ) );
901 901
 		foreach ( $included_atts as $included_att ) {
902
-			if ( '0' === $atts[ $included_att ] ) {
902
+			if ( '0' === $atts[$included_att] ) {
903 903
 				// Skip any option that uses 0 so sanitize_url=0 does not encode.
904 904
 				continue;
905 905
 			}
@@ -972,8 +972,8 @@  discard block
 block discarded – undo
972 972
 
973 973
 		$dynamic_default = array( 'admin_email', 'siteurl', 'frmurl', 'sitename', 'get', 'default-email', 'default-from-email' );
974 974
 
975
-		if ( isset( $shortcode_values[ $atts['tag'] ] ) ) {
976
-			$replace_with = $shortcode_values[ $atts['tag'] ];
975
+		if ( isset( $shortcode_values[$atts['tag']] ) ) {
976
+			$replace_with = $shortcode_values[$atts['tag']];
977 977
 		} elseif ( in_array( $atts['tag'], $dynamic_default, true ) ) {
978 978
 			$replace_with = self::dynamic_default_values( $atts['tag'], $atts );
979 979
 		} elseif ( $clean_tag === 'user_agent' ) {
@@ -1197,8 +1197,8 @@  discard block
 block discarded – undo
1197 1197
 			self::field_types_for_input( $single_input, $field_selection, $field_types );
1198 1198
 		} elseif ( in_array( $type, $multiple_input, true ) ) {
1199 1199
 			self::field_types_for_input( $multiple_input, $field_selection, $field_types );
1200
-		} elseif ( isset( $field_selection[ $type ] ) ) {
1201
-			$field_types[ $type ] = $field_selection[ $type ];
1200
+		} elseif ( isset( $field_selection[$type] ) ) {
1201
+			$field_types[$type] = $field_selection[$type];
1202 1202
 		}
1203 1203
 
1204 1204
 		$field_types = apply_filters( 'frm_switch_field_types', $field_types, compact( 'type', 'field_selection' ) );
@@ -1239,7 +1239,7 @@  discard block
 block discarded – undo
1239 1239
 		foreach ( $inputs as $input ) {
1240 1240
 			// This may not be set if a field type was removed using the frm_available_fields or frm_pro_available_fields filters.
1241 1241
 			if ( array_key_exists( $input, $fields ) ) {
1242
-				$field_types[ $input ] = $fields[ $input ];
1242
+				$field_types[$input] = $fields[$input];
1243 1243
 			}
1244 1244
 			unset( $input );
1245 1245
 		}
@@ -1272,7 +1272,7 @@  discard block
 block discarded – undo
1272 1272
 			'parent'  => false,
1273 1273
 			'pointer' => false,
1274 1274
 		);
1275
-		$args     = wp_parse_args( $args, $defaults );
1275
+		$args = wp_parse_args( $args, $defaults );
1276 1276
 
1277 1277
 		$opt_key   = $args['opt_key'];
1278 1278
 		$field     = $args['field'];
@@ -1288,25 +1288,25 @@  discard block
 block discarded – undo
1288 1288
 
1289 1289
 		// Check posted vals before checking saved values
1290 1290
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
1291
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1291
+		if ( $parent && isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1292 1292
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1293 1293
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1294
-				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1294
+				$other_val = isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ) : '';
1295 1295
 			} else {
1296
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1296
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1297 1297
 			}
1298 1298
 
1299 1299
 			return $other_val;
1300 1300
 		}
1301 1301
 
1302
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1302
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1303 1303
 			// For normal fields
1304 1304
 
1305 1305
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1306 1306
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1307
-				$other_val = isset( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1307
+				$other_val = isset( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ) : '';
1308 1308
 			} else {
1309
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1309
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1310 1310
 			}
1311 1311
 
1312 1312
 			return $other_val;
@@ -1316,8 +1316,8 @@  discard block
 block discarded – undo
1316 1316
 		if ( $field['type'] === 'checkbox' && is_array( $field['value'] ) ) {
1317 1317
 			// Check if there is an "other" val in saved value and make sure the
1318 1318
 			// "other" val is not equal to the Other checkbox option
1319
-			if ( isset( $field['value'][ $opt_key ] ) && $field['options'][ $opt_key ] != $field['value'][ $opt_key ] ) {
1320
-				$other_val = $field['value'][ $opt_key ];
1319
+			if ( isset( $field['value'][$opt_key] ) && $field['options'][$opt_key] != $field['value'][$opt_key] ) {
1320
+				$other_val = $field['value'][$opt_key];
1321 1321
 			}
1322 1322
 		} else {
1323 1323
 			/**
@@ -1329,8 +1329,8 @@  discard block
 block discarded – undo
1329 1329
 				// Multi-select dropdowns - key is not preserved
1330 1330
 				if ( is_array( $field['value'] ) ) {
1331 1331
 					$o_key = array_search( $temp_val, $field['value'] );
1332
-					if ( isset( $field['value'][ $o_key ] ) ) {
1333
-						unset( $field['value'][ $o_key ], $o_key );
1332
+					if ( isset( $field['value'][$o_key] ) ) {
1333
+						unset( $field['value'][$o_key], $o_key );
1334 1334
 					}
1335 1335
 				} elseif ( $temp_val == $field['value'] ) {
1336 1336
 					// For radio and regular dropdowns
@@ -1538,11 +1538,11 @@  discard block
 block discarded – undo
1538 1538
 			foreach ( $val as $k => $v ) {
1539 1539
 				if ( is_string( $v ) ) {
1540 1540
 					if ( 'custom_html' === $k ) {
1541
-						$val[ $k ] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
1541
+						$val[$k] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
1542 1542
 						unset( $k, $v );
1543 1543
 						continue;
1544 1544
 					}
1545
-					$val[ $k ] = str_replace( $replace, $replace_with, $v );
1545
+					$val[$k] = str_replace( $replace, $replace_with, $v );
1546 1546
 					unset( $k, $v );
1547 1547
 				}
1548 1548
 			}
@@ -1571,8 +1571,8 @@  discard block
 block discarded – undo
1571 1571
 			if ( false === $index ) {
1572 1572
 				continue;
1573 1573
 			}
1574
-			unset( $replace[ $index ] );
1575
-			unset( $replace_with[ $index ] );
1574
+			unset( $replace[$index] );
1575
+			unset( $replace_with[$index] );
1576 1576
 		}
1577 1577
 		$value = str_replace( $replace, $replace_with, $value );
1578 1578
 		return $value;
@@ -1920,7 +1920,7 @@  discard block
 block discarded – undo
1920 1920
 			$countries['class'] = 'frm-countries-opts';
1921 1921
 		}
1922 1922
 
1923
-		$prepop[ __( 'Countries', 'formidable' ) ] = $countries;
1923
+		$prepop[__( 'Countries', 'formidable' )] = $countries;
1924 1924
 
1925 1925
 		// State abv.
1926 1926
 		$states    = self::get_us_states();
@@ -1930,7 +1930,7 @@  discard block
 block discarded – undo
1930 1930
 			$state_abv['class'] = 'frm-state-abv-opts';
1931 1931
 		}
1932 1932
 
1933
-		$prepop[ __( 'U.S. State Abbreviations', 'formidable' ) ] = $state_abv;
1933
+		$prepop[__( 'U.S. State Abbreviations', 'formidable' )] = $state_abv;
1934 1934
 
1935 1935
 		// States.
1936 1936
 		$states = array_values( $states );
@@ -1939,7 +1939,7 @@  discard block
 block discarded – undo
1939 1939
 			$states['class'] = 'frm-states-opts';
1940 1940
 		}
1941 1941
 
1942
-		$prepop[ __( 'U.S. States', 'formidable' ) ] = $states;
1942
+		$prepop[__( 'U.S. States', 'formidable' )] = $states;
1943 1943
 		unset( $state_abv, $states );
1944 1944
 
1945 1945
 		// Age.
@@ -1957,7 +1957,7 @@  discard block
 block discarded – undo
1957 1957
 			$ages['class'] = 'frm-age-opts';
1958 1958
 		}
1959 1959
 
1960
-		$prepop[ __( 'Age', 'formidable' ) ] = $ages;
1960
+		$prepop[__( 'Age', 'formidable' )] = $ages;
1961 1961
 
1962 1962
 		// Satisfaction.
1963 1963
 		$satisfaction = array(
@@ -1972,7 +1972,7 @@  discard block
 block discarded – undo
1972 1972
 			$satisfaction['class'] = 'frm-satisfaction-opts';
1973 1973
 		}
1974 1974
 
1975
-		$prepop[ __( 'Satisfaction', 'formidable' ) ] = $satisfaction;
1975
+		$prepop[__( 'Satisfaction', 'formidable' )] = $satisfaction;
1976 1976
 
1977 1977
 		// Importance.
1978 1978
 		$importance = array(
@@ -1987,7 +1987,7 @@  discard block
 block discarded – undo
1987 1987
 			$importance['class'] = 'frm-importance-opts';
1988 1988
 		}
1989 1989
 
1990
-		$prepop[ __( 'Importance', 'formidable' ) ] = $importance;
1990
+		$prepop[__( 'Importance', 'formidable' )] = $importance;
1991 1991
 
1992 1992
 		// Agreement.
1993 1993
 		$agreement = array(
@@ -2002,7 +2002,7 @@  discard block
 block discarded – undo
2002 2002
 			$agreement['class'] = 'frm-agreement-opts';
2003 2003
 		}
2004 2004
 
2005
-		$prepop[ __( 'Agreement', 'formidable' ) ] = $agreement;
2005
+		$prepop[__( 'Agreement', 'formidable' )] = $agreement;
2006 2006
 
2007 2007
 		// Likely.
2008 2008
 		$likely = array(
@@ -2017,7 +2017,7 @@  discard block
 block discarded – undo
2017 2017
 			$likely['class'] = 'frm-likely-opts';
2018 2018
 		}
2019 2019
 
2020
-		$prepop[ __( 'Likely', 'formidable' ) ] = $likely;
2020
+		$prepop[__( 'Likely', 'formidable' )] = $likely;
2021 2021
 
2022 2022
 		$prepop = apply_filters( 'frm_bulk_field_choices', $prepop );
2023 2023
 	}
@@ -2238,16 +2238,16 @@  discard block
 block discarded – undo
2238 2238
 	 */
2239 2239
 	private static function fill_image_setting_options( $options, &$args ) {
2240 2240
 		foreach ( $options as $key => $option ) {
2241
-			$args['options'][ $key ] = $option;
2241
+			$args['options'][$key] = $option;
2242 2242
 
2243 2243
 			if ( ! empty( $option['addon'] ) ) {
2244
-				$args['options'][ $key ]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2244
+				$args['options'][$key]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2245 2245
 			}
2246 2246
 
2247
-			unset( $args['options'][ $key ]['addon'] );
2247
+			unset( $args['options'][$key]['addon'] );
2248 2248
 			$fill = array( 'upgrade', 'message', 'content' );
2249 2249
 			foreach ( $fill as $f ) {
2250
-				unset( $args['options'][ $key ][ $f ], $f );
2250
+				unset( $args['options'][$key][$f], $f );
2251 2251
 			}
2252 2252
 		}
2253 2253
 	}
@@ -2268,8 +2268,8 @@  discard block
 block discarded – undo
2268 2268
 
2269 2269
 		$fill = array( 'upgrade', 'message', 'content' );
2270 2270
 		foreach ( $fill as $f ) {
2271
-			if ( isset( $option[ $f ] ) ) {
2272
-				$custom_attrs[ 'data-' . $f ] = $option[ $f ];
2271
+			if ( isset( $option[$f] ) ) {
2272
+				$custom_attrs['data-' . $f] = $option[$f];
2273 2273
 			}
2274 2274
 		}
2275 2275
 
@@ -2335,7 +2335,7 @@  discard block
 block discarded – undo
2335 2335
 
2336 2336
 		return array_filter(
2337 2337
 			$rows,
2338
-			function ( $row ) {
2338
+			function( $row ) {
2339 2339
 				FrmAppHelper::unserialize_or_decode( $row->field_options );
2340 2340
 				return is_array( $row->field_options ) && ! empty( $row->field_options['draft'] );
2341 2341
 			}
Please login to merge, or discard this patch.